Skip to content

London | May-2026-itp | Vitalii Kmit | Sprint 2 | Book library#554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vitalii-code wants to merge 17 commits into
base:main
Choose a base branch
from
Open

London | May-2026-itp | Vitalii Kmit | Sprint 2 | Book library #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8eaa64a
Fix errors
Vitalii-code Aug 14, 2026
b7a0641
Display author and check correclty
Vitalii-code Aug 14, 2026
c27230b
Convert script into module
Vitalii-code Aug 15, 2026
d9215d8
apply suggestions from https://validator.w3.org
Vitalii-code Aug 15, 2026
b9b0ab3
Add html validation
Vitalii-code Aug 16, 2026
7f4447e
Change page count to Integer
Vitalii-code Aug 16, 2026
a1f2494
Trim input text
Vitalii-code Aug 16, 2026
31bfa27
Use textContent instead of innerHTML
Vitalii-code Aug 16, 2026
6a4344b
Make render() more efficient
Vitalii-code Aug 16, 2026
7cd2449
Make variables more consistent
Vitalii-code Aug 16, 2026
c81cdb8
use const instead of let for non-reassigned variables
Vitalii-code Aug 16, 2026
03672e3
refactor: clean up script.js per code review feedback
Vitalii-code Aug 16, 2026
026b2af
Declare variables at the top of the file
Vitalii-code Aug 17, 2026
6525196
Check for decimal numbers
Vitalii-code Aug 17, 2026
a58e76e
Use ternary operator
Vitalii-code Aug 17, 2026
12ccc8d
Use form to enable validation
Vitalii-code Aug 17, 2026
2473edb
Remove dead code
Vitalii-code Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 53 additions & 53 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
<!DOCTYPE html>
<html>
<!doctype html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<title>Book library</title>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
Expand All@@ -16,60 +13,64 @@
/>
<link rel="stylesheet" type="text/css" href="style.css" />
</head>

<body>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>

<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<form>
<div id="demo" class="collapse">
<div class="form-group" id="bookForm">
<label for="title">Title:</label>
<input
type="text"
class="form-control"
id="title"
name="title"
minlength="1"
maxlength="100"
required
/>
<label for="author">Author: </label>
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
type="text"
class="form-control"
id="author"
name="author"
minlength="1"
maxlength="100"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
min="1"
max="20000"
step="1"
required
/>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
name="read"
value="true"
/>Read
</label>
<button type="submit" id="addBook" class="btn btn-primary">
Submit
</button>
</div>
</div>
</div>

</form>
<table class="table" id="display">
<thead class="thead-dark">
<tr>
Expand All@@ -90,7 +91,6 @@ <h1>Library</h1>
</tr>
</tbody>
</table>

<script src="script.js"></script>
<script src="script.js" type="module"></script>
</body>
</html>
131 changes: 74 additions & 57 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,21 @@
let myLibrary = [];
const myLibrary = [];

const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const checkInput = document.getElementById("check");

document.querySelector("form").addEventListener("submit", (e) => {
e.preventDefault();

const form = e.target;
if (!form.checkValidity()) {
form.reportValidity();
return;
}

addBook();
});

window.addEventListener("load", function (e) {
populateStorage();
Expand All@@ -7,38 +24,43 @@ window.addEventListener("load", function (e) {

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
const book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);
const book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
function addBook() {
const cleanTitle = titleInput.value.trim();
const cleanAuthor = authorInput.value.trim();
const pageCount = Number(pagesInput.value);

if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
cleanTitle == "" ||
cleanAuthor == "" ||
pagesInput.value.trim() == "" ||
Number.isNaN(pageCount) ||
Comment thread
cjyuan marked this conversation as resolved.
!Number.isInteger(pageCount) ||
pageCount <= 0
Comment on lines +49 to +52

@cjyuancjyuanAug 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Two of these checks are optional (redundant).

) {
alert("Please fill all fields!");
alert("Please fill all fields correctly!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
const book = new Book(
cleanTitle,
cleanAuthor,
pageCount,
checkInput.checked
);
myLibrary.push(book);
render();
}
}
Expand All@@ -50,54 +72,49 @@ function Book(title, author, pages, check) {
this.check = check;
}

function showMessage(text) {
const msg = document.createElement("div");
msg.className = "alert alert-info";
msg.textContent = text;
document.body.prepend(msg);
setTimeout(() => msg.remove(), 3000);
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
const tbody = document.querySelector("#display tbody");
tbody.innerHTML = "";

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
const length = myLibrary.length;
for (let i = 0; i < length; i++) {
const row = tbody.insertRow();
const titleCell = row.insertCell(0);
const authorCell = row.insertCell(1);
const pagesCell = row.insertCell(2);
const wasReadCell = row.insertCell(3);
const deleteCell = row.insertCell(4);
titleCell.textContent = myLibrary[i].title;
authorCell.textContent = myLibrary[i].author;
pagesCell.textContent = myLibrary[i].pages;

changeBut.addEventListener("click", function () {
const changeButton = document.createElement("button");
changeButton.className = "btn btn-success";
wasReadCell.appendChild(changeButton);
let readStatus = myLibrary[i].check ? "Yes" : "No";
changeButton.textContent = readStatus;
changeButton.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
const deleteButton = document.createElement("button");
deleteCell.appendChild(deleteButton);
deleteButton.className = "btn btn-warning";
deleteButton.textContent = "Delete";
deleteButton.addEventListener("click", function () {
const deletedTitle = myLibrary[i].title;
myLibrary.splice(i, 1);
render();
showMessage(`You've deleted title: ${deletedTitle}`);
});
}
}
2 changes: 1 addition & 1 deletion debugging/book-library/style.css
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
.form-group {
width: 400px;
height: 300px;
align-self: left;
align-self: center;
padding-left: 20px;
}

Expand Down
Loading