London | ITPMay2026 | Mahbubur Rahman | Sprint 1 | Form Controls by mahbubur13 · Pull Request #1267 · CodeYourFuture/Module-JavaScript-Fundamentals

mahbubur13 · 2026-05-14T15:37:30Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have completed the form controls assignment and updated the html and css. I have also met all the necessary requirements.

netlify · 2026-05-14T15:37:38Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`39ec8c8`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a297bee0dda260008ac4103
😎 Deploy Preview	https://deploy-preview-1267--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 85 (🔴 down 1 from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sambuxc · 2026-05-20T16:16:18Z

You should also add 2 other labels to your PR. Please check which ones and please add them

Sambuxc · 2026-05-20T16:18:49Z

One thing to mention regarding your commit message "Created a folder" isn't really a relevant message. It's better to relate it to the code changes made, for example;

Adds headline html and content
Updates title styles
Refactors article content
Removes unused css
Cleans up html formatting

Sambuxc · 2026-05-20T16:21:07Z

+ </div>
+ <div>
+ <lable type="text" for= "email">email</lable>
+ <input type="email" id="email" pattern=".&@yahoo.co.uk" size="30" required />


Have you tested that this pattern works?

@mahbubur13 Have you seen this comment?

I have corrected the email verification

cjyuan · 2026-05-31T21:51:11Z

@Sambuxc
What's the current status of this PR?

@mahbubur13
Have you made any changes based on the reviewer's comment? I don't see any new commits on this PR branch. If you have made commits on your computer, you need to push them to GitHub.

Sambuxc

Please check these comments and also you need to add missing labels

Sambuxc · 2026-06-01T15:13:51Z

+ </div>
+ <div>
+ <lable type="text" for= "email">email</lable>
+ <input type="email" id="email" pattern=".&@yahoo.co.uk" size="30" required />


@mahbubur13 Have you seen this comment?

cjyuan · 2026-06-09T13:29:09Z

@mahbubur13

Commit messages should be about the changes made. To communicate with the reviewer, use comments instead.

Currently, it is not immediately clear if you have addressed the latest comments: https://github.com/CodeYourFuture/Module-Onboarding/pull/1267#pullrequestreview-4402379541

Note: Leaving a comment in the comment box at the bottom of the page can help preserve the conversation in a chronological timeline.

mahbubur13 · 2026-06-09T13:46:09Z

I have checked all the comments and implemented all the changes required @Sambuxc

cjyuan · 2026-06-10T14:54:57Z

@Sambuxc Because the deadline to complete all PRs in the Onboarding module is tomorrow, hope you don't mind I step in and continue giving review to this PR.

@mahbubur13

The changes you made to the HTML code looks good.
In one of your recent commits, you modified Wireframe/style.css (which is not related to this exercise). Can you revert the changes made to that file? Otherwise the Validation bot will reject your PR.
Can you format the checkboxes in your PR description the way you formatted them in your Wireframe PR?
The Changelist description does not quite tell people what you have changed in your PR. Can you make the description more informative?

mahbubur13 · 2026-06-10T15:03:49Z

@cjyuan can you please check for me

cjyuan · 2026-06-10T15:07:02Z

Changes looks good.

I completed the assignment does not quite tell people what you have changed in this PR. Can you make the description more informative? I will mark this PR as "Complete" first.

cjyuan

A few more minor issues. Can you address them when you have time (even after the deadline)?

This PR has already marked "Complete", so you don't need to use the "Needs review" label on this PR anymore, just respond via comments will do.

cjyuan · 2026-06-10T15:08:26Z

- <!-- change to your name-->
- <p>By HOMEWORK SOLUTION</p>
+ <p>By HOMEWORK SOLUTION</p>


Note: Should have also updated this.

cjyuan · 2026-06-10T15:10:29Z

+ </div>
+ <fieldset>
+ <legend>Please select favourite colour:</legend>
+ <input type="radio" class="colour" id="red" name="fav_color" value="red">
+ <label for="red">Red</label><br>
+ <input type="radio" class="colour" id="blue" name="fav_color" value="blue">
+ <label for="blue">Blue</label><br>
+ <input type="radio" class="colour" name="fav_color" id="green" value="green">
+ <label for="green">Green</label><br>
+ </fieldset>
+ <div>


Indentation is slightly off.
Note: Your formatting is already very good. Using a formatter with "Format on Save" would save you time, ensure 100% consistency, and automatically clean up things like trailing whitespace and unnecessary empty lines. This also helps keep Git diffs and pull requests cleaner by reducing formatting-only changes, making it easier to review the actual code changes.
For more info about enabling "Format on save" option on VS Code, please refer to this guide.

cjyuan · 2026-06-10T15:11:05Z

+ </div>
+ <div>
+ <label for="email">Email</label>
+ <input type="email" name="email" id="email" size="30" required />


Why set size to 30?

mahbubur13 · 2026-06-10T15:13:27Z

@cjyuan now that I have completed the form controls will my step be completed on the CYF portal

illicitonion · 2026-08-24T09:40:38Z

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

created a folder
08b7b55

This comment has been minimized.
Sign in to view

mahbubur13 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 14, 2026

This comment has been minimized.
Sign in to view

github-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 14, 2026

mahbubur13 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 20, 2026

Sambuxc reviewed May 20, 2026
View reviewed changes

Comment threadForm-Controls/index.html

Sambuxc reviewed May 20, 2026
View reviewed changes

Comment threadForm-Controls/index.html Outdated

Sambuxc added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 20, 2026

I made the changes requested of message
5e99b77

mahbubur13 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 1, 2026

Sambuxc reviewed Jun 5, 2026
View reviewed changes

Sambuxc added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 5, 2026

mahbubur13 mentioned this pull request Jun 6, 2026
ITP-May_26 | Onboarding | Mahbubur Rahman mahbubur13/My-Coursework-Planner#15
Open

I have corrected the email verification
2ffa1bd

mahbubur13 requested a review from Sambuxc June 9, 2026 14:10

mahbubur13 added 2 commits June 10, 2026 15:26

changed the html
6773491

added minimum length on html
d178a2f

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 10, 2026

This comment has been minimized.
Sign in to view

reverted changes to wireframe
39ec8c8

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 10, 2026

cjyuan reviewed Jun 10, 2026
View reviewed changes

illicitonion closed this Aug 24, 2026

Uh oh!

Uh oh!

Conversation

mahbubur13 commented May 14, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

netlifyBot commented May 14, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Sambuxc commented May 20, 2026

Uh oh!

Sambuxc commented May 20, 2026

Uh oh!

Uh oh!

SambuxcMay 20, 2026

Choose a reason for hiding this comment

Uh oh!

SambuxcJun 1, 2026

Choose a reason for hiding this comment

Uh oh!

mahbubur13Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan commented May 31, 2026

Uh oh!

Sambuxc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SambuxcJun 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan commented Jun 9, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mahbubur13 commented Jun 9, 2026

Uh oh!

cjyuan commented Jun 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

mahbubur13 commented Jun 10, 2026

Uh oh!

cjyuan commented Jun 10, 2026

Uh oh!

cjyuan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuanJun 10, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuanJun 10, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuanJun 10, 2026

Choose a reason for hiding this comment

Uh oh!

mahbubur13 commented Jun 10, 2026

Uh oh!

illicitonion commented Aug 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mahbubur13 commented May 14, 2026•
edited
Loading

netlifyBot commented May 14, 2026•
edited
Loading

Sambuxc left a comment •
edited
Loading

cjyuan commented Jun 9, 2026•
edited
Loading

cjyuan commented Jun 10, 2026•
edited
Loading

cjyuan left a comment •
edited
Loading