Skip to content

London | ITPMay2026 | Mahbubur Rahman | Sprint 1 | Form Controls#1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mahbubur13 wants to merge 6 commits into from
Closed

London | ITPMay2026 | Mahbubur Rahman | Sprint 1 | Form Controls #1267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
08b7b55
created a folder
mahbubur13 May 14, 2026
5e99b77
I made the changes requested of message
mahbubur13 Jun 1, 2026
2ffa1bd
I have corrected the email verification
mahbubur13 Jun 9, 2026
6773491
changed the html
mahbubur13 Jun 10, 2026
d178a2f
added minimum length on html
mahbubur13 Jun 10, 2026
39ec8c8
reverted changes to wireframe
mahbubur13 Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 37 additions & 8 deletions Form-Controls/index.html
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,22 +6,51 @@
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link rel="stylesheet" href="style.css">
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<form action="#" method="POST">
<div>
<label for="name">Name</label>
<input type="text" name="name" id="name" placeholder="name" pattern="(\s*[^\s]\s*){2,}" minlength="2" title="Name must contain at least two letters or characters." required>
</div>
<div>
<label for="email">Email</label>
<input type="email" name="email" id="email" size="30" required />

@cjyuancjyuanJun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why set size to 30?

</div>
<fieldset>
<legend>Please select favourite colour:</legend>
<input type="radio" class="colour" id="red" name="fav_color" value="red">
<label for="red">Red</label><br>
<input type="radio" class="colour" id="blue" name="fav_color" value="blue">
<label for="blue">Blue</label><br>
<input type="radio" class="colour" name="fav_color" id="green" value="green">
<label for="green">Green</label><br>
</fieldset>
<div>
Comment on lines +24 to +34

@cjyuancjyuanJun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Indentation is slightly off.

Note: Your formatting is already very good. Using a formatter with "Format on Save" would save you time, ensure 100% consistency, and automatically clean up things like trailing whitespace and unnecessary empty lines. This also helps keep Git diffs and pull requests cleaner by reducing formatting-only changes, making it easier to review the actual code changes.

For more info about enabling "Format on save" option on VS Code, please refer to this guide.

<p>Please select your relevant size</p>
<label for="clothing-size">Choose a size:</label>
<!-- Added a placeholder option and a 6th size (XXL) -->
<select id="clothing-size" name="size" required>
<option value="" disabled selected hidden>-- Select a size --</option>
<option value="xs">XS - Extra Small</option>
<option value="s">S - Small</option>
<option value="m">M - Medium</option>
<option value="l">L - Large</option>
<option value="xl">XL - Extra Large</option>
<option value="xxl">XXL - Double Extra Large</option>
</select>
</div>
<button type="reset">Reset</button>
<button type="submit">Submit</button>
</form>
</main>
</main>
Comment thread
mahbubur13 marked this conversation as resolved.
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
<p>By HOMEWORK SOLUTION</p>
Comment on lines -23 to +53

@cjyuancjyuanJun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Should have also updated this.

</footer>
</body>
</html>
11 changes: 11 additions & 0 deletions Form-Controls/style.css
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
#name {
height: 24px;
}

#email {
height: 24px;
}
.colour {
height: 24px;
width: 24px;
}
Loading