Uh oh!
There was an error while loading. Please reload this page.
Manchester | 26-ITP-May | Yee Man Tsang | Sprint 1 | Form Controls - #1338
Manchester | 26-ITP-May | Yee Man Tsang | Sprint 1 | Form Controls#1338lintsang wants to merge 14 commits into
Conversation
Pull request from Feature/form controls
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Luro91
left a comment
There was a problem hiding this comment.
How can you get the SEO score of lighthouse to 100?
| Person name and email</legend> | ||
| <div class="form-group"> | ||
| <label for="fullname">Full Name:</label> | ||
| <input type="text" id="fullname" required minlength="2"> |
There was a problem hiding this comment.
I am not sure if you should check the checkboxes here or just in the PR
There was a problem hiding this comment.
Thanks for reminder. Sorry I did the same in Sprint 2. I will not touch it in Sprint 3
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
Luro91
left a comment
There was a problem hiding this comment.
Well done. I appliled the completed label now
Learners, PR Template
Self checklist
Changelist
Created a form that fulfilled all the requirements