Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 500
Manchester | 26-ITP-May | Yee Man Tsang | Sprint 1 | Form Controls#1338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
657c3d217f876a196b3435da6e4f6e51f8e462ce6ba67be9db1cdf635691b522af122a7dfbf5b4466770dec48ebdd64a9dFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| h1{ | ||
| font-family: 'Times New Roman', Times, serif; | ||
| font-size: 1.5rem; | ||
| } | ||
| fieldset{ | ||
| background-color: #becce2; | ||
| border: 2px solid #c0cde0; | ||
| border-style: solid; | ||
| border-radius: 0.5em; | ||
| margin: 1em auto; | ||
| padding: 1em; | ||
| width: 40em; | ||
| max-width: 800px; | ||
| } | ||
| legend{ | ||
| color: #222; | ||
| background-color: #f6f9ff; | ||
| font-size: 90%; | ||
| padding: 1em 2em; | ||
| border: solid 1px #becce2; | ||
| border-radius: 0.3em; | ||
| } | ||
| fieldset > div{ | ||
| padding: 0.5em 3em; | ||
| display: grid; | ||
| grid-template-columns: 2fr 4fr; | ||
| } | ||
| input, select, button{ | ||
| border: solid 1px #becce2; | ||
| padding: 4px; | ||
| font-size: 1em; | ||
| border-radius: 0.3em; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -3,25 +3,59 @@ | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <title>My form exercise</title> | ||
| <title>My Sprint 1 form controls exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <link rel="stylesheet" href="css/style.css"> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| </header> | ||
| <main> | ||
| <form> | ||
| <!-- write your html here--> | ||
| <fieldset> | ||
| <legend> | ||
| Person name and email</legend> | ||
| <div class="form-group"> | ||
| <label for="fullname">Full Name:</label> | ||
| <input type="text" id="fullname" required minlength="2"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well done on the validation | ||
| </div> | ||
| <div class="form-group"> | ||
| <label for="email">Email:</label> | ||
| <input type="email" id="email" required pattern="^.+@.+\..+$"> | ||
| </div> | ||
| <div class="form-group"> | ||
| <label for="colour-pick">Choose T-shirt Colour:</label> | ||
| <select id="colour-pick"> | ||
| <option value="white">White</option> | ||
| <option value="black">Black</option> | ||
| <option value="grey">Grey</option> | ||
| </select> | ||
| </div> | ||
| <div class="form-group"> | ||
| <label for="size-pick">Choose T-shisrt Size</label> | ||
| <select id="size-pick"> | ||
| <option value="xs">XS</option> | ||
| <option value="s">S</option> | ||
| <option value="m">M</option> | ||
| <option value="l">L</option> | ||
| <option value="xl">XL</option> | ||
| <option value="xxl">XXL</option> | ||
| </select> | ||
| </div> | ||
| <div class="form-group"> | ||
| <button type="submit">Submit</button> | ||
| </div> | ||
| </fieldset> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| Create a form that can collect | ||
| name, email, preferred tshirt colour and size from user--> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <p>By HOMEWORK SOLUTION</p> | ||
| <p>By Lin Tsang</p> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if you should check the checkboxes here or just in the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reminder. Sorry I did the same in Sprint 2. I will not touch it in Sprint 3