Skip to content

🎨 Palette: 혼합 문자열(BiDi)을 위한 dir="auto" 적용 - #435

Closed
seonghobae wants to merge 4 commits into
masterfrom
palette-bidi-fix-534433647654614168
Closed

🎨 Palette: 혼합 문자열(BiDi)을 위한 dir="auto" 적용#435
seonghobae wants to merge 4 commits into
masterfrom
palette-bidi-fix-534433647654614168

Conversation

@seonghobae

@seonghobaeseonghobae commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

변경

사용자가 만든 디렉터리명과 파일명을 표시하는 <h1> 및 가시적 이름 <span>dir="auto"를 적용합니다. 링크 URL, aria-label, title 계약은 변경하지 않습니다.

사용자 효과

아랍어·히브리어와 숫자·라틴 확장자가 섞인 이름도 주변 한국어/LTR 문맥에 일방적으로 끌려가지 않고 각 이름의 첫 강한 문자 방향을 기준으로 표시됩니다.

검증

  • 혼합 방향 디렉터리명 دليل-2026
  • 혼합 방향 파일명 דוח-report.txt
  • 제목과 가시적 파일명에 dir="auto"가 생성되는지 검증
  • 기존 한국어 aria-label과 파일명이 보존되는지 검증
  • Unicode UAX 🛡️ Sentinel: [HIGH] Fix XSS vulnerability #9, WHATWG dir 계약 및 W3C 국제화 지침을 docs/doctoring/bidirectional-file-name-rendering.md에 APA 7th 형식으로 추적
  • current-head CI·보안·독립 리뷰를 통과한 뒤에만 병합

PR created automatically by Jules for task 534433647654614168 started by @seonghobae

디렉토리 이름이나 파일 이름에 아랍어, 히브리어 등 오른쪽에서 왼쪽으로 쓰는(RTL)
문자가 포함된 경우, 기존의 왼쪽에서 오른쪽으로 쓰는(LTR) 기본 HTML 문서 흐름 내에서
문자열이 올바르게 렌더링되지 않는 문제가 발생할 수 있습니다 (예: 확장자나 기호의 위치
오류).
이 커밋은 사용자 텍스트가 렌더링되는 `<h1>` 태그(디렉토리 이름)와 `<span>` 태그(파일
이름)에 `dir="auto"` 속성을 추가하여 브라우저가 해당 요소 내의 텍스트 언어 및 방향을
자동으로 인식하고 올바르게 격리하여 표시할 수 있도록 합니다.
이 변경 사항은 테스트(MainTest.kt)에도 반영되었으며 코드베이스의 100% 테스트
커버리지가 유지됩니다.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitaiBot commented Aug 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in:95 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c4f6a4ea-0d07-4921-9646-885c922b120d

📥 Commits

Reviewing files that changed from the base of the PR and between 35c0668 and 0e54b9f.

📒 Files selected for processing (5)
  • .jules/palette.md
  • docs/doctoring/bidirectional-file-name-rendering.md
  • src/main/kotlin/html4tree/main.kt
  • src/test/kotlin/html4tree/BidiRenderingTest.kt
  • src/test/kotlin/html4tree/MainTest.kt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

디렉토리 이름이나 파일 이름에 아랍어, 히브리어 등 오른쪽에서 왼쪽으로 쓰는(RTL)
문자가 포함된 경우, 기존의 왼쪽에서 오른쪽으로 쓰는(LTR) 기본 HTML 문서 흐름 내에서
문자열이 올바르게 렌더링되지 않는 문제가 발생할 수 있습니다 (예: 확장자나 기호의 위치
오류).
이 커밋은 사용자 텍스트가 렌더링되는 `<h1>` 태그(디렉토리 이름)와 `<span>` 태그(파일
이름)에 `dir="auto"` 속성을 추가하여 브라우저가 해당 요소 내의 텍스트 언어 및 방향을
자동으로 인식하고 올바르게 격리하여 표시할 수 있도록 합니다.
이 변경 사항은 테스트(MainTest.kt)에도 반영되었으며 코드베이스의 100% 테스트
커버리지가 유지됩니다.
@seonghobaeChatGPT Codex Connector

Copy link
Copy Markdown
CollaboratorAuthor

Superseded by #447 after exact-head comparison. The canonical branch now contains this PR’s BiDi production behavior (dir="auto" on the generated heading and visible entry names), the same mixed-direction acceptance test, and the same standards/doctoring artifact byte-for-byte. #447 also preserves the accessible-label contract and adds the required no-follow attribute recheck before rendering, so no unique valuable implementation or acceptance evidence remains here. Closing this older overlapping lane to keep one integration owner; #447 still requires its own exact-head gates and independent review before merge.

auto-merge was automatically disabled August 14, 2026 23:01

Pull request was closed

@google-labs-jules

Copy link
Copy Markdown

Superseded by #447 after exact-head comparison. The canonical branch now contains this PR’s BiDi production behavior (dir="auto" on the generated heading and visible entry names), the same mixed-direction acceptance test, and the same standards/doctoring artifact byte-for-byte. #447 also preserves the accessible-label contract and adds the required no-follow attribute recheck before rendering, so no unique valuable implementation or acceptance evidence remains here. Closing this older overlapping lane to keep one integration owner; #447 still requires its own exact-head gates and independent review before merge.

Understood. Acknowledging that this work is now obsolete as it has been superseded by #447, and stopping work on this task.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@seonghobae