Skip to content

🎨 Palette: 파일 및 디렉토리 이름을 위한 양방향(BiDi) 텍스트 지원 개선 - #441

Closed
seonghobae wants to merge 1 commit into
masterfrom
palette/bidi-support-16949444116762561958
Closed

🎨 Palette: 파일 및 디렉토리 이름을 위한 양방향(BiDi) 텍스트 지원 개선#441
seonghobae wants to merge 1 commit into
masterfrom
palette/bidi-support-16949444116762561958

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

💡 What: 디렉토리 이름이나 파일 이름 등을 표시하는 동적 요소(<h1>, <span>)에 dir="auto" 속성을 추가했습니다.
🎯 Why: 아랍어, 히브리어 등 RTL(Right-To-Left) 언어로 된 디렉토리/파일 이름이 전체 LTR 레이아웃 내에 섞여 있을 때 브라우저가 적절히 방향을 파악하여 렌더링할 수 있도록 돕습니다. 이를 통해 전역적인 언어 방향성과 충돌하지 않는 향상된 사용자 경험과 다국어 접근성을 제공합니다.
📸 Before/After: 시각적으로 변경되지는 않으나, 내부 구조적으로 RTL 문자의 순서가 올바르게 표시됩니다.
♿ Accessibility: 양방향(Bidirectional) 텍스트의 정확한 표시를 보장하여 스크린 리더 및 시각적 브라우징 환경에서 텍스트의 가독성 및 정확도를 크게 개선했습니다.


PR created automatically by Jules for task 16949444116762561958 started by @seonghobae

- `<h1>`와 `<span>`에 `dir="auto"` 속성 추가 (RTL/LTR 혼합 텍스트를 위한 브라우저 자동 양방향 텍스트 렌더링 지원)
- 관련 테스트의 HTML 문자열 검증(`assertTrue`) 업데이트
- `.jules/palette.md`에 BiDi 처리 관련 배운 점(Learning) 기록 추가
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in:117 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8ec59e96-08a6-4fe2-88eb-77dfb4942bed

📥 Commits

Reviewing files that changed from the base of the PR and between 35c0668 and 533a12c.

📒 Files selected for processing (4)
  • .jules/palette.md
  • src/main/kotlin/html4tree/main.kt
  • src/test/kotlin/html4tree/GeneratedIndexReadabilityTest.kt
  • src/test/kotlin/html4tree/MainTest.kt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobaeChatGPT Codex Connector

Copy link
Copy Markdown
CollaboratorAuthor

이 PR은 #435의 dir="auto" 변경과 중복이며, 정적인 상위 경로 표시 ..에까지 방향 자동 판정을 추가해 변경 범위가 더 큽니다. 사용자 생성 디렉토리명·파일명에만 BiDi 격리를 적용하는 #435를 기준으로 유지하고 이 PR은 중복 종료합니다.

@google-labs-jules

Copy link
Copy Markdown

이 PR은 #435의 dir="auto" 변경과 중복이며, 정적인 상위 경로 표시 ..에까지 방향 자동 판정을 추가해 변경 범위가 더 큽니다. 사용자 생성 디렉토리명·파일명에만 BiDi 격리를 적용하는 #435를 기준으로 유지하고 이 PR은 중복 종료합니다.

Understood. Acknowledging that this work is now obsolete as it duplicates #435 with a larger scope, and stopping work on this task.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@seonghobae