feat: add canon_traditions meta table + validator (#1539) by CraigBuckmaster · Pull Request #1587 · CraigBuckmaster/ScriptureDeepDive

CraigBuckmaster · 2026-04-23T12:01:45Z

What this does

Introduces the canon_traditions meta table — schema for the four major canonical traditions (Protestant, Catholic, Eastern Orthodox, Ethiopian Tewahedo). Seeds content/meta/canon_traditions.json as an empty array; the four seeded entries land in HWGTB-P1-05 (#1542).

Closes

Closes#1539

Changes

New filecontent/meta/canon_traditions.json — empty array.
_tools/build_sqlite_schema.py — CREATE TABLE canon_traditions + idx_canon_traditions_sort.
_tools/build_sqlite_loaders.py — populate_canon_traditions() loader.
_tools/build_sqlite.py — loader imported + registered in pipeline.
_tools/schema_validator.py — new CANON TRADITIONS section:
- Required keys: id, label, book_count, canon_list
- id is snake_case and unique
- book_count equals the total canon_list[].books[] length
- canon_list[].books[] validated per the issue. Books outside books.json (deuterocanon, pseudepigrapha, etc.) are tolerated with an informational log — they're expected for non-Protestant traditions — provided they pass the snake_case id shape.
_tools/validate_sqlite.py — DB-side book_count vs canon_list_json consistency check.
app/assets/db-manifest.json — content hash bump.

How I verified

Smoke test with a dummy tradition (3 books: genesis/exodus/matthew, book_count=3):

Positive path: schema_validator + build + validate_sqlite all pass.
Negative path: set book_count=99, confirmed both schema_validator and validate_sqlite emit book_count=99 listed=3 failures.

Final committed state (empty array):

python _tools/schema_validator.py — 136483 passed, 77 failed (same pre-existing set as master), 0 new failures ✅
python _tools/build_sqlite.py — canon_traditions: 0 rows ✅
python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings ✅

Out of scope

Branched from master; does not logically depend on [HWGTB-P0-01] Expand scholar registry: patristic + canon-formation voices #1537 (no scholar cross-refs in this schema).
Canon Comparison screen UI lands in HWGTB-P3-01 ([HWGTB-P3-01] App: CanonComparisonScreen #1550).

Rollback

Revert this PR. Table is recreated from schema on each build so no migration cleanup.

Generated by Claude Code

Introduces the canon_traditions schema for the four major canonical traditions (Protestant, Catholic, Eastern Orthodox, Ethiopian Tewahedo) feeding the Canon Comparison screen. Seeds content/meta/canon_traditions.json as an empty array; the four seeded traditions land in HWGTB-P1-05. schema_validator.py enforces id shape, required keys, and a book_count-vs-canon_list consistency check. Books outside the 66-book Protestant biblical canon are tolerated (deuterocanon / pseudepigrapha will live there) provided they are snake_case ids. validate_sqlite.py asserts the DB-side book_count invariant. Closes#1539 https://claude.ai/code/session_01PHELDhvq1dxY36oL5Gguad

github-actions · 2026-04-23T12:03:37Z

Content Pipeline Results

✅ All pipeline checks passed

Step	Status	Details
Schema Validation	✅	136483 passed, 77 failed
Build DB	✅	—
DB Integrity	✅	94 passed, 0 failed

Content Pipeline — Quality & Accuracy Report

✅ All content checks passed

Scope: 0 chapter(s) across 0 book(s)

Generated by ci_content_check.py

github-actions · 2026-04-23T12:04:00Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3474	❌ 0	3474
Suites	✅ 469	❌ 0	469

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 82.4s

CraigBuckmaster · 2026-04-23T19:06:02Z

Closing as superseded by #1590.

Both PRs modify the same _tools/build_sqlite_*.py schema files plus content/meta/canon_traditions.json — this PR seeds canon_traditions as an empty array and #1590 seeds it with the full 4 entries. #1590 contains the strict superset of this PR's diff.

Keeping #1590 and closing here to avoid a merge conflict on the schema files.

CraigBuckmaster · 2026-04-23T12:01:45Z

What this does

Introduces the canon_traditions meta table — schema for the four major canonical traditions (Protestant, Catholic, Eastern Orthodox, Ethiopian Tewahedo). Seeds content/meta/canon_traditions.json as an empty array; the four seeded entries land in HWGTB-P1-05 (#1542).

Closes

Closes#1539

Changes

New filecontent/meta/canon_traditions.json — empty array.
_tools/build_sqlite_schema.py — CREATE TABLE canon_traditions + idx_canon_traditions_sort.
_tools/build_sqlite_loaders.py — populate_canon_traditions() loader.
_tools/build_sqlite.py — loader imported + registered in pipeline.
_tools/schema_validator.py — new CANON TRADITIONS section:
- Required keys: id, label, book_count, canon_list
- id is snake_case and unique
- book_count equals the total canon_list[].books[] length
- canon_list[].books[] validated per the issue. Books outside books.json (deuterocanon, pseudepigrapha, etc.) are tolerated with an informational log — they're expected for non-Protestant traditions — provided they pass the snake_case id shape.
_tools/validate_sqlite.py — DB-side book_count vs canon_list_json consistency check.
app/assets/db-manifest.json — content hash bump.

How I verified

Smoke test with a dummy tradition (3 books: genesis/exodus/matthew, book_count=3):

Positive path: schema_validator + build + validate_sqlite all pass.
Negative path: set book_count=99, confirmed both schema_validator and validate_sqlite emit book_count=99 listed=3 failures.

Final committed state (empty array):

python _tools/schema_validator.py — 136483 passed, 77 failed (same pre-existing set as master), 0 new failures ✅
python _tools/build_sqlite.py — canon_traditions: 0 rows ✅
python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings ✅

Out of scope

Branched from master; does not logically depend on [HWGTB-P0-01] Expand scholar registry: patristic + canon-formation voices #1537 (no scholar cross-refs in this schema).
Canon Comparison screen UI lands in HWGTB-P3-01 ([HWGTB-P3-01] App: CanonComparisonScreen #1550).

Rollback

Revert this PR. Table is recreated from schema on each build so no migration cleanup.

Generated by Claude Code

Introduces the canon_traditions schema for the four major canonical traditions (Protestant, Catholic, Eastern Orthodox, Ethiopian Tewahedo) feeding the Canon Comparison screen. Seeds content/meta/canon_traditions.json as an empty array; the four seeded traditions land in HWGTB-P1-05. schema_validator.py enforces id shape, required keys, and a book_count-vs-canon_list consistency check. Books outside the 66-book Protestant biblical canon are tolerated (deuterocanon / pseudepigrapha will live there) provided they are snake_case ids. validate_sqlite.py asserts the DB-side book_count invariant. Closes#1539 https://claude.ai/code/session_01PHELDhvq1dxY36oL5Gguad

github-actions · 2026-04-23T12:03:37Z

Content Pipeline Results

✅ All pipeline checks passed

Step	Status	Details
Schema Validation	✅	136483 passed, 77 failed
Build DB	✅	—
DB Integrity	✅	94 passed, 0 failed

Content Pipeline — Quality & Accuracy Report

✅ All content checks passed

Scope: 0 chapter(s) across 0 book(s)

Generated by ci_content_check.py

github-actions · 2026-04-23T12:04:00Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3474	❌ 0	3474
Suites	✅ 469	❌ 0	469

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 82.4s

CraigBuckmaster · 2026-04-23T19:06:02Z

Closing as superseded by #1590.

Both PRs modify the same _tools/build_sqlite_*.py schema files plus content/meta/canon_traditions.json — this PR seeds canon_traditions as an empty array and #1590 seeds it with the full 4 entries. #1590 contains the strict superset of this PR's diff.

Keeping #1590 and closing here to avoid a merge conflict on the schema files.

CraigBuckmaster · 2026-04-23T12:01:45Z

What this does

Introduces the canon_traditions meta table — schema for the four major canonical traditions (Protestant, Catholic, Eastern Orthodox, Ethiopian Tewahedo). Seeds content/meta/canon_traditions.json as an empty array; the four seeded entries land in HWGTB-P1-05 (#1542).

Closes

Closes#1539

Changes

New filecontent/meta/canon_traditions.json — empty array.
_tools/build_sqlite_schema.py — CREATE TABLE canon_traditions + idx_canon_traditions_sort.
_tools/build_sqlite_loaders.py — populate_canon_traditions() loader.
_tools/build_sqlite.py — loader imported + registered in pipeline.
_tools/schema_validator.py — new CANON TRADITIONS section:
- Required keys: id, label, book_count, canon_list
- id is snake_case and unique
- book_count equals the total canon_list[].books[] length
- canon_list[].books[] validated per the issue. Books outside books.json (deuterocanon, pseudepigrapha, etc.) are tolerated with an informational log — they're expected for non-Protestant traditions — provided they pass the snake_case id shape.
_tools/validate_sqlite.py — DB-side book_count vs canon_list_json consistency check.
app/assets/db-manifest.json — content hash bump.

How I verified

Smoke test with a dummy tradition (3 books: genesis/exodus/matthew, book_count=3):

Positive path: schema_validator + build + validate_sqlite all pass.
Negative path: set book_count=99, confirmed both schema_validator and validate_sqlite emit book_count=99 listed=3 failures.

Final committed state (empty array):

python _tools/schema_validator.py — 136483 passed, 77 failed (same pre-existing set as master), 0 new failures ✅
python _tools/build_sqlite.py — canon_traditions: 0 rows ✅
python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings ✅

Out of scope

Branched from master; does not logically depend on [HWGTB-P0-01] Expand scholar registry: patristic + canon-formation voices #1537 (no scholar cross-refs in this schema).
Canon Comparison screen UI lands in HWGTB-P3-01 ([HWGTB-P3-01] App: CanonComparisonScreen #1550).

Rollback

Revert this PR. Table is recreated from schema on each build so no migration cleanup.

Generated by Claude Code

Introduces the canon_traditions schema for the four major canonical traditions (Protestant, Catholic, Eastern Orthodox, Ethiopian Tewahedo) feeding the Canon Comparison screen. Seeds content/meta/canon_traditions.json as an empty array; the four seeded traditions land in HWGTB-P1-05. schema_validator.py enforces id shape, required keys, and a book_count-vs-canon_list consistency check. Books outside the 66-book Protestant biblical canon are tolerated (deuterocanon / pseudepigrapha will live there) provided they are snake_case ids. validate_sqlite.py asserts the DB-side book_count invariant. Closes#1539 https://claude.ai/code/session_01PHELDhvq1dxY36oL5Gguad

github-actions · 2026-04-23T12:03:37Z

Content Pipeline Results

✅ All pipeline checks passed

Step	Status	Details
Schema Validation	✅	136483 passed, 77 failed
Build DB	✅	—
DB Integrity	✅	94 passed, 0 failed

Content Pipeline — Quality & Accuracy Report

✅ All content checks passed

Scope: 0 chapter(s) across 0 book(s)

Generated by ci_content_check.py

github-actions · 2026-04-23T12:04:00Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3474	❌ 0	3474
Suites	✅ 469	❌ 0	469

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 82.4s

CraigBuckmaster · 2026-04-23T19:06:02Z

Closing as superseded by #1590.

Both PRs modify the same _tools/build_sqlite_*.py schema files plus content/meta/canon_traditions.json — this PR seeds canon_traditions as an empty array and #1590 seeds it with the full 4 entries. #1590 contains the strict superset of this PR's diff.

Keeping #1590 and closing here to avoid a merge conflict on the schema files.

CraigBuckmaster · 2026-04-23T12:01:45Z

What this does

Introduces the canon_traditions meta table — schema for the four major canonical traditions (Protestant, Catholic, Eastern Orthodox, Ethiopian Tewahedo). Seeds content/meta/canon_traditions.json as an empty array; the four seeded entries land in HWGTB-P1-05 (#1542).

Closes

Closes#1539

Changes

New filecontent/meta/canon_traditions.json — empty array.
_tools/build_sqlite_schema.py — CREATE TABLE canon_traditions + idx_canon_traditions_sort.
_tools/build_sqlite_loaders.py — populate_canon_traditions() loader.
_tools/build_sqlite.py — loader imported + registered in pipeline.
_tools/schema_validator.py — new CANON TRADITIONS section:
- Required keys: id, label, book_count, canon_list
- id is snake_case and unique
- book_count equals the total canon_list[].books[] length
- canon_list[].books[] validated per the issue. Books outside books.json (deuterocanon, pseudepigrapha, etc.) are tolerated with an informational log — they're expected for non-Protestant traditions — provided they pass the snake_case id shape.
_tools/validate_sqlite.py — DB-side book_count vs canon_list_json consistency check.
app/assets/db-manifest.json — content hash bump.

How I verified

Smoke test with a dummy tradition (3 books: genesis/exodus/matthew, book_count=3):

Positive path: schema_validator + build + validate_sqlite all pass.
Negative path: set book_count=99, confirmed both schema_validator and validate_sqlite emit book_count=99 listed=3 failures.

Final committed state (empty array):

python _tools/schema_validator.py — 136483 passed, 77 failed (same pre-existing set as master), 0 new failures ✅
python _tools/build_sqlite.py — canon_traditions: 0 rows ✅
python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings ✅

Out of scope

Branched from master; does not logically depend on [HWGTB-P0-01] Expand scholar registry: patristic + canon-formation voices #1537 (no scholar cross-refs in this schema).
Canon Comparison screen UI lands in HWGTB-P3-01 ([HWGTB-P3-01] App: CanonComparisonScreen #1550).

Rollback

Revert this PR. Table is recreated from schema on each build so no migration cleanup.

Generated by Claude Code

Introduces the canon_traditions schema for the four major canonical traditions (Protestant, Catholic, Eastern Orthodox, Ethiopian Tewahedo) feeding the Canon Comparison screen. Seeds content/meta/canon_traditions.json as an empty array; the four seeded traditions land in HWGTB-P1-05. schema_validator.py enforces id shape, required keys, and a book_count-vs-canon_list consistency check. Books outside the 66-book Protestant biblical canon are tolerated (deuterocanon / pseudepigrapha will live there) provided they are snake_case ids. validate_sqlite.py asserts the DB-side book_count invariant. Closes#1539 https://claude.ai/code/session_01PHELDhvq1dxY36oL5Gguad

github-actions · 2026-04-23T12:03:37Z

Content Pipeline Results

✅ All pipeline checks passed

Step	Status	Details
Schema Validation	✅	136483 passed, 77 failed
Build DB	✅	—
DB Integrity	✅	94 passed, 0 failed

Content Pipeline — Quality & Accuracy Report

✅ All content checks passed

Scope: 0 chapter(s) across 0 book(s)

Generated by ci_content_check.py

github-actions · 2026-04-23T12:04:00Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3474	❌ 0	3474
Suites	✅ 469	❌ 0	469

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 82.4s

CraigBuckmaster · 2026-04-23T19:06:02Z

Closing as superseded by #1590.

Both PRs modify the same _tools/build_sqlite_*.py schema files plus content/meta/canon_traditions.json — this PR seeds canon_traditions as an empty array and #1590 seeds it with the full 4 entries. #1590 contains the strict superset of this PR's diff.

Keeping #1590 and closing here to avoid a merge conflict on the schema files.

CraigBuckmaster · 2026-04-23T12:01:45Z

What this does

Introduces the canon_traditions meta table — schema for the four major canonical traditions (Protestant, Catholic, Eastern Orthodox, Ethiopian Tewahedo). Seeds content/meta/canon_traditions.json as an empty array; the four seeded entries land in HWGTB-P1-05 (#1542).

Closes

Closes#1539

Changes

New filecontent/meta/canon_traditions.json — empty array.
_tools/build_sqlite_schema.py — CREATE TABLE canon_traditions + idx_canon_traditions_sort.
_tools/build_sqlite_loaders.py — populate_canon_traditions() loader.
_tools/build_sqlite.py — loader imported + registered in pipeline.
_tools/schema_validator.py — new CANON TRADITIONS section:
- Required keys: id, label, book_count, canon_list
- id is snake_case and unique
- book_count equals the total canon_list[].books[] length
- canon_list[].books[] validated per the issue. Books outside books.json (deuterocanon, pseudepigrapha, etc.) are tolerated with an informational log — they're expected for non-Protestant traditions — provided they pass the snake_case id shape.
_tools/validate_sqlite.py — DB-side book_count vs canon_list_json consistency check.
app/assets/db-manifest.json — content hash bump.

How I verified

Smoke test with a dummy tradition (3 books: genesis/exodus/matthew, book_count=3):

Positive path: schema_validator + build + validate_sqlite all pass.
Negative path: set book_count=99, confirmed both schema_validator and validate_sqlite emit book_count=99 listed=3 failures.

Final committed state (empty array):

python _tools/schema_validator.py — 136483 passed, 77 failed (same pre-existing set as master), 0 new failures ✅
python _tools/build_sqlite.py — canon_traditions: 0 rows ✅
python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings ✅

Out of scope

Branched from master; does not logically depend on [HWGTB-P0-01] Expand scholar registry: patristic + canon-formation voices #1537 (no scholar cross-refs in this schema).
Canon Comparison screen UI lands in HWGTB-P3-01 ([HWGTB-P3-01] App: CanonComparisonScreen #1550).

Rollback

Revert this PR. Table is recreated from schema on each build so no migration cleanup.

Generated by Claude Code

Introduces the canon_traditions schema for the four major canonical traditions (Protestant, Catholic, Eastern Orthodox, Ethiopian Tewahedo) feeding the Canon Comparison screen. Seeds content/meta/canon_traditions.json as an empty array; the four seeded traditions land in HWGTB-P1-05. schema_validator.py enforces id shape, required keys, and a book_count-vs-canon_list consistency check. Books outside the 66-book Protestant biblical canon are tolerated (deuterocanon / pseudepigrapha will live there) provided they are snake_case ids. validate_sqlite.py asserts the DB-side book_count invariant. Closes#1539 https://claude.ai/code/session_01PHELDhvq1dxY36oL5Gguad

github-actions · 2026-04-23T12:03:37Z

Content Pipeline Results

✅ All pipeline checks passed

Step	Status	Details
Schema Validation	✅	136483 passed, 77 failed
Build DB	✅	—
DB Integrity	✅	94 passed, 0 failed

Content Pipeline — Quality & Accuracy Report

✅ All content checks passed

Scope: 0 chapter(s) across 0 book(s)

Generated by ci_content_check.py

github-actions · 2026-04-23T12:04:00Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3474	❌ 0	3474
Suites	✅ 469	❌ 0	469

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 82.4s

CraigBuckmaster · 2026-04-23T19:06:02Z

Closing as superseded by #1590.

Both PRs modify the same _tools/build_sqlite_*.py schema files plus content/meta/canon_traditions.json — this PR seeds canon_traditions as an empty array and #1590 seeds it with the full 4 entries. #1590 contains the strict superset of this PR's diff.

Keeping #1590 and closing here to avoid a merge conflict on the schema files.

CraigBuckmaster · 2026-04-23T12:01:45Z

What this does

Introduces the canon_traditions meta table — schema for the four major canonical traditions (Protestant, Catholic, Eastern Orthodox, Ethiopian Tewahedo). Seeds content/meta/canon_traditions.json as an empty array; the four seeded entries land in HWGTB-P1-05 (#1542).

Closes

Closes#1539

Changes

New filecontent/meta/canon_traditions.json — empty array.
_tools/build_sqlite_schema.py — CREATE TABLE canon_traditions + idx_canon_traditions_sort.
_tools/build_sqlite_loaders.py — populate_canon_traditions() loader.
_tools/build_sqlite.py — loader imported + registered in pipeline.
_tools/schema_validator.py — new CANON TRADITIONS section:
- Required keys: id, label, book_count, canon_list
- id is snake_case and unique
- book_count equals the total canon_list[].books[] length
- canon_list[].books[] validated per the issue. Books outside books.json (deuterocanon, pseudepigrapha, etc.) are tolerated with an informational log — they're expected for non-Protestant traditions — provided they pass the snake_case id shape.
_tools/validate_sqlite.py — DB-side book_count vs canon_list_json consistency check.
app/assets/db-manifest.json — content hash bump.

How I verified

Smoke test with a dummy tradition (3 books: genesis/exodus/matthew, book_count=3):

Positive path: schema_validator + build + validate_sqlite all pass.
Negative path: set book_count=99, confirmed both schema_validator and validate_sqlite emit book_count=99 listed=3 failures.

Final committed state (empty array):

python _tools/schema_validator.py — 136483 passed, 77 failed (same pre-existing set as master), 0 new failures ✅
python _tools/build_sqlite.py — canon_traditions: 0 rows ✅
python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings ✅

Out of scope

Branched from master; does not logically depend on [HWGTB-P0-01] Expand scholar registry: patristic + canon-formation voices #1537 (no scholar cross-refs in this schema).
Canon Comparison screen UI lands in HWGTB-P3-01 ([HWGTB-P3-01] App: CanonComparisonScreen #1550).

Rollback

Revert this PR. Table is recreated from schema on each build so no migration cleanup.

Generated by Claude Code

Introduces the canon_traditions schema for the four major canonical traditions (Protestant, Catholic, Eastern Orthodox, Ethiopian Tewahedo) feeding the Canon Comparison screen. Seeds content/meta/canon_traditions.json as an empty array; the four seeded traditions land in HWGTB-P1-05. schema_validator.py enforces id shape, required keys, and a book_count-vs-canon_list consistency check. Books outside the 66-book Protestant biblical canon are tolerated (deuterocanon / pseudepigrapha will live there) provided they are snake_case ids. validate_sqlite.py asserts the DB-side book_count invariant. Closes#1539 https://claude.ai/code/session_01PHELDhvq1dxY36oL5Gguad

github-actions · 2026-04-23T12:03:37Z

Content Pipeline Results

✅ All pipeline checks passed

Step	Status	Details
Schema Validation	✅	136483 passed, 77 failed
Build DB	✅	—
DB Integrity	✅	94 passed, 0 failed

Content Pipeline — Quality & Accuracy Report

✅ All content checks passed

Scope: 0 chapter(s) across 0 book(s)

Generated by ci_content_check.py

github-actions · 2026-04-23T12:04:00Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3474	❌ 0	3474
Suites	✅ 469	❌ 0	469

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 82.4s

CraigBuckmaster · 2026-04-23T19:06:02Z

Closing as superseded by #1590.

Both PRs modify the same _tools/build_sqlite_*.py schema files plus content/meta/canon_traditions.json — this PR seeds canon_traditions as an empty array and #1590 seeds it with the full 4 entries. #1590 contains the strict superset of this PR's diff.

Keeping #1590 and closing here to avoid a merge conflict on the schema files.

CraigBuckmaster · 2026-04-23T12:01:45Z

What this does

Introduces the canon_traditions meta table — schema for the four major canonical traditions (Protestant, Catholic, Eastern Orthodox, Ethiopian Tewahedo). Seeds content/meta/canon_traditions.json as an empty array; the four seeded entries land in HWGTB-P1-05 (#1542).

Closes

Closes#1539

Changes

New filecontent/meta/canon_traditions.json — empty array.
_tools/build_sqlite_schema.py — CREATE TABLE canon_traditions + idx_canon_traditions_sort.
_tools/build_sqlite_loaders.py — populate_canon_traditions() loader.
_tools/build_sqlite.py — loader imported + registered in pipeline.
_tools/schema_validator.py — new CANON TRADITIONS section:
- Required keys: id, label, book_count, canon_list
- id is snake_case and unique
- book_count equals the total canon_list[].books[] length
- canon_list[].books[] validated per the issue. Books outside books.json (deuterocanon, pseudepigrapha, etc.) are tolerated with an informational log — they're expected for non-Protestant traditions — provided they pass the snake_case id shape.
_tools/validate_sqlite.py — DB-side book_count vs canon_list_json consistency check.
app/assets/db-manifest.json — content hash bump.

How I verified

Smoke test with a dummy tradition (3 books: genesis/exodus/matthew, book_count=3):

Positive path: schema_validator + build + validate_sqlite all pass.
Negative path: set book_count=99, confirmed both schema_validator and validate_sqlite emit book_count=99 listed=3 failures.

Final committed state (empty array):

python _tools/schema_validator.py — 136483 passed, 77 failed (same pre-existing set as master), 0 new failures ✅
python _tools/build_sqlite.py — canon_traditions: 0 rows ✅
python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings ✅

Out of scope

Branched from master; does not logically depend on [HWGTB-P0-01] Expand scholar registry: patristic + canon-formation voices #1537 (no scholar cross-refs in this schema).
Canon Comparison screen UI lands in HWGTB-P3-01 ([HWGTB-P3-01] App: CanonComparisonScreen #1550).

Rollback

Revert this PR. Table is recreated from schema on each build so no migration cleanup.

Generated by Claude Code

Introduces the canon_traditions schema for the four major canonical traditions (Protestant, Catholic, Eastern Orthodox, Ethiopian Tewahedo) feeding the Canon Comparison screen. Seeds content/meta/canon_traditions.json as an empty array; the four seeded traditions land in HWGTB-P1-05. schema_validator.py enforces id shape, required keys, and a book_count-vs-canon_list consistency check. Books outside the 66-book Protestant biblical canon are tolerated (deuterocanon / pseudepigrapha will live there) provided they are snake_case ids. validate_sqlite.py asserts the DB-side book_count invariant. Closes#1539 https://claude.ai/code/session_01PHELDhvq1dxY36oL5Gguad

github-actions · 2026-04-23T12:03:37Z

Content Pipeline Results

✅ All pipeline checks passed

Step	Status	Details
Schema Validation	✅	136483 passed, 77 failed
Build DB	✅	—
DB Integrity	✅	94 passed, 0 failed

Content Pipeline — Quality & Accuracy Report

✅ All content checks passed

Scope: 0 chapter(s) across 0 book(s)

Generated by ci_content_check.py

github-actions · 2026-04-23T12:04:00Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3474	❌ 0	3474
Suites	✅ 469	❌ 0	469

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 82.4s

CraigBuckmaster · 2026-04-23T19:06:02Z

Closing as superseded by #1590.

Both PRs modify the same _tools/build_sqlite_*.py schema files plus content/meta/canon_traditions.json — this PR seeds canon_traditions as an empty array and #1590 seeds it with the full 4 entries. #1590 contains the strict superset of this PR's diff.

Keeping #1590 and closing here to avoid a merge conflict on the schema files.

CraigBuckmaster · 2026-04-23T12:01:45Z

What this does

Introduces the canon_traditions meta table — schema for the four major canonical traditions (Protestant, Catholic, Eastern Orthodox, Ethiopian Tewahedo). Seeds content/meta/canon_traditions.json as an empty array; the four seeded entries land in HWGTB-P1-05 (#1542).

Closes

Closes#1539

Changes

New filecontent/meta/canon_traditions.json — empty array.
_tools/build_sqlite_schema.py — CREATE TABLE canon_traditions + idx_canon_traditions_sort.
_tools/build_sqlite_loaders.py — populate_canon_traditions() loader.
_tools/build_sqlite.py — loader imported + registered in pipeline.
_tools/schema_validator.py — new CANON TRADITIONS section:
- Required keys: id, label, book_count, canon_list
- id is snake_case and unique
- book_count equals the total canon_list[].books[] length
- canon_list[].books[] validated per the issue. Books outside books.json (deuterocanon, pseudepigrapha, etc.) are tolerated with an informational log — they're expected for non-Protestant traditions — provided they pass the snake_case id shape.
_tools/validate_sqlite.py — DB-side book_count vs canon_list_json consistency check.
app/assets/db-manifest.json — content hash bump.

How I verified

Smoke test with a dummy tradition (3 books: genesis/exodus/matthew, book_count=3):

Positive path: schema_validator + build + validate_sqlite all pass.
Negative path: set book_count=99, confirmed both schema_validator and validate_sqlite emit book_count=99 listed=3 failures.

Final committed state (empty array):

python _tools/schema_validator.py — 136483 passed, 77 failed (same pre-existing set as master), 0 new failures ✅
python _tools/build_sqlite.py — canon_traditions: 0 rows ✅
python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings ✅

Out of scope

Branched from master; does not logically depend on [HWGTB-P0-01] Expand scholar registry: patristic + canon-formation voices #1537 (no scholar cross-refs in this schema).
Canon Comparison screen UI lands in HWGTB-P3-01 ([HWGTB-P3-01] App: CanonComparisonScreen #1550).

Rollback

Revert this PR. Table is recreated from schema on each build so no migration cleanup.

Generated by Claude Code

Introduces the canon_traditions schema for the four major canonical traditions (Protestant, Catholic, Eastern Orthodox, Ethiopian Tewahedo) feeding the Canon Comparison screen. Seeds content/meta/canon_traditions.json as an empty array; the four seeded traditions land in HWGTB-P1-05. schema_validator.py enforces id shape, required keys, and a book_count-vs-canon_list consistency check. Books outside the 66-book Protestant biblical canon are tolerated (deuterocanon / pseudepigrapha will live there) provided they are snake_case ids. validate_sqlite.py asserts the DB-side book_count invariant. Closes#1539 https://claude.ai/code/session_01PHELDhvq1dxY36oL5Gguad

github-actions · 2026-04-23T12:03:37Z

Content Pipeline Results

✅ All pipeline checks passed

Step	Status	Details
Schema Validation	✅	136483 passed, 77 failed
Build DB	✅	—
DB Integrity	✅	94 passed, 0 failed

Content Pipeline — Quality & Accuracy Report

✅ All content checks passed

Scope: 0 chapter(s) across 0 book(s)

Generated by ci_content_check.py

github-actions · 2026-04-23T12:04:00Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3474	❌ 0	3474
Suites	✅ 469	❌ 0	469

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 82.4s

CraigBuckmaster · 2026-04-23T19:06:02Z

Closing as superseded by #1590.

Both PRs modify the same _tools/build_sqlite_*.py schema files plus content/meta/canon_traditions.json — this PR seeds canon_traditions as an empty array and #1590 seeds it with the full 4 entries. #1590 contains the strict superset of this PR's diff.

Keeping #1590 and closing here to avoid a merge conflict on the schema files.

This was referenced Apr 23, 2026
content: 4 canon_traditions entries (#1542) #1590
Closed
feat(app): CanonComparisonScreen (#1550) #1600
Merged

CraigBuckmaster closed this Apr 23, 2026

CraigBuckmaster deleted the feature/hwgtb-p1-02-canon-traditions-schema branch April 23, 2026 20:35

This was referenced Apr 23, 2026
content: 4 canon_traditions entries (#1542) #1590
Closed
feat(app): CanonComparisonScreen (#1550) #1600
Merged

CraigBuckmaster closed this Apr 23, 2026

CraigBuckmaster deleted the feature/hwgtb-p1-02-canon-traditions-schema branch April 23, 2026 20:35

This was referenced Apr 23, 2026
content: 4 canon_traditions entries (#1542) #1590
Closed
feat(app): CanonComparisonScreen (#1550) #1600
Merged

CraigBuckmaster closed this Apr 23, 2026

CraigBuckmaster deleted the feature/hwgtb-p1-02-canon-traditions-schema branch April 23, 2026 20:35

This was referenced Apr 23, 2026
content: 4 canon_traditions entries (#1542) #1590
Closed
feat(app): CanonComparisonScreen (#1550) #1600
Merged

CraigBuckmaster closed this Apr 23, 2026

CraigBuckmaster deleted the feature/hwgtb-p1-02-canon-traditions-schema branch April 23, 2026 20:35

This was referenced Apr 23, 2026
content: 4 canon_traditions entries (#1542) #1590
Closed
feat(app): CanonComparisonScreen (#1550) #1600
Merged

CraigBuckmaster closed this Apr 23, 2026

CraigBuckmaster deleted the feature/hwgtb-p1-02-canon-traditions-schema branch April 23, 2026 20:35

This was referenced Apr 23, 2026
content: 4 canon_traditions entries (#1542) #1590
Closed
feat(app): CanonComparisonScreen (#1550) #1600
Merged

CraigBuckmaster closed this Apr 23, 2026

CraigBuckmaster deleted the feature/hwgtb-p1-02-canon-traditions-schema branch April 23, 2026 20:35

This was referenced Apr 23, 2026
content: 4 canon_traditions entries (#1542) #1590
Closed
feat(app): CanonComparisonScreen (#1550) #1600
Merged

CraigBuckmaster closed this Apr 23, 2026

CraigBuckmaster deleted the feature/hwgtb-p1-02-canon-traditions-schema branch April 23, 2026 20:35

This was referenced Apr 23, 2026
content: 4 canon_traditions entries (#1542) #1590
Closed
feat(app): CanonComparisonScreen (#1550) #1600
Merged

CraigBuckmaster closed this Apr 23, 2026

CraigBuckmaster deleted the feature/hwgtb-p1-02-canon-traditions-schema branch April 23, 2026 20:35

Conversation

CraigBuckmaster commented Apr 23, 2026

What this does

Closes

Changes

How I verified

Out of scope

Rollback

Uh oh!

github-actionsBot commented Apr 23, 2026

Content Pipeline Results

Content Pipeline — Quality & Accuracy Report

Uh oh!

github-actionsBot commented Apr 23, 2026

Test Results

Coverage

Uh oh!

CraigBuckmaster commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

CraigBuckmaster commented Apr 23, 2026

What this does

Closes

Changes

How I verified

Out of scope

Rollback

Uh oh!

github-actionsBot commented Apr 23, 2026

Content Pipeline Results

Content Pipeline — Quality & Accuracy Report

Uh oh!

github-actionsBot commented Apr 23, 2026

Test Results

Coverage

Uh oh!

CraigBuckmaster commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

CraigBuckmaster commented Apr 23, 2026

What this does

Closes

Changes

How I verified

Out of scope

Rollback

Uh oh!

github-actionsBot commented Apr 23, 2026

Content Pipeline Results

Content Pipeline — Quality & Accuracy Report

Uh oh!

github-actionsBot commented Apr 23, 2026

Test Results

Coverage

Uh oh!

CraigBuckmaster commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!