content: 4 canon_traditions entries (#1542) by CraigBuckmaster · Pull Request #1590 · CraigBuckmaster/ScriptureDeepDive

CraigBuckmaster · 2026-04-23T14:31:10Z

What this does

Seeds content/meta/canon_traditions.json with the four traditions that feed the Canon Comparison screen (HWGTB-P3-01 / #1550):

id	label	book_count	distinctives	formation_events
`protestant`	Protestant	66	4	8
`catholic`	Roman Catholic	73	4	8
`eastern_orthodox`	Eastern Orthodox	76	4	7
`ethiopian_tewahedo`	Ethiopian Orthodox Tewahedo	81	4	8

Each entry ships with a full canon_list organized into OT/NT sections, a factual 1–2 paragraph short_description, 4 distinctives, and 7–8 chronologically ordered formation_events (Jamnia, Athanasius' 39th Festal Letter, Hippo/Carthage, Jerome's Prologus Galeatus, Luther's 1534 Bible, Trent Session IV, Trullo Canon 2, Westminster 1.3, Confession of Dositheos, Kebra Nagast, Haile Selassie Amharic Bible, etc.).

Closes

Closes#1542

Dual-table book-ID resolution (per issue note)

canon_list[].books[] ids may reference either books.json (66-book Protestant canon) or extrabiblical.json (deuterocanon, pseudepigrapha, DSS). Extended both validators:

schema_validator.py — new CANON TRADITIONS section checks every book id against both tables, fails on malformed snake_case, and logs unresolved ids (expected while extrabiblical seed is partial) as informational.
validate_sqlite.py — DB-side parallel: book_count vs canon_list_json consistency + dual-table lookup + informational log.

Table infrastructure

The canon_traditions table (CREATE, loader, populate registration) authored in #1539 is also included here so this branch builds end-to-end without prerequisites. When #1587 merges first the overlap is a redundant no-op; when this merges first #1587 becomes a trivial redundant addition.

Editorial commitments

Descriptive, not prescriptive. "The Ethiopian Tewahedo Church includes 1 Enoch in its canon" stated as fact; no tradition endorsed or rejected.
Factual tone on contested questions. Jamnia council thesis flagged as abandoned by modern scholarship (Lewis, Leiman); Trent's dogmatic binding noted as response to Luther; Meqabyan distinguished from Greek 1–4 Maccabees; 1 Enoch's Ethiopian preservation history named (Bruce 1773, Qumran 1947).
Named primary sources. Athanasius Ep. 39, Westminster 1.3, Trent Session IV, Trullo Canon 2, Dei Verbum §9–10, Confession of Dositheos, Kebra Nagast.
No conspiracy framing. Canon formation described as slow, regional, and contested.

How I verified

Final state on this branch (no prerequisite PRs applied):

python _tools/build_sqlite.py — canon_traditions: 4 rows ✅
python _tools/schema_validator.py — 136807 passed, 77 failed (same 77 pre-existing failures as master baseline, 0 new failures from canon_traditions work) ✅
python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings (pre-existing embeddings/prompts) ✅

Negative paths confirmed:

book_count mismatch → [FAIL] canon_tradition catholic book_count matches canon_list — book_count=999, listed=73
Non-snake_case book id → [FAIL] canon_tradition eastern_orthodox book 'Bad-Cased-Id' is snake_case

With #1541 (extrabiblical content, PR #1589) applied locally on top:

15 canon_list references resolve through extrabiblical.json
15 remain as informational logs (2_maccabees, baruch, 1_esdras, 3_maccabees, prayer_of_manasseh, 1/2/3_meqabyan, letter_of_jeremiah, tagsas) — all books outside the current 12-entry extrabiblical seed. Will stabilize if/when the extrabiblical seed expands in later epic work.

Merge order

Pairs with #1587 (canon_traditions schema, #1539) and #1589 (12 extrabiblical entries, #1541). Any merge order is safe — the shared additions between this and #1587 resolve identically.

Out of scope

Canon Comparison screen UI — HWGTB-P3-01 ([HWGTB-P3-01] App: CanonComparisonScreen #1550).
Additional extrabiblical entries for 2_maccabees, baruch, 1_esdras, etc. — not planned per the epic's scope (Phase 4 expands full_summary for the existing 12 entries only). Unresolved ids log as informational rather than failing, matching the existing pattern for non-Protestant book refs.

Rollback

Revert this PR. canon_traditions table drops on next build_sqlite.py run (tables recreated from schema each build). No user.db migrations.

Generated by Claude Code

github-actions · 2026-04-23T14:40:50Z

Content Pipeline Results

✅ All pipeline checks passed

Step	Status	Details
Schema Validation	✅	136885 passed, 77 failed
Build DB	✅	—
DB Integrity	✅	94 passed, 0 failed

Content Pipeline — Quality & Accuracy Report

✅ All content checks passed

Scope: 0 chapter(s) across 0 book(s)

Generated by ci_content_check.py

github-actions · 2026-04-23T14:41:20Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3474	❌ 0	3474
Suites	✅ 469	❌ 0	469

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 84.4s

Seeds content/meta/canon_traditions.json with the four traditions that feed the Canon Comparison screen: protestant 66 books catholic 73 books eastern_orthodox 76 books ethiopian_tewahedo 81 books Every entry ships with book_count, full canon_list (organized by OT/NT sections), 4 distinctives, and 7–8 chronologically ordered formation_events covering the major councils, letters, and decisions that shaped each tradition (Jamnia, Athanasius' 39th Festal Letter, Hippo/Carthage, Jerome's Prologus Galeatus, Trent, Trullo, Jerusalem 1672, the Haile Selassie Amharic Bible, etc.). Per the issue's dual-table note, canon_list[].books[] ids may reference either books.json (66-book Protestant canon) or extrabiblical.json (deuterocanon, pseudepigrapha, DSS). The schema_validator and validate_sqlite checks are extended to check both tables; ids resolving in neither are logged as informational (expected while the extrabiblical table is seeded incrementally across the epic) but malformed snake_case ids always fail. The canon_traditions table infrastructure (CREATE TABLE, loader, populate registration) authored in #1539 is included here — when #1539 merges first, the overlap is redundant; when this merges first, #1539 becomes a no-op for the shared additions. Editorial commitments per epic guardrails: - Descriptive, not prescriptive. "The Ethiopian Tewahedo Church includes 1 Enoch in its canon" is stated as fact; no tradition is endorsed or rejected. - Factual tone on contested questions (Jamnia council, Trent's dogmatic binding, Meqabyan ≠ Greek Maccabees, 1 Enoch preservation history). - Named primary sources (Athanasius Ep. 39, Westminster 1.3, Vatican II Dei Verbum, Confession of Dositheos, Kebra Nagast). How verified Full pipeline on this branch: - python _tools/build_sqlite.py — canon_traditions: 4 rows (OK) - python _tools/schema_validator.py — 136807 passed, 77 failed (same 77 pre-existing failures as master baseline, 0 new failures from canon_traditions work) - python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings (pre-existing embeddings/prompts warnings) Negative paths confirmed: book_count mismatch, non-snake_case book id, and malformed ids all trigger [FAIL] in both validators. With #1541 (extrabiblical content) applied locally on top: - 15 canon_list references resolve through extrabiblical.json - 15 remain as unresolved informational logs (2_maccabees, baruch, 1_esdras, 3_maccabees, prayer_of_manasseh, 1/2/3_meqabyan, letter_of_jeremiah, tagsas — all represent books outside the current 12-entry extrabiblical seed) Closes#1542

CraigBuckmaster · 2026-04-23T19:34:46Z

Superseded by the replacement PR above, which is rebuilt cleanly on top of #1586 (already merged) so canon_traditions coexists with extrabiblical instead of conflicting. Closing here.

Replaces PR #1590 which was built from a pre-#1586 base and conflicted with the extrabiblical table/validators. This branch is rebuilt cleanly on top of current master (with #1586 landed) so canon_traditions sits alongside extrabiblical rather than replacing it. Adds: - CREATE TABLE canon_traditions in build_sqlite_schema.py - populate_canon_traditions in build_sqlite_loaders.py - canon_traditions invocation in build_sqlite.py - Canon Traditions validation block in schema_validator.py (with dual- table book-ID resolution against books.json + extrabiblical.json, logging unresolved refs informationally) - canon_traditions integrity check in validate_sqlite.py - content/meta/canon_traditions.json seeded with 4 traditions: protestant (66), catholic (73), eastern_orthodox (81), ethiopian_tewahedo (81 broader canon) All five pipeline stages (schema_validator → build_sqlite → validate_sqlite) run green. 32 unresolved book refs are expected and log informationally per #1542 — they resolve as the extrabiblical table is populated incrementally by #1589 and follow-ups.

Replaces PR #1590 which was built from a pre-#1586 base and conflicted with the extrabiblical table/validators. This branch is rebuilt cleanly on top of current master (with #1586 landed) so canon_traditions sits alongside extrabiblical rather than replacing it. Adds: - CREATE TABLE canon_traditions in build_sqlite_schema.py - populate_canon_traditions in build_sqlite_loaders.py - canon_traditions invocation in build_sqlite.py - Canon Traditions validation block in schema_validator.py (with dual- table book-ID resolution against books.json + extrabiblical.json, logging unresolved refs informationally) - canon_traditions integrity check in validate_sqlite.py - content/meta/canon_traditions.json seeded with 4 traditions: protestant (66), catholic (73), eastern_orthodox (81), ethiopian_tewahedo (81 broader canon) All five pipeline stages (schema_validator → build_sqlite → validate_sqlite) run green. 32 unresolved book refs are expected and log informationally per #1542 — they resolve as the extrabiblical table is populated incrementally by #1589 and follow-ups. Co-authored-by: Claude (for Craig) <claude@anthropic.com>

CraigBuckmaster · 2026-04-23T14:31:10Z

What this does

Seeds content/meta/canon_traditions.json with the four traditions that feed the Canon Comparison screen (HWGTB-P3-01 / #1550):

id	label	book_count	distinctives	formation_events
`protestant`	Protestant	66	4	8
`catholic`	Roman Catholic	73	4	8
`eastern_orthodox`	Eastern Orthodox	76	4	7
`ethiopian_tewahedo`	Ethiopian Orthodox Tewahedo	81	4	8

Each entry ships with a full canon_list organized into OT/NT sections, a factual 1–2 paragraph short_description, 4 distinctives, and 7–8 chronologically ordered formation_events (Jamnia, Athanasius' 39th Festal Letter, Hippo/Carthage, Jerome's Prologus Galeatus, Luther's 1534 Bible, Trent Session IV, Trullo Canon 2, Westminster 1.3, Confession of Dositheos, Kebra Nagast, Haile Selassie Amharic Bible, etc.).

Closes

Closes#1542

Dual-table book-ID resolution (per issue note)

canon_list[].books[] ids may reference either books.json (66-book Protestant canon) or extrabiblical.json (deuterocanon, pseudepigrapha, DSS). Extended both validators:

schema_validator.py — new CANON TRADITIONS section checks every book id against both tables, fails on malformed snake_case, and logs unresolved ids (expected while extrabiblical seed is partial) as informational.
validate_sqlite.py — DB-side parallel: book_count vs canon_list_json consistency + dual-table lookup + informational log.

Table infrastructure

The canon_traditions table (CREATE, loader, populate registration) authored in #1539 is also included here so this branch builds end-to-end without prerequisites. When #1587 merges first the overlap is a redundant no-op; when this merges first #1587 becomes a trivial redundant addition.

Editorial commitments

Descriptive, not prescriptive. "The Ethiopian Tewahedo Church includes 1 Enoch in its canon" stated as fact; no tradition endorsed or rejected.
Factual tone on contested questions. Jamnia council thesis flagged as abandoned by modern scholarship (Lewis, Leiman); Trent's dogmatic binding noted as response to Luther; Meqabyan distinguished from Greek 1–4 Maccabees; 1 Enoch's Ethiopian preservation history named (Bruce 1773, Qumran 1947).
Named primary sources. Athanasius Ep. 39, Westminster 1.3, Trent Session IV, Trullo Canon 2, Dei Verbum §9–10, Confession of Dositheos, Kebra Nagast.
No conspiracy framing. Canon formation described as slow, regional, and contested.

How I verified

Final state on this branch (no prerequisite PRs applied):

python _tools/build_sqlite.py — canon_traditions: 4 rows ✅
python _tools/schema_validator.py — 136807 passed, 77 failed (same 77 pre-existing failures as master baseline, 0 new failures from canon_traditions work) ✅
python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings (pre-existing embeddings/prompts) ✅

Negative paths confirmed:

book_count mismatch → [FAIL] canon_tradition catholic book_count matches canon_list — book_count=999, listed=73
Non-snake_case book id → [FAIL] canon_tradition eastern_orthodox book 'Bad-Cased-Id' is snake_case

With #1541 (extrabiblical content, PR #1589) applied locally on top:

15 canon_list references resolve through extrabiblical.json
15 remain as informational logs (2_maccabees, baruch, 1_esdras, 3_maccabees, prayer_of_manasseh, 1/2/3_meqabyan, letter_of_jeremiah, tagsas) — all books outside the current 12-entry extrabiblical seed. Will stabilize if/when the extrabiblical seed expands in later epic work.

Merge order

Pairs with #1587 (canon_traditions schema, #1539) and #1589 (12 extrabiblical entries, #1541). Any merge order is safe — the shared additions between this and #1587 resolve identically.

Out of scope

Canon Comparison screen UI — HWGTB-P3-01 ([HWGTB-P3-01] App: CanonComparisonScreen #1550).
Additional extrabiblical entries for 2_maccabees, baruch, 1_esdras, etc. — not planned per the epic's scope (Phase 4 expands full_summary for the existing 12 entries only). Unresolved ids log as informational rather than failing, matching the existing pattern for non-Protestant book refs.

Rollback

Revert this PR. canon_traditions table drops on next build_sqlite.py run (tables recreated from schema each build). No user.db migrations.

Generated by Claude Code

github-actions · 2026-04-23T14:40:50Z

Content Pipeline Results

✅ All pipeline checks passed

Step	Status	Details
Schema Validation	✅	136885 passed, 77 failed
Build DB	✅	—
DB Integrity	✅	94 passed, 0 failed

Content Pipeline — Quality & Accuracy Report

✅ All content checks passed

Scope: 0 chapter(s) across 0 book(s)

Generated by ci_content_check.py

github-actions · 2026-04-23T14:41:20Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3474	❌ 0	3474
Suites	✅ 469	❌ 0	469

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 84.4s

Seeds content/meta/canon_traditions.json with the four traditions that feed the Canon Comparison screen: protestant 66 books catholic 73 books eastern_orthodox 76 books ethiopian_tewahedo 81 books Every entry ships with book_count, full canon_list (organized by OT/NT sections), 4 distinctives, and 7–8 chronologically ordered formation_events covering the major councils, letters, and decisions that shaped each tradition (Jamnia, Athanasius' 39th Festal Letter, Hippo/Carthage, Jerome's Prologus Galeatus, Trent, Trullo, Jerusalem 1672, the Haile Selassie Amharic Bible, etc.). Per the issue's dual-table note, canon_list[].books[] ids may reference either books.json (66-book Protestant canon) or extrabiblical.json (deuterocanon, pseudepigrapha, DSS). The schema_validator and validate_sqlite checks are extended to check both tables; ids resolving in neither are logged as informational (expected while the extrabiblical table is seeded incrementally across the epic) but malformed snake_case ids always fail. The canon_traditions table infrastructure (CREATE TABLE, loader, populate registration) authored in #1539 is included here — when #1539 merges first, the overlap is redundant; when this merges first, #1539 becomes a no-op for the shared additions. Editorial commitments per epic guardrails: - Descriptive, not prescriptive. "The Ethiopian Tewahedo Church includes 1 Enoch in its canon" is stated as fact; no tradition is endorsed or rejected. - Factual tone on contested questions (Jamnia council, Trent's dogmatic binding, Meqabyan ≠ Greek Maccabees, 1 Enoch preservation history). - Named primary sources (Athanasius Ep. 39, Westminster 1.3, Vatican II Dei Verbum, Confession of Dositheos, Kebra Nagast). How verified Full pipeline on this branch: - python _tools/build_sqlite.py — canon_traditions: 4 rows (OK) - python _tools/schema_validator.py — 136807 passed, 77 failed (same 77 pre-existing failures as master baseline, 0 new failures from canon_traditions work) - python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings (pre-existing embeddings/prompts warnings) Negative paths confirmed: book_count mismatch, non-snake_case book id, and malformed ids all trigger [FAIL] in both validators. With #1541 (extrabiblical content) applied locally on top: - 15 canon_list references resolve through extrabiblical.json - 15 remain as unresolved informational logs (2_maccabees, baruch, 1_esdras, 3_maccabees, prayer_of_manasseh, 1/2/3_meqabyan, letter_of_jeremiah, tagsas — all represent books outside the current 12-entry extrabiblical seed) Closes#1542

CraigBuckmaster · 2026-04-23T19:34:46Z

Superseded by the replacement PR above, which is rebuilt cleanly on top of #1586 (already merged) so canon_traditions coexists with extrabiblical instead of conflicting. Closing here.

Replaces PR #1590 which was built from a pre-#1586 base and conflicted with the extrabiblical table/validators. This branch is rebuilt cleanly on top of current master (with #1586 landed) so canon_traditions sits alongside extrabiblical rather than replacing it. Adds: - CREATE TABLE canon_traditions in build_sqlite_schema.py - populate_canon_traditions in build_sqlite_loaders.py - canon_traditions invocation in build_sqlite.py - Canon Traditions validation block in schema_validator.py (with dual- table book-ID resolution against books.json + extrabiblical.json, logging unresolved refs informationally) - canon_traditions integrity check in validate_sqlite.py - content/meta/canon_traditions.json seeded with 4 traditions: protestant (66), catholic (73), eastern_orthodox (81), ethiopian_tewahedo (81 broader canon) All five pipeline stages (schema_validator → build_sqlite → validate_sqlite) run green. 32 unresolved book refs are expected and log informationally per #1542 — they resolve as the extrabiblical table is populated incrementally by #1589 and follow-ups.

Replaces PR #1590 which was built from a pre-#1586 base and conflicted with the extrabiblical table/validators. This branch is rebuilt cleanly on top of current master (with #1586 landed) so canon_traditions sits alongside extrabiblical rather than replacing it. Adds: - CREATE TABLE canon_traditions in build_sqlite_schema.py - populate_canon_traditions in build_sqlite_loaders.py - canon_traditions invocation in build_sqlite.py - Canon Traditions validation block in schema_validator.py (with dual- table book-ID resolution against books.json + extrabiblical.json, logging unresolved refs informationally) - canon_traditions integrity check in validate_sqlite.py - content/meta/canon_traditions.json seeded with 4 traditions: protestant (66), catholic (73), eastern_orthodox (81), ethiopian_tewahedo (81 broader canon) All five pipeline stages (schema_validator → build_sqlite → validate_sqlite) run green. 32 unresolved book refs are expected and log informationally per #1542 — they resolve as the extrabiblical table is populated incrementally by #1589 and follow-ups. Co-authored-by: Claude (for Craig) <claude@anthropic.com>

CraigBuckmaster · 2026-04-23T14:31:10Z

What this does

Seeds content/meta/canon_traditions.json with the four traditions that feed the Canon Comparison screen (HWGTB-P3-01 / #1550):

id	label	book_count	distinctives	formation_events
`protestant`	Protestant	66	4	8
`catholic`	Roman Catholic	73	4	8
`eastern_orthodox`	Eastern Orthodox	76	4	7
`ethiopian_tewahedo`	Ethiopian Orthodox Tewahedo	81	4	8

Each entry ships with a full canon_list organized into OT/NT sections, a factual 1–2 paragraph short_description, 4 distinctives, and 7–8 chronologically ordered formation_events (Jamnia, Athanasius' 39th Festal Letter, Hippo/Carthage, Jerome's Prologus Galeatus, Luther's 1534 Bible, Trent Session IV, Trullo Canon 2, Westminster 1.3, Confession of Dositheos, Kebra Nagast, Haile Selassie Amharic Bible, etc.).

Closes

Closes#1542

Dual-table book-ID resolution (per issue note)

canon_list[].books[] ids may reference either books.json (66-book Protestant canon) or extrabiblical.json (deuterocanon, pseudepigrapha, DSS). Extended both validators:

schema_validator.py — new CANON TRADITIONS section checks every book id against both tables, fails on malformed snake_case, and logs unresolved ids (expected while extrabiblical seed is partial) as informational.
validate_sqlite.py — DB-side parallel: book_count vs canon_list_json consistency + dual-table lookup + informational log.

Table infrastructure

The canon_traditions table (CREATE, loader, populate registration) authored in #1539 is also included here so this branch builds end-to-end without prerequisites. When #1587 merges first the overlap is a redundant no-op; when this merges first #1587 becomes a trivial redundant addition.

Editorial commitments

Descriptive, not prescriptive. "The Ethiopian Tewahedo Church includes 1 Enoch in its canon" stated as fact; no tradition endorsed or rejected.
Factual tone on contested questions. Jamnia council thesis flagged as abandoned by modern scholarship (Lewis, Leiman); Trent's dogmatic binding noted as response to Luther; Meqabyan distinguished from Greek 1–4 Maccabees; 1 Enoch's Ethiopian preservation history named (Bruce 1773, Qumran 1947).
Named primary sources. Athanasius Ep. 39, Westminster 1.3, Trent Session IV, Trullo Canon 2, Dei Verbum §9–10, Confession of Dositheos, Kebra Nagast.
No conspiracy framing. Canon formation described as slow, regional, and contested.

How I verified

Final state on this branch (no prerequisite PRs applied):

python _tools/build_sqlite.py — canon_traditions: 4 rows ✅
python _tools/schema_validator.py — 136807 passed, 77 failed (same 77 pre-existing failures as master baseline, 0 new failures from canon_traditions work) ✅
python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings (pre-existing embeddings/prompts) ✅

Negative paths confirmed:

book_count mismatch → [FAIL] canon_tradition catholic book_count matches canon_list — book_count=999, listed=73
Non-snake_case book id → [FAIL] canon_tradition eastern_orthodox book 'Bad-Cased-Id' is snake_case

With #1541 (extrabiblical content, PR #1589) applied locally on top:

15 canon_list references resolve through extrabiblical.json
15 remain as informational logs (2_maccabees, baruch, 1_esdras, 3_maccabees, prayer_of_manasseh, 1/2/3_meqabyan, letter_of_jeremiah, tagsas) — all books outside the current 12-entry extrabiblical seed. Will stabilize if/when the extrabiblical seed expands in later epic work.

Merge order

Pairs with #1587 (canon_traditions schema, #1539) and #1589 (12 extrabiblical entries, #1541). Any merge order is safe — the shared additions between this and #1587 resolve identically.

Out of scope

Canon Comparison screen UI — HWGTB-P3-01 ([HWGTB-P3-01] App: CanonComparisonScreen #1550).
Additional extrabiblical entries for 2_maccabees, baruch, 1_esdras, etc. — not planned per the epic's scope (Phase 4 expands full_summary for the existing 12 entries only). Unresolved ids log as informational rather than failing, matching the existing pattern for non-Protestant book refs.

Rollback

Revert this PR. canon_traditions table drops on next build_sqlite.py run (tables recreated from schema each build). No user.db migrations.

Generated by Claude Code

github-actions · 2026-04-23T14:40:50Z

Content Pipeline Results

✅ All pipeline checks passed

Step	Status	Details
Schema Validation	✅	136885 passed, 77 failed
Build DB	✅	—
DB Integrity	✅	94 passed, 0 failed

Content Pipeline — Quality & Accuracy Report

✅ All content checks passed

Scope: 0 chapter(s) across 0 book(s)

Generated by ci_content_check.py

github-actions · 2026-04-23T14:41:20Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3474	❌ 0	3474
Suites	✅ 469	❌ 0	469

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 84.4s

Seeds content/meta/canon_traditions.json with the four traditions that feed the Canon Comparison screen: protestant 66 books catholic 73 books eastern_orthodox 76 books ethiopian_tewahedo 81 books Every entry ships with book_count, full canon_list (organized by OT/NT sections), 4 distinctives, and 7–8 chronologically ordered formation_events covering the major councils, letters, and decisions that shaped each tradition (Jamnia, Athanasius' 39th Festal Letter, Hippo/Carthage, Jerome's Prologus Galeatus, Trent, Trullo, Jerusalem 1672, the Haile Selassie Amharic Bible, etc.). Per the issue's dual-table note, canon_list[].books[] ids may reference either books.json (66-book Protestant canon) or extrabiblical.json (deuterocanon, pseudepigrapha, DSS). The schema_validator and validate_sqlite checks are extended to check both tables; ids resolving in neither are logged as informational (expected while the extrabiblical table is seeded incrementally across the epic) but malformed snake_case ids always fail. The canon_traditions table infrastructure (CREATE TABLE, loader, populate registration) authored in #1539 is included here — when #1539 merges first, the overlap is redundant; when this merges first, #1539 becomes a no-op for the shared additions. Editorial commitments per epic guardrails: - Descriptive, not prescriptive. "The Ethiopian Tewahedo Church includes 1 Enoch in its canon" is stated as fact; no tradition is endorsed or rejected. - Factual tone on contested questions (Jamnia council, Trent's dogmatic binding, Meqabyan ≠ Greek Maccabees, 1 Enoch preservation history). - Named primary sources (Athanasius Ep. 39, Westminster 1.3, Vatican II Dei Verbum, Confession of Dositheos, Kebra Nagast). How verified Full pipeline on this branch: - python _tools/build_sqlite.py — canon_traditions: 4 rows (OK) - python _tools/schema_validator.py — 136807 passed, 77 failed (same 77 pre-existing failures as master baseline, 0 new failures from canon_traditions work) - python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings (pre-existing embeddings/prompts warnings) Negative paths confirmed: book_count mismatch, non-snake_case book id, and malformed ids all trigger [FAIL] in both validators. With #1541 (extrabiblical content) applied locally on top: - 15 canon_list references resolve through extrabiblical.json - 15 remain as unresolved informational logs (2_maccabees, baruch, 1_esdras, 3_maccabees, prayer_of_manasseh, 1/2/3_meqabyan, letter_of_jeremiah, tagsas — all represent books outside the current 12-entry extrabiblical seed) Closes#1542

CraigBuckmaster · 2026-04-23T19:34:46Z

Superseded by the replacement PR above, which is rebuilt cleanly on top of #1586 (already merged) so canon_traditions coexists with extrabiblical instead of conflicting. Closing here.

Replaces PR #1590 which was built from a pre-#1586 base and conflicted with the extrabiblical table/validators. This branch is rebuilt cleanly on top of current master (with #1586 landed) so canon_traditions sits alongside extrabiblical rather than replacing it. Adds: - CREATE TABLE canon_traditions in build_sqlite_schema.py - populate_canon_traditions in build_sqlite_loaders.py - canon_traditions invocation in build_sqlite.py - Canon Traditions validation block in schema_validator.py (with dual- table book-ID resolution against books.json + extrabiblical.json, logging unresolved refs informationally) - canon_traditions integrity check in validate_sqlite.py - content/meta/canon_traditions.json seeded with 4 traditions: protestant (66), catholic (73), eastern_orthodox (81), ethiopian_tewahedo (81 broader canon) All five pipeline stages (schema_validator → build_sqlite → validate_sqlite) run green. 32 unresolved book refs are expected and log informationally per #1542 — they resolve as the extrabiblical table is populated incrementally by #1589 and follow-ups.

Replaces PR #1590 which was built from a pre-#1586 base and conflicted with the extrabiblical table/validators. This branch is rebuilt cleanly on top of current master (with #1586 landed) so canon_traditions sits alongside extrabiblical rather than replacing it. Adds: - CREATE TABLE canon_traditions in build_sqlite_schema.py - populate_canon_traditions in build_sqlite_loaders.py - canon_traditions invocation in build_sqlite.py - Canon Traditions validation block in schema_validator.py (with dual- table book-ID resolution against books.json + extrabiblical.json, logging unresolved refs informationally) - canon_traditions integrity check in validate_sqlite.py - content/meta/canon_traditions.json seeded with 4 traditions: protestant (66), catholic (73), eastern_orthodox (81), ethiopian_tewahedo (81 broader canon) All five pipeline stages (schema_validator → build_sqlite → validate_sqlite) run green. 32 unresolved book refs are expected and log informationally per #1542 — they resolve as the extrabiblical table is populated incrementally by #1589 and follow-ups. Co-authored-by: Claude (for Craig) <claude@anthropic.com>

CraigBuckmaster · 2026-04-23T14:31:10Z

What this does

Seeds content/meta/canon_traditions.json with the four traditions that feed the Canon Comparison screen (HWGTB-P3-01 / #1550):

id	label	book_count	distinctives	formation_events
`protestant`	Protestant	66	4	8
`catholic`	Roman Catholic	73	4	8
`eastern_orthodox`	Eastern Orthodox	76	4	7
`ethiopian_tewahedo`	Ethiopian Orthodox Tewahedo	81	4	8

Each entry ships with a full canon_list organized into OT/NT sections, a factual 1–2 paragraph short_description, 4 distinctives, and 7–8 chronologically ordered formation_events (Jamnia, Athanasius' 39th Festal Letter, Hippo/Carthage, Jerome's Prologus Galeatus, Luther's 1534 Bible, Trent Session IV, Trullo Canon 2, Westminster 1.3, Confession of Dositheos, Kebra Nagast, Haile Selassie Amharic Bible, etc.).

Closes

Closes#1542

Dual-table book-ID resolution (per issue note)

canon_list[].books[] ids may reference either books.json (66-book Protestant canon) or extrabiblical.json (deuterocanon, pseudepigrapha, DSS). Extended both validators:

schema_validator.py — new CANON TRADITIONS section checks every book id against both tables, fails on malformed snake_case, and logs unresolved ids (expected while extrabiblical seed is partial) as informational.
validate_sqlite.py — DB-side parallel: book_count vs canon_list_json consistency + dual-table lookup + informational log.

Table infrastructure

The canon_traditions table (CREATE, loader, populate registration) authored in #1539 is also included here so this branch builds end-to-end without prerequisites. When #1587 merges first the overlap is a redundant no-op; when this merges first #1587 becomes a trivial redundant addition.

Editorial commitments

Descriptive, not prescriptive. "The Ethiopian Tewahedo Church includes 1 Enoch in its canon" stated as fact; no tradition endorsed or rejected.
Factual tone on contested questions. Jamnia council thesis flagged as abandoned by modern scholarship (Lewis, Leiman); Trent's dogmatic binding noted as response to Luther; Meqabyan distinguished from Greek 1–4 Maccabees; 1 Enoch's Ethiopian preservation history named (Bruce 1773, Qumran 1947).
Named primary sources. Athanasius Ep. 39, Westminster 1.3, Trent Session IV, Trullo Canon 2, Dei Verbum §9–10, Confession of Dositheos, Kebra Nagast.
No conspiracy framing. Canon formation described as slow, regional, and contested.

How I verified

Final state on this branch (no prerequisite PRs applied):

python _tools/build_sqlite.py — canon_traditions: 4 rows ✅
python _tools/schema_validator.py — 136807 passed, 77 failed (same 77 pre-existing failures as master baseline, 0 new failures from canon_traditions work) ✅
python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings (pre-existing embeddings/prompts) ✅

Negative paths confirmed:

book_count mismatch → [FAIL] canon_tradition catholic book_count matches canon_list — book_count=999, listed=73
Non-snake_case book id → [FAIL] canon_tradition eastern_orthodox book 'Bad-Cased-Id' is snake_case

With #1541 (extrabiblical content, PR #1589) applied locally on top:

15 canon_list references resolve through extrabiblical.json
15 remain as informational logs (2_maccabees, baruch, 1_esdras, 3_maccabees, prayer_of_manasseh, 1/2/3_meqabyan, letter_of_jeremiah, tagsas) — all books outside the current 12-entry extrabiblical seed. Will stabilize if/when the extrabiblical seed expands in later epic work.

Merge order

Pairs with #1587 (canon_traditions schema, #1539) and #1589 (12 extrabiblical entries, #1541). Any merge order is safe — the shared additions between this and #1587 resolve identically.

Out of scope

Canon Comparison screen UI — HWGTB-P3-01 ([HWGTB-P3-01] App: CanonComparisonScreen #1550).
Additional extrabiblical entries for 2_maccabees, baruch, 1_esdras, etc. — not planned per the epic's scope (Phase 4 expands full_summary for the existing 12 entries only). Unresolved ids log as informational rather than failing, matching the existing pattern for non-Protestant book refs.

Rollback

Revert this PR. canon_traditions table drops on next build_sqlite.py run (tables recreated from schema each build). No user.db migrations.

Generated by Claude Code

github-actions · 2026-04-23T14:40:50Z

Content Pipeline Results

✅ All pipeline checks passed

Step	Status	Details
Schema Validation	✅	136885 passed, 77 failed
Build DB	✅	—
DB Integrity	✅	94 passed, 0 failed

Content Pipeline — Quality & Accuracy Report

✅ All content checks passed

Scope: 0 chapter(s) across 0 book(s)

Generated by ci_content_check.py

github-actions · 2026-04-23T14:41:20Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3474	❌ 0	3474
Suites	✅ 469	❌ 0	469

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 84.4s

Seeds content/meta/canon_traditions.json with the four traditions that feed the Canon Comparison screen: protestant 66 books catholic 73 books eastern_orthodox 76 books ethiopian_tewahedo 81 books Every entry ships with book_count, full canon_list (organized by OT/NT sections), 4 distinctives, and 7–8 chronologically ordered formation_events covering the major councils, letters, and decisions that shaped each tradition (Jamnia, Athanasius' 39th Festal Letter, Hippo/Carthage, Jerome's Prologus Galeatus, Trent, Trullo, Jerusalem 1672, the Haile Selassie Amharic Bible, etc.). Per the issue's dual-table note, canon_list[].books[] ids may reference either books.json (66-book Protestant canon) or extrabiblical.json (deuterocanon, pseudepigrapha, DSS). The schema_validator and validate_sqlite checks are extended to check both tables; ids resolving in neither are logged as informational (expected while the extrabiblical table is seeded incrementally across the epic) but malformed snake_case ids always fail. The canon_traditions table infrastructure (CREATE TABLE, loader, populate registration) authored in #1539 is included here — when #1539 merges first, the overlap is redundant; when this merges first, #1539 becomes a no-op for the shared additions. Editorial commitments per epic guardrails: - Descriptive, not prescriptive. "The Ethiopian Tewahedo Church includes 1 Enoch in its canon" is stated as fact; no tradition is endorsed or rejected. - Factual tone on contested questions (Jamnia council, Trent's dogmatic binding, Meqabyan ≠ Greek Maccabees, 1 Enoch preservation history). - Named primary sources (Athanasius Ep. 39, Westminster 1.3, Vatican II Dei Verbum, Confession of Dositheos, Kebra Nagast). How verified Full pipeline on this branch: - python _tools/build_sqlite.py — canon_traditions: 4 rows (OK) - python _tools/schema_validator.py — 136807 passed, 77 failed (same 77 pre-existing failures as master baseline, 0 new failures from canon_traditions work) - python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings (pre-existing embeddings/prompts warnings) Negative paths confirmed: book_count mismatch, non-snake_case book id, and malformed ids all trigger [FAIL] in both validators. With #1541 (extrabiblical content) applied locally on top: - 15 canon_list references resolve through extrabiblical.json - 15 remain as unresolved informational logs (2_maccabees, baruch, 1_esdras, 3_maccabees, prayer_of_manasseh, 1/2/3_meqabyan, letter_of_jeremiah, tagsas — all represent books outside the current 12-entry extrabiblical seed) Closes#1542

CraigBuckmaster · 2026-04-23T19:34:46Z

Superseded by the replacement PR above, which is rebuilt cleanly on top of #1586 (already merged) so canon_traditions coexists with extrabiblical instead of conflicting. Closing here.

Replaces PR #1590 which was built from a pre-#1586 base and conflicted with the extrabiblical table/validators. This branch is rebuilt cleanly on top of current master (with #1586 landed) so canon_traditions sits alongside extrabiblical rather than replacing it. Adds: - CREATE TABLE canon_traditions in build_sqlite_schema.py - populate_canon_traditions in build_sqlite_loaders.py - canon_traditions invocation in build_sqlite.py - Canon Traditions validation block in schema_validator.py (with dual- table book-ID resolution against books.json + extrabiblical.json, logging unresolved refs informationally) - canon_traditions integrity check in validate_sqlite.py - content/meta/canon_traditions.json seeded with 4 traditions: protestant (66), catholic (73), eastern_orthodox (81), ethiopian_tewahedo (81 broader canon) All five pipeline stages (schema_validator → build_sqlite → validate_sqlite) run green. 32 unresolved book refs are expected and log informationally per #1542 — they resolve as the extrabiblical table is populated incrementally by #1589 and follow-ups.

Replaces PR #1590 which was built from a pre-#1586 base and conflicted with the extrabiblical table/validators. This branch is rebuilt cleanly on top of current master (with #1586 landed) so canon_traditions sits alongside extrabiblical rather than replacing it. Adds: - CREATE TABLE canon_traditions in build_sqlite_schema.py - populate_canon_traditions in build_sqlite_loaders.py - canon_traditions invocation in build_sqlite.py - Canon Traditions validation block in schema_validator.py (with dual- table book-ID resolution against books.json + extrabiblical.json, logging unresolved refs informationally) - canon_traditions integrity check in validate_sqlite.py - content/meta/canon_traditions.json seeded with 4 traditions: protestant (66), catholic (73), eastern_orthodox (81), ethiopian_tewahedo (81 broader canon) All five pipeline stages (schema_validator → build_sqlite → validate_sqlite) run green. 32 unresolved book refs are expected and log informationally per #1542 — they resolve as the extrabiblical table is populated incrementally by #1589 and follow-ups. Co-authored-by: Claude (for Craig) <claude@anthropic.com>

CraigBuckmaster · 2026-04-23T14:31:10Z

What this does

Seeds content/meta/canon_traditions.json with the four traditions that feed the Canon Comparison screen (HWGTB-P3-01 / #1550):

id	label	book_count	distinctives	formation_events
`protestant`	Protestant	66	4	8
`catholic`	Roman Catholic	73	4	8
`eastern_orthodox`	Eastern Orthodox	76	4	7
`ethiopian_tewahedo`	Ethiopian Orthodox Tewahedo	81	4	8

Each entry ships with a full canon_list organized into OT/NT sections, a factual 1–2 paragraph short_description, 4 distinctives, and 7–8 chronologically ordered formation_events (Jamnia, Athanasius' 39th Festal Letter, Hippo/Carthage, Jerome's Prologus Galeatus, Luther's 1534 Bible, Trent Session IV, Trullo Canon 2, Westminster 1.3, Confession of Dositheos, Kebra Nagast, Haile Selassie Amharic Bible, etc.).

Closes

Closes#1542

Dual-table book-ID resolution (per issue note)

canon_list[].books[] ids may reference either books.json (66-book Protestant canon) or extrabiblical.json (deuterocanon, pseudepigrapha, DSS). Extended both validators:

schema_validator.py — new CANON TRADITIONS section checks every book id against both tables, fails on malformed snake_case, and logs unresolved ids (expected while extrabiblical seed is partial) as informational.
validate_sqlite.py — DB-side parallel: book_count vs canon_list_json consistency + dual-table lookup + informational log.

Table infrastructure

The canon_traditions table (CREATE, loader, populate registration) authored in #1539 is also included here so this branch builds end-to-end without prerequisites. When #1587 merges first the overlap is a redundant no-op; when this merges first #1587 becomes a trivial redundant addition.

Editorial commitments

Descriptive, not prescriptive. "The Ethiopian Tewahedo Church includes 1 Enoch in its canon" stated as fact; no tradition endorsed or rejected.
Factual tone on contested questions. Jamnia council thesis flagged as abandoned by modern scholarship (Lewis, Leiman); Trent's dogmatic binding noted as response to Luther; Meqabyan distinguished from Greek 1–4 Maccabees; 1 Enoch's Ethiopian preservation history named (Bruce 1773, Qumran 1947).
Named primary sources. Athanasius Ep. 39, Westminster 1.3, Trent Session IV, Trullo Canon 2, Dei Verbum §9–10, Confession of Dositheos, Kebra Nagast.
No conspiracy framing. Canon formation described as slow, regional, and contested.

How I verified

Final state on this branch (no prerequisite PRs applied):

python _tools/build_sqlite.py — canon_traditions: 4 rows ✅
python _tools/schema_validator.py — 136807 passed, 77 failed (same 77 pre-existing failures as master baseline, 0 new failures from canon_traditions work) ✅
python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings (pre-existing embeddings/prompts) ✅

Negative paths confirmed:

book_count mismatch → [FAIL] canon_tradition catholic book_count matches canon_list — book_count=999, listed=73
Non-snake_case book id → [FAIL] canon_tradition eastern_orthodox book 'Bad-Cased-Id' is snake_case

With #1541 (extrabiblical content, PR #1589) applied locally on top:

15 canon_list references resolve through extrabiblical.json
15 remain as informational logs (2_maccabees, baruch, 1_esdras, 3_maccabees, prayer_of_manasseh, 1/2/3_meqabyan, letter_of_jeremiah, tagsas) — all books outside the current 12-entry extrabiblical seed. Will stabilize if/when the extrabiblical seed expands in later epic work.

Merge order

Pairs with #1587 (canon_traditions schema, #1539) and #1589 (12 extrabiblical entries, #1541). Any merge order is safe — the shared additions between this and #1587 resolve identically.

Out of scope

Canon Comparison screen UI — HWGTB-P3-01 ([HWGTB-P3-01] App: CanonComparisonScreen #1550).
Additional extrabiblical entries for 2_maccabees, baruch, 1_esdras, etc. — not planned per the epic's scope (Phase 4 expands full_summary for the existing 12 entries only). Unresolved ids log as informational rather than failing, matching the existing pattern for non-Protestant book refs.

Rollback

Revert this PR. canon_traditions table drops on next build_sqlite.py run (tables recreated from schema each build). No user.db migrations.

Generated by Claude Code

github-actions · 2026-04-23T14:40:50Z

Content Pipeline Results

✅ All pipeline checks passed

Step	Status	Details
Schema Validation	✅	136885 passed, 77 failed
Build DB	✅	—
DB Integrity	✅	94 passed, 0 failed

Content Pipeline — Quality & Accuracy Report

✅ All content checks passed

Scope: 0 chapter(s) across 0 book(s)

Generated by ci_content_check.py

github-actions · 2026-04-23T14:41:20Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3474	❌ 0	3474
Suites	✅ 469	❌ 0	469

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 84.4s

Seeds content/meta/canon_traditions.json with the four traditions that feed the Canon Comparison screen: protestant 66 books catholic 73 books eastern_orthodox 76 books ethiopian_tewahedo 81 books Every entry ships with book_count, full canon_list (organized by OT/NT sections), 4 distinctives, and 7–8 chronologically ordered formation_events covering the major councils, letters, and decisions that shaped each tradition (Jamnia, Athanasius' 39th Festal Letter, Hippo/Carthage, Jerome's Prologus Galeatus, Trent, Trullo, Jerusalem 1672, the Haile Selassie Amharic Bible, etc.). Per the issue's dual-table note, canon_list[].books[] ids may reference either books.json (66-book Protestant canon) or extrabiblical.json (deuterocanon, pseudepigrapha, DSS). The schema_validator and validate_sqlite checks are extended to check both tables; ids resolving in neither are logged as informational (expected while the extrabiblical table is seeded incrementally across the epic) but malformed snake_case ids always fail. The canon_traditions table infrastructure (CREATE TABLE, loader, populate registration) authored in #1539 is included here — when #1539 merges first, the overlap is redundant; when this merges first, #1539 becomes a no-op for the shared additions. Editorial commitments per epic guardrails: - Descriptive, not prescriptive. "The Ethiopian Tewahedo Church includes 1 Enoch in its canon" is stated as fact; no tradition is endorsed or rejected. - Factual tone on contested questions (Jamnia council, Trent's dogmatic binding, Meqabyan ≠ Greek Maccabees, 1 Enoch preservation history). - Named primary sources (Athanasius Ep. 39, Westminster 1.3, Vatican II Dei Verbum, Confession of Dositheos, Kebra Nagast). How verified Full pipeline on this branch: - python _tools/build_sqlite.py — canon_traditions: 4 rows (OK) - python _tools/schema_validator.py — 136807 passed, 77 failed (same 77 pre-existing failures as master baseline, 0 new failures from canon_traditions work) - python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings (pre-existing embeddings/prompts warnings) Negative paths confirmed: book_count mismatch, non-snake_case book id, and malformed ids all trigger [FAIL] in both validators. With #1541 (extrabiblical content) applied locally on top: - 15 canon_list references resolve through extrabiblical.json - 15 remain as unresolved informational logs (2_maccabees, baruch, 1_esdras, 3_maccabees, prayer_of_manasseh, 1/2/3_meqabyan, letter_of_jeremiah, tagsas — all represent books outside the current 12-entry extrabiblical seed) Closes#1542

CraigBuckmaster · 2026-04-23T19:34:46Z

Superseded by the replacement PR above, which is rebuilt cleanly on top of #1586 (already merged) so canon_traditions coexists with extrabiblical instead of conflicting. Closing here.

Replaces PR #1590 which was built from a pre-#1586 base and conflicted with the extrabiblical table/validators. This branch is rebuilt cleanly on top of current master (with #1586 landed) so canon_traditions sits alongside extrabiblical rather than replacing it. Adds: - CREATE TABLE canon_traditions in build_sqlite_schema.py - populate_canon_traditions in build_sqlite_loaders.py - canon_traditions invocation in build_sqlite.py - Canon Traditions validation block in schema_validator.py (with dual- table book-ID resolution against books.json + extrabiblical.json, logging unresolved refs informationally) - canon_traditions integrity check in validate_sqlite.py - content/meta/canon_traditions.json seeded with 4 traditions: protestant (66), catholic (73), eastern_orthodox (81), ethiopian_tewahedo (81 broader canon) All five pipeline stages (schema_validator → build_sqlite → validate_sqlite) run green. 32 unresolved book refs are expected and log informationally per #1542 — they resolve as the extrabiblical table is populated incrementally by #1589 and follow-ups.

Replaces PR #1590 which was built from a pre-#1586 base and conflicted with the extrabiblical table/validators. This branch is rebuilt cleanly on top of current master (with #1586 landed) so canon_traditions sits alongside extrabiblical rather than replacing it. Adds: - CREATE TABLE canon_traditions in build_sqlite_schema.py - populate_canon_traditions in build_sqlite_loaders.py - canon_traditions invocation in build_sqlite.py - Canon Traditions validation block in schema_validator.py (with dual- table book-ID resolution against books.json + extrabiblical.json, logging unresolved refs informationally) - canon_traditions integrity check in validate_sqlite.py - content/meta/canon_traditions.json seeded with 4 traditions: protestant (66), catholic (73), eastern_orthodox (81), ethiopian_tewahedo (81 broader canon) All five pipeline stages (schema_validator → build_sqlite → validate_sqlite) run green. 32 unresolved book refs are expected and log informationally per #1542 — they resolve as the extrabiblical table is populated incrementally by #1589 and follow-ups. Co-authored-by: Claude (for Craig) <claude@anthropic.com>

CraigBuckmaster · 2026-04-23T14:31:10Z

What this does

Seeds content/meta/canon_traditions.json with the four traditions that feed the Canon Comparison screen (HWGTB-P3-01 / #1550):

id	label	book_count	distinctives	formation_events
`protestant`	Protestant	66	4	8
`catholic`	Roman Catholic	73	4	8
`eastern_orthodox`	Eastern Orthodox	76	4	7
`ethiopian_tewahedo`	Ethiopian Orthodox Tewahedo	81	4	8

Each entry ships with a full canon_list organized into OT/NT sections, a factual 1–2 paragraph short_description, 4 distinctives, and 7–8 chronologically ordered formation_events (Jamnia, Athanasius' 39th Festal Letter, Hippo/Carthage, Jerome's Prologus Galeatus, Luther's 1534 Bible, Trent Session IV, Trullo Canon 2, Westminster 1.3, Confession of Dositheos, Kebra Nagast, Haile Selassie Amharic Bible, etc.).

Closes

Closes#1542

Dual-table book-ID resolution (per issue note)

canon_list[].books[] ids may reference either books.json (66-book Protestant canon) or extrabiblical.json (deuterocanon, pseudepigrapha, DSS). Extended both validators:

schema_validator.py — new CANON TRADITIONS section checks every book id against both tables, fails on malformed snake_case, and logs unresolved ids (expected while extrabiblical seed is partial) as informational.
validate_sqlite.py — DB-side parallel: book_count vs canon_list_json consistency + dual-table lookup + informational log.

Table infrastructure

The canon_traditions table (CREATE, loader, populate registration) authored in #1539 is also included here so this branch builds end-to-end without prerequisites. When #1587 merges first the overlap is a redundant no-op; when this merges first #1587 becomes a trivial redundant addition.

Editorial commitments

Descriptive, not prescriptive. "The Ethiopian Tewahedo Church includes 1 Enoch in its canon" stated as fact; no tradition endorsed or rejected.
Factual tone on contested questions. Jamnia council thesis flagged as abandoned by modern scholarship (Lewis, Leiman); Trent's dogmatic binding noted as response to Luther; Meqabyan distinguished from Greek 1–4 Maccabees; 1 Enoch's Ethiopian preservation history named (Bruce 1773, Qumran 1947).
Named primary sources. Athanasius Ep. 39, Westminster 1.3, Trent Session IV, Trullo Canon 2, Dei Verbum §9–10, Confession of Dositheos, Kebra Nagast.
No conspiracy framing. Canon formation described as slow, regional, and contested.

How I verified

Final state on this branch (no prerequisite PRs applied):

python _tools/build_sqlite.py — canon_traditions: 4 rows ✅
python _tools/schema_validator.py — 136807 passed, 77 failed (same 77 pre-existing failures as master baseline, 0 new failures from canon_traditions work) ✅
python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings (pre-existing embeddings/prompts) ✅

Negative paths confirmed:

book_count mismatch → [FAIL] canon_tradition catholic book_count matches canon_list — book_count=999, listed=73
Non-snake_case book id → [FAIL] canon_tradition eastern_orthodox book 'Bad-Cased-Id' is snake_case

With #1541 (extrabiblical content, PR #1589) applied locally on top:

15 canon_list references resolve through extrabiblical.json
15 remain as informational logs (2_maccabees, baruch, 1_esdras, 3_maccabees, prayer_of_manasseh, 1/2/3_meqabyan, letter_of_jeremiah, tagsas) — all books outside the current 12-entry extrabiblical seed. Will stabilize if/when the extrabiblical seed expands in later epic work.

Merge order

Pairs with #1587 (canon_traditions schema, #1539) and #1589 (12 extrabiblical entries, #1541). Any merge order is safe — the shared additions between this and #1587 resolve identically.

Out of scope

Canon Comparison screen UI — HWGTB-P3-01 ([HWGTB-P3-01] App: CanonComparisonScreen #1550).
Additional extrabiblical entries for 2_maccabees, baruch, 1_esdras, etc. — not planned per the epic's scope (Phase 4 expands full_summary for the existing 12 entries only). Unresolved ids log as informational rather than failing, matching the existing pattern for non-Protestant book refs.

Rollback

Revert this PR. canon_traditions table drops on next build_sqlite.py run (tables recreated from schema each build). No user.db migrations.

Generated by Claude Code

github-actions · 2026-04-23T14:40:50Z

Content Pipeline Results

✅ All pipeline checks passed

Step	Status	Details
Schema Validation	✅	136885 passed, 77 failed
Build DB	✅	—
DB Integrity	✅	94 passed, 0 failed

Content Pipeline — Quality & Accuracy Report

✅ All content checks passed

Scope: 0 chapter(s) across 0 book(s)

Generated by ci_content_check.py

github-actions · 2026-04-23T14:41:20Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3474	❌ 0	3474
Suites	✅ 469	❌ 0	469

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 84.4s

Seeds content/meta/canon_traditions.json with the four traditions that feed the Canon Comparison screen: protestant 66 books catholic 73 books eastern_orthodox 76 books ethiopian_tewahedo 81 books Every entry ships with book_count, full canon_list (organized by OT/NT sections), 4 distinctives, and 7–8 chronologically ordered formation_events covering the major councils, letters, and decisions that shaped each tradition (Jamnia, Athanasius' 39th Festal Letter, Hippo/Carthage, Jerome's Prologus Galeatus, Trent, Trullo, Jerusalem 1672, the Haile Selassie Amharic Bible, etc.). Per the issue's dual-table note, canon_list[].books[] ids may reference either books.json (66-book Protestant canon) or extrabiblical.json (deuterocanon, pseudepigrapha, DSS). The schema_validator and validate_sqlite checks are extended to check both tables; ids resolving in neither are logged as informational (expected while the extrabiblical table is seeded incrementally across the epic) but malformed snake_case ids always fail. The canon_traditions table infrastructure (CREATE TABLE, loader, populate registration) authored in #1539 is included here — when #1539 merges first, the overlap is redundant; when this merges first, #1539 becomes a no-op for the shared additions. Editorial commitments per epic guardrails: - Descriptive, not prescriptive. "The Ethiopian Tewahedo Church includes 1 Enoch in its canon" is stated as fact; no tradition is endorsed or rejected. - Factual tone on contested questions (Jamnia council, Trent's dogmatic binding, Meqabyan ≠ Greek Maccabees, 1 Enoch preservation history). - Named primary sources (Athanasius Ep. 39, Westminster 1.3, Vatican II Dei Verbum, Confession of Dositheos, Kebra Nagast). How verified Full pipeline on this branch: - python _tools/build_sqlite.py — canon_traditions: 4 rows (OK) - python _tools/schema_validator.py — 136807 passed, 77 failed (same 77 pre-existing failures as master baseline, 0 new failures from canon_traditions work) - python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings (pre-existing embeddings/prompts warnings) Negative paths confirmed: book_count mismatch, non-snake_case book id, and malformed ids all trigger [FAIL] in both validators. With #1541 (extrabiblical content) applied locally on top: - 15 canon_list references resolve through extrabiblical.json - 15 remain as unresolved informational logs (2_maccabees, baruch, 1_esdras, 3_maccabees, prayer_of_manasseh, 1/2/3_meqabyan, letter_of_jeremiah, tagsas — all represent books outside the current 12-entry extrabiblical seed) Closes#1542

CraigBuckmaster · 2026-04-23T19:34:46Z

Superseded by the replacement PR above, which is rebuilt cleanly on top of #1586 (already merged) so canon_traditions coexists with extrabiblical instead of conflicting. Closing here.

Replaces PR #1590 which was built from a pre-#1586 base and conflicted with the extrabiblical table/validators. This branch is rebuilt cleanly on top of current master (with #1586 landed) so canon_traditions sits alongside extrabiblical rather than replacing it. Adds: - CREATE TABLE canon_traditions in build_sqlite_schema.py - populate_canon_traditions in build_sqlite_loaders.py - canon_traditions invocation in build_sqlite.py - Canon Traditions validation block in schema_validator.py (with dual- table book-ID resolution against books.json + extrabiblical.json, logging unresolved refs informationally) - canon_traditions integrity check in validate_sqlite.py - content/meta/canon_traditions.json seeded with 4 traditions: protestant (66), catholic (73), eastern_orthodox (81), ethiopian_tewahedo (81 broader canon) All five pipeline stages (schema_validator → build_sqlite → validate_sqlite) run green. 32 unresolved book refs are expected and log informationally per #1542 — they resolve as the extrabiblical table is populated incrementally by #1589 and follow-ups.

Replaces PR #1590 which was built from a pre-#1586 base and conflicted with the extrabiblical table/validators. This branch is rebuilt cleanly on top of current master (with #1586 landed) so canon_traditions sits alongside extrabiblical rather than replacing it. Adds: - CREATE TABLE canon_traditions in build_sqlite_schema.py - populate_canon_traditions in build_sqlite_loaders.py - canon_traditions invocation in build_sqlite.py - Canon Traditions validation block in schema_validator.py (with dual- table book-ID resolution against books.json + extrabiblical.json, logging unresolved refs informationally) - canon_traditions integrity check in validate_sqlite.py - content/meta/canon_traditions.json seeded with 4 traditions: protestant (66), catholic (73), eastern_orthodox (81), ethiopian_tewahedo (81 broader canon) All five pipeline stages (schema_validator → build_sqlite → validate_sqlite) run green. 32 unresolved book refs are expected and log informationally per #1542 — they resolve as the extrabiblical table is populated incrementally by #1589 and follow-ups. Co-authored-by: Claude (for Craig) <claude@anthropic.com>

CraigBuckmaster · 2026-04-23T14:31:10Z

What this does

Seeds content/meta/canon_traditions.json with the four traditions that feed the Canon Comparison screen (HWGTB-P3-01 / #1550):

id	label	book_count	distinctives	formation_events
`protestant`	Protestant	66	4	8
`catholic`	Roman Catholic	73	4	8
`eastern_orthodox`	Eastern Orthodox	76	4	7
`ethiopian_tewahedo`	Ethiopian Orthodox Tewahedo	81	4	8

Each entry ships with a full canon_list organized into OT/NT sections, a factual 1–2 paragraph short_description, 4 distinctives, and 7–8 chronologically ordered formation_events (Jamnia, Athanasius' 39th Festal Letter, Hippo/Carthage, Jerome's Prologus Galeatus, Luther's 1534 Bible, Trent Session IV, Trullo Canon 2, Westminster 1.3, Confession of Dositheos, Kebra Nagast, Haile Selassie Amharic Bible, etc.).

Closes

Closes#1542

Dual-table book-ID resolution (per issue note)

canon_list[].books[] ids may reference either books.json (66-book Protestant canon) or extrabiblical.json (deuterocanon, pseudepigrapha, DSS). Extended both validators:

schema_validator.py — new CANON TRADITIONS section checks every book id against both tables, fails on malformed snake_case, and logs unresolved ids (expected while extrabiblical seed is partial) as informational.
validate_sqlite.py — DB-side parallel: book_count vs canon_list_json consistency + dual-table lookup + informational log.

Table infrastructure

The canon_traditions table (CREATE, loader, populate registration) authored in #1539 is also included here so this branch builds end-to-end without prerequisites. When #1587 merges first the overlap is a redundant no-op; when this merges first #1587 becomes a trivial redundant addition.

Editorial commitments

Descriptive, not prescriptive. "The Ethiopian Tewahedo Church includes 1 Enoch in its canon" stated as fact; no tradition endorsed or rejected.
Factual tone on contested questions. Jamnia council thesis flagged as abandoned by modern scholarship (Lewis, Leiman); Trent's dogmatic binding noted as response to Luther; Meqabyan distinguished from Greek 1–4 Maccabees; 1 Enoch's Ethiopian preservation history named (Bruce 1773, Qumran 1947).
Named primary sources. Athanasius Ep. 39, Westminster 1.3, Trent Session IV, Trullo Canon 2, Dei Verbum §9–10, Confession of Dositheos, Kebra Nagast.
No conspiracy framing. Canon formation described as slow, regional, and contested.

How I verified

Final state on this branch (no prerequisite PRs applied):

python _tools/build_sqlite.py — canon_traditions: 4 rows ✅
python _tools/schema_validator.py — 136807 passed, 77 failed (same 77 pre-existing failures as master baseline, 0 new failures from canon_traditions work) ✅
python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings (pre-existing embeddings/prompts) ✅

Negative paths confirmed:

book_count mismatch → [FAIL] canon_tradition catholic book_count matches canon_list — book_count=999, listed=73
Non-snake_case book id → [FAIL] canon_tradition eastern_orthodox book 'Bad-Cased-Id' is snake_case

With #1541 (extrabiblical content, PR #1589) applied locally on top:

15 canon_list references resolve through extrabiblical.json
15 remain as informational logs (2_maccabees, baruch, 1_esdras, 3_maccabees, prayer_of_manasseh, 1/2/3_meqabyan, letter_of_jeremiah, tagsas) — all books outside the current 12-entry extrabiblical seed. Will stabilize if/when the extrabiblical seed expands in later epic work.

Merge order

Pairs with #1587 (canon_traditions schema, #1539) and #1589 (12 extrabiblical entries, #1541). Any merge order is safe — the shared additions between this and #1587 resolve identically.

Out of scope

Canon Comparison screen UI — HWGTB-P3-01 ([HWGTB-P3-01] App: CanonComparisonScreen #1550).
Additional extrabiblical entries for 2_maccabees, baruch, 1_esdras, etc. — not planned per the epic's scope (Phase 4 expands full_summary for the existing 12 entries only). Unresolved ids log as informational rather than failing, matching the existing pattern for non-Protestant book refs.

Rollback

Revert this PR. canon_traditions table drops on next build_sqlite.py run (tables recreated from schema each build). No user.db migrations.

Generated by Claude Code

github-actions · 2026-04-23T14:40:50Z

Content Pipeline Results

✅ All pipeline checks passed

Step	Status	Details
Schema Validation	✅	136885 passed, 77 failed
Build DB	✅	—
DB Integrity	✅	94 passed, 0 failed

Content Pipeline — Quality & Accuracy Report

✅ All content checks passed

Scope: 0 chapter(s) across 0 book(s)

Generated by ci_content_check.py

github-actions · 2026-04-23T14:41:20Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3474	❌ 0	3474
Suites	✅ 469	❌ 0	469

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 84.4s

Seeds content/meta/canon_traditions.json with the four traditions that feed the Canon Comparison screen: protestant 66 books catholic 73 books eastern_orthodox 76 books ethiopian_tewahedo 81 books Every entry ships with book_count, full canon_list (organized by OT/NT sections), 4 distinctives, and 7–8 chronologically ordered formation_events covering the major councils, letters, and decisions that shaped each tradition (Jamnia, Athanasius' 39th Festal Letter, Hippo/Carthage, Jerome's Prologus Galeatus, Trent, Trullo, Jerusalem 1672, the Haile Selassie Amharic Bible, etc.). Per the issue's dual-table note, canon_list[].books[] ids may reference either books.json (66-book Protestant canon) or extrabiblical.json (deuterocanon, pseudepigrapha, DSS). The schema_validator and validate_sqlite checks are extended to check both tables; ids resolving in neither are logged as informational (expected while the extrabiblical table is seeded incrementally across the epic) but malformed snake_case ids always fail. The canon_traditions table infrastructure (CREATE TABLE, loader, populate registration) authored in #1539 is included here — when #1539 merges first, the overlap is redundant; when this merges first, #1539 becomes a no-op for the shared additions. Editorial commitments per epic guardrails: - Descriptive, not prescriptive. "The Ethiopian Tewahedo Church includes 1 Enoch in its canon" is stated as fact; no tradition is endorsed or rejected. - Factual tone on contested questions (Jamnia council, Trent's dogmatic binding, Meqabyan ≠ Greek Maccabees, 1 Enoch preservation history). - Named primary sources (Athanasius Ep. 39, Westminster 1.3, Vatican II Dei Verbum, Confession of Dositheos, Kebra Nagast). How verified Full pipeline on this branch: - python _tools/build_sqlite.py — canon_traditions: 4 rows (OK) - python _tools/schema_validator.py — 136807 passed, 77 failed (same 77 pre-existing failures as master baseline, 0 new failures from canon_traditions work) - python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings (pre-existing embeddings/prompts warnings) Negative paths confirmed: book_count mismatch, non-snake_case book id, and malformed ids all trigger [FAIL] in both validators. With #1541 (extrabiblical content) applied locally on top: - 15 canon_list references resolve through extrabiblical.json - 15 remain as unresolved informational logs (2_maccabees, baruch, 1_esdras, 3_maccabees, prayer_of_manasseh, 1/2/3_meqabyan, letter_of_jeremiah, tagsas — all represent books outside the current 12-entry extrabiblical seed) Closes#1542

CraigBuckmaster · 2026-04-23T19:34:46Z

Superseded by the replacement PR above, which is rebuilt cleanly on top of #1586 (already merged) so canon_traditions coexists with extrabiblical instead of conflicting. Closing here.

Replaces PR #1590 which was built from a pre-#1586 base and conflicted with the extrabiblical table/validators. This branch is rebuilt cleanly on top of current master (with #1586 landed) so canon_traditions sits alongside extrabiblical rather than replacing it. Adds: - CREATE TABLE canon_traditions in build_sqlite_schema.py - populate_canon_traditions in build_sqlite_loaders.py - canon_traditions invocation in build_sqlite.py - Canon Traditions validation block in schema_validator.py (with dual- table book-ID resolution against books.json + extrabiblical.json, logging unresolved refs informationally) - canon_traditions integrity check in validate_sqlite.py - content/meta/canon_traditions.json seeded with 4 traditions: protestant (66), catholic (73), eastern_orthodox (81), ethiopian_tewahedo (81 broader canon) All five pipeline stages (schema_validator → build_sqlite → validate_sqlite) run green. 32 unresolved book refs are expected and log informationally per #1542 — they resolve as the extrabiblical table is populated incrementally by #1589 and follow-ups.

Replaces PR #1590 which was built from a pre-#1586 base and conflicted with the extrabiblical table/validators. This branch is rebuilt cleanly on top of current master (with #1586 landed) so canon_traditions sits alongside extrabiblical rather than replacing it. Adds: - CREATE TABLE canon_traditions in build_sqlite_schema.py - populate_canon_traditions in build_sqlite_loaders.py - canon_traditions invocation in build_sqlite.py - Canon Traditions validation block in schema_validator.py (with dual- table book-ID resolution against books.json + extrabiblical.json, logging unresolved refs informationally) - canon_traditions integrity check in validate_sqlite.py - content/meta/canon_traditions.json seeded with 4 traditions: protestant (66), catholic (73), eastern_orthodox (81), ethiopian_tewahedo (81 broader canon) All five pipeline stages (schema_validator → build_sqlite → validate_sqlite) run green. 32 unresolved book refs are expected and log informationally per #1542 — they resolve as the extrabiblical table is populated incrementally by #1589 and follow-ups. Co-authored-by: Claude (for Craig) <claude@anthropic.com>

CraigBuckmaster · 2026-04-23T14:31:10Z

What this does

Seeds content/meta/canon_traditions.json with the four traditions that feed the Canon Comparison screen (HWGTB-P3-01 / #1550):

id	label	book_count	distinctives	formation_events
`protestant`	Protestant	66	4	8
`catholic`	Roman Catholic	73	4	8
`eastern_orthodox`	Eastern Orthodox	76	4	7
`ethiopian_tewahedo`	Ethiopian Orthodox Tewahedo	81	4	8

Each entry ships with a full canon_list organized into OT/NT sections, a factual 1–2 paragraph short_description, 4 distinctives, and 7–8 chronologically ordered formation_events (Jamnia, Athanasius' 39th Festal Letter, Hippo/Carthage, Jerome's Prologus Galeatus, Luther's 1534 Bible, Trent Session IV, Trullo Canon 2, Westminster 1.3, Confession of Dositheos, Kebra Nagast, Haile Selassie Amharic Bible, etc.).

Closes

Closes#1542

Dual-table book-ID resolution (per issue note)

canon_list[].books[] ids may reference either books.json (66-book Protestant canon) or extrabiblical.json (deuterocanon, pseudepigrapha, DSS). Extended both validators:

schema_validator.py — new CANON TRADITIONS section checks every book id against both tables, fails on malformed snake_case, and logs unresolved ids (expected while extrabiblical seed is partial) as informational.
validate_sqlite.py — DB-side parallel: book_count vs canon_list_json consistency + dual-table lookup + informational log.

Table infrastructure

The canon_traditions table (CREATE, loader, populate registration) authored in #1539 is also included here so this branch builds end-to-end without prerequisites. When #1587 merges first the overlap is a redundant no-op; when this merges first #1587 becomes a trivial redundant addition.

Editorial commitments

Descriptive, not prescriptive. "The Ethiopian Tewahedo Church includes 1 Enoch in its canon" stated as fact; no tradition endorsed or rejected.
Factual tone on contested questions. Jamnia council thesis flagged as abandoned by modern scholarship (Lewis, Leiman); Trent's dogmatic binding noted as response to Luther; Meqabyan distinguished from Greek 1–4 Maccabees; 1 Enoch's Ethiopian preservation history named (Bruce 1773, Qumran 1947).
Named primary sources. Athanasius Ep. 39, Westminster 1.3, Trent Session IV, Trullo Canon 2, Dei Verbum §9–10, Confession of Dositheos, Kebra Nagast.
No conspiracy framing. Canon formation described as slow, regional, and contested.

How I verified

Final state on this branch (no prerequisite PRs applied):

python _tools/build_sqlite.py — canon_traditions: 4 rows ✅
python _tools/schema_validator.py — 136807 passed, 77 failed (same 77 pre-existing failures as master baseline, 0 new failures from canon_traditions work) ✅
python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings (pre-existing embeddings/prompts) ✅

Negative paths confirmed:

book_count mismatch → [FAIL] canon_tradition catholic book_count matches canon_list — book_count=999, listed=73
Non-snake_case book id → [FAIL] canon_tradition eastern_orthodox book 'Bad-Cased-Id' is snake_case

With #1541 (extrabiblical content, PR #1589) applied locally on top:

15 canon_list references resolve through extrabiblical.json
15 remain as informational logs (2_maccabees, baruch, 1_esdras, 3_maccabees, prayer_of_manasseh, 1/2/3_meqabyan, letter_of_jeremiah, tagsas) — all books outside the current 12-entry extrabiblical seed. Will stabilize if/when the extrabiblical seed expands in later epic work.

Merge order

Pairs with #1587 (canon_traditions schema, #1539) and #1589 (12 extrabiblical entries, #1541). Any merge order is safe — the shared additions between this and #1587 resolve identically.

Out of scope

Canon Comparison screen UI — HWGTB-P3-01 ([HWGTB-P3-01] App: CanonComparisonScreen #1550).
Additional extrabiblical entries for 2_maccabees, baruch, 1_esdras, etc. — not planned per the epic's scope (Phase 4 expands full_summary for the existing 12 entries only). Unresolved ids log as informational rather than failing, matching the existing pattern for non-Protestant book refs.

Rollback

Revert this PR. canon_traditions table drops on next build_sqlite.py run (tables recreated from schema each build). No user.db migrations.

Generated by Claude Code

github-actions · 2026-04-23T14:40:50Z

Content Pipeline Results

✅ All pipeline checks passed

Step	Status	Details
Schema Validation	✅	136885 passed, 77 failed
Build DB	✅	—
DB Integrity	✅	94 passed, 0 failed

Content Pipeline — Quality & Accuracy Report

✅ All content checks passed

Scope: 0 chapter(s) across 0 book(s)

Generated by ci_content_check.py

github-actions · 2026-04-23T14:41:20Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3474	❌ 0	3474
Suites	✅ 469	❌ 0	469

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 84.4s

Seeds content/meta/canon_traditions.json with the four traditions that feed the Canon Comparison screen: protestant 66 books catholic 73 books eastern_orthodox 76 books ethiopian_tewahedo 81 books Every entry ships with book_count, full canon_list (organized by OT/NT sections), 4 distinctives, and 7–8 chronologically ordered formation_events covering the major councils, letters, and decisions that shaped each tradition (Jamnia, Athanasius' 39th Festal Letter, Hippo/Carthage, Jerome's Prologus Galeatus, Trent, Trullo, Jerusalem 1672, the Haile Selassie Amharic Bible, etc.). Per the issue's dual-table note, canon_list[].books[] ids may reference either books.json (66-book Protestant canon) or extrabiblical.json (deuterocanon, pseudepigrapha, DSS). The schema_validator and validate_sqlite checks are extended to check both tables; ids resolving in neither are logged as informational (expected while the extrabiblical table is seeded incrementally across the epic) but malformed snake_case ids always fail. The canon_traditions table infrastructure (CREATE TABLE, loader, populate registration) authored in #1539 is included here — when #1539 merges first, the overlap is redundant; when this merges first, #1539 becomes a no-op for the shared additions. Editorial commitments per epic guardrails: - Descriptive, not prescriptive. "The Ethiopian Tewahedo Church includes 1 Enoch in its canon" is stated as fact; no tradition is endorsed or rejected. - Factual tone on contested questions (Jamnia council, Trent's dogmatic binding, Meqabyan ≠ Greek Maccabees, 1 Enoch preservation history). - Named primary sources (Athanasius Ep. 39, Westminster 1.3, Vatican II Dei Verbum, Confession of Dositheos, Kebra Nagast). How verified Full pipeline on this branch: - python _tools/build_sqlite.py — canon_traditions: 4 rows (OK) - python _tools/schema_validator.py — 136807 passed, 77 failed (same 77 pre-existing failures as master baseline, 0 new failures from canon_traditions work) - python _tools/validate_sqlite.py — 94 passed, 0 failed, 2 warnings (pre-existing embeddings/prompts warnings) Negative paths confirmed: book_count mismatch, non-snake_case book id, and malformed ids all trigger [FAIL] in both validators. With #1541 (extrabiblical content) applied locally on top: - 15 canon_list references resolve through extrabiblical.json - 15 remain as unresolved informational logs (2_maccabees, baruch, 1_esdras, 3_maccabees, prayer_of_manasseh, 1/2/3_meqabyan, letter_of_jeremiah, tagsas — all represent books outside the current 12-entry extrabiblical seed) Closes#1542

CraigBuckmaster · 2026-04-23T19:34:46Z

Superseded by the replacement PR above, which is rebuilt cleanly on top of #1586 (already merged) so canon_traditions coexists with extrabiblical instead of conflicting. Closing here.

Replaces PR #1590 which was built from a pre-#1586 base and conflicted with the extrabiblical table/validators. This branch is rebuilt cleanly on top of current master (with #1586 landed) so canon_traditions sits alongside extrabiblical rather than replacing it. Adds: - CREATE TABLE canon_traditions in build_sqlite_schema.py - populate_canon_traditions in build_sqlite_loaders.py - canon_traditions invocation in build_sqlite.py - Canon Traditions validation block in schema_validator.py (with dual- table book-ID resolution against books.json + extrabiblical.json, logging unresolved refs informationally) - canon_traditions integrity check in validate_sqlite.py - content/meta/canon_traditions.json seeded with 4 traditions: protestant (66), catholic (73), eastern_orthodox (81), ethiopian_tewahedo (81 broader canon) All five pipeline stages (schema_validator → build_sqlite → validate_sqlite) run green. 32 unresolved book refs are expected and log informationally per #1542 — they resolve as the extrabiblical table is populated incrementally by #1589 and follow-ups.

Replaces PR #1590 which was built from a pre-#1586 base and conflicted with the extrabiblical table/validators. This branch is rebuilt cleanly on top of current master (with #1586 landed) so canon_traditions sits alongside extrabiblical rather than replacing it. Adds: - CREATE TABLE canon_traditions in build_sqlite_schema.py - populate_canon_traditions in build_sqlite_loaders.py - canon_traditions invocation in build_sqlite.py - Canon Traditions validation block in schema_validator.py (with dual- table book-ID resolution against books.json + extrabiblical.json, logging unresolved refs informationally) - canon_traditions integrity check in validate_sqlite.py - content/meta/canon_traditions.json seeded with 4 traditions: protestant (66), catholic (73), eastern_orthodox (81), ethiopian_tewahedo (81 broader canon) All five pipeline stages (schema_validator → build_sqlite → validate_sqlite) run green. 32 unresolved book refs are expected and log informationally per #1542 — they resolve as the extrabiblical table is populated incrementally by #1589 and follow-ups. Co-authored-by: Claude (for Craig) <claude@anthropic.com>

This was referenced Apr 23, 2026
feat(app): CanonComparisonScreen (#1550) #1600
Merged
feat: add canon_traditions meta table + validator (#1539) #1587
Closed