Skip to content

feat(app): ExtraBiblicalDetailScreen (#1548)#1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CraigBuckmaster merged 1 commit into from
Apr 23, 2026
Merged

feat(app): ExtraBiblicalDetailScreen (#1548) #1597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
312 changes: 312 additions & 0 deletions app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,312 @@
/**
* ExtraBiblicalDetailScreen.test.tsx — Detail view for one extrabiblical
* entry (HWGTB-P2-03 / #1548).
*/

import React from 'react';
import { fireEvent } from '@testing-library/react-native';
import { Linking } from 'react-native';
import { renderWithProviders } from '../helpers/renderWithProviders';
import ExtraBiblicalDetailScreen from '@/screens/ExtraBiblicalDetailScreen';
import type { ExtrabiblicalEntry } from '@/types';

// ── Navigation mock ─────────────────────────────────────────────
const mockNavigate = jest.fn();
const mockGoBack = jest.fn();
jest.mock('@react-navigation/native', () => {
const actual = jest.requireActual('@react-navigation/native');
return {
...actual,
useNavigation: () => ({
navigate: mockNavigate,
goBack: mockGoBack,
push: jest.fn(),
setOptions: jest.fn(),
}),
useRoute: () => ({ params: { id: '1_enoch' } }),
useScrollToTop: jest.fn(),
useFocusEffect: (cb: () => void) => cb(),
};
});

jest.mock('lucide-react-native', () => ({
ChevronLeft: () => null,
ArrowLeft: () => null,
Search: () => null,
X: () => null,
}));

jest.mock('react-native-safe-area-context', () => ({
SafeAreaView: ({ children }: any) => children,
useSafeAreaInsets: () => ({ top: 44, bottom: 34, left: 0, right: 0 }),
}));

// ── Premium mock — mutable for per-test flip ─────────────────────
let mockIsPremium = true;
const mockShowUpgrade = jest.fn();
const mockDismissUpgrade = jest.fn();
let mockUpgradeRequest: { variant: string; featureName: string } | null = null;
jest.mock('@/hooks/usePremium', () => ({
usePremium: () => ({
isPremium: mockIsPremium,
upgradeRequest: mockUpgradeRequest,
showUpgrade: mockShowUpgrade,
dismissUpgrade: mockDismissUpgrade,
}),
}));

// ── Entry fixture ───────────────────────────────────────────────
const FIXTURE: ExtrabiblicalEntry = {
id: '1_enoch',
title: '1 Enoch (Ethiopic Enoch)',
also_known_as: ['Book of Enoch', 'Ethiopic Enoch'],
category: 'pseudepigrapha',
estimated_date: '3rd c. BC – 1st c. AD',
original_language: 'Aramaic / Hebrew, preserved in Ethiopic Geʽez',
tradition_status: {
protestant: 'not canonical',
catholic: 'not canonical',
eastern_orthodox: 'not canonical',
ethiopian_tewahedo: 'canonical (81-book canon)',
},
brief_summary:
'1 Enoch is a composite work of five distinct books.\n\nIt is preserved complete only in Ethiopic Geʽez.',
full_summary: null,
nt_citations: [
{ ref: 'Jude 14-15', cites: '1 Enoch 1:9', type: 'direct_quotation' },
],
ot_allusions: [
{ ref: 'Genesis 6:1-4', connection: 'The Watchers expand Gen 6:1-4.' },
],
scholar_voices: [
{
scholar_id: 'nickelsburg',
position: "Hermeneia commentary on 1 Enoch.",
},
],
related_debate_ids: ['did-jude-affirm-enoch-as-scripture'],
related_journey_ids: ['canon-formation'],
related_difficult_passage_ids: ['jude-quotes-enoch'],
tags: ['pseudepigrapha', 'hwgtb'],
further_reading: [
{
title: '1 Enoch 1',
author: 'Nickelsburg',
note: 'Hermeneia (2001)',
},
{
title: 'Online Aramaic fragments archive',
url: 'https://example.org/1enoch-aramaic',
},
],
};

let mockEntry: ExtrabiblicalEntry | null = FIXTURE;
let mockLoading = false;
jest.mock('@/hooks/useExtraBiblicalEntry', () => ({
useExtraBiblicalEntry: () => ({ entry: mockEntry, loading: mockLoading }),
}));

beforeEach(() => {
jest.clearAllMocks();
mockIsPremium = true;
mockUpgradeRequest = null;
mockEntry = FIXTURE;
mockLoading = false;
});

describe('ExtraBiblicalDetailScreen', () => {
describe('render — premium tier', () => {
it('renders hero title + aliases', () => {
const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
// Title appears twice: screen header + hero card
expect(getAllByText('1 Enoch (Ethiopic Enoch)').length).toBeGreaterThanOrEqual(1);
expect(getByText(/Also known as:.*Book of Enoch.*Ethiopic Enoch/)).toBeTruthy();
});

it('renders tradition badges', () => {
const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
expect(getByLabelText(/^Protestant:/)).toBeTruthy();
expect(getByLabelText(/^Ethiopian Tewahedo:/)).toBeTruthy();
});

it('renders full brief_summary (both paragraphs)', () => {
const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
expect(
getByText(/1 Enoch is a composite work of five distinct books\./),
).toBeTruthy();
expect(getByText(/It is preserved complete only in Ethiopic Geʽez\./)).toBeTruthy();
});

it('renders NT citations with ref + source + type', () => {
const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
expect(getByText('Jude 14-15')).toBeTruthy();
expect(getByText(/→ 1 Enoch 1:9/)).toBeTruthy();
expect(getByText('Direct quotation')).toBeTruthy();
});

it('renders OT allusions', () => {
const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
expect(getByText('Genesis 6:1-4')).toBeTruthy();
expect(getByText(/The Watchers expand Gen 6:1-4/)).toBeTruthy();
});

it('renders scholar voices', () => {
const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
// 'Nickelsburg' appears twice: scholar-voice name AND further-reading author
expect(getAllByText('Nickelsburg').length).toBeGreaterThanOrEqual(1);
expect(getByText(/Hermeneia commentary on 1 Enoch/)).toBeTruthy();
});

it('renders related-debate chip and section header', () => {
const { getByLabelText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
expect(getByText('RELATED DEBATES')).toBeTruthy();
expect(
getByLabelText('Open debate did-jude-affirm-enoch-as-scripture'),
).toBeTruthy();
});

it('renders related-difficult-passage and related-journey chips', () => {
const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
expect(getByLabelText('Open difficult jude-quotes-enoch')).toBeTruthy();
expect(getByLabelText('Open journey canon-formation')).toBeTruthy();
});

it('renders further-reading items', () => {
const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
expect(getByText('1 Enoch 1')).toBeTruthy();
expect(getAllByText('Nickelsburg').length).toBeGreaterThanOrEqual(1);
expect(getByText('Online Aramaic fragments archive')).toBeTruthy();
});

it('renders "Coming soon" placeholder when full_summary is null', () => {
const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
expect(getByText(/Coming soon — expanded scholarly summary/)).toBeTruthy();
});

it('renders full_summary when it is present instead of placeholder', () => {
mockEntry = { ...FIXTURE, full_summary: 'Expanded analysis goes here.' };
const { getByText, queryByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
expect(getByText('Expanded analysis goes here.')).toBeTruthy();
expect(queryByText(/Coming soon/)).toBeNull();
});
});

describe('deep-link navigation — premium tier', () => {
it('tapping NT citation navigates to Chapter with parsed book/chapter/verse', () => {
const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
fireEvent.press(getByLabelText('Open Jude 14-15'));
expect(mockNavigate).toHaveBeenCalledWith(
'Chapter',
expect.objectContaining({ bookId: 'jude', chapterNum: 1 }),
);
});

it('tapping OT allusion navigates to Chapter with bookId', () => {
const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
fireEvent.press(getByLabelText('Open Genesis 6:1-4'));
expect(mockNavigate).toHaveBeenCalledWith(
'Chapter',
expect.objectContaining({ bookId: 'genesis', chapterNum: 6 }),
);
});

it('tapping scholar navigates to ScholarBio', () => {
const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
fireEvent.press(getByLabelText('Scholar: nickelsburg'));
expect(mockNavigate).toHaveBeenCalledWith('ScholarBio', {
scholarId: 'nickelsburg',
});
});

it('tapping debate chip navigates to DebateDetail', () => {
const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
fireEvent.press(
getByLabelText('Open debate did-jude-affirm-enoch-as-scripture'),
);
expect(mockNavigate).toHaveBeenCalledWith('DebateDetail', {
topicId: 'did-jude-affirm-enoch-as-scripture',
});
});

it('tapping difficult-passage chip navigates to DifficultPassageDetail', () => {
const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
fireEvent.press(getByLabelText('Open difficult jude-quotes-enoch'));
expect(mockNavigate).toHaveBeenCalledWith('DifficultPassageDetail', {
passageId: 'jude-quotes-enoch',
});
});

it('tapping journey chip navigates to JourneyDetail', () => {
const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
fireEvent.press(getByLabelText('Open journey canon-formation'));
expect(mockNavigate).toHaveBeenCalledWith('JourneyDetail', {
journeyId: 'canon-formation',
});
});

it('tapping further-reading with url calls Linking.openURL', () => {
const openUrlSpy = jest
.spyOn(Linking, 'openURL')
.mockResolvedValue(undefined);
const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
fireEvent.press(getByLabelText('Open Online Aramaic fragments archive'));
expect(openUrlSpy).toHaveBeenCalledWith('https://example.org/1enoch-aramaic');
openUrlSpy.mockRestore();
});
});

describe('free tier (premium gating)', () => {
it('renders only first paragraph of brief_summary', () => {
mockIsPremium = false;
const { getByText, queryByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
expect(
getByText(/1 Enoch is a composite work of five distinct books\./),
).toBeTruthy();
// Second paragraph is hidden
expect(
queryByText(/It is preserved complete only in Ethiopic Geʽez\./),
).toBeNull();
});

it('hides all gated sections (NT citations, scholars, debates, etc.)', () => {
mockIsPremium = false;
const { queryByText, queryByLabelText } = renderWithProviders(
<ExtraBiblicalDetailScreen />,
);
expect(queryByText('NEW TESTAMENT CITATIONS')).toBeNull();
expect(queryByText('SCHOLAR VOICES')).toBeNull();
expect(queryByText('RELATED DEBATES')).toBeNull();
expect(queryByText('FULL SUMMARY')).toBeNull();
expect(queryByLabelText('Open Jude 14-15')).toBeNull();
expect(queryByLabelText('Scholar: nickelsburg')).toBeNull();
});

it('shows unlock CTA and fires showUpgrade on tap', () => {
mockIsPremium = false;
const { getByLabelText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
expect(getByText(/Unlock the full entry/)).toBeTruthy();
fireEvent.press(getByLabelText('Unlock full entry'));
expect(mockShowUpgrade).toHaveBeenCalledWith(
'explore',
'Extra-Biblical Literature',
);
});
});

describe('loading + not-found states', () => {
it('shows loading indicator when loading=true', () => {
mockLoading = true;
mockEntry = null;
const { toJSON } = renderWithProviders(<ExtraBiblicalDetailScreen />);
expect(toJSON()).not.toBeNull();
});

it('shows "Entry not found" when entry=null after load', () => {
mockLoading = false;
mockEntry = null;
const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
expect(getByText(/Entry not found\./)).toBeTruthy();
});
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(app): ExtraBiblicalDetailScreen (#1548) by CraigBuckmaster · Pull Request #1597 · CraigBuckmaster/ScriptureDeepDive · GitHub
Skip to content
feat(app): ExtraBiblicalDetailScreen (#1548)#1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

CraigBuckmaster
merged 1 commit into

from

Apr 23, 2026
 Merged


feat(app): ExtraBiblicalDetailScreen (#1548)
#1597
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


312 changes: 312 additions & 0 deletions
app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,312 @@
/**
 * ExtraBiblicalDetailScreen.test.tsx — Detail view for one extrabiblical
 * entry (HWGTB-P2-03 / #1548).
 */

import React from 'react';
import { fireEvent } from '@testing-library/react-native';
import { Linking } from 'react-native';
import { renderWithProviders } from '../helpers/renderWithProviders';
import ExtraBiblicalDetailScreen from '@/screens/ExtraBiblicalDetailScreen';
import type { ExtrabiblicalEntry } from '@/types';

// ── Navigation mock ─────────────────────────────────────────────
const mockNavigate = jest.fn();
const mockGoBack = jest.fn();
jest.mock('@react-navigation/native', () => {
 const actual = jest.requireActual('@react-navigation/native');
 return {
 ...actual,
 useNavigation: () => ({
 navigate: mockNavigate,
 goBack: mockGoBack,
 push: jest.fn(),
 setOptions: jest.fn(),
 }),
 useRoute: () => ({ params: { id: '1_enoch' } }),
 useScrollToTop: jest.fn(),
 useFocusEffect: (cb: () => void) => cb(),
 };
});

jest.mock('lucide-react-native', () => ({
 ChevronLeft: () => null,
 ArrowLeft: () => null,
 Search: () => null,
 X: () => null,
}));

jest.mock('react-native-safe-area-context', () => ({
 SafeAreaView: ({ children }: any) => children,
 useSafeAreaInsets: () => ({ top: 44, bottom: 34, left: 0, right: 0 }),
}));

// ── Premium mock — mutable for per-test flip ─────────────────────
let mockIsPremium = true;
const mockShowUpgrade = jest.fn();
const mockDismissUpgrade = jest.fn();
let mockUpgradeRequest: { variant: string; featureName: string } | null = null;
jest.mock('@/hooks/usePremium', () => ({
 usePremium: () => ({
 isPremium: mockIsPremium,
 upgradeRequest: mockUpgradeRequest,
 showUpgrade: mockShowUpgrade,
 dismissUpgrade: mockDismissUpgrade,
 }),
}));

// ── Entry fixture ───────────────────────────────────────────────
const FIXTURE: ExtrabiblicalEntry = {
 id: '1_enoch',
 title: '1 Enoch (Ethiopic Enoch)',
 also_known_as: ['Book of Enoch', 'Ethiopic Enoch'],
 category: 'pseudepigrapha',
 estimated_date: '3rd c. BC – 1st c. AD',
 original_language: 'Aramaic / Hebrew, preserved in Ethiopic Geʽez',
 tradition_status: {
 protestant: 'not canonical',
 catholic: 'not canonical',
 eastern_orthodox: 'not canonical',
 ethiopian_tewahedo: 'canonical (81-book canon)',
 },
 brief_summary:
 '1 Enoch is a composite work of five distinct books.\n\nIt is preserved complete only in Ethiopic Geʽez.',
 full_summary: null,
 nt_citations: [
 { ref: 'Jude 14-15', cites: '1 Enoch 1:9', type: 'direct_quotation' },
 ],
 ot_allusions: [
 { ref: 'Genesis 6:1-4', connection: 'The Watchers expand Gen 6:1-4.' },
 ],
 scholar_voices: [
 {
 scholar_id: 'nickelsburg',
 position: "Hermeneia commentary on 1 Enoch.",
 },
 ],
 related_debate_ids: ['did-jude-affirm-enoch-as-scripture'],
 related_journey_ids: ['canon-formation'],
 related_difficult_passage_ids: ['jude-quotes-enoch'],
 tags: ['pseudepigrapha', 'hwgtb'],
 further_reading: [
 {
 title: '1 Enoch 1',
 author: 'Nickelsburg',
 note: 'Hermeneia (2001)',
 },
 {
 title: 'Online Aramaic fragments archive',
 url: 'https://example.org/1enoch-aramaic',
 },
 ],
};

let mockEntry: ExtrabiblicalEntry | null = FIXTURE;
let mockLoading = false;
jest.mock('@/hooks/useExtraBiblicalEntry', () => ({
 useExtraBiblicalEntry: () => ({ entry: mockEntry, loading: mockLoading }),
}));

beforeEach(() => {
 jest.clearAllMocks();
 mockIsPremium = true;
 mockUpgradeRequest = null;
 mockEntry = FIXTURE;
 mockLoading = false;
});

describe('ExtraBiblicalDetailScreen', () => {
 describe('render — premium tier', () => {
 it('renders hero title + aliases', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 // Title appears twice: screen header + hero card
 expect(getAllByText('1 Enoch (Ethiopic Enoch)').length).toBeGreaterThanOrEqual(1);
 expect(getByText(/Also known as:.*Book of Enoch.*Ethiopic Enoch/)).toBeTruthy();
 });

 it('renders tradition badges', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByLabelText(/^Protestant:/)).toBeTruthy();
 expect(getByLabelText(/^Ethiopian Tewahedo:/)).toBeTruthy();
 });

 it('renders full brief_summary (both paragraphs)', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(
 getByText(/1 Enoch is a composite work of five distinct books\./),
 ).toBeTruthy();
 expect(getByText(/It is preserved complete only in Ethiopic Geʽez\./)).toBeTruthy();
 });

 it('renders NT citations with ref + source + type', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Jude 14-15')).toBeTruthy();
 expect(getByText(/→ 1 Enoch 1:9/)).toBeTruthy();
 expect(getByText('Direct quotation')).toBeTruthy();
 });

 it('renders OT allusions', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Genesis 6:1-4')).toBeTruthy();
 expect(getByText(/The Watchers expand Gen 6:1-4/)).toBeTruthy();
 });

 it('renders scholar voices', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 // 'Nickelsburg' appears twice: scholar-voice name AND further-reading author
 expect(getAllByText('Nickelsburg').length).toBeGreaterThanOrEqual(1);
 expect(getByText(/Hermeneia commentary on 1 Enoch/)).toBeTruthy();
 });

 it('renders related-debate chip and section header', () => {
 const { getByLabelText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('RELATED DEBATES')).toBeTruthy();
 expect(
 getByLabelText('Open debate did-jude-affirm-enoch-as-scripture'),
 ).toBeTruthy();
 });

 it('renders related-difficult-passage and related-journey chips', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByLabelText('Open difficult jude-quotes-enoch')).toBeTruthy();
 expect(getByLabelText('Open journey canon-formation')).toBeTruthy();
 });

 it('renders further-reading items', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('1 Enoch 1')).toBeTruthy();
 expect(getAllByText('Nickelsburg').length).toBeGreaterThanOrEqual(1);
 expect(getByText('Online Aramaic fragments archive')).toBeTruthy();
 });

 it('renders "Coming soon" placeholder when full_summary is null', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Coming soon — expanded scholarly summary/)).toBeTruthy();
 });

 it('renders full_summary when it is present instead of placeholder', () => {
 mockEntry = { ...FIXTURE, full_summary: 'Expanded analysis goes here.' };
 const { getByText, queryByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Expanded analysis goes here.')).toBeTruthy();
 expect(queryByText(/Coming soon/)).toBeNull();
 });
 });

 describe('deep-link navigation — premium tier', () => {
 it('tapping NT citation navigates to Chapter with parsed book/chapter/verse', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Jude 14-15'));
 expect(mockNavigate).toHaveBeenCalledWith(
 'Chapter',
 expect.objectContaining({ bookId: 'jude', chapterNum: 1 }),
 );
 });

 it('tapping OT allusion navigates to Chapter with bookId', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Genesis 6:1-4'));
 expect(mockNavigate).toHaveBeenCalledWith(
 'Chapter',
 expect.objectContaining({ bookId: 'genesis', chapterNum: 6 }),
 );
 });

 it('tapping scholar navigates to ScholarBio', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Scholar: nickelsburg'));
 expect(mockNavigate).toHaveBeenCalledWith('ScholarBio', {
 scholarId: 'nickelsburg',
 });
 });

 it('tapping debate chip navigates to DebateDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(
 getByLabelText('Open debate did-jude-affirm-enoch-as-scripture'),
 );
 expect(mockNavigate).toHaveBeenCalledWith('DebateDetail', {
 topicId: 'did-jude-affirm-enoch-as-scripture',
 });
 });

 it('tapping difficult-passage chip navigates to DifficultPassageDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open difficult jude-quotes-enoch'));
 expect(mockNavigate).toHaveBeenCalledWith('DifficultPassageDetail', {
 passageId: 'jude-quotes-enoch',
 });
 });

 it('tapping journey chip navigates to JourneyDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open journey canon-formation'));
 expect(mockNavigate).toHaveBeenCalledWith('JourneyDetail', {
 journeyId: 'canon-formation',
 });
 });

 it('tapping further-reading with url calls Linking.openURL', () => {
 const openUrlSpy = jest
 .spyOn(Linking, 'openURL')
 .mockResolvedValue(undefined);
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Online Aramaic fragments archive'));
 expect(openUrlSpy).toHaveBeenCalledWith('https://example.org/1enoch-aramaic');
 openUrlSpy.mockRestore();
 });
 });

 describe('free tier (premium gating)', () => {
 it('renders only first paragraph of brief_summary', () => {
 mockIsPremium = false;
 const { getByText, queryByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(
 getByText(/1 Enoch is a composite work of five distinct books\./),
 ).toBeTruthy();
 // Second paragraph is hidden
 expect(
 queryByText(/It is preserved complete only in Ethiopic Geʽez\./),
 ).toBeNull();
 });

 it('hides all gated sections (NT citations, scholars, debates, etc.)', () => {
 mockIsPremium = false;
 const { queryByText, queryByLabelText } = renderWithProviders(
 <ExtraBiblicalDetailScreen />,
 );
 expect(queryByText('NEW TESTAMENT CITATIONS')).toBeNull();
 expect(queryByText('SCHOLAR VOICES')).toBeNull();
 expect(queryByText('RELATED DEBATES')).toBeNull();
 expect(queryByText('FULL SUMMARY')).toBeNull();
 expect(queryByLabelText('Open Jude 14-15')).toBeNull();
 expect(queryByLabelText('Scholar: nickelsburg')).toBeNull();
 });

 it('shows unlock CTA and fires showUpgrade on tap', () => {
 mockIsPremium = false;
 const { getByLabelText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Unlock the full entry/)).toBeTruthy();
 fireEvent.press(getByLabelText('Unlock full entry'));
 expect(mockShowUpgrade).toHaveBeenCalledWith(
 'explore',
 'Extra-Biblical Literature',
 );
 });
 });

 describe('loading + not-found states', () => {
 it('shows loading indicator when loading=true', () => {
 mockLoading = true;
 mockEntry = null;
 const { toJSON } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(toJSON()).not.toBeNull();
 });

 it('shows "Entry not found" when entry=null after load', () => {
 mockLoading = false;
 mockEntry = null;
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Entry not found\./)).toBeTruthy();
 });
 });
});
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(app): ExtraBiblicalDetailScreen (#1548) by CraigBuckmaster · Pull Request #1597 · CraigBuckmaster/ScriptureDeepDive · GitHub
Skip to content
feat(app): ExtraBiblicalDetailScreen (#1548)#1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

CraigBuckmaster
merged 1 commit into

from

Apr 23, 2026
 Merged


feat(app): ExtraBiblicalDetailScreen (#1548)
#1597
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


312 changes: 312 additions & 0 deletions
app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,312 @@
/**
 * ExtraBiblicalDetailScreen.test.tsx — Detail view for one extrabiblical
 * entry (HWGTB-P2-03 / #1548).
 */

import React from 'react';
import { fireEvent } from '@testing-library/react-native';
import { Linking } from 'react-native';
import { renderWithProviders } from '../helpers/renderWithProviders';
import ExtraBiblicalDetailScreen from '@/screens/ExtraBiblicalDetailScreen';
import type { ExtrabiblicalEntry } from '@/types';

// ── Navigation mock ─────────────────────────────────────────────
const mockNavigate = jest.fn();
const mockGoBack = jest.fn();
jest.mock('@react-navigation/native', () => {
 const actual = jest.requireActual('@react-navigation/native');
 return {
 ...actual,
 useNavigation: () => ({
 navigate: mockNavigate,
 goBack: mockGoBack,
 push: jest.fn(),
 setOptions: jest.fn(),
 }),
 useRoute: () => ({ params: { id: '1_enoch' } }),
 useScrollToTop: jest.fn(),
 useFocusEffect: (cb: () => void) => cb(),
 };
});

jest.mock('lucide-react-native', () => ({
 ChevronLeft: () => null,
 ArrowLeft: () => null,
 Search: () => null,
 X: () => null,
}));

jest.mock('react-native-safe-area-context', () => ({
 SafeAreaView: ({ children }: any) => children,
 useSafeAreaInsets: () => ({ top: 44, bottom: 34, left: 0, right: 0 }),
}));

// ── Premium mock — mutable for per-test flip ─────────────────────
let mockIsPremium = true;
const mockShowUpgrade = jest.fn();
const mockDismissUpgrade = jest.fn();
let mockUpgradeRequest: { variant: string; featureName: string } | null = null;
jest.mock('@/hooks/usePremium', () => ({
 usePremium: () => ({
 isPremium: mockIsPremium,
 upgradeRequest: mockUpgradeRequest,
 showUpgrade: mockShowUpgrade,
 dismissUpgrade: mockDismissUpgrade,
 }),
}));

// ── Entry fixture ───────────────────────────────────────────────
const FIXTURE: ExtrabiblicalEntry = {
 id: '1_enoch',
 title: '1 Enoch (Ethiopic Enoch)',
 also_known_as: ['Book of Enoch', 'Ethiopic Enoch'],
 category: 'pseudepigrapha',
 estimated_date: '3rd c. BC – 1st c. AD',
 original_language: 'Aramaic / Hebrew, preserved in Ethiopic Geʽez',
 tradition_status: {
 protestant: 'not canonical',
 catholic: 'not canonical',
 eastern_orthodox: 'not canonical',
 ethiopian_tewahedo: 'canonical (81-book canon)',
 },
 brief_summary:
 '1 Enoch is a composite work of five distinct books.\n\nIt is preserved complete only in Ethiopic Geʽez.',
 full_summary: null,
 nt_citations: [
 { ref: 'Jude 14-15', cites: '1 Enoch 1:9', type: 'direct_quotation' },
 ],
 ot_allusions: [
 { ref: 'Genesis 6:1-4', connection: 'The Watchers expand Gen 6:1-4.' },
 ],
 scholar_voices: [
 {
 scholar_id: 'nickelsburg',
 position: "Hermeneia commentary on 1 Enoch.",
 },
 ],
 related_debate_ids: ['did-jude-affirm-enoch-as-scripture'],
 related_journey_ids: ['canon-formation'],
 related_difficult_passage_ids: ['jude-quotes-enoch'],
 tags: ['pseudepigrapha', 'hwgtb'],
 further_reading: [
 {
 title: '1 Enoch 1',
 author: 'Nickelsburg',
 note: 'Hermeneia (2001)',
 },
 {
 title: 'Online Aramaic fragments archive',
 url: 'https://example.org/1enoch-aramaic',
 },
 ],
};

let mockEntry: ExtrabiblicalEntry | null = FIXTURE;
let mockLoading = false;
jest.mock('@/hooks/useExtraBiblicalEntry', () => ({
 useExtraBiblicalEntry: () => ({ entry: mockEntry, loading: mockLoading }),
}));

beforeEach(() => {
 jest.clearAllMocks();
 mockIsPremium = true;
 mockUpgradeRequest = null;
 mockEntry = FIXTURE;
 mockLoading = false;
});

describe('ExtraBiblicalDetailScreen', () => {
 describe('render — premium tier', () => {
 it('renders hero title + aliases', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 // Title appears twice: screen header + hero card
 expect(getAllByText('1 Enoch (Ethiopic Enoch)').length).toBeGreaterThanOrEqual(1);
 expect(getByText(/Also known as:.*Book of Enoch.*Ethiopic Enoch/)).toBeTruthy();
 });

 it('renders tradition badges', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByLabelText(/^Protestant:/)).toBeTruthy();
 expect(getByLabelText(/^Ethiopian Tewahedo:/)).toBeTruthy();
 });

 it('renders full brief_summary (both paragraphs)', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(
 getByText(/1 Enoch is a composite work of five distinct books\./),
 ).toBeTruthy();
 expect(getByText(/It is preserved complete only in Ethiopic Geʽez\./)).toBeTruthy();
 });

 it('renders NT citations with ref + source + type', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Jude 14-15')).toBeTruthy();
 expect(getByText(/→ 1 Enoch 1:9/)).toBeTruthy();
 expect(getByText('Direct quotation')).toBeTruthy();
 });

 it('renders OT allusions', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Genesis 6:1-4')).toBeTruthy();
 expect(getByText(/The Watchers expand Gen 6:1-4/)).toBeTruthy();
 });

 it('renders scholar voices', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 // 'Nickelsburg' appears twice: scholar-voice name AND further-reading author
 expect(getAllByText('Nickelsburg').length).toBeGreaterThanOrEqual(1);
 expect(getByText(/Hermeneia commentary on 1 Enoch/)).toBeTruthy();
 });

 it('renders related-debate chip and section header', () => {
 const { getByLabelText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('RELATED DEBATES')).toBeTruthy();
 expect(
 getByLabelText('Open debate did-jude-affirm-enoch-as-scripture'),
 ).toBeTruthy();
 });

 it('renders related-difficult-passage and related-journey chips', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByLabelText('Open difficult jude-quotes-enoch')).toBeTruthy();
 expect(getByLabelText('Open journey canon-formation')).toBeTruthy();
 });

 it('renders further-reading items', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('1 Enoch 1')).toBeTruthy();
 expect(getAllByText('Nickelsburg').length).toBeGreaterThanOrEqual(1);
 expect(getByText('Online Aramaic fragments archive')).toBeTruthy();
 });

 it('renders "Coming soon" placeholder when full_summary is null', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Coming soon — expanded scholarly summary/)).toBeTruthy();
 });

 it('renders full_summary when it is present instead of placeholder', () => {
 mockEntry = { ...FIXTURE, full_summary: 'Expanded analysis goes here.' };
 const { getByText, queryByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Expanded analysis goes here.')).toBeTruthy();
 expect(queryByText(/Coming soon/)).toBeNull();
 });
 });

 describe('deep-link navigation — premium tier', () => {
 it('tapping NT citation navigates to Chapter with parsed book/chapter/verse', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Jude 14-15'));
 expect(mockNavigate).toHaveBeenCalledWith(
 'Chapter',
 expect.objectContaining({ bookId: 'jude', chapterNum: 1 }),
 );
 });

 it('tapping OT allusion navigates to Chapter with bookId', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Genesis 6:1-4'));
 expect(mockNavigate).toHaveBeenCalledWith(
 'Chapter',
 expect.objectContaining({ bookId: 'genesis', chapterNum: 6 }),
 );
 });

 it('tapping scholar navigates to ScholarBio', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Scholar: nickelsburg'));
 expect(mockNavigate).toHaveBeenCalledWith('ScholarBio', {
 scholarId: 'nickelsburg',
 });
 });

 it('tapping debate chip navigates to DebateDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(
 getByLabelText('Open debate did-jude-affirm-enoch-as-scripture'),
 );
 expect(mockNavigate).toHaveBeenCalledWith('DebateDetail', {
 topicId: 'did-jude-affirm-enoch-as-scripture',
 });
 });

 it('tapping difficult-passage chip navigates to DifficultPassageDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open difficult jude-quotes-enoch'));
 expect(mockNavigate).toHaveBeenCalledWith('DifficultPassageDetail', {
 passageId: 'jude-quotes-enoch',
 });
 });

 it('tapping journey chip navigates to JourneyDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open journey canon-formation'));
 expect(mockNavigate).toHaveBeenCalledWith('JourneyDetail', {
 journeyId: 'canon-formation',
 });
 });

 it('tapping further-reading with url calls Linking.openURL', () => {
 const openUrlSpy = jest
 .spyOn(Linking, 'openURL')
 .mockResolvedValue(undefined);
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Online Aramaic fragments archive'));
 expect(openUrlSpy).toHaveBeenCalledWith('https://example.org/1enoch-aramaic');
 openUrlSpy.mockRestore();
 });
 });

 describe('free tier (premium gating)', () => {
 it('renders only first paragraph of brief_summary', () => {
 mockIsPremium = false;
 const { getByText, queryByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(
 getByText(/1 Enoch is a composite work of five distinct books\./),
 ).toBeTruthy();
 // Second paragraph is hidden
 expect(
 queryByText(/It is preserved complete only in Ethiopic Geʽez\./),
 ).toBeNull();
 });

 it('hides all gated sections (NT citations, scholars, debates, etc.)', () => {
 mockIsPremium = false;
 const { queryByText, queryByLabelText } = renderWithProviders(
 <ExtraBiblicalDetailScreen />,
 );
 expect(queryByText('NEW TESTAMENT CITATIONS')).toBeNull();
 expect(queryByText('SCHOLAR VOICES')).toBeNull();
 expect(queryByText('RELATED DEBATES')).toBeNull();
 expect(queryByText('FULL SUMMARY')).toBeNull();
 expect(queryByLabelText('Open Jude 14-15')).toBeNull();
 expect(queryByLabelText('Scholar: nickelsburg')).toBeNull();
 });

 it('shows unlock CTA and fires showUpgrade on tap', () => {
 mockIsPremium = false;
 const { getByLabelText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Unlock the full entry/)).toBeTruthy();
 fireEvent.press(getByLabelText('Unlock full entry'));
 expect(mockShowUpgrade).toHaveBeenCalledWith(
 'explore',
 'Extra-Biblical Literature',
 );
 });
 });

 describe('loading + not-found states', () => {
 it('shows loading indicator when loading=true', () => {
 mockLoading = true;
 mockEntry = null;
 const { toJSON } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(toJSON()).not.toBeNull();
 });

 it('shows "Entry not found" when entry=null after load', () => {
 mockLoading = false;
 mockEntry = null;
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Entry not found\./)).toBeTruthy();
 });
 });
});
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(app): ExtraBiblicalDetailScreen (#1548) by CraigBuckmaster · Pull Request #1597 · CraigBuckmaster/ScriptureDeepDive · GitHub
Skip to content
feat(app): ExtraBiblicalDetailScreen (#1548)#1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

CraigBuckmaster
merged 1 commit into

from

Apr 23, 2026
 Merged


feat(app): ExtraBiblicalDetailScreen (#1548)
#1597
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


312 changes: 312 additions & 0 deletions
app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,312 @@
/**
 * ExtraBiblicalDetailScreen.test.tsx — Detail view for one extrabiblical
 * entry (HWGTB-P2-03 / #1548).
 */

import React from 'react';
import { fireEvent } from '@testing-library/react-native';
import { Linking } from 'react-native';
import { renderWithProviders } from '../helpers/renderWithProviders';
import ExtraBiblicalDetailScreen from '@/screens/ExtraBiblicalDetailScreen';
import type { ExtrabiblicalEntry } from '@/types';

// ── Navigation mock ─────────────────────────────────────────────
const mockNavigate = jest.fn();
const mockGoBack = jest.fn();
jest.mock('@react-navigation/native', () => {
 const actual = jest.requireActual('@react-navigation/native');
 return {
 ...actual,
 useNavigation: () => ({
 navigate: mockNavigate,
 goBack: mockGoBack,
 push: jest.fn(),
 setOptions: jest.fn(),
 }),
 useRoute: () => ({ params: { id: '1_enoch' } }),
 useScrollToTop: jest.fn(),
 useFocusEffect: (cb: () => void) => cb(),
 };
});

jest.mock('lucide-react-native', () => ({
 ChevronLeft: () => null,
 ArrowLeft: () => null,
 Search: () => null,
 X: () => null,
}));

jest.mock('react-native-safe-area-context', () => ({
 SafeAreaView: ({ children }: any) => children,
 useSafeAreaInsets: () => ({ top: 44, bottom: 34, left: 0, right: 0 }),
}));

// ── Premium mock — mutable for per-test flip ─────────────────────
let mockIsPremium = true;
const mockShowUpgrade = jest.fn();
const mockDismissUpgrade = jest.fn();
let mockUpgradeRequest: { variant: string; featureName: string } | null = null;
jest.mock('@/hooks/usePremium', () => ({
 usePremium: () => ({
 isPremium: mockIsPremium,
 upgradeRequest: mockUpgradeRequest,
 showUpgrade: mockShowUpgrade,
 dismissUpgrade: mockDismissUpgrade,
 }),
}));

// ── Entry fixture ───────────────────────────────────────────────
const FIXTURE: ExtrabiblicalEntry = {
 id: '1_enoch',
 title: '1 Enoch (Ethiopic Enoch)',
 also_known_as: ['Book of Enoch', 'Ethiopic Enoch'],
 category: 'pseudepigrapha',
 estimated_date: '3rd c. BC – 1st c. AD',
 original_language: 'Aramaic / Hebrew, preserved in Ethiopic Geʽez',
 tradition_status: {
 protestant: 'not canonical',
 catholic: 'not canonical',
 eastern_orthodox: 'not canonical',
 ethiopian_tewahedo: 'canonical (81-book canon)',
 },
 brief_summary:
 '1 Enoch is a composite work of five distinct books.\n\nIt is preserved complete only in Ethiopic Geʽez.',
 full_summary: null,
 nt_citations: [
 { ref: 'Jude 14-15', cites: '1 Enoch 1:9', type: 'direct_quotation' },
 ],
 ot_allusions: [
 { ref: 'Genesis 6:1-4', connection: 'The Watchers expand Gen 6:1-4.' },
 ],
 scholar_voices: [
 {
 scholar_id: 'nickelsburg',
 position: "Hermeneia commentary on 1 Enoch.",
 },
 ],
 related_debate_ids: ['did-jude-affirm-enoch-as-scripture'],
 related_journey_ids: ['canon-formation'],
 related_difficult_passage_ids: ['jude-quotes-enoch'],
 tags: ['pseudepigrapha', 'hwgtb'],
 further_reading: [
 {
 title: '1 Enoch 1',
 author: 'Nickelsburg',
 note: 'Hermeneia (2001)',
 },
 {
 title: 'Online Aramaic fragments archive',
 url: 'https://example.org/1enoch-aramaic',
 },
 ],
};

let mockEntry: ExtrabiblicalEntry | null = FIXTURE;
let mockLoading = false;
jest.mock('@/hooks/useExtraBiblicalEntry', () => ({
 useExtraBiblicalEntry: () => ({ entry: mockEntry, loading: mockLoading }),
}));

beforeEach(() => {
 jest.clearAllMocks();
 mockIsPremium = true;
 mockUpgradeRequest = null;
 mockEntry = FIXTURE;
 mockLoading = false;
});

describe('ExtraBiblicalDetailScreen', () => {
 describe('render — premium tier', () => {
 it('renders hero title + aliases', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 // Title appears twice: screen header + hero card
 expect(getAllByText('1 Enoch (Ethiopic Enoch)').length).toBeGreaterThanOrEqual(1);
 expect(getByText(/Also known as:.*Book of Enoch.*Ethiopic Enoch/)).toBeTruthy();
 });

 it('renders tradition badges', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByLabelText(/^Protestant:/)).toBeTruthy();
 expect(getByLabelText(/^Ethiopian Tewahedo:/)).toBeTruthy();
 });

 it('renders full brief_summary (both paragraphs)', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(
 getByText(/1 Enoch is a composite work of five distinct books\./),
 ).toBeTruthy();
 expect(getByText(/It is preserved complete only in Ethiopic Geʽez\./)).toBeTruthy();
 });

 it('renders NT citations with ref + source + type', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Jude 14-15')).toBeTruthy();
 expect(getByText(/→ 1 Enoch 1:9/)).toBeTruthy();
 expect(getByText('Direct quotation')).toBeTruthy();
 });

 it('renders OT allusions', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Genesis 6:1-4')).toBeTruthy();
 expect(getByText(/The Watchers expand Gen 6:1-4/)).toBeTruthy();
 });

 it('renders scholar voices', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 // 'Nickelsburg' appears twice: scholar-voice name AND further-reading author
 expect(getAllByText('Nickelsburg').length).toBeGreaterThanOrEqual(1);
 expect(getByText(/Hermeneia commentary on 1 Enoch/)).toBeTruthy();
 });

 it('renders related-debate chip and section header', () => {
 const { getByLabelText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('RELATED DEBATES')).toBeTruthy();
 expect(
 getByLabelText('Open debate did-jude-affirm-enoch-as-scripture'),
 ).toBeTruthy();
 });

 it('renders related-difficult-passage and related-journey chips', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByLabelText('Open difficult jude-quotes-enoch')).toBeTruthy();
 expect(getByLabelText('Open journey canon-formation')).toBeTruthy();
 });

 it('renders further-reading items', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('1 Enoch 1')).toBeTruthy();
 expect(getAllByText('Nickelsburg').length).toBeGreaterThanOrEqual(1);
 expect(getByText('Online Aramaic fragments archive')).toBeTruthy();
 });

 it('renders "Coming soon" placeholder when full_summary is null', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Coming soon — expanded scholarly summary/)).toBeTruthy();
 });

 it('renders full_summary when it is present instead of placeholder', () => {
 mockEntry = { ...FIXTURE, full_summary: 'Expanded analysis goes here.' };
 const { getByText, queryByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Expanded analysis goes here.')).toBeTruthy();
 expect(queryByText(/Coming soon/)).toBeNull();
 });
 });

 describe('deep-link navigation — premium tier', () => {
 it('tapping NT citation navigates to Chapter with parsed book/chapter/verse', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Jude 14-15'));
 expect(mockNavigate).toHaveBeenCalledWith(
 'Chapter',
 expect.objectContaining({ bookId: 'jude', chapterNum: 1 }),
 );
 });

 it('tapping OT allusion navigates to Chapter with bookId', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Genesis 6:1-4'));
 expect(mockNavigate).toHaveBeenCalledWith(
 'Chapter',
 expect.objectContaining({ bookId: 'genesis', chapterNum: 6 }),
 );
 });

 it('tapping scholar navigates to ScholarBio', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Scholar: nickelsburg'));
 expect(mockNavigate).toHaveBeenCalledWith('ScholarBio', {
 scholarId: 'nickelsburg',
 });
 });

 it('tapping debate chip navigates to DebateDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(
 getByLabelText('Open debate did-jude-affirm-enoch-as-scripture'),
 );
 expect(mockNavigate).toHaveBeenCalledWith('DebateDetail', {
 topicId: 'did-jude-affirm-enoch-as-scripture',
 });
 });

 it('tapping difficult-passage chip navigates to DifficultPassageDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open difficult jude-quotes-enoch'));
 expect(mockNavigate).toHaveBeenCalledWith('DifficultPassageDetail', {
 passageId: 'jude-quotes-enoch',
 });
 });

 it('tapping journey chip navigates to JourneyDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open journey canon-formation'));
 expect(mockNavigate).toHaveBeenCalledWith('JourneyDetail', {
 journeyId: 'canon-formation',
 });
 });

 it('tapping further-reading with url calls Linking.openURL', () => {
 const openUrlSpy = jest
 .spyOn(Linking, 'openURL')
 .mockResolvedValue(undefined);
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Online Aramaic fragments archive'));
 expect(openUrlSpy).toHaveBeenCalledWith('https://example.org/1enoch-aramaic');
 openUrlSpy.mockRestore();
 });
 });

 describe('free tier (premium gating)', () => {
 it('renders only first paragraph of brief_summary', () => {
 mockIsPremium = false;
 const { getByText, queryByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(
 getByText(/1 Enoch is a composite work of five distinct books\./),
 ).toBeTruthy();
 // Second paragraph is hidden
 expect(
 queryByText(/It is preserved complete only in Ethiopic Geʽez\./),
 ).toBeNull();
 });

 it('hides all gated sections (NT citations, scholars, debates, etc.)', () => {
 mockIsPremium = false;
 const { queryByText, queryByLabelText } = renderWithProviders(
 <ExtraBiblicalDetailScreen />,
 );
 expect(queryByText('NEW TESTAMENT CITATIONS')).toBeNull();
 expect(queryByText('SCHOLAR VOICES')).toBeNull();
 expect(queryByText('RELATED DEBATES')).toBeNull();
 expect(queryByText('FULL SUMMARY')).toBeNull();
 expect(queryByLabelText('Open Jude 14-15')).toBeNull();
 expect(queryByLabelText('Scholar: nickelsburg')).toBeNull();
 });

 it('shows unlock CTA and fires showUpgrade on tap', () => {
 mockIsPremium = false;
 const { getByLabelText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Unlock the full entry/)).toBeTruthy();
 fireEvent.press(getByLabelText('Unlock full entry'));
 expect(mockShowUpgrade).toHaveBeenCalledWith(
 'explore',
 'Extra-Biblical Literature',
 );
 });
 });

 describe('loading + not-found states', () => {
 it('shows loading indicator when loading=true', () => {
 mockLoading = true;
 mockEntry = null;
 const { toJSON } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(toJSON()).not.toBeNull();
 });

 it('shows "Entry not found" when entry=null after load', () => {
 mockLoading = false;
 mockEntry = null;
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Entry not found\./)).toBeTruthy();
 });
 });
});
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
feat(app): ExtraBiblicalDetailScreen (#1548) by CraigBuckmaster · Pull Request #1597 · CraigBuckmaster/ScriptureDeepDive · GitHub
Skip to content
feat(app): ExtraBiblicalDetailScreen (#1548)#1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

CraigBuckmaster
merged 1 commit into

from

Apr 23, 2026
 Merged


feat(app): ExtraBiblicalDetailScreen (#1548)
#1597
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


312 changes: 312 additions & 0 deletions
app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,312 @@
/**
 * ExtraBiblicalDetailScreen.test.tsx — Detail view for one extrabiblical
 * entry (HWGTB-P2-03 / #1548).
 */

import React from 'react';
import { fireEvent } from '@testing-library/react-native';
import { Linking } from 'react-native';
import { renderWithProviders } from '../helpers/renderWithProviders';
import ExtraBiblicalDetailScreen from '@/screens/ExtraBiblicalDetailScreen';
import type { ExtrabiblicalEntry } from '@/types';

// ── Navigation mock ─────────────────────────────────────────────
const mockNavigate = jest.fn();
const mockGoBack = jest.fn();
jest.mock('@react-navigation/native', () => {
 const actual = jest.requireActual('@react-navigation/native');
 return {
 ...actual,
 useNavigation: () => ({
 navigate: mockNavigate,
 goBack: mockGoBack,
 push: jest.fn(),
 setOptions: jest.fn(),
 }),
 useRoute: () => ({ params: { id: '1_enoch' } }),
 useScrollToTop: jest.fn(),
 useFocusEffect: (cb: () => void) => cb(),
 };
});

jest.mock('lucide-react-native', () => ({
 ChevronLeft: () => null,
 ArrowLeft: () => null,
 Search: () => null,
 X: () => null,
}));

jest.mock('react-native-safe-area-context', () => ({
 SafeAreaView: ({ children }: any) => children,
 useSafeAreaInsets: () => ({ top: 44, bottom: 34, left: 0, right: 0 }),
}));

// ── Premium mock — mutable for per-test flip ─────────────────────
let mockIsPremium = true;
const mockShowUpgrade = jest.fn();
const mockDismissUpgrade = jest.fn();
let mockUpgradeRequest: { variant: string; featureName: string } | null = null;
jest.mock('@/hooks/usePremium', () => ({
 usePremium: () => ({
 isPremium: mockIsPremium,
 upgradeRequest: mockUpgradeRequest,
 showUpgrade: mockShowUpgrade,
 dismissUpgrade: mockDismissUpgrade,
 }),
}));

// ── Entry fixture ───────────────────────────────────────────────
const FIXTURE: ExtrabiblicalEntry = {
 id: '1_enoch',
 title: '1 Enoch (Ethiopic Enoch)',
 also_known_as: ['Book of Enoch', 'Ethiopic Enoch'],
 category: 'pseudepigrapha',
 estimated_date: '3rd c. BC – 1st c. AD',
 original_language: 'Aramaic / Hebrew, preserved in Ethiopic Geʽez',
 tradition_status: {
 protestant: 'not canonical',
 catholic: 'not canonical',
 eastern_orthodox: 'not canonical',
 ethiopian_tewahedo: 'canonical (81-book canon)',
 },
 brief_summary:
 '1 Enoch is a composite work of five distinct books.\n\nIt is preserved complete only in Ethiopic Geʽez.',
 full_summary: null,
 nt_citations: [
 { ref: 'Jude 14-15', cites: '1 Enoch 1:9', type: 'direct_quotation' },
 ],
 ot_allusions: [
 { ref: 'Genesis 6:1-4', connection: 'The Watchers expand Gen 6:1-4.' },
 ],
 scholar_voices: [
 {
 scholar_id: 'nickelsburg',
 position: "Hermeneia commentary on 1 Enoch.",
 },
 ],
 related_debate_ids: ['did-jude-affirm-enoch-as-scripture'],
 related_journey_ids: ['canon-formation'],
 related_difficult_passage_ids: ['jude-quotes-enoch'],
 tags: ['pseudepigrapha', 'hwgtb'],
 further_reading: [
 {
 title: '1 Enoch 1',
 author: 'Nickelsburg',
 note: 'Hermeneia (2001)',
 },
 {
 title: 'Online Aramaic fragments archive',
 url: 'https://example.org/1enoch-aramaic',
 },
 ],
};

let mockEntry: ExtrabiblicalEntry | null = FIXTURE;
let mockLoading = false;
jest.mock('@/hooks/useExtraBiblicalEntry', () => ({
 useExtraBiblicalEntry: () => ({ entry: mockEntry, loading: mockLoading }),
}));

beforeEach(() => {
 jest.clearAllMocks();
 mockIsPremium = true;
 mockUpgradeRequest = null;
 mockEntry = FIXTURE;
 mockLoading = false;
});

describe('ExtraBiblicalDetailScreen', () => {
 describe('render — premium tier', () => {
 it('renders hero title + aliases', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 // Title appears twice: screen header + hero card
 expect(getAllByText('1 Enoch (Ethiopic Enoch)').length).toBeGreaterThanOrEqual(1);
 expect(getByText(/Also known as:.*Book of Enoch.*Ethiopic Enoch/)).toBeTruthy();
 });

 it('renders tradition badges', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByLabelText(/^Protestant:/)).toBeTruthy();
 expect(getByLabelText(/^Ethiopian Tewahedo:/)).toBeTruthy();
 });

 it('renders full brief_summary (both paragraphs)', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(
 getByText(/1 Enoch is a composite work of five distinct books\./),
 ).toBeTruthy();
 expect(getByText(/It is preserved complete only in Ethiopic Geʽez\./)).toBeTruthy();
 });

 it('renders NT citations with ref + source + type', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Jude 14-15')).toBeTruthy();
 expect(getByText(/→ 1 Enoch 1:9/)).toBeTruthy();
 expect(getByText('Direct quotation')).toBeTruthy();
 });

 it('renders OT allusions', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Genesis 6:1-4')).toBeTruthy();
 expect(getByText(/The Watchers expand Gen 6:1-4/)).toBeTruthy();
 });

 it('renders scholar voices', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 // 'Nickelsburg' appears twice: scholar-voice name AND further-reading author
 expect(getAllByText('Nickelsburg').length).toBeGreaterThanOrEqual(1);
 expect(getByText(/Hermeneia commentary on 1 Enoch/)).toBeTruthy();
 });

 it('renders related-debate chip and section header', () => {
 const { getByLabelText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('RELATED DEBATES')).toBeTruthy();
 expect(
 getByLabelText('Open debate did-jude-affirm-enoch-as-scripture'),
 ).toBeTruthy();
 });

 it('renders related-difficult-passage and related-journey chips', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByLabelText('Open difficult jude-quotes-enoch')).toBeTruthy();
 expect(getByLabelText('Open journey canon-formation')).toBeTruthy();
 });

 it('renders further-reading items', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('1 Enoch 1')).toBeTruthy();
 expect(getAllByText('Nickelsburg').length).toBeGreaterThanOrEqual(1);
 expect(getByText('Online Aramaic fragments archive')).toBeTruthy();
 });

 it('renders "Coming soon" placeholder when full_summary is null', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Coming soon — expanded scholarly summary/)).toBeTruthy();
 });

 it('renders full_summary when it is present instead of placeholder', () => {
 mockEntry = { ...FIXTURE, full_summary: 'Expanded analysis goes here.' };
 const { getByText, queryByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Expanded analysis goes here.')).toBeTruthy();
 expect(queryByText(/Coming soon/)).toBeNull();
 });
 });

 describe('deep-link navigation — premium tier', () => {
 it('tapping NT citation navigates to Chapter with parsed book/chapter/verse', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Jude 14-15'));
 expect(mockNavigate).toHaveBeenCalledWith(
 'Chapter',
 expect.objectContaining({ bookId: 'jude', chapterNum: 1 }),
 );
 });

 it('tapping OT allusion navigates to Chapter with bookId', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Genesis 6:1-4'));
 expect(mockNavigate).toHaveBeenCalledWith(
 'Chapter',
 expect.objectContaining({ bookId: 'genesis', chapterNum: 6 }),
 );
 });

 it('tapping scholar navigates to ScholarBio', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Scholar: nickelsburg'));
 expect(mockNavigate).toHaveBeenCalledWith('ScholarBio', {
 scholarId: 'nickelsburg',
 });
 });

 it('tapping debate chip navigates to DebateDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(
 getByLabelText('Open debate did-jude-affirm-enoch-as-scripture'),
 );
 expect(mockNavigate).toHaveBeenCalledWith('DebateDetail', {
 topicId: 'did-jude-affirm-enoch-as-scripture',
 });
 });

 it('tapping difficult-passage chip navigates to DifficultPassageDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open difficult jude-quotes-enoch'));
 expect(mockNavigate).toHaveBeenCalledWith('DifficultPassageDetail', {
 passageId: 'jude-quotes-enoch',
 });
 });

 it('tapping journey chip navigates to JourneyDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open journey canon-formation'));
 expect(mockNavigate).toHaveBeenCalledWith('JourneyDetail', {
 journeyId: 'canon-formation',
 });
 });

 it('tapping further-reading with url calls Linking.openURL', () => {
 const openUrlSpy = jest
 .spyOn(Linking, 'openURL')
 .mockResolvedValue(undefined);
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Online Aramaic fragments archive'));
 expect(openUrlSpy).toHaveBeenCalledWith('https://example.org/1enoch-aramaic');
 openUrlSpy.mockRestore();
 });
 });

 describe('free tier (premium gating)', () => {
 it('renders only first paragraph of brief_summary', () => {
 mockIsPremium = false;
 const { getByText, queryByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(
 getByText(/1 Enoch is a composite work of five distinct books\./),
 ).toBeTruthy();
 // Second paragraph is hidden
 expect(
 queryByText(/It is preserved complete only in Ethiopic Geʽez\./),
 ).toBeNull();
 });

 it('hides all gated sections (NT citations, scholars, debates, etc.)', () => {
 mockIsPremium = false;
 const { queryByText, queryByLabelText } = renderWithProviders(
 <ExtraBiblicalDetailScreen />,
 );
 expect(queryByText('NEW TESTAMENT CITATIONS')).toBeNull();
 expect(queryByText('SCHOLAR VOICES')).toBeNull();
 expect(queryByText('RELATED DEBATES')).toBeNull();
 expect(queryByText('FULL SUMMARY')).toBeNull();
 expect(queryByLabelText('Open Jude 14-15')).toBeNull();
 expect(queryByLabelText('Scholar: nickelsburg')).toBeNull();
 });

 it('shows unlock CTA and fires showUpgrade on tap', () => {
 mockIsPremium = false;
 const { getByLabelText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Unlock the full entry/)).toBeTruthy();
 fireEvent.press(getByLabelText('Unlock full entry'));
 expect(mockShowUpgrade).toHaveBeenCalledWith(
 'explore',
 'Extra-Biblical Literature',
 );
 });
 });

 describe('loading + not-found states', () => {
 it('shows loading indicator when loading=true', () => {
 mockLoading = true;
 mockEntry = null;
 const { toJSON } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(toJSON()).not.toBeNull();
 });

 it('shows "Entry not found" when entry=null after load', () => {
 mockLoading = false;
 mockEntry = null;
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Entry not found\./)).toBeTruthy();
 });
 });
});
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(app): ExtraBiblicalDetailScreen (#1548) by CraigBuckmaster · Pull Request #1597 · CraigBuckmaster/ScriptureDeepDive · GitHub
Skip to content
feat(app): ExtraBiblicalDetailScreen (#1548)#1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

CraigBuckmaster
merged 1 commit into

from

Apr 23, 2026
 Merged


feat(app): ExtraBiblicalDetailScreen (#1548)
#1597
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


312 changes: 312 additions & 0 deletions
app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,312 @@
/**
 * ExtraBiblicalDetailScreen.test.tsx — Detail view for one extrabiblical
 * entry (HWGTB-P2-03 / #1548).
 */

import React from 'react';
import { fireEvent } from '@testing-library/react-native';
import { Linking } from 'react-native';
import { renderWithProviders } from '../helpers/renderWithProviders';
import ExtraBiblicalDetailScreen from '@/screens/ExtraBiblicalDetailScreen';
import type { ExtrabiblicalEntry } from '@/types';

// ── Navigation mock ─────────────────────────────────────────────
const mockNavigate = jest.fn();
const mockGoBack = jest.fn();
jest.mock('@react-navigation/native', () => {
 const actual = jest.requireActual('@react-navigation/native');
 return {
 ...actual,
 useNavigation: () => ({
 navigate: mockNavigate,
 goBack: mockGoBack,
 push: jest.fn(),
 setOptions: jest.fn(),
 }),
 useRoute: () => ({ params: { id: '1_enoch' } }),
 useScrollToTop: jest.fn(),
 useFocusEffect: (cb: () => void) => cb(),
 };
});

jest.mock('lucide-react-native', () => ({
 ChevronLeft: () => null,
 ArrowLeft: () => null,
 Search: () => null,
 X: () => null,
}));

jest.mock('react-native-safe-area-context', () => ({
 SafeAreaView: ({ children }: any) => children,
 useSafeAreaInsets: () => ({ top: 44, bottom: 34, left: 0, right: 0 }),
}));

// ── Premium mock — mutable for per-test flip ─────────────────────
let mockIsPremium = true;
const mockShowUpgrade = jest.fn();
const mockDismissUpgrade = jest.fn();
let mockUpgradeRequest: { variant: string; featureName: string } | null = null;
jest.mock('@/hooks/usePremium', () => ({
 usePremium: () => ({
 isPremium: mockIsPremium,
 upgradeRequest: mockUpgradeRequest,
 showUpgrade: mockShowUpgrade,
 dismissUpgrade: mockDismissUpgrade,
 }),
}));

// ── Entry fixture ───────────────────────────────────────────────
const FIXTURE: ExtrabiblicalEntry = {
 id: '1_enoch',
 title: '1 Enoch (Ethiopic Enoch)',
 also_known_as: ['Book of Enoch', 'Ethiopic Enoch'],
 category: 'pseudepigrapha',
 estimated_date: '3rd c. BC – 1st c. AD',
 original_language: 'Aramaic / Hebrew, preserved in Ethiopic Geʽez',
 tradition_status: {
 protestant: 'not canonical',
 catholic: 'not canonical',
 eastern_orthodox: 'not canonical',
 ethiopian_tewahedo: 'canonical (81-book canon)',
 },
 brief_summary:
 '1 Enoch is a composite work of five distinct books.\n\nIt is preserved complete only in Ethiopic Geʽez.',
 full_summary: null,
 nt_citations: [
 { ref: 'Jude 14-15', cites: '1 Enoch 1:9', type: 'direct_quotation' },
 ],
 ot_allusions: [
 { ref: 'Genesis 6:1-4', connection: 'The Watchers expand Gen 6:1-4.' },
 ],
 scholar_voices: [
 {
 scholar_id: 'nickelsburg',
 position: "Hermeneia commentary on 1 Enoch.",
 },
 ],
 related_debate_ids: ['did-jude-affirm-enoch-as-scripture'],
 related_journey_ids: ['canon-formation'],
 related_difficult_passage_ids: ['jude-quotes-enoch'],
 tags: ['pseudepigrapha', 'hwgtb'],
 further_reading: [
 {
 title: '1 Enoch 1',
 author: 'Nickelsburg',
 note: 'Hermeneia (2001)',
 },
 {
 title: 'Online Aramaic fragments archive',
 url: 'https://example.org/1enoch-aramaic',
 },
 ],
};

let mockEntry: ExtrabiblicalEntry | null = FIXTURE;
let mockLoading = false;
jest.mock('@/hooks/useExtraBiblicalEntry', () => ({
 useExtraBiblicalEntry: () => ({ entry: mockEntry, loading: mockLoading }),
}));

beforeEach(() => {
 jest.clearAllMocks();
 mockIsPremium = true;
 mockUpgradeRequest = null;
 mockEntry = FIXTURE;
 mockLoading = false;
});

describe('ExtraBiblicalDetailScreen', () => {
 describe('render — premium tier', () => {
 it('renders hero title + aliases', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 // Title appears twice: screen header + hero card
 expect(getAllByText('1 Enoch (Ethiopic Enoch)').length).toBeGreaterThanOrEqual(1);
 expect(getByText(/Also known as:.*Book of Enoch.*Ethiopic Enoch/)).toBeTruthy();
 });

 it('renders tradition badges', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByLabelText(/^Protestant:/)).toBeTruthy();
 expect(getByLabelText(/^Ethiopian Tewahedo:/)).toBeTruthy();
 });

 it('renders full brief_summary (both paragraphs)', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(
 getByText(/1 Enoch is a composite work of five distinct books\./),
 ).toBeTruthy();
 expect(getByText(/It is preserved complete only in Ethiopic Geʽez\./)).toBeTruthy();
 });

 it('renders NT citations with ref + source + type', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Jude 14-15')).toBeTruthy();
 expect(getByText(/→ 1 Enoch 1:9/)).toBeTruthy();
 expect(getByText('Direct quotation')).toBeTruthy();
 });

 it('renders OT allusions', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Genesis 6:1-4')).toBeTruthy();
 expect(getByText(/The Watchers expand Gen 6:1-4/)).toBeTruthy();
 });

 it('renders scholar voices', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 // 'Nickelsburg' appears twice: scholar-voice name AND further-reading author
 expect(getAllByText('Nickelsburg').length).toBeGreaterThanOrEqual(1);
 expect(getByText(/Hermeneia commentary on 1 Enoch/)).toBeTruthy();
 });

 it('renders related-debate chip and section header', () => {
 const { getByLabelText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('RELATED DEBATES')).toBeTruthy();
 expect(
 getByLabelText('Open debate did-jude-affirm-enoch-as-scripture'),
 ).toBeTruthy();
 });

 it('renders related-difficult-passage and related-journey chips', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByLabelText('Open difficult jude-quotes-enoch')).toBeTruthy();
 expect(getByLabelText('Open journey canon-formation')).toBeTruthy();
 });

 it('renders further-reading items', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('1 Enoch 1')).toBeTruthy();
 expect(getAllByText('Nickelsburg').length).toBeGreaterThanOrEqual(1);
 expect(getByText('Online Aramaic fragments archive')).toBeTruthy();
 });

 it('renders "Coming soon" placeholder when full_summary is null', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Coming soon — expanded scholarly summary/)).toBeTruthy();
 });

 it('renders full_summary when it is present instead of placeholder', () => {
 mockEntry = { ...FIXTURE, full_summary: 'Expanded analysis goes here.' };
 const { getByText, queryByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Expanded analysis goes here.')).toBeTruthy();
 expect(queryByText(/Coming soon/)).toBeNull();
 });
 });

 describe('deep-link navigation — premium tier', () => {
 it('tapping NT citation navigates to Chapter with parsed book/chapter/verse', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Jude 14-15'));
 expect(mockNavigate).toHaveBeenCalledWith(
 'Chapter',
 expect.objectContaining({ bookId: 'jude', chapterNum: 1 }),
 );
 });

 it('tapping OT allusion navigates to Chapter with bookId', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Genesis 6:1-4'));
 expect(mockNavigate).toHaveBeenCalledWith(
 'Chapter',
 expect.objectContaining({ bookId: 'genesis', chapterNum: 6 }),
 );
 });

 it('tapping scholar navigates to ScholarBio', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Scholar: nickelsburg'));
 expect(mockNavigate).toHaveBeenCalledWith('ScholarBio', {
 scholarId: 'nickelsburg',
 });
 });

 it('tapping debate chip navigates to DebateDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(
 getByLabelText('Open debate did-jude-affirm-enoch-as-scripture'),
 );
 expect(mockNavigate).toHaveBeenCalledWith('DebateDetail', {
 topicId: 'did-jude-affirm-enoch-as-scripture',
 });
 });

 it('tapping difficult-passage chip navigates to DifficultPassageDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open difficult jude-quotes-enoch'));
 expect(mockNavigate).toHaveBeenCalledWith('DifficultPassageDetail', {
 passageId: 'jude-quotes-enoch',
 });
 });

 it('tapping journey chip navigates to JourneyDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open journey canon-formation'));
 expect(mockNavigate).toHaveBeenCalledWith('JourneyDetail', {
 journeyId: 'canon-formation',
 });
 });

 it('tapping further-reading with url calls Linking.openURL', () => {
 const openUrlSpy = jest
 .spyOn(Linking, 'openURL')
 .mockResolvedValue(undefined);
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Online Aramaic fragments archive'));
 expect(openUrlSpy).toHaveBeenCalledWith('https://example.org/1enoch-aramaic');
 openUrlSpy.mockRestore();
 });
 });

 describe('free tier (premium gating)', () => {
 it('renders only first paragraph of brief_summary', () => {
 mockIsPremium = false;
 const { getByText, queryByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(
 getByText(/1 Enoch is a composite work of five distinct books\./),
 ).toBeTruthy();
 // Second paragraph is hidden
 expect(
 queryByText(/It is preserved complete only in Ethiopic Geʽez\./),
 ).toBeNull();
 });

 it('hides all gated sections (NT citations, scholars, debates, etc.)', () => {
 mockIsPremium = false;
 const { queryByText, queryByLabelText } = renderWithProviders(
 <ExtraBiblicalDetailScreen />,
 );
 expect(queryByText('NEW TESTAMENT CITATIONS')).toBeNull();
 expect(queryByText('SCHOLAR VOICES')).toBeNull();
 expect(queryByText('RELATED DEBATES')).toBeNull();
 expect(queryByText('FULL SUMMARY')).toBeNull();
 expect(queryByLabelText('Open Jude 14-15')).toBeNull();
 expect(queryByLabelText('Scholar: nickelsburg')).toBeNull();
 });

 it('shows unlock CTA and fires showUpgrade on tap', () => {
 mockIsPremium = false;
 const { getByLabelText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Unlock the full entry/)).toBeTruthy();
 fireEvent.press(getByLabelText('Unlock full entry'));
 expect(mockShowUpgrade).toHaveBeenCalledWith(
 'explore',
 'Extra-Biblical Literature',
 );
 });
 });

 describe('loading + not-found states', () => {
 it('shows loading indicator when loading=true', () => {
 mockLoading = true;
 mockEntry = null;
 const { toJSON } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(toJSON()).not.toBeNull();
 });

 it('shows "Entry not found" when entry=null after load', () => {
 mockLoading = false;
 mockEntry = null;
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Entry not found\./)).toBeTruthy();
 });
 });
});
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(app): ExtraBiblicalDetailScreen (#1548) by CraigBuckmaster · Pull Request #1597 · CraigBuckmaster/ScriptureDeepDive · GitHub
Skip to content
feat(app): ExtraBiblicalDetailScreen (#1548)#1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

CraigBuckmaster
merged 1 commit into

from

Apr 23, 2026
 Merged


feat(app): ExtraBiblicalDetailScreen (#1548)
#1597
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


312 changes: 312 additions & 0 deletions
app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,312 @@
/**
 * ExtraBiblicalDetailScreen.test.tsx — Detail view for one extrabiblical
 * entry (HWGTB-P2-03 / #1548).
 */

import React from 'react';
import { fireEvent } from '@testing-library/react-native';
import { Linking } from 'react-native';
import { renderWithProviders } from '../helpers/renderWithProviders';
import ExtraBiblicalDetailScreen from '@/screens/ExtraBiblicalDetailScreen';
import type { ExtrabiblicalEntry } from '@/types';

// ── Navigation mock ─────────────────────────────────────────────
const mockNavigate = jest.fn();
const mockGoBack = jest.fn();
jest.mock('@react-navigation/native', () => {
 const actual = jest.requireActual('@react-navigation/native');
 return {
 ...actual,
 useNavigation: () => ({
 navigate: mockNavigate,
 goBack: mockGoBack,
 push: jest.fn(),
 setOptions: jest.fn(),
 }),
 useRoute: () => ({ params: { id: '1_enoch' } }),
 useScrollToTop: jest.fn(),
 useFocusEffect: (cb: () => void) => cb(),
 };
});

jest.mock('lucide-react-native', () => ({
 ChevronLeft: () => null,
 ArrowLeft: () => null,
 Search: () => null,
 X: () => null,
}));

jest.mock('react-native-safe-area-context', () => ({
 SafeAreaView: ({ children }: any) => children,
 useSafeAreaInsets: () => ({ top: 44, bottom: 34, left: 0, right: 0 }),
}));

// ── Premium mock — mutable for per-test flip ─────────────────────
let mockIsPremium = true;
const mockShowUpgrade = jest.fn();
const mockDismissUpgrade = jest.fn();
let mockUpgradeRequest: { variant: string; featureName: string } | null = null;
jest.mock('@/hooks/usePremium', () => ({
 usePremium: () => ({
 isPremium: mockIsPremium,
 upgradeRequest: mockUpgradeRequest,
 showUpgrade: mockShowUpgrade,
 dismissUpgrade: mockDismissUpgrade,
 }),
}));

// ── Entry fixture ───────────────────────────────────────────────
const FIXTURE: ExtrabiblicalEntry = {
 id: '1_enoch',
 title: '1 Enoch (Ethiopic Enoch)',
 also_known_as: ['Book of Enoch', 'Ethiopic Enoch'],
 category: 'pseudepigrapha',
 estimated_date: '3rd c. BC – 1st c. AD',
 original_language: 'Aramaic / Hebrew, preserved in Ethiopic Geʽez',
 tradition_status: {
 protestant: 'not canonical',
 catholic: 'not canonical',
 eastern_orthodox: 'not canonical',
 ethiopian_tewahedo: 'canonical (81-book canon)',
 },
 brief_summary:
 '1 Enoch is a composite work of five distinct books.\n\nIt is preserved complete only in Ethiopic Geʽez.',
 full_summary: null,
 nt_citations: [
 { ref: 'Jude 14-15', cites: '1 Enoch 1:9', type: 'direct_quotation' },
 ],
 ot_allusions: [
 { ref: 'Genesis 6:1-4', connection: 'The Watchers expand Gen 6:1-4.' },
 ],
 scholar_voices: [
 {
 scholar_id: 'nickelsburg',
 position: "Hermeneia commentary on 1 Enoch.",
 },
 ],
 related_debate_ids: ['did-jude-affirm-enoch-as-scripture'],
 related_journey_ids: ['canon-formation'],
 related_difficult_passage_ids: ['jude-quotes-enoch'],
 tags: ['pseudepigrapha', 'hwgtb'],
 further_reading: [
 {
 title: '1 Enoch 1',
 author: 'Nickelsburg',
 note: 'Hermeneia (2001)',
 },
 {
 title: 'Online Aramaic fragments archive',
 url: 'https://example.org/1enoch-aramaic',
 },
 ],
};

let mockEntry: ExtrabiblicalEntry | null = FIXTURE;
let mockLoading = false;
jest.mock('@/hooks/useExtraBiblicalEntry', () => ({
 useExtraBiblicalEntry: () => ({ entry: mockEntry, loading: mockLoading }),
}));

beforeEach(() => {
 jest.clearAllMocks();
 mockIsPremium = true;
 mockUpgradeRequest = null;
 mockEntry = FIXTURE;
 mockLoading = false;
});

describe('ExtraBiblicalDetailScreen', () => {
 describe('render — premium tier', () => {
 it('renders hero title + aliases', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 // Title appears twice: screen header + hero card
 expect(getAllByText('1 Enoch (Ethiopic Enoch)').length).toBeGreaterThanOrEqual(1);
 expect(getByText(/Also known as:.*Book of Enoch.*Ethiopic Enoch/)).toBeTruthy();
 });

 it('renders tradition badges', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByLabelText(/^Protestant:/)).toBeTruthy();
 expect(getByLabelText(/^Ethiopian Tewahedo:/)).toBeTruthy();
 });

 it('renders full brief_summary (both paragraphs)', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(
 getByText(/1 Enoch is a composite work of five distinct books\./),
 ).toBeTruthy();
 expect(getByText(/It is preserved complete only in Ethiopic Geʽez\./)).toBeTruthy();
 });

 it('renders NT citations with ref + source + type', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Jude 14-15')).toBeTruthy();
 expect(getByText(/→ 1 Enoch 1:9/)).toBeTruthy();
 expect(getByText('Direct quotation')).toBeTruthy();
 });

 it('renders OT allusions', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Genesis 6:1-4')).toBeTruthy();
 expect(getByText(/The Watchers expand Gen 6:1-4/)).toBeTruthy();
 });

 it('renders scholar voices', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 // 'Nickelsburg' appears twice: scholar-voice name AND further-reading author
 expect(getAllByText('Nickelsburg').length).toBeGreaterThanOrEqual(1);
 expect(getByText(/Hermeneia commentary on 1 Enoch/)).toBeTruthy();
 });

 it('renders related-debate chip and section header', () => {
 const { getByLabelText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('RELATED DEBATES')).toBeTruthy();
 expect(
 getByLabelText('Open debate did-jude-affirm-enoch-as-scripture'),
 ).toBeTruthy();
 });

 it('renders related-difficult-passage and related-journey chips', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByLabelText('Open difficult jude-quotes-enoch')).toBeTruthy();
 expect(getByLabelText('Open journey canon-formation')).toBeTruthy();
 });

 it('renders further-reading items', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('1 Enoch 1')).toBeTruthy();
 expect(getAllByText('Nickelsburg').length).toBeGreaterThanOrEqual(1);
 expect(getByText('Online Aramaic fragments archive')).toBeTruthy();
 });

 it('renders "Coming soon" placeholder when full_summary is null', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Coming soon — expanded scholarly summary/)).toBeTruthy();
 });

 it('renders full_summary when it is present instead of placeholder', () => {
 mockEntry = { ...FIXTURE, full_summary: 'Expanded analysis goes here.' };
 const { getByText, queryByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Expanded analysis goes here.')).toBeTruthy();
 expect(queryByText(/Coming soon/)).toBeNull();
 });
 });

 describe('deep-link navigation — premium tier', () => {
 it('tapping NT citation navigates to Chapter with parsed book/chapter/verse', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Jude 14-15'));
 expect(mockNavigate).toHaveBeenCalledWith(
 'Chapter',
 expect.objectContaining({ bookId: 'jude', chapterNum: 1 }),
 );
 });

 it('tapping OT allusion navigates to Chapter with bookId', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Genesis 6:1-4'));
 expect(mockNavigate).toHaveBeenCalledWith(
 'Chapter',
 expect.objectContaining({ bookId: 'genesis', chapterNum: 6 }),
 );
 });

 it('tapping scholar navigates to ScholarBio', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Scholar: nickelsburg'));
 expect(mockNavigate).toHaveBeenCalledWith('ScholarBio', {
 scholarId: 'nickelsburg',
 });
 });

 it('tapping debate chip navigates to DebateDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(
 getByLabelText('Open debate did-jude-affirm-enoch-as-scripture'),
 );
 expect(mockNavigate).toHaveBeenCalledWith('DebateDetail', {
 topicId: 'did-jude-affirm-enoch-as-scripture',
 });
 });

 it('tapping difficult-passage chip navigates to DifficultPassageDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open difficult jude-quotes-enoch'));
 expect(mockNavigate).toHaveBeenCalledWith('DifficultPassageDetail', {
 passageId: 'jude-quotes-enoch',
 });
 });

 it('tapping journey chip navigates to JourneyDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open journey canon-formation'));
 expect(mockNavigate).toHaveBeenCalledWith('JourneyDetail', {
 journeyId: 'canon-formation',
 });
 });

 it('tapping further-reading with url calls Linking.openURL', () => {
 const openUrlSpy = jest
 .spyOn(Linking, 'openURL')
 .mockResolvedValue(undefined);
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Online Aramaic fragments archive'));
 expect(openUrlSpy).toHaveBeenCalledWith('https://example.org/1enoch-aramaic');
 openUrlSpy.mockRestore();
 });
 });

 describe('free tier (premium gating)', () => {
 it('renders only first paragraph of brief_summary', () => {
 mockIsPremium = false;
 const { getByText, queryByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(
 getByText(/1 Enoch is a composite work of five distinct books\./),
 ).toBeTruthy();
 // Second paragraph is hidden
 expect(
 queryByText(/It is preserved complete only in Ethiopic Geʽez\./),
 ).toBeNull();
 });

 it('hides all gated sections (NT citations, scholars, debates, etc.)', () => {
 mockIsPremium = false;
 const { queryByText, queryByLabelText } = renderWithProviders(
 <ExtraBiblicalDetailScreen />,
 );
 expect(queryByText('NEW TESTAMENT CITATIONS')).toBeNull();
 expect(queryByText('SCHOLAR VOICES')).toBeNull();
 expect(queryByText('RELATED DEBATES')).toBeNull();
 expect(queryByText('FULL SUMMARY')).toBeNull();
 expect(queryByLabelText('Open Jude 14-15')).toBeNull();
 expect(queryByLabelText('Scholar: nickelsburg')).toBeNull();
 });

 it('shows unlock CTA and fires showUpgrade on tap', () => {
 mockIsPremium = false;
 const { getByLabelText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Unlock the full entry/)).toBeTruthy();
 fireEvent.press(getByLabelText('Unlock full entry'));
 expect(mockShowUpgrade).toHaveBeenCalledWith(
 'explore',
 'Extra-Biblical Literature',
 );
 });
 });

 describe('loading + not-found states', () => {
 it('shows loading indicator when loading=true', () => {
 mockLoading = true;
 mockEntry = null;
 const { toJSON } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(toJSON()).not.toBeNull();
 });

 it('shows "Entry not found" when entry=null after load', () => {
 mockLoading = false;
 mockEntry = null;
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Entry not found\./)).toBeTruthy();
 });
 });
});
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
feat(app): ExtraBiblicalDetailScreen (#1548) by CraigBuckmaster · Pull Request #1597 · CraigBuckmaster/ScriptureDeepDive · GitHub
Skip to content
feat(app): ExtraBiblicalDetailScreen (#1548)#1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

CraigBuckmaster
merged 1 commit into

from

Apr 23, 2026
 Merged


feat(app): ExtraBiblicalDetailScreen (#1548)
#1597
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


312 changes: 312 additions & 0 deletions
app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,312 @@
/**
 * ExtraBiblicalDetailScreen.test.tsx — Detail view for one extrabiblical
 * entry (HWGTB-P2-03 / #1548).
 */

import React from 'react';
import { fireEvent } from '@testing-library/react-native';
import { Linking } from 'react-native';
import { renderWithProviders } from '../helpers/renderWithProviders';
import ExtraBiblicalDetailScreen from '@/screens/ExtraBiblicalDetailScreen';
import type { ExtrabiblicalEntry } from '@/types';

// ── Navigation mock ─────────────────────────────────────────────
const mockNavigate = jest.fn();
const mockGoBack = jest.fn();
jest.mock('@react-navigation/native', () => {
 const actual = jest.requireActual('@react-navigation/native');
 return {
 ...actual,
 useNavigation: () => ({
 navigate: mockNavigate,
 goBack: mockGoBack,
 push: jest.fn(),
 setOptions: jest.fn(),
 }),
 useRoute: () => ({ params: { id: '1_enoch' } }),
 useScrollToTop: jest.fn(),
 useFocusEffect: (cb: () => void) => cb(),
 };
});

jest.mock('lucide-react-native', () => ({
 ChevronLeft: () => null,
 ArrowLeft: () => null,
 Search: () => null,
 X: () => null,
}));

jest.mock('react-native-safe-area-context', () => ({
 SafeAreaView: ({ children }: any) => children,
 useSafeAreaInsets: () => ({ top: 44, bottom: 34, left: 0, right: 0 }),
}));

// ── Premium mock — mutable for per-test flip ─────────────────────
let mockIsPremium = true;
const mockShowUpgrade = jest.fn();
const mockDismissUpgrade = jest.fn();
let mockUpgradeRequest: { variant: string; featureName: string } | null = null;
jest.mock('@/hooks/usePremium', () => ({
 usePremium: () => ({
 isPremium: mockIsPremium,
 upgradeRequest: mockUpgradeRequest,
 showUpgrade: mockShowUpgrade,
 dismissUpgrade: mockDismissUpgrade,
 }),
}));

// ── Entry fixture ───────────────────────────────────────────────
const FIXTURE: ExtrabiblicalEntry = {
 id: '1_enoch',
 title: '1 Enoch (Ethiopic Enoch)',
 also_known_as: ['Book of Enoch', 'Ethiopic Enoch'],
 category: 'pseudepigrapha',
 estimated_date: '3rd c. BC – 1st c. AD',
 original_language: 'Aramaic / Hebrew, preserved in Ethiopic Geʽez',
 tradition_status: {
 protestant: 'not canonical',
 catholic: 'not canonical',
 eastern_orthodox: 'not canonical',
 ethiopian_tewahedo: 'canonical (81-book canon)',
 },
 brief_summary:
 '1 Enoch is a composite work of five distinct books.\n\nIt is preserved complete only in Ethiopic Geʽez.',
 full_summary: null,
 nt_citations: [
 { ref: 'Jude 14-15', cites: '1 Enoch 1:9', type: 'direct_quotation' },
 ],
 ot_allusions: [
 { ref: 'Genesis 6:1-4', connection: 'The Watchers expand Gen 6:1-4.' },
 ],
 scholar_voices: [
 {
 scholar_id: 'nickelsburg',
 position: "Hermeneia commentary on 1 Enoch.",
 },
 ],
 related_debate_ids: ['did-jude-affirm-enoch-as-scripture'],
 related_journey_ids: ['canon-formation'],
 related_difficult_passage_ids: ['jude-quotes-enoch'],
 tags: ['pseudepigrapha', 'hwgtb'],
 further_reading: [
 {
 title: '1 Enoch 1',
 author: 'Nickelsburg',
 note: 'Hermeneia (2001)',
 },
 {
 title: 'Online Aramaic fragments archive',
 url: 'https://example.org/1enoch-aramaic',
 },
 ],
};

let mockEntry: ExtrabiblicalEntry | null = FIXTURE;
let mockLoading = false;
jest.mock('@/hooks/useExtraBiblicalEntry', () => ({
 useExtraBiblicalEntry: () => ({ entry: mockEntry, loading: mockLoading }),
}));

beforeEach(() => {
 jest.clearAllMocks();
 mockIsPremium = true;
 mockUpgradeRequest = null;
 mockEntry = FIXTURE;
 mockLoading = false;
});

describe('ExtraBiblicalDetailScreen', () => {
 describe('render — premium tier', () => {
 it('renders hero title + aliases', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 // Title appears twice: screen header + hero card
 expect(getAllByText('1 Enoch (Ethiopic Enoch)').length).toBeGreaterThanOrEqual(1);
 expect(getByText(/Also known as:.*Book of Enoch.*Ethiopic Enoch/)).toBeTruthy();
 });

 it('renders tradition badges', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByLabelText(/^Protestant:/)).toBeTruthy();
 expect(getByLabelText(/^Ethiopian Tewahedo:/)).toBeTruthy();
 });

 it('renders full brief_summary (both paragraphs)', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(
 getByText(/1 Enoch is a composite work of five distinct books\./),
 ).toBeTruthy();
 expect(getByText(/It is preserved complete only in Ethiopic Geʽez\./)).toBeTruthy();
 });

 it('renders NT citations with ref + source + type', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Jude 14-15')).toBeTruthy();
 expect(getByText(/→ 1 Enoch 1:9/)).toBeTruthy();
 expect(getByText('Direct quotation')).toBeTruthy();
 });

 it('renders OT allusions', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Genesis 6:1-4')).toBeTruthy();
 expect(getByText(/The Watchers expand Gen 6:1-4/)).toBeTruthy();
 });

 it('renders scholar voices', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 // 'Nickelsburg' appears twice: scholar-voice name AND further-reading author
 expect(getAllByText('Nickelsburg').length).toBeGreaterThanOrEqual(1);
 expect(getByText(/Hermeneia commentary on 1 Enoch/)).toBeTruthy();
 });

 it('renders related-debate chip and section header', () => {
 const { getByLabelText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('RELATED DEBATES')).toBeTruthy();
 expect(
 getByLabelText('Open debate did-jude-affirm-enoch-as-scripture'),
 ).toBeTruthy();
 });

 it('renders related-difficult-passage and related-journey chips', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByLabelText('Open difficult jude-quotes-enoch')).toBeTruthy();
 expect(getByLabelText('Open journey canon-formation')).toBeTruthy();
 });

 it('renders further-reading items', () => {
 const { getAllByText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('1 Enoch 1')).toBeTruthy();
 expect(getAllByText('Nickelsburg').length).toBeGreaterThanOrEqual(1);
 expect(getByText('Online Aramaic fragments archive')).toBeTruthy();
 });

 it('renders "Coming soon" placeholder when full_summary is null', () => {
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Coming soon — expanded scholarly summary/)).toBeTruthy();
 });

 it('renders full_summary when it is present instead of placeholder', () => {
 mockEntry = { ...FIXTURE, full_summary: 'Expanded analysis goes here.' };
 const { getByText, queryByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText('Expanded analysis goes here.')).toBeTruthy();
 expect(queryByText(/Coming soon/)).toBeNull();
 });
 });

 describe('deep-link navigation — premium tier', () => {
 it('tapping NT citation navigates to Chapter with parsed book/chapter/verse', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Jude 14-15'));
 expect(mockNavigate).toHaveBeenCalledWith(
 'Chapter',
 expect.objectContaining({ bookId: 'jude', chapterNum: 1 }),
 );
 });

 it('tapping OT allusion navigates to Chapter with bookId', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Genesis 6:1-4'));
 expect(mockNavigate).toHaveBeenCalledWith(
 'Chapter',
 expect.objectContaining({ bookId: 'genesis', chapterNum: 6 }),
 );
 });

 it('tapping scholar navigates to ScholarBio', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Scholar: nickelsburg'));
 expect(mockNavigate).toHaveBeenCalledWith('ScholarBio', {
 scholarId: 'nickelsburg',
 });
 });

 it('tapping debate chip navigates to DebateDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(
 getByLabelText('Open debate did-jude-affirm-enoch-as-scripture'),
 );
 expect(mockNavigate).toHaveBeenCalledWith('DebateDetail', {
 topicId: 'did-jude-affirm-enoch-as-scripture',
 });
 });

 it('tapping difficult-passage chip navigates to DifficultPassageDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open difficult jude-quotes-enoch'));
 expect(mockNavigate).toHaveBeenCalledWith('DifficultPassageDetail', {
 passageId: 'jude-quotes-enoch',
 });
 });

 it('tapping journey chip navigates to JourneyDetail', () => {
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open journey canon-formation'));
 expect(mockNavigate).toHaveBeenCalledWith('JourneyDetail', {
 journeyId: 'canon-formation',
 });
 });

 it('tapping further-reading with url calls Linking.openURL', () => {
 const openUrlSpy = jest
 .spyOn(Linking, 'openURL')
 .mockResolvedValue(undefined);
 const { getByLabelText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 fireEvent.press(getByLabelText('Open Online Aramaic fragments archive'));
 expect(openUrlSpy).toHaveBeenCalledWith('https://example.org/1enoch-aramaic');
 openUrlSpy.mockRestore();
 });
 });

 describe('free tier (premium gating)', () => {
 it('renders only first paragraph of brief_summary', () => {
 mockIsPremium = false;
 const { getByText, queryByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(
 getByText(/1 Enoch is a composite work of five distinct books\./),
 ).toBeTruthy();
 // Second paragraph is hidden
 expect(
 queryByText(/It is preserved complete only in Ethiopic Geʽez\./),
 ).toBeNull();
 });

 it('hides all gated sections (NT citations, scholars, debates, etc.)', () => {
 mockIsPremium = false;
 const { queryByText, queryByLabelText } = renderWithProviders(
 <ExtraBiblicalDetailScreen />,
 );
 expect(queryByText('NEW TESTAMENT CITATIONS')).toBeNull();
 expect(queryByText('SCHOLAR VOICES')).toBeNull();
 expect(queryByText('RELATED DEBATES')).toBeNull();
 expect(queryByText('FULL SUMMARY')).toBeNull();
 expect(queryByLabelText('Open Jude 14-15')).toBeNull();
 expect(queryByLabelText('Scholar: nickelsburg')).toBeNull();
 });

 it('shows unlock CTA and fires showUpgrade on tap', () => {
 mockIsPremium = false;
 const { getByLabelText, getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Unlock the full entry/)).toBeTruthy();
 fireEvent.press(getByLabelText('Unlock full entry'));
 expect(mockShowUpgrade).toHaveBeenCalledWith(
 'explore',
 'Extra-Biblical Literature',
 );
 });
 });

 describe('loading + not-found states', () => {
 it('shows loading indicator when loading=true', () => {
 mockLoading = true;
 mockEntry = null;
 const { toJSON } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(toJSON()).not.toBeNull();
 });

 it('shows "Entry not found" when entry=null after load', () => {
 mockLoading = false;
 mockEntry = null;
 const { getByText } = renderWithProviders(<ExtraBiblicalDetailScreen />);
 expect(getByText(/Entry not found\./)).toBeTruthy();
 });
 });
});
Loading
Loading