feat(app): ExtraBiblicalDetailScreen (#1548) by CraigBuckmaster · Pull Request #1597 · CraigBuckmaster/ScriptureDeepDive

CraigBuckmaster · 2026-04-23T17:36:35Z

What this does

Detail view for a single extrabiblical entry (1 Enoch, Jubilees, Tobit, etc.) — the deep-link target for SecondTemplePanel chips (#1595) and ExtraBiblicalIndexScreen card taps (#1596). Renders 10 sections per the issue spec.

Closes

Closes#1548

Sections (in order)

Hero — title + aliases + dates/language + 4-tradition status badges (ExtraBiblicalHero component)
Brief summary — always visible (full on premium, first paragraph only on free)
NT citations — tappable → Chapter screen w/ verse highlight
OT allusions — tappable → Chapter screen
Scholar voices — tappable → ScholarBio screen
Related debates — chips → DebateDetail
Related difficult passages — chips → DifficultPassageDetail
Related journeys — chips → JourneyDetail
Further reading — url → Linking.openURL; text-only rows render as non-tappable (the Phase-1 seed has no URLs)
Full summary — prose if populated, else "Coming soon — expanded scholarly summary" placeholder card

Files added

app/src/components/ExtraBiblicalHero.tsx — 170 LOC
app/src/screens/ExtraBiblicalDetailScreen.tsx — 703 LOC
app/src/hooks/useExtraBiblicalEntry.ts — single-entry loader, 51 LOC
app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx — 312 LOC, 23 tests

Files touched

app/src/db/content/extrabiblical.ts — new rowToEntry() parser + getExtraBiblicalEntry() wrapper
app/src/db/content/index.ts — barrel export
app/src/types/meta.ts — ExtrabiblicalEntry, ExtrabiblicalNTCitation, ExtrabiblicalOTAllusion, ExtrabiblicalScholarVoice, ExtrabiblicalFurtherReading
app/src/navigation/types.ts — ExtraBiblicalDetail route param
app/src/navigation/ExploreStack.tsx — Stack.Screen registration

Some additions overlap with PR #1596 (#1547's Index screen) — the types, query-module file, and barrel exports are identical additions that merge cleanly regardless of order.

Premium gating

Matches the DebatePanel / DebateDetailScreen precedent — props-based, screen wires usePremium() itself.

Free tier: Hero + first paragraph of brief_summary only; gated region replaced by "✨ Unlock the full entry" card with description; tap fires showUpgrade('explore', 'Extra-Biblical Literature').
Premium tier: all 10 sections visible with full deep-link behavior.

Deep-link handling — verse ref parsing

The Phase-1 extrabiblical seed (#1541) uses natural-language refs like "Jude 14-15" and "Genesis 6:1-4". The standard parseReference utility handles most of these but fails on single-chapter book refs ("Jude 14-15", "Obadiah 11", "Philemon 6") because its regex requires a colon before the verse.

Added a screen-local parseReferenceExtended that wraps parseReference with a fallback: if standard parsing fails and the book is single-chapter (Obadiah, Philemon, 2-3 John, Jude), treat the number as a verse and return chapter=1. This is the minimum needed to make Jude-heavy content (1 Enoch, Assumption of Moses) navigate correctly from their NT citations.

Note on issue file-path text

Issue says app/src/db/queries/extrabiblical.ts, but the actual repo convention is app/src/db/content/*.ts (18 sibling query modules). Placed at db/content/ to match real layout.

Note on further-reading URLs

The issue specifies Linking.openURL for external links, but the Phase-1 extrabiblical.json seed (#1541) has no URL fields — further_reading entries are text-only (title, author, note). Code supports URLs when present (guarded: TouchableOpacity only when url is a non-empty string, else plain View); when the content author adds URLs in a future PR, the tap handler lights up automatically.

How I verified

npx tsc --noEmit — clean ✅
npm run lint on touched files — 0 warnings on new/touched files (the 4 pre-existing master warnings in unrelated files are out of scope) ✅
npx jest (full suite) — 470 suites / 3497 tests pass ✅

Tests (23/23 passing)

render — premium tier
✓ renders hero title + aliases
✓ renders tradition badges
✓ renders full brief_summary (both paragraphs)
✓ renders NT citations with ref + source + type
✓ renders OT allusions
✓ renders scholar voices
✓ renders related-debate chip and section header
✓ renders related-difficult-passage and related-journey chips
✓ renders further-reading items
✓ renders "Coming soon" placeholder when full_summary is null
✓ renders full_summary when it is present instead of placeholder
deep-link navigation — premium tier
✓ tapping NT citation navigates to Chapter with parsed book/chapter/verse
✓ tapping OT allusion navigates to Chapter with bookId
✓ tapping scholar navigates to ScholarBio
✓ tapping debate chip navigates to DebateDetail
✓ tapping difficult-passage chip navigates to DifficultPassageDetail
✓ tapping journey chip navigates to JourneyDetail
✓ tapping further-reading with url calls Linking.openURL
free tier (premium gating)
✓ renders only first paragraph of brief_summary
✓ hides all gated sections (NT citations, scholars, debates, etc.)
✓ shows unlock CTA and fires showUpgrade on tap
loading + not-found states
✓ shows loading indicator when loading=true
✓ shows "Entry not found" when entry=null after load

Merge order

Depends on: #1538 (extrabiblical schema), #1541 (12 seeded entries).

Pairs with:

PR feat(app): SecondTemplePanel component (#1546) #1595 (SecondTemplePanel) — its onExtraBiblicalPress chips will now navigate to this screen once both PRs are merged and ChapterScreen threads the callback through.
PR feat(app): ExtraBiblicalIndexScreen (#1547) #1596 (ExtraBiblicalIndexScreen) — its card-tap navigate('ExtraBiblicalDetail', { id }) lands on this screen. This PR overlaps with feat(app): ExtraBiblicalIndexScreen (#1547) #1596 on types / query module / barrel exports — identical additions that merge cleanly in either order.

Rollback

Revert this PR. ExtraBiblicalDetail route unregisters; ExtraBiblicalDetailScreen deleted. SecondTemplePanel chips and ExtraBiblicalIndexScreen tap handlers continue to call navigation.navigate('ExtraBiblicalDetail', …) — which will no longer resolve — but the guarded optional-callback in SecondTemplePanel means chips simply won't render if the parent doesn't wire them, and the Index screen would fail more loudly (acceptable if reverting deliberately).

Generated by Claude Code

github-actions · 2026-04-23T17:38:57Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3523	❌ 0	3523
Suites	✅ 473	❌ 0	473

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 81.2s

Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550

Coverage on this PR was 81.85% lines. Same temporary 79%/81% fallback as #1596/#1597/#1580 with tracking issue #1599.

Detail view for a single extrabiblical entry (1 Enoch, Jubilees, Tobit, etc.). 10 sections per the issue spec: 1. Hero (title + aliases + dates + 4-tradition status) 2. Brief summary 3. NT citations 4. OT allusions 5. Scholar voices 6. Related debates 7. Related difficult passages 8. Related journeys 9. Further reading 10. Full summary (or "Coming soon" placeholder) Files added app/src/components/ExtraBiblicalHero.tsx — hero (title, aliases, dates, tradition-status badges) app/src/screens/ExtraBiblicalDetailScreen.tsx — the screen app/src/hooks/useExtraBiblicalEntry.ts — single-entry loader app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx — 23 tests Files touched (some overlap with PR #1596 / #1547 — identical additions that merge cleanly) app/src/db/content/extrabiblical.ts — new rowToEntry() parser + getExtraBiblicalEntry() wrapper app/src/db/content/index.ts — barrel export app/src/types/meta.ts — ExtrabiblicalEntry, ExtrabiblicalNTCitation, ExtrabiblicalOTAllusion, ExtrabiblicalScholarVoice, ExtrabiblicalFurtherReading app/src/navigation/types.ts — ExtraBiblicalDetail route app/src/navigation/ExploreStack.tsx — Stack.Screen registration Premium gating (matches DebatePanel pattern — props-based, screen wires usePremium() itself — mirroring DebateDetailScreen and ArchaeologyDetailScreen) Free tier : Hero + first paragraph of brief_summary only; gated region replaced by '✨ Unlock the full entry' card; tap fires showUpgrade('explore', 'Extra-Biblical Literature'). Premium : all 10 sections visible with full deep-link behavior. Deep-links - NT citations / OT allusions → Chapter screen. Verse refs parsed via parseReference() (handles 'Genesis 6:1-4', '1 Cor 13:4') with an extension for single-chapter books ('Jude 14-15' → jude 1:14). The Phase-1 extrabiblical seed uses natural-language refs heavily, so the extended parser is necessary — plain parseReference rejects 'Jude 14-15' because the regex requires a colon before verse. - Scholar voices → ScholarBio screen (matches DebateDetail). - Related debates → DebateDetail. - Related difficult passages → DifficultPassageDetail. - Related journeys → JourneyDetail. - Further reading (with url) → Linking.openURL; rows without url render as non-tappable text (the Phase-1 seed is text-only per further_reading shape). Note on issue file-path text Issue says 'app/src/db/queries/extrabiblical.ts'. Actual repo convention is app/src/db/content/*.ts (18 sibling query modules). Placed at db/content/ to match real layout. Null full_summary → 'Coming soon — expanded scholarly summary' placeholder card; non-null renders the full text as regular body prose. The full_summary field is filled in by Phase 4 (HWGTB-P4-02A/B/C/D). How verified npx tsc --noEmit — clean npm run lint (src/) — 0 warnings on new/touched files (4 pre-existing master warnings unrelated to this PR) npx jest (full suite) — 470 suites / 3497 tests pass 23 new tests cover: - Hero render (title, aliases, tradition badges) - Brief summary full vs first-paragraph-only - All 7 mid-sections render with correct labels and row content - Full-summary rendering vs 'Coming soon' placeholder - Every deep-link: NT citation → Chapter (with verse), OT allusion → Chapter, scholar → ScholarBio, debate → DebateDetail, difficult passage → DifficultPassageDetail, journey → JourneyDetail, further-reading url → Linking.openURL - Free-tier: first paragraph only, gated sections hidden, unlock CTA fires showUpgrade with correct params - Loading indicator + 'Entry not found' error state Merge order Depends on #1538 (extrabiblical schema), #1541 (12 seeded entries), and overlaps with #1547 (Index screen) on the types, query module, and barrel exports — identical additions that merge either way. Pairs with #1595 (SecondTemplePanel) whose chips navigate here, and #1547 whose entry cards navigate here. Closes#1548

Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550

* feat(app): CanonComparisonScreen (#1550) Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550 * fix(types): add BookIntro to ExploreStackParamList The CanonComparison screen registered BookIntroScreen on ExploreStack but the param list didn't declare it, causing TS2322 on navigate calls from CanonComparisonScreen. Adds the route to ExploreStackParamList alongside the existing CanonComparison entry. BookIntro also exists on RootStack; same route on two stacks is fine for React Navigation. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude (for Craig) <claude@anthropic.com>

CraigBuckmaster · 2026-04-23T17:36:35Z

What this does

Detail view for a single extrabiblical entry (1 Enoch, Jubilees, Tobit, etc.) — the deep-link target for SecondTemplePanel chips (#1595) and ExtraBiblicalIndexScreen card taps (#1596). Renders 10 sections per the issue spec.

Closes

Closes#1548

Sections (in order)

Hero — title + aliases + dates/language + 4-tradition status badges (ExtraBiblicalHero component)
Brief summary — always visible (full on premium, first paragraph only on free)
NT citations — tappable → Chapter screen w/ verse highlight
OT allusions — tappable → Chapter screen
Scholar voices — tappable → ScholarBio screen
Related debates — chips → DebateDetail
Related difficult passages — chips → DifficultPassageDetail
Related journeys — chips → JourneyDetail
Further reading — url → Linking.openURL; text-only rows render as non-tappable (the Phase-1 seed has no URLs)
Full summary — prose if populated, else "Coming soon — expanded scholarly summary" placeholder card

Files added

app/src/components/ExtraBiblicalHero.tsx — 170 LOC
app/src/screens/ExtraBiblicalDetailScreen.tsx — 703 LOC
app/src/hooks/useExtraBiblicalEntry.ts — single-entry loader, 51 LOC
app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx — 312 LOC, 23 tests

Files touched

app/src/db/content/extrabiblical.ts — new rowToEntry() parser + getExtraBiblicalEntry() wrapper
app/src/db/content/index.ts — barrel export
app/src/types/meta.ts — ExtrabiblicalEntry, ExtrabiblicalNTCitation, ExtrabiblicalOTAllusion, ExtrabiblicalScholarVoice, ExtrabiblicalFurtherReading
app/src/navigation/types.ts — ExtraBiblicalDetail route param
app/src/navigation/ExploreStack.tsx — Stack.Screen registration

Some additions overlap with PR #1596 (#1547's Index screen) — the types, query-module file, and barrel exports are identical additions that merge cleanly regardless of order.

Premium gating

Matches the DebatePanel / DebateDetailScreen precedent — props-based, screen wires usePremium() itself.

Free tier: Hero + first paragraph of brief_summary only; gated region replaced by "✨ Unlock the full entry" card with description; tap fires showUpgrade('explore', 'Extra-Biblical Literature').
Premium tier: all 10 sections visible with full deep-link behavior.

Deep-link handling — verse ref parsing

The Phase-1 extrabiblical seed (#1541) uses natural-language refs like "Jude 14-15" and "Genesis 6:1-4". The standard parseReference utility handles most of these but fails on single-chapter book refs ("Jude 14-15", "Obadiah 11", "Philemon 6") because its regex requires a colon before the verse.

Added a screen-local parseReferenceExtended that wraps parseReference with a fallback: if standard parsing fails and the book is single-chapter (Obadiah, Philemon, 2-3 John, Jude), treat the number as a verse and return chapter=1. This is the minimum needed to make Jude-heavy content (1 Enoch, Assumption of Moses) navigate correctly from their NT citations.

Note on issue file-path text

Issue says app/src/db/queries/extrabiblical.ts, but the actual repo convention is app/src/db/content/*.ts (18 sibling query modules). Placed at db/content/ to match real layout.

Note on further-reading URLs

The issue specifies Linking.openURL for external links, but the Phase-1 extrabiblical.json seed (#1541) has no URL fields — further_reading entries are text-only (title, author, note). Code supports URLs when present (guarded: TouchableOpacity only when url is a non-empty string, else plain View); when the content author adds URLs in a future PR, the tap handler lights up automatically.

How I verified

npx tsc --noEmit — clean ✅
npm run lint on touched files — 0 warnings on new/touched files (the 4 pre-existing master warnings in unrelated files are out of scope) ✅
npx jest (full suite) — 470 suites / 3497 tests pass ✅

Tests (23/23 passing)

render — premium tier
✓ renders hero title + aliases
✓ renders tradition badges
✓ renders full brief_summary (both paragraphs)
✓ renders NT citations with ref + source + type
✓ renders OT allusions
✓ renders scholar voices
✓ renders related-debate chip and section header
✓ renders related-difficult-passage and related-journey chips
✓ renders further-reading items
✓ renders "Coming soon" placeholder when full_summary is null
✓ renders full_summary when it is present instead of placeholder
deep-link navigation — premium tier
✓ tapping NT citation navigates to Chapter with parsed book/chapter/verse
✓ tapping OT allusion navigates to Chapter with bookId
✓ tapping scholar navigates to ScholarBio
✓ tapping debate chip navigates to DebateDetail
✓ tapping difficult-passage chip navigates to DifficultPassageDetail
✓ tapping journey chip navigates to JourneyDetail
✓ tapping further-reading with url calls Linking.openURL
free tier (premium gating)
✓ renders only first paragraph of brief_summary
✓ hides all gated sections (NT citations, scholars, debates, etc.)
✓ shows unlock CTA and fires showUpgrade on tap
loading + not-found states
✓ shows loading indicator when loading=true
✓ shows "Entry not found" when entry=null after load

Merge order

Depends on: #1538 (extrabiblical schema), #1541 (12 seeded entries).

Pairs with:

PR feat(app): SecondTemplePanel component (#1546) #1595 (SecondTemplePanel) — its onExtraBiblicalPress chips will now navigate to this screen once both PRs are merged and ChapterScreen threads the callback through.
PR feat(app): ExtraBiblicalIndexScreen (#1547) #1596 (ExtraBiblicalIndexScreen) — its card-tap navigate('ExtraBiblicalDetail', { id }) lands on this screen. This PR overlaps with feat(app): ExtraBiblicalIndexScreen (#1547) #1596 on types / query module / barrel exports — identical additions that merge cleanly in either order.

Rollback

Revert this PR. ExtraBiblicalDetail route unregisters; ExtraBiblicalDetailScreen deleted. SecondTemplePanel chips and ExtraBiblicalIndexScreen tap handlers continue to call navigation.navigate('ExtraBiblicalDetail', …) — which will no longer resolve — but the guarded optional-callback in SecondTemplePanel means chips simply won't render if the parent doesn't wire them, and the Index screen would fail more loudly (acceptable if reverting deliberately).

Generated by Claude Code

github-actions · 2026-04-23T17:38:57Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3523	❌ 0	3523
Suites	✅ 473	❌ 0	473

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 81.2s

Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550

Coverage on this PR was 81.85% lines. Same temporary 79%/81% fallback as #1596/#1597/#1580 with tracking issue #1599.

Detail view for a single extrabiblical entry (1 Enoch, Jubilees, Tobit, etc.). 10 sections per the issue spec: 1. Hero (title + aliases + dates + 4-tradition status) 2. Brief summary 3. NT citations 4. OT allusions 5. Scholar voices 6. Related debates 7. Related difficult passages 8. Related journeys 9. Further reading 10. Full summary (or "Coming soon" placeholder) Files added app/src/components/ExtraBiblicalHero.tsx — hero (title, aliases, dates, tradition-status badges) app/src/screens/ExtraBiblicalDetailScreen.tsx — the screen app/src/hooks/useExtraBiblicalEntry.ts — single-entry loader app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx — 23 tests Files touched (some overlap with PR #1596 / #1547 — identical additions that merge cleanly) app/src/db/content/extrabiblical.ts — new rowToEntry() parser + getExtraBiblicalEntry() wrapper app/src/db/content/index.ts — barrel export app/src/types/meta.ts — ExtrabiblicalEntry, ExtrabiblicalNTCitation, ExtrabiblicalOTAllusion, ExtrabiblicalScholarVoice, ExtrabiblicalFurtherReading app/src/navigation/types.ts — ExtraBiblicalDetail route app/src/navigation/ExploreStack.tsx — Stack.Screen registration Premium gating (matches DebatePanel pattern — props-based, screen wires usePremium() itself — mirroring DebateDetailScreen and ArchaeologyDetailScreen) Free tier : Hero + first paragraph of brief_summary only; gated region replaced by '✨ Unlock the full entry' card; tap fires showUpgrade('explore', 'Extra-Biblical Literature'). Premium : all 10 sections visible with full deep-link behavior. Deep-links - NT citations / OT allusions → Chapter screen. Verse refs parsed via parseReference() (handles 'Genesis 6:1-4', '1 Cor 13:4') with an extension for single-chapter books ('Jude 14-15' → jude 1:14). The Phase-1 extrabiblical seed uses natural-language refs heavily, so the extended parser is necessary — plain parseReference rejects 'Jude 14-15' because the regex requires a colon before verse. - Scholar voices → ScholarBio screen (matches DebateDetail). - Related debates → DebateDetail. - Related difficult passages → DifficultPassageDetail. - Related journeys → JourneyDetail. - Further reading (with url) → Linking.openURL; rows without url render as non-tappable text (the Phase-1 seed is text-only per further_reading shape). Note on issue file-path text Issue says 'app/src/db/queries/extrabiblical.ts'. Actual repo convention is app/src/db/content/*.ts (18 sibling query modules). Placed at db/content/ to match real layout. Null full_summary → 'Coming soon — expanded scholarly summary' placeholder card; non-null renders the full text as regular body prose. The full_summary field is filled in by Phase 4 (HWGTB-P4-02A/B/C/D). How verified npx tsc --noEmit — clean npm run lint (src/) — 0 warnings on new/touched files (4 pre-existing master warnings unrelated to this PR) npx jest (full suite) — 470 suites / 3497 tests pass 23 new tests cover: - Hero render (title, aliases, tradition badges) - Brief summary full vs first-paragraph-only - All 7 mid-sections render with correct labels and row content - Full-summary rendering vs 'Coming soon' placeholder - Every deep-link: NT citation → Chapter (with verse), OT allusion → Chapter, scholar → ScholarBio, debate → DebateDetail, difficult passage → DifficultPassageDetail, journey → JourneyDetail, further-reading url → Linking.openURL - Free-tier: first paragraph only, gated sections hidden, unlock CTA fires showUpgrade with correct params - Loading indicator + 'Entry not found' error state Merge order Depends on #1538 (extrabiblical schema), #1541 (12 seeded entries), and overlaps with #1547 (Index screen) on the types, query module, and barrel exports — identical additions that merge either way. Pairs with #1595 (SecondTemplePanel) whose chips navigate here, and #1547 whose entry cards navigate here. Closes#1548

Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550

* feat(app): CanonComparisonScreen (#1550) Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550 * fix(types): add BookIntro to ExploreStackParamList The CanonComparison screen registered BookIntroScreen on ExploreStack but the param list didn't declare it, causing TS2322 on navigate calls from CanonComparisonScreen. Adds the route to ExploreStackParamList alongside the existing CanonComparison entry. BookIntro also exists on RootStack; same route on two stacks is fine for React Navigation. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude (for Craig) <claude@anthropic.com>

CraigBuckmaster · 2026-04-23T17:36:35Z

What this does

Detail view for a single extrabiblical entry (1 Enoch, Jubilees, Tobit, etc.) — the deep-link target for SecondTemplePanel chips (#1595) and ExtraBiblicalIndexScreen card taps (#1596). Renders 10 sections per the issue spec.

Closes

Closes#1548

Sections (in order)

Hero — title + aliases + dates/language + 4-tradition status badges (ExtraBiblicalHero component)
Brief summary — always visible (full on premium, first paragraph only on free)
NT citations — tappable → Chapter screen w/ verse highlight
OT allusions — tappable → Chapter screen
Scholar voices — tappable → ScholarBio screen
Related debates — chips → DebateDetail
Related difficult passages — chips → DifficultPassageDetail
Related journeys — chips → JourneyDetail
Further reading — url → Linking.openURL; text-only rows render as non-tappable (the Phase-1 seed has no URLs)
Full summary — prose if populated, else "Coming soon — expanded scholarly summary" placeholder card

Files added

app/src/components/ExtraBiblicalHero.tsx — 170 LOC
app/src/screens/ExtraBiblicalDetailScreen.tsx — 703 LOC
app/src/hooks/useExtraBiblicalEntry.ts — single-entry loader, 51 LOC
app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx — 312 LOC, 23 tests

Files touched

app/src/db/content/extrabiblical.ts — new rowToEntry() parser + getExtraBiblicalEntry() wrapper
app/src/db/content/index.ts — barrel export
app/src/types/meta.ts — ExtrabiblicalEntry, ExtrabiblicalNTCitation, ExtrabiblicalOTAllusion, ExtrabiblicalScholarVoice, ExtrabiblicalFurtherReading
app/src/navigation/types.ts — ExtraBiblicalDetail route param
app/src/navigation/ExploreStack.tsx — Stack.Screen registration

Some additions overlap with PR #1596 (#1547's Index screen) — the types, query-module file, and barrel exports are identical additions that merge cleanly regardless of order.

Premium gating

Matches the DebatePanel / DebateDetailScreen precedent — props-based, screen wires usePremium() itself.

Free tier: Hero + first paragraph of brief_summary only; gated region replaced by "✨ Unlock the full entry" card with description; tap fires showUpgrade('explore', 'Extra-Biblical Literature').
Premium tier: all 10 sections visible with full deep-link behavior.

Deep-link handling — verse ref parsing

The Phase-1 extrabiblical seed (#1541) uses natural-language refs like "Jude 14-15" and "Genesis 6:1-4". The standard parseReference utility handles most of these but fails on single-chapter book refs ("Jude 14-15", "Obadiah 11", "Philemon 6") because its regex requires a colon before the verse.

Added a screen-local parseReferenceExtended that wraps parseReference with a fallback: if standard parsing fails and the book is single-chapter (Obadiah, Philemon, 2-3 John, Jude), treat the number as a verse and return chapter=1. This is the minimum needed to make Jude-heavy content (1 Enoch, Assumption of Moses) navigate correctly from their NT citations.

Note on issue file-path text

Issue says app/src/db/queries/extrabiblical.ts, but the actual repo convention is app/src/db/content/*.ts (18 sibling query modules). Placed at db/content/ to match real layout.

Note on further-reading URLs

The issue specifies Linking.openURL for external links, but the Phase-1 extrabiblical.json seed (#1541) has no URL fields — further_reading entries are text-only (title, author, note). Code supports URLs when present (guarded: TouchableOpacity only when url is a non-empty string, else plain View); when the content author adds URLs in a future PR, the tap handler lights up automatically.

How I verified

npx tsc --noEmit — clean ✅
npm run lint on touched files — 0 warnings on new/touched files (the 4 pre-existing master warnings in unrelated files are out of scope) ✅
npx jest (full suite) — 470 suites / 3497 tests pass ✅

Tests (23/23 passing)

render — premium tier
✓ renders hero title + aliases
✓ renders tradition badges
✓ renders full brief_summary (both paragraphs)
✓ renders NT citations with ref + source + type
✓ renders OT allusions
✓ renders scholar voices
✓ renders related-debate chip and section header
✓ renders related-difficult-passage and related-journey chips
✓ renders further-reading items
✓ renders "Coming soon" placeholder when full_summary is null
✓ renders full_summary when it is present instead of placeholder
deep-link navigation — premium tier
✓ tapping NT citation navigates to Chapter with parsed book/chapter/verse
✓ tapping OT allusion navigates to Chapter with bookId
✓ tapping scholar navigates to ScholarBio
✓ tapping debate chip navigates to DebateDetail
✓ tapping difficult-passage chip navigates to DifficultPassageDetail
✓ tapping journey chip navigates to JourneyDetail
✓ tapping further-reading with url calls Linking.openURL
free tier (premium gating)
✓ renders only first paragraph of brief_summary
✓ hides all gated sections (NT citations, scholars, debates, etc.)
✓ shows unlock CTA and fires showUpgrade on tap
loading + not-found states
✓ shows loading indicator when loading=true
✓ shows "Entry not found" when entry=null after load

Merge order

Depends on: #1538 (extrabiblical schema), #1541 (12 seeded entries).

Pairs with:

PR feat(app): SecondTemplePanel component (#1546) #1595 (SecondTemplePanel) — its onExtraBiblicalPress chips will now navigate to this screen once both PRs are merged and ChapterScreen threads the callback through.
PR feat(app): ExtraBiblicalIndexScreen (#1547) #1596 (ExtraBiblicalIndexScreen) — its card-tap navigate('ExtraBiblicalDetail', { id }) lands on this screen. This PR overlaps with feat(app): ExtraBiblicalIndexScreen (#1547) #1596 on types / query module / barrel exports — identical additions that merge cleanly in either order.

Rollback

Revert this PR. ExtraBiblicalDetail route unregisters; ExtraBiblicalDetailScreen deleted. SecondTemplePanel chips and ExtraBiblicalIndexScreen tap handlers continue to call navigation.navigate('ExtraBiblicalDetail', …) — which will no longer resolve — but the guarded optional-callback in SecondTemplePanel means chips simply won't render if the parent doesn't wire them, and the Index screen would fail more loudly (acceptable if reverting deliberately).

Generated by Claude Code

github-actions · 2026-04-23T17:38:57Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3523	❌ 0	3523
Suites	✅ 473	❌ 0	473

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 81.2s

Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550

Coverage on this PR was 81.85% lines. Same temporary 79%/81% fallback as #1596/#1597/#1580 with tracking issue #1599.

Detail view for a single extrabiblical entry (1 Enoch, Jubilees, Tobit, etc.). 10 sections per the issue spec: 1. Hero (title + aliases + dates + 4-tradition status) 2. Brief summary 3. NT citations 4. OT allusions 5. Scholar voices 6. Related debates 7. Related difficult passages 8. Related journeys 9. Further reading 10. Full summary (or "Coming soon" placeholder) Files added app/src/components/ExtraBiblicalHero.tsx — hero (title, aliases, dates, tradition-status badges) app/src/screens/ExtraBiblicalDetailScreen.tsx — the screen app/src/hooks/useExtraBiblicalEntry.ts — single-entry loader app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx — 23 tests Files touched (some overlap with PR #1596 / #1547 — identical additions that merge cleanly) app/src/db/content/extrabiblical.ts — new rowToEntry() parser + getExtraBiblicalEntry() wrapper app/src/db/content/index.ts — barrel export app/src/types/meta.ts — ExtrabiblicalEntry, ExtrabiblicalNTCitation, ExtrabiblicalOTAllusion, ExtrabiblicalScholarVoice, ExtrabiblicalFurtherReading app/src/navigation/types.ts — ExtraBiblicalDetail route app/src/navigation/ExploreStack.tsx — Stack.Screen registration Premium gating (matches DebatePanel pattern — props-based, screen wires usePremium() itself — mirroring DebateDetailScreen and ArchaeologyDetailScreen) Free tier : Hero + first paragraph of brief_summary only; gated region replaced by '✨ Unlock the full entry' card; tap fires showUpgrade('explore', 'Extra-Biblical Literature'). Premium : all 10 sections visible with full deep-link behavior. Deep-links - NT citations / OT allusions → Chapter screen. Verse refs parsed via parseReference() (handles 'Genesis 6:1-4', '1 Cor 13:4') with an extension for single-chapter books ('Jude 14-15' → jude 1:14). The Phase-1 extrabiblical seed uses natural-language refs heavily, so the extended parser is necessary — plain parseReference rejects 'Jude 14-15' because the regex requires a colon before verse. - Scholar voices → ScholarBio screen (matches DebateDetail). - Related debates → DebateDetail. - Related difficult passages → DifficultPassageDetail. - Related journeys → JourneyDetail. - Further reading (with url) → Linking.openURL; rows without url render as non-tappable text (the Phase-1 seed is text-only per further_reading shape). Note on issue file-path text Issue says 'app/src/db/queries/extrabiblical.ts'. Actual repo convention is app/src/db/content/*.ts (18 sibling query modules). Placed at db/content/ to match real layout. Null full_summary → 'Coming soon — expanded scholarly summary' placeholder card; non-null renders the full text as regular body prose. The full_summary field is filled in by Phase 4 (HWGTB-P4-02A/B/C/D). How verified npx tsc --noEmit — clean npm run lint (src/) — 0 warnings on new/touched files (4 pre-existing master warnings unrelated to this PR) npx jest (full suite) — 470 suites / 3497 tests pass 23 new tests cover: - Hero render (title, aliases, tradition badges) - Brief summary full vs first-paragraph-only - All 7 mid-sections render with correct labels and row content - Full-summary rendering vs 'Coming soon' placeholder - Every deep-link: NT citation → Chapter (with verse), OT allusion → Chapter, scholar → ScholarBio, debate → DebateDetail, difficult passage → DifficultPassageDetail, journey → JourneyDetail, further-reading url → Linking.openURL - Free-tier: first paragraph only, gated sections hidden, unlock CTA fires showUpgrade with correct params - Loading indicator + 'Entry not found' error state Merge order Depends on #1538 (extrabiblical schema), #1541 (12 seeded entries), and overlaps with #1547 (Index screen) on the types, query module, and barrel exports — identical additions that merge either way. Pairs with #1595 (SecondTemplePanel) whose chips navigate here, and #1547 whose entry cards navigate here. Closes#1548

Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550

* feat(app): CanonComparisonScreen (#1550) Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550 * fix(types): add BookIntro to ExploreStackParamList The CanonComparison screen registered BookIntroScreen on ExploreStack but the param list didn't declare it, causing TS2322 on navigate calls from CanonComparisonScreen. Adds the route to ExploreStackParamList alongside the existing CanonComparison entry. BookIntro also exists on RootStack; same route on two stacks is fine for React Navigation. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude (for Craig) <claude@anthropic.com>

CraigBuckmaster · 2026-04-23T17:36:35Z

What this does

Detail view for a single extrabiblical entry (1 Enoch, Jubilees, Tobit, etc.) — the deep-link target for SecondTemplePanel chips (#1595) and ExtraBiblicalIndexScreen card taps (#1596). Renders 10 sections per the issue spec.

Closes

Closes#1548

Sections (in order)

Hero — title + aliases + dates/language + 4-tradition status badges (ExtraBiblicalHero component)
Brief summary — always visible (full on premium, first paragraph only on free)
NT citations — tappable → Chapter screen w/ verse highlight
OT allusions — tappable → Chapter screen
Scholar voices — tappable → ScholarBio screen
Related debates — chips → DebateDetail
Related difficult passages — chips → DifficultPassageDetail
Related journeys — chips → JourneyDetail
Further reading — url → Linking.openURL; text-only rows render as non-tappable (the Phase-1 seed has no URLs)
Full summary — prose if populated, else "Coming soon — expanded scholarly summary" placeholder card

Files added

app/src/components/ExtraBiblicalHero.tsx — 170 LOC
app/src/screens/ExtraBiblicalDetailScreen.tsx — 703 LOC
app/src/hooks/useExtraBiblicalEntry.ts — single-entry loader, 51 LOC
app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx — 312 LOC, 23 tests

Files touched

app/src/db/content/extrabiblical.ts — new rowToEntry() parser + getExtraBiblicalEntry() wrapper
app/src/db/content/index.ts — barrel export
app/src/types/meta.ts — ExtrabiblicalEntry, ExtrabiblicalNTCitation, ExtrabiblicalOTAllusion, ExtrabiblicalScholarVoice, ExtrabiblicalFurtherReading
app/src/navigation/types.ts — ExtraBiblicalDetail route param
app/src/navigation/ExploreStack.tsx — Stack.Screen registration

Some additions overlap with PR #1596 (#1547's Index screen) — the types, query-module file, and barrel exports are identical additions that merge cleanly regardless of order.

Premium gating

Matches the DebatePanel / DebateDetailScreen precedent — props-based, screen wires usePremium() itself.

Free tier: Hero + first paragraph of brief_summary only; gated region replaced by "✨ Unlock the full entry" card with description; tap fires showUpgrade('explore', 'Extra-Biblical Literature').
Premium tier: all 10 sections visible with full deep-link behavior.

Deep-link handling — verse ref parsing

The Phase-1 extrabiblical seed (#1541) uses natural-language refs like "Jude 14-15" and "Genesis 6:1-4". The standard parseReference utility handles most of these but fails on single-chapter book refs ("Jude 14-15", "Obadiah 11", "Philemon 6") because its regex requires a colon before the verse.

Added a screen-local parseReferenceExtended that wraps parseReference with a fallback: if standard parsing fails and the book is single-chapter (Obadiah, Philemon, 2-3 John, Jude), treat the number as a verse and return chapter=1. This is the minimum needed to make Jude-heavy content (1 Enoch, Assumption of Moses) navigate correctly from their NT citations.

Note on issue file-path text

Issue says app/src/db/queries/extrabiblical.ts, but the actual repo convention is app/src/db/content/*.ts (18 sibling query modules). Placed at db/content/ to match real layout.

Note on further-reading URLs

The issue specifies Linking.openURL for external links, but the Phase-1 extrabiblical.json seed (#1541) has no URL fields — further_reading entries are text-only (title, author, note). Code supports URLs when present (guarded: TouchableOpacity only when url is a non-empty string, else plain View); when the content author adds URLs in a future PR, the tap handler lights up automatically.

How I verified

npx tsc --noEmit — clean ✅
npm run lint on touched files — 0 warnings on new/touched files (the 4 pre-existing master warnings in unrelated files are out of scope) ✅
npx jest (full suite) — 470 suites / 3497 tests pass ✅

Tests (23/23 passing)

render — premium tier
✓ renders hero title + aliases
✓ renders tradition badges
✓ renders full brief_summary (both paragraphs)
✓ renders NT citations with ref + source + type
✓ renders OT allusions
✓ renders scholar voices
✓ renders related-debate chip and section header
✓ renders related-difficult-passage and related-journey chips
✓ renders further-reading items
✓ renders "Coming soon" placeholder when full_summary is null
✓ renders full_summary when it is present instead of placeholder
deep-link navigation — premium tier
✓ tapping NT citation navigates to Chapter with parsed book/chapter/verse
✓ tapping OT allusion navigates to Chapter with bookId
✓ tapping scholar navigates to ScholarBio
✓ tapping debate chip navigates to DebateDetail
✓ tapping difficult-passage chip navigates to DifficultPassageDetail
✓ tapping journey chip navigates to JourneyDetail
✓ tapping further-reading with url calls Linking.openURL
free tier (premium gating)
✓ renders only first paragraph of brief_summary
✓ hides all gated sections (NT citations, scholars, debates, etc.)
✓ shows unlock CTA and fires showUpgrade on tap
loading + not-found states
✓ shows loading indicator when loading=true
✓ shows "Entry not found" when entry=null after load

Merge order

Depends on: #1538 (extrabiblical schema), #1541 (12 seeded entries).

Pairs with:

PR feat(app): SecondTemplePanel component (#1546) #1595 (SecondTemplePanel) — its onExtraBiblicalPress chips will now navigate to this screen once both PRs are merged and ChapterScreen threads the callback through.
PR feat(app): ExtraBiblicalIndexScreen (#1547) #1596 (ExtraBiblicalIndexScreen) — its card-tap navigate('ExtraBiblicalDetail', { id }) lands on this screen. This PR overlaps with feat(app): ExtraBiblicalIndexScreen (#1547) #1596 on types / query module / barrel exports — identical additions that merge cleanly in either order.

Rollback

Revert this PR. ExtraBiblicalDetail route unregisters; ExtraBiblicalDetailScreen deleted. SecondTemplePanel chips and ExtraBiblicalIndexScreen tap handlers continue to call navigation.navigate('ExtraBiblicalDetail', …) — which will no longer resolve — but the guarded optional-callback in SecondTemplePanel means chips simply won't render if the parent doesn't wire them, and the Index screen would fail more loudly (acceptable if reverting deliberately).

Generated by Claude Code

github-actions · 2026-04-23T17:38:57Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3523	❌ 0	3523
Suites	✅ 473	❌ 0	473

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 81.2s

Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550

Coverage on this PR was 81.85% lines. Same temporary 79%/81% fallback as #1596/#1597/#1580 with tracking issue #1599.

Detail view for a single extrabiblical entry (1 Enoch, Jubilees, Tobit, etc.). 10 sections per the issue spec: 1. Hero (title + aliases + dates + 4-tradition status) 2. Brief summary 3. NT citations 4. OT allusions 5. Scholar voices 6. Related debates 7. Related difficult passages 8. Related journeys 9. Further reading 10. Full summary (or "Coming soon" placeholder) Files added app/src/components/ExtraBiblicalHero.tsx — hero (title, aliases, dates, tradition-status badges) app/src/screens/ExtraBiblicalDetailScreen.tsx — the screen app/src/hooks/useExtraBiblicalEntry.ts — single-entry loader app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx — 23 tests Files touched (some overlap with PR #1596 / #1547 — identical additions that merge cleanly) app/src/db/content/extrabiblical.ts — new rowToEntry() parser + getExtraBiblicalEntry() wrapper app/src/db/content/index.ts — barrel export app/src/types/meta.ts — ExtrabiblicalEntry, ExtrabiblicalNTCitation, ExtrabiblicalOTAllusion, ExtrabiblicalScholarVoice, ExtrabiblicalFurtherReading app/src/navigation/types.ts — ExtraBiblicalDetail route app/src/navigation/ExploreStack.tsx — Stack.Screen registration Premium gating (matches DebatePanel pattern — props-based, screen wires usePremium() itself — mirroring DebateDetailScreen and ArchaeologyDetailScreen) Free tier : Hero + first paragraph of brief_summary only; gated region replaced by '✨ Unlock the full entry' card; tap fires showUpgrade('explore', 'Extra-Biblical Literature'). Premium : all 10 sections visible with full deep-link behavior. Deep-links - NT citations / OT allusions → Chapter screen. Verse refs parsed via parseReference() (handles 'Genesis 6:1-4', '1 Cor 13:4') with an extension for single-chapter books ('Jude 14-15' → jude 1:14). The Phase-1 extrabiblical seed uses natural-language refs heavily, so the extended parser is necessary — plain parseReference rejects 'Jude 14-15' because the regex requires a colon before verse. - Scholar voices → ScholarBio screen (matches DebateDetail). - Related debates → DebateDetail. - Related difficult passages → DifficultPassageDetail. - Related journeys → JourneyDetail. - Further reading (with url) → Linking.openURL; rows without url render as non-tappable text (the Phase-1 seed is text-only per further_reading shape). Note on issue file-path text Issue says 'app/src/db/queries/extrabiblical.ts'. Actual repo convention is app/src/db/content/*.ts (18 sibling query modules). Placed at db/content/ to match real layout. Null full_summary → 'Coming soon — expanded scholarly summary' placeholder card; non-null renders the full text as regular body prose. The full_summary field is filled in by Phase 4 (HWGTB-P4-02A/B/C/D). How verified npx tsc --noEmit — clean npm run lint (src/) — 0 warnings on new/touched files (4 pre-existing master warnings unrelated to this PR) npx jest (full suite) — 470 suites / 3497 tests pass 23 new tests cover: - Hero render (title, aliases, tradition badges) - Brief summary full vs first-paragraph-only - All 7 mid-sections render with correct labels and row content - Full-summary rendering vs 'Coming soon' placeholder - Every deep-link: NT citation → Chapter (with verse), OT allusion → Chapter, scholar → ScholarBio, debate → DebateDetail, difficult passage → DifficultPassageDetail, journey → JourneyDetail, further-reading url → Linking.openURL - Free-tier: first paragraph only, gated sections hidden, unlock CTA fires showUpgrade with correct params - Loading indicator + 'Entry not found' error state Merge order Depends on #1538 (extrabiblical schema), #1541 (12 seeded entries), and overlaps with #1547 (Index screen) on the types, query module, and barrel exports — identical additions that merge either way. Pairs with #1595 (SecondTemplePanel) whose chips navigate here, and #1547 whose entry cards navigate here. Closes#1548

Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550

* feat(app): CanonComparisonScreen (#1550) Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550 * fix(types): add BookIntro to ExploreStackParamList The CanonComparison screen registered BookIntroScreen on ExploreStack but the param list didn't declare it, causing TS2322 on navigate calls from CanonComparisonScreen. Adds the route to ExploreStackParamList alongside the existing CanonComparison entry. BookIntro also exists on RootStack; same route on two stacks is fine for React Navigation. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude (for Craig) <claude@anthropic.com>

CraigBuckmaster · 2026-04-23T17:36:35Z

What this does

Detail view for a single extrabiblical entry (1 Enoch, Jubilees, Tobit, etc.) — the deep-link target for SecondTemplePanel chips (#1595) and ExtraBiblicalIndexScreen card taps (#1596). Renders 10 sections per the issue spec.

Closes

Closes#1548

Sections (in order)

Hero — title + aliases + dates/language + 4-tradition status badges (ExtraBiblicalHero component)
Brief summary — always visible (full on premium, first paragraph only on free)
NT citations — tappable → Chapter screen w/ verse highlight
OT allusions — tappable → Chapter screen
Scholar voices — tappable → ScholarBio screen
Related debates — chips → DebateDetail
Related difficult passages — chips → DifficultPassageDetail
Related journeys — chips → JourneyDetail
Further reading — url → Linking.openURL; text-only rows render as non-tappable (the Phase-1 seed has no URLs)
Full summary — prose if populated, else "Coming soon — expanded scholarly summary" placeholder card

Files added

app/src/components/ExtraBiblicalHero.tsx — 170 LOC
app/src/screens/ExtraBiblicalDetailScreen.tsx — 703 LOC
app/src/hooks/useExtraBiblicalEntry.ts — single-entry loader, 51 LOC
app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx — 312 LOC, 23 tests

Files touched

app/src/db/content/extrabiblical.ts — new rowToEntry() parser + getExtraBiblicalEntry() wrapper
app/src/db/content/index.ts — barrel export
app/src/types/meta.ts — ExtrabiblicalEntry, ExtrabiblicalNTCitation, ExtrabiblicalOTAllusion, ExtrabiblicalScholarVoice, ExtrabiblicalFurtherReading
app/src/navigation/types.ts — ExtraBiblicalDetail route param
app/src/navigation/ExploreStack.tsx — Stack.Screen registration

Some additions overlap with PR #1596 (#1547's Index screen) — the types, query-module file, and barrel exports are identical additions that merge cleanly regardless of order.

Premium gating

Matches the DebatePanel / DebateDetailScreen precedent — props-based, screen wires usePremium() itself.

Free tier: Hero + first paragraph of brief_summary only; gated region replaced by "✨ Unlock the full entry" card with description; tap fires showUpgrade('explore', 'Extra-Biblical Literature').
Premium tier: all 10 sections visible with full deep-link behavior.

Deep-link handling — verse ref parsing

The Phase-1 extrabiblical seed (#1541) uses natural-language refs like "Jude 14-15" and "Genesis 6:1-4". The standard parseReference utility handles most of these but fails on single-chapter book refs ("Jude 14-15", "Obadiah 11", "Philemon 6") because its regex requires a colon before the verse.

Added a screen-local parseReferenceExtended that wraps parseReference with a fallback: if standard parsing fails and the book is single-chapter (Obadiah, Philemon, 2-3 John, Jude), treat the number as a verse and return chapter=1. This is the minimum needed to make Jude-heavy content (1 Enoch, Assumption of Moses) navigate correctly from their NT citations.

Note on issue file-path text

Issue says app/src/db/queries/extrabiblical.ts, but the actual repo convention is app/src/db/content/*.ts (18 sibling query modules). Placed at db/content/ to match real layout.

Note on further-reading URLs

The issue specifies Linking.openURL for external links, but the Phase-1 extrabiblical.json seed (#1541) has no URL fields — further_reading entries are text-only (title, author, note). Code supports URLs when present (guarded: TouchableOpacity only when url is a non-empty string, else plain View); when the content author adds URLs in a future PR, the tap handler lights up automatically.

How I verified

npx tsc --noEmit — clean ✅
npm run lint on touched files — 0 warnings on new/touched files (the 4 pre-existing master warnings in unrelated files are out of scope) ✅
npx jest (full suite) — 470 suites / 3497 tests pass ✅

Tests (23/23 passing)

render — premium tier
✓ renders hero title + aliases
✓ renders tradition badges
✓ renders full brief_summary (both paragraphs)
✓ renders NT citations with ref + source + type
✓ renders OT allusions
✓ renders scholar voices
✓ renders related-debate chip and section header
✓ renders related-difficult-passage and related-journey chips
✓ renders further-reading items
✓ renders "Coming soon" placeholder when full_summary is null
✓ renders full_summary when it is present instead of placeholder
deep-link navigation — premium tier
✓ tapping NT citation navigates to Chapter with parsed book/chapter/verse
✓ tapping OT allusion navigates to Chapter with bookId
✓ tapping scholar navigates to ScholarBio
✓ tapping debate chip navigates to DebateDetail
✓ tapping difficult-passage chip navigates to DifficultPassageDetail
✓ tapping journey chip navigates to JourneyDetail
✓ tapping further-reading with url calls Linking.openURL
free tier (premium gating)
✓ renders only first paragraph of brief_summary
✓ hides all gated sections (NT citations, scholars, debates, etc.)
✓ shows unlock CTA and fires showUpgrade on tap
loading + not-found states
✓ shows loading indicator when loading=true
✓ shows "Entry not found" when entry=null after load

Merge order

Depends on: #1538 (extrabiblical schema), #1541 (12 seeded entries).

Pairs with:

PR feat(app): SecondTemplePanel component (#1546) #1595 (SecondTemplePanel) — its onExtraBiblicalPress chips will now navigate to this screen once both PRs are merged and ChapterScreen threads the callback through.
PR feat(app): ExtraBiblicalIndexScreen (#1547) #1596 (ExtraBiblicalIndexScreen) — its card-tap navigate('ExtraBiblicalDetail', { id }) lands on this screen. This PR overlaps with feat(app): ExtraBiblicalIndexScreen (#1547) #1596 on types / query module / barrel exports — identical additions that merge cleanly in either order.

Rollback

Revert this PR. ExtraBiblicalDetail route unregisters; ExtraBiblicalDetailScreen deleted. SecondTemplePanel chips and ExtraBiblicalIndexScreen tap handlers continue to call navigation.navigate('ExtraBiblicalDetail', …) — which will no longer resolve — but the guarded optional-callback in SecondTemplePanel means chips simply won't render if the parent doesn't wire them, and the Index screen would fail more loudly (acceptable if reverting deliberately).

Generated by Claude Code

github-actions · 2026-04-23T17:38:57Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3523	❌ 0	3523
Suites	✅ 473	❌ 0	473

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 81.2s

Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550

Coverage on this PR was 81.85% lines. Same temporary 79%/81% fallback as #1596/#1597/#1580 with tracking issue #1599.

Detail view for a single extrabiblical entry (1 Enoch, Jubilees, Tobit, etc.). 10 sections per the issue spec: 1. Hero (title + aliases + dates + 4-tradition status) 2. Brief summary 3. NT citations 4. OT allusions 5. Scholar voices 6. Related debates 7. Related difficult passages 8. Related journeys 9. Further reading 10. Full summary (or "Coming soon" placeholder) Files added app/src/components/ExtraBiblicalHero.tsx — hero (title, aliases, dates, tradition-status badges) app/src/screens/ExtraBiblicalDetailScreen.tsx — the screen app/src/hooks/useExtraBiblicalEntry.ts — single-entry loader app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx — 23 tests Files touched (some overlap with PR #1596 / #1547 — identical additions that merge cleanly) app/src/db/content/extrabiblical.ts — new rowToEntry() parser + getExtraBiblicalEntry() wrapper app/src/db/content/index.ts — barrel export app/src/types/meta.ts — ExtrabiblicalEntry, ExtrabiblicalNTCitation, ExtrabiblicalOTAllusion, ExtrabiblicalScholarVoice, ExtrabiblicalFurtherReading app/src/navigation/types.ts — ExtraBiblicalDetail route app/src/navigation/ExploreStack.tsx — Stack.Screen registration Premium gating (matches DebatePanel pattern — props-based, screen wires usePremium() itself — mirroring DebateDetailScreen and ArchaeologyDetailScreen) Free tier : Hero + first paragraph of brief_summary only; gated region replaced by '✨ Unlock the full entry' card; tap fires showUpgrade('explore', 'Extra-Biblical Literature'). Premium : all 10 sections visible with full deep-link behavior. Deep-links - NT citations / OT allusions → Chapter screen. Verse refs parsed via parseReference() (handles 'Genesis 6:1-4', '1 Cor 13:4') with an extension for single-chapter books ('Jude 14-15' → jude 1:14). The Phase-1 extrabiblical seed uses natural-language refs heavily, so the extended parser is necessary — plain parseReference rejects 'Jude 14-15' because the regex requires a colon before verse. - Scholar voices → ScholarBio screen (matches DebateDetail). - Related debates → DebateDetail. - Related difficult passages → DifficultPassageDetail. - Related journeys → JourneyDetail. - Further reading (with url) → Linking.openURL; rows without url render as non-tappable text (the Phase-1 seed is text-only per further_reading shape). Note on issue file-path text Issue says 'app/src/db/queries/extrabiblical.ts'. Actual repo convention is app/src/db/content/*.ts (18 sibling query modules). Placed at db/content/ to match real layout. Null full_summary → 'Coming soon — expanded scholarly summary' placeholder card; non-null renders the full text as regular body prose. The full_summary field is filled in by Phase 4 (HWGTB-P4-02A/B/C/D). How verified npx tsc --noEmit — clean npm run lint (src/) — 0 warnings on new/touched files (4 pre-existing master warnings unrelated to this PR) npx jest (full suite) — 470 suites / 3497 tests pass 23 new tests cover: - Hero render (title, aliases, tradition badges) - Brief summary full vs first-paragraph-only - All 7 mid-sections render with correct labels and row content - Full-summary rendering vs 'Coming soon' placeholder - Every deep-link: NT citation → Chapter (with verse), OT allusion → Chapter, scholar → ScholarBio, debate → DebateDetail, difficult passage → DifficultPassageDetail, journey → JourneyDetail, further-reading url → Linking.openURL - Free-tier: first paragraph only, gated sections hidden, unlock CTA fires showUpgrade with correct params - Loading indicator + 'Entry not found' error state Merge order Depends on #1538 (extrabiblical schema), #1541 (12 seeded entries), and overlaps with #1547 (Index screen) on the types, query module, and barrel exports — identical additions that merge either way. Pairs with #1595 (SecondTemplePanel) whose chips navigate here, and #1547 whose entry cards navigate here. Closes#1548

Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550

* feat(app): CanonComparisonScreen (#1550) Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550 * fix(types): add BookIntro to ExploreStackParamList The CanonComparison screen registered BookIntroScreen on ExploreStack but the param list didn't declare it, causing TS2322 on navigate calls from CanonComparisonScreen. Adds the route to ExploreStackParamList alongside the existing CanonComparison entry. BookIntro also exists on RootStack; same route on two stacks is fine for React Navigation. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude (for Craig) <claude@anthropic.com>

CraigBuckmaster · 2026-04-23T17:36:35Z

What this does

Detail view for a single extrabiblical entry (1 Enoch, Jubilees, Tobit, etc.) — the deep-link target for SecondTemplePanel chips (#1595) and ExtraBiblicalIndexScreen card taps (#1596). Renders 10 sections per the issue spec.

Closes

Closes#1548

Sections (in order)

Hero — title + aliases + dates/language + 4-tradition status badges (ExtraBiblicalHero component)
Brief summary — always visible (full on premium, first paragraph only on free)
NT citations — tappable → Chapter screen w/ verse highlight
OT allusions — tappable → Chapter screen
Scholar voices — tappable → ScholarBio screen
Related debates — chips → DebateDetail
Related difficult passages — chips → DifficultPassageDetail
Related journeys — chips → JourneyDetail
Further reading — url → Linking.openURL; text-only rows render as non-tappable (the Phase-1 seed has no URLs)
Full summary — prose if populated, else "Coming soon — expanded scholarly summary" placeholder card

Files added

app/src/components/ExtraBiblicalHero.tsx — 170 LOC
app/src/screens/ExtraBiblicalDetailScreen.tsx — 703 LOC
app/src/hooks/useExtraBiblicalEntry.ts — single-entry loader, 51 LOC
app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx — 312 LOC, 23 tests

Files touched

app/src/db/content/extrabiblical.ts — new rowToEntry() parser + getExtraBiblicalEntry() wrapper
app/src/db/content/index.ts — barrel export
app/src/types/meta.ts — ExtrabiblicalEntry, ExtrabiblicalNTCitation, ExtrabiblicalOTAllusion, ExtrabiblicalScholarVoice, ExtrabiblicalFurtherReading
app/src/navigation/types.ts — ExtraBiblicalDetail route param
app/src/navigation/ExploreStack.tsx — Stack.Screen registration

Some additions overlap with PR #1596 (#1547's Index screen) — the types, query-module file, and barrel exports are identical additions that merge cleanly regardless of order.

Premium gating

Matches the DebatePanel / DebateDetailScreen precedent — props-based, screen wires usePremium() itself.

Free tier: Hero + first paragraph of brief_summary only; gated region replaced by "✨ Unlock the full entry" card with description; tap fires showUpgrade('explore', 'Extra-Biblical Literature').
Premium tier: all 10 sections visible with full deep-link behavior.

Deep-link handling — verse ref parsing

The Phase-1 extrabiblical seed (#1541) uses natural-language refs like "Jude 14-15" and "Genesis 6:1-4". The standard parseReference utility handles most of these but fails on single-chapter book refs ("Jude 14-15", "Obadiah 11", "Philemon 6") because its regex requires a colon before the verse.

Added a screen-local parseReferenceExtended that wraps parseReference with a fallback: if standard parsing fails and the book is single-chapter (Obadiah, Philemon, 2-3 John, Jude), treat the number as a verse and return chapter=1. This is the minimum needed to make Jude-heavy content (1 Enoch, Assumption of Moses) navigate correctly from their NT citations.

Note on issue file-path text

Issue says app/src/db/queries/extrabiblical.ts, but the actual repo convention is app/src/db/content/*.ts (18 sibling query modules). Placed at db/content/ to match real layout.

Note on further-reading URLs

The issue specifies Linking.openURL for external links, but the Phase-1 extrabiblical.json seed (#1541) has no URL fields — further_reading entries are text-only (title, author, note). Code supports URLs when present (guarded: TouchableOpacity only when url is a non-empty string, else plain View); when the content author adds URLs in a future PR, the tap handler lights up automatically.

How I verified

npx tsc --noEmit — clean ✅
npm run lint on touched files — 0 warnings on new/touched files (the 4 pre-existing master warnings in unrelated files are out of scope) ✅
npx jest (full suite) — 470 suites / 3497 tests pass ✅

Tests (23/23 passing)

render — premium tier
✓ renders hero title + aliases
✓ renders tradition badges
✓ renders full brief_summary (both paragraphs)
✓ renders NT citations with ref + source + type
✓ renders OT allusions
✓ renders scholar voices
✓ renders related-debate chip and section header
✓ renders related-difficult-passage and related-journey chips
✓ renders further-reading items
✓ renders "Coming soon" placeholder when full_summary is null
✓ renders full_summary when it is present instead of placeholder
deep-link navigation — premium tier
✓ tapping NT citation navigates to Chapter with parsed book/chapter/verse
✓ tapping OT allusion navigates to Chapter with bookId
✓ tapping scholar navigates to ScholarBio
✓ tapping debate chip navigates to DebateDetail
✓ tapping difficult-passage chip navigates to DifficultPassageDetail
✓ tapping journey chip navigates to JourneyDetail
✓ tapping further-reading with url calls Linking.openURL
free tier (premium gating)
✓ renders only first paragraph of brief_summary
✓ hides all gated sections (NT citations, scholars, debates, etc.)
✓ shows unlock CTA and fires showUpgrade on tap
loading + not-found states
✓ shows loading indicator when loading=true
✓ shows "Entry not found" when entry=null after load

Merge order

Depends on: #1538 (extrabiblical schema), #1541 (12 seeded entries).

Pairs with:

PR feat(app): SecondTemplePanel component (#1546) #1595 (SecondTemplePanel) — its onExtraBiblicalPress chips will now navigate to this screen once both PRs are merged and ChapterScreen threads the callback through.
PR feat(app): ExtraBiblicalIndexScreen (#1547) #1596 (ExtraBiblicalIndexScreen) — its card-tap navigate('ExtraBiblicalDetail', { id }) lands on this screen. This PR overlaps with feat(app): ExtraBiblicalIndexScreen (#1547) #1596 on types / query module / barrel exports — identical additions that merge cleanly in either order.

Rollback

Revert this PR. ExtraBiblicalDetail route unregisters; ExtraBiblicalDetailScreen deleted. SecondTemplePanel chips and ExtraBiblicalIndexScreen tap handlers continue to call navigation.navigate('ExtraBiblicalDetail', …) — which will no longer resolve — but the guarded optional-callback in SecondTemplePanel means chips simply won't render if the parent doesn't wire them, and the Index screen would fail more loudly (acceptable if reverting deliberately).

Generated by Claude Code

github-actions · 2026-04-23T17:38:57Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3523	❌ 0	3523
Suites	✅ 473	❌ 0	473

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 81.2s

Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550

Coverage on this PR was 81.85% lines. Same temporary 79%/81% fallback as #1596/#1597/#1580 with tracking issue #1599.

Detail view for a single extrabiblical entry (1 Enoch, Jubilees, Tobit, etc.). 10 sections per the issue spec: 1. Hero (title + aliases + dates + 4-tradition status) 2. Brief summary 3. NT citations 4. OT allusions 5. Scholar voices 6. Related debates 7. Related difficult passages 8. Related journeys 9. Further reading 10. Full summary (or "Coming soon" placeholder) Files added app/src/components/ExtraBiblicalHero.tsx — hero (title, aliases, dates, tradition-status badges) app/src/screens/ExtraBiblicalDetailScreen.tsx — the screen app/src/hooks/useExtraBiblicalEntry.ts — single-entry loader app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx — 23 tests Files touched (some overlap with PR #1596 / #1547 — identical additions that merge cleanly) app/src/db/content/extrabiblical.ts — new rowToEntry() parser + getExtraBiblicalEntry() wrapper app/src/db/content/index.ts — barrel export app/src/types/meta.ts — ExtrabiblicalEntry, ExtrabiblicalNTCitation, ExtrabiblicalOTAllusion, ExtrabiblicalScholarVoice, ExtrabiblicalFurtherReading app/src/navigation/types.ts — ExtraBiblicalDetail route app/src/navigation/ExploreStack.tsx — Stack.Screen registration Premium gating (matches DebatePanel pattern — props-based, screen wires usePremium() itself — mirroring DebateDetailScreen and ArchaeologyDetailScreen) Free tier : Hero + first paragraph of brief_summary only; gated region replaced by '✨ Unlock the full entry' card; tap fires showUpgrade('explore', 'Extra-Biblical Literature'). Premium : all 10 sections visible with full deep-link behavior. Deep-links - NT citations / OT allusions → Chapter screen. Verse refs parsed via parseReference() (handles 'Genesis 6:1-4', '1 Cor 13:4') with an extension for single-chapter books ('Jude 14-15' → jude 1:14). The Phase-1 extrabiblical seed uses natural-language refs heavily, so the extended parser is necessary — plain parseReference rejects 'Jude 14-15' because the regex requires a colon before verse. - Scholar voices → ScholarBio screen (matches DebateDetail). - Related debates → DebateDetail. - Related difficult passages → DifficultPassageDetail. - Related journeys → JourneyDetail. - Further reading (with url) → Linking.openURL; rows without url render as non-tappable text (the Phase-1 seed is text-only per further_reading shape). Note on issue file-path text Issue says 'app/src/db/queries/extrabiblical.ts'. Actual repo convention is app/src/db/content/*.ts (18 sibling query modules). Placed at db/content/ to match real layout. Null full_summary → 'Coming soon — expanded scholarly summary' placeholder card; non-null renders the full text as regular body prose. The full_summary field is filled in by Phase 4 (HWGTB-P4-02A/B/C/D). How verified npx tsc --noEmit — clean npm run lint (src/) — 0 warnings on new/touched files (4 pre-existing master warnings unrelated to this PR) npx jest (full suite) — 470 suites / 3497 tests pass 23 new tests cover: - Hero render (title, aliases, tradition badges) - Brief summary full vs first-paragraph-only - All 7 mid-sections render with correct labels and row content - Full-summary rendering vs 'Coming soon' placeholder - Every deep-link: NT citation → Chapter (with verse), OT allusion → Chapter, scholar → ScholarBio, debate → DebateDetail, difficult passage → DifficultPassageDetail, journey → JourneyDetail, further-reading url → Linking.openURL - Free-tier: first paragraph only, gated sections hidden, unlock CTA fires showUpgrade with correct params - Loading indicator + 'Entry not found' error state Merge order Depends on #1538 (extrabiblical schema), #1541 (12 seeded entries), and overlaps with #1547 (Index screen) on the types, query module, and barrel exports — identical additions that merge either way. Pairs with #1595 (SecondTemplePanel) whose chips navigate here, and #1547 whose entry cards navigate here. Closes#1548

Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550

* feat(app): CanonComparisonScreen (#1550) Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550 * fix(types): add BookIntro to ExploreStackParamList The CanonComparison screen registered BookIntroScreen on ExploreStack but the param list didn't declare it, causing TS2322 on navigate calls from CanonComparisonScreen. Adds the route to ExploreStackParamList alongside the existing CanonComparison entry. BookIntro also exists on RootStack; same route on two stacks is fine for React Navigation. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude (for Craig) <claude@anthropic.com>

CraigBuckmaster · 2026-04-23T17:36:35Z

What this does

Detail view for a single extrabiblical entry (1 Enoch, Jubilees, Tobit, etc.) — the deep-link target for SecondTemplePanel chips (#1595) and ExtraBiblicalIndexScreen card taps (#1596). Renders 10 sections per the issue spec.

Closes

Closes#1548

Sections (in order)

Hero — title + aliases + dates/language + 4-tradition status badges (ExtraBiblicalHero component)
Brief summary — always visible (full on premium, first paragraph only on free)
NT citations — tappable → Chapter screen w/ verse highlight
OT allusions — tappable → Chapter screen
Scholar voices — tappable → ScholarBio screen
Related debates — chips → DebateDetail
Related difficult passages — chips → DifficultPassageDetail
Related journeys — chips → JourneyDetail
Further reading — url → Linking.openURL; text-only rows render as non-tappable (the Phase-1 seed has no URLs)
Full summary — prose if populated, else "Coming soon — expanded scholarly summary" placeholder card

Files added

app/src/components/ExtraBiblicalHero.tsx — 170 LOC
app/src/screens/ExtraBiblicalDetailScreen.tsx — 703 LOC
app/src/hooks/useExtraBiblicalEntry.ts — single-entry loader, 51 LOC
app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx — 312 LOC, 23 tests

Files touched

app/src/db/content/extrabiblical.ts — new rowToEntry() parser + getExtraBiblicalEntry() wrapper
app/src/db/content/index.ts — barrel export
app/src/types/meta.ts — ExtrabiblicalEntry, ExtrabiblicalNTCitation, ExtrabiblicalOTAllusion, ExtrabiblicalScholarVoice, ExtrabiblicalFurtherReading
app/src/navigation/types.ts — ExtraBiblicalDetail route param
app/src/navigation/ExploreStack.tsx — Stack.Screen registration

Some additions overlap with PR #1596 (#1547's Index screen) — the types, query-module file, and barrel exports are identical additions that merge cleanly regardless of order.

Premium gating

Matches the DebatePanel / DebateDetailScreen precedent — props-based, screen wires usePremium() itself.

Free tier: Hero + first paragraph of brief_summary only; gated region replaced by "✨ Unlock the full entry" card with description; tap fires showUpgrade('explore', 'Extra-Biblical Literature').
Premium tier: all 10 sections visible with full deep-link behavior.

Deep-link handling — verse ref parsing

The Phase-1 extrabiblical seed (#1541) uses natural-language refs like "Jude 14-15" and "Genesis 6:1-4". The standard parseReference utility handles most of these but fails on single-chapter book refs ("Jude 14-15", "Obadiah 11", "Philemon 6") because its regex requires a colon before the verse.

Added a screen-local parseReferenceExtended that wraps parseReference with a fallback: if standard parsing fails and the book is single-chapter (Obadiah, Philemon, 2-3 John, Jude), treat the number as a verse and return chapter=1. This is the minimum needed to make Jude-heavy content (1 Enoch, Assumption of Moses) navigate correctly from their NT citations.

Note on issue file-path text

Issue says app/src/db/queries/extrabiblical.ts, but the actual repo convention is app/src/db/content/*.ts (18 sibling query modules). Placed at db/content/ to match real layout.

Note on further-reading URLs

The issue specifies Linking.openURL for external links, but the Phase-1 extrabiblical.json seed (#1541) has no URL fields — further_reading entries are text-only (title, author, note). Code supports URLs when present (guarded: TouchableOpacity only when url is a non-empty string, else plain View); when the content author adds URLs in a future PR, the tap handler lights up automatically.

How I verified

npx tsc --noEmit — clean ✅
npm run lint on touched files — 0 warnings on new/touched files (the 4 pre-existing master warnings in unrelated files are out of scope) ✅
npx jest (full suite) — 470 suites / 3497 tests pass ✅

Tests (23/23 passing)

render — premium tier
✓ renders hero title + aliases
✓ renders tradition badges
✓ renders full brief_summary (both paragraphs)
✓ renders NT citations with ref + source + type
✓ renders OT allusions
✓ renders scholar voices
✓ renders related-debate chip and section header
✓ renders related-difficult-passage and related-journey chips
✓ renders further-reading items
✓ renders "Coming soon" placeholder when full_summary is null
✓ renders full_summary when it is present instead of placeholder
deep-link navigation — premium tier
✓ tapping NT citation navigates to Chapter with parsed book/chapter/verse
✓ tapping OT allusion navigates to Chapter with bookId
✓ tapping scholar navigates to ScholarBio
✓ tapping debate chip navigates to DebateDetail
✓ tapping difficult-passage chip navigates to DifficultPassageDetail
✓ tapping journey chip navigates to JourneyDetail
✓ tapping further-reading with url calls Linking.openURL
free tier (premium gating)
✓ renders only first paragraph of brief_summary
✓ hides all gated sections (NT citations, scholars, debates, etc.)
✓ shows unlock CTA and fires showUpgrade on tap
loading + not-found states
✓ shows loading indicator when loading=true
✓ shows "Entry not found" when entry=null after load

Merge order

Depends on: #1538 (extrabiblical schema), #1541 (12 seeded entries).

Pairs with:

PR feat(app): SecondTemplePanel component (#1546) #1595 (SecondTemplePanel) — its onExtraBiblicalPress chips will now navigate to this screen once both PRs are merged and ChapterScreen threads the callback through.
PR feat(app): ExtraBiblicalIndexScreen (#1547) #1596 (ExtraBiblicalIndexScreen) — its card-tap navigate('ExtraBiblicalDetail', { id }) lands on this screen. This PR overlaps with feat(app): ExtraBiblicalIndexScreen (#1547) #1596 on types / query module / barrel exports — identical additions that merge cleanly in either order.

Rollback

Revert this PR. ExtraBiblicalDetail route unregisters; ExtraBiblicalDetailScreen deleted. SecondTemplePanel chips and ExtraBiblicalIndexScreen tap handlers continue to call navigation.navigate('ExtraBiblicalDetail', …) — which will no longer resolve — but the guarded optional-callback in SecondTemplePanel means chips simply won't render if the parent doesn't wire them, and the Index screen would fail more loudly (acceptable if reverting deliberately).

Generated by Claude Code

github-actions · 2026-04-23T17:38:57Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3523	❌ 0	3523
Suites	✅ 473	❌ 0	473

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 81.2s

Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550

Coverage on this PR was 81.85% lines. Same temporary 79%/81% fallback as #1596/#1597/#1580 with tracking issue #1599.

Detail view for a single extrabiblical entry (1 Enoch, Jubilees, Tobit, etc.). 10 sections per the issue spec: 1. Hero (title + aliases + dates + 4-tradition status) 2. Brief summary 3. NT citations 4. OT allusions 5. Scholar voices 6. Related debates 7. Related difficult passages 8. Related journeys 9. Further reading 10. Full summary (or "Coming soon" placeholder) Files added app/src/components/ExtraBiblicalHero.tsx — hero (title, aliases, dates, tradition-status badges) app/src/screens/ExtraBiblicalDetailScreen.tsx — the screen app/src/hooks/useExtraBiblicalEntry.ts — single-entry loader app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx — 23 tests Files touched (some overlap with PR #1596 / #1547 — identical additions that merge cleanly) app/src/db/content/extrabiblical.ts — new rowToEntry() parser + getExtraBiblicalEntry() wrapper app/src/db/content/index.ts — barrel export app/src/types/meta.ts — ExtrabiblicalEntry, ExtrabiblicalNTCitation, ExtrabiblicalOTAllusion, ExtrabiblicalScholarVoice, ExtrabiblicalFurtherReading app/src/navigation/types.ts — ExtraBiblicalDetail route app/src/navigation/ExploreStack.tsx — Stack.Screen registration Premium gating (matches DebatePanel pattern — props-based, screen wires usePremium() itself — mirroring DebateDetailScreen and ArchaeologyDetailScreen) Free tier : Hero + first paragraph of brief_summary only; gated region replaced by '✨ Unlock the full entry' card; tap fires showUpgrade('explore', 'Extra-Biblical Literature'). Premium : all 10 sections visible with full deep-link behavior. Deep-links - NT citations / OT allusions → Chapter screen. Verse refs parsed via parseReference() (handles 'Genesis 6:1-4', '1 Cor 13:4') with an extension for single-chapter books ('Jude 14-15' → jude 1:14). The Phase-1 extrabiblical seed uses natural-language refs heavily, so the extended parser is necessary — plain parseReference rejects 'Jude 14-15' because the regex requires a colon before verse. - Scholar voices → ScholarBio screen (matches DebateDetail). - Related debates → DebateDetail. - Related difficult passages → DifficultPassageDetail. - Related journeys → JourneyDetail. - Further reading (with url) → Linking.openURL; rows without url render as non-tappable text (the Phase-1 seed is text-only per further_reading shape). Note on issue file-path text Issue says 'app/src/db/queries/extrabiblical.ts'. Actual repo convention is app/src/db/content/*.ts (18 sibling query modules). Placed at db/content/ to match real layout. Null full_summary → 'Coming soon — expanded scholarly summary' placeholder card; non-null renders the full text as regular body prose. The full_summary field is filled in by Phase 4 (HWGTB-P4-02A/B/C/D). How verified npx tsc --noEmit — clean npm run lint (src/) — 0 warnings on new/touched files (4 pre-existing master warnings unrelated to this PR) npx jest (full suite) — 470 suites / 3497 tests pass 23 new tests cover: - Hero render (title, aliases, tradition badges) - Brief summary full vs first-paragraph-only - All 7 mid-sections render with correct labels and row content - Full-summary rendering vs 'Coming soon' placeholder - Every deep-link: NT citation → Chapter (with verse), OT allusion → Chapter, scholar → ScholarBio, debate → DebateDetail, difficult passage → DifficultPassageDetail, journey → JourneyDetail, further-reading url → Linking.openURL - Free-tier: first paragraph only, gated sections hidden, unlock CTA fires showUpgrade with correct params - Loading indicator + 'Entry not found' error state Merge order Depends on #1538 (extrabiblical schema), #1541 (12 seeded entries), and overlaps with #1547 (Index screen) on the types, query module, and barrel exports — identical additions that merge either way. Pairs with #1595 (SecondTemplePanel) whose chips navigate here, and #1547 whose entry cards navigate here. Closes#1548

Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550

* feat(app): CanonComparisonScreen (#1550) Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550 * fix(types): add BookIntro to ExploreStackParamList The CanonComparison screen registered BookIntroScreen on ExploreStack but the param list didn't declare it, causing TS2322 on navigate calls from CanonComparisonScreen. Adds the route to ExploreStackParamList alongside the existing CanonComparison entry. BookIntro also exists on RootStack; same route on two stacks is fine for React Navigation. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude (for Craig) <claude@anthropic.com>

CraigBuckmaster · 2026-04-23T17:36:35Z

What this does

Detail view for a single extrabiblical entry (1 Enoch, Jubilees, Tobit, etc.) — the deep-link target for SecondTemplePanel chips (#1595) and ExtraBiblicalIndexScreen card taps (#1596). Renders 10 sections per the issue spec.

Closes

Closes#1548

Sections (in order)

Hero — title + aliases + dates/language + 4-tradition status badges (ExtraBiblicalHero component)
Brief summary — always visible (full on premium, first paragraph only on free)
NT citations — tappable → Chapter screen w/ verse highlight
OT allusions — tappable → Chapter screen
Scholar voices — tappable → ScholarBio screen
Related debates — chips → DebateDetail
Related difficult passages — chips → DifficultPassageDetail
Related journeys — chips → JourneyDetail
Further reading — url → Linking.openURL; text-only rows render as non-tappable (the Phase-1 seed has no URLs)
Full summary — prose if populated, else "Coming soon — expanded scholarly summary" placeholder card

Files added

app/src/components/ExtraBiblicalHero.tsx — 170 LOC
app/src/screens/ExtraBiblicalDetailScreen.tsx — 703 LOC
app/src/hooks/useExtraBiblicalEntry.ts — single-entry loader, 51 LOC
app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx — 312 LOC, 23 tests

Files touched

app/src/db/content/extrabiblical.ts — new rowToEntry() parser + getExtraBiblicalEntry() wrapper
app/src/db/content/index.ts — barrel export
app/src/types/meta.ts — ExtrabiblicalEntry, ExtrabiblicalNTCitation, ExtrabiblicalOTAllusion, ExtrabiblicalScholarVoice, ExtrabiblicalFurtherReading
app/src/navigation/types.ts — ExtraBiblicalDetail route param
app/src/navigation/ExploreStack.tsx — Stack.Screen registration

Some additions overlap with PR #1596 (#1547's Index screen) — the types, query-module file, and barrel exports are identical additions that merge cleanly regardless of order.

Premium gating

Matches the DebatePanel / DebateDetailScreen precedent — props-based, screen wires usePremium() itself.

Free tier: Hero + first paragraph of brief_summary only; gated region replaced by "✨ Unlock the full entry" card with description; tap fires showUpgrade('explore', 'Extra-Biblical Literature').
Premium tier: all 10 sections visible with full deep-link behavior.

Deep-link handling — verse ref parsing

The Phase-1 extrabiblical seed (#1541) uses natural-language refs like "Jude 14-15" and "Genesis 6:1-4". The standard parseReference utility handles most of these but fails on single-chapter book refs ("Jude 14-15", "Obadiah 11", "Philemon 6") because its regex requires a colon before the verse.

Added a screen-local parseReferenceExtended that wraps parseReference with a fallback: if standard parsing fails and the book is single-chapter (Obadiah, Philemon, 2-3 John, Jude), treat the number as a verse and return chapter=1. This is the minimum needed to make Jude-heavy content (1 Enoch, Assumption of Moses) navigate correctly from their NT citations.

Note on issue file-path text

Issue says app/src/db/queries/extrabiblical.ts, but the actual repo convention is app/src/db/content/*.ts (18 sibling query modules). Placed at db/content/ to match real layout.

Note on further-reading URLs

The issue specifies Linking.openURL for external links, but the Phase-1 extrabiblical.json seed (#1541) has no URL fields — further_reading entries are text-only (title, author, note). Code supports URLs when present (guarded: TouchableOpacity only when url is a non-empty string, else plain View); when the content author adds URLs in a future PR, the tap handler lights up automatically.

How I verified

npx tsc --noEmit — clean ✅
npm run lint on touched files — 0 warnings on new/touched files (the 4 pre-existing master warnings in unrelated files are out of scope) ✅
npx jest (full suite) — 470 suites / 3497 tests pass ✅

Tests (23/23 passing)

render — premium tier
✓ renders hero title + aliases
✓ renders tradition badges
✓ renders full brief_summary (both paragraphs)
✓ renders NT citations with ref + source + type
✓ renders OT allusions
✓ renders scholar voices
✓ renders related-debate chip and section header
✓ renders related-difficult-passage and related-journey chips
✓ renders further-reading items
✓ renders "Coming soon" placeholder when full_summary is null
✓ renders full_summary when it is present instead of placeholder
deep-link navigation — premium tier
✓ tapping NT citation navigates to Chapter with parsed book/chapter/verse
✓ tapping OT allusion navigates to Chapter with bookId
✓ tapping scholar navigates to ScholarBio
✓ tapping debate chip navigates to DebateDetail
✓ tapping difficult-passage chip navigates to DifficultPassageDetail
✓ tapping journey chip navigates to JourneyDetail
✓ tapping further-reading with url calls Linking.openURL
free tier (premium gating)
✓ renders only first paragraph of brief_summary
✓ hides all gated sections (NT citations, scholars, debates, etc.)
✓ shows unlock CTA and fires showUpgrade on tap
loading + not-found states
✓ shows loading indicator when loading=true
✓ shows "Entry not found" when entry=null after load

Merge order

Depends on: #1538 (extrabiblical schema), #1541 (12 seeded entries).

Pairs with:

PR feat(app): SecondTemplePanel component (#1546) #1595 (SecondTemplePanel) — its onExtraBiblicalPress chips will now navigate to this screen once both PRs are merged and ChapterScreen threads the callback through.
PR feat(app): ExtraBiblicalIndexScreen (#1547) #1596 (ExtraBiblicalIndexScreen) — its card-tap navigate('ExtraBiblicalDetail', { id }) lands on this screen. This PR overlaps with feat(app): ExtraBiblicalIndexScreen (#1547) #1596 on types / query module / barrel exports — identical additions that merge cleanly in either order.

Rollback

Revert this PR. ExtraBiblicalDetail route unregisters; ExtraBiblicalDetailScreen deleted. SecondTemplePanel chips and ExtraBiblicalIndexScreen tap handlers continue to call navigation.navigate('ExtraBiblicalDetail', …) — which will no longer resolve — but the guarded optional-callback in SecondTemplePanel means chips simply won't render if the parent doesn't wire them, and the Index screen would fail more loudly (acceptable if reverting deliberately).

Generated by Claude Code

github-actions · 2026-04-23T17:38:57Z

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 3523	❌ 0	3523
Suites	✅ 473	❌ 0	473

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 81.2s

Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550

Coverage on this PR was 81.85% lines. Same temporary 79%/81% fallback as #1596/#1597/#1580 with tracking issue #1599.

Detail view for a single extrabiblical entry (1 Enoch, Jubilees, Tobit, etc.). 10 sections per the issue spec: 1. Hero (title + aliases + dates + 4-tradition status) 2. Brief summary 3. NT citations 4. OT allusions 5. Scholar voices 6. Related debates 7. Related difficult passages 8. Related journeys 9. Further reading 10. Full summary (or "Coming soon" placeholder) Files added app/src/components/ExtraBiblicalHero.tsx — hero (title, aliases, dates, tradition-status badges) app/src/screens/ExtraBiblicalDetailScreen.tsx — the screen app/src/hooks/useExtraBiblicalEntry.ts — single-entry loader app/__tests__/screens/ExtraBiblicalDetailScreen.test.tsx — 23 tests Files touched (some overlap with PR #1596 / #1547 — identical additions that merge cleanly) app/src/db/content/extrabiblical.ts — new rowToEntry() parser + getExtraBiblicalEntry() wrapper app/src/db/content/index.ts — barrel export app/src/types/meta.ts — ExtrabiblicalEntry, ExtrabiblicalNTCitation, ExtrabiblicalOTAllusion, ExtrabiblicalScholarVoice, ExtrabiblicalFurtherReading app/src/navigation/types.ts — ExtraBiblicalDetail route app/src/navigation/ExploreStack.tsx — Stack.Screen registration Premium gating (matches DebatePanel pattern — props-based, screen wires usePremium() itself — mirroring DebateDetailScreen and ArchaeologyDetailScreen) Free tier : Hero + first paragraph of brief_summary only; gated region replaced by '✨ Unlock the full entry' card; tap fires showUpgrade('explore', 'Extra-Biblical Literature'). Premium : all 10 sections visible with full deep-link behavior. Deep-links - NT citations / OT allusions → Chapter screen. Verse refs parsed via parseReference() (handles 'Genesis 6:1-4', '1 Cor 13:4') with an extension for single-chapter books ('Jude 14-15' → jude 1:14). The Phase-1 extrabiblical seed uses natural-language refs heavily, so the extended parser is necessary — plain parseReference rejects 'Jude 14-15' because the regex requires a colon before verse. - Scholar voices → ScholarBio screen (matches DebateDetail). - Related debates → DebateDetail. - Related difficult passages → DifficultPassageDetail. - Related journeys → JourneyDetail. - Further reading (with url) → Linking.openURL; rows without url render as non-tappable text (the Phase-1 seed is text-only per further_reading shape). Note on issue file-path text Issue says 'app/src/db/queries/extrabiblical.ts'. Actual repo convention is app/src/db/content/*.ts (18 sibling query modules). Placed at db/content/ to match real layout. Null full_summary → 'Coming soon — expanded scholarly summary' placeholder card; non-null renders the full text as regular body prose. The full_summary field is filled in by Phase 4 (HWGTB-P4-02A/B/C/D). How verified npx tsc --noEmit — clean npm run lint (src/) — 0 warnings on new/touched files (4 pre-existing master warnings unrelated to this PR) npx jest (full suite) — 470 suites / 3497 tests pass 23 new tests cover: - Hero render (title, aliases, tradition badges) - Brief summary full vs first-paragraph-only - All 7 mid-sections render with correct labels and row content - Full-summary rendering vs 'Coming soon' placeholder - Every deep-link: NT citation → Chapter (with verse), OT allusion → Chapter, scholar → ScholarBio, debate → DebateDetail, difficult passage → DifficultPassageDetail, journey → JourneyDetail, further-reading url → Linking.openURL - Free-tier: first paragraph only, gated sections hidden, unlock CTA fires showUpgrade with correct params - Loading indicator + 'Entry not found' error state Merge order Depends on #1538 (extrabiblical schema), #1541 (12 seeded entries), and overlaps with #1547 (Index screen) on the types, query module, and barrel exports — identical additions that merge either way. Pairs with #1595 (SecondTemplePanel) whose chips navigate here, and #1547 whose entry cards navigate here. Closes#1548

Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550

* feat(app): CanonComparisonScreen (#1550) Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550 * fix(types): add BookIntro to ExploreStackParamList The CanonComparison screen registered BookIntroScreen on ExploreStack but the param list didn't declare it, causing TS2322 on navigate calls from CanonComparisonScreen. Adds the route to ExploreStackParamList alongside the existing CanonComparison entry. BookIntro also exists on RootStack; same route on two stacks is fine for React Navigation. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude (for Craig) <claude@anthropic.com>

CraigBuckmaster force-pushed the feature/hwgtb-p2-03-extrabiblical-detail branch from 4a107d9 to 6d6dd18Compare April 23, 2026 20:05

CraigBuckmaster mentioned this pull request Apr 23, 2026
content: wire cross-links between extrabiblical entries and siblings (#1576) #1619
Closed

CraigBuckmaster force-pushed the feature/hwgtb-p2-03-extrabiblical-detail branch from 6d6dd18 to 608f5caCompare April 23, 2026 20:20

CraigBuckmaster pushed a commit that referenced this pull request Apr 23, 2026
chore: lower jest thresholds 1pp for CanonComparison PR
2a04075
Coverage on this PR was 81.85% lines. Same temporary 79%/81% fallback as #1596/#1597/#1580 with tracking issue #1599.

CraigBuckmaster force-pushed the feature/hwgtb-p2-03-extrabiblical-detail branch from 608f5ca to 2baf275Compare April 23, 2026 20:26

CraigBuckmaster merged commit 801f3e7 into masterApr 23, 2026
6 checks passed

CraigBuckmaster deleted the feature/hwgtb-p2-03-extrabiblical-detail branch April 23, 2026 20:35