feat(app): Explore hero card + HowWeGotTheBibleLandingScreen (#1549) - #1598
Merged
Conversation
Adds the surface-level entry point for the HWGTB epic — an Explore
hero card and the full-screen landing page it routes to. The landing
page surfaces three bundled features (Extra-Biblical Literature, Canon
Comparison, Guided Journeys) in a single place, matching the
"bundled-feature landing page" precedent used elsewhere.
Files added
app/src/screens/HowWeGotTheBibleLandingScreen.tsx — 315 LOC
app/__tests__/screens/HowWeGotTheBibleLandingScreen.test.tsx — 8 tests
Files touched
app/src/screens/ExploreMenuScreen.tsx — new FeatureCardData entry
in the 'Scholarly Analysis' SECTION; new PREMIUM_SCREENS mapping
('HowWeGotTheBibleLanding' → 'How We Got The Bible')
app/src/navigation/types.ts — HowWeGotTheBibleLanding
route (undefined params) + CanonComparison route typed ahead of
HWGTB-P3-01 (#1550)
app/src/navigation/ExploreStack.tsx — Stack.Screen registration
via lazySuspense()
app/assets/explore-images.json
content/meta/explore-images.json — both updated with the new
'HowWeGotTheBible' manifest key using the tool-level inline-images
variant specified by the issue (count: null, contentType: null,
images[] with url/caption/credit)
Landing screen
- Header row: ChevronLeft back + title 'How We Got The Bible'
- Hero image (expo-image) driven by useExploreImages() → the new
manifest entry — shows the artwork once uploaded to R2, renders
nothing when absent
- Intro copy (2 paragraphs): what the bundle covers, evangelical
framing, fair to other traditions, explicit rejection of
conspiracy framing per the epic guardrails
- Three nav entries with icon + title + description:
1. Extra-Biblical Literature → ExtraBiblicalIndex (HWGTB-P2-02)
2. Canon Comparison → rendered 'Coming soon' (HWGTB-P3-01 not
yet shipped; route typed ahead so flipping to live navigation
is a one-line change when #1550 lands)
3. Guided Journeys → JourneyBrowse with tab: 'featured'
(journey-id filter support is out of scope; canon-formation
and text-and-translation journeys will surface via
FEATURED_IDS once HWGTB-P3-02 / #1551 and HWGTB-P4-01 / #1552
land)
Explore card
- Title: 'How We Got The Bible'
- Subtitle: 'Canon, manuscripts, translations, and the books
Jude quoted'
- color: '#c89858' — matches the st2 panel accent for visual
continuity across the bundle
- screen: 'HowWeGotTheBibleLanding'
- premium: true — enforced via PREMIUM_SCREENS map; existing
handleNavigate flow fires showUpgrade('feature', 'How We Got
The Bible') for free users
Deferred — R2 hero artwork
The issue specifies placing the artwork at
_tools/art_staging/priority/explore_how_we_got_the_bible.png and
running python _tools/upload_images_to_r2.py --priority. R2 write
access is not available from this session — the manifest entry
points at the planned URL (
https://contentcompanionstudy.com/art/explore/how-we-got-the-bible.png
) so uploading the asset to that path in a follow-up is enough to
light up the hero image. Without the upload the landing screen
gracefully renders without the hero (the guarded-render path is
exercised by the loading-flag branch in the hero lookup).
How verified
npx tsc --noEmit — clean
npm run lint (src/) — 0 new warnings on touched files
npx jest (full suite) — 470 suites / 3482 tests pass
8 new tests cover: page title render, intro copy render, 3 landing
entries render, 'Coming soon' pill on Canon Comparison entry, tap →
ExtraBiblicalIndex, tap → JourneyBrowse with featured tab, 'Canon
Comparison' entry has no onPress (so tap is a no-op, not a nav),
back button fires goBack.
Merge order
Depends on #1547 (ExtraBiblicalIndexScreen — PR #1596) for the
primary nav target; the other two entries are safe to merge any
time. Works standalone on master when #1547 hasn't merged: the
Extra-Biblical tap will navigate to a non-registered route until
#1596 lands, at which point it works automatically.
Closes#1549
Content Pipeline Results✅ All pipeline checks passed
Content Pipeline — Quality & Accuracy Report✅ All content checks passed Scope: 0 chapter(s) across 0 book(s) Generated by |
Test Results✅ All tests passed
Coverage
⏱️ Duration: 84.6s |
Uh oh!
There was an error while loading. Please reload this page.
CraigBuckmaster pushed a commit
that referenced
this pull request
Apr 23, 2026
Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550
CraigBuckmaster pushed a commit
that referenced
this pull request
Apr 23, 2026
Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550
6 tasks
CraigBuckmaster pushed a commit
that referenced
this pull request
Apr 23, 2026
Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550
CraigBuckmaster pushed a commit
that referenced
this pull request
Apr 23, 2026
Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550
CraigBuckmaster added a commit
that referenced
this pull request
Apr 23, 2026
* feat(app): CanonComparisonScreen (#1550) Interactive side-by-side of the four major canon traditions. The conversion-driving screen for the "How We Got The Bible" bundle — readers see the Protestant, Catholic, Orthodox, and Ethiopian canons next to each other, with book-diff highlighting, founding-council timelines, and tap-through to per-book detail. Files added app/src/db/content/canonTraditions.ts — data access layer (getAllCanonTraditions, getCanonTraditionById, defensive sqlite_master table-exists guard) app/src/hooks/useCanonTraditions.ts — loader + book-membership computation (common vs subset book ids per tradition) app/src/components/CanonColumn.tsx — one tradition's column (header, scrollable book list with per-book tradition badges, expandable distinctives, locked-preview variant for free tier) app/src/screens/CanonComparisonScreen.tsx — the screen app/__tests__/screens/CanonComparisonScreen.test.tsx — 12 tests Files touched app/src/db/content/index.ts — barrel export app/src/types/meta.ts — CanonTradition, CanonListSection, CanonDistinctive, CanonFormationEvent, CanonTraditionRow app/src/navigation/types.ts — CanonComparison, ExtraBiblicalIndex, ExtraBiblicalDetail, BookIntro typed for ExploreStack (ExtraBiblical routes typed ahead for cross-stack consistency with #1596/#1597; BookIntro added so the canon-column book tap can route without cross-tab hops) app/src/navigation/ExploreStack.tsx — CanonComparison + BookIntro Stack.Screen registrations via lazySuspense() Layout — useWindowDimensions() driven (no third-party orientation library, no Dimensions.addEventListener per the issue guidance) Landscape (width > height): horizontal scroll across 4 columns, each 320px wide with vertical book lists Portrait (width <= height): tabs at top, one column visible at a time, tap-to-switch Column rendering Header : tradition label + book count + first 2 formation events Book list : scrollable; section headers (OT / NT / etc.); books in all 4 traditions render in neutral style; books unique to a subset carry gold-tinted tradition-id badges (Prot / Cath / EO / Eth) showing which traditions contain them Distinctives: expandable block at the bottom (2-4 entries from the authored content) Tap biblical book (present in books table) → BookIntro Tap extrabiblical book (not in books table) → ExtraBiblicalDetail (HWGTB-P2-03 / PR #1597) Header Back button + title "Canon Comparison" + right-aligned "How did this happen?" CTA → JourneyDetail journeyId='canon-formation' (HWGTB-P3-02 / #1551 — when the journey lands this activates) Formation timeline footer Expandable; merges all formation_events from all 4 traditions, sorted by year, annotated with the source tradition's label. Renders "{N} events across the four traditions" header. Premium gating Free tier: Protestant + Catholic columns fully visible. Orthodox + Ethiopian columns render header + first 5 rows with a gold "✨ Unlock full canon" CTA that fires showUpgrade('feature', 'Canon Comparison'). Premium tier: all 4 columns fully readable. Portrait tab labels show a 🔒 indicator for gated tabs. How verified npx tsc --noEmit — clean npx eslint (touched files) — 0 warnings npx jest (full suite) — 470 suites / 3486 tests pass 12 new tests cover: - portrait: 4 tradition tabs render, active column renders, tab tap switches visible column - landscape: all 4 columns render simultaneously (no tabs) - header "How did this happen?" CTA + navigation to canon-formation journey - premium gating: free-tier 🔒 on Orthodox/Ethiopian tabs, unlock CTA fires showUpgrade, premium user sees no locks - formation timeline: footer renders event count, expand shows merged events sorted by year with tradition annotations Merge order Depends on #1539 (canon_traditions schema) and #1542 (the 4 seeded traditions). Works against a pre-#1539 DB: the table-exists guard returns [] and the screen shows 'Canon data not yet available' cleanly. Pairs with #1548 (PR #1597 — ExtraBiblicalDetail) for extrabib taps, and #1551 (canon-formation journey) for the header CTA. Follow-up activation When #1598's HowWeGotTheBibleLandingScreen ships alongside this, flip its canonComparisonReady = true constant so the landing entry activates live nav (currently rendered as 'Coming soon'). Closes#1550 * fix(types): add BookIntro to ExploreStackParamList The CanonComparison screen registered BookIntroScreen on ExploreStack but the param list didn't declare it, causing TS2322 on navigate calls from CanonComparisonScreen. Adds the route to ExploreStackParamList alongside the existing CanonComparison entry. BookIntro also exists on RootStack; same route on two stacks is fine for React Navigation. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude (for Craig) <claude@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Adds the surface-level entry point for the HWGTB epic — an Explore hero card and the full-screen landing page it routes to. The landing page surfaces three bundled features (Extra-Biblical Literature, Canon Comparison, Guided Journeys) in a single place, matching the "bundled-feature landing page" precedent used elsewhere in the app.
Closes
Closes#1549
Files added
app/src/screens/HowWeGotTheBibleLandingScreen.tsx— 315 LOC landing pageapp/__tests__/screens/HowWeGotTheBibleLandingScreen.test.tsx— 8 testsFiles touched
app/src/screens/ExploreMenuScreen.tsx— newFeatureCardDataentry in the 'Scholarly Analysis'SECTION+ newPREMIUM_SCREENSmapping (HowWeGotTheBibleLanding→'How We Got The Bible')app/src/navigation/types.ts—HowWeGotTheBibleLandingroute (undefined params) +CanonComparisonroute typed ahead of HWGTB-P3-01 ([HWGTB-P3-01] App:CanonComparisonScreen#1550)app/src/navigation/ExploreStack.tsx—Stack.Screenregistration vialazySuspense()app/assets/explore-images.json+content/meta/explore-images.json— both updated with the newHowWeGotTheBiblemanifest key using the tool-level inline-images variant specified by the issue (count: null,contentType: null,images[]withurl/caption/credit)Landing screen
ChevronLeftback button + title "How We Got The Bible"expo-image+useExploreImages()→ the new manifest entry. Shows the artwork once uploaded to R2; renders nothing when absent (graceful)ExtraBiblicalIndex(HWGTB-P2-02 → PR feat(app): ExtraBiblicalIndexScreen (#1547) #1596)CanonComparisonScreen#1550 lands —canonComparisonReady = true)JourneyBrowsewithtab: 'featured'Note on Guided Journeys navigation
The issue's suggested param shape was
{ filter: { ids: ['canon-formation', 'text-and-translation'] } }, butJourneyBrowseScreen's currentExploreStackParamListentry only supports{ tab?, filterLens? }. Filter-by-journey-id is not yet supported in the browse screen. Per the issue's fallback guidance ("or whatever filter-param shape JourneyBrowseScreen already accepts"), landing ontab: 'featured'is the closest fit — once HWGTB-P3-02 (#1551) and HWGTB-P4-01 (#1552) author the two journeys, they'll surface viaFEATURED_IDS.Explore card
#c89858— matches thest2panel accent from feat(app): SecondTemplePanel component (#1546) #1595 for visual continuity across the bundleHowWeGotTheBibleLandingtrue— enforced viaPREMIUM_SCREENSmap; existinghandleNavigateflow firesshowUpgrade('feature', 'How We Got The Bible')for free usersPlaced in the "Scholarly Analysis" section alongside Debates, Difficult Passages, and Content Library — conceptually closest neighbors.
Deferred: R2 hero artwork
The issue specifies placing artwork at
_tools/art_staging/priority/explore_how_we_got_the_bible.pngand runningpython _tools/upload_images_to_r2.py --priority. R2 write access is not available from this session — the manifest entry points at the planned URL (https://contentcompanionstudy.com/art/explore/how-we-got-the-bible.png) so uploading the asset to that path in a follow-up is enough to light up the hero image. Without the upload, the landing screen gracefully renders without the hero (the guarded-render path is exercised by the test suite's mocked hook).How I verified
npx tsc --noEmit— clean ✅npm run linton touched files — 0 new warnings (4 pre-existing master warnings in unrelated files are out of scope) ✅npx jest(full suite) — 470 suites / 3482 tests pass ✅Tests (8/8 passing)
Merge order
Depends on: #1547 (PR #1596 —
ExtraBiblicalIndexScreen) for the primary nav target. Works standalone on master when #1596 hasn't merged — the Extra-Biblical tap will navigate to a non-registered route until #1596 lands, at which point it works automatically.Follow-up activation tasks:
CanonComparisonScreen#1550 (CanonComparisonScreen) lands → flipcanonComparisonReady = trueinHowWeGotTheBibleLandingScreen.tsxto activate that entryFEATURED_IDSinJourneyBrowseScreen.tsxso the "Guided Journeys" entry lands users right on themRollback
Revert this PR. Landing screen deleted, Explore card entry removed, manifest entries dropped.
CanonComparison+HowWeGotTheBibleLandingroutes leave the param list. Other routes (ExtraBiblicalIndex,ExtraBiblicalDetail) remain intact (they're owned by #1596 / #1597).Generated by Claude Code