Uh oh!
There was an error while loading. Please reload this page.
added tests and fastapi typed version - #186
Merged
Merged
Conversation
CI does not have a sibling cpa-templates tree; keep the typed-starter assertion for local/dev checkouts only. Co-authored-by: Cursor <cursoragent@cursor.com>
That catalog entry lives in cpa-templates#45 and is not on main yet; keep this PR focused on Windows file:// path resolution + unit tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes local template scaffolding when using Windows-style file URLs such as file:///E:/... for template sources.
What changed
Updated local file URL parsing in the core path resolver
Fixed handling of Windows drive-letter paths so local templates resolve correctly
Added regression tests covering Windows-style file URLs
Why
Previously, Windows-based file URLs were parsed incorrectly, causing local template scaffolding to fail when pointing to a template from a local checkout.
Testing
Added regression tests for Windows file URL handling
Verified the relevant test suite passes
Smoke-tested scaffolding with a local typed FastAPI template
Closes#185