Skip to content

added tests and fastapi typed version#186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ulises-jeremias merged 5 commits into from
Jul 17, 2026
Merged

added tests and fastapi typed version #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f84519d
added tests and fastapi typed version
PUSHPAK-JAISWAL Jul 16, 2026
0bdba70
test: skip local cpa-templates catalog check when checkout missing
ulises-jeremias Jul 17, 2026
ab9e5c4
test: drop local cpa-templates typed-starter assertion
ulises-jeremias Jul 17, 2026
21cd3bf
style: clean unused import and blank lines in catalog tests
ulises-jeremias Jul 17, 2026
2e67a6a
style: ruff format catalog fetch tests
ulises-jeremias Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/create-python-app-core/src/create_python_app_core/paths.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@
from dataclasses import dataclass
from pathlib import Path
from urllib.parse import parse_qs, unquote, urlparse
from urllib.request import url2pathname

from create_python_app_core.errors import CpaError

Expand DownExpand Up@@ -54,10 +55,14 @@ def resolve_source(spec: str, *, cache_dir: Path | None = None) -> ResolvedSourc
if spec.startswith("file://"):
parsed = urlparse(spec)
query = parse_qs(parsed.query)
path = Path(unquote(parsed.path))
raw_path = unquote(parsed.path or "/")
if parsed.netloc and parsed.netloc != "localhost":
# file://host/path — uncommon; treat netloc+path
path = Path(f"/{parsed.netloc}{unquote(parsed.path)}")
raw_path = f"//{parsed.netloc}{raw_path}"
path_text = url2pathname(raw_path)
if os.name == "nt" and re.match(r"^/[A-Za-z]:", path_text):
path_text = path_text[1:]
path = Path(path_text)
subdir = (query.get("subdir") or [None])[0]
return ResolvedSource(
kind="file",
Expand Down
11 changes: 11 additions & 0 deletions packages/create-python-app-core/tests/test_paths.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import os
from pathlib import Path

import pytest
Expand All@@ -18,6 +19,16 @@ def test_file_url(tmp_path: Path) -> None:
assert src.subdir == "templates/foo"


def test_windows_drive_letter_file_url() -> None:
if os.name != "nt":
pytest.skip("Windows path handling is only relevant on Windows")

src = resolve_source("file:///E:/create-python/cpa-templates?subdir=templates/foo")
assert src.kind == "file"
assert src.subdir == "templates/foo"
assert src.local_path == Path(r"E:\create-python\cpa-templates")


def test_github_url_with_ref() -> None:
src = resolve_source("https://github.com/org/repo?ref=main&subdir=templates/x")
assert src.kind == "github"
Expand Down