Jetty leaking out of `:dd-java-agent:testing` by bric3 · Pull Request #10218 · DataDog/dd-trace-java

bric3 · 2025-12-15T21:14:39Z

What Does This Do

:dd-java-agent:testing is using jetty for it's embedded server. However, it leaks through other projects, in particular jetty instrumentation projects, but others too. This forces these projects to exclude that dependency.

Also, make some dependencies explicit, e.g. in spring webflux tests: :dd-java-agent:testing.

Motivation

Build correctness.
Needed by #9752

Additional Notes

This was introduced as part of

Support jetty client 10 and 11 #6590

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

…version of jetty

pr-commenter · 2025-12-15T22:18:09Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/fix-jetty-leaking-out-of-testing
git_commit_date	1765983602	1765986589
git_commit_sha	`cebe04f`	`0d4dc6f`
release_version	1.57.0-SNAPSHOT~cebe04f7d3	1.57.0-SNAPSHOT~0d4dc6fb85

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1765988396	1765988396
ci_job_id	1302925083	1302925083
ci_pipeline_id	87320807	87320807
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-054yptve 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-054yptve 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics.

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~0d4dc6fb85, baseline=1.57.0-SNAPSHOT~cebe04f7d3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1084917
Total [baseline] (8.772 s) : 0, 8771971
Agent [candidate] (1.079 s) : 0, 1079253
Total [candidate] (8.736 s) : 0, 8736222
section iast
Agent [baseline] (1.224 s) : 0, 1224288
Total [baseline] (9.411 s) : 0, 9410647
Agent [candidate] (1.236 s) : 0, 1236177
Total [candidate] (9.39 s) : 0, 9389668

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.085 s	-
Agent	iast	1.224 s	139.371 ms (12.8%)
Total	tracing	8.772 s	-
Total	iast	9.411 s	638.676 ms (7.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.079 s	-
Agent	iast	1.236 s	156.924 ms (14.5%)
Total	tracing	8.736 s	-
Total	iast	9.39 s	653.445 ms (7.5%)

gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~0d4dc6fb85, baseline=1.57.0-SNAPSHOT~cebe04f7d3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (651.952 ms) : 0, 651952
BytebuddyAgent [candidate] (647.823 ms) : 0, 647823
GlobalTracer [baseline] (283.498 ms) : 0, 283498
GlobalTracer [candidate] (282.133 ms) : 0, 282133
AppSec [baseline] (32.349 ms) : 0, 32349
AppSec [candidate] (32.262 ms) : 0, 32262
Debugger [baseline] (67.138 ms) : 0, 67138
Debugger [candidate] (67.043 ms) : 0, 67043
Remote Config [baseline] (623.808 µs) : 0, 624
Remote Config [candidate] (635.72 µs) : 0, 636
Telemetry [baseline] (8.932 ms) : 0, 8932
Telemetry [candidate] (9.013 ms) : 0, 9013
Flare Poller [baseline] (3.716 ms) : 0, 3716
Flare Poller [candidate] (3.805 ms) : 0, 3805
section iast
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.228 ms) : 0, 1228
BytebuddyAgent [baseline] (791.285 ms) : 0, 791285
BytebuddyAgent [candidate] (800.411 ms) : 0, 800411
GlobalTracer [baseline] (256.411 ms) : 0, 256411
GlobalTracer [candidate] (258.519 ms) : 0, 258519
IAST [baseline] (27.394 ms) : 0, 27394
IAST [candidate] (27.371 ms) : 0, 27371
AppSec [baseline] (33.586 ms) : 0, 33586
AppSec [candidate] (32.927 ms) : 0, 32927
Debugger [baseline] (66.588 ms) : 0, 66588
Debugger [candidate] (67.606 ms) : 0, 67606
Remote Config [baseline] (580.114 µs) : 0, 580
Remote Config [candidate] (566.126 µs) : 0, 566
Telemetry [baseline] (8.428 ms) : 0, 8428
Telemetry [candidate] (8.474 ms) : 0, 8474
Flare Poller [baseline] (3.584 ms) : 0, 3584
Flare Poller [candidate] (3.508 ms) : 0, 3508

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~0d4dc6fb85, baseline=1.57.0-SNAPSHOT~cebe04f7d3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1080201
Total [baseline] (10.826 s) : 0, 10826262
Agent [candidate] (1.082 s) : 0, 1081736
Total [candidate] (10.751 s) : 0, 10750705
section appsec
Agent [baseline] (1.267 s) : 0, 1267382
Total [baseline] (11.022 s) : 0, 11022425
Agent [candidate] (1.262 s) : 0, 1262161
Total [candidate] (10.97 s) : 0, 10970435
section iast
Agent [baseline] (1.226 s) : 0, 1225993
Total [baseline] (11.122 s) : 0, 11121822
Agent [candidate] (1.219 s) : 0, 1219467
Total [candidate] (11.211 s) : 0, 11210817
section profiling
Agent [baseline] (1.203 s) : 0, 1202743
Total [baseline] (10.889 s) : 0, 10888541
Agent [candidate] (1.202 s) : 0, 1201624
Total [candidate] (10.995 s) : 0, 10995469

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.08 s	-
Agent	appsec	1.267 s	187.181 ms (17.3%)
Agent	iast	1.226 s	145.792 ms (13.5%)
Agent	profiling	1.203 s	122.541 ms (11.3%)
Total	tracing	10.826 s	-
Total	appsec	11.022 s	196.163 ms (1.8%)
Total	iast	11.122 s	295.56 ms (2.7%)
Total	profiling	10.889 s	62.28 ms (0.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.082 s	-
Agent	appsec	1.262 s	180.426 ms (16.7%)
Agent	iast	1.219 s	137.731 ms (12.7%)
Agent	profiling	1.202 s	119.888 ms (11.1%)
Total	tracing	10.751 s	-
Total	appsec	10.97 s	219.73 ms (2.0%)
Total	iast	11.211 s	460.112 ms (4.3%)
Total	profiling	10.995 s	244.764 ms (2.3%)

gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~0d4dc6fb85, baseline=1.57.0-SNAPSHOT~cebe04f7d3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.172 ms) : 0, 1172
BytebuddyAgent [baseline] (647.875 ms) : 0, 647875
BytebuddyAgent [candidate] (648.316 ms) : 0, 648316
GlobalTracer [baseline] (282.18 ms) : 0, 282180
GlobalTracer [candidate] (282.79 ms) : 0, 282790
AppSec [baseline] (32.259 ms) : 0, 32259
AppSec [candidate] (32.411 ms) : 0, 32411
Debugger [baseline] (68.082 ms) : 0, 68082
Debugger [candidate] (68.344 ms) : 0, 68344
Remote Config [baseline] (612.319 µs) : 0, 612
Remote Config [candidate] (613.385 µs) : 0, 613
Telemetry [baseline] (8.892 ms) : 0, 8892
Telemetry [candidate] (8.96 ms) : 0, 8960
Flare Poller [baseline] (3.714 ms) : 0, 3714
Flare Poller [candidate] (3.722 ms) : 0, 3722
section appsec
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (691.93 ms) : 0, 691930
BytebuddyAgent [candidate] (688.361 ms) : 0, 688361
GlobalTracer [baseline] (259.911 ms) : 0, 259911
GlobalTracer [candidate] (258.763 ms) : 0, 258763
AppSec [baseline] (170.995 ms) : 0, 170995
AppSec [candidate] (172.259 ms) : 0, 172259
Debugger [baseline] (69.324 ms) : 0, 69324
Debugger [candidate] (68.022 ms) : 0, 68022
Remote Config [baseline] (699.666 µs) : 0, 700
Remote Config [candidate] (717.776 µs) : 0, 718
Telemetry [baseline] (9.076 ms) : 0, 9076
Telemetry [candidate] (8.995 ms) : 0, 8995
Flare Poller [baseline] (3.876 ms) : 0, 3876
Flare Poller [candidate] (3.865 ms) : 0, 3865
IAST [baseline] (24.654 ms) : 0, 24654
IAST [candidate] (24.518 ms) : 0, 24518
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.171 ms) : 0, 1171
BytebuddyAgent [baseline] (792.497 ms) : 0, 792497
BytebuddyAgent [candidate] (788.044 ms) : 0, 788044
GlobalTracer [baseline] (256.095 ms) : 0, 256095
GlobalTracer [candidate] (255.009 ms) : 0, 255009
AppSec [baseline] (33.788 ms) : 0, 33788
AppSec [candidate] (34.178 ms) : 0, 34178
Debugger [baseline] (67.439 ms) : 0, 67439
Debugger [candidate] (66.279 ms) : 0, 66279
Remote Config [baseline] (553.813 µs) : 0, 554
Remote Config [candidate] (592.526 µs) : 0, 593
Telemetry [baseline] (8.469 ms) : 0, 8469
Telemetry [candidate] (8.464 ms) : 0, 8464
Flare Poller [baseline] (3.52 ms) : 0, 3520
Flare Poller [candidate] (3.481 ms) : 0, 3481
IAST [baseline] (27.093 ms) : 0, 27093
IAST [candidate] (27.16 ms) : 0, 27160
section profiling
ProfilingAgent [baseline] (96.566 ms) : 0, 96566
ProfilingAgent [candidate] (96.498 ms) : 0, 96498
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (700.994 ms) : 0, 700994
BytebuddyAgent [candidate] (700.041 ms) : 0, 700041
GlobalTracer [baseline] (220.851 ms) : 0, 220851
GlobalTracer [candidate] (220.662 ms) : 0, 220662
AppSec [baseline] (32.153 ms) : 0, 32153
AppSec [candidate] (32.045 ms) : 0, 32045
Debugger [baseline] (68.148 ms) : 0, 68148
Debugger [candidate] (68.263 ms) : 0, 68263
Remote Config [baseline] (647.773 µs) : 0, 648
Remote Config [candidate] (620.605 µs) : 0, 621
Telemetry [baseline] (8.84 ms) : 0, 8840
Telemetry [candidate] (8.875 ms) : 0, 8875
Flare Poller [baseline] (3.692 ms) : 0, 3692
Flare Poller [candidate] (3.742 ms) : 0, 3742
Profiling [baseline] (97.138 ms) : 0, 97138
Profiling [candidate] (97.069 ms) : 0, 97069

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/fix-jetty-leaking-out-of-testing
git_commit_date	1765983602	1765986589
git_commit_sha	`cebe04f`	`0d4dc6f`
release_version	1.57.0-SNAPSHOT~cebe04f7d3	1.57.0-SNAPSHOT~0d4dc6fb85

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1765988890	1765988890
ci_job_id	1302925088	1302925088
ci_pipeline_id	87320807	87320807
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-otbb4zap 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-otbb4zap 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 4 performance improvements and 6 performance regressions! Performance is the same for 11 metrics, 15 unstable metrics.

scenario	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p95	Δ mean throughput	candidate mean agg_http_req_duration_p50	candidate mean agg_http_req_duration_p95	candidate mean throughput	baseline mean agg_http_req_duration_p50	baseline mean agg_http_req_duration_p95	baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load	better [-325.670µs; -215.614µs] or [-11.408%; -7.553%]	better [-746.104µs; -310.836µs] or [-9.349%; -3.895%]	unstable [-29.841op/s; +252.404op/s] or [-2.341%; +19.799%]	2.584ms	7.452ms	1386.094op/s	2.855ms	7.981ms	1274.812op/s
scenario:load:petclinic:iast:high_load	worse [+0.861ms; +1.640ms] or [+5.011%; +9.540%]	worse [+0.681ms; +2.185ms] or [+2.383%; +7.639%]	unstable [-41.314op/s; +9.189op/s] or [-15.576%; +3.464%]	18.440ms	30.033ms	249.188op/s	17.189ms	28.600ms	265.250op/s
scenario:load:petclinic:no_agent:high_load	worse [+0.820ms; +1.851ms] or [+5.047%; +11.392%]	worse [+0.892ms; +3.383ms] or [+3.223%; +12.227%]	unstable [-47.559op/s; +7.372op/s] or [-17.142%; +2.657%]	17.588ms	29.801ms	257.344op/s	16.252ms	27.664ms	277.438op/s
scenario:load:petclinic:appsec:high_load	better [-1.767ms; -0.725ms] or [-9.248%; -3.796%]	better [-2.450ms; -0.953ms] or [-7.917%; -3.078%]	unstable [-10.058op/s; +39.558op/s] or [-4.174%; +16.416%]	17.857ms	29.247ms	255.719op/s	19.103ms	30.949ms	240.969op/s
scenario:load:petclinic:code_origins:high_load	worse [+0.782ms; +1.559ms] or [+4.520%; +9.008%]	unsure [+0.323ms; +1.801ms] or [+1.128%; +6.297%]	unstable [-40.637op/s; +9.825op/s] or [-15.406%; +3.725%]	18.477ms	29.670ms	248.375op/s	17.307ms	28.608ms	263.781op/s
scenario:load:petclinic:profiling:high_load	worse [+0.638ms; +1.834ms] or [+3.488%; +10.029%]	same [-337.405µs; +1808.469µs] or [-1.120%; +6.003%]	unstable [-36.363op/s; +12.238op/s] or [-14.611%; +4.917%]	19.520ms	30.863ms	236.812op/s	18.285ms	30.127ms	248.875op/s

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~0d4dc6fb85, baseline=1.57.0-SNAPSHOT~cebe04f7d3
dateFormat X
axisFormat %s
section baseline
no_agent (1.195 ms) : 1183, 1207
. : milestone, 1195,
iast (3.164 ms) : 3119, 3210
. : milestone, 3164,
iast_FULL (5.768 ms) : 5711, 5824
. : milestone, 5768,
iast_GLOBAL (3.598 ms) : 3545, 3650
. : milestone, 3598,
profiling (1.991 ms) : 1972, 2010
. : milestone, 1991,
tracing (1.839 ms) : 1824, 1855
. : milestone, 1839,
section candidate
no_agent (1.173 ms) : 1161, 1184
. : milestone, 1173,
iast (3.237 ms) : 3196, 3278
. : milestone, 3237,
iast_FULL (5.644 ms) : 5588, 5700
. : milestone, 5644,
iast_GLOBAL (3.304 ms) : 3260, 3348
. : milestone, 3304,
profiling (2.104 ms) : 2085, 2122
. : milestone, 2104,
tracing (1.801 ms) : 1787, 1816
. : milestone, 1801,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.195 ms [1.183 ms, 1.207 ms]	-
iast	3.164 ms [3.119 ms, 3.21 ms]	1.969 ms (164.8%)
iast_FULL	5.768 ms [5.711 ms, 5.824 ms]	4.572 ms (382.6%)
iast_GLOBAL	3.598 ms [3.545 ms, 3.65 ms]	2.403 ms (201.0%)
profiling	1.991 ms [1.972 ms, 2.01 ms]	795.913 µs (66.6%)
tracing	1.839 ms [1.824 ms, 1.855 ms]	644.307 µs (53.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.173 ms [1.161 ms, 1.184 ms]	-
iast	3.237 ms [3.196 ms, 3.278 ms]	2.065 ms (176.1%)
iast_FULL	5.644 ms [5.588 ms, 5.7 ms]	4.471 ms (381.4%)
iast_GLOBAL	3.304 ms [3.26 ms, 3.348 ms]	2.131 ms (181.8%)
profiling	2.104 ms [2.085 ms, 2.122 ms]	931.116 µs (79.4%)
tracing	1.801 ms [1.787 ms, 1.816 ms]	628.819 µs (53.6%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~0d4dc6fb85, baseline=1.57.0-SNAPSHOT~cebe04f7d3
dateFormat X
axisFormat %s
section baseline
no_agent (16.814 ms) : 16650, 16978
. : milestone, 16814,
appsec (19.372 ms) : 19173, 19570
. : milestone, 19372,
code_origins (17.692 ms) : 17515, 17870
. : milestone, 17692,
iast (17.587 ms) : 17413, 17761
. : milestone, 17587,
profiling (18.755 ms) : 18564, 18946
. : milestone, 18755,
tracing (17.849 ms) : 17671, 18028
. : milestone, 17849,
section candidate
no_agent (18.133 ms) : 17948, 18319
. : milestone, 18133,
appsec (18.248 ms) : 18067, 18430
. : milestone, 18248,
code_origins (18.79 ms) : 18606, 18974
. : milestone, 18790,
iast (18.729 ms) : 18538, 18921
. : milestone, 18729,
profiling (19.71 ms) : 19508, 19912
. : milestone, 19710,
tracing (17.643 ms) : 17467, 17820
. : milestone, 17643,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	16.814 ms [16.65 ms, 16.978 ms]	-
appsec	19.372 ms [19.173 ms, 19.57 ms]	2.557 ms (15.2%)
code_origins	17.692 ms [17.515 ms, 17.87 ms]	877.888 µs (5.2%)
iast	17.587 ms [17.413 ms, 17.761 ms]	772.494 µs (4.6%)
profiling	18.755 ms [18.564 ms, 18.946 ms]	1.941 ms (11.5%)
tracing	17.849 ms [17.671 ms, 18.028 ms]	1.035 ms (6.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.133 ms [17.948 ms, 18.319 ms]	-
appsec	18.248 ms [18.067 ms, 18.43 ms]	115.206 µs (0.6%)
code_origins	18.79 ms [18.606 ms, 18.974 ms]	656.854 µs (3.6%)
iast	18.729 ms [18.538 ms, 18.921 ms]	596.244 µs (3.3%)
profiling	19.71 ms [19.508 ms, 19.912 ms]	1.577 ms (8.7%)
tracing	17.643 ms [17.467 ms, 17.82 ms]	-489.863 µs (-2.7%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/fix-jetty-leaking-out-of-testing
git_commit_date	1765983602	1765986589
git_commit_sha	`cebe04f`	`0d4dc6f`
release_version	1.57.0-SNAPSHOT~cebe04f7d3	1.57.0-SNAPSHOT~0d4dc6fb85

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1765988678	1765988678
ci_job_id	1302925093	1302925093
ci_pipeline_id	87320807	87320807
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-c4wy7tma 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-c4wy7tma 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~0d4dc6fb85, baseline=1.57.0-SNAPSHOT~cebe04f7d3
dateFormat X
axisFormat %s
section baseline
no_agent (15.088 s) : 15088000, 15088000
. : milestone, 15088000,
appsec (14.525 s) : 14525000, 14525000
. : milestone, 14525000,
iast (18.471 s) : 18471000, 18471000
. : milestone, 18471000,
iast_GLOBAL (17.647 s) : 17647000, 17647000
. : milestone, 17647000,
profiling (14.768 s) : 14768000, 14768000
. : milestone, 14768000,
tracing (14.777 s) : 14777000, 14777000
. : milestone, 14777000,
section candidate
no_agent (15.579 s) : 15579000, 15579000
. : milestone, 15579000,
appsec (14.815 s) : 14815000, 14815000
. : milestone, 14815000,
iast (18.641 s) : 18641000, 18641000
. : milestone, 18641000,
iast_GLOBAL (17.93 s) : 17930000, 17930000
. : milestone, 17930000,
profiling (14.719 s) : 14719000, 14719000
. : milestone, 14719000,
tracing (14.672 s) : 14672000, 14672000
. : milestone, 14672000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.088 s [15.088 s, 15.088 s]	-
appsec	14.525 s [14.525 s, 14.525 s]	-563.0 ms (-3.7%)
iast	18.471 s [18.471 s, 18.471 s]	3.383 s (22.4%)
iast_GLOBAL	17.647 s [17.647 s, 17.647 s]	2.559 s (17.0%)
profiling	14.768 s [14.768 s, 14.768 s]	-320.0 ms (-2.1%)
tracing	14.777 s [14.777 s, 14.777 s]	-311.0 ms (-2.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.579 s [15.579 s, 15.579 s]	-
appsec	14.815 s [14.815 s, 14.815 s]	-764.0 ms (-4.9%)
iast	18.641 s [18.641 s, 18.641 s]	3.062 s (19.7%)
iast_GLOBAL	17.93 s [17.93 s, 17.93 s]	2.351 s (15.1%)
profiling	14.719 s [14.719 s, 14.719 s]	-860.0 ms (-5.5%)
tracing	14.672 s [14.672 s, 14.672 s]	-907.0 ms (-5.8%)

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~0d4dc6fb85, baseline=1.57.0-SNAPSHOT~cebe04f7d3
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (3.667 ms) : 3452, 3882
. : milestone, 3667,
iast (2.213 ms) : 2148, 2278
. : milestone, 2213,
iast_GLOBAL (2.257 ms) : 2193, 2322
. : milestone, 2257,
profiling (2.485 ms) : 2275, 2695
. : milestone, 2485,
tracing (2.052 ms) : 2001, 2103
. : milestone, 2052,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.742 ms) : 3522, 3962
. : milestone, 3742,
iast (2.222 ms) : 2157, 2288
. : milestone, 2222,
iast_GLOBAL (2.26 ms) : 2196, 2325
. : milestone, 2260,
profiling (2.069 ms) : 2016, 2121
. : milestone, 2069,
tracing (2.055 ms) : 2005, 2106
. : milestone, 2055,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.479 ms [1.467 ms, 1.49 ms]	-
appsec	3.667 ms [3.452 ms, 3.882 ms]	2.188 ms (148.0%)
iast	2.213 ms [2.148 ms, 2.278 ms]	734.68 µs (49.7%)
iast_GLOBAL	2.257 ms [2.193 ms, 2.322 ms]	778.51 µs (52.6%)
profiling	2.485 ms [2.275 ms, 2.695 ms]	1.006 ms (68.1%)
tracing	2.052 ms [2.001 ms, 2.103 ms]	573.309 µs (38.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.462 ms, 1.485 ms]	-
appsec	3.742 ms [3.522 ms, 3.962 ms]	2.269 ms (154.0%)
iast	2.222 ms [2.157 ms, 2.288 ms]	749.015 µs (50.8%)
iast_GLOBAL	2.26 ms [2.196 ms, 2.325 ms]	786.789 µs (53.4%)
profiling	2.069 ms [2.016 ms, 2.121 ms]	595.276 µs (40.4%)
tracing	2.055 ms [2.005 ms, 2.106 ms]	581.909 µs (39.5%)

This was lost when jetty server got shadowed.

…instrumentation Now that :dd-java-agent:testing shadows jetty, the jetty instrumentation was not applied.

amarziali

Thanks for that improvement!

This reverts commit 7442d01.

bric3 added 4 commits December 15, 2025 21:53

fix: Workaround for :dd-java-agent:testing coming with a more recent …
8680447
…version of jetty

fix: Proper shadowing of jetty in agent-testing
be26899

chore: lockfiles
9deb715

fix: jsp instrumentation needlessly requiring jetty http status
73e0938

bric3 added type: feature Enhancements and improvements tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Dec 15, 2025

bric3 temporarily deployed to ci-build December 15, 2025 21:14 — with GitHub Actions Inactive

bric3 temporarily deployed to ci-build December 15, 2025 21:47 — with GitHub Actions Inactive

AlexeyKuznetsov-DD reviewed Dec 15, 2025
View reviewed changes

Comment threaddd-java-agent/testing/build.gradle Outdated

bric3 marked this pull request as ready for review December 15, 2025 22:58

bric3 requested review from a team as code owners December 15, 2025 22:58

bric3 requested a review from mcculls December 15, 2025 22:58

bric3 mentioned this pull request Dec 15, 2025
Remove instrumentation afterEvaluate#9752
Merged

bric3 marked this pull request as draft December 15, 2025 23:25

bric3 added 2 commits December 16, 2025 00:57

fix: Exports servlet request api
0f91d4f
This was lost when jetty server got shadowed.

fix: Use config lazy API
2b6b84d

bric3 force-pushed the bdu/fix-jetty-leaking-out-of-testing branch from efaf8a0 to 2b6b84dCompare December 16, 2025 00:09

bric3 temporarily deployed to ci-build December 16, 2025 00:09 — with GitHub Actions Inactive

AlexeyKuznetsov-DD reviewed Dec 16, 2025
View reviewed changes

Comment threaddd-java-agent/testing/build.gradle

chore: Make spotless happy
612bea1

bric3 temporarily deployed to ci-build December 16, 2025 06:53 — with GitHub Actions Inactive

fix: Replaces testing http client by raw jetty in Apache Http Client …
681b9df
…instrumentation Now that :dd-java-agent:testing shadows jetty, the jetty instrumentation was not applied.

bric3 temporarily deployed to ci-build December 16, 2025 17:48 — with GitHub Actions Inactive

chore: Make spotless happy
9f78da2

bric3 temporarily deployed to ci-build December 16, 2025 20:19 — with GitHub Actions Inactive

Merge branch 'master' into bdu/fix-jetty-leaking-out-of-testing
42ed9b7

bric3 marked this pull request as ready for review December 16, 2025 22:14

bric3 requested a review from a team as a code owner December 16, 2025 22:14

bric3 requested review from dromanol and manuel-alvarez-alvarez December 16, 2025 22:14

bric3 temporarily deployed to ci-build December 16, 2025 22:14 — with GitHub Actions Inactive

Merge branch 'master' into bdu/fix-jetty-leaking-out-of-testing
0d4dc6f

bric3 temporarily deployed to ci-build December 17, 2025 15:49 — with GitHub Actions Inactive

bric3 requested a review from amarziali December 17, 2025 15:54

AlexeyKuznetsov-DD approved these changes Dec 17, 2025
View reviewed changes

amarziali approved these changes Dec 18, 2025
View reviewed changes

bric3 merged commit 7442d01 into masterDec 18, 2025
559 checks passed

bric3 deleted the bdu/fix-jetty-leaking-out-of-testing branch December 18, 2025 12:24

github-actionsBot added this to the 1.58.0 milestone Dec 18, 2025

bric3 mentioned this pull request Dec 31, 2025
Rewrite build-time instrumentation as compilation post-processor (using Gradle lazy APIs) #9475
Merged

amarziali added a commit that referenced this pull request Jan 13, 2026
Revert "Jetty leaking out of:dd-java-agent:testing(#10218)"
e957181
This reverts commit 7442d01.

bric3 mentioned this pull request Jan 13, 2026
Fix type issues after shading jetty in test server #10349
Merged

Navigation Menu

Uh oh!

Jetty leaking out of `:dd-java-agent:testing` - #10218

Jetty leaking out of `:dd-java-agent:testing`#10218
bric3 merged 11 commits into
masterfrom
bdu/fix-jetty-leaking-out-of-testing

bric3 commented Dec 15, 2025•
edited
Loading

Uh oh!

Uh oh!

pr-commenterBot commented Dec 15, 2025•
edited
Loading

Uh oh!

Uh oh!

amarziali left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

bric3 commented Dec 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

Uh oh!

pr-commenterBot commented Dec 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

amarziali left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bric3 commented Dec 15, 2025•
edited
Loading

pr-commenterBot commented Dec 15, 2025•
edited
Loading