Remove instrumentation `afterEvaluate` by bric3 · Pull Request #9752 · DataDog/dd-trace-java

bric3 · 2025-10-14T14:57:53Z

What Does This Do

Removes instrumentation module's afterEvaluate.

This looks like it is reducing sync time to ~1min on my M1

Motivation

Using afterEvaluate is a bad practice and has tighter restriction in Gradle 9+.

https://docs.gradle.org/9.1.0/userguide/task_configuration_avoidance.html#8_some_apis_may_be_disallowed_if_you_try_to_access_them_from_the_new_apis_configuration_blocks

It introduces subtle ordering issues which can be very challenging to debug.

From my notes:

Anyone wanting to use code in an afterEvaluate {} now also needs to use afterEvaluate {} all the way down.
It becomes even more complicated as more plugins/scripts are involved
More generally, it makes dependencies between plugins/scripts implicit and error prone
Abusing afterEvaluate causes many things that will try to run later and later after each other when order is not guaranteed. In almost all situations, afterEvaluate is a work-around that introduces timing problems and race conditions and just treats symptoms.
Usually, afterEvaluate {} is good in this occasion:
consistency checks, i.e. ensure that something is not misconfigured.

Additional Notes

Blocked by

Blocks

Rewrite build-time instrumentation as compilation post-processor (using Gradle lazy APIs) #9475

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-11-12T19:46:42Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/avoid-afterEvaluate-in-instrumentation
git_commit_date	1766071645	1766078043
git_commit_sha	`6ccbc06`	`243cc8f`
release_version	1.58.0-SNAPSHOT~6ccbc0607e	1.58.0-SNAPSHOT~243cc8f840

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1766079850	1766079850
ci_job_id	1307076353	1307076353
ci_pipeline_id	87613305	87613305
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-mwa53pvk 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-mwa53pvk 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics.

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~243cc8f840, baseline=1.58.0-SNAPSHOT~6ccbc0607e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085898
Total [baseline] (8.802 s) : 0, 8801663
Agent [candidate] (1.083 s) : 0, 1083123
Total [candidate] (8.768 s) : 0, 8768393
section iast
Agent [baseline] (1.222 s) : 0, 1222133
Total [baseline] (9.37 s) : 0, 9370267
Agent [candidate] (1.223 s) : 0, 1223247
Total [candidate] (9.388 s) : 0, 9387699

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.086 s	-
Agent	iast	1.222 s	136.235 ms (12.5%)
Total	tracing	8.802 s	-
Total	iast	9.37 s	568.603 ms (6.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.083 s	-
Agent	iast	1.223 s	140.124 ms (12.9%)
Total	tracing	8.768 s	-
Total	iast	9.388 s	619.306 ms (7.1%)

gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~243cc8f840, baseline=1.58.0-SNAPSHOT~6ccbc0607e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (653.057 ms) : 0, 653057
BytebuddyAgent [candidate] (650.182 ms) : 0, 650182
GlobalTracer [baseline] (282.706 ms) : 0, 282706
GlobalTracer [candidate] (283.262 ms) : 0, 283262
AppSec [baseline] (32.369 ms) : 0, 32369
AppSec [candidate] (32.439 ms) : 0, 32439
Debugger [baseline] (67.51 ms) : 0, 67510
Debugger [candidate] (66.377 ms) : 0, 66377
Remote Config [baseline] (611.203 µs) : 0, 611
Remote Config [candidate] (630.699 µs) : 0, 631
Telemetry [baseline] (9.038 ms) : 0, 9038
Telemetry [candidate] (9.778 ms) : 0, 9778
Flare Poller [baseline] (3.716 ms) : 0, 3716
Flare Poller [candidate] (3.73 ms) : 0, 3730
section iast
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (789.566 ms) : 0, 789566
BytebuddyAgent [candidate] (790.31 ms) : 0, 790310
GlobalTracer [baseline] (256.281 ms) : 0, 256281
GlobalTracer [candidate] (256.512 ms) : 0, 256512
AppSec [baseline] (33.498 ms) : 0, 33498
AppSec [candidate] (32.912 ms) : 0, 32912
Debugger [baseline] (66.435 ms) : 0, 66435
Debugger [candidate] (67.126 ms) : 0, 67126
Remote Config [baseline] (635.752 µs) : 0, 636
Remote Config [candidate] (596.746 µs) : 0, 597
Telemetry [baseline] (8.531 ms) : 0, 8531
Telemetry [candidate] (8.477 ms) : 0, 8477
Flare Poller [baseline] (3.565 ms) : 0, 3565
Flare Poller [candidate] (3.558 ms) : 0, 3558
IAST [baseline] (26.985 ms) : 0, 26985
IAST [candidate] (27.075 ms) : 0, 27075

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~243cc8f840, baseline=1.58.0-SNAPSHOT~6ccbc0607e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088034
Total [baseline] (10.869 s) : 0, 10869293
Agent [candidate] (1.082 s) : 0, 1082192
Total [candidate] (10.803 s) : 0, 10803129
section appsec
Agent [baseline] (1.267 s) : 0, 1266759
Total [baseline] (11.007 s) : 0, 11007006
Agent [candidate] (1.268 s) : 0, 1268015
Total [candidate] (11.013 s) : 0, 11013066
section iast
Agent [baseline] (1.222 s) : 0, 1222281
Total [baseline] (11.165 s) : 0, 11164928
Agent [candidate] (1.238 s) : 0, 1238273
Total [candidate] (11.243 s) : 0, 11242752
section profiling
Agent [baseline] (1.207 s) : 0, 1206577
Total [baseline] (10.97 s) : 0, 10969648
Agent [candidate] (1.208 s) : 0, 1207817
Total [candidate] (10.979 s) : 0, 10978687

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.088 s	-
Agent	appsec	1.267 s	178.726 ms (16.4%)
Agent	iast	1.222 s	134.247 ms (12.3%)
Agent	profiling	1.207 s	118.543 ms (10.9%)
Total	tracing	10.869 s	-
Total	appsec	11.007 s	137.713 ms (1.3%)
Total	iast	11.165 s	295.635 ms (2.7%)
Total	profiling	10.97 s	100.355 ms (0.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.082 s	-
Agent	appsec	1.268 s	185.822 ms (17.2%)
Agent	iast	1.238 s	156.081 ms (14.4%)
Agent	profiling	1.208 s	125.625 ms (11.6%)
Total	tracing	10.803 s	-
Total	appsec	11.013 s	209.937 ms (1.9%)
Total	iast	11.243 s	439.622 ms (4.1%)
Total	profiling	10.979 s	175.557 ms (1.6%)

gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~243cc8f840, baseline=1.58.0-SNAPSHOT~6ccbc0607e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (654.048 ms) : 0, 654048
BytebuddyAgent [candidate] (648.746 ms) : 0, 648746
GlobalTracer [baseline] (282.819 ms) : 0, 282819
GlobalTracer [candidate] (283.013 ms) : 0, 283013
AppSec [baseline] (32.363 ms) : 0, 32363
AppSec [candidate] (32.202 ms) : 0, 32202
Debugger [baseline] (68.652 ms) : 0, 68652
Debugger [candidate] (68.102 ms) : 0, 68102
Remote Config [baseline] (603.21 µs) : 0, 603
Remote Config [candidate] (622.745 µs) : 0, 623
Telemetry [baseline] (8.983 ms) : 0, 8983
Telemetry [candidate] (9.159 ms) : 0, 9159
Flare Poller [baseline] (3.711 ms) : 0, 3711
Flare Poller [candidate] (3.726 ms) : 0, 3726
section appsec
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (690.095 ms) : 0, 690095
BytebuddyAgent [candidate] (690.992 ms) : 0, 690992
GlobalTracer [baseline] (259.807 ms) : 0, 259807
GlobalTracer [candidate] (260.562 ms) : 0, 260562
AppSec [baseline] (174.917 ms) : 0, 174917
AppSec [candidate] (174.954 ms) : 0, 174954
Debugger [baseline] (66.99 ms) : 0, 66990
Debugger [candidate] (66.65 ms) : 0, 66650
Remote Config [baseline] (734.426 µs) : 0, 734
Remote Config [candidate] (691.811 µs) : 0, 692
Telemetry [baseline] (8.897 ms) : 0, 8897
Telemetry [candidate] (8.976 ms) : 0, 8976
Flare Poller [baseline] (3.821 ms) : 0, 3821
Flare Poller [candidate] (3.775 ms) : 0, 3775
IAST [baseline] (24.571 ms) : 0, 24571
IAST [candidate] (24.498 ms) : 0, 24498
section iast
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (789.265 ms) : 0, 789265
BytebuddyAgent [candidate] (801.325 ms) : 0, 801325
GlobalTracer [baseline] (256.404 ms) : 0, 256404
GlobalTracer [candidate] (258.474 ms) : 0, 258474
AppSec [baseline] (31.839 ms) : 0, 31839
AppSec [candidate] (33.229 ms) : 0, 33229
Debugger [baseline] (68.387 ms) : 0, 68387
Debugger [candidate] (68.186 ms) : 0, 68186
Remote Config [baseline] (593.334 µs) : 0, 593
Remote Config [candidate] (628.212 µs) : 0, 628
Telemetry [baseline] (8.504 ms) : 0, 8504
Telemetry [candidate] (8.659 ms) : 0, 8659
Flare Poller [baseline] (3.533 ms) : 0, 3533
Flare Poller [candidate] (3.556 ms) : 0, 3556
IAST [baseline] (27.135 ms) : 0, 27135
IAST [candidate] (27.323 ms) : 0, 27323
section profiling
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.223 ms) : 0, 1223
BytebuddyAgent [baseline] (703.154 ms) : 0, 703154
BytebuddyAgent [candidate] (703.668 ms) : 0, 703668
GlobalTracer [baseline] (221.417 ms) : 0, 221417
GlobalTracer [candidate] (221.377 ms) : 0, 221377
AppSec [baseline] (32.193 ms) : 0, 32193
AppSec [candidate] (32.19 ms) : 0, 32190
Debugger [baseline] (68.063 ms) : 0, 68063
Debugger [candidate] (68.81 ms) : 0, 68810
Remote Config [baseline] (636.941 µs) : 0, 637
Remote Config [candidate] (644.429 µs) : 0, 644
Telemetry [baseline] (8.931 ms) : 0, 8931
Telemetry [candidate] (8.856 ms) : 0, 8856
Flare Poller [baseline] (3.775 ms) : 0, 3775
Flare Poller [candidate] (3.798 ms) : 0, 3798
ProfilingAgent [baseline] (97.275 ms) : 0, 97275
ProfilingAgent [candidate] (97.455 ms) : 0, 97455
Profiling [baseline] (97.874 ms) : 0, 97874
Profiling [candidate] (98.034 ms) : 0, 98034

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/avoid-afterEvaluate-in-instrumentation
git_commit_date	1766071645	1766078043
git_commit_sha	`6ccbc06`	`243cc8f`
release_version	1.58.0-SNAPSHOT~6ccbc0607e	1.58.0-SNAPSHOT~243cc8f840

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1766080454	1766080454
ci_job_id	1307076354	1307076354
ci_pipeline_id	87613305	87613305
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-aig95htc 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-aig95htc 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 2 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.

scenario	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p95	Δ mean throughput	candidate mean agg_http_req_duration_p50	candidate mean agg_http_req_duration_p95	candidate mean throughput	baseline mean agg_http_req_duration_p50	baseline mean agg_http_req_duration_p95	baseline mean throughput
scenario:load:petclinic:appsec:high_load	worse [+0.706ms; +1.601ms] or [+3.896%; +8.831%]	worse [+0.778ms; +2.067ms] or [+2.597%; +6.896%]	unstable [-35.258op/s; +9.258op/s] or [-14.023%; +3.682%]	19.288ms	31.388ms	238.438op/s	18.134ms	29.966ms	251.438op/s

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~243cc8f840, baseline=1.58.0-SNAPSHOT~6ccbc0607e
dateFormat X
axisFormat %s
section baseline
no_agent (18.188 ms) : 17997, 18378
. : milestone, 18188,
appsec (18.559 ms) : 18371, 18746
. : milestone, 18559,
code_origins (17.644 ms) : 17469, 17818
. : milestone, 17644,
iast (17.689 ms) : 17511, 17866
. : milestone, 17689,
profiling (18.714 ms) : 18528, 18900
. : milestone, 18714,
tracing (17.871 ms) : 17692, 18050
. : milestone, 17871,
section candidate
no_agent (18.246 ms) : 18060, 18432
. : milestone, 18246,
appsec (19.578 ms) : 19374, 19783
. : milestone, 19578,
code_origins (17.858 ms) : 17682, 18035
. : milestone, 17858,
iast (17.617 ms) : 17440, 17794
. : milestone, 17617,
profiling (18.605 ms) : 18423, 18787
. : milestone, 18605,
tracing (17.476 ms) : 17303, 17650
. : milestone, 17476,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.188 ms [17.997 ms, 18.378 ms]	-
appsec	18.559 ms [18.371 ms, 18.746 ms]	370.922 µs (2.0%)
code_origins	17.644 ms [17.469 ms, 17.818 ms]	-543.727 µs (-3.0%)
iast	17.689 ms [17.511 ms, 17.866 ms]	-499.003 µs (-2.7%)
profiling	18.714 ms [18.528 ms, 18.9 ms]	526.268 µs (2.9%)
tracing	17.871 ms [17.692 ms, 18.05 ms]	-316.464 µs (-1.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.246 ms [18.06 ms, 18.432 ms]	-
appsec	19.578 ms [19.374 ms, 19.783 ms]	1.332 ms (7.3%)
code_origins	17.858 ms [17.682 ms, 18.035 ms]	-387.823 µs (-2.1%)
iast	17.617 ms [17.44 ms, 17.794 ms]	-629.219 µs (-3.4%)
profiling	18.605 ms [18.423 ms, 18.787 ms]	359.257 µs (2.0%)
tracing	17.476 ms [17.303 ms, 17.65 ms]	-769.838 µs (-4.2%)

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~243cc8f840, baseline=1.58.0-SNAPSHOT~6ccbc0607e
dateFormat X
axisFormat %s
section baseline
no_agent (1.189 ms) : 1178, 1201
. : milestone, 1189,
iast (3.186 ms) : 3140, 3231
. : milestone, 3186,
iast_FULL (5.742 ms) : 5685, 5799
. : milestone, 5742,
iast_GLOBAL (3.629 ms) : 3569, 3688
. : milestone, 3629,
profiling (2.049 ms) : 2031, 2067
. : milestone, 2049,
tracing (1.82 ms) : 1805, 1836
. : milestone, 1820,
section candidate
no_agent (1.199 ms) : 1187, 1211
. : milestone, 1199,
iast (3.127 ms) : 3089, 3166
. : milestone, 3127,
iast_FULL (5.76 ms) : 5702, 5817
. : milestone, 5760,
iast_GLOBAL (3.739 ms) : 3679, 3798
. : milestone, 3739,
profiling (2.189 ms) : 2170, 2209
. : milestone, 2189,
tracing (1.784 ms) : 1768, 1800
. : milestone, 1784,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.189 ms [1.178 ms, 1.201 ms]	-
iast	3.186 ms [3.14 ms, 3.231 ms]	1.997 ms (167.9%)
iast_FULL	5.742 ms [5.685 ms, 5.799 ms]	4.552 ms (382.8%)
iast_GLOBAL	3.629 ms [3.569 ms, 3.688 ms]	2.439 ms (205.1%)
profiling	2.049 ms [2.031 ms, 2.067 ms]	859.863 µs (72.3%)
tracing	1.82 ms [1.805 ms, 1.836 ms]	631.173 µs (53.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.199 ms [1.187 ms, 1.211 ms]	-
iast	3.127 ms [3.089 ms, 3.166 ms]	1.928 ms (160.8%)
iast_FULL	5.76 ms [5.702 ms, 5.817 ms]	4.561 ms (380.3%)
iast_GLOBAL	3.739 ms [3.679 ms, 3.798 ms]	2.54 ms (211.8%)
profiling	2.189 ms [2.17 ms, 2.209 ms]	990.359 µs (82.6%)
tracing	1.784 ms [1.768 ms, 1.8 ms]	584.901 µs (48.8%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/avoid-afterEvaluate-in-instrumentation
git_commit_date	1766071645	1766078043
git_commit_sha	`6ccbc06`	`243cc8f`
release_version	1.58.0-SNAPSHOT~6ccbc0607e	1.58.0-SNAPSHOT~243cc8f840

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1766080195	1766080195
ci_job_id	1307076355	1307076355
ci_pipeline_id	87613305	87613305
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-jmxytfqf 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-jmxytfqf 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~243cc8f840, baseline=1.58.0-SNAPSHOT~6ccbc0607e
dateFormat X
axisFormat %s
section baseline
no_agent (14.989 s) : 14989000, 14989000
. : milestone, 14989000,
appsec (14.914 s) : 14914000, 14914000
. : milestone, 14914000,
iast (17.981 s) : 17981000, 17981000
. : milestone, 17981000,
iast_GLOBAL (17.736 s) : 17736000, 17736000
. : milestone, 17736000,
profiling (15.103 s) : 15103000, 15103000
. : milestone, 15103000,
tracing (14.71 s) : 14710000, 14710000
. : milestone, 14710000,
section candidate
no_agent (15.011 s) : 15011000, 15011000
. : milestone, 15011000,
appsec (14.671 s) : 14671000, 14671000
. : milestone, 14671000,
iast (18.428 s) : 18428000, 18428000
. : milestone, 18428000,
iast_GLOBAL (17.918 s) : 17918000, 17918000
. : milestone, 17918000,
profiling (14.847 s) : 14847000, 14847000
. : milestone, 14847000,
tracing (14.768 s) : 14768000, 14768000
. : milestone, 14768000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.989 s [14.989 s, 14.989 s]	-
appsec	14.914 s [14.914 s, 14.914 s]	-75.0 ms (-0.5%)
iast	17.981 s [17.981 s, 17.981 s]	2.992 s (20.0%)
iast_GLOBAL	17.736 s [17.736 s, 17.736 s]	2.747 s (18.3%)
profiling	15.103 s [15.103 s, 15.103 s]	114.0 ms (0.8%)
tracing	14.71 s [14.71 s, 14.71 s]	-279.0 ms (-1.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.011 s [15.011 s, 15.011 s]	-
appsec	14.671 s [14.671 s, 14.671 s]	-340.0 ms (-2.3%)
iast	18.428 s [18.428 s, 18.428 s]	3.417 s (22.8%)
iast_GLOBAL	17.918 s [17.918 s, 17.918 s]	2.907 s (19.4%)
profiling	14.847 s [14.847 s, 14.847 s]	-164.0 ms (-1.1%)
tracing	14.768 s [14.768 s, 14.768 s]	-243.0 ms (-1.6%)

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~243cc8f840, baseline=1.58.0-SNAPSHOT~6ccbc0607e
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.726 ms) : 3508, 3943
. : milestone, 3726,
iast (2.224 ms) : 2159, 2289
. : milestone, 2224,
iast_GLOBAL (2.266 ms) : 2201, 2331
. : milestone, 2266,
profiling (2.081 ms) : 2028, 2134
. : milestone, 2081,
tracing (2.052 ms) : 2001, 2103
. : milestone, 2052,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.744 ms) : 3524, 3964
. : milestone, 3744,
iast (2.217 ms) : 2152, 2282
. : milestone, 2217,
iast_GLOBAL (2.272 ms) : 2207, 2337
. : milestone, 2272,
profiling (2.085 ms) : 2031, 2139
. : milestone, 2085,
tracing (2.038 ms) : 1987, 2090
. : milestone, 2038,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.461 ms, 1.484 ms]	-
appsec	3.726 ms [3.508 ms, 3.943 ms]	2.253 ms (153.0%)
iast	2.224 ms [2.159 ms, 2.289 ms]	750.974 µs (51.0%)
iast_GLOBAL	2.266 ms [2.201 ms, 2.331 ms]	793.194 µs (53.9%)
profiling	2.081 ms [2.028 ms, 2.134 ms]	608.043 µs (41.3%)
tracing	2.052 ms [2.001 ms, 2.103 ms]	579.24 µs (39.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.462 ms, 1.485 ms]	-
appsec	3.744 ms [3.524 ms, 3.964 ms]	2.27 ms (154.0%)
iast	2.217 ms [2.152 ms, 2.282 ms]	743.145 µs (50.4%)
iast_GLOBAL	2.272 ms [2.207 ms, 2.337 ms]	797.916 µs (54.1%)
profiling	2.085 ms [2.031 ms, 2.139 ms]	610.626 µs (41.4%)
tracing	2.038 ms [1.987 ms, 2.09 ms]	564.447 µs (38.3%)

# Conflicts: # dd-java-agent/instrumentation/build.gradle # Conflicts: # dd-java-agent/instrumentation/build.gradle # Conflicts: # dd-java-agent/instrumentation/build.gradle

sarahchen6

Cool!

This reverts commit 3428502.

bric3 requested a review from a team as a code owner October 14, 2025 14:57

bric3 added type: feature Enhancements and improvements tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Oct 14, 2025

bric3 marked this pull request as draft October 14, 2025 15:05

bric3 force-pushed the bdu/avoid-afterEvaluate-in-instrumentation branch from d930307 to ff71451Compare November 12, 2025 17:58

This comment has been minimized.
Sign in to view

bric3 force-pushed the bdu/avoid-afterEvaluate-in-instrumentation branch 2 times, most recently from 5388f6d to 4835e7bCompare November 13, 2025 12:28

bric3 mentioned this pull request Nov 17, 2025
CSI plugin use too much configuration classpath #9955
Merged

bric3 force-pushed the bdu/avoid-afterEvaluate-in-instrumentation branch from 4835e7b to bd9e60cCompare November 20, 2025 09:29

This was referenced Dec 5, 2025
Rewrite build-time instrumentation as compilation post-processor (using Gradle lazy APIs) #9475
Merged
Refactored InstrumentPlugin from Groovy to Kotlin. #10086
Closed

bric3 force-pushed the bdu/avoid-afterEvaluate-in-instrumentation branch from bd9e60c to a83b867Compare December 15, 2025 18:31

bric3 temporarily deployed to ci-build December 15, 2025 18:31 — with GitHub Actions Inactive

bric3 temporarily deployed to ci-build December 15, 2025 20:42 — with GitHub Actions Inactive

bric3 force-pushed the bdu/avoid-afterEvaluate-in-instrumentation branch from f458fa4 to aec23b1Compare December 15, 2025 21:17

bric3 temporarily deployed to ci-build December 15, 2025 21:17 — with GitHub Actions Inactive

bric3 temporarily deployed to ci-build December 15, 2025 21:46 — with GitHub Actions Inactive

bric3 force-pushed the bdu/avoid-afterEvaluate-in-instrumentation branch from 6357293 to 745c9e4Compare December 15, 2025 23:37

bric3 temporarily deployed to ci-build December 15, 2025 23:37 — with GitHub Actions Inactive

bric3 force-pushed the bdu/avoid-afterEvaluate-in-instrumentation branch from 745c9e4 to 248eb0bCompare December 16, 2025 00:11

bric3 temporarily deployed to ci-build December 16, 2025 00:11 — with GitHub Actions Inactive

bric3 temporarily deployed to ci-build December 16, 2025 06:52 — with GitHub Actions Inactive

bric3 temporarily deployed to ci-build December 16, 2025 17:50 — with GitHub Actions Inactive

bric3 temporarily deployed to ci-build December 16, 2025 20:19 — with GitHub Actions Inactive

bric3 temporarily deployed to ci-build December 16, 2025 22:14 — with GitHub Actions Inactive

bric3 mentioned this pull request Dec 18, 2025
Jetty leaking out of :dd-java-agent:testing#10218
Merged

bric3 force-pushed the bdu/avoid-afterEvaluate-in-instrumentation branch from 0aaa955 to 5586082Compare December 18, 2025 13:35

bric3 temporarily deployed to ci-build December 18, 2025 13:35 — with GitHub Actions Inactive

bric3 marked this pull request as ready for review December 18, 2025 17:12

chore: Remove instrumentation afterEvaluate
243cc8f
# Conflicts: # dd-java-agent/instrumentation/build.gradle # Conflicts: # dd-java-agent/instrumentation/build.gradle # Conflicts: # dd-java-agent/instrumentation/build.gradle

bric3 force-pushed the bdu/avoid-afterEvaluate-in-instrumentation branch from 5586082 to 243cc8fCompare December 18, 2025 17:14

bric3 temporarily deployed to ci-build December 18, 2025 17:14 — with GitHub Actions Inactive

sarahchen6 approved these changes Dec 18, 2025
View reviewed changes

bric3 merged commit 3428502 into masterDec 18, 2025
559 checks passed

bric3 deleted the bdu/avoid-afterEvaluate-in-instrumentation branch December 18, 2025 19:52

github-actionsBot added this to the 1.58.0 milestone Dec 18, 2025

amarziali added a commit that referenced this pull request Jan 13, 2026
Revert "chore: Remove instrumentationafterEvaluate(#9752)"
a8ef803
This reverts commit 3428502.

Navigation Menu

Uh oh!

Remove instrumentation `afterEvaluate` - #9752

Remove instrumentation `afterEvaluate`#9752
bric3 merged 1 commit into
masterfrom
bdu/avoid-afterEvaluate-in-instrumentation

bric3 commented Oct 14, 2025•
edited
Loading

Uh oh!

This comment has been minimized.

pr-commenterBot commented Nov 12, 2025•
edited
Loading

Uh oh!

sarahchen6 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

bric3 commented Oct 14, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

This comment has been minimized.

pr-commenterBot commented Nov 12, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

sarahchen6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bric3 commented Oct 14, 2025•
edited
Loading

pr-commenterBot commented Nov 12, 2025•
edited
Loading