Skip to content

Migrate version.gradle script plugin to Kotlin convention plugin - #11345

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits into
masterfrom
bdu/gradle9-write-version-convention-plugin
May 12, 2026
Merged

Migrate version.gradle script plugin to Kotlin convention plugin#11345
gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits into
masterfrom
bdu/gradle9-write-version-convention-plugin

Conversation

@bric3

@bric3bric3 commented May 11, 2026

Copy link
Copy Markdown
Contributor

What does it do

Replaces the Groovy version.gradle script plugin with a convention plugin dd-trace-java.version-file.

There's 20 consumers they are now declarign it in plugins {} block (or apply plugin: where plugins {} is not available).

Adds tests for this plug-in.

Motivation

  1. Project.exec {} is removed in Gradle 9. It is also incompatible with the configuration cache.
  2. version.gradle is a Groovy script plugin, migrating to convention plugin is the way to go.

Additional Notes

Sub-PR of #10402, #11272.

@bric3bric3 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels May 11, 2026

@AlexeyKuznetsov-DDAlexeyKuznetsov-DD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more step in removing Groovy! Nice!

@bric3bric3 mentioned this pull request May 11, 2026
19 tasks
@bric3
bric3force-pushed the bdu/gradle9-write-version-convention-plugin branch from 6af14f7 to 930a06eCompareMay 11, 2026 16:26
* `Project.exec {}` is removed in Gradle 9. It is also incompatible with
the configuration cache.
* `gradle/version.gradle` is a Groovy script plugin, migrating to
a convention plugin is the way to go.
@bric3
bric3force-pushed the bdu/gradle9-write-version-convention-plugin branch from 930a06e to 72991c0CompareMay 11, 2026 16:57
@bric3
bric3 marked this pull request as ready for review May 11, 2026 16:58
@bric3
bric3 requested review from a team as code ownersMay 11, 2026 16:58
@bric3
bric3 requested review from claponcet, dd-oleksii, evanchooly, jandro996, leoromanovsky and mcculls and removed request for a teamMay 11, 2026 16:58
@bric3bric3 changed the title Migrate version.gradle script plugin to Kotlin convention pluginMigrate version.gradle script plugin to Kotlin convention pluginMay 11, 2026
@pr-commenter

pr-commenterBot commented May 11, 2026

Copy link
Copy Markdown

Debugger benchmarks

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
ci_job_date17785903521778590701
end_time2026-05-12T12:54:022026-05-12T12:59:52
git_branchmasterbdu/gradle9-write-version-convention-plugin
git_commit_sha710ca876ee8709
start_time2026-05-12T12:52:332026-05-12T12:58:22
See matching parameters
BaselineCandidate
ci_job_id16756982561675698256
ci_pipeline_id112691016112691016
cpu_modelIntel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
git_commit_date17785898161778589816

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenarioΔ mean agg_http_req_duration_minΔ mean agg_http_req_duration_p50Δ mean agg_http_req_duration_p75Δ mean agg_http_req_duration_p99Δ mean throughput
scenario:noprobeunstable
[-26.531µs; +22.297µs] or [-8.493%; +7.138%]
unstable
[-40.070µs; +34.891µs] or [-11.182%; +9.737%]
unstable
[-52.266µs; +43.611µs] or [-13.886%; +11.587%]
unstable
[-216.874µs; +118.264µs] or [-16.583%; +9.043%]
same
scenario:basicsamesamesameunstable
[-46.076µs; +77.824µs] or [-4.276%; +7.223%]
unstable
[-151.601op/s; +151.601op/s] or [-6.367%; +6.367%]
scenario:loopunsure
[-8.767µs; -1.388µs] or [-0.098%; -0.016%]
samesamesamesame
Request duration reports for reports
gantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (358.348 µs) : 316, 400
. : milestone, 358,
basic (312.499 µs) : 304, 321
. : milestone, 312,
loop (9.011 ms) : 9003, 9018
. : milestone, 9011,
section candidate
noprobe (355.759 µs) : 328, 384
. : milestone, 356,
basic (310.265 µs) : 302, 318
. : milestone, 310,
loop (9.015 ms) : 9007, 9022
. : milestone, 9015,
Loading
  • baseline results
ScenarioRequest median duration [CI 0.99]
noprobe358.348 µs [316.48 µs, 400.217 µs]
basic312.499 µs [303.594 µs, 321.404 µs]
loop9.011 ms [9.003 ms, 9.018 ms]
  • candidate results
ScenarioRequest median duration [CI 0.99]
noprobe355.759 µs [327.824 µs, 383.693 µs]
basic310.265 µs [302.462 µs, 318.067 µs]
loop9.015 ms [9.007 ms, 9.022 ms]

@sarahchen6sarahchen6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bric3

Copy link
Copy Markdown
ContributorAuthor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351Bot commented May 12, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-05-12 14:32:04 UTC ℹ️ Start processing command /merge


2026-05-12 14:32:12 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-05-12 15:08:09 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-05-12 16:26:04 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot merged commit fc39960 into masterMay 12, 2026
577 of 579 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot deleted the bdu/gradle9-write-version-convention-plugin branch May 12, 2026 16:26
@github-actionsgithub-actionsBot added this to the 1.63.0 milestone May 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: toolingBuild & Toolingtag: no release notesChanges to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@bric3@mcculls@evanchooly@jpbempel@sarahchen6@daniel-mohedano@AlexeyKuznetsov-DD