Skip to content

Normalize generated version file for classpath inputs - #11651

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bdu/normalize-version-file-classpath
Jun 16, 2026
Merged

Normalize generated version file for classpath inputs#11651
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bdu/normalize-version-file-classpath

Conversation

@bric3

@bric3bric3 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Configures the version-file convention plugin to ignore its generated <project>.version resource during runtime classpath input normalization.

This keeps the changing versioon file from invalidating @Classpath inputs. CodeNarc for example makes use of it, and as such is affected when the file changes.

https://docs.gradle.org/current/userguide/build_cache_concepts.html#runtime_classpath_normalization

On second run now, codenarc should be up to date, for example ./gradlew :dd-trace-core:codenarcTest --info should show the following

:dd-trace-core:writeVersionNumberFile executed
:dd-trace-core:processResources executed
:dd-trace-core:jar UP-TO-DATE
:dd-trace-core:codenarcTest UP-TO-DATE

Motivation

The generated version resource includes commit short hash. When it appears on classpath inputs, tasks that do not depend on that metadata can rerun unnecessarily after a commit changes.

The issue was likely introduced by #11345 and as such constitute a follow-up to that work.

Additional Notes

Another strategy is possible: on CI keep today's behavior, but on local machine, use a stable marker.

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@datadog-datadog-prod-us1

datadog-datadog-prod-us1Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

Check pull requests | Check pull requests View in DatadogGitHub Actions

DataDog/apm-reliability/dd-trace-java | linux-java-spring-petclinic-sca-load-parallel View in DatadogGitLab

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2714be3 | Docs | Datadog PR Page | Give us feedback!

@bric3
bric3 marked this pull request as ready for review June 15, 2026 19:25
@bric3
bric3 requested a review from a team as a code ownerJune 15, 2026 19:25
@bric3
bric3 requested a review from dougqhJune 15, 2026 19:25
@dd-octo-sts

dd-octo-stsBot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@bric3bric3 added tag: performance Performance related changes tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jun 15, 2026
@bric3bric3 changed the title Normalize generated version metadata in classpath inputsNormalize generated version file for classpath inputsJun 15, 2026

@AlexeyKuznetsov-DDAlexeyKuznetsov-DD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Left minor comment.

@bric3

Copy link
Copy Markdown
ContributorAuthor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351Bot commented Jun 16, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-16 07:41:04 UTC ℹ️ Start processing command /merge


2026-06-16 07:41:09 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-06-16 09:11:04 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot merged commit 82ced12 into masterJun 16, 2026
791 of 801 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot deleted the bdu/normalize-version-file-classpath branch June 16, 2026 09:11
@github-actionsgithub-actionsBot added this to the 1.64.0 milestone Jun 16, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: toolingBuild & Toolingtag: no release notesChanges to exclude from release notestag: performancePerformance related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bric3@AlexeyKuznetsov-DD