Uh oh!
There was an error while loading. Please reload this page.
Proposal for checking instrumentation/framework versions - #19
Conversation
Add thread name and id to each span as additional tags.
gpolaert
commented
Jun 26, 2017
@tylerbenson It's working :) but could you give me your feedback. I'm not very confident using static methods |
tylerbenson
left a comment
There was a problem hiding this comment.
I think this PR would have been nicer if the version checking was separated from the JMS support.
| # Instrument Elasticsearch Transport Client | ||
| # ========================================== | ||
| RULE elasticsearch | ||
| RULE opentracing-elasticsearch-client |
There was a problem hiding this comment.
Since these names are used in the config to allow customers to disable instrumentation, I think it would be good to document the list of names, or update the documentation to explain how to find the name needed.
tylerbenson
left a comment
There was a problem hiding this comment.
Looks like this diff is mostly confusing because of the differences with the branch it was based on. It might be cleaned up with rebasing, but no big deal.
No description provided.