Improve ASM support in vert.x 5.0 by manuel-alvarez-alvarez · Pull Request #8285 · DataDog/dd-trace-java

manuel-alvarez-alvarez · 2025-01-27T08:30:39Z

What Does This Do

This PR takes care of all the failing tests for ASM with the latest versions of vert.x, it limits the latest deps tests to v4.x in vertx-web-4.0 and creates a new module for v5.x in vertx-web-5.0. The new v5.x module relies in v4.x for most of the instrumentations and only takes care of the changed APIs (e.g. io.vertx.core.buffer.Buffer)

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APPSEC-56368

pr-commenter · 2025-01-27T09:13:43Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/asm-vertx-5
git_commit_date	1738578316	1738596373
git_commit_sha	`9af5347`	`89632ae`
release_version	1.47.0-SNAPSHOT~9af5347cda	1.47.0-SNAPSHOT~89632aeb4e

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1738598953	1738598953
ci_job_id	791449177	791449177
ci_pipeline_id	54727810	54727810
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-kmuzcns6-project-304-concurrent-0-edetodj6 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-kmuzcns6-project-304-concurrent-0-edetodj6 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~89632aeb4e, baseline=1.47.0-SNAPSHOT~9af5347cda
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050760
Total [baseline] (10.471 s) : 0, 10471296
Agent [candidate] (1.048 s) : 0, 1047926
Total [candidate] (10.467 s) : 0, 10467399
section appsec
Agent [baseline] (1.19 s) : 0, 1189795
Total [baseline] (10.783 s) : 0, 10783106
Agent [candidate] (1.185 s) : 0, 1185167
Total [candidate] (10.765 s) : 0, 10764901
section iast
Agent [baseline] (1.174 s) : 0, 1174452
Total [baseline] (10.95 s) : 0, 10949727
Agent [candidate] (1.183 s) : 0, 1182565
Total [candidate] (11.003 s) : 0, 11002865
section profiling
Agent [baseline] (1.274 s) : 0, 1274422
Total [baseline] (10.922 s) : 0, 10921700
Agent [candidate] (1.27 s) : 0, 1270462
Total [candidate] (10.906 s) : 0, 10906271

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.051 s	-
Agent	appsec	1.19 s	139.034 ms (13.2%)
Agent	iast	1.174 s	123.692 ms (11.8%)
Agent	profiling	1.274 s	223.662 ms (21.3%)
Total	tracing	10.471 s	-
Total	appsec	10.783 s	311.809 ms (3.0%)
Total	iast	10.95 s	478.43 ms (4.6%)
Total	profiling	10.922 s	450.403 ms (4.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	appsec	1.185 s	137.241 ms (13.1%)
Agent	iast	1.183 s	134.639 ms (12.8%)
Agent	profiling	1.27 s	222.536 ms (21.2%)
Total	tracing	10.467 s	-
Total	appsec	10.765 s	297.502 ms (2.8%)
Total	iast	11.003 s	535.466 ms (5.1%)
Total	profiling	10.906 s	438.871 ms (4.2%)

gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~89632aeb4e, baseline=1.47.0-SNAPSHOT~9af5347cda
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.971 ms) : 0, 720971
BytebuddyAgent [candidate] (720.49 ms) : 0, 720490
GlobalTracer [baseline] (244.974 ms) : 0, 244974
GlobalTracer [candidate] (245.565 ms) : 0, 245565
AppSec [baseline] (55.656 ms) : 0, 55656
AppSec [candidate] (55.677 ms) : 0, 55677
Remote Config [baseline] (728.319 µs) : 0, 728
Remote Config [candidate] (725.226 µs) : 0, 725
Telemetry [baseline] (13.085 ms) : 0, 13085
Telemetry [candidate] (10.137 ms) : 0, 10137
section appsec
BytebuddyAgent [baseline] (735.429 ms) : 0, 735429
BytebuddyAgent [candidate] (733.387 ms) : 0, 733387
GlobalTracer [baseline] (242.262 ms) : 0, 242262
GlobalTracer [candidate] (240.762 ms) : 0, 240762
IAST [baseline] (21.606 ms) : 0, 21606
IAST [candidate] (21.525 ms) : 0, 21525
AppSec [baseline] (177.007 ms) : 0, 177007
AppSec [candidate] (176.037 ms) : 0, 176037
Remote Config [baseline] (662.261 µs) : 0, 662
Remote Config [candidate] (671.028 µs) : 0, 671
Telemetry [baseline] (8.312 ms) : 0, 8312
Telemetry [candidate] (8.312 ms) : 0, 8312
section iast
BytebuddyAgent [baseline] (835.147 ms) : 0, 835147
BytebuddyAgent [candidate] (841.588 ms) : 0, 841588
GlobalTracer [baseline] (235.012 ms) : 0, 235012
GlobalTracer [candidate] (235.855 ms) : 0, 235855
IAST [baseline] (24.764 ms) : 0, 24764
IAST [candidate] (24.209 ms) : 0, 24209
AppSec [baseline] (54.789 ms) : 0, 54789
AppSec [candidate] (56.192 ms) : 0, 56192
Remote Config [baseline] (629.874 µs) : 0, 630
Remote Config [candidate] (638.088 µs) : 0, 638
Telemetry [baseline] (8.791 ms) : 0, 8791
Telemetry [candidate] (8.738 ms) : 0, 8738
section profiling
BytebuddyAgent [baseline] (714.162 ms) : 0, 714162
BytebuddyAgent [candidate] (711.185 ms) : 0, 711185
GlobalTracer [baseline] (355.505 ms) : 0, 355505
GlobalTracer [candidate] (355.819 ms) : 0, 355819
AppSec [baseline] (55.349 ms) : 0, 55349
AppSec [candidate] (54.575 ms) : 0, 54575
Remote Config [baseline] (702.33 µs) : 0, 702
Remote Config [candidate] (714.038 µs) : 0, 714
Telemetry [baseline] (8.972 ms) : 0, 8972
Telemetry [candidate] (8.991 ms) : 0, 8991
ProfilingAgent [baseline] (96.804 ms) : 0, 96804
ProfilingAgent [candidate] (96.528 ms) : 0, 96528
Profiling [baseline] (96.827 ms) : 0, 96827
Profiling [candidate] (96.552 ms) : 0, 96552

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~89632aeb4e, baseline=1.47.0-SNAPSHOT~9af5347cda
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046585
Total [baseline] (8.708 s) : 0, 8708122
Agent [candidate] (1.043 s) : 0, 1042836
Total [candidate] (8.68 s) : 0, 8679615
section iast
Agent [baseline] (1.17 s) : 0, 1169810
Total [baseline] (9.265 s) : 0, 9264741
Agent [candidate] (1.183 s) : 0, 1182907
Total [candidate] (9.256 s) : 0, 9256158
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.18 s) : 0, 1180485
Total [baseline] (9.234 s) : 0, 9234227
Agent [candidate] (1.187 s) : 0, 1186619
Total [candidate] (9.238 s) : 0, 9237679
section iast_TELEMETRY_OFF
Agent [baseline] (1.179 s) : 0, 1178963
Total [baseline] (9.309 s) : 0, 9309205
Agent [candidate] (1.173 s) : 0, 1173324
Total [candidate] (9.279 s) : 0, 9279257

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.047 s	-
Agent	iast	1.17 s	123.225 ms (11.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.18 s	133.9 ms (12.8%)
Agent	iast_TELEMETRY_OFF	1.179 s	132.378 ms (12.6%)
Total	tracing	8.708 s	-
Total	iast	9.265 s	556.619 ms (6.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.234 s	526.104 ms (6.0%)
Total	iast_TELEMETRY_OFF	9.309 s	601.082 ms (6.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.043 s	-
Agent	iast	1.183 s	140.071 ms (13.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.187 s	143.782 ms (13.8%)
Agent	iast_TELEMETRY_OFF	1.173 s	130.488 ms (12.5%)
Total	tracing	8.68 s	-
Total	iast	9.256 s	576.543 ms (6.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.238 s	558.063 ms (6.4%)
Total	iast_TELEMETRY_OFF	9.279 s	599.642 ms (6.9%)

gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~89632aeb4e, baseline=1.47.0-SNAPSHOT~9af5347cda
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.957 ms) : 0, 718957
BytebuddyAgent [candidate] (715.549 ms) : 0, 715549
GlobalTracer [baseline] (244.452 ms) : 0, 244452
GlobalTracer [candidate] (243.375 ms) : 0, 243375
AppSec [baseline] (55.553 ms) : 0, 55553
AppSec [candidate] (55.606 ms) : 0, 55606
Remote Config [baseline] (724.65 µs) : 0, 725
Remote Config [candidate] (717.638 µs) : 0, 718
Telemetry [baseline] (11.579 ms) : 0, 11579
Telemetry [candidate] (12.302 ms) : 0, 12302
section iast
BytebuddyAgent [baseline] (832.661 ms) : 0, 832661
BytebuddyAgent [candidate] (841.622 ms) : 0, 841622
GlobalTracer [baseline] (233.283 ms) : 0, 233283
GlobalTracer [candidate] (235.939 ms) : 0, 235939
IAST [baseline] (26.51 ms) : 0, 26510
IAST [candidate] (25.217 ms) : 0, 25217
AppSec [baseline] (52.793 ms) : 0, 52793
AppSec [candidate] (55.078 ms) : 0, 55078
Remote Config [baseline] (608.836 µs) : 0, 609
Remote Config [candidate] (622.438 µs) : 0, 622
Telemetry [baseline] (8.635 ms) : 0, 8635
Telemetry [candidate] (8.775 ms) : 0, 8775
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (839.754 ms) : 0, 839754
BytebuddyAgent [candidate] (845.285 ms) : 0, 845285
GlobalTracer [baseline] (235.335 ms) : 0, 235335
GlobalTracer [candidate] (235.623 ms) : 0, 235623
IAST [baseline] (26.899 ms) : 0, 26899
IAST [candidate] (25.422 ms) : 0, 25422
AppSec [baseline] (53.638 ms) : 0, 53638
AppSec [candidate] (55.382 ms) : 0, 55382
Remote Config [baseline] (626.685 µs) : 0, 627
Remote Config [candidate] (637.128 µs) : 0, 637
Telemetry [baseline] (8.856 ms) : 0, 8856
Telemetry [candidate] (8.838 ms) : 0, 8838
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (838.374 ms) : 0, 838374
BytebuddyAgent [candidate] (833.924 ms) : 0, 833924
GlobalTracer [baseline] (236.7 ms) : 0, 236700
GlobalTracer [candidate] (235.405 ms) : 0, 235405
IAST [baseline] (27.72 ms) : 0, 27720
IAST [candidate] (26.207 ms) : 0, 26207
AppSec [baseline] (51.524 ms) : 0, 51524
AppSec [candidate] (53.197 ms) : 0, 53197
Remote Config [baseline] (608.244 µs) : 0, 608
Remote Config [candidate] (618.184 µs) : 0, 618
Telemetry [baseline] (8.632 ms) : 0, 8632
Telemetry [candidate] (8.649 ms) : 0, 8649

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-02-03T15:41:01	2025-02-03T15:48:05
git_branch	master	malvarez/asm-vertx-5
git_commit_date	1738578316	1738596373
git_commit_sha	`9af5347`	`89632ae`
release_version	1.47.0-SNAPSHOT~9af5347cda	1.47.0-SNAPSHOT~89632aeb4e
start_time	2025-02-03T15:40:47	2025-02-03T15:47:51

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1738598042	1738598042
ci_job_id	791449178	791449178
ci_pipeline_id	54727810	54727810
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-rzaamrpw-project-304-concurrent-0-v8jairng 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-rzaamrpw-project-304-concurrent-0-v8jairng 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~89632aeb4e, baseline=1.47.0-SNAPSHOT~9af5347cda
dateFormat X
axisFormat %s
section baseline
no_agent (1.346 ms) : 1326, 1366
. : milestone, 1346,
appsec (1.742 ms) : 1719, 1765
. : milestone, 1742,
appsec_no_iast (1.764 ms) : 1742, 1787
. : milestone, 1764,
iast (1.509 ms) : 1485, 1532
. : milestone, 1509,
profiling (1.531 ms) : 1507, 1556
. : milestone, 1531,
tracing (1.5 ms) : 1475, 1526
. : milestone, 1500,
section candidate
no_agent (1.356 ms) : 1337, 1376
. : milestone, 1356,
appsec (1.738 ms) : 1714, 1761
. : milestone, 1738,
appsec_no_iast (1.749 ms) : 1724, 1773
. : milestone, 1749,
iast (1.482 ms) : 1458, 1507
. : milestone, 1482,
profiling (1.556 ms) : 1531, 1582
. : milestone, 1556,
tracing (1.49 ms) : 1467, 1514
. : milestone, 1490,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.346 ms [1.326 ms, 1.366 ms]	-
appsec	1.742 ms [1.719 ms, 1.765 ms]	395.893 µs (29.4%)
appsec_no_iast	1.764 ms [1.742 ms, 1.787 ms]	418.456 µs (31.1%)
iast	1.509 ms [1.485 ms, 1.532 ms]	162.709 µs (12.1%)
profiling	1.531 ms [1.507 ms, 1.556 ms]	185.437 µs (13.8%)
tracing	1.5 ms [1.475 ms, 1.526 ms]	154.119 µs (11.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.356 ms [1.337 ms, 1.376 ms]	-
appsec	1.738 ms [1.714 ms, 1.761 ms]	381.442 µs (28.1%)
appsec_no_iast	1.749 ms [1.724 ms, 1.773 ms]	392.329 µs (28.9%)
iast	1.482 ms [1.458 ms, 1.507 ms]	126.278 µs (9.3%)
profiling	1.556 ms [1.531 ms, 1.582 ms]	200.135 µs (14.8%)
tracing	1.49 ms [1.467 ms, 1.514 ms]	134.101 µs (9.9%)

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~89632aeb4e, baseline=1.47.0-SNAPSHOT~9af5347cda
dateFormat X
axisFormat %s
section baseline
no_agent (379.922 µs) : 360, 399
. : milestone, 380,
iast (503.138 µs) : 481, 525
. : milestone, 503,
iast_FULL (740.718 µs) : 719, 763
. : milestone, 741,
iast_GLOBAL (556.139 µs) : 533, 579
. : milestone, 556,
iast_HARDCODED_SECRET_DISABLED (507.427 µs) : 486, 529
. : milestone, 507,
iast_INACTIVE (459.938 µs) : 438, 481
. : milestone, 460,
iast_TELEMETRY_OFF (501.001 µs) : 478, 524
. : milestone, 501,
tracing (448.598 µs) : 428, 469
. : milestone, 449,
section candidate
no_agent (373.188 µs) : 353, 393
. : milestone, 373,
iast (501.356 µs) : 480, 523
. : milestone, 501,
iast_FULL (738.753 µs) : 717, 761
. : milestone, 739,
iast_GLOBAL (555.106 µs) : 532, 578
. : milestone, 555,
iast_HARDCODED_SECRET_DISABLED (499.403 µs) : 478, 521
. : milestone, 499,
iast_INACTIVE (453.09 µs) : 432, 474
. : milestone, 453,
iast_TELEMETRY_OFF (493.464 µs) : 471, 516
. : milestone, 493,
tracing (450.805 µs) : 430, 472
. : milestone, 451,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	379.922 µs [360.376 µs, 399.469 µs]	-
iast	503.138 µs [481.251 µs, 525.025 µs]	123.216 µs (32.4%)
iast_FULL	740.718 µs [718.705 µs, 762.731 µs]	360.795 µs (95.0%)
iast_GLOBAL	556.139 µs [533.457 µs, 578.82 µs]	176.216 µs (46.4%)
iast_HARDCODED_SECRET_DISABLED	507.427 µs [485.796 µs, 529.057 µs]	127.504 µs (33.6%)
iast_INACTIVE	459.938 µs [438.386 µs, 481.49 µs]	80.015 µs (21.1%)
iast_TELEMETRY_OFF	501.001 µs [478.093 µs, 523.908 µs]	121.078 µs (31.9%)
tracing	448.598 µs [427.815 µs, 469.382 µs]	68.676 µs (18.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	373.188 µs [353.031 µs, 393.345 µs]	-
iast	501.356 µs [479.554 µs, 523.159 µs]	128.168 µs (34.3%)
iast_FULL	738.753 µs [716.928 µs, 760.578 µs]	365.565 µs (98.0%)
iast_GLOBAL	555.106 µs [532.408 µs, 577.803 µs]	181.918 µs (48.7%)
iast_HARDCODED_SECRET_DISABLED	499.403 µs [478.195 µs, 520.611 µs]	126.215 µs (33.8%)
iast_INACTIVE	453.09 µs [432.124 µs, 474.056 µs]	79.902 µs (21.4%)
iast_TELEMETRY_OFF	493.464 µs [471.2 µs, 515.727 µs]	120.276 µs (32.2%)
tracing	450.805 µs [429.693 µs, 471.916 µs]	77.617 µs (20.8%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/asm-vertx-5
git_commit_date	1738578316	1738596373
git_commit_sha	`9af5347`	`89632ae`
release_version	1.47.0-SNAPSHOT~9af5347cda	1.47.0-SNAPSHOT~89632aeb4e

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1738598622	1738598622
ci_job_id	791449179	791449179
ci_pipeline_id	54727810	54727810
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-rzaamrpw-project-304-concurrent-1-wyzzpt2e 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-rzaamrpw-project-304-concurrent-1-wyzzpt2e 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~89632aeb4e, baseline=1.47.0-SNAPSHOT~9af5347cda
dateFormat X
axisFormat %s
section baseline
no_agent (14.747 s) : 14747000, 14747000
. : milestone, 14747000,
appsec (14.965 s) : 14965000, 14965000
. : milestone, 14965000,
iast (18.471 s) : 18471000, 18471000
. : milestone, 18471000,
iast_GLOBAL (18.15 s) : 18150000, 18150000
. : milestone, 18150000,
profiling (15.224 s) : 15224000, 15224000
. : milestone, 15224000,
tracing (14.641 s) : 14641000, 14641000
. : milestone, 14641000,
section candidate
no_agent (15.43 s) : 15430000, 15430000
. : milestone, 15430000,
appsec (14.828 s) : 14828000, 14828000
. : milestone, 14828000,
iast (18.98 s) : 18980000, 18980000
. : milestone, 18980000,
iast_GLOBAL (18.062 s) : 18062000, 18062000
. : milestone, 18062000,
profiling (14.989 s) : 14989000, 14989000
. : milestone, 14989000,
tracing (15.009 s) : 15009000, 15009000
. : milestone, 15009000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.747 s [14.747 s, 14.747 s]	-
appsec	14.965 s [14.965 s, 14.965 s]	218.0 ms (1.5%)
iast	18.471 s [18.471 s, 18.471 s]	3.724 s (25.3%)
iast_GLOBAL	18.15 s [18.15 s, 18.15 s]	3.403 s (23.1%)
profiling	15.224 s [15.224 s, 15.224 s]	477.0 ms (3.2%)
tracing	14.641 s [14.641 s, 14.641 s]	-106.0 ms (-0.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.43 s [15.43 s, 15.43 s]	-
appsec	14.828 s [14.828 s, 14.828 s]	-602.0 ms (-3.9%)
iast	18.98 s [18.98 s, 18.98 s]	3.55 s (23.0%)
iast_GLOBAL	18.062 s [18.062 s, 18.062 s]	2.632 s (17.1%)
profiling	14.989 s [14.989 s, 14.989 s]	-441.0 ms (-2.9%)
tracing	15.009 s [15.009 s, 15.009 s]	-421.0 ms (-2.7%)

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~89632aeb4e, baseline=1.47.0-SNAPSHOT~9af5347cda
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (2.372 ms) : 2328, 2415
. : milestone, 2372,
iast (2.117 ms) : 2062, 2173
. : milestone, 2117,
iast_GLOBAL (2.157 ms) : 2102, 2212
. : milestone, 2157,
profiling (1.995 ms) : 1950, 2039
. : milestone, 1995,
tracing (1.958 ms) : 1915, 2000
. : milestone, 1958,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.364 ms) : 2320, 2407
. : milestone, 2364,
iast (2.112 ms) : 2057, 2167
. : milestone, 2112,
iast_GLOBAL (2.158 ms) : 2103, 2213
. : milestone, 2158,
profiling (1.98 ms) : 1936, 2024
. : milestone, 1980,
tracing (1.952 ms) : 1910, 1994
. : milestone, 1952,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.459 ms, 1.482 ms]	-
appsec	2.372 ms [2.328 ms, 2.415 ms]	901.059 µs (61.3%)
iast	2.117 ms [2.062 ms, 2.173 ms]	646.801 µs (44.0%)
iast_GLOBAL	2.157 ms [2.102 ms, 2.212 ms]	686.229 µs (46.7%)
profiling	1.995 ms [1.95 ms, 2.039 ms]	524.095 µs (35.6%)
tracing	1.958 ms [1.915 ms, 2.0 ms]	487.156 µs (33.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.479 ms [1.468 ms, 1.491 ms]	-
appsec	2.364 ms [2.32 ms, 2.407 ms]	884.663 µs (59.8%)
iast	2.112 ms [2.057 ms, 2.167 ms]	632.998 µs (42.8%)
iast_GLOBAL	2.158 ms [2.103 ms, 2.213 ms]	679.074 µs (45.9%)
profiling	1.98 ms [1.936 ms, 2.024 ms]	500.353 µs (33.8%)
tracing	1.952 ms [1.91 ms, 1.994 ms]	472.776 µs (32.0%)

amarziali

LGTM. Thanks a lot!

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.0): 1.47.0 ##### Components ##### Application Security Management (IAST) - 🐛 Exclude com.stripe.net.HttpURLConnectionClient to solve IAST SSRF vulnerability false positives ([#8483](DataDog/dd-trace-java#8483) - [@jandro996](https://github.com/jandro996)) - 🐛 Add exclusion to solve IAST weak randomness vulnerability false positives ([#8462](DataDog/dd-trace-java#8462) - [@jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness false positive in Kafka client ([#8408](DataDog/dd-trace-java#8408) - [@smola](https://github.com/smola)) - ✨ Fix location for SSRF with Kong Unirest ([#8407](DataDog/dd-trace-java#8407) - [@smola](https://github.com/smola)) - ✨ Exclude IBM Instana from IAST ([#8406](DataDog/dd-trace-java#8406) - [@smola](https://github.com/smola)) - 🐛 Fix org.json iast instrumentation test for latest dependency ([#8347](DataDog/dd-trace-java#8347) - [@jandro996](https://github.com/jandro996)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) - ✨ Address cookie vulnerability cardinality issues ([#8210](DataDog/dd-trace-java#8210) - [@jandro996](https://github.com/jandro996)) - ✨ Email HTML Injection detection in IAST ([#8205](DataDog/dd-trace-java#8205) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Application Security Management (WAF) - 🐛✨ Ensure usr.exists tag is not overridden when UsernameNotFoundException is thrown ([#8376](DataDog/dd-trace-java#8376) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛✨ Ensure usr.exists tag is not overridden by auto instrumentation ([#8374](DataDog/dd-trace-java#8374) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update appsec metrics with event_rules_version tag ([#8354](DataDog/dd-trace-java#8354) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) - ✨ Improve ASM support in vert.x 5.0 ([#8285](DataDog/dd-trace-java#8285) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update metrics: appsec.waf.updates and appsec.waf.init ([#8280](DataDog/dd-trace-java#8280) - [@Mariovido](https://github.com/Mariovido)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 🐛 Do not generate Muzzle references for primitive arrays in method body ([#8361](DataDog/dd-trace-java#8361) - [@amarziali](https://github.com/amarziali)) - 📖 Improve dev env setup documentation for Windows ([#8180](DataDog/dd-trace-java#8180) - [@lucaspimentel](https://github.com/lucaspimentel)) ##### Continuous Integration Visibility - ✨ Add support for skip-EFD tagging ([#8487](DataDog/dd-trace-java#8487) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix an NPE in Gradle Android instrumentation ([#8484](DataDog/dd-trace-java#8484) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Consider modified tests when applying fail-fast tests ordering ([#8474](DataDog/dd-trace-java#8474) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests reordering for TestNG ([#8467](DataDog/dd-trace-java#8467) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Gradle Launcher instrumentation to not interfere with Gradle Test Kit ([#8465](DataDog/dd-trace-java#8465) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Use separate TestEventHandlers per framework in CI Vis instrumentations ([#8451](DataDog/dd-trace-java#8451) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Remove warning log when JUnit 4 test method cannot be retrieved ([#8445](DataDog/dd-trace-java#8445) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Scalatest tracing for tests that are reported asynchronously ([#8444](DataDog/dd-trace-java#8444) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement attempt to fix tests ([#8393](DataDog/dd-trace-java#8393) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement test disabling ([#8377](DataDog/dd-trace-java#8377) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update CODEOWNERS parser to not log errors on comments with leading whitespace ([#8349](DataDog/dd-trace-java#8349) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Request Test Management tests list ([#8345](DataDog/dd-trace-java#8345) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Receive test management settings from CIVis settings request ([#8331](DataDog/dd-trace-java#8331) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement quarantined tests tagging ([#8326](DataDog/dd-trace-java#8326) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests quarantining ([#8320](DataDog/dd-trace-java#8320) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tag to specify if the user is setting DD_SERVICE ([#8318](DataDog/dd-trace-java#8318) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Use Java home of the crashed process to launch crash uploader ([#8348](DataDog/dd-trace-java#8348) - [@jbachorik](https://github.com/jbachorik)) ##### Data Streams Monitoring - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix service name overrides in consumers ([#8387](DataDog/dd-trace-java#8387) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Database Monitoring - ✨ Add DBMTracePreparedStatements to tracer configuration log ([#8508](DataDog/dd-trace-java#8508) - [@cecile75](https://github.com/cecile75)) ##### Dynamic Instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix Exception Replay with Lambda proxy classes ([#8452](DataDog/dd-trace-java#8452) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add support for scanning jar from loaded class ([#8370](DataDog/dd-trace-java#8370) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Disable capture of entry values ([#8369](DataDog/dd-trace-java#8369) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix CodeOrigin for `@Trace` annotation ([#8344](DataDog/dd-trace-java#8344) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix equals/hashCode for CodeOrigin probe ([#8319](DataDog/dd-trace-java#8319) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### Metrics - ✨ Create metric: appsec.waf.error ([#8381](DataDog/dd-trace-java#8381) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Create metric: appsec.rasp.error ([#8364](DataDog/dd-trace-java#8364) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Profiling - ✨ Bump ddprof library to 1.22.0 ([#8463](DataDog/dd-trace-java#8463) - [@jbachorik](https://github.com/jbachorik)) - IBM J9 8u361 corresponds to OpenJDK 8u362 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#187 - Fix compatibility with musl libc 1.2.4 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#189 - Modify version extraction by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#179 - Do not write null values to jvminfo event by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#184 - Productize VMStructs-based stack walker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#177 - A few minor downport issues by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#180 - Enable ASGCT by default on fairly safe J9 JDK versions by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#181 - 🐛 Exclude OrderedThreadPoolExecutor from queue-time measurements ([#8456](DataDog/dd-trace-java#8456) - [@jbachorik](https://github.com/jbachorik)) - ✨ Record JVM info on JVMs without JFR ([#8431](DataDog/dd-trace-java#8431) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Actually use CleanupTask in TempLocationManager ([#8420](DataDog/dd-trace-java#8420) - [@mcculls](https://github.com/mcculls)) - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Adjust JFR checks for J9 ([#8405](DataDog/dd-trace-java#8405) - [@jbachorik](https://github.com/jbachorik)) - 🧹 Disable smap RSS parsing by default ([#8342](DataDog/dd-trace-java#8342) - [@MattAlp](https://github.com/MattAlp)) ##### Telemetry - 🐛 Add support for JBoss jar:file format to DependencyResolver ([#8428](DataDog/dd-trace-java#8428) - [@jandro996](https://github.com/jandro996)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) ##### Trace context propagation - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - 🐛 Fix Stable Config telemetry source names ([#8460](DataDog/dd-trace-java#8460) - [@BaptisteFoy](https://github.com/BaptisteFoy)) - ✨ Probe trace endpoints with a valid payload of empty arrays ([#8414](DataDog/dd-trace-java#8414) - [@mcculls](https://github.com/mcculls)) - ✨ Add 1 minute fail-safe to JUL/JMX class-loading callback ([#8399](DataDog/dd-trace-java#8399) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate DSM injection calls to context-first APIs ([#8383](DataDog/dd-trace-java#8383) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Move continuation capture methods from scope to tracer ([#8371](DataDog/dd-trace-java#8371) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate context extraction calls to context-first APIs ([#8368](DataDog/dd-trace-java#8368) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Migrate context injection calls to context-first APIs ([#8358](DataDog/dd-trace-java#8358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 💡 Support reading configurations from files ([#8338](DataDog/dd-trace-java#8338) - [@mtoffl01](https://github.com/mtoffl01)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - 🧹 Combine continuation implementations into one which supports multiple activations ([#8324](DataDog/dd-trace-java#8324) - [@mcculls](https://github.com/mcculls)) - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Remove old context propagation API ([#8271](DataDog/dd-trace-java#8271) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Instrumentations ##### AWS Lambda instrumentation - 🐛 Send error message and stack to Lambda extension ([#8417](DataDog/dd-trace-java#8417) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 💡 Inject trace context into AWS Step Functions input ([#7585](DataDog/dd-trace-java#7585) - [@DylanLovesCoffee](https://github.com/DylanLovesCoffee)) ##### Core Java language instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### gRPC instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) ##### Kafka instrumentation - ✨ Add messaging.destination.name tag to kafka integrations ([#8366](DataDog/dd-trace-java#8366) - [@rarguelloF](https://github.com/rarguelloF)) ##### Protocol Buffer instrumentation - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 108a0f86aa59ab4c938cbac0688dd4c19cb301fa

manuel-alvarez-alvarez added comp: asm waf Application Security Management (WAF) inst: vertx Eclipse Vert.x instrumentation type: feature Enhancements and improvements labels Jan 27, 2025

manuel-alvarez-alvarez force-pushed the malvarez/asm-vertx-5 branch 5 times, most recently from b5c2f12 to 3b6d1dcCompare January 28, 2025 09:46

manuel-alvarez-alvarez changed the title ~~Improve support for vert.x 5.0~~Improve ASM support in vert.x 5.0Jan 28, 2025

manuel-alvarez-alvarez force-pushed the malvarez/asm-vertx-5 branch from 3b6d1dc to ab39c74Compare January 29, 2025 08:49

manuel-alvarez-alvarez marked this pull request as ready for review January 29, 2025 10:21

manuel-alvarez-alvarez requested review from a team as code owners January 29, 2025 10:21

manuel-alvarez-alvarez requested review from amarziali, jandro996 and smola January 29, 2025 10:21

amarziali reviewed Jan 29, 2025
View reviewed changes

Comment threaddd-java-agent/instrumentation/vertx-web-5.0/build.gradle Outdated

amarziali approved these changes Jan 29, 2025
View reviewed changes

smola approved these changes Jan 31, 2025
View reviewed changes

manuel-alvarez-alvarez added 4 commits February 3, 2025 16:26

Fix failing ASM tests in vert.x 5.0
8ca3493

Remove max versions limits
9212120

Add comment to the call depth usage in vert.x
710b06e

Join routing context instrumentations again
89632ae

manuel-alvarez-alvarez force-pushed the malvarez/asm-vertx-5 branch from bd7e855 to 89632aeCompare February 3, 2025 15:30

manuel-alvarez-alvarez added type: feature Enhancements and improvements and removed type: feature Enhancements and improvements labels Feb 4, 2025

manuel-alvarez-alvarez merged commit eef31bc into masterFeb 4, 2025

manuel-alvarez-alvarez deleted the malvarez/asm-vertx-5 branch February 4, 2025 08:12

github-actionsBot added this to the 1.47.0 milestone Feb 4, 2025

Navigation Menu

Uh oh!

Improve ASM support in vert.x 5.0 - #8285

Improve ASM support in vert.x 5.0#8285
manuel-alvarez-alvarez merged 4 commits into
masterfrom
malvarez/asm-vertx-5

manuel-alvarez-alvarez commented Jan 27, 2025•
edited
Loading

Uh oh!

pr-commenterBot commented Jan 27, 2025•
edited
Loading

Uh oh!

Uh oh!

amarziali left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

manuel-alvarez-alvarez commented Jan 27, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenterBot commented Jan 27, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

amarziali left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

manuel-alvarez-alvarez commented Jan 27, 2025•
edited
Loading

pr-commenterBot commented Jan 27, 2025•
edited
Loading