Uh oh!
There was an error while loading. Please reload this page.
Apply component tag more consistently - #578
Merged
Merged
Conversation
tylerbensonforce-pushed
the
tyler/components
branch
from
November 14, 2018 19:31
f4577b0 to
cbb2906Comparemar-kolya
suggested changes
Nov 15, 2018
| tracer.buildSpan("aws.command").withTag(Tags.SPAN_KIND.getKey(), Tags.SPAN_KIND_CLIENT); | ||
| tracer | ||
| .buildSpan("aws.command") | ||
| .withTag(Tags.COMPONENT.getKey(), "aws-sdk") |
Contributor
There was a problem hiding this comment.
I think the there is no real point in setting this since it is always set few lines below in SpanDecorator.onRequest(request, span); call.
| parent() | ||
| tags { | ||
| "$DDTags.SPAN_TYPE" DDSpanTypes.COUCHBASE | ||
| "$Tags.COMPONENT.key" "couchbase-client" |
Contributor
There was a problem hiding this comment.
It would be nice to pull this value (and other values of this tag) into public context on an instrumentation to avoid repeating it many times.
| .buildSpan(protocol + ".request") | ||
| .withTag(Tags.SPAN_KIND.getKey(), Tags.SPAN_KIND_CLIENT) | ||
| .withTag(DDTags.SPAN_TYPE, DDSpanTypes.HTTP_CLIENT) | ||
| .withTag(Tags.COMPONENT.getKey(), "UrlConnection") |
Mar kolya/components suggestions
mar-kolya
approved these changes
Nov 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.