Uh oh!
There was an error while loading. Please reload this page.
Mar kolya/components suggestions - #580
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
you're right... it doesn't make sense for this case. perhaps we should limit this error span somehow to http only?
ContributorAuthor
There was a problem hiding this comment.
My impression is that http case doesn't even hit this code since we instrument http stuff separately...
Contributor
There was a problem hiding this comment.
Oops... I missed that it was already being set. Nice catch.
tylerbenson
approved these changes
Nov 15, 2018
tylerbenson
commented
Nov 15, 2018
Contributor
looks like there are format violations. fix that and merge it in. |
mar-kolyaforce-pushed
the
mar-kolya/components-suggestions
branch
from
November 15, 2018 18:23
318ef63 to
465e237Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.