Common temporary location manager for profiling product by jbachorik · Pull Request #7971 · DataDog/dd-trace-java

jbachorik · 2024-11-18T16:11:24Z

What Does This Do

It extracts the functionality related to temporary location cleanup (previously only for JFR) to allow for shared experience for JFR recording, ddprof recording and temporary library artifacts.

Motivation

Unification of the temporary location handling. Providing cleanup of all orphaned temporary artifacts generated by the profiler.

Additional Notes

How does this work

The temp location manager will create one common root for the temporary data and that location will have the name of pid_<pid> where <pid> is the Java process PID. Then, the users can request temporary subfolders with a specific path and these will be created under the common, process-specific, location. All the temporary subfolders are automatically registered for cleanup on JVM exit.
In order to handle hard-kills and JVM crashes, each time a profiled process is started it will scan the base temporary location for any pid_<pid> subfolders that don't correspond to any of the currently running JVM. There is an additional requirement for a file/directory to be cleaned up, though. It must have been last modified at least 2* seconds ago. This helps to exclude JVMs being currently in shutdown and therefore not showing up in jps output or having been created between the cleaner obtained the jps output and started cleaning the files.

I had to modify PidHelper to drain the pipes asynchronously - apparently, in smoke tests and system tests the number of java processes running on a single host was large enough to cause clogging and effectively deadlocking the test process with the 'jps' subprocess.

Compatibility issues

The configuration flag profiling.jfr.repository.cleanup is removed and ignored; cleanup will happen always
The configuration flag profiling.jfr.repository.base is deprecated and ignored; use profiling.tempdir instead

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: PROF-10925

github-actions · 2024-11-18T16:11:37Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

…va/com/datadog/profiling/controller/TempLocationManager.java Co-authored-by: datadog-datadog-prod-us1[bot] <88084959+datadog-datadog-prod-us1[bot]@users.noreply.github.com>

pr-commenter · 2024-11-18T16:52:40Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jb/profiling_temp_location
git_commit_date	1732280130	1732280012
git_commit_sha	`9078a8c`	`84d0501`
release_version	1.43.0-SNAPSHOT~9078a8c473	1.43.0-SNAPSHOT~84d0501188

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732282427	1732282427
ci_job_id	716965225	716965225
ci_pipeline_id	49721768	49721768
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 51 metrics, 11 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:petclinic:profiling:GlobalTracer	worse [+26.319ms; +39.913ms] or [+6.506%; +9.866%]	437.657ms	404.541ms

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~84d0501188, baseline=1.43.0-SNAPSHOT~9078a8c473
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.105 s) : 0, 1104760
Total [baseline] (8.733 s) : 0, 8732818
Agent [candidate] (1.087 s) : 0, 1087142
Total [candidate] (8.631 s) : 0, 8630682
section iast
Agent [baseline] (1.216 s) : 0, 1215509
Total [baseline] (9.176 s) : 0, 9175594
Agent [candidate] (1.225 s) : 0, 1225076
Total [candidate] (9.21 s) : 0, 9210023
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.222 s) : 0, 1222236
Total [baseline] (9.18 s) : 0, 9180026
Agent [candidate] (1.217 s) : 0, 1216694
Total [candidate] (9.18 s) : 0, 9179576
section iast_TELEMETRY_OFF
Agent [baseline] (1.215 s) : 0, 1214865
Total [baseline] (9.225 s) : 0, 9225033
Agent [candidate] (1.216 s) : 0, 1215885
Total [candidate] (9.217 s) : 0, 9217177

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.105 s	-
Agent	iast	1.216 s	110.749 ms (10.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.222 s	117.476 ms (10.6%)
Agent	iast_TELEMETRY_OFF	1.215 s	110.105 ms (10.0%)
Total	tracing	8.733 s	-
Total	iast	9.176 s	442.776 ms (5.1%)
Total	iast_HARDCODED_SECRET_DISABLED	9.18 s	447.208 ms (5.1%)
Total	iast_TELEMETRY_OFF	9.225 s	492.215 ms (5.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.087 s	-
Agent	iast	1.225 s	137.933 ms (12.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.217 s	129.552 ms (11.9%)
Agent	iast_TELEMETRY_OFF	1.216 s	128.742 ms (11.8%)
Total	tracing	8.631 s	-
Total	iast	9.21 s	579.341 ms (6.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.18 s	548.893 ms (6.4%)
Total	iast_TELEMETRY_OFF	9.217 s	586.495 ms (6.8%)

gantt
title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~84d0501188, baseline=1.43.0-SNAPSHOT~9078a8c473
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (703.533 ms) : 0, 703533
BytebuddyAgent [candidate] (692.189 ms) : 0, 692189
GlobalTracer [baseline] (320.838 ms) : 0, 320838
GlobalTracer [candidate] (317.023 ms) : 0, 317023
AppSec [baseline] (55.6 ms) : 0, 55600
AppSec [candidate] (54.882 ms) : 0, 54882
Remote Config [baseline] (707.454 µs) : 0, 707
Remote Config [candidate] (702.819 µs) : 0, 703
Telemetry [baseline] (10.116 ms) : 0, 10116
Telemetry [candidate] (8.618 ms) : 0, 8618
section iast
BytebuddyAgent [baseline] (808.854 ms) : 0, 808854
BytebuddyAgent [candidate] (815.32 ms) : 0, 815320
GlobalTracer [baseline] (306.224 ms) : 0, 306224
GlobalTracer [candidate] (308.443 ms) : 0, 308443
AppSec [baseline] (56.36 ms) : 0, 56360
AppSec [candidate] (57.634 ms) : 0, 57634
IAST [baseline] (22.373 ms) : 0, 22373
IAST [candidate] (21.678 ms) : 0, 21678
Remote Config [baseline] (599.803 µs) : 0, 600
Remote Config [candidate] (616.376 µs) : 0, 616
Telemetry [baseline] (7.383 ms) : 0, 7383
Telemetry [candidate] (7.548 ms) : 0, 7548
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (813.644 ms) : 0, 813644
BytebuddyAgent [candidate] (809.417 ms) : 0, 809417
GlobalTracer [baseline] (307.797 ms) : 0, 307797
GlobalTracer [candidate] (306.504 ms) : 0, 306504
AppSec [baseline] (57.27 ms) : 0, 57270
AppSec [candidate] (58.04 ms) : 0, 58040
IAST [baseline] (21.605 ms) : 0, 21605
IAST [candidate] (20.841 ms) : 0, 20841
Remote Config [baseline] (650.171 µs) : 0, 650
Remote Config [candidate] (642.068 µs) : 0, 642
Telemetry [baseline] (7.475 ms) : 0, 7475
Telemetry [candidate] (7.476 ms) : 0, 7476
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (807.354 ms) : 0, 807354
BytebuddyAgent [candidate] (808.461 ms) : 0, 808461
GlobalTracer [baseline] (306.8 ms) : 0, 306800
GlobalTracer [candidate] (306.843 ms) : 0, 306843
AppSec [baseline] (57.674 ms) : 0, 57674
AppSec [candidate] (57.167 ms) : 0, 57167
IAST [baseline] (21.308 ms) : 0, 21308
IAST [candidate] (21.585 ms) : 0, 21585
Remote Config [baseline] (623.824 µs) : 0, 624
Remote Config [candidate] (622.23 µs) : 0, 622
Telemetry [baseline] (7.377 ms) : 0, 7377
Telemetry [candidate] (7.429 ms) : 0, 7429

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~84d0501188, baseline=1.43.0-SNAPSHOT~9078a8c473
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.101 s) : 0, 1100600
Total [baseline] (10.457 s) : 0, 10456815
Agent [candidate] (1.086 s) : 0, 1085907
Total [candidate] (10.474 s) : 0, 10473736
section appsec
Agent [baseline] (1.225 s) : 0, 1224839
Total [baseline] (10.739 s) : 0, 10739066
Agent [candidate] (1.223 s) : 0, 1222773
Total [candidate] (10.694 s) : 0, 10694446
section iast
Agent [baseline] (1.223 s) : 0, 1223089
Total [baseline] (10.887 s) : 0, 10886829
Agent [candidate] (1.225 s) : 0, 1224714
Total [candidate] (10.956 s) : 0, 10955675
section profiling
Agent [baseline] (1.303 s) : 0, 1303358
Total [baseline] (10.874 s) : 0, 10873527
Agent [candidate] (1.322 s) : 0, 1322334
Total [candidate] (10.923 s) : 0, 10923138

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.101 s	-
Agent	appsec	1.225 s	124.239 ms (11.3%)
Agent	iast	1.223 s	122.488 ms (11.1%)
Agent	profiling	1.303 s	202.758 ms (18.4%)
Total	tracing	10.457 s	-
Total	appsec	10.739 s	282.25 ms (2.7%)
Total	iast	10.887 s	430.013 ms (4.1%)
Total	profiling	10.874 s	416.712 ms (4.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.086 s	-
Agent	appsec	1.223 s	136.866 ms (12.6%)
Agent	iast	1.225 s	138.807 ms (12.8%)
Agent	profiling	1.322 s	236.427 ms (21.8%)
Total	tracing	10.474 s	-
Total	appsec	10.694 s	220.71 ms (2.1%)
Total	iast	10.956 s	481.94 ms (4.6%)
Total	profiling	10.923 s	449.402 ms (4.3%)

gantt
title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~84d0501188, baseline=1.43.0-SNAPSHOT~9078a8c473
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (700.11 ms) : 0, 700110
BytebuddyAgent [candidate] (691.72 ms) : 0, 691720
GlobalTracer [baseline] (320.656 ms) : 0, 320656
GlobalTracer [candidate] (316.806 ms) : 0, 316806
AppSec [baseline] (55.188 ms) : 0, 55188
AppSec [candidate] (54.436 ms) : 0, 54436
Remote Config [baseline] (684.951 µs) : 0, 685
Remote Config [candidate] (684.543 µs) : 0, 685
Telemetry [baseline] (10.094 ms) : 0, 10094
Telemetry [candidate] (8.584 ms) : 0, 8584
section appsec
BytebuddyAgent [baseline] (711.319 ms) : 0, 711319
BytebuddyAgent [candidate] (708.702 ms) : 0, 708702
GlobalTracer [baseline] (314.952 ms) : 0, 314952
GlobalTracer [candidate] (313.906 ms) : 0, 313906
AppSec [baseline] (165.816 ms) : 0, 165816
AppSec [candidate] (166.978 ms) : 0, 166978
Remote Config [baseline] (660.78 µs) : 0, 661
Remote Config [candidate] (647.188 µs) : 0, 647
Telemetry [baseline] (8.581 ms) : 0, 8581
Telemetry [candidate] (8.203 ms) : 0, 8203
IAST [baseline] (19.62 ms) : 0, 19620
IAST [candidate] (21.295 ms) : 0, 21295
section iast
BytebuddyAgent [baseline] (814.945 ms) : 0, 814945
BytebuddyAgent [candidate] (815.353 ms) : 0, 815353
GlobalTracer [baseline] (308.034 ms) : 0, 308034
GlobalTracer [candidate] (308.152 ms) : 0, 308152
AppSec [baseline] (57.508 ms) : 0, 57508
AppSec [candidate] (57.478 ms) : 0, 57478
Remote Config [baseline] (604.538 µs) : 0, 605
Remote Config [candidate] (1.442 ms) : 0, 1442
Telemetry [baseline] (7.468 ms) : 0, 7468
Telemetry [candidate] (7.488 ms) : 0, 7488
IAST [baseline] (20.793 ms) : 0, 20793
IAST [candidate] (20.959 ms) : 0, 20959
section profiling
ProfilingAgent [baseline] (95.819 ms) : 0, 95819
ProfilingAgent [candidate] (93.608 ms) : 0, 93608
BytebuddyAgent [baseline] (695.461 ms) : 0, 695461
BytebuddyAgent [candidate] (689.459 ms) : 0, 689459
GlobalTracer [baseline] (404.541 ms) : 0, 404541
GlobalTracer [candidate] (437.657 ms) : 0, 437657
AppSec [baseline] (55.732 ms) : 0, 55732
AppSec [candidate] (54.084 ms) : 0, 54084
Remote Config [baseline] (690.089 µs) : 0, 690
Remote Config [candidate] (675.072 µs) : 0, 675
Telemetry [baseline] (11.558 ms) : 0, 11558
Telemetry [candidate] (7.757 ms) : 0, 7757
Profiling [baseline] (95.842 ms) : 0, 95842
Profiling [candidate] (93.633 ms) : 0, 93633

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-11-22T13:03:54	2024-11-22T13:10:50
git_branch	master	jb/profiling_temp_location
git_commit_date	1732280130	1732280012
git_commit_sha	`9078a8c`	`84d0501`
release_version	1.43.0-SNAPSHOT~9078a8c473	1.43.0-SNAPSHOT~84d0501188
start_time	2024-11-22T13:03:40	2024-11-22T13:10:37

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732281404	1732281404
ci_job_id	716965226	716965226
ci_pipeline_id	49721768	49721768
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~84d0501188, baseline=1.43.0-SNAPSHOT~9078a8c473
dateFormat X
axisFormat %s
section baseline
no_agent (372.148 µs) : 352, 392
. : milestone, 372,
iast (484.868 µs) : 464, 506
. : milestone, 485,
iast_FULL (646.629 µs) : 625, 668
. : milestone, 647,
iast_GLOBAL (512.68 µs) : 491, 534
. : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (487.053 µs) : 466, 508
. : milestone, 487,
iast_INACTIVE (451.981 µs) : 430, 473
. : milestone, 452,
iast_TELEMETRY_OFF (475.308 µs) : 454, 497
. : milestone, 475,
tracing (445.686 µs) : 425, 467
. : milestone, 446,
section candidate
no_agent (371.967 µs) : 351, 393
. : milestone, 372,
iast (488.767 µs) : 467, 510
. : milestone, 489,
iast_FULL (652.432 µs) : 631, 674
. : milestone, 652,
iast_GLOBAL (521.119 µs) : 498, 544
. : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (487.801 µs) : 466, 509
. : milestone, 488,
iast_INACTIVE (454.845 µs) : 433, 477
. : milestone, 455,
iast_TELEMETRY_OFF (482.372 µs) : 460, 505
. : milestone, 482,
tracing (449.525 µs) : 428, 471
. : milestone, 450,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	372.148 µs [351.841 µs, 392.455 µs]	-
iast	484.868 µs [463.84 µs, 505.896 µs]	112.72 µs (30.3%)
iast_FULL	646.629 µs [625.168 µs, 668.09 µs]	274.481 µs (73.8%)
iast_GLOBAL	512.68 µs [491.454 µs, 533.906 µs]	140.532 µs (37.8%)
iast_HARDCODED_SECRET_DISABLED	487.053 µs [465.741 µs, 508.365 µs]	114.905 µs (30.9%)
iast_INACTIVE	451.981 µs [430.482 µs, 473.48 µs]	79.833 µs (21.5%)
iast_TELEMETRY_OFF	475.308 µs [453.97 µs, 496.645 µs]	103.16 µs (27.7%)
tracing	445.686 µs [424.776 µs, 466.595 µs]	73.538 µs (19.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	371.967 µs [351.065 µs, 392.869 µs]	-
iast	488.767 µs [467.213 µs, 510.322 µs]	116.8 µs (31.4%)
iast_FULL	652.432 µs [630.603 µs, 674.261 µs]	280.465 µs (75.4%)
iast_GLOBAL	521.119 µs [498.462 µs, 543.776 µs]	149.152 µs (40.1%)
iast_HARDCODED_SECRET_DISABLED	487.801 µs [466.476 µs, 509.125 µs]	115.834 µs (31.1%)
iast_INACTIVE	454.845 µs [433.043 µs, 476.646 µs]	82.878 µs (22.3%)
iast_TELEMETRY_OFF	482.372 µs [460.079 µs, 504.665 µs]	110.405 µs (29.7%)
tracing	449.525 µs [428.011 µs, 471.038 µs]	77.558 µs (20.9%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~84d0501188, baseline=1.43.0-SNAPSHOT~9078a8c473
dateFormat X
axisFormat %s
section baseline
no_agent (1.353 ms) : 1333, 1373
. : milestone, 1353,
appsec (1.743 ms) : 1718, 1767
. : milestone, 1743,
appsec_no_iast (1.774 ms) : 1750, 1799
. : milestone, 1774,
iast (1.505 ms) : 1481, 1528
. : milestone, 1505,
profiling (1.496 ms) : 1473, 1519
. : milestone, 1496,
tracing (1.474 ms) : 1449, 1499
. : milestone, 1474,
section candidate
no_agent (1.36 ms) : 1340, 1380
. : milestone, 1360,
appsec (1.762 ms) : 1738, 1786
. : milestone, 1762,
appsec_no_iast (1.755 ms) : 1731, 1779
. : milestone, 1755,
iast (1.492 ms) : 1470, 1515
. : milestone, 1492,
profiling (1.55 ms) : 1526, 1574
. : milestone, 1550,
tracing (1.481 ms) : 1457, 1505
. : milestone, 1481,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.353 ms [1.333 ms, 1.373 ms]	-
appsec	1.743 ms [1.718 ms, 1.767 ms]	389.795 µs (28.8%)
appsec_no_iast	1.774 ms [1.75 ms, 1.799 ms]	421.325 µs (31.1%)
iast	1.505 ms [1.481 ms, 1.528 ms]	151.976 µs (11.2%)
profiling	1.496 ms [1.473 ms, 1.519 ms]	143.046 µs (10.6%)
tracing	1.474 ms [1.449 ms, 1.499 ms]	121.053 µs (8.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.36 ms [1.34 ms, 1.38 ms]	-
appsec	1.762 ms [1.738 ms, 1.786 ms]	402.318 µs (29.6%)
appsec_no_iast	1.755 ms [1.731 ms, 1.779 ms]	395.178 µs (29.1%)
iast	1.492 ms [1.47 ms, 1.515 ms]	132.35 µs (9.7%)
profiling	1.55 ms [1.526 ms, 1.574 ms]	189.793 µs (14.0%)
tracing	1.481 ms [1.457 ms, 1.505 ms]	121.287 µs (8.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jb/profiling_temp_location
git_commit_date	1732280130	1732280012
git_commit_sha	`9078a8c`	`84d0501`
release_version	1.43.0-SNAPSHOT~9078a8c473	1.43.0-SNAPSHOT~84d0501188

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1732281997	1732281997
ci_job_id	716965227	716965227
ci_pipeline_id	49721768	49721768
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~84d0501188, baseline=1.43.0-SNAPSHOT~9078a8c473
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1478
. : milestone, 1467,
appsec (2.342 ms) : 2300, 2383
. : milestone, 2342,
iast (2.081 ms) : 2029, 2133
. : milestone, 2081,
iast_GLOBAL (2.124 ms) : 2072, 2177
. : milestone, 2124,
profiling (1.966 ms) : 1923, 2009
. : milestone, 1966,
tracing (1.922 ms) : 1882, 1962
. : milestone, 1922,
section candidate
no_agent (1.465 ms) : 1454, 1477
. : milestone, 1465,
appsec (2.328 ms) : 2287, 2370
. : milestone, 2328,
iast (2.08 ms) : 2027, 2132
. : milestone, 2080,
iast_GLOBAL (2.116 ms) : 2064, 2168
. : milestone, 2116,
profiling (1.949 ms) : 1907, 1991
. : milestone, 1949,
tracing (1.914 ms) : 1874, 1954
. : milestone, 1914,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.467 ms [1.455 ms, 1.478 ms]	-
appsec	2.342 ms [2.3 ms, 2.383 ms]	874.886 µs (59.6%)
iast	2.081 ms [2.029 ms, 2.133 ms]	614.082 µs (41.9%)
iast_GLOBAL	2.124 ms [2.072 ms, 2.177 ms]	657.397 µs (44.8%)
profiling	1.966 ms [1.923 ms, 2.009 ms]	499.207 µs (34.0%)
tracing	1.922 ms [1.882 ms, 1.962 ms]	455.192 µs (31.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.465 ms [1.454 ms, 1.477 ms]	-
appsec	2.328 ms [2.287 ms, 2.37 ms]	863.211 µs (58.9%)
iast	2.08 ms [2.027 ms, 2.132 ms]	614.381 µs (41.9%)
iast_GLOBAL	2.116 ms [2.064 ms, 2.168 ms]	651.159 µs (44.4%)
profiling	1.949 ms [1.907 ms, 1.991 ms]	483.621 µs (33.0%)
tracing	1.914 ms [1.874 ms, 1.954 ms]	448.841 µs (30.6%)

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~84d0501188, baseline=1.43.0-SNAPSHOT~9078a8c473
dateFormat X
axisFormat %s
section baseline
no_agent (15.204 s) : 15204000, 15204000
. : milestone, 15204000,
appsec (15.169 s) : 15169000, 15169000
. : milestone, 15169000,
iast (18.917 s) : 18917000, 18917000
. : milestone, 18917000,
iast_GLOBAL (17.903 s) : 17903000, 17903000
. : milestone, 17903000,
profiling (14.954 s) : 14954000, 14954000
. : milestone, 14954000,
tracing (14.941 s) : 14941000, 14941000
. : milestone, 14941000,
section candidate
no_agent (15.245 s) : 15245000, 15245000
. : milestone, 15245000,
appsec (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
iast (18.934 s) : 18934000, 18934000
. : milestone, 18934000,
iast_GLOBAL (17.976 s) : 17976000, 17976000
. : milestone, 17976000,
profiling (14.754 s) : 14754000, 14754000
. : milestone, 14754000,
tracing (15.167 s) : 15167000, 15167000
. : milestone, 15167000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.204 s [15.204 s, 15.204 s]	-
appsec	15.169 s [15.169 s, 15.169 s]	-35.0 ms (-0.2%)
iast	18.917 s [18.917 s, 18.917 s]	3.713 s (24.4%)
iast_GLOBAL	17.903 s [17.903 s, 17.903 s]	2.699 s (17.8%)
profiling	14.954 s [14.954 s, 14.954 s]	-250.0 ms (-1.6%)
tracing	14.941 s [14.941 s, 14.941 s]	-263.0 ms (-1.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.245 s [15.245 s, 15.245 s]	-
appsec	14.946 s [14.946 s, 14.946 s]	-299.0 ms (-2.0%)
iast	18.934 s [18.934 s, 18.934 s]	3.689 s (24.2%)
iast_GLOBAL	17.976 s [17.976 s, 17.976 s]	2.731 s (17.9%)
profiling	14.754 s [14.754 s, 14.754 s]	-491.0 ms (-3.2%)
tracing	15.167 s [15.167 s, 15.167 s]	-78.0 ms (-0.5%)

richardstartin

Looks good, I just think we need to be sure we don't make the JVM hang on shutdown

manuel-alvarez-alvarez

LGTM (@richardstartin concerns at shutdown should be addressed)

…va/com/datadog/profiling/controller/TempLocationManager.java Co-authored-by: datadog-datadog-prod-us1[bot] <88084959+datadog-datadog-prod-us1[bot]@users.noreply.github.com>

Common temporary location manager for profiling product
d2479b5

jbachorik added the comp: profiling Profiling label Nov 18, 2024

jbachorik requested review from a team as code owners November 18, 2024 16:11

jbachorik requested a review from manuel-alvarez-alvarez November 18, 2024 16:11

datadog-datadog-prod-us1Bot reviewed Nov 18, 2024
View reviewed changes

Comment thread...profiling-controller/src/main/java/com/datadog/profiling/controller/TempLocationManager.java Outdated

jbachorik added the type: feature Enhancements and improvements label Nov 18, 2024

jbachorikand others added 2 commits November 18, 2024 17:13

Update dd-java-agent/agent-profiling/profiling-controller/src/main/ja…
06ae694
…va/com/datadog/profiling/controller/TempLocationManager.java Co-authored-by: datadog-datadog-prod-us1[bot] <88084959+datadog-datadog-prod-us1[bot]@users.noreply.github.com>

Fix tests
ff48e46

jbachorikand others added 6 commits November 18, 2024 17:56

Spotless
92d1ecf

Fix tests
6e60ed6

Merge branch 'master' into jb/profiling_temp_location
df36231

Allow for parallel runs of TempLocationManagerTest
f65e89c

More standard temp randomization
e4d56d2

Debug disabling cleanup on startup
fe0aeca

jbachorik marked this pull request as draft November 19, 2024 17:00

jbachorikand others added 5 commits November 19, 2024 19:08

Try to avoid racy cleanups
9f2cbf1

Improve the temp location manager api
3c6f3ed

Merge branch 'master' into jb/profiling_temp_location
0975e0f

Blindly trying to fix the smoke tests
17ef73a

Blindly trying to fix the smoke tests
0fa642e

jbachorik force-pushed the jb/profiling_temp_location branch from 6dabf93 to 0fa642eCompare November 20, 2024 11:46

jbachorik marked this pull request as ready for review November 20, 2024 12:46

jbachorik requested a review from richardstartin November 20, 2024 12:48

jbachorik marked this pull request as draft November 20, 2024 13:07

jbachorik marked this pull request as ready for review November 20, 2024 15:09

jbachorik added 2 commits November 20, 2024 18:21

Allow for slower jps execution
5e0ed99

Add tests for concurrent cleanup
ff6ff64

richardstartin reviewed Nov 22, 2024
View reviewed changes

Comment thread...profiling-controller/src/main/java/com/datadog/profiling/controller/TempLocationManager.java Outdated

richardstartin reviewed Nov 22, 2024
View reviewed changes

manuel-alvarez-alvarez reviewed Nov 22, 2024
View reviewed changes

Comment thread...iling-controller/src/test/java/com/datadog/profiling/controller/TempLocationManagerTest.java

manuel-alvarez-alvarez reviewed Nov 22, 2024
View reviewed changes

Comment thread...profiling-controller/src/main/java/com/datadog/profiling/controller/TempLocationManager.java

Add support for timeout to cleanup task
f438c9e

manuel-alvarez-alvarez approved these changes Nov 22, 2024
View reviewed changes

datadog-datadog-prod-us1Bot reviewed Nov 22, 2024
View reviewed changes

Comment thread...profiling-controller/src/main/java/com/datadog/profiling/controller/TempLocationManager.java Outdated

Update dd-java-agent/agent-profiling/profiling-controller/src/main/ja…
84d0501
…va/com/datadog/profiling/controller/TempLocationManager.java Co-authored-by: datadog-datadog-prod-us1[bot] <88084959+datadog-datadog-prod-us1[bot]@users.noreply.github.com>

richardstartin approved these changes Nov 22, 2024
View reviewed changes

jbachorik merged commit 79ca6e4 into masterNov 22, 2024

jbachorik deleted the jb/profiling_temp_location branch November 22, 2024 15:46

github-actionsBot added this to the 1.43.0 milestone Nov 22, 2024

jbachorik mentioned this pull request Nov 22, 2024
Fix the temp location manager on J9 #8002
Merged

ajax-boiko-y mentioned this pull request Jan 3, 2025
Error: Port already in use. Version 1.43.0 or higher. #8148
Open

Navigation Menu

Uh oh!

Common temporary location manager for profiling product - #7971

Common temporary location manager for profiling product#7971
jbachorik merged 18 commits into
masterfrom
jb/profiling_temp_location

jbachorik commented Nov 18, 2024•
edited
Loading

Uh oh!

github-actionsBot commented Nov 18, 2024•
edited
Loading

Uh oh!

Uh oh!

pr-commenterBot commented Nov 18, 2024•
edited
Loading

Uh oh!

Uh oh!

richardstartin left a comment

Uh oh!

Uh oh!

Uh oh!

manuel-alvarez-alvarez left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jbachorik commented Nov 18, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

How does this work

Contributor Checklist

Uh oh!

github-actionsBot commented Nov 18, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

pr-commenterBot commented Nov 18, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

richardstartin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

manuel-alvarez-alvarez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jbachorik commented Nov 18, 2024•
edited
Loading

github-actionsBot commented Nov 18, 2024•
edited
Loading

pr-commenterBot commented Nov 18, 2024•
edited
Loading