Fix the temp location manager on J9 by jbachorik · Pull Request #8002 · DataDog/dd-trace-java

jbachorik · 2024-11-22T17:27:00Z

What Does This Do

Fix up of #7971

Motivation

Due to a different mechanism to retrieve running JVM processes the cleanup is not correct on J9

(due to a different mechanism to retrieve running JVM processes)

pr-commenter · 2024-11-22T18:00:45Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jb/profiling_temp_location_1
git_commit_date	1732489991	1732521666
git_commit_sha	`4925a50`	`ec5b89d`
release_version	1.43.0-SNAPSHOT~4925a50233	1.43.0-SNAPSHOT~ec5b89d719

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732524160	1732524160
ci_job_id	718371331	718371331
ci_pipeline_id	49826727	49826727
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~ec5b89d719, baseline=1.43.0-SNAPSHOT~4925a50233
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088418
Total [baseline] (10.475 s) : 0, 10474549
Agent [candidate] (1.085 s) : 0, 1085416
Total [candidate] (10.523 s) : 0, 10523063
section appsec
Agent [baseline] (1.224 s) : 0, 1223768
Total [baseline] (10.71 s) : 0, 10709744
Agent [candidate] (1.228 s) : 0, 1227562
Total [candidate] (10.743 s) : 0, 10742626
section iast
Agent [baseline] (1.22 s) : 0, 1219973
Total [baseline] (10.94 s) : 0, 10940220
Agent [candidate] (1.232 s) : 0, 1232047
Total [candidate] (11.033 s) : 0, 11033499
section profiling
Agent [baseline] (1.324 s) : 0, 1323738
Total [baseline] (10.806 s) : 0, 10805561
Agent [candidate] (1.315 s) : 0, 1315326
Total [candidate] (10.791 s) : 0, 10791041

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.088 s	-
Agent	appsec	1.224 s	135.35 ms (12.4%)
Agent	iast	1.22 s	131.555 ms (12.1%)
Agent	profiling	1.324 s	235.321 ms (21.6%)
Total	tracing	10.475 s	-
Total	appsec	10.71 s	235.195 ms (2.2%)
Total	iast	10.94 s	465.671 ms (4.4%)
Total	profiling	10.806 s	331.012 ms (3.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.085 s	-
Agent	appsec	1.228 s	142.145 ms (13.1%)
Agent	iast	1.232 s	146.631 ms (13.5%)
Agent	profiling	1.315 s	229.91 ms (21.2%)
Total	tracing	10.523 s	-
Total	appsec	10.743 s	219.563 ms (2.1%)
Total	iast	11.033 s	510.436 ms (4.9%)
Total	profiling	10.791 s	267.978 ms (2.5%)

gantt
title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~ec5b89d719, baseline=1.43.0-SNAPSHOT~4925a50233
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.683 ms) : 0, 692683
BytebuddyAgent [candidate] (691.205 ms) : 0, 691205
GlobalTracer [baseline] (317.204 ms) : 0, 317204
GlobalTracer [candidate] (316.414 ms) : 0, 316414
AppSec [baseline] (54.906 ms) : 0, 54906
AppSec [candidate] (54.725 ms) : 0, 54725
Remote Config [baseline] (687.488 µs) : 0, 687
Remote Config [candidate] (690.369 µs) : 0, 690
Telemetry [baseline] (9.234 ms) : 0, 9234
Telemetry [candidate] (8.671 ms) : 0, 8671
section appsec
BytebuddyAgent [baseline] (710.172 ms) : 0, 710172
BytebuddyAgent [candidate] (712.105 ms) : 0, 712105
GlobalTracer [baseline] (314.212 ms) : 0, 314212
GlobalTracer [candidate] (315.269 ms) : 0, 315269
AppSec [baseline] (166.642 ms) : 0, 166642
AppSec [candidate] (168.09 ms) : 0, 168090
IAST [baseline] (20.386 ms) : 0, 20386
IAST [candidate] (19.729 ms) : 0, 19729
Remote Config [baseline] (646.149 µs) : 0, 646
Remote Config [candidate] (650.156 µs) : 0, 650
Telemetry [baseline] (8.2 ms) : 0, 8200
Telemetry [candidate] (7.878 ms) : 0, 7878
section iast
BytebuddyAgent [baseline] (812.258 ms) : 0, 812258
BytebuddyAgent [candidate] (820.47 ms) : 0, 820470
GlobalTracer [baseline] (307.397 ms) : 0, 307397
GlobalTracer [candidate] (310.348 ms) : 0, 310348
AppSec [baseline] (57.87 ms) : 0, 57870
AppSec [candidate] (57.314 ms) : 0, 57314
IAST [baseline] (20.66 ms) : 0, 20660
IAST [candidate] (21.791 ms) : 0, 21791
Remote Config [baseline] (608.168 µs) : 0, 608
Remote Config [candidate] (613.997 µs) : 0, 614
Telemetry [baseline] (7.507 ms) : 0, 7507
Telemetry [candidate] (7.6 ms) : 0, 7600
section profiling
BytebuddyAgent [baseline] (691.834 ms) : 0, 691834
BytebuddyAgent [candidate] (686.423 ms) : 0, 686423
GlobalTracer [baseline] (437.45 ms) : 0, 437450
GlobalTracer [candidate] (434.262 ms) : 0, 434262
AppSec [baseline] (53.578 ms) : 0, 53578
AppSec [candidate] (53.804 ms) : 0, 53804
Remote Config [baseline] (652.398 µs) : 0, 652
Remote Config [candidate] (657.392 µs) : 0, 657
Telemetry [baseline] (7.77 ms) : 0, 7770
Telemetry [candidate] (7.707 ms) : 0, 7707
ProfilingAgent [baseline] (93.227 ms) : 0, 93227
ProfilingAgent [candidate] (93.471 ms) : 0, 93471
Profiling [baseline] (93.25 ms) : 0, 93250
Profiling [candidate] (93.494 ms) : 0, 93494

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~ec5b89d719, baseline=1.43.0-SNAPSHOT~4925a50233
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1098275
Total [baseline] (8.661 s) : 0, 8661427
Agent [candidate] (1.093 s) : 0, 1093032
Total [candidate] (8.695 s) : 0, 8695305
section iast
Agent [baseline] (1.229 s) : 0, 1228674
Total [baseline] (9.237 s) : 0, 9236817
Agent [candidate] (1.216 s) : 0, 1216353
Total [candidate] (9.187 s) : 0, 9186762
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.214 s) : 0, 1213701
Total [baseline] (9.159 s) : 0, 9159448
Agent [candidate] (1.221 s) : 0, 1221474
Total [candidate] (9.174 s) : 0, 9174042
section iast_TELEMETRY_OFF
Agent [baseline] (1.221 s) : 0, 1221385
Total [baseline] (9.212 s) : 0, 9212111
Agent [candidate] (1.212 s) : 0, 1212034
Total [candidate] (9.19 s) : 0, 9189684

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.098 s	-
Agent	iast	1.229 s	130.4 ms (11.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.214 s	115.427 ms (10.5%)
Agent	iast_TELEMETRY_OFF	1.221 s	123.11 ms (11.2%)
Total	tracing	8.661 s	-
Total	iast	9.237 s	575.391 ms (6.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.159 s	498.021 ms (5.7%)
Total	iast_TELEMETRY_OFF	9.212 s	550.684 ms (6.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.093 s	-
Agent	iast	1.216 s	123.321 ms (11.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.221 s	128.442 ms (11.8%)
Agent	iast_TELEMETRY_OFF	1.212 s	119.002 ms (10.9%)
Total	tracing	8.695 s	-
Total	iast	9.187 s	491.457 ms (5.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.174 s	478.737 ms (5.5%)
Total	iast_TELEMETRY_OFF	9.19 s	494.378 ms (5.7%)

gantt
title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~ec5b89d719, baseline=1.43.0-SNAPSHOT~4925a50233
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (698.477 ms) : 0, 698477
BytebuddyAgent [candidate] (696.694 ms) : 0, 696694
GlobalTracer [baseline] (320.008 ms) : 0, 320008
GlobalTracer [candidate] (318.461 ms) : 0, 318461
AppSec [baseline] (55.302 ms) : 0, 55302
AppSec [candidate] (54.831 ms) : 0, 54831
Remote Config [baseline] (705.117 µs) : 0, 705
Remote Config [candidate] (699.292 µs) : 0, 699
Telemetry [baseline] (10.015 ms) : 0, 10015
Telemetry [candidate] (8.542 ms) : 0, 8542
section iast
BytebuddyAgent [baseline] (816.642 ms) : 0, 816642
BytebuddyAgent [candidate] (808.922 ms) : 0, 808922
GlobalTracer [baseline] (310.37 ms) : 0, 310370
GlobalTracer [candidate] (306.4 ms) : 0, 306400
AppSec [baseline] (58.492 ms) : 0, 58492
AppSec [candidate] (56.539 ms) : 0, 56539
IAST [baseline] (21.096 ms) : 0, 21096
IAST [candidate] (22.632 ms) : 0, 22632
Remote Config [baseline] (621.663 µs) : 0, 622
Remote Config [candidate] (607.782 µs) : 0, 608
Telemetry [baseline] (7.598 ms) : 0, 7598
Telemetry [candidate] (7.518 ms) : 0, 7518
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.43 ms) : 0, 807430
BytebuddyAgent [candidate] (813.872 ms) : 0, 813872
GlobalTracer [baseline] (306.009 ms) : 0, 306009
GlobalTracer [candidate] (307.265 ms) : 0, 307265
AppSec [baseline] (56.174 ms) : 0, 56174
AppSec [candidate] (57.83 ms) : 0, 57830
IAST [baseline] (22.315 ms) : 0, 22315
IAST [candidate] (20.634 ms) : 0, 20634
Remote Config [baseline] (630.964 µs) : 0, 631
Remote Config [candidate] (593.643 µs) : 0, 594
Telemetry [baseline] (7.509 ms) : 0, 7509
Telemetry [candidate] (7.453 ms) : 0, 7453
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (812.956 ms) : 0, 812956
BytebuddyAgent [candidate] (806.275 ms) : 0, 806275
GlobalTracer [baseline] (308.145 ms) : 0, 308145
GlobalTracer [candidate] (306.179 ms) : 0, 306179
AppSec [baseline] (58.202 ms) : 0, 58202
AppSec [candidate] (57.641 ms) : 0, 57641
IAST [baseline] (20.258 ms) : 0, 20258
IAST [candidate] (20.217 ms) : 0, 20217
Remote Config [baseline] (640.074 µs) : 0, 640
Remote Config [candidate] (637.942 µs) : 0, 638
Telemetry [baseline] (7.398 ms) : 0, 7398
Telemetry [candidate] (7.37 ms) : 0, 7370

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-11-25T08:12:49	2024-11-25T08:19:45
git_branch	master	jb/profiling_temp_location_1
git_commit_date	1732489991	1732521666
git_commit_sha	`4925a50`	`ec5b89d`
release_version	1.43.0-SNAPSHOT~4925a50233	1.43.0-SNAPSHOT~ec5b89d719
start_time	2024-11-25T08:12:35	2024-11-25T08:19:32

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732523138	1732523138
ci_job_id	718371332	718371332
ci_pipeline_id	49826727	49826727
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~ec5b89d719, baseline=1.43.0-SNAPSHOT~4925a50233
dateFormat X
axisFormat %s
section baseline
no_agent (1.355 ms) : 1335, 1374
. : milestone, 1355,
appsec (1.744 ms) : 1720, 1768
. : milestone, 1744,
appsec_no_iast (1.744 ms) : 1720, 1768
. : milestone, 1744,
iast (1.5 ms) : 1477, 1523
. : milestone, 1500,
profiling (1.507 ms) : 1484, 1531
. : milestone, 1507,
tracing (1.475 ms) : 1450, 1500
. : milestone, 1475,
section candidate
no_agent (1.343 ms) : 1323, 1363
. : milestone, 1343,
appsec (1.739 ms) : 1714, 1763
. : milestone, 1739,
appsec_no_iast (1.752 ms) : 1726, 1777
. : milestone, 1752,
iast (1.508 ms) : 1486, 1531
. : milestone, 1508,
profiling (1.522 ms) : 1499, 1545
. : milestone, 1522,
tracing (1.51 ms) : 1485, 1535
. : milestone, 1510,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.355 ms [1.335 ms, 1.374 ms]	-
appsec	1.744 ms [1.72 ms, 1.768 ms]	389.227 µs (28.7%)
appsec_no_iast	1.744 ms [1.72 ms, 1.768 ms]	389.245 µs (28.7%)
iast	1.5 ms [1.477 ms, 1.523 ms]	145.748 µs (10.8%)
profiling	1.507 ms [1.484 ms, 1.531 ms]	152.678 µs (11.3%)
tracing	1.475 ms [1.45 ms, 1.5 ms]	120.032 µs (8.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.343 ms [1.323 ms, 1.363 ms]	-
appsec	1.739 ms [1.714 ms, 1.763 ms]	395.76 µs (29.5%)
appsec_no_iast	1.752 ms [1.726 ms, 1.777 ms]	408.664 µs (30.4%)
iast	1.508 ms [1.486 ms, 1.531 ms]	165.434 µs (12.3%)
profiling	1.522 ms [1.499 ms, 1.545 ms]	179.131 µs (13.3%)
tracing	1.51 ms [1.485 ms, 1.535 ms]	166.905 µs (12.4%)

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~ec5b89d719, baseline=1.43.0-SNAPSHOT~4925a50233
dateFormat X
axisFormat %s
section baseline
no_agent (376.971 µs) : 357, 396
. : milestone, 377,
iast (489.944 µs) : 468, 512
. : milestone, 490,
iast_FULL (652.908 µs) : 631, 674
. : milestone, 653,
iast_GLOBAL (515.381 µs) : 494, 537
. : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (488.583 µs) : 467, 510
. : milestone, 489,
iast_INACTIVE (453.39 µs) : 432, 475
. : milestone, 453,
iast_TELEMETRY_OFF (472.896 µs) : 452, 494
. : milestone, 473,
tracing (448.86 µs) : 427, 471
. : milestone, 449,
section candidate
no_agent (377.788 µs) : 358, 398
. : milestone, 378,
iast (487.891 µs) : 466, 509
. : milestone, 488,
iast_FULL (650.345 µs) : 629, 672
. : milestone, 650,
iast_GLOBAL (513.151 µs) : 491, 535
. : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (487.146 µs) : 466, 509
. : milestone, 487,
iast_INACTIVE (444.789 µs) : 424, 466
. : milestone, 445,
iast_TELEMETRY_OFF (475.4 µs) : 454, 497
. : milestone, 475,
tracing (445.179 µs) : 424, 466
. : milestone, 445,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	376.971 µs [357.451 µs, 396.491 µs]	-
iast	489.944 µs [467.981 µs, 511.907 µs]	112.973 µs (30.0%)
iast_FULL	652.908 µs [631.399 µs, 674.417 µs]	275.937 µs (73.2%)
iast_GLOBAL	515.381 µs [493.593 µs, 537.169 µs]	138.41 µs (36.7%)
iast_HARDCODED_SECRET_DISABLED	488.583 µs [466.795 µs, 510.37 µs]	111.611 µs (29.6%)
iast_INACTIVE	453.39 µs [432.153 µs, 474.626 µs]	76.418 µs (20.3%)
iast_TELEMETRY_OFF	472.896 µs [451.743 µs, 494.049 µs]	95.925 µs (25.4%)
tracing	448.86 µs [427.051 µs, 470.669 µs]	71.888 µs (19.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	377.788 µs [357.705 µs, 397.871 µs]	-
iast	487.891 µs [466.346 µs, 509.436 µs]	110.103 µs (29.1%)
iast_FULL	650.345 µs [628.856 µs, 671.834 µs]	272.557 µs (72.1%)
iast_GLOBAL	513.151 µs [491.124 µs, 535.177 µs]	135.363 µs (35.8%)
iast_HARDCODED_SECRET_DISABLED	487.146 µs [465.608 µs, 508.684 µs]	109.358 µs (28.9%)
iast_INACTIVE	444.789 µs [423.981 µs, 465.596 µs]	67.001 µs (17.7%)
iast_TELEMETRY_OFF	475.4 µs [453.58 µs, 497.219 µs]	97.612 µs (25.8%)
tracing	445.179 µs [424.278 µs, 466.08 µs]	67.391 µs (17.8%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jb/profiling_temp_location_1
git_commit_date	1732489991	1732521666
git_commit_sha	`4925a50`	`ec5b89d`
release_version	1.43.0-SNAPSHOT~4925a50233	1.43.0-SNAPSHOT~ec5b89d719

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1732523717	1732523717
ci_job_id	718371333	718371333
ci_pipeline_id	49826727	49826727
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~ec5b89d719, baseline=1.43.0-SNAPSHOT~4925a50233
dateFormat X
axisFormat %s
section baseline
no_agent (14.988 s) : 14988000, 14988000
. : milestone, 14988000,
appsec (15.201 s) : 15201000, 15201000
. : milestone, 15201000,
iast (18.862 s) : 18862000, 18862000
. : milestone, 18862000,
iast_GLOBAL (17.617 s) : 17617000, 17617000
. : milestone, 17617000,
profiling (15.095 s) : 15095000, 15095000
. : milestone, 15095000,
tracing (14.986 s) : 14986000, 14986000
. : milestone, 14986000,
section candidate
no_agent (14.782 s) : 14782000, 14782000
. : milestone, 14782000,
appsec (15.146 s) : 15146000, 15146000
. : milestone, 15146000,
iast (18.628 s) : 18628000, 18628000
. : milestone, 18628000,
iast_GLOBAL (18.043 s) : 18043000, 18043000
. : milestone, 18043000,
profiling (15.579 s) : 15579000, 15579000
. : milestone, 15579000,
tracing (14.877 s) : 14877000, 14877000
. : milestone, 14877000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.988 s [14.988 s, 14.988 s]	-
appsec	15.201 s [15.201 s, 15.201 s]	213.0 ms (1.4%)
iast	18.862 s [18.862 s, 18.862 s]	3.874 s (25.8%)
iast_GLOBAL	17.617 s [17.617 s, 17.617 s]	2.629 s (17.5%)
profiling	15.095 s [15.095 s, 15.095 s]	107.0 ms (0.7%)
tracing	14.986 s [14.986 s, 14.986 s]	-2.0 ms (-0.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.782 s [14.782 s, 14.782 s]	-
appsec	15.146 s [15.146 s, 15.146 s]	364.0 ms (2.5%)
iast	18.628 s [18.628 s, 18.628 s]	3.846 s (26.0%)
iast_GLOBAL	18.043 s [18.043 s, 18.043 s]	3.261 s (22.1%)
profiling	15.579 s [15.579 s, 15.579 s]	797.0 ms (5.4%)
tracing	14.877 s [14.877 s, 14.877 s]	95.0 ms (0.6%)

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~ec5b89d719, baseline=1.43.0-SNAPSHOT~4925a50233
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1452, 1475
. : milestone, 1464,
appsec (2.335 ms) : 2293, 2376
. : milestone, 2335,
iast (2.079 ms) : 2027, 2131
. : milestone, 2079,
iast_GLOBAL (2.123 ms) : 2070, 2175
. : milestone, 2123,
profiling (1.938 ms) : 1897, 1980
. : milestone, 1938,
tracing (1.926 ms) : 1886, 1966
. : milestone, 1926,
section candidate
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (2.337 ms) : 2296, 2378
. : milestone, 2337,
iast (2.07 ms) : 2019, 2122
. : milestone, 2070,
iast_GLOBAL (2.116 ms) : 2064, 2168
. : milestone, 2116,
profiling (1.965 ms) : 1922, 2008
. : milestone, 1965,
tracing (1.917 ms) : 1877, 1957
. : milestone, 1917,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.464 ms [1.452 ms, 1.475 ms]	-
appsec	2.335 ms [2.293 ms, 2.376 ms]	871.104 µs (59.5%)
iast	2.079 ms [2.027 ms, 2.131 ms]	615.109 µs (42.0%)
iast_GLOBAL	2.123 ms [2.07 ms, 2.175 ms]	659.087 µs (45.0%)
profiling	1.938 ms [1.897 ms, 1.98 ms]	474.85 µs (32.4%)
tracing	1.926 ms [1.886 ms, 1.966 ms]	462.306 µs (31.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.468 ms [1.456 ms, 1.479 ms]	-
appsec	2.337 ms [2.296 ms, 2.378 ms]	869.481 µs (59.2%)
iast	2.07 ms [2.019 ms, 2.122 ms]	602.902 µs (41.1%)
iast_GLOBAL	2.116 ms [2.064 ms, 2.168 ms]	648.504 µs (44.2%)
profiling	1.965 ms [1.922 ms, 2.008 ms]	497.443 µs (33.9%)
tracing	1.917 ms [1.877 ms, 1.957 ms]	449.27 µs (30.6%)

mcculls

just a small suggestion to improve readability

Fix the temp location manager on J9
124c3b5
(due to a different mechanism to retrieve running JVM processes)

jbachorik added type: bug fix Bug fix tag: no release notes Changes to exclude from release notes comp: profiling Profiling labels Nov 22, 2024

jbachorik requested a review from a team as a code owner November 22, 2024 17:27

mcculls reviewed Nov 22, 2024
View reviewed changes

Comment thread...profiling-controller/src/main/java/com/datadog/profiling/controller/TempLocationManager.java Outdated

mcculls approved these changes Nov 22, 2024
View reviewed changes

Improve condition readability
ec5b89d

jbachorik merged commit 52cf791 into masterNov 25, 2024

jbachorik deleted the jb/profiling_temp_location_1 branch November 25, 2024 09:27

github-actionsBot added this to the 1.43.0 milestone Nov 25, 2024

Navigation Menu

Uh oh!

Fix the temp location manager on J9 - #8002

Fix the temp location manager on J9#8002
jbachorik merged 2 commits into
masterfrom
jb/profiling_temp_location_1

jbachorik commented Nov 22, 2024

Uh oh!

pr-commenterBot commented Nov 22, 2024•
edited
Loading

Uh oh!

Uh oh!

mcculls left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jbachorik commented Nov 22, 2024

What Does This Do

Motivation

Uh oh!

pr-commenterBot commented Nov 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

mcculls left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pr-commenterBot commented Nov 22, 2024•
edited
Loading