Apply the standard nomenclature to the stacktrace configs by jandro996 · Pull Request #8244 · DataDog/dd-trace-java

jandro996 · 2025-01-17T14:05:16Z

What Does This Do

Add STACK_TRACE config properties and set them as principal key in Config class
Keep legacy STACKTRACE config properties and set them as alias

Motivation

Standarize APPSEC and IAST STACK_TRACE config properties

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APPSEC-56384

pr-commenter · 2025-01-17T14:34:54Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alejandro.gonzalez/Standardize-stacktrace-naming
git_commit_date	1737371099	1737372124
git_commit_sha	`4ce36ea`	`20a900c`
release_version	1.46.0-SNAPSHOT~4ce36eae0f	1.46.0-SNAPSHOT~20a900ca81

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1737374385	1737374385
ci_job_id	772539496	772539496
ci_pipeline_id	53464304	53464304
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 2 unstable metrics.

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~20a900ca81, baseline=1.46.0-SNAPSHOT~4ce36eae0f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054547
Total [baseline] (8.644 s) : 0, 8644095
Agent [candidate] (1.054 s) : 0, 1054009
Total [candidate] (8.644 s) : 0, 8644216
section iast
Agent [baseline] (1.191 s) : 0, 1191461
Total [baseline] (9.216 s) : 0, 9216054
Agent [candidate] (1.187 s) : 0, 1186614
Total [candidate] (9.252 s) : 0, 9252140
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.185 s) : 0, 1184690
Total [baseline] (9.178 s) : 0, 9177653
Agent [candidate] (1.189 s) : 0, 1188847
Total [candidate] (9.2 s) : 0, 9200103
section iast_TELEMETRY_OFF
Agent [baseline] (1.179 s) : 0, 1178815
Total [baseline] (9.168 s) : 0, 9168306
Agent [candidate] (1.183 s) : 0, 1182948
Total [candidate] (9.176 s) : 0, 9175778

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.055 s	-
Agent	iast	1.191 s	136.914 ms (13.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.185 s	130.142 ms (12.3%)
Agent	iast_TELEMETRY_OFF	1.179 s	124.268 ms (11.8%)
Total	tracing	8.644 s	-
Total	iast	9.216 s	571.959 ms (6.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.178 s	533.558 ms (6.2%)
Total	iast_TELEMETRY_OFF	9.168 s	524.211 ms (6.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.054 s	-
Agent	iast	1.187 s	132.605 ms (12.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.189 s	134.837 ms (12.8%)
Agent	iast_TELEMETRY_OFF	1.183 s	128.939 ms (12.2%)
Total	tracing	8.644 s	-
Total	iast	9.252 s	607.924 ms (7.0%)
Total	iast_HARDCODED_SECRET_DISABLED	9.2 s	555.887 ms (6.4%)
Total	iast_TELEMETRY_OFF	9.176 s	531.562 ms (6.1%)

gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~20a900ca81, baseline=1.46.0-SNAPSHOT~4ce36eae0f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.464 ms) : 0, 714464
BytebuddyAgent [candidate] (713.181 ms) : 0, 713181
GlobalTracer [baseline] (255.286 ms) : 0, 255286
GlobalTracer [candidate] (255.152 ms) : 0, 255152
AppSec [baseline] (55.527 ms) : 0, 55527
AppSec [candidate] (55.979 ms) : 0, 55979
Remote Config [baseline] (740.507 µs) : 0, 741
Remote Config [candidate] (723.497 µs) : 0, 723
Telemetry [baseline] (13.528 ms) : 0, 13528
Telemetry [candidate] (14.024 ms) : 0, 14024
section iast
BytebuddyAgent [baseline] (838.267 ms) : 0, 838267
BytebuddyAgent [candidate] (833.585 ms) : 0, 833585
GlobalTracer [baseline] (248.174 ms) : 0, 248174
GlobalTracer [candidate] (247.923 ms) : 0, 247923
AppSec [baseline] (58.621 ms) : 0, 58621
AppSec [candidate] (58.645 ms) : 0, 58645
IAST [baseline] (21.666 ms) : 0, 21666
IAST [candidate] (21.888 ms) : 0, 21888
Remote Config [baseline] (679.714 µs) : 0, 680
Remote Config [candidate] (677.964 µs) : 0, 678
Telemetry [baseline] (8.963 ms) : 0, 8963
Telemetry [candidate] (8.854 ms) : 0, 8854
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (832.983 ms) : 0, 832983
BytebuddyAgent [candidate] (835.329 ms) : 0, 835329
GlobalTracer [baseline] (247.127 ms) : 0, 247127
GlobalTracer [candidate] (248.84 ms) : 0, 248840
AppSec [baseline] (58.241 ms) : 0, 58241
AppSec [candidate] (58.545 ms) : 0, 58545
IAST [baseline] (21.755 ms) : 0, 21755
IAST [candidate] (21.661 ms) : 0, 21661
Remote Config [baseline] (673.338 µs) : 0, 673
Remote Config [candidate] (676.446 µs) : 0, 676
Telemetry [baseline] (8.904 ms) : 0, 8904
Telemetry [candidate] (8.76 ms) : 0, 8760
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (828.973 ms) : 0, 828973
BytebuddyAgent [candidate] (832.205 ms) : 0, 832205
GlobalTracer [baseline] (247.01 ms) : 0, 247010
GlobalTracer [candidate] (247.692 ms) : 0, 247692
AppSec [baseline] (57.925 ms) : 0, 57925
AppSec [candidate] (57.927 ms) : 0, 57927
IAST [baseline] (20.642 ms) : 0, 20642
IAST [candidate] (20.683 ms) : 0, 20683
Remote Config [baseline] (660.245 µs) : 0, 660
Remote Config [candidate] (671.464 µs) : 0, 671
Telemetry [baseline] (8.561 ms) : 0, 8561
Telemetry [candidate] (8.59 ms) : 0, 8590

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~20a900ca81, baseline=1.46.0-SNAPSHOT~4ce36eae0f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064287
Total [baseline] (10.547 s) : 0, 10546680
Agent [candidate] (1.057 s) : 0, 1056623
Total [candidate] (10.457 s) : 0, 10456944
section appsec
Agent [baseline] (1.196 s) : 0, 1195816
Total [baseline] (10.734 s) : 0, 10734092
Agent [candidate] (1.189 s) : 0, 1189125
Total [candidate] (10.728 s) : 0, 10728362
section iast
Agent [baseline] (1.185 s) : 0, 1185197
Total [baseline] (10.935 s) : 0, 10935260
Agent [candidate] (1.184 s) : 0, 1183889
Total [candidate] (11.032 s) : 0, 11031853
section profiling
Agent [baseline] (1.258 s) : 0, 1257998
Total [baseline] (10.796 s) : 0, 10796493
Agent [candidate] (1.261 s) : 0, 1261112
Total [candidate] (10.706 s) : 0, 10705628

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.064 s	-
Agent	appsec	1.196 s	131.529 ms (12.4%)
Agent	iast	1.185 s	120.911 ms (11.4%)
Agent	profiling	1.258 s	193.711 ms (18.2%)
Total	tracing	10.547 s	-
Total	appsec	10.734 s	187.412 ms (1.8%)
Total	iast	10.935 s	388.58 ms (3.7%)
Total	profiling	10.796 s	249.814 ms (2.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.057 s	-
Agent	appsec	1.189 s	132.502 ms (12.5%)
Agent	iast	1.184 s	127.267 ms (12.0%)
Agent	profiling	1.261 s	204.49 ms (19.4%)
Total	tracing	10.457 s	-
Total	appsec	10.728 s	271.418 ms (2.6%)
Total	iast	11.032 s	574.909 ms (5.5%)
Total	profiling	10.706 s	248.684 ms (2.4%)

gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~20a900ca81, baseline=1.46.0-SNAPSHOT~4ce36eae0f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.832 ms) : 0, 719832
BytebuddyAgent [candidate] (714.407 ms) : 0, 714407
GlobalTracer [baseline] (257.551 ms) : 0, 257551
GlobalTracer [candidate] (255.786 ms) : 0, 255786
AppSec [baseline] (58.069 ms) : 0, 58069
AppSec [candidate] (55.636 ms) : 0, 55636
Remote Config [baseline] (744.891 µs) : 0, 745
Remote Config [candidate] (737.455 µs) : 0, 737
Telemetry [baseline] (12.883 ms) : 0, 12883
Telemetry [candidate] (15.017 ms) : 0, 15017
section appsec
BytebuddyAgent [baseline] (735.873 ms) : 0, 735873
BytebuddyAgent [candidate] (731.346 ms) : 0, 731346
GlobalTracer [baseline] (254.587 ms) : 0, 254587
GlobalTracer [candidate] (253.507 ms) : 0, 253507
AppSec [baseline] (171.586 ms) : 0, 171586
AppSec [candidate] (170.674 ms) : 0, 170674
IAST [baseline] (19.541 ms) : 0, 19541
IAST [candidate] (19.329 ms) : 0, 19329
Remote Config [baseline] (673.731 µs) : 0, 674
Remote Config [candidate] (662.561 µs) : 0, 663
Telemetry [baseline] (8.25 ms) : 0, 8250
Telemetry [candidate] (8.206 ms) : 0, 8206
section iast
BytebuddyAgent [baseline] (833.34 ms) : 0, 833340
BytebuddyAgent [candidate] (832.831 ms) : 0, 832831
GlobalTracer [baseline] (247.617 ms) : 0, 247617
GlobalTracer [candidate] (247.042 ms) : 0, 247042
AppSec [baseline] (58.166 ms) : 0, 58166
AppSec [candidate] (58.04 ms) : 0, 58040
IAST [baseline] (21.563 ms) : 0, 21563
IAST [candidate] (21.515 ms) : 0, 21515
Remote Config [baseline] (663.29 µs) : 0, 663
Remote Config [candidate] (672.148 µs) : 0, 672
Telemetry [baseline] (8.777 ms) : 0, 8777
Telemetry [candidate] (8.741 ms) : 0, 8741
section profiling
BytebuddyAgent [baseline] (706.282 ms) : 0, 706282
BytebuddyAgent [candidate] (708.255 ms) : 0, 708255
GlobalTracer [baseline] (349.061 ms) : 0, 349061
GlobalTracer [candidate] (351.178 ms) : 0, 351178
AppSec [baseline] (55.613 ms) : 0, 55613
AppSec [candidate] (54.665 ms) : 0, 54665
Remote Config [baseline] (700.506 µs) : 0, 701
Remote Config [candidate] (714.448 µs) : 0, 714
Telemetry [baseline] (8.8 ms) : 0, 8800
Telemetry [candidate] (8.812 ms) : 0, 8812
ProfilingAgent [baseline] (95.478 ms) : 0, 95478
ProfilingAgent [candidate] (95.237 ms) : 0, 95237
Profiling [baseline] (95.502 ms) : 0, 95502
Profiling [candidate] (95.261 ms) : 0, 95261

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-01-20T11:31:50	2025-01-20T11:38:53
git_branch	master	alejandro.gonzalez/Standardize-stacktrace-naming
git_commit_date	1737371099	1737372124
git_commit_sha	`4ce36ea`	`20a900c`
release_version	1.46.0-SNAPSHOT~4ce36eae0f	1.46.0-SNAPSHOT~20a900ca81
start_time	2025-01-20T11:31:36	2025-01-20T11:38:39

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1737373489	1737373489
ci_job_id	772539497	772539497
ci_pipeline_id	53464304	53464304
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~20a900ca81, baseline=1.46.0-SNAPSHOT~4ce36eae0f
dateFormat X
axisFormat %s
section baseline
no_agent (383.681 µs) : 364, 404
. : milestone, 384,
iast (506.209 µs) : 484, 529
. : milestone, 506,
iast_FULL (737.401 µs) : 715, 759
. : milestone, 737,
iast_GLOBAL (545.364 µs) : 524, 567
. : milestone, 545,
iast_HARDCODED_SECRET_DISABLED (498.838 µs) : 477, 520
. : milestone, 499,
iast_INACTIVE (449.055 µs) : 428, 470
. : milestone, 449,
iast_TELEMETRY_OFF (488.376 µs) : 467, 510
. : milestone, 488,
tracing (457.977 µs) : 433, 483
. : milestone, 458,
section candidate
no_agent (376.741 µs) : 357, 396
. : milestone, 377,
iast (499.432 µs) : 478, 521
. : milestone, 499,
iast_FULL (742.407 µs) : 720, 765
. : milestone, 742,
iast_GLOBAL (540.583 µs) : 519, 562
. : milestone, 541,
iast_HARDCODED_SECRET_DISABLED (497.324 µs) : 475, 520
. : milestone, 497,
iast_INACTIVE (452.239 µs) : 431, 474
. : milestone, 452,
iast_TELEMETRY_OFF (487.101 µs) : 466, 509
. : milestone, 487,
tracing (441.629 µs) : 421, 462
. : milestone, 442,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	383.681 µs [363.806 µs, 403.555 µs]	-
iast	506.209 µs [483.831 µs, 528.588 µs]	122.529 µs (31.9%)
iast_FULL	737.401 µs [715.459 µs, 759.343 µs]	353.72 µs (92.2%)
iast_GLOBAL	545.364 µs [523.715 µs, 567.012 µs]	161.683 µs (42.1%)
iast_HARDCODED_SECRET_DISABLED	498.838 µs [477.338 µs, 520.339 µs]	115.158 µs (30.0%)
iast_INACTIVE	449.055 µs [428.103 µs, 470.008 µs]	65.375 µs (17.0%)
iast_TELEMETRY_OFF	488.376 µs [466.756 µs, 509.996 µs]	104.695 µs (27.3%)
tracing	457.977 µs [433.032 µs, 482.921 µs]	74.296 µs (19.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	376.741 µs [357.131 µs, 396.35 µs]	-
iast	499.432 µs [477.606 µs, 521.259 µs]	122.692 µs (32.6%)
iast_FULL	742.407 µs [719.965 µs, 764.85 µs]	365.667 µs (97.1%)
iast_GLOBAL	540.583 µs [518.912 µs, 562.254 µs]	163.843 µs (43.5%)
iast_HARDCODED_SECRET_DISABLED	497.324 µs [474.95 µs, 519.699 µs]	120.584 µs (32.0%)
iast_INACTIVE	452.239 µs [430.777 µs, 473.702 µs]	75.499 µs (20.0%)
iast_TELEMETRY_OFF	487.101 µs [465.57 µs, 508.631 µs]	110.36 µs (29.3%)
tracing	441.629 µs [421.164 µs, 462.093 µs]	64.888 µs (17.2%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~20a900ca81, baseline=1.46.0-SNAPSHOT~4ce36eae0f
dateFormat X
axisFormat %s
section baseline
no_agent (1.371 ms) : 1351, 1390
. : milestone, 1371,
appsec (1.75 ms) : 1725, 1774
. : milestone, 1750,
appsec_no_iast (1.761 ms) : 1737, 1785
. : milestone, 1761,
iast (1.503 ms) : 1478, 1527
. : milestone, 1503,
profiling (1.563 ms) : 1539, 1587
. : milestone, 1563,
tracing (1.477 ms) : 1452, 1502
. : milestone, 1477,
section candidate
no_agent (1.342 ms) : 1323, 1362
. : milestone, 1342,
appsec (1.747 ms) : 1723, 1771
. : milestone, 1747,
appsec_no_iast (1.751 ms) : 1728, 1773
. : milestone, 1751,
iast (1.512 ms) : 1488, 1537
. : milestone, 1512,
profiling (1.51 ms) : 1487, 1533
. : milestone, 1510,
tracing (1.469 ms) : 1443, 1495
. : milestone, 1469,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.371 ms [1.351 ms, 1.39 ms]	-
appsec	1.75 ms [1.725 ms, 1.774 ms]	379.017 µs (27.7%)
appsec_no_iast	1.761 ms [1.737 ms, 1.785 ms]	390.416 µs (28.5%)
iast	1.503 ms [1.478 ms, 1.527 ms]	131.95 µs (9.6%)
profiling	1.563 ms [1.539 ms, 1.587 ms]	192.185 µs (14.0%)
tracing	1.477 ms [1.452 ms, 1.502 ms]	106.125 µs (7.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.342 ms [1.323 ms, 1.362 ms]	-
appsec	1.747 ms [1.723 ms, 1.771 ms]	405.041 µs (30.2%)
appsec_no_iast	1.751 ms [1.728 ms, 1.773 ms]	408.543 µs (30.4%)
iast	1.512 ms [1.488 ms, 1.537 ms]	170.046 µs (12.7%)
profiling	1.51 ms [1.487 ms, 1.533 ms]	167.823 µs (12.5%)
tracing	1.469 ms [1.443 ms, 1.495 ms]	127.026 µs (9.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alejandro.gonzalez/Standardize-stacktrace-naming
git_commit_date	1737371099	1737372124
git_commit_sha	`4ce36ea`	`20a900c`
release_version	1.46.0-SNAPSHOT~4ce36eae0f	1.46.0-SNAPSHOT~20a900ca81

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1737373942	1737373942
ci_job_id	772539498	772539498
ci_pipeline_id	53464304	53464304
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~20a900ca81, baseline=1.46.0-SNAPSHOT~4ce36eae0f
dateFormat X
axisFormat %s
section baseline
no_agent (1.465 ms) : 1454, 1476
. : milestone, 1465,
appsec (2.353 ms) : 2310, 2396
. : milestone, 2353,
iast (2.095 ms) : 2041, 2149
. : milestone, 2095,
iast_GLOBAL (2.136 ms) : 2082, 2190
. : milestone, 2136,
profiling (1.967 ms) : 1924, 2011
. : milestone, 1967,
tracing (1.927 ms) : 1885, 1968
. : milestone, 1927,
section candidate
no_agent (1.465 ms) : 1453, 1476
. : milestone, 1465,
appsec (2.347 ms) : 2304, 2390
. : milestone, 2347,
iast (2.105 ms) : 2050, 2160
. : milestone, 2105,
iast_GLOBAL (2.14 ms) : 2086, 2195
. : milestone, 2140,
profiling (1.96 ms) : 1917, 2003
. : milestone, 1960,
tracing (1.932 ms) : 1891, 1974
. : milestone, 1932,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.465 ms [1.454 ms, 1.476 ms]	-
appsec	2.353 ms [2.31 ms, 2.396 ms]	887.781 µs (60.6%)
iast	2.095 ms [2.041 ms, 2.149 ms]	630.086 µs (43.0%)
iast_GLOBAL	2.136 ms [2.082 ms, 2.19 ms]	671.063 µs (45.8%)
profiling	1.967 ms [1.924 ms, 2.011 ms]	502.389 µs (34.3%)
tracing	1.927 ms [1.885 ms, 1.968 ms]	461.516 µs (31.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.465 ms [1.453 ms, 1.476 ms]	-
appsec	2.347 ms [2.304 ms, 2.39 ms]	882.416 µs (60.2%)
iast	2.105 ms [2.05 ms, 2.16 ms]	640.314 µs (43.7%)
iast_GLOBAL	2.14 ms [2.086 ms, 2.195 ms]	675.373 µs (46.1%)
profiling	1.96 ms [1.917 ms, 2.003 ms]	495.223 µs (33.8%)
tracing	1.932 ms [1.891 ms, 1.974 ms]	467.623 µs (31.9%)

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~20a900ca81, baseline=1.46.0-SNAPSHOT~4ce36eae0f
dateFormat X
axisFormat %s
section baseline
no_agent (14.722 s) : 14722000, 14722000
. : milestone, 14722000,
appsec (14.955 s) : 14955000, 14955000
. : milestone, 14955000,
iast (18.831 s) : 18831000, 18831000
. : milestone, 18831000,
iast_GLOBAL (17.781 s) : 17781000, 17781000
. : milestone, 17781000,
profiling (15.765 s) : 15765000, 15765000
. : milestone, 15765000,
tracing (14.757 s) : 14757000, 14757000
. : milestone, 14757000,
section candidate
no_agent (15.239 s) : 15239000, 15239000
. : milestone, 15239000,
appsec (15.008 s) : 15008000, 15008000
. : milestone, 15008000,
iast (18.614 s) : 18614000, 18614000
. : milestone, 18614000,
iast_GLOBAL (17.99 s) : 17990000, 17990000
. : milestone, 17990000,
profiling (15.355 s) : 15355000, 15355000
. : milestone, 15355000,
tracing (15.008 s) : 15008000, 15008000
. : milestone, 15008000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.722 s [14.722 s, 14.722 s]	-
appsec	14.955 s [14.955 s, 14.955 s]	233.0 ms (1.6%)
iast	18.831 s [18.831 s, 18.831 s]	4.109 s (27.9%)
iast_GLOBAL	17.781 s [17.781 s, 17.781 s]	3.059 s (20.8%)
profiling	15.765 s [15.765 s, 15.765 s]	1.043 s (7.1%)
tracing	14.757 s [14.757 s, 14.757 s]	35.0 ms (0.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.239 s [15.239 s, 15.239 s]	-
appsec	15.008 s [15.008 s, 15.008 s]	-231.0 ms (-1.5%)
iast	18.614 s [18.614 s, 18.614 s]	3.375 s (22.1%)
iast_GLOBAL	17.99 s [17.99 s, 17.99 s]	2.751 s (18.1%)
profiling	15.355 s [15.355 s, 15.355 s]	116.0 ms (0.8%)
tracing	15.008 s [15.008 s, 15.008 s]	-231.0 ms (-1.5%)

github-actions · 2025-01-17T14:42:36Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

…naming

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.25.4` -> `2.26.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | --- ### Release Notes <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.26.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2260-2025-01-29) ##### Features - Add firestoreInDatastoreMode for datastore emulator ([#1698](googleapis/java-datastore#1698)) ([50f106d](googleapis/java-datastore@50f106d)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.42.0 ([#1725](googleapis/java-datastore#1725)) ([1cbaf22](googleapis/java-datastore@1cbaf22)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.46.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.46.0): 1.46.0 ##### Breaking Changes > \[!WARNING] > jnr-unixsocket is now an external dependency of dd-trace-ot and must be included when deploying dd-trace-ot. > \[!NOTE] > The API `TracerScope.setAsync(boolean)`, used to manually control asynchronous span propagation, does no more apply to the scope instance but to the active span scope. ##### Components ##### Application Security Management (IAST) - 🐛 Fix String.replace instrumentation for IAST ([#8281](DataDog/dd-trace-java#8281) - [@Mariovido](https://github.com/Mariovido)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Exclude false positive weak randomness ([#8232](DataDog/dd-trace-java#8232) - [@jandro996](https://github.com/jandro996)) - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Add security control metrics ([#8175](DataDog/dd-trace-java#8175) - [@jandro996](https://github.com/jandro996)) - ✨ Increase IAST propagation to StringBuffer setLength ([#8128](DataDog/dd-trace-java#8128) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST taint tracking for DB values ([#8072](DataDog/dd-trace-java#8072) - [@Mariovido](https://github.com/Mariovido)) ##### Application Security Management (WAF) - 🐛 Prevents a NPE when there is no subscriber for user events ([#8258](DataDog/dd-trace-java#8258) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Ensure cached subscriptions are cleared on reconfiguration via RC ([#8229](DataDog/dd-trace-java#8229) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Create span tag: \_dd.appsec.rasp.timeout ([#8269](DataDog/dd-trace-java#8269) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - 🐛 Ensure shaded helpers have unique names when injected into class-loaders ([#8192](DataDog/dd-trace-java#8192) - [@mcculls](https://github.com/mcculls)) ##### Configuration at Runtime - 🐛 Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer ([#8176](DataDog/dd-trace-java#8176) - [@mhlidd](https://github.com/mhlidd)) ##### Continuous Integration Visibility - 🧹 Generalize TestRetryPolicy to TestExecutionPolicy ([#8302](DataDog/dd-trace-java#8302) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Parallelize CI Visibility settings requests ([#8299](DataDog/dd-trace-java#8299) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize test retry logic ([#8289](DataDog/dd-trace-java#8289) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize tests skipping logic ([#8288](DataDog/dd-trace-java#8288) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Remove skip and shouldBeSkipped methods from TestEventsHandler in favor of isSkippable ([#8286](DataDog/dd-trace-java#8286) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Optimize Git repository information computation ([#8270](DataDog/dd-trace-java#8270) - [@dougqh](https://github.com/dougqh)) - ✨ Always request known tests from the backend ([#8268](DataDog/dd-trace-java#8268) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Fix NPE when trying to get retry analyzer in Test NG ([#8253](DataDog/dd-trace-java#8253) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Set test framework and test framework version tags atomically ([#8252](DataDog/dd-trace-java#8252) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add debug logging to Android Gradle module layout logic ([#8251](DataDog/dd-trace-java#8251) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix source and destination folders computation for Android Gradle projects ([#8190](DataDog/dd-trace-java#8190) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add basic Scala Weaver sbt support ([#8189](DataDog/dd-trace-java#8189) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement impacted tests detection ([#8188](DataDog/dd-trace-java#8188) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Data Streams Monitoring - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Database Monitoring - Add peer service tag in dbm sql commenter ([#7913](DataDog/dd-trace-java#7913) - [@jordan-wong](https://github.com/jordan-wong)) ##### Dynamic Instrumentation - ✨ Add support for SymDB to scan directories ([#8306](DataDog/dd-trace-java#8306) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add SymDB report for any jar scanning failures ([#8300](DataDog/dd-trace-java#8300) - [@jpbempel](https://github.com/jpbempel)) - ✨ Use two budgets depending on type ([#8283](DataDog/dd-trace-java#8283) - [@evanchooly](https://github.com/evanchooly)) - ✨ Institute a 10 snapshot per probe per trace budget ([#8277](DataDog/dd-trace-java#8277) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Avoid double snapshots for Exception Replay ([#8273](DataDog/dd-trace-java#8273) - [@jpbempel](https://github.com/jpbempel)) - ✨ Simplify code origins. Separate out snapshot generation. ([#8263](DataDog/dd-trace-java#8263) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add Exception probe custom instrumentation ([#8230](DataDog/dd-trace-java#8230) - [@jpbempel](https://github.com/jpbempel)) - ✨ Enhance log probes to honor debug session tags ([#8215](DataDog/dd-trace-java#8215) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Don't redact env tokens from debugger probe snapshots ([#8211](DataDog/dd-trace-java#8211) - [@watson](https://github.com/watson)) - ✨⚡ Move Trace/SpanId capture at commit time ([#8184](DataDog/dd-trace-java#8184) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Capture values at entry for method probe ([#8169](DataDog/dd-trace-java#8169) - [@jpbempel](https://github.com/jpbempel)) ##### JMX fetch - 🐛 Mute JMXFetch Shutdown in progress error ([#8068](DataDog/dd-trace-java#8068) - [@ygree](https://github.com/ygree)) ##### OpenTracing - ⚠️🧹 Make jnr-unixsocket an explicit dependency of dd-trace-ot ([#8307](DataDog/dd-trace-java#8307) - [@mcculls](https://github.com/mcculls)) ##### Profiling - 🐛 Avoid unsupported API call for creating folders on windows ([#8304](DataDog/dd-trace-java#8304) - [@jbachorik](https://github.com/jbachorik)) - ✨ Tag profiles for serverless ([#8279](DataDog/dd-trace-java#8279) - [@jbachorik](https://github.com/jbachorik)) - ✨ add queue type and length to queue events ([#8242](DataDog/dd-trace-java#8242) - [@richardstartin](https://github.com/richardstartin)) - 🐛 TempLocationManager Fixes and Improvements ([#8191](DataDog/dd-trace-java#8191) - [@jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.18.0 ([#8173](DataDog/dd-trace-java#8173) - [@jbachorik](https://github.com/jbachorik)) - ✨ Report profiler initialization and configuration errors to telemetry ([#8171](DataDog/dd-trace-java#8171) - [@jbachorik](https://github.com/jbachorik)) ##### Telemetry - ✨ Add pending traces report in tracer flares ([#8053](DataDog/dd-trace-java#8053) - [@mhlidd](https://github.com/mhlidd)) ##### Testing - ✨ Test http server requests in parallel ([#8222](DataDog/dd-trace-java#8222) - [@amarziali](https://github.com/amarziali)) ##### Trace context propagation - ✨ Add non default propagator registration ([#8310](DataDog/dd-trace-java#8310) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - ✨ Probe for existence of IBMSASL or ACCP security providers ([#8276](DataDog/dd-trace-java#8276) - [@mcculls](https://github.com/mcculls)) - ✨⚡ Overhead improvement to agent feedback based sampling ([#8265](DataDog/dd-trace-java#8265) - [@dougqh](https://github.com/dougqh)) - 🧹 Move async propagation API from scope to tracer ([#8231](DataDog/dd-trace-java#8231) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Introduce context propagation API ([#8161](DataDog/dd-trace-java#8161) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🧪 Use env-entry to add tags per webapp deployment ([#8138](DataDog/dd-trace-java#8138) - [@amarziali](https://github.com/amarziali)) - ✨ Introduce context helpers API ([#8134](DataDog/dd-trace-java#8134) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Support IPv6 values for `DD_AGENT_HOST` and `DD_TRACE_AGENT_URL` ([#7984](DataDog/dd-trace-java#7984) - [@mhlidd](https://github.com/mhlidd)) ##### Instrumentations ##### Apache HttpComponents - 🐛 Properly finish spans and support latest apache httpclient5 ([#8272](DataDog/dd-trace-java#8272) - [@amarziali](https://github.com/amarziali)) ##### AWS Lambda instrumentation - 🐛 Properly capture lambda payloads for all handler types. ([#8264](DataDog/dd-trace-java#8264) - [@purple4reina](https://github.com/purple4reina)) ##### AWS S3 instrumentation - 💡 Create S3 instrumentation + add span pointers ([#8075](DataDog/dd-trace-java#8075) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Revert "Add avoid double instrumenting lambda non-streaming handlers." ([#8247](DataDog/dd-trace-java#8247) - [@nhulston](https://github.com/nhulston)) ##### Cassandra - ✨ Allow extracting keyspace from statement result ([#8239](DataDog/dd-trace-java#8239) - [@amarziali](https://github.com/amarziali)) ##### Core Java language instrumentation - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Eclipse Vert.x instrumentation - 🐛 Fix vertx worker propagation and error handling ([#8237](DataDog/dd-trace-java#8237) - [@amarziali](https://github.com/amarziali)) - ✨ Support vertx 5 ([#8220](DataDog/dd-trace-java#8220) - [@amarziali](https://github.com/amarziali)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) ##### Kafka instrumentation - 🐛 Prevent possible NPE calculating Kafka record header size ([#8292](DataDog/dd-trace-java#8292) - [@ygree](https://github.com/ygree)) ##### Mule instrumentation - 🐛 Fix crash using Mule with JPMS ([#8187](DataDog/dd-trace-java#8187) - [@amarziali](https://github.com/amarziali)) ##### Protocol Buffer instrumentation - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Spring instrumentation - 🐛 Preserve getQualifier from spring scheduling runnables ([#8293](DataDog/dd-trace-java#8293) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: bb09d47e4eed77a003f630273b4d0a84003eb899

Apply the standard nomenclature to the stacktrace configs
929c372

jandro996 marked this pull request as ready for review January 17, 2025 14:42

jandro996 requested review from a team as code owners January 17, 2025 14:42

jandro996 requested review from sezen-datadog and smola January 17, 2025 14:42

smola reviewed Jan 17, 2025
View reviewed changes

Comment threaddd-trace-api/src/main/java/datadog/trace/api/config/AppSecConfig.java Outdated

rename to add the DEPRECATED subfix
1506fd5

jandro996 requested a review from smola January 17, 2025 14:57

smola approved these changes Jan 17, 2025
View reviewed changes

smola added type: feature Enhancements and improvements comp: asm waf Application Security Management (WAF) comp: asm iast Application Security Management (IAST) labels Jan 17, 2025

jandro996 added 2 commits January 20, 2025 09:01

Merge branch 'master' into alejandro.gonzalez/Standardize-stacktrace-…
02d36a5
…naming

Merge branch 'master' into alejandro.gonzalez/Standardize-stacktrace-…
20a900c
…naming

jandro996 added comp: api Tracer public API and removed comp: api Tracer public API labels Jan 20, 2025

jandro996 merged commit 2616b64 into masterJan 20, 2025

jandro996 deleted the alejandro.gonzalez/Standardize-stacktrace-naming branch January 20, 2025 13:46

github-actionsBot added this to the 1.46.0 milestone Jan 20, 2025

Navigation Menu

Uh oh!

Apply the standard nomenclature to the stacktrace configs - #8244

Apply the standard nomenclature to the stacktrace configs#8244
jandro996 merged 4 commits into
masterfrom
alejandro.gonzalez/Standardize-stacktrace-naming

jandro996 commented Jan 17, 2025•
edited by atlassian Bot
Loading

Uh oh!

pr-commenterBot commented Jan 17, 2025•
edited
Loading

Uh oh!

github-actionsBot commented Jan 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jandro996 commented Jan 17, 2025• edited by atlassian BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenterBot commented Jan 17, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

github-actionsBot commented Jan 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jandro996 commented Jan 17, 2025•
edited by atlassian Bot
Loading

pr-commenterBot commented Jan 17, 2025•
edited
Loading