Fix NPE when trying to get retry analyzer in Test NG by nikita-tkachenko-datadog · Pull Request #8253 · DataDog/dd-trace-java

nikita-tkachenko-datadog · 2025-01-20T14:03:03Z

What Does This Do

Fixes an NPE that was written to the logs when trying to get Test NG retry analyzer for test result instances that had no test method associated with them.
The exception was caught and null was returned.
Now a null-check is done and null is returned without throwing an exception, so the there is no spamming the logs.

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-01-20T14:41:07Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	nikita-tkachenko/testng-retry-analyzer-npe
git_commit_date	1737381499	1737381605
git_commit_sha	`ea4856f`	`ab64d4e`
release_version	1.46.0-SNAPSHOT~ea4856fb98	1.46.0-SNAPSHOT~ab64d4e4a0

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1737384021	1737384021
ci_job_id	772779827	772779827
ci_pipeline_id	53479567	53479567
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics.

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~ab64d4e4a0, baseline=1.46.0-SNAPSHOT~ea4856fb98
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066142
Total [baseline] (10.576 s) : 0, 10575951
Agent [candidate] (1.064 s) : 0, 1063697
Total [candidate] (10.483 s) : 0, 10483338
section appsec
Agent [baseline] (1.199 s) : 0, 1198615
Total [baseline] (10.776 s) : 0, 10775954
Agent [candidate] (1.191 s) : 0, 1190532
Total [candidate] (10.746 s) : 0, 10745811
section iast
Agent [baseline] (1.188 s) : 0, 1187750
Total [baseline] (11.026 s) : 0, 11026165
Agent [candidate] (1.194 s) : 0, 1194016
Total [candidate] (11.049 s) : 0, 11048894
section profiling
Agent [baseline] (1.255 s) : 0, 1255177
Total [baseline] (10.835 s) : 0, 10834604
Agent [candidate] (1.255 s) : 0, 1254889
Total [candidate] (10.822 s) : 0, 10821667

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.066 s	-
Agent	appsec	1.199 s	132.473 ms (12.4%)
Agent	iast	1.188 s	121.608 ms (11.4%)
Agent	profiling	1.255 s	189.035 ms (17.7%)
Total	tracing	10.576 s	-
Total	appsec	10.776 s	200.003 ms (1.9%)
Total	iast	11.026 s	450.214 ms (4.3%)
Total	profiling	10.835 s	258.653 ms (2.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.064 s	-
Agent	appsec	1.191 s	126.835 ms (11.9%)
Agent	iast	1.194 s	130.319 ms (12.3%)
Agent	profiling	1.255 s	191.193 ms (18.0%)
Total	tracing	10.483 s	-
Total	appsec	10.746 s	262.473 ms (2.5%)
Total	iast	11.049 s	565.556 ms (5.4%)
Total	profiling	10.822 s	338.329 ms (3.2%)

gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~ab64d4e4a0, baseline=1.46.0-SNAPSHOT~ea4856fb98
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.775 ms) : 0, 723775
BytebuddyAgent [candidate] (720.36 ms) : 0, 720360
GlobalTracer [baseline] (257.301 ms) : 0, 257301
GlobalTracer [candidate] (257.203 ms) : 0, 257203
AppSec [baseline] (55.967 ms) : 0, 55967
AppSec [candidate] (55.718 ms) : 0, 55718
Remote Config [baseline] (745.667 µs) : 0, 746
Remote Config [candidate] (746.799 µs) : 0, 747
Telemetry [baseline] (13.058 ms) : 0, 13058
Telemetry [candidate] (14.529 ms) : 0, 14529
section appsec
BytebuddyAgent [baseline] (737.616 ms) : 0, 737616
BytebuddyAgent [candidate] (731.742 ms) : 0, 731742
GlobalTracer [baseline] (255.218 ms) : 0, 255218
GlobalTracer [candidate] (253.746 ms) : 0, 253746
AppSec [baseline] (171.727 ms) : 0, 171727
AppSec [candidate] (171.007 ms) : 0, 171007
Remote Config [baseline] (678.548 µs) : 0, 679
Remote Config [candidate] (673.176 µs) : 0, 673
Telemetry [baseline] (8.576 ms) : 0, 8576
Telemetry [candidate] (8.593 ms) : 0, 8593
IAST [baseline] (19.408 ms) : 0, 19408
IAST [candidate] (19.541 ms) : 0, 19541
section iast
BytebuddyAgent [baseline] (835.152 ms) : 0, 835152
BytebuddyAgent [candidate] (839.38 ms) : 0, 839380
GlobalTracer [baseline] (247.828 ms) : 0, 247828
GlobalTracer [candidate] (249.23 ms) : 0, 249230
AppSec [baseline] (58.49 ms) : 0, 58490
AppSec [candidate] (58.774 ms) : 0, 58774
Remote Config [baseline] (669.801 µs) : 0, 670
Remote Config [candidate] (664.701 µs) : 0, 665
Telemetry [baseline] (8.857 ms) : 0, 8857
Telemetry [candidate] (8.877 ms) : 0, 8877
IAST [baseline] (21.665 ms) : 0, 21665
IAST [candidate] (22.014 ms) : 0, 22014
section profiling
BytebuddyAgent [baseline] (704.469 ms) : 0, 704469
BytebuddyAgent [candidate] (703.8 ms) : 0, 703800
GlobalTracer [baseline] (349.539 ms) : 0, 349539
GlobalTracer [candidate] (350.655 ms) : 0, 350655
AppSec [baseline] (54.879 ms) : 0, 54879
AppSec [candidate] (53.864 ms) : 0, 53864
Remote Config [baseline] (721.773 µs) : 0, 722
Remote Config [candidate] (700.272 µs) : 0, 700
Telemetry [baseline] (8.889 ms) : 0, 8889
Telemetry [candidate] (8.785 ms) : 0, 8785
ProfilingAgent [baseline] (94.738 ms) : 0, 94738
ProfilingAgent [candidate] (95.098 ms) : 0, 95098
Profiling [baseline] (94.766 ms) : 0, 94766
Profiling [candidate] (95.125 ms) : 0, 95125

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~ab64d4e4a0, baseline=1.46.0-SNAPSHOT~ea4856fb98
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062601
Total [baseline] (8.641 s) : 0, 8641110
Agent [candidate] (1.057 s) : 0, 1056735
Total [candidate] (8.642 s) : 0, 8641686
section iast
Agent [baseline] (1.187 s) : 0, 1187458
Total [baseline] (9.226 s) : 0, 9226465
Agent [candidate] (1.206 s) : 0, 1205766
Total [candidate] (9.276 s) : 0, 9275679
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.183 s) : 0, 1183316
Total [baseline] (9.171 s) : 0, 9171160
Agent [candidate] (1.185 s) : 0, 1184933
Total [candidate] (9.212 s) : 0, 9211977
section iast_TELEMETRY_OFF
Agent [baseline] (1.181 s) : 0, 1181208
Total [baseline] (9.205 s) : 0, 9204770
Agent [candidate] (1.188 s) : 0, 1187770
Total [candidate] (9.223 s) : 0, 9222523

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.063 s	-
Agent	iast	1.187 s	124.857 ms (11.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.183 s	120.716 ms (11.4%)
Agent	iast_TELEMETRY_OFF	1.181 s	118.607 ms (11.2%)
Total	tracing	8.641 s	-
Total	iast	9.226 s	585.355 ms (6.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.171 s	530.051 ms (6.1%)
Total	iast_TELEMETRY_OFF	9.205 s	563.661 ms (6.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.057 s	-
Agent	iast	1.206 s	149.031 ms (14.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.185 s	128.197 ms (12.1%)
Agent	iast_TELEMETRY_OFF	1.188 s	131.035 ms (12.4%)
Total	tracing	8.642 s	-
Total	iast	9.276 s	633.993 ms (7.3%)
Total	iast_HARDCODED_SECRET_DISABLED	9.212 s	570.291 ms (6.6%)
Total	iast_TELEMETRY_OFF	9.223 s	580.837 ms (6.7%)

gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~ab64d4e4a0, baseline=1.46.0-SNAPSHOT~ea4856fb98
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.854 ms) : 0, 718854
BytebuddyAgent [candidate] (714.013 ms) : 0, 714013
GlobalTracer [baseline] (257.092 ms) : 0, 257092
GlobalTracer [candidate] (255.725 ms) : 0, 255725
AppSec [baseline] (57.945 ms) : 0, 57945
AppSec [candidate] (56.224 ms) : 0, 56224
Remote Config [baseline] (755.738 µs) : 0, 756
Remote Config [candidate] (735.254 µs) : 0, 735
Telemetry [baseline] (12.816 ms) : 0, 12816
Telemetry [candidate] (15.007 ms) : 0, 15007
section iast
BytebuddyAgent [baseline] (836.087 ms) : 0, 836087
BytebuddyAgent [candidate] (849.849 ms) : 0, 849849
GlobalTracer [baseline] (246.612 ms) : 0, 246612
GlobalTracer [candidate] (250.016 ms) : 0, 250016
AppSec [baseline] (58.389 ms) : 0, 58389
AppSec [candidate] (59.017 ms) : 0, 59017
Remote Config [baseline] (686.717 µs) : 0, 687
Remote Config [candidate] (688.862 µs) : 0, 689
Telemetry [baseline] (8.92 ms) : 0, 8920
Telemetry [candidate] (8.963 ms) : 0, 8963
IAST [baseline] (21.707 ms) : 0, 21707
IAST [candidate] (21.868 ms) : 0, 21868
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (831.984 ms) : 0, 831984
BytebuddyAgent [candidate] (832.836 ms) : 0, 832836
GlobalTracer [baseline] (246.931 ms) : 0, 246931
GlobalTracer [candidate] (247.34 ms) : 0, 247340
AppSec [baseline] (58.283 ms) : 0, 58283
AppSec [candidate] (58.468 ms) : 0, 58468
Remote Config [baseline] (678.199 µs) : 0, 678
Remote Config [candidate] (683.543 µs) : 0, 684
Telemetry [baseline] (8.805 ms) : 0, 8805
Telemetry [candidate] (8.892 ms) : 0, 8892
IAST [baseline] (21.659 ms) : 0, 21659
IAST [candidate] (21.745 ms) : 0, 21745
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (830.631 ms) : 0, 830631
BytebuddyAgent [candidate] (835.763 ms) : 0, 835763
GlobalTracer [baseline] (247.113 ms) : 0, 247113
GlobalTracer [candidate] (248.351 ms) : 0, 248351
AppSec [baseline] (58.279 ms) : 0, 58279
AppSec [candidate] (58.08 ms) : 0, 58080
Remote Config [baseline] (667.991 µs) : 0, 668
Remote Config [candidate] (674.097 µs) : 0, 674
Telemetry [baseline] (8.679 ms) : 0, 8679
Telemetry [candidate] (8.704 ms) : 0, 8704
IAST [baseline] (20.812 ms) : 0, 20812
IAST [candidate] (21.131 ms) : 0, 21131

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-01-20T14:12:16	2025-01-20T14:19:23
git_branch	master	nikita-tkachenko/testng-retry-analyzer-npe
git_commit_date	1737381499	1737381605
git_commit_sha	`ea4856f`	`ab64d4e`
release_version	1.46.0-SNAPSHOT~ea4856fb98	1.46.0-SNAPSHOT~ab64d4e4a0
start_time	2025-01-20T14:12:02	2025-01-20T14:19:09

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1737383121	1737383121
ci_job_id	772779828	772779828
ci_pipeline_id	53479567	53479567
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:profiling	better [-92.978µs; -31.475µs] or [-5.950%; -2.014%]	unstable [-366.102op/s; +612.256op/s] or [-11.898%; +19.898%]	1.500ms	3200.000op/s	1.563ms	3076.923op/s

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~ab64d4e4a0, baseline=1.46.0-SNAPSHOT~ea4856fb98
dateFormat X
axisFormat %s
section baseline
no_agent (383.618 µs) : 364, 403
. : milestone, 384,
iast (506.709 µs) : 485, 528
. : milestone, 507,
iast_FULL (748.623 µs) : 727, 770
. : milestone, 749,
iast_GLOBAL (555.62 µs) : 533, 578
. : milestone, 556,
iast_HARDCODED_SECRET_DISABLED (507.852 µs) : 486, 529
. : milestone, 508,
iast_INACTIVE (460.933 µs) : 439, 483
. : milestone, 461,
iast_TELEMETRY_OFF (505.681 µs) : 483, 528
. : milestone, 506,
tracing (452.961 µs) : 431, 475
. : milestone, 453,
section candidate
no_agent (378.869 µs) : 359, 399
. : milestone, 379,
iast (509.098 µs) : 487, 531
. : milestone, 509,
iast_FULL (747.155 µs) : 725, 769
. : milestone, 747,
iast_GLOBAL (548.818 µs) : 527, 570
. : milestone, 549,
iast_HARDCODED_SECRET_DISABLED (507.241 µs) : 486, 529
. : milestone, 507,
iast_INACTIVE (454.218 µs) : 433, 475
. : milestone, 454,
iast_TELEMETRY_OFF (498.715 µs) : 476, 521
. : milestone, 499,
tracing (452.954 µs) : 432, 474
. : milestone, 453,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	383.618 µs [363.896 µs, 403.34 µs]	-
iast	506.709 µs [484.968 µs, 528.45 µs]	123.091 µs (32.1%)
iast_FULL	748.623 µs [726.803 µs, 770.444 µs]	365.005 µs (95.1%)
iast_GLOBAL	555.62 µs [533.424 µs, 577.816 µs]	172.002 µs (44.8%)
iast_HARDCODED_SECRET_DISABLED	507.852 µs [486.312 µs, 529.393 µs]	124.234 µs (32.4%)
iast_INACTIVE	460.933 µs [439.173 µs, 482.693 µs]	77.315 µs (20.2%)
iast_TELEMETRY_OFF	505.681 µs [483.378 µs, 527.983 µs]	122.063 µs (31.8%)
tracing	452.961 µs [431.107 µs, 474.815 µs]	69.343 µs (18.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	378.869 µs [358.559 µs, 399.178 µs]	-
iast	509.098 µs [487.449 µs, 530.747 µs]	130.23 µs (34.4%)
iast_FULL	747.155 µs [725.289 µs, 769.021 µs]	368.286 µs (97.2%)
iast_GLOBAL	548.818 µs [527.169 µs, 570.468 µs]	169.95 µs (44.9%)
iast_HARDCODED_SECRET_DISABLED	507.241 µs [485.652 µs, 528.831 µs]	128.373 µs (33.9%)
iast_INACTIVE	454.218 µs [433.285 µs, 475.152 µs]	75.35 µs (19.9%)
iast_TELEMETRY_OFF	498.715 µs [476.315 µs, 521.116 µs]	119.847 µs (31.6%)
tracing	452.954 µs [432.064 µs, 473.844 µs]	74.085 µs (19.6%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~ab64d4e4a0, baseline=1.46.0-SNAPSHOT~ea4856fb98
dateFormat X
axisFormat %s
section baseline
no_agent (1.356 ms) : 1336, 1375
. : milestone, 1356,
appsec (1.752 ms) : 1728, 1775
. : milestone, 1752,
appsec_no_iast (1.758 ms) : 1734, 1781
. : milestone, 1758,
iast (1.52 ms) : 1495, 1544
. : milestone, 1520,
profiling (1.563 ms) : 1530, 1595
. : milestone, 1563,
tracing (1.502 ms) : 1478, 1527
. : milestone, 1502,
section candidate
no_agent (1.363 ms) : 1342, 1383
. : milestone, 1363,
appsec (1.761 ms) : 1737, 1785
. : milestone, 1761,
appsec_no_iast (1.767 ms) : 1745, 1790
. : milestone, 1767,
iast (1.511 ms) : 1487, 1535
. : milestone, 1511,
profiling (1.5 ms) : 1477, 1524
. : milestone, 1500,
tracing (1.476 ms) : 1451, 1501
. : milestone, 1476,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.356 ms [1.336 ms, 1.375 ms]	-
appsec	1.752 ms [1.728 ms, 1.775 ms]	396.056 µs (29.2%)
appsec_no_iast	1.758 ms [1.734 ms, 1.781 ms]	402.029 µs (29.7%)
iast	1.52 ms [1.495 ms, 1.544 ms]	164.236 µs (12.1%)
profiling	1.563 ms [1.53 ms, 1.595 ms]	207.118 µs (15.3%)
tracing	1.502 ms [1.478 ms, 1.527 ms]	146.932 µs (10.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.363 ms [1.342 ms, 1.383 ms]	-
appsec	1.761 ms [1.737 ms, 1.785 ms]	398.473 µs (29.2%)
appsec_no_iast	1.767 ms [1.745 ms, 1.79 ms]	404.521 µs (29.7%)
iast	1.511 ms [1.487 ms, 1.535 ms]	148.046 µs (10.9%)
profiling	1.5 ms [1.477 ms, 1.524 ms]	137.71 µs (10.1%)
tracing	1.476 ms [1.451 ms, 1.501 ms]	112.899 µs (8.3%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	nikita-tkachenko/testng-retry-analyzer-npe
git_commit_date	1737381499	1737381605
git_commit_sha	`ea4856f`	`ab64d4e`
release_version	1.46.0-SNAPSHOT~ea4856fb98	1.46.0-SNAPSHOT~ab64d4e4a0

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1737383664	1737383664
ci_job_id	772779829	772779829
ci_pipeline_id	53479567	53479567
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~ab64d4e4a0, baseline=1.46.0-SNAPSHOT~ea4856fb98
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.355 ms) : 2312, 2398
. : milestone, 2355,
iast (2.098 ms) : 2044, 2152
. : milestone, 2098,
iast_GLOBAL (2.146 ms) : 2091, 2201
. : milestone, 2146,
profiling (1.963 ms) : 1920, 2006
. : milestone, 1963,
tracing (1.935 ms) : 1894, 1977
. : milestone, 1935,
section candidate
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (2.361 ms) : 2318, 2404
. : milestone, 2361,
iast (2.099 ms) : 2045, 2153
. : milestone, 2099,
iast_GLOBAL (2.14 ms) : 2086, 2194
. : milestone, 2140,
profiling (1.952 ms) : 1909, 1996
. : milestone, 1952,
tracing (1.934 ms) : 1893, 1976
. : milestone, 1934,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.461 ms, 1.484 ms]	-
appsec	2.355 ms [2.312 ms, 2.398 ms]	882.309 µs (59.9%)
iast	2.098 ms [2.044 ms, 2.152 ms]	625.467 µs (42.5%)
iast_GLOBAL	2.146 ms [2.091 ms, 2.201 ms]	673.618 µs (45.7%)
profiling	1.963 ms [1.92 ms, 2.006 ms]	490.775 µs (33.3%)
tracing	1.935 ms [1.894 ms, 1.977 ms]	463.054 µs (31.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.468 ms [1.456 ms, 1.479 ms]	-
appsec	2.361 ms [2.318 ms, 2.404 ms]	893.151 µs (60.8%)
iast	2.099 ms [2.045 ms, 2.153 ms]	631.404 µs (43.0%)
iast_GLOBAL	2.14 ms [2.086 ms, 2.194 ms]	672.032 µs (45.8%)
profiling	1.952 ms [1.909 ms, 1.996 ms]	484.607 µs (33.0%)
tracing	1.934 ms [1.893 ms, 1.976 ms]	466.503 µs (31.8%)

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~ab64d4e4a0, baseline=1.46.0-SNAPSHOT~ea4856fb98
dateFormat X
axisFormat %s
section baseline
no_agent (15.384 s) : 15384000, 15384000
. : milestone, 15384000,
appsec (14.835 s) : 14835000, 14835000
. : milestone, 14835000,
iast (18.643 s) : 18643000, 18643000
. : milestone, 18643000,
iast_GLOBAL (18.462 s) : 18462000, 18462000
. : milestone, 18462000,
profiling (15.066 s) : 15066000, 15066000
. : milestone, 15066000,
tracing (15.077 s) : 15077000, 15077000
. : milestone, 15077000,
section candidate
no_agent (15.351 s) : 15351000, 15351000
. : milestone, 15351000,
appsec (15.007 s) : 15007000, 15007000
. : milestone, 15007000,
iast (18.888 s) : 18888000, 18888000
. : milestone, 18888000,
iast_GLOBAL (18.15 s) : 18150000, 18150000
. : milestone, 18150000,
profiling (15.8 s) : 15800000, 15800000
. : milestone, 15800000,
tracing (14.788 s) : 14788000, 14788000
. : milestone, 14788000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.384 s [15.384 s, 15.384 s]	-
appsec	14.835 s [14.835 s, 14.835 s]	-549.0 ms (-3.6%)
iast	18.643 s [18.643 s, 18.643 s]	3.259 s (21.2%)
iast_GLOBAL	18.462 s [18.462 s, 18.462 s]	3.078 s (20.0%)
profiling	15.066 s [15.066 s, 15.066 s]	-318.0 ms (-2.1%)
tracing	15.077 s [15.077 s, 15.077 s]	-307.0 ms (-2.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.351 s [15.351 s, 15.351 s]	-
appsec	15.007 s [15.007 s, 15.007 s]	-344.0 ms (-2.2%)
iast	18.888 s [18.888 s, 18.888 s]	3.537 s (23.0%)
iast_GLOBAL	18.15 s [18.15 s, 18.15 s]	2.799 s (18.2%)
profiling	15.8 s [15.8 s, 15.8 s]	449.0 ms (2.9%)
tracing	14.788 s [14.788 s, 14.788 s]	-563.0 ms (-3.7%)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.25.4` -> `2.26.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | --- ### Release Notes <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.26.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2260-2025-01-29) ##### Features - Add firestoreInDatastoreMode for datastore emulator ([#1698](googleapis/java-datastore#1698)) ([50f106d](googleapis/java-datastore@50f106d)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.42.0 ([#1725](googleapis/java-datastore#1725)) ([1cbaf22](googleapis/java-datastore@1cbaf22)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.46.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.46.0): 1.46.0 ##### Breaking Changes > \[!WARNING] > jnr-unixsocket is now an external dependency of dd-trace-ot and must be included when deploying dd-trace-ot. > \[!NOTE] > The API `TracerScope.setAsync(boolean)`, used to manually control asynchronous span propagation, does no more apply to the scope instance but to the active span scope. ##### Components ##### Application Security Management (IAST) - 🐛 Fix String.replace instrumentation for IAST ([#8281](DataDog/dd-trace-java#8281) - [@Mariovido](https://github.com/Mariovido)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Exclude false positive weak randomness ([#8232](DataDog/dd-trace-java#8232) - [@jandro996](https://github.com/jandro996)) - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Add security control metrics ([#8175](DataDog/dd-trace-java#8175) - [@jandro996](https://github.com/jandro996)) - ✨ Increase IAST propagation to StringBuffer setLength ([#8128](DataDog/dd-trace-java#8128) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST taint tracking for DB values ([#8072](DataDog/dd-trace-java#8072) - [@Mariovido](https://github.com/Mariovido)) ##### Application Security Management (WAF) - 🐛 Prevents a NPE when there is no subscriber for user events ([#8258](DataDog/dd-trace-java#8258) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Ensure cached subscriptions are cleared on reconfiguration via RC ([#8229](DataDog/dd-trace-java#8229) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Create span tag: \_dd.appsec.rasp.timeout ([#8269](DataDog/dd-trace-java#8269) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - 🐛 Ensure shaded helpers have unique names when injected into class-loaders ([#8192](DataDog/dd-trace-java#8192) - [@mcculls](https://github.com/mcculls)) ##### Configuration at Runtime - 🐛 Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer ([#8176](DataDog/dd-trace-java#8176) - [@mhlidd](https://github.com/mhlidd)) ##### Continuous Integration Visibility - 🧹 Generalize TestRetryPolicy to TestExecutionPolicy ([#8302](DataDog/dd-trace-java#8302) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Parallelize CI Visibility settings requests ([#8299](DataDog/dd-trace-java#8299) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize test retry logic ([#8289](DataDog/dd-trace-java#8289) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize tests skipping logic ([#8288](DataDog/dd-trace-java#8288) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Remove skip and shouldBeSkipped methods from TestEventsHandler in favor of isSkippable ([#8286](DataDog/dd-trace-java#8286) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Optimize Git repository information computation ([#8270](DataDog/dd-trace-java#8270) - [@dougqh](https://github.com/dougqh)) - ✨ Always request known tests from the backend ([#8268](DataDog/dd-trace-java#8268) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Fix NPE when trying to get retry analyzer in Test NG ([#8253](DataDog/dd-trace-java#8253) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Set test framework and test framework version tags atomically ([#8252](DataDog/dd-trace-java#8252) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add debug logging to Android Gradle module layout logic ([#8251](DataDog/dd-trace-java#8251) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix source and destination folders computation for Android Gradle projects ([#8190](DataDog/dd-trace-java#8190) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add basic Scala Weaver sbt support ([#8189](DataDog/dd-trace-java#8189) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement impacted tests detection ([#8188](DataDog/dd-trace-java#8188) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Data Streams Monitoring - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Database Monitoring - Add peer service tag in dbm sql commenter ([#7913](DataDog/dd-trace-java#7913) - [@jordan-wong](https://github.com/jordan-wong)) ##### Dynamic Instrumentation - ✨ Add support for SymDB to scan directories ([#8306](DataDog/dd-trace-java#8306) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add SymDB report for any jar scanning failures ([#8300](DataDog/dd-trace-java#8300) - [@jpbempel](https://github.com/jpbempel)) - ✨ Use two budgets depending on type ([#8283](DataDog/dd-trace-java#8283) - [@evanchooly](https://github.com/evanchooly)) - ✨ Institute a 10 snapshot per probe per trace budget ([#8277](DataDog/dd-trace-java#8277) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Avoid double snapshots for Exception Replay ([#8273](DataDog/dd-trace-java#8273) - [@jpbempel](https://github.com/jpbempel)) - ✨ Simplify code origins. Separate out snapshot generation. ([#8263](DataDog/dd-trace-java#8263) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add Exception probe custom instrumentation ([#8230](DataDog/dd-trace-java#8230) - [@jpbempel](https://github.com/jpbempel)) - ✨ Enhance log probes to honor debug session tags ([#8215](DataDog/dd-trace-java#8215) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Don't redact env tokens from debugger probe snapshots ([#8211](DataDog/dd-trace-java#8211) - [@watson](https://github.com/watson)) - ✨⚡ Move Trace/SpanId capture at commit time ([#8184](DataDog/dd-trace-java#8184) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Capture values at entry for method probe ([#8169](DataDog/dd-trace-java#8169) - [@jpbempel](https://github.com/jpbempel)) ##### JMX fetch - 🐛 Mute JMXFetch Shutdown in progress error ([#8068](DataDog/dd-trace-java#8068) - [@ygree](https://github.com/ygree)) ##### OpenTracing - ⚠️🧹 Make jnr-unixsocket an explicit dependency of dd-trace-ot ([#8307](DataDog/dd-trace-java#8307) - [@mcculls](https://github.com/mcculls)) ##### Profiling - 🐛 Avoid unsupported API call for creating folders on windows ([#8304](DataDog/dd-trace-java#8304) - [@jbachorik](https://github.com/jbachorik)) - ✨ Tag profiles for serverless ([#8279](DataDog/dd-trace-java#8279) - [@jbachorik](https://github.com/jbachorik)) - ✨ add queue type and length to queue events ([#8242](DataDog/dd-trace-java#8242) - [@richardstartin](https://github.com/richardstartin)) - 🐛 TempLocationManager Fixes and Improvements ([#8191](DataDog/dd-trace-java#8191) - [@jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.18.0 ([#8173](DataDog/dd-trace-java#8173) - [@jbachorik](https://github.com/jbachorik)) - ✨ Report profiler initialization and configuration errors to telemetry ([#8171](DataDog/dd-trace-java#8171) - [@jbachorik](https://github.com/jbachorik)) ##### Telemetry - ✨ Add pending traces report in tracer flares ([#8053](DataDog/dd-trace-java#8053) - [@mhlidd](https://github.com/mhlidd)) ##### Testing - ✨ Test http server requests in parallel ([#8222](DataDog/dd-trace-java#8222) - [@amarziali](https://github.com/amarziali)) ##### Trace context propagation - ✨ Add non default propagator registration ([#8310](DataDog/dd-trace-java#8310) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - ✨ Probe for existence of IBMSASL or ACCP security providers ([#8276](DataDog/dd-trace-java#8276) - [@mcculls](https://github.com/mcculls)) - ✨⚡ Overhead improvement to agent feedback based sampling ([#8265](DataDog/dd-trace-java#8265) - [@dougqh](https://github.com/dougqh)) - 🧹 Move async propagation API from scope to tracer ([#8231](DataDog/dd-trace-java#8231) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Introduce context propagation API ([#8161](DataDog/dd-trace-java#8161) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🧪 Use env-entry to add tags per webapp deployment ([#8138](DataDog/dd-trace-java#8138) - [@amarziali](https://github.com/amarziali)) - ✨ Introduce context helpers API ([#8134](DataDog/dd-trace-java#8134) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Support IPv6 values for `DD_AGENT_HOST` and `DD_TRACE_AGENT_URL` ([#7984](DataDog/dd-trace-java#7984) - [@mhlidd](https://github.com/mhlidd)) ##### Instrumentations ##### Apache HttpComponents - 🐛 Properly finish spans and support latest apache httpclient5 ([#8272](DataDog/dd-trace-java#8272) - [@amarziali](https://github.com/amarziali)) ##### AWS Lambda instrumentation - 🐛 Properly capture lambda payloads for all handler types. ([#8264](DataDog/dd-trace-java#8264) - [@purple4reina](https://github.com/purple4reina)) ##### AWS S3 instrumentation - 💡 Create S3 instrumentation + add span pointers ([#8075](DataDog/dd-trace-java#8075) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Revert "Add avoid double instrumenting lambda non-streaming handlers." ([#8247](DataDog/dd-trace-java#8247) - [@nhulston](https://github.com/nhulston)) ##### Cassandra - ✨ Allow extracting keyspace from statement result ([#8239](DataDog/dd-trace-java#8239) - [@amarziali](https://github.com/amarziali)) ##### Core Java language instrumentation - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Eclipse Vert.x instrumentation - 🐛 Fix vertx worker propagation and error handling ([#8237](DataDog/dd-trace-java#8237) - [@amarziali](https://github.com/amarziali)) - ✨ Support vertx 5 ([#8220](DataDog/dd-trace-java#8220) - [@amarziali](https://github.com/amarziali)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) ##### Kafka instrumentation - 🐛 Prevent possible NPE calculating Kafka record header size ([#8292](DataDog/dd-trace-java#8292) - [@ygree](https://github.com/ygree)) ##### Mule instrumentation - 🐛 Fix crash using Mule with JPMS ([#8187](DataDog/dd-trace-java#8187) - [@amarziali](https://github.com/amarziali)) ##### Protocol Buffer instrumentation - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Spring instrumentation - 🐛 Preserve getQualifier from spring scheduling runnables ([#8293](DataDog/dd-trace-java#8293) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: bb09d47e4eed77a003f630273b4d0a84003eb899

Fix NPE when trying to get retry analyzer in Test NG
ab64d4e

nikita-tkachenko-datadog added type: feature Enhancements and improvements comp: ci visibility Continuous Integration Visibility labels Jan 20, 2025

PerfectSlayer approved these changes Jan 20, 2025
View reviewed changes

nikita-tkachenko-datadog marked this pull request as ready for review January 20, 2025 14:58

nikita-tkachenko-datadog requested a review from a team as a code owner January 20, 2025 14:58

nikita-tkachenko-datadog requested a review from juan-fernandez January 20, 2025 14:58

nikita-tkachenko-datadog merged commit 053241c into masterJan 20, 2025

nikita-tkachenko-datadog deleted the nikita-tkachenko/testng-retry-analyzer-npe branch January 20, 2025 14:58

github-actionsBot added this to the 1.46.0 milestone Jan 20, 2025

Navigation Menu

Uh oh!

Fix NPE when trying to get retry analyzer in Test NG - #8253

Fix NPE when trying to get retry analyzer in Test NG#8253
nikita-tkachenko-datadog merged 1 commit into
masterfrom
nikita-tkachenko/testng-retry-analyzer-npe

nikita-tkachenko-datadog commented Jan 20, 2025

Uh oh!

pr-commenterBot commented Jan 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

nikita-tkachenko-datadog commented Jan 20, 2025

What Does This Do

Contributor Checklist

Uh oh!

pr-commenterBot commented Jan 20, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants