Skip to content

byte-buddy 1.17.5 - #8657

Merged
mcculls merged 2 commits into
masterfrom
mcculls/byte-buddy-1.17.5
May 7, 2025
Merged

byte-buddy 1.17.5#8657
mcculls merged 2 commits into
masterfrom
mcculls/byte-buddy-1.17.5

Conversation

@mcculls

@mccullsmcculls commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Jira ticket: APMAPI-1286

@mccullsmcculls added the tag: do not merge Do not merge changes label Apr 1, 2025
@mcculls
mccullsforce-pushed the mcculls/byte-buddy-1.17.5 branch from d65ed3d to f06431eCompareApril 1, 2025 19:58
@pr-commenter

pr-commenterBot commented Apr 1, 2025

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
git_branchmastermcculls/byte-buddy-1.17.5
git_commit_date17465350021746566730
git_commit_sha5bfab6503c0344
release_version1.49.0-SNAPSHOT~5bfab6549b1.50.0-SNAPSHOT~03c0344d28
See matching parameters
BaselineCandidate
applicationinsecure-bankinsecure-bank
ci_job_date17465699211746569921
ci_job_id926893600926893600
ci_pipeline_id6432767664327676
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-ps6td5ta-project-304-concurrent-3-4c3m2d6q 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-ps6td5ta-project-304-concurrent-3-4c3m2d6q 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
moduleAgentAgent
parentNoneNone
variantiastiast

Summary

Found 1 performance improvements and 2 performance regressions! Performance is the same for 59 metrics, 9 unstable metrics.

scenarioΔ mean execution_timecandidate mean execution_timebaseline mean execution_time
scenario:startup:insecure-bank:iast:AppSecbetter
[-9.147ms; -4.548ms] or [-16.179%; -8.044%]
49.692ms56.540ms
scenario:startup:petclinic:profiling:ProfilingAgentworse
[+4.985ms; +9.582ms] or [+5.118%; +9.836%]
104.701ms97.417ms
scenario:startup:petclinic:profiling:Profilingworse
[+4.988ms; +9.586ms] or [+5.119%; +9.838%]
104.728ms97.440ms
Startup time reports for insecure-bank
gantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~03c0344d28, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.01 s) : 0, 1009579
Total [baseline] (8.621 s) : 0, 8621475
Agent [candidate] (1.018 s) : 0, 1017720
Total [candidate] (8.622 s) : 0, 8621765
section iast
Agent [baseline] (1.136 s) : 0, 1136062
Total [baseline] (9.154 s) : 0, 9154093
Agent [candidate] (1.149 s) : 0, 1148610
Total [candidate] (9.205 s) : 0, 9205008
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.144 s) : 0, 1143666
Total [baseline] (9.164 s) : 0, 9164274
Agent [candidate] (1.149 s) : 0, 1148938
Total [candidate] (9.189 s) : 0, 9188639
section iast_TELEMETRY_OFF
Agent [baseline] (1.133 s) : 0, 1132705
Total [baseline] (9.227 s) : 0, 9226848
Agent [candidate] (1.145 s) : 0, 1144881
Total [candidate] (9.212 s) : 0, 9211877
Loading
  • baseline results
ModuleVariantDurationΔ tracing
Agenttracing1.01 s-
Agentiast1.136 s126.483 ms (12.5%)
Agentiast_HARDCODED_SECRET_DISABLED1.144 s134.086 ms (13.3%)
Agentiast_TELEMETRY_OFF1.133 s123.126 ms (12.2%)
Totaltracing8.621 s-
Totaliast9.154 s532.618 ms (6.2%)
Totaliast_HARDCODED_SECRET_DISABLED9.164 s542.799 ms (6.3%)
Totaliast_TELEMETRY_OFF9.227 s605.372 ms (7.0%)
  • candidate results
ModuleVariantDurationΔ tracing
Agenttracing1.018 s-
Agentiast1.149 s130.89 ms (12.9%)
Agentiast_HARDCODED_SECRET_DISABLED1.149 s131.218 ms (12.9%)
Agentiast_TELEMETRY_OFF1.145 s127.161 ms (12.5%)
Totaltracing8.622 s-
Totaliast9.205 s583.243 ms (6.8%)
Totaliast_HARDCODED_SECRET_DISABLED9.189 s566.874 ms (6.6%)
Totaliast_TELEMETRY_OFF9.212 s590.112 ms (6.8%)
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~03c0344d28, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.413 ms) : 0, 671413
BytebuddyAgent [candidate] (681.758 ms) : 0, 681758
GlobalTracer [baseline] (240.112 ms) : 0, 240112
GlobalTracer [candidate] (239.529 ms) : 0, 239529
AppSec [baseline] (54.782 ms) : 0, 54782
AppSec [candidate] (54.375 ms) : 0, 54375
Debugger [baseline] (7.044 ms) : 0, 7044
Debugger [candidate] (8.995 ms) : 0, 8995
Remote Config [baseline] (710.064 µs) : 0, 710
Remote Config [candidate] (684.767 µs) : 0, 685
Telemetry [baseline] (12.177 ms) : 0, 12177
Telemetry [candidate] (9.002 ms) : 0, 9002
section iast
BytebuddyAgent [baseline] (789.225 ms) : 0, 789225
BytebuddyAgent [candidate] (801.584 ms) : 0, 801584
GlobalTracer [baseline] (229.908 ms) : 0, 229908
GlobalTracer [candidate] (230.176 ms) : 0, 230176
IAST [baseline] (22.697 ms) : 0, 22697
IAST [candidate] (29.217 ms) : 0, 29217
AppSec [baseline] (56.54 ms) : 0, 56540
AppSec [candidate] (49.692 ms) : 0, 49692
Debugger [baseline] (5.879 ms) : 0, 5879
Debugger [candidate] (5.923 ms) : 0, 5923
Remote Config [baseline] (578.124 µs) : 0, 578
Remote Config [candidate] (590.947 µs) : 0, 591
Telemetry [baseline] (7.819 ms) : 0, 7819
Telemetry [candidate] (7.91 ms) : 0, 7910
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (795.105 ms) : 0, 795105
BytebuddyAgent [candidate] (801.948 ms) : 0, 801948
GlobalTracer [baseline] (231.364 ms) : 0, 231364
GlobalTracer [candidate] (230.445 ms) : 0, 230445
IAST [baseline] (22.983 ms) : 0, 22983
IAST [candidate] (24.492 ms) : 0, 24492
AppSec [baseline] (56.312 ms) : 0, 56312
AppSec [candidate] (54.218 ms) : 0, 54218
Debugger [baseline] (5.919 ms) : 0, 5919
Debugger [candidate] (5.922 ms) : 0, 5922
Remote Config [baseline] (578.693 µs) : 0, 579
Remote Config [candidate] (590.409 µs) : 0, 590
Telemetry [baseline] (7.881 ms) : 0, 7881
Telemetry [candidate] (7.875 ms) : 0, 7875
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (786.498 ms) : 0, 786498
BytebuddyAgent [candidate] (798.288 ms) : 0, 798288
GlobalTracer [baseline] (229.719 ms) : 0, 229719
GlobalTracer [candidate] (230.787 ms) : 0, 230787
IAST [baseline] (22.31 ms) : 0, 22310
IAST [candidate] (22.322 ms) : 0, 22322
AppSec [baseline] (56.52 ms) : 0, 56520
AppSec [candidate] (55.661 ms) : 0, 55661
Debugger [baseline] (6.004 ms) : 0, 6004
Debugger [candidate] (5.991 ms) : 0, 5991
Remote Config [baseline] (603.992 µs) : 0, 604
Remote Config [candidate] (596.042 µs) : 0, 596
Telemetry [baseline] (7.73 ms) : 0, 7730
Telemetry [candidate] (7.754 ms) : 0, 7754
Loading
Startup time reports for petclinic
gantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~03c0344d28, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.012 s) : 0, 1012184
Total [baseline] (10.509 s) : 0, 10509241
Agent [candidate] (1.021 s) : 0, 1020515
Total [candidate] (10.477 s) : 0, 10476648
section appsec
Agent [baseline] (1.154 s) : 0, 1153950
Total [baseline] (10.71 s) : 0, 10709634
Agent [candidate] (1.16 s) : 0, 1159968
Total [candidate] (10.713 s) : 0, 10712973
section iast
Agent [baseline] (1.14 s) : 0, 1140028
Total [baseline] (10.83 s) : 0, 10830444
Agent [candidate] (1.149 s) : 0, 1149094
Total [candidate] (10.959 s) : 0, 10958652
section profiling
Agent [baseline] (1.26 s) : 0, 1259628
Total [baseline] (10.821 s) : 0, 10821491
Agent [candidate] (1.276 s) : 0, 1275823
Total [candidate] (10.923 s) : 0, 10922572
Loading
  • baseline results
ModuleVariantDurationΔ tracing
Agenttracing1.012 s-
Agentappsec1.154 s141.766 ms (14.0%)
Agentiast1.14 s127.843 ms (12.6%)
Agentprofiling1.26 s247.444 ms (24.4%)
Totaltracing10.509 s-
Totalappsec10.71 s200.393 ms (1.9%)
Totaliast10.83 s321.204 ms (3.1%)
Totalprofiling10.821 s312.25 ms (3.0%)
  • candidate results
ModuleVariantDurationΔ tracing
Agenttracing1.021 s-
Agentappsec1.16 s139.453 ms (13.7%)
Agentiast1.149 s128.579 ms (12.6%)
Agentprofiling1.276 s255.308 ms (25.0%)
Totaltracing10.477 s-
Totalappsec10.713 s236.325 ms (2.3%)
Totaliast10.959 s482.004 ms (4.6%)
Totalprofiling10.923 s445.924 ms (4.3%)
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~03c0344d28, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.872 ms) : 0, 674872
BytebuddyAgent [candidate] (682.578 ms) : 0, 682578
GlobalTracer [baseline] (240.736 ms) : 0, 240736
GlobalTracer [candidate] (240.037 ms) : 0, 240037
AppSec [baseline] (55.463 ms) : 0, 55463
AppSec [candidate] (57.209 ms) : 0, 57209
Debugger [baseline] (6.915 ms) : 0, 6915
Debugger [candidate] (6.912 ms) : 0, 6912
Remote Config [baseline] (712.328 µs) : 0, 712
Remote Config [candidate] (677.812 µs) : 0, 678
Telemetry [baseline] (9.982 ms) : 0, 9982
Telemetry [candidate] (9.665 ms) : 0, 9665
section appsec
BytebuddyAgent [baseline] (691.977 ms) : 0, 691977
BytebuddyAgent [candidate] (699.494 ms) : 0, 699494
GlobalTracer [baseline] (237.445 ms) : 0, 237445
GlobalTracer [candidate] (236.636 ms) : 0, 236636
AppSec [baseline] (175.449 ms) : 0, 175449
AppSec [candidate] (174.802 ms) : 0, 174802
Debugger [baseline] (5.863 ms) : 0, 5863
Debugger [candidate] (5.958 ms) : 0, 5958
Remote Config [baseline] (631.927 µs) : 0, 632
Remote Config [candidate] (622.58 µs) : 0, 623
Telemetry [baseline] (8.138 ms) : 0, 8138
Telemetry [candidate] (8.144 ms) : 0, 8144
IAST [baseline] (21.992 ms) : 0, 21992
IAST [candidate] (21.767 ms) : 0, 21767
section iast
BytebuddyAgent [baseline] (792.159 ms) : 0, 792159
BytebuddyAgent [candidate] (801.972 ms) : 0, 801972
GlobalTracer [baseline] (230.66 ms) : 0, 230660
GlobalTracer [candidate] (230.133 ms) : 0, 230133
AppSec [baseline] (56.422 ms) : 0, 56422
AppSec [candidate] (53.797 ms) : 0, 53797
Debugger [baseline] (5.922 ms) : 0, 5922
Debugger [candidate] (5.987 ms) : 0, 5987
Remote Config [baseline] (590.842 µs) : 0, 591
Remote Config [candidate] (595.378 µs) : 0, 595
Telemetry [baseline] (7.915 ms) : 0, 7915
Telemetry [candidate] (8.008 ms) : 0, 8008
IAST [baseline] (22.889 ms) : 0, 22889
IAST [candidate] (24.345 ms) : 0, 24345
section profiling
ProfilingAgent [baseline] (97.417 ms) : 0, 97417
ProfilingAgent [candidate] (104.701 ms) : 0, 104701
BytebuddyAgent [baseline] (663.105 ms) : 0, 663105
BytebuddyAgent [candidate] (673.345 ms) : 0, 673345
GlobalTracer [baseline] (379.235 ms) : 0, 379235
GlobalTracer [candidate] (378.292 ms) : 0, 378292
AppSec [baseline] (54.889 ms) : 0, 54889
AppSec [candidate] (54.137 ms) : 0, 54137
Debugger [baseline] (6.109 ms) : 0, 6109
Debugger [candidate] (6.161 ms) : 0, 6161
Remote Config [baseline] (657.653 µs) : 0, 658
Remote Config [candidate] (660.087 µs) : 0, 660
Telemetry [baseline] (8.181 ms) : 0, 8181
Telemetry [candidate] (8.137 ms) : 0, 8137
Profiling [baseline] (97.44 ms) : 0, 97440
Profiling [candidate] (104.728 ms) : 0, 104728
Loading

Load

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
end_time2025-05-06T21:47:052025-05-06T21:54:51
git_branchmastermcculls/byte-buddy-1.17.5
git_commit_date17465350021746566730
git_commit_sha5bfab6503c0344
release_version1.49.0-SNAPSHOT~5bfab6549b1.50.0-SNAPSHOT~03c0344d28
start_time2025-05-06T21:46:512025-05-06T21:54:36
See matching parameters
BaselineCandidate
applicationinsecure-bankinsecure-bank
ci_job_date17465688891746568889
ci_job_id926893601926893601
ci_pipeline_id6432767664327676
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-ps6td5ta-project-304-concurrent-4-nywbmcrf 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-ps6td5ta-project-304-concurrent-4-nywbmcrf 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variantiastiast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for insecure-bank
gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~03c0344d28, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section baseline
no_agent (386.949 µs) : 367, 407
. : milestone, 387,
iast (524.821 µs) : 502, 548
. : milestone, 525,
iast_FULL (751.006 µs) : 728, 774
. : milestone, 751,
iast_GLOBAL (578.687 µs) : 555, 602
. : milestone, 579,
iast_HARDCODED_SECRET_DISABLED (521.932 µs) : 499, 545
. : milestone, 522,
iast_INACTIVE (464.654 µs) : 443, 486
. : milestone, 465,
iast_TELEMETRY_OFF (508.923 µs) : 486, 532
. : milestone, 509,
tracing (461.39 µs) : 439, 484
. : milestone, 461,
section candidate
no_agent (385.003 µs) : 365, 405
. : milestone, 385,
iast (533.308 µs) : 510, 557
. : milestone, 533,
iast_FULL (738.041 µs) : 716, 760
. : milestone, 738,
iast_GLOBAL (565.913 µs) : 544, 588
. : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (518.926 µs) : 496, 542
. : milestone, 519,
iast_INACTIVE (468.967 µs) : 447, 491
. : milestone, 469,
iast_TELEMETRY_OFF (518.208 µs) : 495, 541
. : milestone, 518,
tracing (462.563 µs) : 441, 485
. : milestone, 463,
Loading
  • baseline results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent386.949 µs [367.153 µs, 406.746 µs]-
iast524.821 µs [501.705 µs, 547.937 µs]137.872 µs (35.6%)
iast_FULL751.006 µs [727.696 µs, 774.316 µs]364.057 µs (94.1%)
iast_GLOBAL578.687 µs [555.146 µs, 602.228 µs]191.738 µs (49.6%)
iast_HARDCODED_SECRET_DISABLED521.932 µs [498.513 µs, 545.351 µs]134.983 µs (34.9%)
iast_INACTIVE464.654 µs [443.184 µs, 486.125 µs]77.705 µs (20.1%)
iast_TELEMETRY_OFF508.923 µs [485.518 µs, 532.328 µs]121.974 µs (31.5%)
tracing461.39 µs [438.748 µs, 484.033 µs]74.441 µs (19.2%)
  • candidate results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent385.003 µs [364.858 µs, 405.148 µs]-
iast533.308 µs [510.085 µs, 556.532 µs]148.305 µs (38.5%)
iast_FULL738.041 µs [715.964 µs, 760.118 µs]353.037 µs (91.7%)
iast_GLOBAL565.913 µs [543.917 µs, 587.908 µs]180.91 µs (47.0%)
iast_HARDCODED_SECRET_DISABLED518.926 µs [496.013 µs, 541.839 µs]133.923 µs (34.8%)
iast_INACTIVE468.967 µs [446.793 µs, 491.142 µs]83.964 µs (21.8%)
iast_TELEMETRY_OFF518.208 µs [494.934 µs, 541.482 µs]133.205 µs (34.6%)
tracing462.563 µs [440.557 µs, 484.57 µs]77.56 µs (20.1%)
Request duration reports for petclinic
gantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~03c0344d28, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section baseline
no_agent (1.361 ms) : 1341, 1381
. : milestone, 1361,
appsec (1.713 ms) : 1690, 1737
. : milestone, 1713,
appsec_no_iast (1.738 ms) : 1715, 1762
. : milestone, 1738,
code_origins (1.71 ms) : 1684, 1736
. : milestone, 1710,
iast (1.525 ms) : 1501, 1549
. : milestone, 1525,
profiling (1.518 ms) : 1495, 1542
. : milestone, 1518,
tracing (1.503 ms) : 1478, 1527
. : milestone, 1503,
section candidate
no_agent (1.363 ms) : 1344, 1382
. : milestone, 1363,
appsec (1.737 ms) : 1714, 1760
. : milestone, 1737,
appsec_no_iast (1.734 ms) : 1711, 1757
. : milestone, 1734,
code_origins (1.679 ms) : 1652, 1707
. : milestone, 1679,
iast (1.527 ms) : 1502, 1552
. : milestone, 1527,
profiling (1.554 ms) : 1529, 1579
. : milestone, 1554,
tracing (1.488 ms) : 1462, 1513
. : milestone, 1488,
Loading
  • baseline results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent1.361 ms [1.341 ms, 1.381 ms]-
appsec1.713 ms [1.69 ms, 1.737 ms]352.61 µs (25.9%)
appsec_no_iast1.738 ms [1.715 ms, 1.762 ms]377.634 µs (27.8%)
code_origins1.71 ms [1.684 ms, 1.736 ms]349.195 µs (25.7%)
iast1.525 ms [1.501 ms, 1.549 ms]164.393 µs (12.1%)
profiling1.518 ms [1.495 ms, 1.542 ms]157.631 µs (11.6%)
tracing1.503 ms [1.478 ms, 1.527 ms]141.786 µs (10.4%)
  • candidate results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent1.363 ms [1.344 ms, 1.382 ms]-
appsec1.737 ms [1.714 ms, 1.76 ms]374.142 µs (27.5%)
appsec_no_iast1.734 ms [1.711 ms, 1.757 ms]371.22 µs (27.2%)
code_origins1.679 ms [1.652 ms, 1.707 ms]316.594 µs (23.2%)
iast1.527 ms [1.502 ms, 1.552 ms]164.26 µs (12.1%)
profiling1.554 ms [1.529 ms, 1.579 ms]191.692 µs (14.1%)
tracing1.488 ms [1.462 ms, 1.513 ms]124.932 µs (9.2%)

Dacapo

@mcculls
mccullsforce-pushed the mcculls/byte-buddy-1.17.5 branch from f06431e to 289dd9dCompareApril 1, 2025 21:07
@amarzialiamarziali mentioned this pull request Apr 11, 2025
@sarahchen6
sarahchen6force-pushed the mcculls/byte-buddy-1.17.5 branch 2 times, most recently from b01ebd4 to 962056aCompareApril 18, 2025 19:47
@sarahchen6
sarahchen6force-pushed the mcculls/byte-buddy-1.17.5 branch from 962056a to 644f996CompareApril 21, 2025 21:28
@mcculls
mccullsforce-pushed the mcculls/byte-buddy-1.17.5 branch from 644f996 to 1fd3b2cCompareApril 24, 2025 18:47
@mccullsmcculls changed the title WIP: byte-buddy 1.17.5byte-buddy 1.17.5Apr 24, 2025
@mccullsmcculls added type: feature Enhancements and improvements comp: core Tracer core tag: dependencies Dependencies related changes and removed tag: do not merge Do not merge changes labels Apr 25, 2025
@mcculls
mccullsforce-pushed the mcculls/byte-buddy-1.17.5 branch 3 times, most recently from 445bae6 to a7ecbc4CompareApril 29, 2025 11:55
@mcculls
mccullsforce-pushed the mcculls/byte-buddy-1.17.5 branch from a7ecbc4 to 03c0344CompareMay 6, 2025 21:25
@mcculls
mcculls marked this pull request as ready for review May 6, 2025 22:46
@mcculls
mcculls requested review from a team as code ownersMay 6, 2025 22:46

@PerfectSlayerPerfectSlayer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about shadow plugin.
Otherwise looks good 👍

Comment threadbuild.gradle
id 'io.github.gradle-nexus.publish-plugin' version '1.3.0'

id "com.github.johnrengelman.shadow" version "7.1.2" apply false
id "com.github.johnrengelman.shadow" version "8.1.1" apply false

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but I'd do that in a separate PR, as it relates more to making the build itself ready for Java 24 then this specific upgrade.

As part of that PR we can also change the plugin id (versions after 8.1.1 use a different gradle plugin id)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small PR with the changes you mentioned! #8785

@mcculls
mcculls merged commit 13eba48 into masterMay 7, 2025
@mcculls
mcculls deleted the mcculls/byte-buddy-1.17.5 branch May 7, 2025 09:28
@github-actionsgithub-actionsBot added this to the 1.50.0 milestone May 7, 2025
@PerfectSlayerPerfectSlayer added the tag: no release notes Changes to exclude from release notes label Jun 20, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: coreTracer coretag: dependenciesDependencies related changestag: no release notesChanges to exclude from release notestype: featureEnhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mcculls@PerfectSlayer@sarahchen6