Turn JDK socket support on by default by sarahchen6 · Pull Request #8752 · DataDog/dd-trace-java

sarahchen6 · 2025-04-29T20:47:38Z

What Does This Do

Address file leakage issue with the native UDS implementation.

Update closing technique such that when the input stream, output stream, or socket is closed, all resources (i.e. input stream, output stream, channel, selector, and socket) are closed. This better matches expected socket behavior.

Turn JDK socket support by default back on.

Motivation

Resolve issue: #8696

Update closing technique to match expected behavior - closing the input stream should close the socket, closing the output stream should close the socket, and closing the socket should close both streams and the associated channel.

Additional Notes

OpenJDK Socket class for reference: https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/net/Socket.java

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: https://datadoghq.atlassian.net/browse/LANGPLAT-459

pr-commenter · 2025-04-29T21:29:01Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	sarahchen6/fix-jdk-uds-implementation
git_commit_date	1746535002	1746560721
git_commit_sha	`5bfab65`	`c089869`
release_version	1.49.0-SNAPSHOT~5bfab6549b	1.50.0-SNAPSHOT~c089869839

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1746563730	1746563730
ci_job_id	926690512	926690512
ci_pipeline_id	64313166	64313166
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-mxzd64wf-project-304-concurrent-0-godgbsag 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-mxzd64wf-project-304-concurrent-0-godgbsag 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics.

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~c089869839, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.007 s) : 0, 1006602
Total [baseline] (8.615 s) : 0, 8615407
Agent [candidate] (1.011 s) : 0, 1011065
Total [candidate] (8.665 s) : 0, 8665322
section iast
Agent [baseline] (1.14 s) : 0, 1139712
Total [baseline] (9.211 s) : 0, 9210521
Agent [candidate] (1.145 s) : 0, 1145191
Total [candidate] (9.219 s) : 0, 9219303
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.148 s) : 0, 1147918
Total [baseline] (9.213 s) : 0, 9212973
Agent [candidate] (1.139 s) : 0, 1139489
Total [candidate] (9.161 s) : 0, 9160588
section iast_TELEMETRY_OFF
Agent [baseline] (1.138 s) : 0, 1137676
Total [baseline] (9.201 s) : 0, 9201019
Agent [candidate] (1.142 s) : 0, 1142090
Total [candidate] (9.221 s) : 0, 9220749

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.007 s	-
Agent	iast	1.14 s	133.111 ms (13.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.148 s	141.316 ms (14.0%)
Agent	iast_TELEMETRY_OFF	1.138 s	131.074 ms (13.0%)
Total	tracing	8.615 s	-
Total	iast	9.211 s	595.114 ms (6.9%)
Total	iast_HARDCODED_SECRET_DISABLED	9.213 s	597.565 ms (6.9%)
Total	iast_TELEMETRY_OFF	9.201 s	585.612 ms (6.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.011 s	-
Agent	iast	1.145 s	134.127 ms (13.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.139 s	128.424 ms (12.7%)
Agent	iast_TELEMETRY_OFF	1.142 s	131.025 ms (13.0%)
Total	tracing	8.665 s	-
Total	iast	9.219 s	553.981 ms (6.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.161 s	495.266 ms (5.7%)
Total	iast_TELEMETRY_OFF	9.221 s	555.427 ms (6.4%)

gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~c089869839, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.367 ms) : 0, 670367
BytebuddyAgent [candidate] (675.054 ms) : 0, 675054
GlobalTracer [baseline] (239.997 ms) : 0, 239997
GlobalTracer [candidate] (241.343 ms) : 0, 241343
AppSec [baseline] (54.587 ms) : 0, 54587
AppSec [candidate] (54.922 ms) : 0, 54922
Debugger [baseline] (6.221 ms) : 0, 6221
Debugger [candidate] (6.941 ms) : 0, 6941
Remote Config [baseline] (711.072 µs) : 0, 711
Remote Config [candidate] (706.101 µs) : 0, 706
Telemetry [baseline] (11.377 ms) : 0, 11377
Telemetry [candidate] (8.466 ms) : 0, 8466
section iast
BytebuddyAgent [baseline] (791.3 ms) : 0, 791300
BytebuddyAgent [candidate] (795.987 ms) : 0, 795987
GlobalTracer [baseline] (230.827 ms) : 0, 230827
GlobalTracer [candidate] (231.795 ms) : 0, 231795
IAST [baseline] (22.721 ms) : 0, 22721
IAST [candidate] (23.068 ms) : 0, 23068
AppSec [baseline] (56.878 ms) : 0, 56878
AppSec [candidate] (56.328 ms) : 0, 56328
Debugger [baseline] (5.956 ms) : 0, 5956
Debugger [candidate] (5.915 ms) : 0, 5915
Remote Config [baseline] (599.175 µs) : 0, 599
Remote Config [candidate] (604.5 µs) : 0, 605
Telemetry [baseline] (7.949 ms) : 0, 7949
Telemetry [candidate] (7.922 ms) : 0, 7922
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (797.169 ms) : 0, 797169
BytebuddyAgent [candidate] (791.26 ms) : 0, 791260
GlobalTracer [baseline] (232.617 ms) : 0, 232617
GlobalTracer [candidate] (230.986 ms) : 0, 230986
IAST [baseline] (23.08 ms) : 0, 23080
IAST [candidate] (22.846 ms) : 0, 22846
AppSec [baseline] (56.712 ms) : 0, 56712
AppSec [candidate] (56.496 ms) : 0, 56496
Debugger [baseline] (5.971 ms) : 0, 5971
Debugger [candidate] (5.952 ms) : 0, 5952
Remote Config [baseline] (590.572 µs) : 0, 591
Remote Config [candidate] (594.602 µs) : 0, 595
Telemetry [baseline] (8.044 ms) : 0, 8044
Telemetry [candidate] (7.924 ms) : 0, 7924
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (789.323 ms) : 0, 789323
BytebuddyAgent [candidate] (793.245 ms) : 0, 793245
GlobalTracer [baseline] (231.364 ms) : 0, 231364
GlobalTracer [candidate] (231.999 ms) : 0, 231999
IAST [baseline] (22.606 ms) : 0, 22606
IAST [candidate] (22.536 ms) : 0, 22536
AppSec [baseline] (56.564 ms) : 0, 56564
AppSec [candidate] (56.469 ms) : 0, 56469
Debugger [baseline] (5.975 ms) : 0, 5975
Debugger [candidate] (5.909 ms) : 0, 5909
Remote Config [baseline] (599.133 µs) : 0, 599
Remote Config [candidate] (597.175 µs) : 0, 597
Telemetry [baseline] (7.769 ms) : 0, 7769
Telemetry [candidate] (7.793 ms) : 0, 7793

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~c089869839, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.008 s) : 0, 1008426
Total [baseline] (10.498 s) : 0, 10498431
Agent [candidate] (1.005 s) : 0, 1005011
Total [candidate] (10.49 s) : 0, 10490122
section appsec
Agent [baseline] (1.15 s) : 0, 1149879
Total [baseline] (10.696 s) : 0, 10696393
Agent [candidate] (1.15 s) : 0, 1149759
Total [candidate] (10.692 s) : 0, 10691671
section iast
Agent [baseline] (1.139 s) : 0, 1139481
Total [baseline] (10.855 s) : 0, 10854777
Agent [candidate] (1.148 s) : 0, 1147915
Total [candidate] (10.843 s) : 0, 10842591
section profiling
Agent [baseline] (1.266 s) : 0, 1266263
Total [baseline] (10.815 s) : 0, 10814807
Agent [candidate] (1.273 s) : 0, 1273371
Total [candidate] (10.84 s) : 0, 10840190

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.008 s	-
Agent	appsec	1.15 s	141.453 ms (14.0%)
Agent	iast	1.139 s	131.055 ms (13.0%)
Agent	profiling	1.266 s	257.837 ms (25.6%)
Total	tracing	10.498 s	-
Total	appsec	10.696 s	197.962 ms (1.9%)
Total	iast	10.855 s	356.346 ms (3.4%)
Total	profiling	10.815 s	316.376 ms (3.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.005 s	-
Agent	appsec	1.15 s	144.749 ms (14.4%)
Agent	iast	1.148 s	142.904 ms (14.2%)
Agent	profiling	1.273 s	268.36 ms (26.7%)
Total	tracing	10.49 s	-
Total	appsec	10.692 s	201.549 ms (1.9%)
Total	iast	10.843 s	352.469 ms (3.4%)
Total	profiling	10.84 s	350.067 ms (3.3%)

gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~c089869839, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.716 ms) : 0, 671716
BytebuddyAgent [candidate] (670.353 ms) : 0, 670353
GlobalTracer [baseline] (240.316 ms) : 0, 240316
GlobalTracer [candidate] (239.686 ms) : 0, 239686
AppSec [baseline] (54.793 ms) : 0, 54793
AppSec [candidate] (54.766 ms) : 0, 54766
Debugger [baseline] (6.182 ms) : 0, 6182
Debugger [candidate] (6.88 ms) : 0, 6880
Remote Config [baseline] (688.581 µs) : 0, 689
Remote Config [candidate] (696.731 µs) : 0, 697
Telemetry [baseline] (11.289 ms) : 0, 11289
Telemetry [candidate] (9.177 ms) : 0, 9177
section appsec
BytebuddyAgent [baseline] (689.254 ms) : 0, 689254
BytebuddyAgent [candidate] (688.547 ms) : 0, 688547
GlobalTracer [baseline] (237.051 ms) : 0, 237051
GlobalTracer [candidate] (236.748 ms) : 0, 236748
AppSec [baseline] (174.932 ms) : 0, 174932
AppSec [candidate] (175.784 ms) : 0, 175784
Debugger [baseline] (5.9 ms) : 0, 5900
Debugger [candidate] (5.894 ms) : 0, 5894
Remote Config [baseline] (640.312 µs) : 0, 640
Remote Config [candidate] (632.117 µs) : 0, 632
Telemetry [baseline] (7.82 ms) : 0, 7820
Telemetry [candidate] (7.807 ms) : 0, 7807
IAST [baseline] (21.752 ms) : 0, 21752
IAST [candidate] (21.777 ms) : 0, 21777
section iast
BytebuddyAgent [baseline] (792.162 ms) : 0, 792162
BytebuddyAgent [candidate] (797.975 ms) : 0, 797975
GlobalTracer [baseline] (230.655 ms) : 0, 230655
GlobalTracer [candidate] (232.293 ms) : 0, 232293
AppSec [baseline] (56.336 ms) : 0, 56336
AppSec [candidate] (56.692 ms) : 0, 56692
Debugger [baseline] (5.835 ms) : 0, 5835
Debugger [candidate] (5.945 ms) : 0, 5945
Remote Config [baseline] (577.005 µs) : 0, 577
Remote Config [candidate] (603.927 µs) : 0, 604
Telemetry [baseline] (7.769 ms) : 0, 7769
Telemetry [candidate] (7.953 ms) : 0, 7953
IAST [baseline] (22.647 ms) : 0, 22647
IAST [candidate] (22.848 ms) : 0, 22848
section profiling
ProfilingAgent [baseline] (97.734 ms) : 0, 97734
ProfilingAgent [candidate] (97.693 ms) : 0, 97693
BytebuddyAgent [baseline] (666.648 ms) : 0, 666648
BytebuddyAgent [candidate] (671.796 ms) : 0, 671796
GlobalTracer [baseline] (381.294 ms) : 0, 381294
GlobalTracer [candidate] (383.414 ms) : 0, 383414
AppSec [baseline] (54.95 ms) : 0, 54950
AppSec [candidate] (54.44 ms) : 0, 54440
Debugger [baseline] (6.232 ms) : 0, 6232
Debugger [candidate] (6.214 ms) : 0, 6214
Remote Config [baseline] (662.453 µs) : 0, 662
Remote Config [candidate] (661.932 µs) : 0, 662
Telemetry [baseline] (8.24 ms) : 0, 8240
Telemetry [candidate] (8.262 ms) : 0, 8262
Profiling [baseline] (97.757 ms) : 0, 97757
Profiling [candidate] (97.717 ms) : 0, 97717

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-05-06T20:03:53	2025-05-06T20:11:40
git_branch	master	sarahchen6/fix-jdk-uds-implementation
git_commit_date	1746535002	1746560721
git_commit_sha	`5bfab65`	`c089869`
release_version	1.49.0-SNAPSHOT~5bfab6549b	1.50.0-SNAPSHOT~c089869839
start_time	2025-05-06T20:03:39	2025-05-06T20:11:26

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1746562702	1746562702
ci_job_id	926690513	926690513
ci_pipeline_id	64313166	64313166
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-okkhypjs-project-304-concurrent-0-4vpb2slx 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-okkhypjs-project-304-concurrent-0-4vpb2slx 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~c089869839, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section baseline
no_agent (386.546 µs) : 366, 407
. : milestone, 387,
iast (526.66 µs) : 503, 550
. : milestone, 527,
iast_FULL (738.905 µs) : 716, 762
. : milestone, 739,
iast_GLOBAL (574.006 µs) : 551, 597
. : milestone, 574,
iast_HARDCODED_SECRET_DISABLED (520.355 µs) : 497, 543
. : milestone, 520,
iast_INACTIVE (475.894 µs) : 453, 499
. : milestone, 476,
iast_TELEMETRY_OFF (518.126 µs) : 496, 541
. : milestone, 518,
tracing (472.186 µs) : 450, 494
. : milestone, 472,
section candidate
no_agent (397.096 µs) : 377, 417
. : milestone, 397,
iast (519.194 µs) : 496, 542
. : milestone, 519,
iast_FULL (745.822 µs) : 722, 769
. : milestone, 746,
iast_GLOBAL (567.406 µs) : 544, 590
. : milestone, 567,
iast_HARDCODED_SECRET_DISABLED (529.517 µs) : 507, 552
. : milestone, 530,
iast_INACTIVE (470.962 µs) : 449, 493
. : milestone, 471,
iast_TELEMETRY_OFF (518.028 µs) : 495, 541
. : milestone, 518,
tracing (463.672 µs) : 442, 486
. : milestone, 464,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	386.546 µs [366.294 µs, 406.798 µs]	-
iast	526.66 µs [503.095 µs, 550.226 µs]	140.114 µs (36.2%)
iast_FULL	738.905 µs [715.563 µs, 762.247 µs]	352.359 µs (91.2%)
iast_GLOBAL	574.006 µs [551.07 µs, 596.942 µs]	187.46 µs (48.5%)
iast_HARDCODED_SECRET_DISABLED	520.355 µs [497.319 µs, 543.392 µs]	133.809 µs (34.6%)
iast_INACTIVE	475.894 µs [452.979 µs, 498.81 µs]	89.348 µs (23.1%)
iast_TELEMETRY_OFF	518.126 µs [495.527 µs, 540.725 µs]	131.58 µs (34.0%)
tracing	472.186 µs [450.284 µs, 494.088 µs]	85.64 µs (22.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	397.096 µs [376.921 µs, 417.271 µs]	-
iast	519.194 µs [496.057 µs, 542.33 µs]	122.098 µs (30.7%)
iast_FULL	745.822 µs [722.173 µs, 769.471 µs]	348.726 µs (87.8%)
iast_GLOBAL	567.406 µs [544.411 µs, 590.401 µs]	170.31 µs (42.9%)
iast_HARDCODED_SECRET_DISABLED	529.517 µs [506.787 µs, 552.247 µs]	132.421 µs (33.3%)
iast_INACTIVE	470.962 µs [449.239 µs, 492.685 µs]	73.866 µs (18.6%)
iast_TELEMETRY_OFF	518.028 µs [495.376 µs, 540.681 µs]	120.933 µs (30.5%)
tracing	463.672 µs [441.601 µs, 485.742 µs]	66.576 µs (16.8%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~c089869839, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section baseline
no_agent (1.373 ms) : 1352, 1394
. : milestone, 1373,
appsec (1.742 ms) : 1718, 1766
. : milestone, 1742,
appsec_no_iast (1.744 ms) : 1720, 1768
. : milestone, 1744,
code_origins (1.68 ms) : 1653, 1707
. : milestone, 1680,
iast (1.519 ms) : 1494, 1543
. : milestone, 1519,
profiling (1.554 ms) : 1528, 1580
. : milestone, 1554,
tracing (1.515 ms) : 1491, 1540
. : milestone, 1515,
section candidate
no_agent (1.356 ms) : 1336, 1375
. : milestone, 1356,
appsec (1.747 ms) : 1723, 1771
. : milestone, 1747,
appsec_no_iast (1.748 ms) : 1725, 1772
. : milestone, 1748,
code_origins (1.719 ms) : 1692, 1745
. : milestone, 1719,
iast (1.54 ms) : 1515, 1566
. : milestone, 1540,
profiling (1.525 ms) : 1502, 1548
. : milestone, 1525,
tracing (1.503 ms) : 1478, 1528
. : milestone, 1503,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.373 ms [1.352 ms, 1.394 ms]	-
appsec	1.742 ms [1.718 ms, 1.766 ms]	368.905 µs (26.9%)
appsec_no_iast	1.744 ms [1.72 ms, 1.768 ms]	370.845 µs (27.0%)
code_origins	1.68 ms [1.653 ms, 1.707 ms]	306.97 µs (22.4%)
iast	1.519 ms [1.494 ms, 1.543 ms]	145.512 µs (10.6%)
profiling	1.554 ms [1.528 ms, 1.58 ms]	180.828 µs (13.2%)
tracing	1.515 ms [1.491 ms, 1.54 ms]	142.349 µs (10.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.356 ms [1.336 ms, 1.375 ms]	-
appsec	1.747 ms [1.723 ms, 1.771 ms]	391.347 µs (28.9%)
appsec_no_iast	1.748 ms [1.725 ms, 1.772 ms]	392.635 µs (29.0%)
code_origins	1.719 ms [1.692 ms, 1.745 ms]	362.985 µs (26.8%)
iast	1.54 ms [1.515 ms, 1.566 ms]	184.65 µs (13.6%)
profiling	1.525 ms [1.502 ms, 1.548 ms]	169.058 µs (12.5%)
tracing	1.503 ms [1.478 ms, 1.528 ms]	147.433 µs (10.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	sarahchen6/fix-jdk-uds-implementation
git_commit_date	1746535002	1746560721
git_commit_sha	`5bfab65`	`c089869`
release_version	1.49.0-SNAPSHOT~5bfab6549b	1.50.0-SNAPSHOT~c089869839

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1746563284	1746563284
ci_job_id	926690514	926690514
ci_pipeline_id	64313166	64313166
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-dhdkofs9-project-304-concurrent-0-06b61mk3 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-dhdkofs9-project-304-concurrent-0-06b61mk3 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~c089869839, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.372 ms) : 2325, 2419
. : milestone, 2372,
iast (2.147 ms) : 2088, 2206
. : milestone, 2147,
iast_GLOBAL (2.193 ms) : 2133, 2253
. : milestone, 2193,
profiling (1.993 ms) : 1947, 2040
. : milestone, 1993,
tracing (1.976 ms) : 1931, 2022
. : milestone, 1976,
section candidate
no_agent (1.467 ms) : 1455, 1478
. : milestone, 1467,
appsec (2.374 ms) : 2327, 2421
. : milestone, 2374,
iast (2.15 ms) : 2091, 2209
. : milestone, 2150,
iast_GLOBAL (2.199 ms) : 2140, 2259
. : milestone, 2199,
profiling (1.995 ms) : 1948, 2042
. : milestone, 1995,
tracing (1.969 ms) : 1924, 2015
. : milestone, 1969,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.469 ms [1.458 ms, 1.481 ms]	-
appsec	2.372 ms [2.325 ms, 2.419 ms]	902.584 µs (61.4%)
iast	2.147 ms [2.088 ms, 2.206 ms]	677.415 µs (46.1%)
iast_GLOBAL	2.193 ms [2.133 ms, 2.253 ms]	723.448 µs (49.2%)
profiling	1.993 ms [1.947 ms, 2.04 ms]	524.22 µs (35.7%)
tracing	1.976 ms [1.931 ms, 2.022 ms]	506.953 µs (34.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.467 ms [1.455 ms, 1.478 ms]	-
appsec	2.374 ms [2.327 ms, 2.421 ms]	907.384 µs (61.9%)
iast	2.15 ms [2.091 ms, 2.209 ms]	683.115 µs (46.6%)
iast_GLOBAL	2.199 ms [2.14 ms, 2.259 ms]	732.639 µs (50.0%)
profiling	1.995 ms [1.948 ms, 2.042 ms]	528.719 µs (36.1%)
tracing	1.969 ms [1.924 ms, 2.015 ms]	502.736 µs (34.3%)

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~c089869839, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section baseline
no_agent (15.016 s) : 15016000, 15016000
. : milestone, 15016000,
appsec (15.204 s) : 15204000, 15204000
. : milestone, 15204000,
iast (19.153 s) : 19153000, 19153000
. : milestone, 19153000,
iast_GLOBAL (17.975 s) : 17975000, 17975000
. : milestone, 17975000,
profiling (15.04 s) : 15040000, 15040000
. : milestone, 15040000,
tracing (14.927 s) : 14927000, 14927000
. : milestone, 14927000,
section candidate
no_agent (14.978 s) : 14978000, 14978000
. : milestone, 14978000,
appsec (15.051 s) : 15051000, 15051000
. : milestone, 15051000,
iast (19.059 s) : 19059000, 19059000
. : milestone, 19059000,
iast_GLOBAL (18.424 s) : 18424000, 18424000
. : milestone, 18424000,
profiling (15.754 s) : 15754000, 15754000
. : milestone, 15754000,
tracing (14.927 s) : 14927000, 14927000
. : milestone, 14927000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.016 s [15.016 s, 15.016 s]	-
appsec	15.204 s [15.204 s, 15.204 s]	188.0 ms (1.3%)
iast	19.153 s [19.153 s, 19.153 s]	4.137 s (27.6%)
iast_GLOBAL	17.975 s [17.975 s, 17.975 s]	2.959 s (19.7%)
profiling	15.04 s [15.04 s, 15.04 s]	24.0 ms (0.2%)
tracing	14.927 s [14.927 s, 14.927 s]	-89.0 ms (-0.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.978 s [14.978 s, 14.978 s]	-
appsec	15.051 s [15.051 s, 15.051 s]	73.0 ms (0.5%)
iast	19.059 s [19.059 s, 19.059 s]	4.081 s (27.2%)
iast_GLOBAL	18.424 s [18.424 s, 18.424 s]	3.446 s (23.0%)
profiling	15.754 s [15.754 s, 15.754 s]	776.0 ms (5.2%)
tracing	14.927 s [14.927 s, 14.927 s]	-51.0 ms (-0.3%)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.49.0` -> `1.50.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.50.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.50.0): 1.50.0 ### Deprecation Notice > \[!NOTE] > `DD_RUNTIME_ID_ENABLED` has been deprecated and will be removed in future releases. Please use `DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED` instead. ### Components #### Application Security Management (WAF) - 🐛 Add String length truncation limit to ObjectIntrospector and update truncation metrics ([#8825](DataDog/dd-trace-java#8825) - [@jandro996](https://github.com/jandro996)) - 🐛 Adapt standalone ASM to support API Security ([#8804](DataDog/dd-trace-java#8804) - [@jandro996](https://github.com/jandro996)) - ✨ Add appsec.waf.input\_truncated metric ([#8791](DataDog/dd-trace-java#8791) - [@jandro996](https://github.com/jandro996)) - ✨ Extended appsec request body collection ([#8748](DataDog/dd-trace-java#8748) - [@jandro996](https://github.com/jandro996)) - ✨ Extended appsec request/response headers collection ([#8724](DataDog/dd-trace-java#8724) - [@jandro996](https://github.com/jandro996)) #### Build & Tooling - ✨ Add artifacts to public s3 bucket ([#8947](DataDog/dd-trace-java#8947) - [@randomanderson](https://github.com/randomanderson)) #### Continuous Integration Visibility - ✨ Improve PR information building ([#8908](DataDog/dd-trace-java#8908) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Truncate span stack traces when Test Optimization is enabled ([#8903](DataDog/dd-trace-java#8903) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Ensure auto-detected service name is the same for every process in the same build ([#8902](DataDog/dd-trace-java#8902) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Use tag as fallback in api requests if no branch is available ([#8876](DataDog/dd-trace-java#8876) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add support for JUnit 5.13-RC1 ([#8865](DataDog/dd-trace-java#8865), [#8871](DataDog/dd-trace-java#8871) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement attempt to fix v3 and v4 and bump capability version ([#8824](DataDog/dd-trace-java#8824) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🧹 Align retry logic for all test framework instrumentations ([#8803](DataDog/dd-trace-java#8803) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🐛 Always build ci workspace without trailing separator ([#8788](DataDog/dd-trace-java#8788) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add commit discrepancies telemetry when building repository git information ([#8763](DataDog/dd-trace-java#8763) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - 💡 Surface process tags in dsm payloads and use them for base hash calculation ([#8836](DataDog/dd-trace-java#8836) - [@amarziali](https://github.com/amarziali)) #### Dynamic Instrumentation - ✨ Optimized allocations for collection filter functions ([#8896](DataDog/dd-trace-java#8896) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix SymDB upload size check ([#8887](DataDog/dd-trace-java#8887) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Add support for Set in filter function ([#8873](DataDog/dd-trace-java#8873) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Add support for isDefined in log template ([#8859](DataDog/dd-trace-java#8859) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix Max captured frames for Exception Replay ([#8856](DataDog/dd-trace-java#8856) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Remove static inherited fields collection ([#8832](DataDog/dd-trace-java#8832) - [@jpbempel](https://github.com/jpbempel)) - 💡 Add process tags to dynamic instrumentation intake payload ([#8779](DataDog/dd-trace-java#8779) - [@amarziali](https://github.com/amarziali)) #### GraalVM native-image - ✨ Add support for GraalVM Native GC metrics ([#8913](DataDog/dd-trace-java#8913) - [@ygree](https://github.com/ygree)) - ✨ Add JMXFetch support for GraalVM Native ([#8569](DataDog/dd-trace-java#8569) - [@ygree](https://github.com/ygree)) #### JMX fetch - ✨ Add support for GraalVM Native GC metrics ([#8913](DataDog/dd-trace-java#8913) - [@ygree](https://github.com/ygree)) #### Library Injection - ✨ Deny oracle db jvm based tools ([#8909](DataDog/dd-trace-java#8909) - [@bric3](https://github.com/bric3)) #### OpenTracing - 🐛 Fix OT packaging for exception replay ([#8912](DataDog/dd-trace-java#8912) - [@jpbempel](https://github.com/jpbempel)) #### Profiling - ✨ Bump ddprof to 1.27.0 ([#8893](DataDog/dd-trace-java#8893) - [@jbachorik](https://github.com/jbachorik)) - Properly handle the adaptive sampling interval overflow by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#213 - Fix [#200](DataDog/dd-trace-java#200) Crash related to aligned\_alloc and free in context by [@yanglong1010](https://github.com/yanglong1010) in DataDog/java-profiler#208 - Explicitly initialize empty context page by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#210 - Re-connect crash recursion protection with VM stackwalker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#214 - ✨ Enable ZSTD compression for profiling ([#8862](DataDog/dd-trace-java#8862) - [@MattAlp](https://github.com/MattAlp)) - ✨ Extend JPS re-implementation to J9 family ([#8813](DataDog/dd-trace-java#8813) - [@MattAlp](https://github.com/MattAlp)) - 💡 Collect process tags for profiling upload requests ([#8780](DataDog/dd-trace-java#8780) - [@amarziali](https://github.com/amarziali)) #### Telemetry - 💡 Surface process tags on telemetry payloads ([#8837](DataDog/dd-trace-java#8837) - [@amarziali](https://github.com/amarziali)) #### Trace context propagation - ✨ Migrating all HttpClient Instrumentations to Inject Full Context ([#8826](DataDog/dd-trace-java#8826) - [@mhlidd](https://github.com/mhlidd)) - ✨ Migrating all HttpServer Instrumentations to Extract full Context ([#8820](DataDog/dd-trace-java#8820) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add context API support OTel propagators ([#8770](DataDog/dd-trace-java#8770) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - ✨⚡ Skip JAXB generated classes classloader ([#9003](DataDog/dd-trace-java#9003) - [@bric3](https://github.com/bric3)) - ✨ Add DD\_RUNTIME\_METRICS\_RUNTIME\_ID\_ENABLED alias for runtime id generation ([#8981](DataDog/dd-trace-java#8981) - [@amarziali](https://github.com/amarziali)) - 🐛 Use resolved address for peer.hostname when available without hitting the cache ([#8915](DataDog/dd-trace-java#8915) - [@amarziali](https://github.com/amarziali)) - 💡 Surface server name process tag for tomcat ([#8894](DataDog/dd-trace-java#8894) - [@amarziali](https://github.com/amarziali)) - 💡 Surface websphere cell and server name on process tags ([#8880](DataDog/dd-trace-java#8880) - [@amarziali](https://github.com/amarziali)) - ✨ Added special lightweight pre-main class that skips installation on incompatible JVMs. ([#8855](DataDog/dd-trace-java#8855) - [@AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Add entrypoint type to process tags ([#8839](DataDog/dd-trace-java#8839) - [@amarziali](https://github.com/amarziali)) - ✨ Extend JPS re-implementation to J9 family ([#8813](DataDog/dd-trace-java#8813) - [@MattAlp](https://github.com/MattAlp)) - ✨ Notify listeners when the scope top changes after switching scope stacks ([#8797](DataDog/dd-trace-java#8797) - [@mcculls](https://github.com/mcculls)) - ✨ Read hsperfdata for Java PIDs if jvmstat is unavailable ([#8792](DataDog/dd-trace-java#8792) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Turn JDK socket support on by default ([#8752](DataDog/dd-trace-java#8752) - [@sarahchen6](https://github.com/sarahchen6)) - ✨ Simplify context propagation ([#8719](DataDog/dd-trace-java#8719) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Add JSON parsing support ([#8579](DataDog/dd-trace-java#8579) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer internal logging - ✨ Fix printing format of span identifiers ([#8897](DataDog/dd-trace-java#8897) - [@vandonr](https://github.com/vandonr)) #### Tracer public API - 💡 Track the source of installation ([#8956](DataDog/dd-trace-java#8956) - [@mabdinur](https://github.com/mabdinur)) - ✨ Enforce size limit on application\_monitoring.yaml files ([#8789](DataDog/dd-trace-java#8789) - [@mtoffl01](https://github.com/mtoffl01)) - ✨ Enabling baggage cache to support limits and non-ascii characters ([#8713](DataDog/dd-trace-java#8713) - [@mhlidd](https://github.com/mhlidd)) ### Instrumentations #### AWS Lambda instrumentation - ✨ Pass Lambda Request ID to Extension ([#8814](DataDog/dd-trace-java#8814) - [@nhulston](https://github.com/nhulston)) #### Core Java language instrumentation - ✨ Ensure ClassloadingInstrumentation is always applied even with `DD_TRACE_ENABLED=false` ([#8863](DataDog/dd-trace-java#8863) - [@mcculls](https://github.com/mcculls)) #### Eclipse Vert.x instrumentation - 🐛 Do not override route with / in vertx instrumentation ([#8881](DataDog/dd-trace-java#8881) - [@vandonr](https://github.com/vandonr)) #### IBM Liberty - 🐛 Fix error mark on http status for IBM liberty ([#8822](DataDog/dd-trace-java#8822) - [@amarziali](https://github.com/amarziali)) #### JDBC instrumentation - 🐛 Do not prepend DBM <> APM trace comment in SQLCommenter if there is a pg plan hint ([#8864](DataDog/dd-trace-java#8864) - [@edengorevoy](https://github.com/edengorevoy)) #### JMS instrumentation - ✨ Add jms as an extra integration name where there is JMS involved ([#8933](DataDog/dd-trace-java#8933) - [@vandonr](https://github.com/vandonr)) #### Kotlin instrumentation - ✨ Enable kotlin\_coroutine integration by default ([#8848](DataDog/dd-trace-java#8848) - [@mcculls](https://github.com/mcculls)) - 🧹 Rework Kotlin coroutines instrumentation around coroutine context ([#8774](DataDog/dd-trace-java#8774) - [@mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Support WithSpan inheritContext attribute ([#8858](DataDog/dd-trace-java#8858) - [@amarziali](https://github.com/amarziali)) - ✨ Add context API support OTel propagators ([#8770](DataDog/dd-trace-java#8770) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Play Framework instrumentation - 🐛 Fix the Play Framework's span resource name priority so that the client JAX-RS 404 cannot override it ([#8591](DataDog/dd-trace-java#8591) - [@ygree](https://github.com/ygree)) #### Quarkus Instrumentation - 🐛 Ignore quarkus jaxrs stubs and cdi wrapper proxies ([#8891](DataDog/dd-trace-java#8891) - [@amarziali](https://github.com/amarziali)) #### ServiceTalk - ✨ Improve ServiceTalk Captured Context API Instrumentation for v0.42.56+ ([#8821](DataDog/dd-trace-java#8821) - [@ygree](https://github.com/ygree)) #### Spring instrumentation - ✨ Supporting Baggage for Instrumentations used in Weblog Tests ([#8773](DataDog/dd-trace-java#8773) - [@mhlidd](https://github.com/mhlidd)) #### WebSocket Instrumentation - 💡 Trace websocket for spring webflux reactive handlers ([#8831](DataDog/dd-trace-java#8831) - [@amarziali](https://github.com/amarziali)) - 💡:test\_tube: WebSocket support for Netty ([#8632](DataDog/dd-trace-java#8632) - [@ValentinZakharov](https://github.com/ValentinZakharov)) #### Zio Instrumentation - 🧹 Cleanup Zio fiber instrumentation to avoid repeated activation of continuation ([#8798](DataDog/dd-trace-java#8798) - [@mcculls](https://github.com/mcculls)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 9207366cdb6a1bd098082305d354a0a3c4622d7a

sarahchen6 added type: bug fix Bug fix tag: do not merge Do not merge changes labels Apr 29, 2025

sarahchen6 changed the title ~~[WIP] Fix native UDS file leakage~~Fix native UDS file leakage and closing techniqueMay 1, 2025

sarahchen6 added comp: core Tracer core and removed tag: do not merge Do not merge changes labels May 2, 2025

sarahchen6 marked this pull request as ready for review May 2, 2025 00:07

sarahchen6 requested a review from a team as a code owner May 2, 2025 00:07

sarahchen6 requested a review from amarziali May 2, 2025 00:07

amarziali requested a review from PerfectSlayer May 2, 2025 07:10

sarahchen6 marked this pull request as draft May 2, 2025 11:33

sarahchen6 force-pushed the sarahchen6/fix-jdk-uds-implementation branch from ce4aaa1 to d79201eCompare May 2, 2025 12:46

sarahchen6 marked this pull request as ready for review May 2, 2025 12:46

amarziali approved these changes May 2, 2025
View reviewed changes

mcculls reviewed May 2, 2025
View reviewed changes

Comment threadinternal-api/src/main/java/datadog/trace/api/Config.java Outdated

sarahchen6 added the tag: do not merge Do not merge changes label May 2, 2025

sarahchen6 changed the title ~~Fix native UDS file leakage and closing technique~~Solves native UDS file leakage and closing issueMay 6, 2025

sarahchen6 removed the tag: do not merge Do not merge changes label May 6, 2025

sarahchen6 added 7 commits May 6, 2025 14:38

Add test for file descriptors
ca9fcf5

Fix closing technique
a098bb0

Add tests for socket and stream connection and closing
bfcb079

Fix closing technique again
d12cf3f

Clean implementation and tests to match expected Socket behavior
1f7c3df

Remove comments
3133a7b

Change default JDK_SOCKET_ENABLED to true
4e6eb27

sarahchen6 force-pushed the sarahchen6/fix-jdk-uds-implementation branch from c8a66a3 to 4e6eb27Compare May 6, 2025 18:39

dougqh reviewed May 6, 2025
View reviewed changes

Comment threadutils/socket-utils/src/main/java17/datadog/common/socket/TunnelingJdkSocket.java Outdated

dougqh reviewed May 6, 2025
View reviewed changes

Comment threadutils/socket-utils/src/main/java17/datadog/common/socket/TunnelingJdkSocket.java Outdated

dougqh reviewed May 6, 2025
View reviewed changes

Comment threadutils/socket-utils/src/main/java17/datadog/common/socket/TunnelingJdkSocket.java Outdated

Address PR comments about socket closing and buffer exceptions
c089869

sarahchen6 changed the title ~~Solves native UDS file leakage and closing issue~~Solve file leakage and turn JDK socket support on by defaultMay 7, 2025

sarahchen6 merged commit c2faab3 into masterMay 7, 2025

sarahchen6 deleted the sarahchen6/fix-jdk-uds-implementation branch May 7, 2025 19:17

github-actionsBot added this to the 1.50.0 milestone May 7, 2025

mcculls changed the title ~~Solve file leakage and turn JDK socket support on by default~~Turn JDK socket support on by defaultMay 13, 2025

Navigation Menu

Uh oh!

Turn JDK socket support on by default - #8752

Turn JDK socket support on by default#8752
sarahchen6 merged 8 commits into
masterfrom
sarahchen6/fix-jdk-uds-implementation

sarahchen6 commented Apr 29, 2025•
edited
Loading

Uh oh!

pr-commenterBot commented Apr 29, 2025•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

sarahchen6 commented Apr 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenterBot commented Apr 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sarahchen6 commented Apr 29, 2025•
edited
Loading

pr-commenterBot commented Apr 29, 2025•
edited
Loading