Always build ci workspace without trailing separator by daniel-mohedano · Pull Request #8788 · DataDog/dd-trace-java

daniel-mohedano · 2025-05-08T15:07:55Z

What Does This Do

Always build CI Workspace without trailing separators. Before it was unchecked and could cause git informations built to not be correctly identified in the cache.

Motivation

The method datadog.trace.api.git.GitInfoProvider#getGitInfo(java.lang.String) is sometimes called with a normalized path (datadog.trace.civisibility.ci.CITagsProvider#getCiTags) and others with a regular path without trailing separator (datadog.trace.common.GitMetadataTraceInterceptor#onTraceComplete). This means that the same git information will be built twice, as it is cached using the repository path. For example: /repo/path and /repo/path/ were not considered the same.

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket:

pr-commenter · 2025-05-08T15:53:57Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	daniel.mohedano/ci-workspace-path-normalization
git_commit_date	1746789389	1746789040
git_commit_sha	`ad6d5fe`	`de21bd1`
release_version	1.50.0-SNAPSHOT~ad6d5fef42	1.50.0-SNAPSHOT~de21bd10c2

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1746792041	1746792041
ci_job_id	931229400	931229400
ci_pipeline_id	64624179	64624179
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-njbofxpe-project-304-concurrent-0-q8by7tbj 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-njbofxpe-project-304-concurrent-0-q8by7tbj 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics.

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~de21bd10c2, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.025 s) : 0, 1025468
Total [baseline] (10.484 s) : 0, 10483863
Agent [candidate] (1.025 s) : 0, 1024997
Total [candidate] (10.548 s) : 0, 10548166
section appsec
Agent [baseline] (1.16 s) : 0, 1159609
Total [baseline] (10.655 s) : 0, 10655067
Agent [candidate] (1.166 s) : 0, 1165603
Total [candidate] (10.738 s) : 0, 10738499
section iast
Agent [baseline] (1.152 s) : 0, 1151503
Total [baseline] (10.914 s) : 0, 10913587
Agent [candidate] (1.15 s) : 0, 1149769
Total [candidate] (10.855 s) : 0, 10854930
section profiling
Agent [baseline] (1.279 s) : 0, 1279028
Total [baseline] (10.89 s) : 0, 10890326
Agent [candidate] (1.286 s) : 0, 1285653
Total [candidate] (10.907 s) : 0, 10907396

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.025 s	-
Agent	appsec	1.16 s	134.141 ms (13.1%)
Agent	iast	1.152 s	126.035 ms (12.3%)
Agent	profiling	1.279 s	253.56 ms (24.7%)
Total	tracing	10.484 s	-
Total	appsec	10.655 s	171.204 ms (1.6%)
Total	iast	10.914 s	429.724 ms (4.1%)
Total	profiling	10.89 s	406.463 ms (3.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.025 s	-
Agent	appsec	1.166 s	140.606 ms (13.7%)
Agent	iast	1.15 s	124.772 ms (12.2%)
Agent	profiling	1.286 s	260.656 ms (25.4%)
Total	tracing	10.548 s	-
Total	appsec	10.738 s	190.333 ms (1.8%)
Total	iast	10.855 s	306.764 ms (2.9%)
Total	profiling	10.907 s	359.23 ms (3.4%)

gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~de21bd10c2, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.738 ms) : 0, 687738
BytebuddyAgent [candidate] (687.282 ms) : 0, 687282
GlobalTracer [baseline] (241.019 ms) : 0, 241019
GlobalTracer [candidate] (241.055 ms) : 0, 241055
AppSec [baseline] (54.7 ms) : 0, 54700
AppSec [candidate] (54.73 ms) : 0, 54730
Debugger [baseline] (6.248 ms) : 0, 6248
Debugger [candidate] (8.366 ms) : 0, 8366
Remote Config [baseline] (705.567 µs) : 0, 706
Remote Config [candidate] (715.53 µs) : 0, 716
Telemetry [baseline] (11.391 ms) : 0, 11391
Telemetry [candidate] (9.167 ms) : 0, 9167
section appsec
BytebuddyAgent [baseline] (699.351 ms) : 0, 699351
BytebuddyAgent [candidate] (703.244 ms) : 0, 703244
GlobalTracer [baseline] (236.039 ms) : 0, 236039
GlobalTracer [candidate] (237.411 ms) : 0, 237411
IAST [baseline] (21.655 ms) : 0, 21655
IAST [candidate] (21.715 ms) : 0, 21715
AppSec [baseline] (175.968 ms) : 0, 175968
AppSec [candidate] (176.05 ms) : 0, 176050
Debugger [baseline] (5.922 ms) : 0, 5922
Debugger [candidate] (6.004 ms) : 0, 6004
Remote Config [baseline] (614.203 µs) : 0, 614
Remote Config [candidate] (625.875 µs) : 0, 626
Telemetry [baseline] (7.373 ms) : 0, 7373
Telemetry [candidate] (7.822 ms) : 0, 7822
section iast
BytebuddyAgent [baseline] (803.209 ms) : 0, 803209
BytebuddyAgent [candidate] (802.832 ms) : 0, 802832
GlobalTracer [baseline] (230.988 ms) : 0, 230988
GlobalTracer [candidate] (230.547 ms) : 0, 230547
IAST [baseline] (27.582 ms) : 0, 27582
IAST [candidate] (25.893 ms) : 0, 25893
AppSec [baseline] (51.63 ms) : 0, 51630
AppSec [candidate] (51.173 ms) : 0, 51173
Debugger [baseline] (5.96 ms) : 0, 5960
Debugger [candidate] (5.913 ms) : 0, 5913
Remote Config [baseline] (599.64 µs) : 0, 600
Remote Config [candidate] (593.077 µs) : 0, 593
Telemetry [baseline] (7.895 ms) : 0, 7895
Telemetry [candidate] (7.842 ms) : 0, 7842
section profiling
BytebuddyAgent [baseline] (673.47 ms) : 0, 673470
BytebuddyAgent [candidate] (676.3 ms) : 0, 676300
GlobalTracer [baseline] (377.121 ms) : 0, 377121
GlobalTracer [candidate] (378.529 ms) : 0, 378529
AppSec [baseline] (54.088 ms) : 0, 54088
AppSec [candidate] (54.236 ms) : 0, 54236
Debugger [baseline] (6.126 ms) : 0, 6126
Debugger [candidate] (6.225 ms) : 0, 6225
Remote Config [baseline] (647.427 µs) : 0, 647
Remote Config [candidate] (659.857 µs) : 0, 660
Telemetry [baseline] (8.033 ms) : 0, 8033
Telemetry [candidate] (8.241 ms) : 0, 8241
ProfilingAgent [baseline] (109.135 ms) : 0, 109135
ProfilingAgent [candidate] (110.651 ms) : 0, 110651
Profiling [baseline] (109.16 ms) : 0, 109160
Profiling [candidate] (110.676 ms) : 0, 110676

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~de21bd10c2, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.027 s) : 0, 1027258
Total [baseline] (8.676 s) : 0, 8676277
Agent [candidate] (1.02 s) : 0, 1019945
Total [candidate] (8.648 s) : 0, 8648299
section iast
Agent [baseline] (1.147 s) : 0, 1147001
Total [baseline] (9.228 s) : 0, 9228084
Agent [candidate] (1.15 s) : 0, 1149686
Total [candidate] (9.258 s) : 0, 9258299
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.148 s) : 0, 1148071
Total [baseline] (9.192 s) : 0, 9191956
Agent [candidate] (1.15 s) : 0, 1150482
Total [candidate] (9.206 s) : 0, 9206368
section iast_TELEMETRY_OFF
Agent [baseline] (1.153 s) : 0, 1152976
Total [baseline] (9.205 s) : 0, 9204640
Agent [candidate] (1.144 s) : 0, 1143736
Total [candidate] (9.249 s) : 0, 9249463

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.027 s	-
Agent	iast	1.147 s	119.744 ms (11.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.148 s	120.813 ms (11.8%)
Agent	iast_TELEMETRY_OFF	1.153 s	125.718 ms (12.2%)
Total	tracing	8.676 s	-
Total	iast	9.228 s	551.807 ms (6.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.192 s	515.679 ms (5.9%)
Total	iast_TELEMETRY_OFF	9.205 s	528.362 ms (6.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.02 s	-
Agent	iast	1.15 s	129.742 ms (12.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.15 s	130.538 ms (12.8%)
Agent	iast_TELEMETRY_OFF	1.144 s	123.792 ms (12.1%)
Total	tracing	8.648 s	-
Total	iast	9.258 s	610.001 ms (7.1%)
Total	iast_HARDCODED_SECRET_DISABLED	9.206 s	558.07 ms (6.5%)
Total	iast_TELEMETRY_OFF	9.249 s	601.165 ms (7.0%)

gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~de21bd10c2, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.633 ms) : 0, 685633
BytebuddyAgent [candidate] (682.54 ms) : 0, 682540
GlobalTracer [baseline] (241.867 ms) : 0, 241867
GlobalTracer [candidate] (240.355 ms) : 0, 240355
AppSec [baseline] (54.597 ms) : 0, 54597
AppSec [candidate] (54.529 ms) : 0, 54529
Debugger [baseline] (10.681 ms) : 0, 10681
Debugger [candidate] (8.43 ms) : 0, 8430
Remote Config [baseline] (714.746 µs) : 0, 715
Remote Config [candidate] (691.961 µs) : 0, 692
Telemetry [baseline] (9.941 ms) : 0, 9941
Telemetry [candidate] (9.853 ms) : 0, 9853
section iast
BytebuddyAgent [baseline] (800.588 ms) : 0, 800588
BytebuddyAgent [candidate] (801.452 ms) : 0, 801452
GlobalTracer [baseline] (230.066 ms) : 0, 230066
GlobalTracer [candidate] (231.176 ms) : 0, 231176
IAST [baseline] (27.417 ms) : 0, 27417
IAST [candidate] (26.878 ms) : 0, 26878
AppSec [baseline] (51.045 ms) : 0, 51045
AppSec [candidate] (52.259 ms) : 0, 52259
Debugger [baseline] (5.908 ms) : 0, 5908
Debugger [candidate] (5.953 ms) : 0, 5953
Remote Config [baseline] (593.015 µs) : 0, 593
Remote Config [candidate] (604.513 µs) : 0, 605
Telemetry [baseline] (7.863 ms) : 0, 7863
Telemetry [candidate] (7.896 ms) : 0, 7896
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (801.493 ms) : 0, 801493
BytebuddyAgent [candidate] (802.398 ms) : 0, 802398
GlobalTracer [baseline] (229.878 ms) : 0, 229878
GlobalTracer [candidate] (231.07 ms) : 0, 231070
IAST [baseline] (27.634 ms) : 0, 27634
IAST [candidate] (24.421 ms) : 0, 24421
AppSec [baseline] (49.629 ms) : 0, 49629
AppSec [candidate] (52.966 ms) : 0, 52966
Debugger [baseline] (5.935 ms) : 0, 5935
Debugger [candidate] (5.943 ms) : 0, 5943
Remote Config [baseline] (594.433 µs) : 0, 594
Remote Config [candidate] (586.246 µs) : 0, 586
Telemetry [baseline] (7.911 ms) : 0, 7911
Telemetry [candidate] (7.951 ms) : 0, 7951
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (804.83 ms) : 0, 804830
BytebuddyAgent [candidate] (797.216 ms) : 0, 797216
GlobalTracer [baseline] (231.698 ms) : 0, 231698
GlobalTracer [candidate] (230.102 ms) : 0, 230102
IAST [baseline] (22.361 ms) : 0, 22361
IAST [candidate] (24.088 ms) : 0, 24088
AppSec [baseline] (55.961 ms) : 0, 55961
AppSec [candidate] (54.468 ms) : 0, 54468
Debugger [baseline] (5.978 ms) : 0, 5978
Debugger [candidate] (5.979 ms) : 0, 5979
Remote Config [baseline] (602.726 µs) : 0, 603
Remote Config [candidate] (603.995 µs) : 0, 604
Telemetry [baseline] (7.854 ms) : 0, 7854
Telemetry [candidate] (7.786 ms) : 0, 7786

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-05-09T11:31:02	2025-05-09T11:38:51
git_branch	master	daniel.mohedano/ci-workspace-path-normalization
git_commit_date	1746789389	1746789040
git_commit_sha	`ad6d5fe`	`de21bd1`
release_version	1.50.0-SNAPSHOT~ad6d5fef42	1.50.0-SNAPSHOT~de21bd10c2
start_time	2025-05-09T11:30:47	2025-05-09T11:38:36

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1746791131	1746791131
ci_job_id	931229401	931229401
ci_pipeline_id	64624179	64624179
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-njbofxpe-project-304-concurrent-1-0drmh0nt 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-njbofxpe-project-304-concurrent-1-0drmh0nt 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~de21bd10c2, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (383.076 µs) : 363, 403
. : milestone, 383,
iast (523.037 µs) : 501, 545
. : milestone, 523,
iast_FULL (738.529 µs) : 716, 761
. : milestone, 739,
iast_GLOBAL (566.658 µs) : 545, 588
. : milestone, 567,
iast_HARDCODED_SECRET_DISABLED (531.977 µs) : 509, 555
. : milestone, 532,
iast_INACTIVE (468.69 µs) : 447, 491
. : milestone, 469,
iast_TELEMETRY_OFF (509.173 µs) : 486, 532
. : milestone, 509,
tracing (468.721 µs) : 446, 491
. : milestone, 469,
section candidate
no_agent (381.933 µs) : 362, 402
. : milestone, 382,
iast (532.625 µs) : 509, 556
. : milestone, 533,
iast_FULL (744.413 µs) : 722, 767
. : milestone, 744,
iast_GLOBAL (563.629 µs) : 542, 585
. : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (520.017 µs) : 497, 543
. : milestone, 520,
iast_INACTIVE (467.51 µs) : 445, 490
. : milestone, 468,
iast_TELEMETRY_OFF (511.027 µs) : 488, 535
. : milestone, 511,
tracing (466.402 µs) : 444, 489
. : milestone, 466,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	383.076 µs [362.911 µs, 403.242 µs]	-
iast	523.037 µs [501.16 µs, 544.914 µs]	139.961 µs (36.5%)
iast_FULL	738.529 µs [716.494 µs, 760.564 µs]	355.453 µs (92.8%)
iast_GLOBAL	566.658 µs [545.12 µs, 588.197 µs]	183.582 µs (47.9%)
iast_HARDCODED_SECRET_DISABLED	531.977 µs [509.248 µs, 554.707 µs]	148.901 µs (38.9%)
iast_INACTIVE	468.69 µs [446.564 µs, 490.816 µs]	85.614 µs (22.3%)
iast_TELEMETRY_OFF	509.173 µs [486.028 µs, 532.318 µs]	126.096 µs (32.9%)
tracing	468.721 µs [446.177 µs, 491.265 µs]	85.645 µs (22.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	381.933 µs [361.598 µs, 402.268 µs]	-
iast	532.625 µs [509.374 µs, 555.876 µs]	150.692 µs (39.5%)
iast_FULL	744.413 µs [721.835 µs, 766.99 µs]	362.48 µs (94.9%)
iast_GLOBAL	563.629 µs [541.956 µs, 585.301 µs]	181.696 µs (47.6%)
iast_HARDCODED_SECRET_DISABLED	520.017 µs [497.048 µs, 542.986 µs]	138.085 µs (36.2%)
iast_INACTIVE	467.51 µs [444.999 µs, 490.021 µs]	85.577 µs (22.4%)
iast_TELEMETRY_OFF	511.027 µs [487.532 µs, 534.522 µs]	129.094 µs (33.8%)
tracing	466.402 µs [444.155 µs, 488.648 µs]	84.469 µs (22.1%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~de21bd10c2, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.377 ms) : 1357, 1398
. : milestone, 1377,
appsec (1.752 ms) : 1729, 1776
. : milestone, 1752,
appsec_no_iast (1.749 ms) : 1725, 1772
. : milestone, 1749,
code_origins (1.691 ms) : 1663, 1719
. : milestone, 1691,
iast (1.519 ms) : 1495, 1544
. : milestone, 1519,
profiling (1.567 ms) : 1542, 1591
. : milestone, 1567,
tracing (1.496 ms) : 1471, 1521
. : milestone, 1496,
section candidate
no_agent (1.366 ms) : 1347, 1385
. : milestone, 1366,
appsec (1.75 ms) : 1726, 1774
. : milestone, 1750,
appsec_no_iast (1.741 ms) : 1717, 1764
. : milestone, 1741,
code_origins (1.668 ms) : 1641, 1695
. : milestone, 1668,
iast (1.52 ms) : 1494, 1545
. : milestone, 1520,
profiling (1.526 ms) : 1501, 1550
. : milestone, 1526,
tracing (1.517 ms) : 1493, 1542
. : milestone, 1517,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.377 ms [1.357 ms, 1.398 ms]	-
appsec	1.752 ms [1.729 ms, 1.776 ms]	374.846 µs (27.2%)
appsec_no_iast	1.749 ms [1.725 ms, 1.772 ms]	371.198 µs (26.9%)
code_origins	1.691 ms [1.663 ms, 1.719 ms]	313.51 µs (22.8%)
iast	1.519 ms [1.495 ms, 1.544 ms]	141.863 µs (10.3%)
profiling	1.567 ms [1.542 ms, 1.591 ms]	189.195 µs (13.7%)
tracing	1.496 ms [1.471 ms, 1.521 ms]	118.624 µs (8.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.366 ms [1.347 ms, 1.385 ms]	-
appsec	1.75 ms [1.726 ms, 1.774 ms]	384.707 µs (28.2%)
appsec_no_iast	1.741 ms [1.717 ms, 1.764 ms]	375.375 µs (27.5%)
code_origins	1.668 ms [1.641 ms, 1.695 ms]	302.698 µs (22.2%)
iast	1.52 ms [1.494 ms, 1.545 ms]	153.961 µs (11.3%)
profiling	1.526 ms [1.501 ms, 1.55 ms]	160.162 µs (11.7%)
tracing	1.517 ms [1.493 ms, 1.542 ms]	151.819 µs (11.1%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	daniel.mohedano/ci-workspace-path-normalization
git_commit_date	1746789389	1746789040
git_commit_sha	`ad6d5fe`	`de21bd1`
release_version	1.50.0-SNAPSHOT~ad6d5fef42	1.50.0-SNAPSHOT~de21bd10c2

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1746791626	1746791626
ci_job_id	931229402	931229402
ci_pipeline_id	64624179	64624179
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-ujqpvmht-project-304-concurrent-0-keisbev6 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-ujqpvmht-project-304-concurrent-0-keisbev6 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~de21bd10c2, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.412 ms) : 2363, 2461
. : milestone, 2412,
iast (2.186 ms) : 2124, 2248
. : milestone, 2186,
iast_GLOBAL (2.238 ms) : 2176, 2301
. : milestone, 2238,
profiling (2.04 ms) : 1989, 2091
. : milestone, 2040,
tracing (2.006 ms) : 1958, 2054
. : milestone, 2006,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (2.414 ms) : 2364, 2463
. : milestone, 2414,
iast (2.196 ms) : 2133, 2258
. : milestone, 2196,
iast_GLOBAL (2.23 ms) : 2168, 2292
. : milestone, 2230,
profiling (2.029 ms) : 1979, 2078
. : milestone, 2029,
tracing (2.004 ms) : 1957, 2052
. : milestone, 2004,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.466 ms, 1.489 ms]	-
appsec	2.412 ms [2.363 ms, 2.461 ms]	934.778 µs (63.3%)
iast	2.186 ms [2.124 ms, 2.248 ms]	708.538 µs (48.0%)
iast_GLOBAL	2.238 ms [2.176 ms, 2.301 ms]	760.916 µs (51.5%)
profiling	2.04 ms [1.989 ms, 2.091 ms]	562.501 µs (38.1%)
tracing	2.006 ms [1.958 ms, 2.054 ms]	528.423 µs (35.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.46 ms, 1.483 ms]	-
appsec	2.414 ms [2.364 ms, 2.463 ms]	941.733 µs (64.0%)
iast	2.196 ms [2.133 ms, 2.258 ms]	723.923 µs (49.2%)
iast_GLOBAL	2.23 ms [2.168 ms, 2.292 ms]	757.81 µs (51.5%)
profiling	2.029 ms [1.979 ms, 2.078 ms]	556.719 µs (37.8%)
tracing	2.004 ms [1.957 ms, 2.052 ms]	532.63 µs (36.2%)

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~de21bd10c2, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (15.064 s) : 15064000, 15064000
. : milestone, 15064000,
appsec (15.187 s) : 15187000, 15187000
. : milestone, 15187000,
iast (18.699 s) : 18699000, 18699000
. : milestone, 18699000,
iast_GLOBAL (18.292 s) : 18292000, 18292000
. : milestone, 18292000,
profiling (15.596 s) : 15596000, 15596000
. : milestone, 15596000,
tracing (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
section candidate
no_agent (14.957 s) : 14957000, 14957000
. : milestone, 14957000,
appsec (14.961 s) : 14961000, 14961000
. : milestone, 14961000,
iast (18.718 s) : 18718000, 18718000
. : milestone, 18718000,
iast_GLOBAL (18.092 s) : 18092000, 18092000
. : milestone, 18092000,
profiling (15.161 s) : 15161000, 15161000
. : milestone, 15161000,
tracing (14.713 s) : 14713000, 14713000
. : milestone, 14713000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.064 s [15.064 s, 15.064 s]	-
appsec	15.187 s [15.187 s, 15.187 s]	123.0 ms (0.8%)
iast	18.699 s [18.699 s, 18.699 s]	3.635 s (24.1%)
iast_GLOBAL	18.292 s [18.292 s, 18.292 s]	3.228 s (21.4%)
profiling	15.596 s [15.596 s, 15.596 s]	532.0 ms (3.5%)
tracing	14.946 s [14.946 s, 14.946 s]	-118.0 ms (-0.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.957 s [14.957 s, 14.957 s]	-
appsec	14.961 s [14.961 s, 14.961 s]	4.0 ms (0.0%)
iast	18.718 s [18.718 s, 18.718 s]	3.761 s (25.1%)
iast_GLOBAL	18.092 s [18.092 s, 18.092 s]	3.135 s (21.0%)
profiling	15.161 s [15.161 s, 15.161 s]	204.0 ms (1.4%)
tracing	14.713 s [14.713 s, 14.713 s]	-244.0 ms (-1.6%)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.49.0` -> `1.50.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.50.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.50.0): 1.50.0 ### Deprecation Notice > \[!NOTE] > `DD_RUNTIME_ID_ENABLED` has been deprecated and will be removed in future releases. Please use `DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED` instead. ### Components #### Application Security Management (WAF) - 🐛 Add String length truncation limit to ObjectIntrospector and update truncation metrics ([#8825](DataDog/dd-trace-java#8825) - [@jandro996](https://github.com/jandro996)) - 🐛 Adapt standalone ASM to support API Security ([#8804](DataDog/dd-trace-java#8804) - [@jandro996](https://github.com/jandro996)) - ✨ Add appsec.waf.input\_truncated metric ([#8791](DataDog/dd-trace-java#8791) - [@jandro996](https://github.com/jandro996)) - ✨ Extended appsec request body collection ([#8748](DataDog/dd-trace-java#8748) - [@jandro996](https://github.com/jandro996)) - ✨ Extended appsec request/response headers collection ([#8724](DataDog/dd-trace-java#8724) - [@jandro996](https://github.com/jandro996)) #### Build & Tooling - ✨ Add artifacts to public s3 bucket ([#8947](DataDog/dd-trace-java#8947) - [@randomanderson](https://github.com/randomanderson)) #### Continuous Integration Visibility - ✨ Improve PR information building ([#8908](DataDog/dd-trace-java#8908) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Truncate span stack traces when Test Optimization is enabled ([#8903](DataDog/dd-trace-java#8903) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Ensure auto-detected service name is the same for every process in the same build ([#8902](DataDog/dd-trace-java#8902) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Use tag as fallback in api requests if no branch is available ([#8876](DataDog/dd-trace-java#8876) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add support for JUnit 5.13-RC1 ([#8865](DataDog/dd-trace-java#8865), [#8871](DataDog/dd-trace-java#8871) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement attempt to fix v3 and v4 and bump capability version ([#8824](DataDog/dd-trace-java#8824) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🧹 Align retry logic for all test framework instrumentations ([#8803](DataDog/dd-trace-java#8803) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🐛 Always build ci workspace without trailing separator ([#8788](DataDog/dd-trace-java#8788) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add commit discrepancies telemetry when building repository git information ([#8763](DataDog/dd-trace-java#8763) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - 💡 Surface process tags in dsm payloads and use them for base hash calculation ([#8836](DataDog/dd-trace-java#8836) - [@amarziali](https://github.com/amarziali)) #### Dynamic Instrumentation - ✨ Optimized allocations for collection filter functions ([#8896](DataDog/dd-trace-java#8896) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix SymDB upload size check ([#8887](DataDog/dd-trace-java#8887) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Add support for Set in filter function ([#8873](DataDog/dd-trace-java#8873) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Add support for isDefined in log template ([#8859](DataDog/dd-trace-java#8859) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix Max captured frames for Exception Replay ([#8856](DataDog/dd-trace-java#8856) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Remove static inherited fields collection ([#8832](DataDog/dd-trace-java#8832) - [@jpbempel](https://github.com/jpbempel)) - 💡 Add process tags to dynamic instrumentation intake payload ([#8779](DataDog/dd-trace-java#8779) - [@amarziali](https://github.com/amarziali)) #### GraalVM native-image - ✨ Add support for GraalVM Native GC metrics ([#8913](DataDog/dd-trace-java#8913) - [@ygree](https://github.com/ygree)) - ✨ Add JMXFetch support for GraalVM Native ([#8569](DataDog/dd-trace-java#8569) - [@ygree](https://github.com/ygree)) #### JMX fetch - ✨ Add support for GraalVM Native GC metrics ([#8913](DataDog/dd-trace-java#8913) - [@ygree](https://github.com/ygree)) #### Library Injection - ✨ Deny oracle db jvm based tools ([#8909](DataDog/dd-trace-java#8909) - [@bric3](https://github.com/bric3)) #### OpenTracing - 🐛 Fix OT packaging for exception replay ([#8912](DataDog/dd-trace-java#8912) - [@jpbempel](https://github.com/jpbempel)) #### Profiling - ✨ Bump ddprof to 1.27.0 ([#8893](DataDog/dd-trace-java#8893) - [@jbachorik](https://github.com/jbachorik)) - Properly handle the adaptive sampling interval overflow by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#213 - Fix [#200](DataDog/dd-trace-java#200) Crash related to aligned\_alloc and free in context by [@yanglong1010](https://github.com/yanglong1010) in DataDog/java-profiler#208 - Explicitly initialize empty context page by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#210 - Re-connect crash recursion protection with VM stackwalker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#214 - ✨ Enable ZSTD compression for profiling ([#8862](DataDog/dd-trace-java#8862) - [@MattAlp](https://github.com/MattAlp)) - ✨ Extend JPS re-implementation to J9 family ([#8813](DataDog/dd-trace-java#8813) - [@MattAlp](https://github.com/MattAlp)) - 💡 Collect process tags for profiling upload requests ([#8780](DataDog/dd-trace-java#8780) - [@amarziali](https://github.com/amarziali)) #### Telemetry - 💡 Surface process tags on telemetry payloads ([#8837](DataDog/dd-trace-java#8837) - [@amarziali](https://github.com/amarziali)) #### Trace context propagation - ✨ Migrating all HttpClient Instrumentations to Inject Full Context ([#8826](DataDog/dd-trace-java#8826) - [@mhlidd](https://github.com/mhlidd)) - ✨ Migrating all HttpServer Instrumentations to Extract full Context ([#8820](DataDog/dd-trace-java#8820) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add context API support OTel propagators ([#8770](DataDog/dd-trace-java#8770) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - ✨⚡ Skip JAXB generated classes classloader ([#9003](DataDog/dd-trace-java#9003) - [@bric3](https://github.com/bric3)) - ✨ Add DD\_RUNTIME\_METRICS\_RUNTIME\_ID\_ENABLED alias for runtime id generation ([#8981](DataDog/dd-trace-java#8981) - [@amarziali](https://github.com/amarziali)) - 🐛 Use resolved address for peer.hostname when available without hitting the cache ([#8915](DataDog/dd-trace-java#8915) - [@amarziali](https://github.com/amarziali)) - 💡 Surface server name process tag for tomcat ([#8894](DataDog/dd-trace-java#8894) - [@amarziali](https://github.com/amarziali)) - 💡 Surface websphere cell and server name on process tags ([#8880](DataDog/dd-trace-java#8880) - [@amarziali](https://github.com/amarziali)) - ✨ Added special lightweight pre-main class that skips installation on incompatible JVMs. ([#8855](DataDog/dd-trace-java#8855) - [@AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Add entrypoint type to process tags ([#8839](DataDog/dd-trace-java#8839) - [@amarziali](https://github.com/amarziali)) - ✨ Extend JPS re-implementation to J9 family ([#8813](DataDog/dd-trace-java#8813) - [@MattAlp](https://github.com/MattAlp)) - ✨ Notify listeners when the scope top changes after switching scope stacks ([#8797](DataDog/dd-trace-java#8797) - [@mcculls](https://github.com/mcculls)) - ✨ Read hsperfdata for Java PIDs if jvmstat is unavailable ([#8792](DataDog/dd-trace-java#8792) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Turn JDK socket support on by default ([#8752](DataDog/dd-trace-java#8752) - [@sarahchen6](https://github.com/sarahchen6)) - ✨ Simplify context propagation ([#8719](DataDog/dd-trace-java#8719) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Add JSON parsing support ([#8579](DataDog/dd-trace-java#8579) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer internal logging - ✨ Fix printing format of span identifiers ([#8897](DataDog/dd-trace-java#8897) - [@vandonr](https://github.com/vandonr)) #### Tracer public API - 💡 Track the source of installation ([#8956](DataDog/dd-trace-java#8956) - [@mabdinur](https://github.com/mabdinur)) - ✨ Enforce size limit on application\_monitoring.yaml files ([#8789](DataDog/dd-trace-java#8789) - [@mtoffl01](https://github.com/mtoffl01)) - ✨ Enabling baggage cache to support limits and non-ascii characters ([#8713](DataDog/dd-trace-java#8713) - [@mhlidd](https://github.com/mhlidd)) ### Instrumentations #### AWS Lambda instrumentation - ✨ Pass Lambda Request ID to Extension ([#8814](DataDog/dd-trace-java#8814) - [@nhulston](https://github.com/nhulston)) #### Core Java language instrumentation - ✨ Ensure ClassloadingInstrumentation is always applied even with `DD_TRACE_ENABLED=false` ([#8863](DataDog/dd-trace-java#8863) - [@mcculls](https://github.com/mcculls)) #### Eclipse Vert.x instrumentation - 🐛 Do not override route with / in vertx instrumentation ([#8881](DataDog/dd-trace-java#8881) - [@vandonr](https://github.com/vandonr)) #### IBM Liberty - 🐛 Fix error mark on http status for IBM liberty ([#8822](DataDog/dd-trace-java#8822) - [@amarziali](https://github.com/amarziali)) #### JDBC instrumentation - 🐛 Do not prepend DBM <> APM trace comment in SQLCommenter if there is a pg plan hint ([#8864](DataDog/dd-trace-java#8864) - [@edengorevoy](https://github.com/edengorevoy)) #### JMS instrumentation - ✨ Add jms as an extra integration name where there is JMS involved ([#8933](DataDog/dd-trace-java#8933) - [@vandonr](https://github.com/vandonr)) #### Kotlin instrumentation - ✨ Enable kotlin\_coroutine integration by default ([#8848](DataDog/dd-trace-java#8848) - [@mcculls](https://github.com/mcculls)) - 🧹 Rework Kotlin coroutines instrumentation around coroutine context ([#8774](DataDog/dd-trace-java#8774) - [@mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Support WithSpan inheritContext attribute ([#8858](DataDog/dd-trace-java#8858) - [@amarziali](https://github.com/amarziali)) - ✨ Add context API support OTel propagators ([#8770](DataDog/dd-trace-java#8770) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Play Framework instrumentation - 🐛 Fix the Play Framework's span resource name priority so that the client JAX-RS 404 cannot override it ([#8591](DataDog/dd-trace-java#8591) - [@ygree](https://github.com/ygree)) #### Quarkus Instrumentation - 🐛 Ignore quarkus jaxrs stubs and cdi wrapper proxies ([#8891](DataDog/dd-trace-java#8891) - [@amarziali](https://github.com/amarziali)) #### ServiceTalk - ✨ Improve ServiceTalk Captured Context API Instrumentation for v0.42.56+ ([#8821](DataDog/dd-trace-java#8821) - [@ygree](https://github.com/ygree)) #### Spring instrumentation - ✨ Supporting Baggage for Instrumentations used in Weblog Tests ([#8773](DataDog/dd-trace-java#8773) - [@mhlidd](https://github.com/mhlidd)) #### WebSocket Instrumentation - 💡 Trace websocket for spring webflux reactive handlers ([#8831](DataDog/dd-trace-java#8831) - [@amarziali](https://github.com/amarziali)) - 💡:test\_tube: WebSocket support for Netty ([#8632](DataDog/dd-trace-java#8632) - [@ValentinZakharov](https://github.com/ValentinZakharov)) #### Zio Instrumentation - 🧹 Cleanup Zio fiber instrumentation to avoid repeated activation of continuation ([#8798](DataDog/dd-trace-java#8798) - [@mcculls](https://github.com/mcculls)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 9207366cdb6a1bd098082305d354a0a3c4622d7a

daniel-mohedano added 2 commits May 8, 2025 16:04

normalize repo path before building git info
26b8dda

unit test and usage of Paths to avoid issues with root directory
4522409

daniel-mohedano requested a review from nikita-tkachenko-datadog May 8, 2025 15:07

daniel-mohedano added type: bug fix Bug fix comp: ci visibility Continuous Integration Visibility labels May 8, 2025

spotless
6060bb4

nikita-tkachenko-datadog approved these changes May 8, 2025
View reviewed changes

nikita-tkachenko-datadog self-requested a review May 8, 2025 15:39

daniel-mohedano added 3 commits May 9, 2025 11:03

sanitize ciworkspace instead of using Path
9cc396e

fix spotless
53f52c0

add unit tests and take into account root path
de21bd1

nikita-tkachenko-datadog approved these changes May 9, 2025
View reviewed changes

daniel-mohedano changed the title ~~Fix git information caching to avoid unnecessary builds~~Always build ci workspace without trailing separatorMay 9, 2025

daniel-mohedano marked this pull request as ready for review May 9, 2025 12:56

daniel-mohedano requested review from a team as code owners May 9, 2025 12:56

daniel-mohedano requested review from anmarchenko and ygree May 9, 2025 12:56

daniel-mohedano merged commit 127660a into masterMay 9, 2025

daniel-mohedano deleted the daniel.mohedano/ci-workspace-path-normalization branch May 9, 2025 12:58

github-actionsBot added this to the 1.50.0 milestone May 9, 2025

Navigation Menu

Uh oh!

Always build ci workspace without trailing separator - #8788

Always build ci workspace without trailing separator#8788
daniel-mohedano merged 6 commits into
masterfrom
daniel.mohedano/ci-workspace-path-normalization

daniel-mohedano commented May 8, 2025•
edited
Loading

Uh oh!

pr-commenterBot commented May 8, 2025•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

daniel-mohedano commented May 8, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Contributor Checklist

Uh oh!

pr-commenterBot commented May 8, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

daniel-mohedano commented May 8, 2025•
edited
Loading

pr-commenterBot commented May 8, 2025•
edited
Loading