Stable Config improvements by mtoffl01 · Pull Request #9259 · DataDog/dd-trace-java

mtoffl01 · 2025-07-28T16:04:31Z

What Does This Do

Refactors matchOperator logic to use method reference comparator for efficiency
Introduces a new exception type StableConfigMappingException for better exception handling and debug logging when our custom YAML parsing fails on the StableConfig class
Adds a debug log message when apm_configuration_rules is set but none of the rules match the active process
Modifies constructors for StableConfig's Rule and Selector classes with a static factoring function from(Map<?, ?>) to enforce type safety at the API level

Motivation

For (1): Suggestion by @PerfectSlayer in previous PR #9201
For (2) & (3): A result of design partner troubleshooting sessions

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-07-28T16:38:13Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/scfg-improvements
git_commit_date	1755212609	1755264751
git_commit_sha	`65b2349`	`16d5f36`
release_version	1.53.0-SNAPSHOT~65b2349214	1.52.0-SNAPSHOT~16d5f36836

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755266777	1755266777
ci_job_id	1082175723	1082175723
ci_pipeline_id	73793242	73793242
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-mpah81nk 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-mpah81nk 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics.

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~16d5f36836, baseline=1.53.0-SNAPSHOT~65b2349214
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1044528
Total [baseline] (8.591 s) : 0, 8591427
Agent [candidate] (1.042 s) : 0, 1041818
Total [candidate] (8.568 s) : 0, 8568090
section iast
Agent [baseline] (1.177 s) : 0, 1176743
Total [baseline] (9.318 s) : 0, 9317815
Agent [candidate] (1.175 s) : 0, 1175315
Total [candidate] (9.308 s) : 0, 9308486

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.045 s	-
Agent	iast	1.177 s	132.214 ms (12.7%)
Total	tracing	8.591 s	-
Total	iast	9.318 s	726.388 ms (8.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.042 s	-
Agent	iast	1.175 s	133.497 ms (12.8%)
Total	tracing	8.568 s	-
Total	iast	9.308 s	740.396 ms (8.6%)

gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~16d5f36836, baseline=1.53.0-SNAPSHOT~65b2349214
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.422 ms) : 0, 1422
crashtracking [candidate] (1.427 ms) : 0, 1427
BytebuddyAgent [baseline] (730.962 ms) : 0, 730962
BytebuddyAgent [candidate] (729.466 ms) : 0, 729466
GlobalTracer [baseline] (241.78 ms) : 0, 241780
GlobalTracer [candidate] (241.92 ms) : 0, 241920
AppSec [baseline] (30.124 ms) : 0, 30124
AppSec [candidate] (30.04 ms) : 0, 30040
Debugger [baseline] (6.011 ms) : 0, 6011
Debugger [candidate] (6.05 ms) : 0, 6050
Remote Config [baseline] (652.874 µs) : 0, 653
Remote Config [candidate] (657.711 µs) : 0, 658
Telemetry [baseline] (12.586 ms) : 0, 12586
Telemetry [candidate] (11.325 ms) : 0, 11325
section iast
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.428 ms) : 0, 1428
BytebuddyAgent [baseline] (849.418 ms) : 0, 849418
BytebuddyAgent [candidate] (848.743 ms) : 0, 848743
GlobalTracer [baseline] (232.346 ms) : 0, 232346
GlobalTracer [candidate] (232.981 ms) : 0, 232981
AppSec [baseline] (25.972 ms) : 0, 25972
AppSec [candidate] (27.8 ms) : 0, 27800
Debugger [baseline] (8.478 ms) : 0, 8478
Debugger [candidate] (5.784 ms) : 0, 5784
Remote Config [baseline] (581.482 µs) : 0, 581
Remote Config [candidate] (589.455 µs) : 0, 589
Telemetry [baseline] (8.272 ms) : 0, 8272
Telemetry [candidate] (8.028 ms) : 0, 8028
IAST [baseline] (29.223 ms) : 0, 29223
IAST [candidate] (29.013 ms) : 0, 29013

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~16d5f36836, baseline=1.53.0-SNAPSHOT~65b2349214
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043627
Total [baseline] (10.637 s) : 0, 10637212
Agent [candidate] (1.051 s) : 0, 1051072
Total [candidate] (10.749 s) : 0, 10748718
section appsec
Agent [baseline] (1.222 s) : 0, 1221675
Total [baseline] (10.721 s) : 0, 10721273
Agent [candidate] (1.22 s) : 0, 1219993
Total [candidate] (10.786 s) : 0, 10785776
section iast
Agent [baseline] (1.197 s) : 0, 1196773
Total [baseline] (10.96 s) : 0, 10959574
Agent [candidate] (1.197 s) : 0, 1196723
Total [candidate] (11.061 s) : 0, 11061203
section profiling
Agent [baseline] (1.203 s) : 0, 1202842
Total [baseline] (10.968 s) : 0, 10968215
Agent [candidate] (1.194 s) : 0, 1194359
Total [candidate] (10.898 s) : 0, 10898283

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.044 s	-
Agent	appsec	1.222 s	178.048 ms (17.1%)
Agent	iast	1.197 s	153.146 ms (14.7%)
Agent	profiling	1.203 s	159.215 ms (15.3%)
Total	tracing	10.637 s	-
Total	appsec	10.721 s	84.06 ms (0.8%)
Total	iast	10.96 s	322.362 ms (3.0%)
Total	profiling	10.968 s	331.003 ms (3.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.051 s	-
Agent	appsec	1.22 s	168.921 ms (16.1%)
Agent	iast	1.197 s	145.651 ms (13.9%)
Agent	profiling	1.194 s	143.287 ms (13.6%)
Total	tracing	10.749 s	-
Total	appsec	10.786 s	37.058 ms (0.3%)
Total	iast	11.061 s	312.485 ms (2.9%)
Total	profiling	10.898 s	149.565 ms (1.4%)

gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~16d5f36836, baseline=1.53.0-SNAPSHOT~65b2349214
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.442 ms) : 0, 1442
crashtracking [candidate] (1.509 ms) : 0, 1509
BytebuddyAgent [baseline] (730.435 ms) : 0, 730435
BytebuddyAgent [candidate] (737.724 ms) : 0, 737724
GlobalTracer [baseline] (241.385 ms) : 0, 241385
GlobalTracer [candidate] (243.73 ms) : 0, 243730
AppSec [baseline] (30.013 ms) : 0, 30013
AppSec [candidate] (30.361 ms) : 0, 30361
Debugger [baseline] (6.011 ms) : 0, 6011
Debugger [candidate] (6.078 ms) : 0, 6078
Remote Config [baseline] (642.13 µs) : 0, 642
Remote Config [candidate] (660.538 µs) : 0, 661
Telemetry [baseline] (12.706 ms) : 0, 12706
Telemetry [candidate] (9.794 ms) : 0, 9794
section appsec
crashtracking [baseline] (1.44 ms) : 0, 1440
crashtracking [candidate] (1.434 ms) : 0, 1434
BytebuddyAgent [baseline] (754.182 ms) : 0, 754182
BytebuddyAgent [candidate] (753.311 ms) : 0, 753311
GlobalTracer [baseline] (235.301 ms) : 0, 235301
GlobalTracer [candidate] (234.685 ms) : 0, 234685
IAST [baseline] (23.455 ms) : 0, 23455
IAST [candidate] (23.502 ms) : 0, 23502
AppSec [baseline] (167.73 ms) : 0, 167730
AppSec [candidate] (168.436 ms) : 0, 168436
Debugger [baseline] (7.999 ms) : 0, 7999
Debugger [candidate] (8.744 ms) : 0, 8744
Remote Config [baseline] (631.882 µs) : 0, 632
Remote Config [candidate] (613.686 µs) : 0, 614
Telemetry [baseline] (9.894 ms) : 0, 9894
Telemetry [candidate] (8.226 ms) : 0, 8226
section iast
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (865.587 ms) : 0, 865587
BytebuddyAgent [candidate] (865.122 ms) : 0, 865122
GlobalTracer [baseline] (235.486 ms) : 0, 235486
GlobalTracer [candidate] (235.086 ms) : 0, 235086
IAST [baseline] (28.635 ms) : 0, 28635
IAST [candidate] (28.003 ms) : 0, 28003
AppSec [baseline] (28.676 ms) : 0, 28676
AppSec [candidate] (29.369 ms) : 0, 29369
Debugger [baseline] (6.566 ms) : 0, 6566
Debugger [candidate] (7.479 ms) : 0, 7479
Remote Config [baseline] (592.864 µs) : 0, 593
Remote Config [candidate] (602.542 µs) : 0, 603
Telemetry [baseline] (8.5 ms) : 0, 8500
Telemetry [candidate] (8.371 ms) : 0, 8371
section profiling
crashtracking [baseline] (1.417 ms) : 0, 1417
crashtracking [candidate] (1.41 ms) : 0, 1410
BytebuddyAgent [baseline] (766.303 ms) : 0, 766303
BytebuddyAgent [candidate] (761.072 ms) : 0, 761072
GlobalTracer [baseline] (223.187 ms) : 0, 223187
GlobalTracer [candidate] (221.773 ms) : 0, 221773
AppSec [baseline] (30.273 ms) : 0, 30273
AppSec [candidate] (29.915 ms) : 0, 29915
Debugger [baseline] (6.329 ms) : 0, 6329
Debugger [candidate] (6.266 ms) : 0, 6266
Remote Config [baseline] (685.963 µs) : 0, 686
Remote Config [candidate] (671.886 µs) : 0, 672
Telemetry [baseline] (15.279 ms) : 0, 15279
Telemetry [candidate] (15.935 ms) : 0, 15935
ProfilingAgent [baseline] (109.579 ms) : 0, 109579
ProfilingAgent [candidate] (107.819 ms) : 0, 107819
Profiling [baseline] (110.223 ms) : 0, 110223
Profiling [candidate] (108.463 ms) : 0, 108463

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/scfg-improvements
git_commit_date	1755212609	1755264751
git_commit_sha	`65b2349`	`16d5f36`
release_version	1.53.0-SNAPSHOT~65b2349214	1.52.0-SNAPSHOT~16d5f36836

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755266441	1755266441
ci_job_id	1082175724	1082175724
ci_pipeline_id	73793242	73793242
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-siscqlr0 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-siscqlr0 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load	worse [+380.048µs; +759.666µs] or [+3.829%; +7.653%]	unstable [-79.554op/s; +29.304op/s] or [-17.002%; +6.263%]	10.496ms	442.781op/s	9.926ms	467.906op/s

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~16d5f36836, baseline=1.53.0-SNAPSHOT~65b2349214
dateFormat X
axisFormat %s
section baseline
no_agent (37.02 ms) : 36721, 37319
. : milestone, 37020,
appsec (47.332 ms) : 46903, 47761
. : milestone, 47332,
code_origins (45.358 ms) : 44957, 45760
. : milestone, 45358,
iast (45.227 ms) : 44833, 45621
. : milestone, 45227,
profiling (48.142 ms) : 47712, 48571
. : milestone, 48142,
tracing (42.636 ms) : 42270, 43001
. : milestone, 42636,
section candidate
no_agent (37.377 ms) : 37075, 37678
. : milestone, 37377,
appsec (46.571 ms) : 46161, 46982
. : milestone, 46571,
code_origins (45.823 ms) : 45419, 46228
. : milestone, 45823,
iast (44.924 ms) : 44533, 45316
. : milestone, 44924,
profiling (47.884 ms) : 47457, 48311
. : milestone, 47884,
tracing (43.577 ms) : 43182, 43973
. : milestone, 43577,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.02 ms [36.721 ms, 37.319 ms]	-
appsec	47.332 ms [46.903 ms, 47.761 ms]	10.312 ms (27.9%)
code_origins	45.358 ms [44.957 ms, 45.76 ms]	8.339 ms (22.5%)
iast	45.227 ms [44.833 ms, 45.621 ms]	8.207 ms (22.2%)
profiling	48.142 ms [47.712 ms, 48.571 ms]	11.122 ms (30.0%)
tracing	42.636 ms [42.27 ms, 43.001 ms]	5.616 ms (15.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.377 ms [37.075 ms, 37.678 ms]	-
appsec	46.571 ms [46.161 ms, 46.982 ms]	9.195 ms (24.6%)
code_origins	45.823 ms [45.419 ms, 46.228 ms]	8.447 ms (22.6%)
iast	44.924 ms [44.533 ms, 45.316 ms]	7.548 ms (20.2%)
profiling	47.884 ms [47.457 ms, 48.311 ms]	10.507 ms (28.1%)
tracing	43.577 ms [43.182 ms, 43.973 ms]	6.201 ms (16.6%)

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~16d5f36836, baseline=1.53.0-SNAPSHOT~65b2349214
dateFormat X
axisFormat %s
section baseline
no_agent (4.386 ms) : 4335, 4437
. : milestone, 4386,
iast (9.168 ms) : 9020, 9316
. : milestone, 9168,
iast_FULL (14.311 ms) : 14025, 14598
. : milestone, 14311,
iast_GLOBAL (9.926 ms) : 9755, 10096
. : milestone, 9926,
profiling (8.844 ms) : 8712, 8977
. : milestone, 8844,
tracing (7.777 ms) : 7659, 7896
. : milestone, 7777,
section candidate
no_agent (4.366 ms) : 4315, 4417
. : milestone, 4366,
iast (9.448 ms) : 9287, 9610
. : milestone, 9448,
iast_FULL (14.802 ms) : 14506, 15098
. : milestone, 14802,
iast_GLOBAL (10.496 ms) : 10314, 10678
. : milestone, 10496,
profiling (8.718 ms) : 8577, 8859
. : milestone, 8718,
tracing (7.643 ms) : 7536, 7749
. : milestone, 7643,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.386 ms [4.335 ms, 4.437 ms]	-
iast	9.168 ms [9.02 ms, 9.316 ms]	4.782 ms (109.0%)
iast_FULL	14.311 ms [14.025 ms, 14.598 ms]	9.926 ms (226.3%)
iast_GLOBAL	9.926 ms [9.755 ms, 10.096 ms]	5.54 ms (126.3%)
profiling	8.844 ms [8.712 ms, 8.977 ms]	4.458 ms (101.7%)
tracing	7.777 ms [7.659 ms, 7.896 ms]	3.391 ms (77.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.366 ms [4.315 ms, 4.417 ms]	-
iast	9.448 ms [9.287 ms, 9.61 ms]	5.082 ms (116.4%)
iast_FULL	14.802 ms [14.506 ms, 15.098 ms]	10.436 ms (239.0%)
iast_GLOBAL	10.496 ms [10.314 ms, 10.678 ms]	6.13 ms (140.4%)
profiling	8.718 ms [8.577 ms, 8.859 ms]	4.352 ms (99.7%)
tracing	7.643 ms [7.536 ms, 7.749 ms]	3.277 ms (75.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/scfg-improvements
git_commit_date	1755212609	1755264751
git_commit_sha	`65b2349`	`16d5f36`
release_version	1.53.0-SNAPSHOT~65b2349214	1.52.0-SNAPSHOT~16d5f36836

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1755266981	1755266981
ci_job_id	1082175725	1082175725
ci_pipeline_id	73793242	73793242
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-3-s5dxmlad 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-3-s5dxmlad 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~16d5f36836, baseline=1.53.0-SNAPSHOT~65b2349214
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.646 ms) : 3427, 3864
. : milestone, 3646,
iast (2.213 ms) : 2151, 2276
. : milestone, 2213,
iast_GLOBAL (2.251 ms) : 2187, 2314
. : milestone, 2251,
profiling (2.073 ms) : 2020, 2125
. : milestone, 2073,
tracing (2.019 ms) : 1970, 2067
. : milestone, 2019,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.59 ms) : 3378, 3803
. : milestone, 3590,
iast (2.206 ms) : 2144, 2269
. : milestone, 2206,
iast_GLOBAL (2.233 ms) : 2170, 2295
. : milestone, 2233,
profiling (2.059 ms) : 2007, 2111
. : milestone, 2059,
tracing (2.017 ms) : 1969, 2065
. : milestone, 2017,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.477 ms [1.466 ms, 1.489 ms]	-
appsec	3.646 ms [3.427 ms, 3.864 ms]	2.168 ms (146.8%)
iast	2.213 ms [2.151 ms, 2.276 ms]	736.009 µs (49.8%)
iast_GLOBAL	2.251 ms [2.187 ms, 2.314 ms]	773.429 µs (52.4%)
profiling	2.073 ms [2.02 ms, 2.125 ms]	595.244 µs (40.3%)
tracing	2.019 ms [1.97 ms, 2.067 ms]	541.376 µs (36.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.463 ms, 1.486 ms]	-
appsec	3.59 ms [3.378 ms, 3.803 ms]	2.116 ms (143.6%)
iast	2.206 ms [2.144 ms, 2.269 ms]	732.286 µs (49.7%)
iast_GLOBAL	2.233 ms [2.17 ms, 2.295 ms]	758.382 µs (51.4%)
profiling	2.059 ms [2.007 ms, 2.111 ms]	584.526 µs (39.7%)
tracing	2.017 ms [1.969 ms, 2.065 ms]	542.841 µs (36.8%)

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~16d5f36836, baseline=1.53.0-SNAPSHOT~65b2349214
dateFormat X
axisFormat %s
section baseline
no_agent (14.834 s) : 14834000, 14834000
. : milestone, 14834000,
appsec (14.877 s) : 14877000, 14877000
. : milestone, 14877000,
iast (18.314 s) : 18314000, 18314000
. : milestone, 18314000,
iast_GLOBAL (18.021 s) : 18021000, 18021000
. : milestone, 18021000,
profiling (15.674 s) : 15674000, 15674000
. : milestone, 15674000,
tracing (14.871 s) : 14871000, 14871000
. : milestone, 14871000,
section candidate
no_agent (15.608 s) : 15608000, 15608000
. : milestone, 15608000,
appsec (14.78 s) : 14780000, 14780000
. : milestone, 14780000,
iast (18.089 s) : 18089000, 18089000
. : milestone, 18089000,
iast_GLOBAL (17.985 s) : 17985000, 17985000
. : milestone, 17985000,
profiling (15.345 s) : 15345000, 15345000
. : milestone, 15345000,
tracing (14.922 s) : 14922000, 14922000
. : milestone, 14922000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.834 s [14.834 s, 14.834 s]	-
appsec	14.877 s [14.877 s, 14.877 s]	43.0 ms (0.3%)
iast	18.314 s [18.314 s, 18.314 s]	3.48 s (23.5%)
iast_GLOBAL	18.021 s [18.021 s, 18.021 s]	3.187 s (21.5%)
profiling	15.674 s [15.674 s, 15.674 s]	840.0 ms (5.7%)
tracing	14.871 s [14.871 s, 14.871 s]	37.0 ms (0.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.608 s [15.608 s, 15.608 s]	-
appsec	14.78 s [14.78 s, 14.78 s]	-828.0 ms (-5.3%)
iast	18.089 s [18.089 s, 18.089 s]	2.481 s (15.9%)
iast_GLOBAL	17.985 s [17.985 s, 17.985 s]	2.377 s (15.2%)
profiling	15.345 s [15.345 s, 15.345 s]	-263.0 ms (-1.7%)
tracing	14.922 s [14.922 s, 14.922 s]	-686.0 ms (-4.4%)

…g parsing errors

mtoffl01 · 2025-07-28T20:41:55Z

@@ -26,12 +26,34 @@ public Rule(List<Selector> selectors, Map<String, Object> configuration) {
 }

 public Rule(Object yaml) {


Let me know if this constructor is too hard to read and if you recommend I move the "require fields" logic into helper functions (in a utils class to be used by both Rule and Selector?)

Overall, I would rather try to bring type safety to the Java API as soon as possible even if SnakeYaml is returning loose Object.
An idiomatic Java would be to have a static builder like static Rule from(Map<?, ?> rules) and check that its parameters is the right time before calling it.
-- Note that a better type for rules would be Map<String, ?> but there is no way to enforce / test it due to type erasure in Java.
So far example, I would check the type ahead in StableConfig before trying to create rule using its fromMap:
this.apmConfigurationRules = parseRules(yaml); // with some helper methods in StableConfigprivateList<Rule> parseRules(Map<?, ?> yaml) { ObjectapmConfigurationDefaultObject = map.get("apm_configuration_default"); if (apmConfigurationDefaultObjectinstanceofList) { return ((List<?>) apmConfigurationDefaultObject).stream() .filter(r -> rinstanceofMap) .map(r -> (Map<?, ?>) r) .map(Rule::fromMap) .collect(toList()); } else { returnemptyList(); } }

PerfectSlayer · 2025-07-29T15:12:32Z

@@ -26,12 +26,34 @@ public Rule(List<Selector> selectors, Map<String, Object> configuration) {
 }

 public Rule(Object yaml) {


Overall, I would rather try to bring type safety to the Java API as soon as possible even if SnakeYaml is returning loose Object.
An idiomatic Java would be to have a static builder like static Rule from(Map<?, ?> rules) and check that its parameters is the right time before calling it.
-- Note that a better type for rules would be Map<String, ?> but there is no way to enforce / test it due to type erasure in Java.
So far example, I would check the type ahead in StableConfig before trying to create rule using its fromMap:
this.apmConfigurationRules = parseRules(yaml); // with some helper methods in StableConfigprivateList<Rule> parseRules(Map<?, ?> yaml) { ObjectapmConfigurationDefaultObject = map.get("apm_configuration_default"); if (apmConfigurationDefaultObjectinstanceofList) { return ((List<?>) apmConfigurationDefaultObject).stream() .filter(r -> rinstanceofMap) .map(r -> (Map<?, ?>) r) .map(Rule::fromMap) .collect(toList()); } else { returnemptyList(); } }

PerfectSlayer · 2025-07-29T15:30:35Z

- return value.contains(match);
- default:
- return false;
+ if (comparator.test(match)) {


…le and Selector classes

datadog-datadog-prod-us1 · 2025-07-31T17:07:49Z

Code coverage: total 57.12%, base diff 0.03%, patch 88.76% (view details)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 16d5f36 | Docs | Was this helpful? Give us feedback!}

…ilure

github-actions · 2025-08-04T16:37:37Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

PerfectSlayer

Looking good 👍
One question about testing logging though

PerfectSlayer

Thanks for the follow up PR and the improvements 👍

…ider/stableconfig/Rule.java Co-authored-by: Alexey Kuznetsov <alexey.kuznetsov@datadoghq.com>

AlexeyKuznetsov-DD · 2025-08-12T18:35:02Z

+ } else if (log.isDebugEnabled()) {
+ log.error("Unexpected error while reading stable configuration file {}: {}", filePath, e);
+ } else {


Not sure I understand this if (log.isDebugEnabled())...
To me it looks like we can log that error always, because all major cases were processed in previous if block.
Also, I feel that here we have a very tricky case: you have 2 placeholders {}, but the second argument e is actually an exception and it will be treaded in a special way. So you should use only one place holder, or provide as second argument something else, for example e.getMessage().

As for the log.isDebugEnabled() check: this was something @mcculls suggested; we want to print the complete exception if and only if debug is enabled, else just print the exception message. An alternative is to only print the message regardless, I suppose. WDYT?
As for the placeholder: I was not aware, thanks for sharing. 🤔 I will change this accordingly, based on what we decide on the above.

got it! make sense in debug to print stack trace
but code should be with one place holder:
log.error("Unexpected error while reading stable configuration file: {}", filePath, e);

…ider/stableconfig/Rule.java Co-authored-by: Alexey Kuznetsov <alexey.kuznetsov@datadoghq.com>

…invocations

…-java into mtoff/scfg-improvements

AlexeyKuznetsov-DD · 2025-08-12T20:40:13Z

+ } else if (log.isDebugEnabled()) {
+ log.error("Unexpected error while reading stable configuration file {}: {}", filePath, e);
+ } else {


got it! make sense in debug to print stack trace
but code should be with one place holder:
log.error("Unexpected error while reading stable configuration file: {}", filePath, e);

…ider/StableConfigSource.java Co-authored-by: Alexey Kuznetsov <alexey.kuznetsov@datadoghq.com>

…t manipulation

…-java into mtoff/scfg-improvements

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.52.1` -> `1.53.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.53.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.53.0): 1.53.0 ### Components #### Application Security Management (WAF) - 🐛 Fix NullPointerException log in AppSec ([#9355](DataDog/dd-trace-java#9355) - [@jandro996](https://github.com/jandro996)) - ✨ Add Forwarded header as a source to client IP resolution ([#9310](DataDog/dd-trace-java#9310) - [@jandro996](https://github.com/jandro996)) #### Build & Tooling - 📖 Update CODEOWNERS ([#9294](DataDog/dd-trace-java#9294) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add dependency on Maven Central deployment to OCI publish jobs ([#9204](DataDog/dd-trace-java#9204) - [@sarahchen6](https://github.com/sarahchen6)) #### Continuous Integration Visibility - ✨ Upload code coverage reports to Datadog ([#9425](DataDog/dd-trace-java#9425) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Do not follow symlinks by default when building repository index ([#9318](DataDog/dd-trace-java#9318) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Improve tag propagation between test event levels ([#9278](DataDog/dd-trace-java#9278) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - ✨ Create container hash tags propagation ([#9282](DataDog/dd-trace-java#9282) - [@ygree](https://github.com/ygree)) #### Database Monitoring - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#9321](DataDog/dd-trace-java#9321) - [@na-ji](https://github.com/na-ji)) - ✨ Create container hash tags propagation ([#9282](DataDog/dd-trace-java#9282) - [@ygree](https://github.com/ygree)) #### GraalVM native-image - 🐛 Update GraalVM config to reflect TempLocationManager's new package ([#9337](DataDog/dd-trace-java#9337) - [@luneo7](https://github.com/luneo7) - thanks for the contribution!) #### Metrics - 🐛 Add reflect config for CSS and graalvm ([#9449](DataDog/dd-trace-java#9449) - [@amarziali](https://github.com/amarziali)) - ✨ Align CSS health metrics ([#9444](DataDog/dd-trace-java#9444) - [@amarziali](https://github.com/amarziali)) - ✨ Aggregate peer tags for consumer span kind ([#9442](DataDog/dd-trace-java#9442) - [@amarziali](https://github.com/amarziali)) - ✨ Implement health metrics for client stats ([#9377](DataDog/dd-trace-java#9377) - [@amarziali](https://github.com/amarziali)) - ✨ Add peer tags, span kind and trace root flag to MetricKey bucket ([#9178](DataDog/dd-trace-java#9178) - [@bric3](https://github.com/bric3)) #### Profiling - ✨ Create a profile flare reporter (requires tracing or CI vis to be enabled) ([#9433](DataDog/dd-trace-java#9433) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Properly fall-back on UDS profiling URL ([#9401](DataDog/dd-trace-java#9401) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Properly handle trace agent IPv6 URL in profiling ([#9334](DataDog/dd-trace-java#9334) - [@jbachorik](https://github.com/jbachorik)) #### Realtime User Monitoring - 🐛 Avoid multiple injections on dispatch on jboss ([#9392](DataDog/dd-trace-java#9392) - [@amarziali](https://github.com/amarziali)) - ✨ Support async servlet for RUM injection ([#9333](DataDog/dd-trace-java#9333) - [@amarziali](https://github.com/amarziali)) - 🐛 Improve RUM injection matching and avoid truncating responses ([#9323](DataDog/dd-trace-java#9323) - [@amarziali](https://github.com/amarziali)) - 💡 Add telemetry for the RUM injector ([#9267](DataDog/dd-trace-java#9267) - [@sarahchen6](https://github.com/sarahchen6)) - ✨ Make rum injector stream/writer more resilient to errors ([#9184](DataDog/dd-trace-java#9184) - [@amarziali](https://github.com/amarziali)) #### Telemetry - 🐛 Remediate error logs ([#9459](DataDog/dd-trace-java#9459) - [@ygree](https://github.com/ygree)) - ✨ Report config\_id for Hands Off Config files ([#9299](DataDog/dd-trace-java#9299) - [@mtoffl01](https://github.com/mtoffl01)) - ✨ Adding Config Inversion Telemetry component ([#9244](DataDog/dd-trace-java#9244) - [@mhlidd](https://github.com/mhlidd)) #### Trace context propagation - 🧹 Migrate instrumentations to Context API ([#9384](DataDog/dd-trace-java#9384), [#9378](DataDog/dd-trace-java#9378), [#9358](DataDog/dd-trace-java#9358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🔍 Add baggage propagation telemetry ([#9289](DataDog/dd-trace-java#9289) - [@rachelyangdog](https://github.com/rachelyangdog)) - 🧹 Improve Instrumenter API to use Context instead of Span ([#9211](DataDog/dd-trace-java#9211) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - 💡:test\_tube: Enable process level tags for java 21 applications ([#9458](DataDog/dd-trace-java#9458) - [@amarziali](https://github.com/amarziali)) - ✨ Move base and peer service adder before span is published ([#9408](DataDog/dd-trace-java#9408) - [@amarziali](https://github.com/amarziali)) - ✨ Add ErrorPriorities level for manual instrumentation ([#9387](DataDog/dd-trace-java#9387) - [@cecile75](https://github.com/cecile75)) - ✨ Throw InvalidBooleanValueException in ConfigConverter.booleanValueOf ([#9370](DataDog/dd-trace-java#9370) - [@mtoffl01](https://github.com/mtoffl01)) - 🐛 Avoid NPE on featureDiscovery creation ([#9353](DataDog/dd-trace-java#9353) - [@amarziali](https://github.com/amarziali)) - ✨ Stable Config improvements ([#9259](DataDog/dd-trace-java#9259) - [@mtoffl01](https://github.com/mtoffl01)) ### Instrumentations #### gRPC instrumentation - 🐛 Changing GRPC instrumentation codes from `status.code` to `grpc.status.code` ([#9367](DataDog/dd-trace-java#9367) - [@mhlidd](https://github.com/mhlidd)) #### JDBC instrumentation - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#9321](DataDog/dd-trace-java#9321) - [@na-ji](https://github.com/na-ji)) #### Kotlin instrumentation - 🐛 Take defensive copy of original scope stack when restoring on different thread ([#9403](DataDog/dd-trace-java#9403) - [@mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Fix using SpanAttribute annotation on multiple parameters ([#9412](DataDog/dd-trace-java#9412) - [@cecile75](https://github.com/cecile75)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: e23ec866cef91afc6b5226d5f0dc7da538d947e8

Refactor matchOperator to use method reference comparator for efficiency
370e894

Implement better exception handling and debug logging for StableConfi…
df4da2f
…g parsing errors

mtoffl01 commented Jul 28, 2025
View reviewed changes

Comment threadinternal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Selector.java Outdated

Add a debug log about no rules getting applied
7049d36

PerfectSlayer reviewed Jul 29, 2025
View reviewed changes

mtoffl01 added 2 commits July 29, 2025 11:37

Improve test file logic and cleanup in StableConfigSourceTest class
e730cbe

Github suggestions: Use static factory methods as constructors for Ru…
5b639aa
…le and Selector classes

mtoffl01 added 2 commits August 1, 2025 10:03

Improve exception message: include value of object that caused the fa…
85d11cf
…ilure

Add more test cases to StableConfigSourceTest to improve codecov
6ab4b6c

mtoffl01 commented Aug 1, 2025
View reviewed changes

Comment thread.../java/datadog/trace/bootstrap/config/provider/stableconfig/StableConfigMappingException.java Outdated

mtoffl01 commented Aug 1, 2025
View reviewed changes

Comment threadinternal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Rule.java Outdated

mtoffl01and others added 2 commits August 1, 2025 16:28

Add test coverage for StableConfigMappingException
007f58a

Merge branch 'master' into mtoff/scfg-improvements
ac69f2d

mtoffl01 marked this pull request as ready for review August 4, 2025 16:37

mtoffl01 requested a review from a team as a code owner August 4, 2025 16:37

mtoffl01 requested a review from PerfectSlayer August 4, 2025 16:37

PerfectSlayer reviewed Aug 5, 2025
View reviewed changes

Comment threadinternal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigSource.java Outdated
Comment thread...al-api/src/test/groovy/datadog/trace/bootstrap/config/provider/StableConfigSourceTest.groovy

PerfectSlayer approved these changes Aug 6, 2025
View reviewed changes

AlexeyKuznetsov-DD requested changes Aug 6, 2025
View reviewed changes

Update internal-api/src/main/java/datadog/trace/bootstrap/config/prov…
473c59b
…ider/stableconfig/Rule.java Co-authored-by: Alexey Kuznetsov <alexey.kuznetsov@datadoghq.com>

mtoffl01 requested a review from a team as a code owner August 8, 2025 15:55

mtoffl01and others added 2 commits August 8, 2025 11:55

Update internal-api/src/main/java/datadog/trace/bootstrap/config/prov…
feb1ba0
…ider/stableconfig/Rule.java Co-authored-by: Alexey Kuznetsov <alexey.kuznetsov@datadoghq.com>

Use safeToString when printing stableconfig map
f93546a

mtoffl01 commented Aug 8, 2025
View reviewed changes

Comment threadinternal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Rule.java Outdated

mtoffl01 added 2 commits August 8, 2025 13:40

rearrange logic in selectors creation for better readability
780aee3

delete superfluous else
ac5e05a

refactor exception catching in StableConfigSource
957d9c9

AlexeyKuznetsov-DD requested changes Aug 11, 2025
View reviewed changes

mtoffl01 added 5 commits August 11, 2025 15:43

restore semicolon in calls to throwStableConfigMappingException
b9870bd

Use static import for throwStableConfigMappingException
5019584

test other kinds of exceptions in StableConfigSource
e8d6e8f

remove duplicate cfg assignments
1fefb17

fix missing operator test case
058cbda

mtoffl01 requested a review from AlexeyKuznetsov-DD August 12, 2025 15:20

mtoffl01 added the type: feature Enhancements and improvements label Aug 12, 2025

AlexeyKuznetsov-DD requested changes Aug 12, 2025
View reviewed changes

mtoffl01and others added 3 commits August 12, 2025 14:59

Update internal-api/src/main/java/datadog/trace/bootstrap/config/prov…
5460c8a
…ider/stableconfig/Rule.java Co-authored-by: Alexey Kuznetsov <alexey.kuznetsov@datadoghq.com>

Improve readability of StableConfigMappingException and its function …
37da711
…invocations

modify safeToString logic to print first 50 and last 50 chars
5dac7f8

mtoffl01 added comp: core Tracer core comp: logging Tracer internal logging labels Aug 12, 2025

Merge branch 'mtoff/scfg-improvements' of github.com:DataDog/dd-trace…
5104ac5
…-java into mtoff/scfg-improvements

mtoffl01 requested a review from AlexeyKuznetsov-DD August 12, 2025 20:16

AlexeyKuznetsov-DD requested changes Aug 12, 2025
View reviewed changes

remove extra placeholder in string message when printing exception
13bef8d

AlexeyKuznetsov-DD requested changes Aug 12, 2025
View reviewed changes

Comment threadinternal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigSource.java

mtoffl01and others added 3 commits August 12, 2025 16:58

Update internal-api/src/main/java/datadog/trace/bootstrap/config/prov…
2706bca
…ider/StableConfigSource.java Co-authored-by: Alexey Kuznetsov <alexey.kuznetsov@datadoghq.com>

refactor Rules.from to perform type assertions before heavyweight lis…
4dde216
…t manipulation

Merge branch 'mtoff/scfg-improvements' of github.com:DataDog/dd-trace…
bfd5d7b
…-java into mtoff/scfg-improvements

AlexeyKuznetsov-DD approved these changes Aug 14, 2025
View reviewed changes

run spotless
16d5f36

mtoffl01 merged commit 1d77102 into masterAug 15, 2025
501 checks passed

mtoffl01 deleted the mtoff/scfg-improvements branch August 15, 2025 15:24

github-actionsBot added this to the 1.53.0 milestone Aug 15, 2025

		@@ -26,12 +26,34 @@ public Rule(List<Selector> selectors, Map<String, Object> configuration) {
		}

		public Rule(Object yaml) {

Uh oh!

Conversation

mtoffl01 commented Jul 28, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenterBot commented Jul 28, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-prod-us1Bot commented Jul 31, 2025• edited by datadog-official BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented Aug 4, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mtoffl01 commented Jul 28, 2025•
edited
Loading

pr-commenterBot commented Jul 28, 2025•
edited
Loading

datadog-datadog-prod-us1Bot commented Jul 31, 2025•
edited by datadog-official Bot
Loading

github-actionsBot commented Aug 4, 2025•
edited
Loading