Take defensive copy of original scope stack when restoring on different thread by mcculls · Pull Request #9403 · DataDog/dd-trace-java

mcculls · 2025-08-21T11:52:09Z

What Does This Do

When restoring a swapped out scope-stack, take defensive copy if the current thread is not the original.

Motivation

This mitigates a potential issue if the swapped out scope-stack is ever restored more than once on different threads.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

datadog-datadog-prod-us1 · 2025-08-21T12:09:54Z

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 59.20% (+1.64%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: d8b3327 | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-08-21T12:20:43Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/maybe-copy-scope-stack-when-restoring
git_commit_date	1755780320	1755780191
git_commit_sha	`9aad755`	`d8b3327`
release_version	1.53.0-SNAPSHOT~9aad75597f	1.53.0-SNAPSHOT~d8b332790d

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755782118	1755782118
ci_job_id	1091828890	1091828890
ci_pipeline_id	74359755	74359755
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-vfx8t5qg 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-vfx8t5qg 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 15 unstable metrics.

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~d8b332790d, baseline=1.53.0-SNAPSHOT~9aad75597f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050245
Total [baseline] (8.622 s) : 0, 8622382
Agent [candidate] (1.045 s) : 0, 1044979
Total [candidate] (8.614 s) : 0, 8613635
section iast
Agent [baseline] (1.19 s) : 0, 1190031
Total [baseline] (9.323 s) : 0, 9323258
Agent [candidate] (1.187 s) : 0, 1187054
Total [candidate] (9.37 s) : 0, 9370137

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	iast	1.19 s	139.786 ms (13.3%)
Total	tracing	8.622 s	-
Total	iast	9.323 s	700.876 ms (8.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.045 s	-
Agent	iast	1.187 s	142.075 ms (13.6%)
Total	tracing	8.614 s	-
Total	iast	9.37 s	756.502 ms (8.8%)

gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~d8b332790d, baseline=1.53.0-SNAPSHOT~9aad75597f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (734.403 ms) : 0, 734403
BytebuddyAgent [candidate] (730.705 ms) : 0, 730705
GlobalTracer [baseline] (243.617 ms) : 0, 243617
GlobalTracer [candidate] (242.113 ms) : 0, 242113
AppSec [baseline] (30.543 ms) : 0, 30543
AppSec [candidate] (30.117 ms) : 0, 30117
Debugger [baseline] (6.118 ms) : 0, 6118
Debugger [candidate] (6.053 ms) : 0, 6053
Remote Config [baseline] (680.573 µs) : 0, 681
Remote Config [candidate] (673.969 µs) : 0, 674
Telemetry [baseline] (12.349 ms) : 0, 12349
Telemetry [candidate] (12.835 ms) : 0, 12835
section iast
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (859.133 ms) : 0, 859133
BytebuddyAgent [candidate] (857.503 ms) : 0, 857503
GlobalTracer [baseline] (234.687 ms) : 0, 234687
GlobalTracer [candidate] (234.747 ms) : 0, 234747
AppSec [baseline] (27.033 ms) : 0, 27033
AppSec [candidate] (25.34 ms) : 0, 25340
Debugger [baseline] (6.663 ms) : 0, 6663
Debugger [candidate] (6.672 ms) : 0, 6672
Remote Config [baseline] (626.699 µs) : 0, 627
Remote Config [candidate] (601.229 µs) : 0, 601
Telemetry [baseline] (8.342 ms) : 0, 8342
Telemetry [candidate] (8.357 ms) : 0, 8357
IAST [baseline] (30.966 ms) : 0, 30966
IAST [candidate] (31.232 ms) : 0, 31232

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~d8b332790d, baseline=1.53.0-SNAPSHOT~9aad75597f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055373
Total [baseline] (10.823 s) : 0, 10823312
Agent [candidate] (1.05 s) : 0, 1050308
Total [candidate] (10.89 s) : 0, 10889907
section appsec
Agent [baseline] (1.223 s) : 0, 1223041
Total [baseline] (10.773 s) : 0, 10773302
Agent [candidate] (1.226 s) : 0, 1225768
Total [candidate] (10.749 s) : 0, 10748832
section iast
Agent [baseline] (1.182 s) : 0, 1182067
Total [baseline] (10.937 s) : 0, 10937209
Agent [candidate] (1.189 s) : 0, 1189364
Total [candidate] (10.996 s) : 0, 10995812
section profiling
Agent [baseline] (1.197 s) : 0, 1197210
Total [baseline] (10.965 s) : 0, 10964591
Agent [candidate] (1.197 s) : 0, 1197084
Total [candidate] (10.934 s) : 0, 10934380

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.055 s	-
Agent	appsec	1.223 s	167.668 ms (15.9%)
Agent	iast	1.182 s	126.694 ms (12.0%)
Agent	profiling	1.197 s	141.837 ms (13.4%)
Total	tracing	10.823 s	-
Total	appsec	10.773 s	-50.011 ms (-0.5%)
Total	iast	10.937 s	113.897 ms (1.1%)
Total	profiling	10.965 s	141.279 ms (1.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	appsec	1.226 s	175.46 ms (16.7%)
Agent	iast	1.189 s	139.056 ms (13.2%)
Agent	profiling	1.197 s	146.776 ms (14.0%)
Total	tracing	10.89 s	-
Total	appsec	10.749 s	-141.075 ms (-1.3%)
Total	iast	10.996 s	105.905 ms (1.0%)
Total	profiling	10.934 s	44.473 ms (0.4%)

gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~d8b332790d, baseline=1.53.0-SNAPSHOT~9aad75597f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (738.218 ms) : 0, 738218
BytebuddyAgent [candidate] (733.532 ms) : 0, 733532
GlobalTracer [baseline] (244.771 ms) : 0, 244771
GlobalTracer [candidate] (243.472 ms) : 0, 243472
AppSec [baseline] (30.454 ms) : 0, 30454
AppSec [candidate] (30.334 ms) : 0, 30334
Debugger [baseline] (6.108 ms) : 0, 6108
Debugger [candidate] (6.034 ms) : 0, 6034
Remote Config [baseline] (676.913 µs) : 0, 677
Remote Config [candidate] (668.342 µs) : 0, 668
Telemetry [baseline] (12.367 ms) : 0, 12367
Telemetry [candidate] (13.651 ms) : 0, 13651
section appsec
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (755.081 ms) : 0, 755081
BytebuddyAgent [candidate] (756.932 ms) : 0, 756932
GlobalTracer [baseline] (235.558 ms) : 0, 235558
GlobalTracer [candidate] (235.978 ms) : 0, 235978
AppSec [baseline] (169.84 ms) : 0, 169840
AppSec [candidate] (171.006 ms) : 0, 171006
Debugger [baseline] (5.734 ms) : 0, 5734
Debugger [candidate] (6.479 ms) : 0, 6479
Remote Config [baseline] (650.898 µs) : 0, 651
Remote Config [candidate] (646.359 µs) : 0, 646
Telemetry [baseline] (9.989 ms) : 0, 9989
Telemetry [candidate] (8.529 ms) : 0, 8529
IAST [baseline] (23.588 ms) : 0, 23588
IAST [candidate] (23.48 ms) : 0, 23480
section iast
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (852.353 ms) : 0, 852353
BytebuddyAgent [candidate] (858.808 ms) : 0, 858808
GlobalTracer [baseline] (233.839 ms) : 0, 233839
GlobalTracer [candidate] (234.782 ms) : 0, 234782
AppSec [baseline] (27.024 ms) : 0, 27024
AppSec [candidate] (26.006 ms) : 0, 26006
Debugger [baseline] (6.663 ms) : 0, 6663
Debugger [candidate] (6.729 ms) : 0, 6729
Remote Config [baseline] (991.607 µs) : 0, 992
Remote Config [candidate] (612.8 µs) : 0, 613
Telemetry [baseline] (8.372 ms) : 0, 8372
Telemetry [candidate] (8.379 ms) : 0, 8379
IAST [baseline] (30.225 ms) : 0, 30225
IAST [candidate] (31.358 ms) : 0, 31358
section profiling
crashtracking [baseline] (1.419 ms) : 0, 1419
crashtracking [candidate] (1.41 ms) : 0, 1410
BytebuddyAgent [baseline] (762.87 ms) : 0, 762870
BytebuddyAgent [candidate] (762.11 ms) : 0, 762110
GlobalTracer [baseline] (221.76 ms) : 0, 221760
GlobalTracer [candidate] (222.872 ms) : 0, 222872
AppSec [baseline] (29.998 ms) : 0, 29998
AppSec [candidate] (29.942 ms) : 0, 29942
Debugger [baseline] (7.059 ms) : 0, 7059
Debugger [candidate] (7.834 ms) : 0, 7834
Remote Config [baseline] (731.592 µs) : 0, 732
Remote Config [candidate] (692.751 µs) : 0, 693
Telemetry [baseline] (14.843 ms) : 0, 14843
Telemetry [candidate] (14.942 ms) : 0, 14942
ProfilingAgent [baseline] (108.776 ms) : 0, 108776
ProfilingAgent [candidate] (107.594 ms) : 0, 107594
Profiling [baseline] (109.418 ms) : 0, 109418
Profiling [candidate] (108.291 ms) : 0, 108291

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/maybe-copy-scope-stack-when-restoring
git_commit_date	1755780320	1755780191
git_commit_sha	`9aad755`	`d8b3327`
release_version	1.53.0-SNAPSHOT~9aad75597f	1.53.0-SNAPSHOT~d8b332790d

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755781716	1755781716
ci_job_id	1091828891	1091828891
ci_pipeline_id	74359755	74359755
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-3-d2qwihdb 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-3-d2qwihdb 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:iast:high_load	worse [+225.456µs; +566.009µs] or [+2.402%; +6.030%]	unstable [-82.489op/s; +42.926op/s] or [-16.683%; +8.682%]	9.783ms	474.656op/s	9.387ms	494.438op/s
scenario:load:insecure-bank:tracing:high_load	worse [+152.358µs; +386.010µs] or [+2.028%; +5.138%]	unstable [-100.215op/s; +57.840op/s] or [-16.263%; +9.386%]	7.782ms	595.031op/s	7.513ms	616.219op/s
scenario:load:insecure-bank:no_agent:high_load	better [-203.346µs; -93.118µs] or [-4.581%; -2.098%]	unstable [-92.926op/s; +161.926op/s] or [-8.983%; +15.654%]	4.290ms	1068.938op/s	4.439ms	1034.438op/s

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~d8b332790d, baseline=1.53.0-SNAPSHOT~9aad75597f
dateFormat X
axisFormat %s
section baseline
no_agent (4.439 ms) : 4384, 4493
. : milestone, 4439,
iast (9.387 ms) : 9230, 9544
. : milestone, 9387,
iast_FULL (13.824 ms) : 13553, 14094
. : milestone, 13824,
iast_GLOBAL (10.606 ms) : 10418, 10794
. : milestone, 10606,
profiling (8.95 ms) : 8811, 9089
. : milestone, 8950,
tracing (7.513 ms) : 7408, 7617
. : milestone, 7513,
section candidate
no_agent (4.29 ms) : 4243, 4338
. : milestone, 4290,
iast (9.783 ms) : 9623, 9942
. : milestone, 9783,
iast_FULL (14.263 ms) : 13976, 14550
. : milestone, 14263,
iast_GLOBAL (10.626 ms) : 10438, 10813
. : milestone, 10626,
profiling (9.2 ms) : 9038, 9363
. : milestone, 9200,
tracing (7.782 ms) : 7669, 7894
. : milestone, 7782,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.439 ms [4.384 ms, 4.493 ms]	-
iast	9.387 ms [9.23 ms, 9.544 ms]	4.948 ms (111.5%)
iast_FULL	13.824 ms [13.553 ms, 14.094 ms]	9.385 ms (211.4%)
iast_GLOBAL	10.606 ms [10.418 ms, 10.794 ms]	6.168 ms (139.0%)
profiling	8.95 ms [8.811 ms, 9.089 ms]	4.511 ms (101.6%)
tracing	7.513 ms [7.408 ms, 7.617 ms]	3.074 ms (69.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.29 ms [4.243 ms, 4.338 ms]	-
iast	9.783 ms [9.623 ms, 9.942 ms]	5.492 ms (128.0%)
iast_FULL	14.263 ms [13.976 ms, 14.55 ms]	9.972 ms (232.4%)
iast_GLOBAL	10.626 ms [10.438 ms, 10.813 ms]	6.335 ms (147.7%)
profiling	9.2 ms [9.038 ms, 9.363 ms]	4.91 ms (114.4%)
tracing	7.782 ms [7.669 ms, 7.894 ms]	3.491 ms (81.4%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~d8b332790d, baseline=1.53.0-SNAPSHOT~9aad75597f
dateFormat X
axisFormat %s
section baseline
no_agent (37.242 ms) : 36953, 37532
. : milestone, 37242,
appsec (48.009 ms) : 47583, 48435
. : milestone, 48009,
code_origins (46.64 ms) : 46225, 47055
. : milestone, 46640,
iast (45.018 ms) : 44632, 45404
. : milestone, 45018,
profiling (47.377 ms) : 46952, 47803
. : milestone, 47377,
tracing (44.492 ms) : 44102, 44882
. : milestone, 44492,
section candidate
no_agent (36.237 ms) : 35944, 36531
. : milestone, 36237,
appsec (46.983 ms) : 46573, 47392
. : milestone, 46983,
code_origins (46.351 ms) : 45939, 46763
. : milestone, 46351,
iast (45.13 ms) : 44736, 45525
. : milestone, 45130,
profiling (48.377 ms) : 47911, 48843
. : milestone, 48377,
tracing (44.507 ms) : 44118, 44896
. : milestone, 44507,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.242 ms [36.953 ms, 37.532 ms]	-
appsec	48.009 ms [47.583 ms, 48.435 ms]	10.767 ms (28.9%)
code_origins	46.64 ms [46.225 ms, 47.055 ms]	9.398 ms (25.2%)
iast	45.018 ms [44.632 ms, 45.404 ms]	7.775 ms (20.9%)
profiling	47.377 ms [46.952 ms, 47.803 ms]	10.135 ms (27.2%)
tracing	44.492 ms [44.102 ms, 44.882 ms]	7.25 ms (19.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.237 ms [35.944 ms, 36.531 ms]	-
appsec	46.983 ms [46.573 ms, 47.392 ms]	10.746 ms (29.7%)
code_origins	46.351 ms [45.939 ms, 46.763 ms]	10.114 ms (27.9%)
iast	45.13 ms [44.736 ms, 45.525 ms]	8.893 ms (24.5%)
profiling	48.377 ms [47.911 ms, 48.843 ms]	12.14 ms (33.5%)
tracing	44.507 ms [44.118 ms, 44.896 ms]	8.27 ms (22.8%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/maybe-copy-scope-stack-when-restoring
git_commit_date	1755780320	1755780191
git_commit_sha	`9aad755`	`d8b3327`
release_version	1.53.0-SNAPSHOT~9aad75597f	1.53.0-SNAPSHOT~d8b332790d

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1755782271	1755782271
ci_job_id	1091828892	1091828892
ci_pipeline_id	74359755	74359755
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-74h7v0qu 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-74h7v0qu 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~d8b332790d, baseline=1.53.0-SNAPSHOT~9aad75597f
dateFormat X
axisFormat %s
section baseline
no_agent (14.801 s) : 14801000, 14801000
. : milestone, 14801000,
appsec (15.108 s) : 15108000, 15108000
. : milestone, 15108000,
iast (18.096 s) : 18096000, 18096000
. : milestone, 18096000,
iast_GLOBAL (18.023 s) : 18023000, 18023000
. : milestone, 18023000,
profiling (15.114 s) : 15114000, 15114000
. : milestone, 15114000,
tracing (15.084 s) : 15084000, 15084000
. : milestone, 15084000,
section candidate
no_agent (14.763 s) : 14763000, 14763000
. : milestone, 14763000,
appsec (14.951 s) : 14951000, 14951000
. : milestone, 14951000,
iast (18.344 s) : 18344000, 18344000
. : milestone, 18344000,
iast_GLOBAL (18.155 s) : 18155000, 18155000
. : milestone, 18155000,
profiling (15.557 s) : 15557000, 15557000
. : milestone, 15557000,
tracing (15.126 s) : 15126000, 15126000
. : milestone, 15126000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.801 s [14.801 s, 14.801 s]	-
appsec	15.108 s [15.108 s, 15.108 s]	307.0 ms (2.1%)
iast	18.096 s [18.096 s, 18.096 s]	3.295 s (22.3%)
iast_GLOBAL	18.023 s [18.023 s, 18.023 s]	3.222 s (21.8%)
profiling	15.114 s [15.114 s, 15.114 s]	313.0 ms (2.1%)
tracing	15.084 s [15.084 s, 15.084 s]	283.0 ms (1.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.763 s [14.763 s, 14.763 s]	-
appsec	14.951 s [14.951 s, 14.951 s]	188.0 ms (1.3%)
iast	18.344 s [18.344 s, 18.344 s]	3.581 s (24.3%)
iast_GLOBAL	18.155 s [18.155 s, 18.155 s]	3.392 s (23.0%)
profiling	15.557 s [15.557 s, 15.557 s]	794.0 ms (5.4%)
tracing	15.126 s [15.126 s, 15.126 s]	363.0 ms (2.5%)

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~d8b332790d, baseline=1.53.0-SNAPSHOT~9aad75597f
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1494
. : milestone, 1482,
appsec (3.69 ms) : 3470, 3911
. : milestone, 3690,
iast (2.206 ms) : 2142, 2269
. : milestone, 2206,
iast_GLOBAL (2.254 ms) : 2190, 2318
. : milestone, 2254,
profiling (2.072 ms) : 2019, 2124
. : milestone, 2072,
tracing (2.038 ms) : 1988, 2088
. : milestone, 2038,
section candidate
no_agent (1.484 ms) : 1472, 1495
. : milestone, 1484,
appsec (3.669 ms) : 3450, 3888
. : milestone, 3669,
iast (2.208 ms) : 2145, 2272
. : milestone, 2208,
iast_GLOBAL (2.252 ms) : 2189, 2315
. : milestone, 2252,
profiling (2.079 ms) : 2027, 2131
. : milestone, 2079,
tracing (2.026 ms) : 1977, 2074
. : milestone, 2026,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.482 ms [1.47 ms, 1.494 ms]	-
appsec	3.69 ms [3.47 ms, 3.911 ms]	2.208 ms (149.0%)
iast	2.206 ms [2.142 ms, 2.269 ms]	723.604 µs (48.8%)
iast_GLOBAL	2.254 ms [2.19 ms, 2.318 ms]	771.777 µs (52.1%)
profiling	2.072 ms [2.019 ms, 2.124 ms]	589.764 µs (39.8%)
tracing	2.038 ms [1.988 ms, 2.088 ms]	556.342 µs (37.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.484 ms [1.472 ms, 1.495 ms]	-
appsec	3.669 ms [3.45 ms, 3.888 ms]	2.185 ms (147.3%)
iast	2.208 ms [2.145 ms, 2.272 ms]	724.653 µs (48.8%)
iast_GLOBAL	2.252 ms [2.189 ms, 2.315 ms]	768.291 µs (51.8%)
profiling	2.079 ms [2.027 ms, 2.131 ms]	595.068 µs (40.1%)
tracing	2.026 ms [1.977 ms, 2.074 ms]	541.84 µs (36.5%)

…current thread is not the original. This mitigates a potential issue if the swapped out scope-stack is ever restored more than once on different threads.

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.52.1` -> `1.53.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.53.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.53.0): 1.53.0 ### Components #### Application Security Management (WAF) - 🐛 Fix NullPointerException log in AppSec ([#9355](DataDog/dd-trace-java#9355) - [@jandro996](https://github.com/jandro996)) - ✨ Add Forwarded header as a source to client IP resolution ([#9310](DataDog/dd-trace-java#9310) - [@jandro996](https://github.com/jandro996)) #### Build & Tooling - 📖 Update CODEOWNERS ([#9294](DataDog/dd-trace-java#9294) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add dependency on Maven Central deployment to OCI publish jobs ([#9204](DataDog/dd-trace-java#9204) - [@sarahchen6](https://github.com/sarahchen6)) #### Continuous Integration Visibility - ✨ Upload code coverage reports to Datadog ([#9425](DataDog/dd-trace-java#9425) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Do not follow symlinks by default when building repository index ([#9318](DataDog/dd-trace-java#9318) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Improve tag propagation between test event levels ([#9278](DataDog/dd-trace-java#9278) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - ✨ Create container hash tags propagation ([#9282](DataDog/dd-trace-java#9282) - [@ygree](https://github.com/ygree)) #### Database Monitoring - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#9321](DataDog/dd-trace-java#9321) - [@na-ji](https://github.com/na-ji)) - ✨ Create container hash tags propagation ([#9282](DataDog/dd-trace-java#9282) - [@ygree](https://github.com/ygree)) #### GraalVM native-image - 🐛 Update GraalVM config to reflect TempLocationManager's new package ([#9337](DataDog/dd-trace-java#9337) - [@luneo7](https://github.com/luneo7) - thanks for the contribution!) #### Metrics - 🐛 Add reflect config for CSS and graalvm ([#9449](DataDog/dd-trace-java#9449) - [@amarziali](https://github.com/amarziali)) - ✨ Align CSS health metrics ([#9444](DataDog/dd-trace-java#9444) - [@amarziali](https://github.com/amarziali)) - ✨ Aggregate peer tags for consumer span kind ([#9442](DataDog/dd-trace-java#9442) - [@amarziali](https://github.com/amarziali)) - ✨ Implement health metrics for client stats ([#9377](DataDog/dd-trace-java#9377) - [@amarziali](https://github.com/amarziali)) - ✨ Add peer tags, span kind and trace root flag to MetricKey bucket ([#9178](DataDog/dd-trace-java#9178) - [@bric3](https://github.com/bric3)) #### Profiling - ✨ Create a profile flare reporter (requires tracing or CI vis to be enabled) ([#9433](DataDog/dd-trace-java#9433) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Properly fall-back on UDS profiling URL ([#9401](DataDog/dd-trace-java#9401) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Properly handle trace agent IPv6 URL in profiling ([#9334](DataDog/dd-trace-java#9334) - [@jbachorik](https://github.com/jbachorik)) #### Realtime User Monitoring - 🐛 Avoid multiple injections on dispatch on jboss ([#9392](DataDog/dd-trace-java#9392) - [@amarziali](https://github.com/amarziali)) - ✨ Support async servlet for RUM injection ([#9333](DataDog/dd-trace-java#9333) - [@amarziali](https://github.com/amarziali)) - 🐛 Improve RUM injection matching and avoid truncating responses ([#9323](DataDog/dd-trace-java#9323) - [@amarziali](https://github.com/amarziali)) - 💡 Add telemetry for the RUM injector ([#9267](DataDog/dd-trace-java#9267) - [@sarahchen6](https://github.com/sarahchen6)) - ✨ Make rum injector stream/writer more resilient to errors ([#9184](DataDog/dd-trace-java#9184) - [@amarziali](https://github.com/amarziali)) #### Telemetry - 🐛 Remediate error logs ([#9459](DataDog/dd-trace-java#9459) - [@ygree](https://github.com/ygree)) - ✨ Report config\_id for Hands Off Config files ([#9299](DataDog/dd-trace-java#9299) - [@mtoffl01](https://github.com/mtoffl01)) - ✨ Adding Config Inversion Telemetry component ([#9244](DataDog/dd-trace-java#9244) - [@mhlidd](https://github.com/mhlidd)) #### Trace context propagation - 🧹 Migrate instrumentations to Context API ([#9384](DataDog/dd-trace-java#9384), [#9378](DataDog/dd-trace-java#9378), [#9358](DataDog/dd-trace-java#9358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🔍 Add baggage propagation telemetry ([#9289](DataDog/dd-trace-java#9289) - [@rachelyangdog](https://github.com/rachelyangdog)) - 🧹 Improve Instrumenter API to use Context instead of Span ([#9211](DataDog/dd-trace-java#9211) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - 💡:test\_tube: Enable process level tags for java 21 applications ([#9458](DataDog/dd-trace-java#9458) - [@amarziali](https://github.com/amarziali)) - ✨ Move base and peer service adder before span is published ([#9408](DataDog/dd-trace-java#9408) - [@amarziali](https://github.com/amarziali)) - ✨ Add ErrorPriorities level for manual instrumentation ([#9387](DataDog/dd-trace-java#9387) - [@cecile75](https://github.com/cecile75)) - ✨ Throw InvalidBooleanValueException in ConfigConverter.booleanValueOf ([#9370](DataDog/dd-trace-java#9370) - [@mtoffl01](https://github.com/mtoffl01)) - 🐛 Avoid NPE on featureDiscovery creation ([#9353](DataDog/dd-trace-java#9353) - [@amarziali](https://github.com/amarziali)) - ✨ Stable Config improvements ([#9259](DataDog/dd-trace-java#9259) - [@mtoffl01](https://github.com/mtoffl01)) ### Instrumentations #### gRPC instrumentation - 🐛 Changing GRPC instrumentation codes from `status.code` to `grpc.status.code` ([#9367](DataDog/dd-trace-java#9367) - [@mhlidd](https://github.com/mhlidd)) #### JDBC instrumentation - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#9321](DataDog/dd-trace-java#9321) - [@na-ji](https://github.com/na-ji)) #### Kotlin instrumentation - 🐛 Take defensive copy of original scope stack when restoring on different thread ([#9403](DataDog/dd-trace-java#9403) - [@mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Fix using SpanAttribute annotation on multiple parameters ([#9412](DataDog/dd-trace-java#9412) - [@cecile75](https://github.com/cecile75)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: e23ec866cef91afc6b5226d5f0dc7da538d947e8

mcculls requested a review from a team as a code owner August 21, 2025 11:52

mcculls added type: bug fix Bug fix inst: kotlin Kotlin instrumentation labels Aug 21, 2025

mcculls requested a review from amarziali August 21, 2025 11:52

amarziali approved these changes Aug 21, 2025
View reviewed changes

When restoring a swapped out scope-stack, take defensive copy if the …
d8b3327
…current thread is not the original. This mitigates a potential issue if the swapped out scope-stack is ever restored more than once on different threads.

mcculls force-pushed the mcculls/maybe-copy-scope-stack-when-restoring branch from 384508c to d8b3327Compare August 21, 2025 12:43

mcculls merged commit 2fa9986 into masterAug 21, 2025
499 checks passed

mcculls deleted the mcculls/maybe-copy-scope-stack-when-restoring branch August 21, 2025 13:41

github-actionsBot added this to the 1.53.0 milestone Aug 21, 2025

mcculls mentioned this pull request Aug 21, 2025
NullPointerException in ScopeStack.checkOverdueScopes() due to race condition on 'top' field #9399
Closed

Navigation Menu

Uh oh!

Take defensive copy of original scope stack when restoring on different thread - #9403

Take defensive copy of original scope stack when restoring on different thread#9403
mcculls merged 1 commit into
masterfrom
mcculls/maybe-copy-scope-stack-when-restoring

mcculls commented Aug 21, 2025

Uh oh!

datadog-datadog-prod-us1Bot commented Aug 21, 2025•
edited
Loading

Uh oh!

pr-commenterBot commented Aug 21, 2025•
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mcculls commented Aug 21, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-datadog-prod-us1Bot commented Aug 21, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenterBot commented Aug 21, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

datadog-datadog-prod-us1Bot commented Aug 21, 2025•
edited
Loading

pr-commenterBot commented Aug 21, 2025•
edited
Loading