Introduces `testJvmConstraints` Gradle extension to replace extra properties by bric3 · Pull Request #9892 · DataDog/dd-trace-java

bric3 · 2025-10-31T17:10:39Z

What Does This Do

Refactor the mechanism that relied on extra properties like minJavaVersionForTests to a Gradle extension mechanism.

Also, minJavaVersionForTests was serving two distinct purpose

Restricting the range JDK on which the test can run
Adding and configuring a source set

This PR explicitly segregates these two concerns.

Motivation

The way the extra properties were programmed prevents to remove some project.afterEvaluate calls. And also prevents to migrate to convention plugins (these are ultimately pre-compiled script plugins).

Additional Notes

At this time the logic remains very similar, and focuses on the refactoring from extra properties (ext { }) to extensions to avoid too many change.

However, in the future it might be interesting to revisit the way the JDK is specified, from JavaVersion to something more toolchain aware via org.gradle.jvm.toolchain.JavaToolchainSpec.

Some projects still rely on regular Gradle directives to set the sourceset. These will be migrate in a follow-up PR :

dd-java-agent/agent-bootstrap/build.gradle
dd-java-agent/agent-builder/build.gradle
dd-java-agent/build.gradle
dd-java-agent/instrumentation/mule-4.5/build.gradle
dd-java-agent/instrumentation/play/play-2.4/build.gradle
dd-java-agent/instrumentation/play/play-2.6/build.gradle

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

…sion # Conflicts: # dd-java-agent/instrumentation/aerospike-4.0/build.gradle # dd-java-agent/instrumentation/armeria/armeria-jetty-1.24/build.gradle

… test jvm constraints

…includeJdk directive

…tension

…ation

github-actions · 2025-10-31T17:10:57Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

sarahchen6 · 2025-11-04T16:57:03Z

+tracerJava {
+ addSourceSetFor(JavaVersion.VERSION_11)
+}
+


just curious -- how come in some files like this one, we use tracerJava instead of testJvmConstraint like this:
testJvmConstraint { minJavaVersion = JavaVersion.VERSION_11 }
?
e.g. dd-java-agent/instrumentation/java/java-lang/java-lang-17.0/build.gradle now uses testJvmConstraint vs. dd-java-agent/instrumentation/jetty/jetty-server/jetty-server-12.0/build.gradle now uses tracerJava whereas both previously had:
ext { minJavaVersionForTests = JavaVersion.VERSION_17 }
and e.g. dd-java-agent/instrumentation/vertx/vertx-web/vertx-web-5.0/build.gradle has both

Good catch !
Before minJavaVersionForTests was used for two purposes, as a constraint testJvm only, i.e. they were no java source with this version.
When there are source set, addSourceSetFor actually sets by default the minimum JVM for test as well.
I chose to keep things explicit. But thinking about it maybe I can make another pass to avoid setting this twice.

I see. Thanks for the clarification!

sarahchen6

Pre-approving because I think these suggestions could be included in a follow-up PR as well, but wow thanks for this great build improvement!

bric3

Thanks for the review

bric3 · 2025-11-07T17:22:25Z

+tracerJava {
+ addSourceSetFor(JavaVersion.VERSION_11)
+}
+


Good catch !
Before minJavaVersionForTests was used for two purposes, as a constraint testJvm only, i.e. they were no java source with this version.
When there are source set, addSourceSetFor actually sets by default the minimum JVM for test as well.
I chose to keep things explicit. But thinking about it maybe I can make another pass to avoid setting this twice.

…s-to-extensions # Conflicts: # dd-java-agent/instrumentation/jakarta-jms/build.gradle # dd-java-agent/instrumentation/karate/build.gradle # dd-java-agent/instrumentation/selenium/build.gradle # dd-java-agent/instrumentation/testng/testng-7/build.gradle

datadog-official · 2025-11-10T09:29:23Z

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 59.60% (-0.03%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: b2345ac | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

amarziali

Is really neat and now declaring test compatibilities with that kind of directive is way more clear! Thanks for having refactored this. As a future improvement (not needed for this PR) it could be nice to change the documentation

pr-commenter · 2025-11-10T09:45:39Z

Kafka / producer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/from-extra-props-to-extensions
git_commit_date	1762738486	1762765724
git_commit_sha	`0ab0769`	`b2345ac`

See matching parameters

	Baseline	Candidate
ci_job_date	1762766841	1762766841
ci_job_id	1224781490	1224781490
ci_pipeline_id	81772293	81772293
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.25	11.0.25
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.25+9-post-Ubuntu-1ubuntu122.04	11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce	same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce	same

pr-commenter · 2025-11-10T09:57:22Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/from-extra-props-to-extensions
git_commit_date	1762738486	1762765724
git_commit_sha	`0ab0769`	`b2345ac`
release_version	1.56.0-SNAPSHOT~0ab0769ee0	1.55.0-SNAPSHOT~b2345ac263

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1762767604	1762767604
ci_job_id	1224781481	1224781481
ci_pipeline_id	81772293	81772293
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-0pf372ys 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-0pf372ys 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics.

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~b2345ac263, baseline=1.56.0-SNAPSHOT~0ab0769ee0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050031
Total [baseline] (8.645 s) : 0, 8644890
Agent [candidate] (1.062 s) : 0, 1062356
Total [candidate] (8.676 s) : 0, 8676354
section iast
Agent [baseline] (1.177 s) : 0, 1176669
Total [baseline] (9.261 s) : 0, 9261368
Agent [candidate] (1.185 s) : 0, 1184858
Total [candidate] (9.29 s) : 0, 9289516

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	iast	1.177 s	126.638 ms (12.1%)
Total	tracing	8.645 s	-
Total	iast	9.261 s	616.478 ms (7.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.062 s	-
Agent	iast	1.185 s	122.502 ms (11.5%)
Total	tracing	8.676 s	-
Total	iast	9.29 s	613.162 ms (7.1%)

gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~b2345ac263, baseline=1.56.0-SNAPSHOT~0ab0769ee0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.481 ms) : 0, 1481
BytebuddyAgent [baseline] (707.798 ms) : 0, 707798
BytebuddyAgent [candidate] (715.071 ms) : 0, 715071
GlobalTracer [baseline] (245.781 ms) : 0, 245781
GlobalTracer [candidate] (248.928 ms) : 0, 248928
AppSec [baseline] (32.233 ms) : 0, 32233
AppSec [candidate] (32.93 ms) : 0, 32930
Debugger [baseline] (6.349 ms) : 0, 6349
Debugger [candidate] (6.547 ms) : 0, 6547
Remote Config [baseline] (738.2 µs) : 0, 738
Remote Config [candidate] (713.076 µs) : 0, 713
Telemetry [baseline] (15.04 ms) : 0, 15040
Telemetry [candidate] (13.352 ms) : 0, 13352
Flare Poller [baseline] (5.769 ms) : 0, 5769
Flare Poller [candidate] (8.183 ms) : 0, 8183
section iast
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (826.806 ms) : 0, 826806
BytebuddyAgent [candidate] (831.042 ms) : 0, 831042
GlobalTracer [baseline] (233.833 ms) : 0, 233833
GlobalTracer [candidate] (236.332 ms) : 0, 236332
AppSec [baseline] (26.219 ms) : 0, 26219
AppSec [candidate] (28.208 ms) : 0, 28208
Debugger [baseline] (6.004 ms) : 0, 6004
Debugger [candidate] (6.002 ms) : 0, 6002
Remote Config [baseline] (595.028 µs) : 0, 595
Remote Config [candidate] (601.26 µs) : 0, 601
Telemetry [baseline] (8.27 ms) : 0, 8270
Telemetry [candidate] (8.535 ms) : 0, 8535
Flare Poller [baseline] (4.164 ms) : 0, 4164
Flare Poller [candidate] (4.099 ms) : 0, 4099
IAST [baseline] (34.632 ms) : 0, 34632
IAST [candidate] (33.805 ms) : 0, 33805

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~b2345ac263, baseline=1.56.0-SNAPSHOT~0ab0769ee0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1052969
Total [baseline] (10.805 s) : 0, 10805166
Agent [candidate] (1.047 s) : 0, 1047065
Total [candidate] (10.798 s) : 0, 10798346
section appsec
Agent [baseline] (1.228 s) : 0, 1228464
Total [baseline] (10.895 s) : 0, 10894726
Agent [candidate] (1.224 s) : 0, 1224144
Total [candidate] (10.944 s) : 0, 10943949
section iast
Agent [baseline] (1.176 s) : 0, 1176453
Total [baseline] (11.128 s) : 0, 11127514
Agent [candidate] (1.187 s) : 0, 1186765
Total [candidate] (11.264 s) : 0, 11264423
section profiling
Agent [baseline] (1.203 s) : 0, 1202794
Total [baseline] (10.973 s) : 0, 10972532
Agent [candidate] (1.199 s) : 0, 1198748
Total [candidate] (10.978 s) : 0, 10977524

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.053 s	-
Agent	appsec	1.228 s	175.495 ms (16.7%)
Agent	iast	1.176 s	123.484 ms (11.7%)
Agent	profiling	1.203 s	149.825 ms (14.2%)
Total	tracing	10.805 s	-
Total	appsec	10.895 s	89.56 ms (0.8%)
Total	iast	11.128 s	322.348 ms (3.0%)
Total	profiling	10.973 s	167.366 ms (1.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.047 s	-
Agent	appsec	1.224 s	177.079 ms (16.9%)
Agent	iast	1.187 s	139.7 ms (13.3%)
Agent	profiling	1.199 s	151.684 ms (14.5%)
Total	tracing	10.798 s	-
Total	appsec	10.944 s	145.604 ms (1.3%)
Total	iast	11.264 s	466.078 ms (4.3%)
Total	profiling	10.978 s	179.178 ms (1.7%)

gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~b2345ac263, baseline=1.56.0-SNAPSHOT~0ab0769ee0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (708.635 ms) : 0, 708635
BytebuddyAgent [candidate] (704.271 ms) : 0, 704271
GlobalTracer [baseline] (246.942 ms) : 0, 246942
GlobalTracer [candidate] (245.963 ms) : 0, 245963
AppSec [baseline] (32.656 ms) : 0, 32656
AppSec [candidate] (32.495 ms) : 0, 32495
Debugger [baseline] (6.448 ms) : 0, 6448
Debugger [candidate] (6.391 ms) : 0, 6391
Remote Config [baseline] (716.436 µs) : 0, 716
Remote Config [candidate] (723.212 µs) : 0, 723
Telemetry [baseline] (12.248 ms) : 0, 12248
Telemetry [candidate] (14.395 ms) : 0, 14395
Flare Poller [baseline] (8.946 ms) : 0, 8946
Flare Poller [candidate] (6.6 ms) : 0, 6600
section appsec
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (735.118 ms) : 0, 735118
BytebuddyAgent [candidate] (730.473 ms) : 0, 730473
GlobalTracer [baseline] (238.058 ms) : 0, 238058
GlobalTracer [candidate] (237.481 ms) : 0, 237481
AppSec [baseline] (174.634 ms) : 0, 174634
AppSec [candidate] (175.611 ms) : 0, 175611
Debugger [baseline] (5.994 ms) : 0, 5994
Debugger [candidate] (6.025 ms) : 0, 6025
Remote Config [baseline] (647.257 µs) : 0, 647
Remote Config [candidate] (652.915 µs) : 0, 653
Telemetry [baseline] (8.574 ms) : 0, 8574
Telemetry [candidate] (8.632 ms) : 0, 8632
Flare Poller [baseline] (3.989 ms) : 0, 3989
Flare Poller [candidate] (4.021 ms) : 0, 4021
IAST [baseline] (24.852 ms) : 0, 24852
IAST [candidate] (24.809 ms) : 0, 24809
section iast
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (825.509 ms) : 0, 825509
BytebuddyAgent [candidate] (834.22 ms) : 0, 834220
GlobalTracer [baseline] (234.004 ms) : 0, 234004
GlobalTracer [candidate] (235.642 ms) : 0, 235642
AppSec [baseline] (28.305 ms) : 0, 28305
AppSec [candidate] (27.168 ms) : 0, 27168
Debugger [baseline] (6.03 ms) : 0, 6030
Debugger [candidate] (6.056 ms) : 0, 6056
Remote Config [baseline] (601.499 µs) : 0, 601
Remote Config [candidate] (609.531 µs) : 0, 610
Telemetry [baseline] (8.407 ms) : 0, 8407
Telemetry [candidate] (8.407 ms) : 0, 8407
Flare Poller [baseline] (4.113 ms) : 0, 4113
Flare Poller [candidate] (4.127 ms) : 0, 4127
IAST [baseline] (33.283 ms) : 0, 33283
IAST [candidate] (34.217 ms) : 0, 34217
section profiling
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (735.273 ms) : 0, 735273
BytebuddyAgent [candidate] (732.973 ms) : 0, 732973
GlobalTracer [baseline] (223.155 ms) : 0, 223155
GlobalTracer [candidate] (223.23 ms) : 0, 223230
AppSec [baseline] (32.294 ms) : 0, 32294
AppSec [candidate] (32.131 ms) : 0, 32131
Debugger [baseline] (8.356 ms) : 0, 8356
Debugger [candidate] (8.205 ms) : 0, 8205
Remote Config [baseline] (729.404 µs) : 0, 729
Remote Config [candidate] (725.925 µs) : 0, 726
Telemetry [baseline] (14.544 ms) : 0, 14544
Telemetry [candidate] (14.481 ms) : 0, 14481
Flare Poller [baseline] (4.111 ms) : 0, 4111
Flare Poller [candidate] (4.171 ms) : 0, 4171
ProfilingAgent [baseline] (112.138 ms) : 0, 112138
ProfilingAgent [candidate] (111.263 ms) : 0, 111263
Profiling [baseline] (112.802 ms) : 0, 112802
Profiling [candidate] (111.92 ms) : 0, 111920

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/from-extra-props-to-extensions
git_commit_date	1762738486	1762765724
git_commit_sha	`0ab0769`	`b2345ac`
release_version	1.56.0-SNAPSHOT~0ab0769ee0	1.55.0-SNAPSHOT~b2345ac263

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1762768094	1762768094
ci_job_id	1224781483	1224781483
ci_pipeline_id	81772293	81772293
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-yhjto97a 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-yhjto97a 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:profiling:high_load	better [-412.125µs; -368.560µs] or [-17.649%; -15.783%]	unstable [+120.013op/s; +632.237op/s] or [+6.178%; +32.546%]	1.945ms	2318.719op/s	2.335ms	1942.594op/s
scenario:load:petclinic:no_agent:high_load	worse [+432.091µs; +865.502µs] or [+2.260%; +4.527%]	unstable [-33.944op/s; +18.069op/s] or [-13.905%; +7.402%]	19.768ms	236.188op/s	19.119ms	244.125op/s
scenario:load:petclinic:profiling:high_load	worse [+774.065µs; +1195.053µs] or [+4.155%; +6.415%]	unstable [-38.469op/s; +13.407op/s] or [-15.355%; +5.351%]	19.613ms	238.000op/s	18.628ms	250.531op/s
scenario:load:petclinic:iast:high_load	worse [+732.855µs; +1125.678µs] or [+4.124%; +6.335%]	unstable [-39.570op/s; +13.757op/s] or [-15.071%; +5.240%]	18.698ms	249.656op/s	17.769ms	262.562op/s
scenario:load:petclinic:tracing:high_load	better [-1.382ms; -0.982ms] or [-7.322%; -5.206%]	unstable [-10.717op/s; +43.592op/s] or [-4.332%; +17.622%]	17.688ms	263.812op/s	18.870ms	247.375op/s

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~b2345ac263, baseline=1.56.0-SNAPSHOT~0ab0769ee0
dateFormat X
axisFormat %s
section baseline
no_agent (1.201 ms) : 1189, 1213
. : milestone, 1201,
iast (3.205 ms) : 3158, 3252
. : milestone, 3205,
iast_FULL (5.833 ms) : 5775, 5891
. : milestone, 5833,
iast_GLOBAL (3.651 ms) : 3601, 3701
. : milestone, 3651,
profiling (2.335 ms) : 2312, 2358
. : milestone, 2335,
tracing (1.834 ms) : 1819, 1849
. : milestone, 1834,
section candidate
no_agent (1.187 ms) : 1176, 1199
. : milestone, 1187,
iast (3.28 ms) : 3241, 3319
. : milestone, 3280,
iast_FULL (5.788 ms) : 5729, 5846
. : milestone, 5788,
iast_GLOBAL (3.64 ms) : 3586, 3693
. : milestone, 3640,
profiling (1.945 ms) : 1928, 1962
. : milestone, 1945,
tracing (1.823 ms) : 1809, 1838
. : milestone, 1823,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.201 ms [1.189 ms, 1.213 ms]	-
iast	3.205 ms [3.158 ms, 3.252 ms]	2.004 ms (166.8%)
iast_FULL	5.833 ms [5.775 ms, 5.891 ms]	4.632 ms (385.7%)
iast_GLOBAL	3.651 ms [3.601 ms, 3.701 ms]	2.45 ms (204.0%)
profiling	2.335 ms [2.312 ms, 2.358 ms]	1.134 ms (94.4%)
tracing	1.834 ms [1.819 ms, 1.849 ms]	633.034 µs (52.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.187 ms [1.176 ms, 1.199 ms]	-
iast	3.28 ms [3.241 ms, 3.319 ms]	2.093 ms (176.3%)
iast_FULL	5.788 ms [5.729 ms, 5.846 ms]	4.6 ms (387.5%)
iast_GLOBAL	3.64 ms [3.586 ms, 3.693 ms]	2.452 ms (206.6%)
profiling	1.945 ms [1.928 ms, 1.962 ms]	757.592 µs (63.8%)
tracing	1.823 ms [1.809 ms, 1.838 ms]	636.114 µs (53.6%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~b2345ac263, baseline=1.56.0-SNAPSHOT~0ab0769ee0
dateFormat X
axisFormat %s
section baseline
no_agent (19.119 ms) : 18923, 19315
. : milestone, 19119,
appsec (18.92 ms) : 18728, 19113
. : milestone, 18920,
code_origins (17.757 ms) : 17581, 17934
. : milestone, 17757,
iast (17.769 ms) : 17592, 17945
. : milestone, 17769,
profiling (18.628 ms) : 18440, 18817
. : milestone, 18628,
tracing (18.87 ms) : 18676, 19065
. : milestone, 18870,
section candidate
no_agent (19.768 ms) : 19561, 19974
. : milestone, 19768,
appsec (18.689 ms) : 18499, 18879
. : milestone, 18689,
code_origins (17.618 ms) : 17441, 17796
. : milestone, 17618,
iast (18.698 ms) : 18509, 18886
. : milestone, 18698,
profiling (19.613 ms) : 19411, 19815
. : milestone, 19613,
tracing (17.688 ms) : 17512, 17865
. : milestone, 17688,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	19.119 ms [18.923 ms, 19.315 ms]	-
appsec	18.92 ms [18.728 ms, 19.113 ms]	-198.624 µs (-1.0%)
code_origins	17.757 ms [17.581 ms, 17.934 ms]	-1.361 ms (-7.1%)
iast	17.769 ms [17.592 ms, 17.945 ms]	-1.35 ms (-7.1%)
profiling	18.628 ms [18.44 ms, 18.817 ms]	-490.559 µs (-2.6%)
tracing	18.87 ms [18.676 ms, 19.065 ms]	-248.429 µs (-1.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	19.768 ms [19.561 ms, 19.974 ms]	-
appsec	18.689 ms [18.499 ms, 18.879 ms]	-1.079 ms (-5.5%)
code_origins	17.618 ms [17.441 ms, 17.796 ms]	-2.149 ms (-10.9%)
iast	18.698 ms [18.509 ms, 18.886 ms]	-1.07 ms (-5.4%)
profiling	19.613 ms [19.411 ms, 19.815 ms]	-154.797 µs (-0.8%)
tracing	17.688 ms [17.512 ms, 17.865 ms]	-2.079 ms (-10.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/from-extra-props-to-extensions
git_commit_date	1762738486	1762765724
git_commit_sha	`0ab0769`	`b2345ac`
release_version	1.56.0-SNAPSHOT~0ab0769ee0	1.55.0-SNAPSHOT~b2345ac263

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1762767737	1762767737
ci_job_id	1224781485	1224781485
ci_pipeline_id	81772293	81772293
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-8zp35tot 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-8zp35tot 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~b2345ac263, baseline=1.56.0-SNAPSHOT~0ab0769ee0
dateFormat X
axisFormat %s
section baseline
no_agent (14.767 s) : 14767000, 14767000
. : milestone, 14767000,
appsec (14.874 s) : 14874000, 14874000
. : milestone, 14874000,
iast (18.587 s) : 18587000, 18587000
. : milestone, 18587000,
iast_GLOBAL (18.138 s) : 18138000, 18138000
. : milestone, 18138000,
profiling (15.068 s) : 15068000, 15068000
. : milestone, 15068000,
tracing (14.923 s) : 14923000, 14923000
. : milestone, 14923000,
section candidate
no_agent (14.977 s) : 14977000, 14977000
. : milestone, 14977000,
appsec (14.943 s) : 14943000, 14943000
. : milestone, 14943000,
iast (18.376 s) : 18376000, 18376000
. : milestone, 18376000,
iast_GLOBAL (17.839 s) : 17839000, 17839000
. : milestone, 17839000,
profiling (14.979 s) : 14979000, 14979000
. : milestone, 14979000,
tracing (14.892 s) : 14892000, 14892000
. : milestone, 14892000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.767 s [14.767 s, 14.767 s]	-
appsec	14.874 s [14.874 s, 14.874 s]	107.0 ms (0.7%)
iast	18.587 s [18.587 s, 18.587 s]	3.82 s (25.9%)
iast_GLOBAL	18.138 s [18.138 s, 18.138 s]	3.371 s (22.8%)
profiling	15.068 s [15.068 s, 15.068 s]	301.0 ms (2.0%)
tracing	14.923 s [14.923 s, 14.923 s]	156.0 ms (1.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.977 s [14.977 s, 14.977 s]	-
appsec	14.943 s [14.943 s, 14.943 s]	-34.0 ms (-0.2%)
iast	18.376 s [18.376 s, 18.376 s]	3.399 s (22.7%)
iast_GLOBAL	17.839 s [17.839 s, 17.839 s]	2.862 s (19.1%)
profiling	14.979 s [14.979 s, 14.979 s]	2.0 ms (0.0%)
tracing	14.892 s [14.892 s, 14.892 s]	-85.0 ms (-0.6%)

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~b2345ac263, baseline=1.56.0-SNAPSHOT~0ab0769ee0
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.692 ms) : 3474, 3910
. : milestone, 3692,
iast (2.206 ms) : 2143, 2270
. : milestone, 2206,
iast_GLOBAL (2.235 ms) : 2171, 2298
. : milestone, 2235,
profiling (2.071 ms) : 2017, 2124
. : milestone, 2071,
tracing (2.03 ms) : 1980, 2080
. : milestone, 2030,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.709 ms) : 3491, 3928
. : milestone, 3709,
iast (2.206 ms) : 2142, 2269
. : milestone, 2206,
iast_GLOBAL (2.248 ms) : 2184, 2311
. : milestone, 2248,
profiling (2.075 ms) : 2022, 2128
. : milestone, 2075,
tracing (2.016 ms) : 1966, 2065
. : milestone, 2016,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.461 ms, 1.484 ms]	-
appsec	3.692 ms [3.474 ms, 3.91 ms]	2.219 ms (150.7%)
iast	2.206 ms [2.143 ms, 2.27 ms]	733.293 µs (49.8%)
iast_GLOBAL	2.235 ms [2.171 ms, 2.298 ms]	761.601 µs (51.7%)
profiling	2.071 ms [2.017 ms, 2.124 ms]	597.601 µs (40.6%)
tracing	2.03 ms [1.98 ms, 2.08 ms]	557.334 µs (37.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.46 ms, 1.483 ms]	-
appsec	3.709 ms [3.491 ms, 3.928 ms]	2.238 ms (152.1%)
iast	2.206 ms [2.142 ms, 2.269 ms]	734.297 µs (49.9%)
iast_GLOBAL	2.248 ms [2.184 ms, 2.311 ms]	776.312 µs (52.8%)
profiling	2.075 ms [2.022 ms, 2.128 ms]	603.835 µs (41.0%)
tracing	2.016 ms [1.966 ms, 2.065 ms]	544.223 µs (37.0%)

pr-commenter · 2025-11-10T09:57:41Z

Kafka / consumer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/from-extra-props-to-extensions
git_commit_date	1762738486	1762765724
git_commit_sha	`0ab0769`	`b2345ac`

See matching parameters

	Baseline	Candidate
ci_job_date	1762766875	1762766875
ci_job_id	1224781491	1224781491
ci_pipeline_id	81772293	81772293
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.25	11.0.25
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.25+9-post-Ubuntu-1ubuntu122.04	11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume	same

bric3 added 17 commits October 27, 2025 14:32

chore: Starts extracting testJvm configuration to another script plugin
914c780

chore: Moved test jvm constraint logic to convention plugin
770111c

chore: Moved additional test suite constraints to new test task exten…
c6cda9f
…sion # Conflicts: # dd-java-agent/instrumentation/aerospike-4.0/build.gradle # dd-java-agent/instrumentation/armeria/armeria-jetty-1.24/build.gradle

chore: Configure test jvm constraint on test task, added project wide…
dfefaea
… test jvm constraints

chore: configure source set via extension method
9f643d4

chore: Use source set configuration
594cbb1

chore: Renames jvmConstraints to testJvmConstraints
dcce4f2

fix: profiling-controller-oracle tests could never run, introduce an …
3ef9429
…includeJdk directive

refactor: Simplify test jvm enablement code
39c00ee

chore: Handle test sources compilation override
975044a

chore: testJvm is optional
deaebf1

refactor: small rename job
4a2aa18

refactor: Convert remaining usage of min/max jdk properties to our ex…
1e2e37b
…tension

refactor: Renames min|maxJavaVersionForTests to min|maxJavaVersion
f5a892a

chore: Make spotless happy
79cf261

fix: Apply test sources compiler settings via common compilerConfigur…
04bd398
…ation

fix: Make vertx compile test with Java 11
5a502dc

bric3 requested review from a team as code owners October 31, 2025 17:10

bric3 requested review from AlexeyKuznetsov-DD, Mariovido, manuel-alvarez-alvarez and sarahchen6 October 31, 2025 17:10

bric3 added type: feature Enhancements and improvements tag: no release notes Changes to exclude from release notes labels Nov 3, 2025

bric3 added the comp: tooling Build & Tooling label Nov 3, 2025

sarahchen6 reviewed Nov 4, 2025
View reviewed changes

Comment threadinternal-api/internal-api-9/build.gradle.kts

sarahchen6 reviewed Nov 4, 2025
View reviewed changes

Comment threadgradle/java_no_deps.gradle

sarahchen6 reviewed Nov 4, 2025
View reviewed changes

Comment threadgradle/java_no_deps.gradle

sarahchen6 reviewed Nov 4, 2025
View reviewed changes

Comment thread...dSrc/src/main/kotlin/datadog/gradle/plugin/testJvmConstraints/TestJvmConstraintsExtension.kt Outdated

sarahchen6 approved these changes Nov 4, 2025
View reviewed changes

AlexeyKuznetsov-DD reviewed Nov 5, 2025
View reviewed changes

Comment threadbuildSrc/src/main/kotlin/datadog/gradle/plugin/testJvmConstraints/TestJvmConstraintsUtils.kt Outdated
Comment threadbuildSrc/src/main/kotlin/datadog.test-jvm-contraints.gradle.kts Outdated

bric3 commented Nov 7, 2025
View reviewed changes

AlexeyKuznetsov-DD approved these changes Nov 7, 2025
View reviewed changes

fix: PR comments
590f959

bric3 enabled auto-merge (squash) November 10, 2025 09:02

bric3 changed the title ~~Introduces testJvmConstraint Gradle extension to replace extra properties~~Introduces testJvmConstraints Gradle extension to replace extra propertiesNov 10, 2025

bric3 force-pushed the bdu/from-extra-props-to-extensions branch from 97d50b4 to b2345acCompare November 10, 2025 09:08

amarziali approved these changes Nov 10, 2025
View reviewed changes

bric3 merged commit 4255dc0 into masterNov 10, 2025
541 checks passed

bric3 deleted the bdu/from-extra-props-to-extensions branch November 10, 2025 10:00

github-actionsBot added this to the 1.56.0 milestone Nov 10, 2025

This was referenced Nov 20, 2025
Fix Java version requirements for OpenFeature tests #10003
Merged
Remove instrumentation afterEvaluate#9752
Merged

bric3 mentioned this pull request Dec 5, 2025
Rewrite build-time instrumentation as compilation post-processor (using Gradle lazy APIs) #9475
Merged

bric3 mentioned this pull request Jun 29, 2026
Enable coverage when testJvm same as Gradle Daemon JDK or with checkCoverage property #11764
Merged

Uh oh!

Conversation

bric3 commented Oct 31, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

github-actionsBot commented Oct 31, 2025

Uh oh!

sarahchen6Nov 4, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bric3Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

sarahchen6Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sarahchen6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bric3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bric3Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

datadog-officialBot commented Nov 10, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amarziali left a comment

Choose a reason for hiding this comment

Uh oh!

pr-commenterBot commented Nov 10, 2025

Kafka / producer-benchmark

Parameters

Summary

Uh oh!

pr-commenterBot commented Nov 10, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

pr-commenterBot commented Nov 10, 2025

Kafka / consumer-benchmark

Parameters

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sarahchen6Nov 4, 2025•
edited
Loading

datadog-officialBot commented Nov 10, 2025•
edited
Loading