Uh oh!
There was an error while loading. Please reload this page.
fix: gate linear token sequences by flag profile - #114
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens when the runtime compiler may take the named-capture Linear Token Sequence (LTS) fast-path by requiring an explicit Reggie DOTALL flag profile (rather than source-inline modifiers), and adds tests to lock in the new routing behavior and cache interactions.
Changes:
- Gate LTS admission behind a source-derived “inline modifier present?” scan and an explicit Reggie
DOTALLflag profile (not(?s)in the pattern text). - Thread the LTS-admission profile through
RuntimeCompiler.compile(...)intotryCompileLinearTokenSequence(...)/isRuntimeExecutableLinearTokenSequence(...). - Update/add runtime tests to use the Reggie-owned
DOTALLAPI and cover routing, cache-order independence, and inline-modifier detection.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| reggie-runtime/src/main/java/com/datadoghq/reggie/runtime/RuntimeCompiler.java | Introduces and propagates LinearTokenSequenceAdmission and adds a source scanner to block LTS when inline modifiers are present unless explicitly permitted by the Reggie DOTALL flag profile. |
| reggie-runtime/src/test/java/com/datadoghq/reggie/runtime/LinearTokenSequenceMatcherTest.java | Updates fixtures to use ReggieFlags.DOTALL and adds tests covering the new LTS gating rules and inline-modifier scanner behavior. |
| reggie-runtime/src/test/java/com/datadoghq/reggie/runtime/LinearTokenSequenceMatcherConcurrencyTest.java | Updates compilation of LTS fixtures to use explicit Reggie DOTALL when fixtures previously used a leading (?s). |
| reggie-runtime/src/test/java/com/datadoghq/reggie/runtime/LinearTokenSequenceAccessLogTest.java | Same fixture compilation update as concurrency test; centralizes it in a helper to convert leading (?s) into ReggieFlags.DOTALL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:dde7ffc2e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
dde7ffc to
77e99a5CompareCodecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## agent/logs-reggie-l1c #114 +/- ##
=======================================================
Coverage 84.4% 84.4% Complexity 1 1 =======================================================
Files 147 147 Lines 42993 43067 +74 Branches 5860 5890 +30 =======================================================
+ Hits 36296 36367 +71 + Misses 4911 4905 -6 - Partials 1786 1795 +9
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
77e99a5 to
c4b2025Comparec4b2025 to
f4bb496Compare
Summary
and comment contexts
Validation
Stacked on #113 (which is stacked on #112 and #111).