Uh oh!
There was an error while loading. Please reload this page.
feat: add native linear token admission - #115
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a package-private “native named-only LTS admission” seam in RuntimeCompiler that can return either an admitted LinearTokenSequenceMatcher or a structured rejection reason, and introduces tests to validate cache isolation, rejection taxonomy, capture index behavior, and matcher independence (including concurrency).
Changes:
- Introduced
NamedOnlyLtsRejection+NamedOnlyLtsCompilationandtryCompileNamedOnlyLinearTokenSequence(...)to return structured admission results without touching legacy caches. - Refactored the existing named-only LTS routing to share a single admission implementation (
admitNamedOnlyLinearTokenSequence). - Added
NamedOnlyLtsAdmissionTestto cover admissions, rejections, capture projection/index preservation, and concurrency behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| reggie-runtime/src/main/java/com/datadoghq/reggie/runtime/RuntimeCompiler.java | Adds structured named-only LTS admission API and refactors admission logic to share the same implementation path. |
| reggie-runtime/src/test/java/com/datadoghq/reggie/runtime/NamedOnlyLtsAdmissionTest.java | Adds coverage for cache isolation, rejection reasons, matcher independence, and capture-index preservation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:773d63b137
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
773d63b to
74a0504CompareCodecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## agent/logs-reggie-l1d #115 +/- ##
=======================================================
Coverage 84.4% 84.4% Complexity 1 1 =======================================================
Files 147 147 Lines 43067 43087 +20 Branches 5890 5891 +1 =======================================================
+ Hits 36367 36394 +27 - Misses 4905 4906 +1 + Partials 1795 1787 -8
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
74a0504 to
ce17323Comparece17323 to
362ae27Compare
Summary
Validation
Stacked on #114.