Skip to content

Limelight constants - #72

Merged
ProfessorAtomicManiac merged 7 commits into
masterfrom
limelight-constants+testing
Jun 13, 2024
Merged

Limelight constants#72
ProfessorAtomicManiac merged 7 commits into
masterfrom
limelight-constants+testing

Conversation

@stwiggy

@stwiggy stwiggy commented Jun 12, 2024

Copy link
Copy Markdown
Contributor

updated LimelightHelpers and changed some constants to match ryan's CAD

@stwiggy
stwiggy requested a review from a team as a code owner June 12, 2024 16:58

@brettle brettle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a cursory review. Don't know if there are other issues.

Comment thread src/main/java/org/carlmontrobotics/commands/AlignToApriltag.java Outdated
Comment thread src/main/java/org/carlmontrobotics/commands/AlignToApriltag.java Outdated
@brettle
brettle dismissed their stale review June 13, 2024 03:00

Sunshine rise should do a more thorough review.

@brettle

brettle commented Jun 13, 2024

Copy link
Copy Markdown
Member

Sunshine rise --> someone else.

Shouldn't have tried to type that on my phone.

Comment thread src/main/java/org/carlmontrobotics/RobotContainer.java Outdated
Comment thread src/main/java/org/carlmontrobotics/RobotContainer.java Outdated
Comment thread src/main/java/org/carlmontrobotics/subsystems/Limelight.java
@CoolSpy3 CoolSpy3 mentioned this pull request Jun 13, 2024

@ProfessorAtomicManiac ProfessorAtomicManiac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool

Comment thread src/main/java/org/carlmontrobotics/subsystems/Limelight.java
@ProfessorAtomicManiac
ProfessorAtomicManiac merged commit 4b2fb42 into master Jun 13, 2024
@ProfessorAtomicManiac
ProfessorAtomicManiac deleted the limelight-constants+testing branch June 13, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants