Conversation
CoolSpy3
marked this pull request as draft
August 4, 2023 09:22
Member
|
Ready for review/merge? I have a small conflicting change to |
Member
Author
|
I believe I intended to keep this open until the relevant PRs in |
CoolSpy3
marked this pull request as ready for review
May 3, 2024 21:34
brettle
approved these changes
May 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bunch of miscellaneous bug fixes for things I found when writing simulation docs. I tried to break it up so that each "thing" is a separate commit. Thus, a good idea of the changes can be obtained by reading the commit messages. Because some of these are widespread formatting changes, the full diff may be a little difficult to read, so I recommend looking at each diff individually.
I'm going to keep this as a draft until I go through the other libraries in case I think of anything else.
Atm, this is also untestedI got the system test working (locally, see note about CI in DeepBlueRobotics/DeepBlueSim#46), but a lot of these changes are fairly straight forward, so... its probably fine :D I can maybe run some tests once the other libraries are brought up-to-date. It would also be nice to test with any new Rev/Phoenix sim stuff, so keep an eye on DeepBlueRobotics/lib199#44 and DeepBlueRobotics/lib199#62.