Possible Unnecessary Code (Check REVLib Changelog) (SparkMax Unplugged Warning)

[CoolSpy3]

lib199/src/main/java/org/carlmontrobotics/lib199/MotorControllerFactory.java

Lines 124 to 128 in 432cd16

	if (spark.getFirmwareVersion() == 0) {
	spark.close();
	System.err.println("SparkMax on port: " + id + " is not connected!");
	return MotorErrors.createDummySparkMax();
	}

I've emailed Rev about the REVLib issue for which this is a workaround. This issue is for discussion of any relevant information, and as a reminder to watch the changelog as a supported solution may be released in the future.

[CoolSpy3]

As far as I can tell, this has been patched. I tried creating a spark-max with id 99 and setting the speed, and it didn't crash the code. Some pros and cons to keeping this in:
Pros

• We get a warning when a SparkMax is unplugged
• Known behavior of disconnected SparkMaxes

Cons

• When there are REVLib changes, the dummy spark max implementation has to be updated or stuff starts breaking
• Mockito overhead

Please provide thoughts below

[brettle]

This post seems to indicate that RevLib already logs an error if you attempt to communicate with an unplugged SparkMax, so I don't see a good reason to keep the code.

[CoolSpy3]

Confirmed! I'll start a PR.