Skip to content

Remove SparkMax Unplugged Handler - #48

Merged
CoolSpy3 merged 3 commits into
masterfrom
remove-sparkmax-unplugged-handler
Jul 6, 2023
Merged

Remove SparkMax Unplugged Handler#48
CoolSpy3 merged 3 commits into
masterfrom
remove-sparkmax-unplugged-handler

Conversation

@CoolSpy3

Copy link
Copy Markdown
Member

Fixes#45 .

@CoolSpy3CoolSpy3 changed the title Remove SparkMax Unplugged Handler and Deprecate Related MethodsRemove SparkMax Unplugged HandlerMay 27, 2023
@CoolSpy3CoolSpy3 added the Passed Testing This PR was successfully tested on a robot label Jun 14, 2023
FriedLongJohns
FriedLongJohns previously approved these changes Jun 29, 2023

@FriedLongJohnsFriedLongJohns left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me from what I can understand, as long as people know that revRobotics has code for this instead of lib199

Comment threadsrc/main/java/org/carlmontrobotics/lib199/MotorControllerFactory.java Outdated
@CoolSpy3CoolSpy3 added the Patch This PR will introduce backwards-compatible changes and bugfixes without new functionality label Jun 30, 2023
@CoolSpy3
CoolSpy3 merged commit ed78b8f into masterJul 6, 2023
@CoolSpy3
CoolSpy3 deleted the remove-sparkmax-unplugged-handler branch July 21, 2023 23:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Passed TestingThis PR was successfully tested on a robotPatchThis PR will introduce backwards-compatible changes and bugfixes without new functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible Unnecessary Code (Check REVLib Changelog) (SparkMax Unplugged Warning)

3 participants

@CoolSpy3@ProfessorAtomicManiac@FriedLongJohns