Uh oh!
There was an error while loading. Please reload this page.
feat(semver): identifierBase for inc() & throwErrors for parse() & jsdoc - #73409
Conversation
@hkleungai Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 73409,
"author": "hkleungai",
"headCommitOid": "b17198f998e7649b310603e20d74553a0af533d7",
"mergeBaseOid": "68cfc5a271cd13cf509636f3f54e819bfe816112",
"lastPushDate": "2025-08-05T05:56:05.000Z",
"lastActivityDate": "2025-09-03T14:43:39.000Z",
"mergeOfferDate": "2025-09-03T03:30:40.000Z",
"mergeRequestDate": "2025-09-03T14:43:39.000Z",
"mergeRequestUser": "hkleungai",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "semver",
"kind": "edit",
"files": [
{
"path": "types/semver/classes/semver.d.ts",
"kind": "definition"
},
{
"path": "types/semver/functions/compare-loose.d.ts",
"kind": "definition"
},
{
"path": "types/semver/functions/inc.d.ts",
"kind": "definition"
},
{
"path": "types/semver/functions/parse.d.ts",
"kind": "definition"
},
{
"path": "types/semver/index.d.ts",
"kind": "definition"
},
{
"path": "types/semver/semver-tests.ts",
"kind": "test"
}
],
"owners": [
"Bartvds",
"BendingBender",
"LucianBuzzo",
"ajafff",
"ExE-Boss",
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "RyanCavanaugh",
"date": "2025-09-03T03:30:00.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "steveoh",
"date": "2025-08-05T15:03:13.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 3153453305,
"ciResult": "pass"
} |
typescript-bot
commented
Aug 5, 2025
🔔 @Bartvds@BendingBender@LucianBuzzo@ajafff@ExE-Boss@peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
commented
Aug 16, 2025
Re-ping @Bartvds, @BendingBender, @LucianBuzzo, @ajafff, @ExE-Boss, @peterblazejewicz: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
typescript-bot
commented
Aug 23, 2025
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @hkleungai. (Ping @Bartvds, @BendingBender, @LucianBuzzo, @ajafff, @ExE-Boss, @peterblazejewicz.) |
typescript-bot
commented
Sep 3, 2025
@hkleungai: Everything looks good here. I am ready to merge this PR (at b17198f) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@Bartvds, @BendingBender, @LucianBuzzo, @ajafff, @ExE-Boss, @peterblazejewicz: you can do this too.) |
hkleungai
commented
Sep 3, 2025
Ready to merge |
Uh oh!
There was an error while loading. Please reload this page.
Add
identifierBasefor.inc(). Resolves discussion #73405.Add
throwErrorsfor.parse().Update some other jsdoc.
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition: