Uh oh!
There was an error while loading. Please reload this page.
feat: allow identifierBase to be false - #548
Conversation
…intentifiers without appending .0
wraithgar
commented
Apr 12, 2023
A "disable" boolean is often very confusing because it's turning something off when it's true. We already have a flag to change this number, perhaps supporting |
157e260 to
fda7e36Compare…Prerelease Identifier Base parameter
fda7e36 to
14a3913CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
wraithgar
commented
Apr 13, 2023
A very good start. Just some minor copy and code quality feedback. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| ['1.2.3-dev.bar', 'prerelease', '1.2.3-dev', false, 'dev', false], | ||
| ['1.2.0', 'preminor', '1.3.0-dev', false, 'dev', false], | ||
| ['1.2.3-1', 'preminor', '1.3.0-dev', false, 'dev', false], | ||
| ['1.2.3-dev', 'prerelease', '1.2.3-dev.1', false, 'dev', false], |
There was a problem hiding this comment.
@nlf what do you think about this? If they have said "increase the prerelease" but also asked for there not to be a prerelease base, do we default to 1 or should we throw?
There was a problem hiding this comment.
my gut reaction is we should throw because they've asked for us to do something that doesn't make sense. going from no number to adding a number when we've been asked to not add numbers feels wrong
There was a problem hiding this comment.
I agree, let's throw in this situation. No more guessing user intent!
There was a problem hiding this comment.
just to clarify do we want to throw also in:
['1.2.0','prerelease','1.2.1-1',false,'',false],?
There was a problem hiding this comment.
Oooh good point. We sure do! "increase the prerelease with no identifier and no identifierBase" sure sounds impossible.
There was a problem hiding this comment.
i updated it to throw on both cases
wraithgar
commented
Apr 13, 2023
Can you add the tests from #550 to this PR? |
wraithgar
commented
Apr 14, 2023
Really useful new feature, thanks! |
What
Added Disable Prerelease Identifier Base flag for creating prerelease identifiers without appending
.0/.1Improved
Prerelease Identifier Baseto use it when identifier is not set (1.0.0-{Identifier Base}) and adds description to cli help for-nflagWhy
Version
1.0.0-somethingis valid Semantic Version and its not necessary to have "build" number for identifiers that have only one/ first build, changes reflect that so if another prerelease is created with same identifier the "build" number will be append according Prerelease Identifier Base argumentReferences
Fixes#441
Improves #532