Uh oh!
There was an error while loading. Please reload this page.
refactor(atomic-actions): add typed tracking contracts - #501
Merged
Conversation
Make endpoint bindings, timed command frames, transports, routing, safe holds, and profile lowering controller-agnostic. Preserve joint trajectories as optional feedback artifacts and add staged, same-address invocation revision semantics for mobile and whole-body safety.
This was referenced Aug 11, 2026
yuecideng
marked this pull request as ready for review
August 11, 2026 16:46
Greptile SummaryThis PR replaces implicit trajectory-error callbacks with typed, versioned tracking contracts shared by direct atomic actions and semantic skill runtimes.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| embodichain/lab/sim/atomic_actions/tracking.py | Introduces typed tracking channels, states, policies, registries, built-in providers, projectors, evaluators, and immutable evaluation contracts. |
| embodichain/lab/sim/atomic_actions/execution.py | Integrates typed in-flight evaluation, terminal acceptance, feedback failure handling, and tracking-route continuity into execution. |
| embodichain/lab/sim/atomic_actions/core.py | Projects endpoint commands into command-aligned tracking frames while validating channel coverage. |
| embodichain/lab/sim/atomic_actions/plans.py | Extends action plans with tracking sequences and validates consistent setpoint identities and routes across frames. |
| embodichain/lab/sim/skills/profiles.py | Adds tracking policies and typed endpoint tracking bindings to semantic skill profiles. |
| embodichain/lab/sim/skills/runtime.py | Propagates typed tracking behavior through semantic workflow execution and result reporting. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Action invocation] --> B[Action plan]
B --> C[Timed command sequence]
B --> D[Timed tracking sequence]
C --> E[Command transport]
E --> F[Robot or simulator]
F --> G[Typed feedback provider]
D --> H[Tracking frame]
G --> I[Metric evaluator]
H --> I
I --> J{Tracking policy}
J -->|Accepted| K[Complete or verify effect]
J -->|Pending| L[Continue or settle]
J -->|Violation| M[Retry or replan]
Reviews (5): Last reviewed commit: "wip" | Re-trigger Greptile
4 tasks
skywhite1024force-pushed
the
refactor/typed-tracking-contract
branch
from
August 21, 2026 09:35
6a42cd6 to
57e47f3Compareskywhite1024force-pushed
the
refactor/typed-tracking-contract
branch
from
August 21, 2026 11:31
57e47f3 to
6a42cd6Compare…dation' into refactor/typed-tracking-contract # Conflicts: # embodichain/lab/sim/atomic_actions/__init__.py # embodichain/lab/sim/atomic_actions/core.py # embodichain/lab/sim/atomic_actions/engine.py # embodichain/lab/sim/atomic_actions/execution.py # embodichain/lab/sim/atomic_actions/runtime.py # embodichain/lab/sim/skills/runtime.py # tests/sim/atomic_actions/test_core.py # tests/sim/atomic_actions/test_engine_per_env.py # tests/sim/skills/test_profiles.py # tests/sim/skills/test_runtime.py
…dation' into refactor/typed-tracking-contract # Conflicts: # embodichain_tasks/embodichain_tasks/tableware/open_drawer.py # tests/gym/envs/tasks/test_expert_program_repeated_pick_place.py
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stack
feat/expert-program-rollout-validationReplace implicit trajectory-error callbacks with typed tracking observations, metric bands, in-flight/terminal policies, and immutable tracking results.
The execution session can now diagnose row-local divergence, success, staleness, and retry through a stable public contract shared by direct atomic actions and semantic runtimes.
Refs #471
Refs #474
Type of change
Screenshots
Not applicable.
Validation
tests/sim/atomic_actions/test_tracking.py,test_engine_per_env.py,test_runner.py, and semantic runtime/profile testsChecklist