Uh oh!
There was an error while loading. Please reload this page.
Adapt Spawn integration to DexSim 0.5 APIs - #546
Open
yuecideng wants to merge 8 commits into
Open
Conversation
Greptile SummaryThis PR adapts the simulation lifecycle and object facades to DexSim 0.5 Spawn APIs.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains within the eligible follow-up review scope. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| embodichain/lab/sim/sim_manager.py | Moves scene commitment, backend preparation, facade binding, and deferred sensor attachment behind the common retryable prepare boundary. |
| embodichain/lab/sim/spawn/scene.py | Coordinates source resolution, finalization or rebuilding, and in-place binding of declared facades. |
| embodichain/lab/sim/spawn/descriptors.py | Compiles rigid-body, collision, link, joint, load-option, and articulation overrides into source-resolved Spawn descriptors. |
| embodichain/lab/sim/objects/backends/spawn.py | Replaces full-batch read-modify-write operations with native row and DOF selections and checks native failure statuses. |
| embodichain/lab/sim/objects/articulation.py | Updates articulation binding and property initialization to use Spawn-backed runtime data. |
| embodichain/lab/sim/objects/rigid_object.py | Extends Spawn-backed rigid-object property support and binding behavior. |
| embodichain/lab/sim/cfg.py | Adds the Newton Warp-log suppression setting and forwards it to DexSim configuration. |
Sequence Diagram
sequenceDiagram
participant Caller
participant Manager as SimulationManager
participant Scene as SpawnScene
participant Result as SpawnResult
participant Facades
participant Sensors
Caller->>Manager: add robots and objects
Manager->>Scene: declare descriptors and facades
Caller->>Manager: prepare()
Manager->>Scene: commit pending topology
Scene->>Result: finalize or rebuild
Manager->>Result: prepare_runtime()
Manager->>Scene: bind()
Scene->>Facades: bind_spawn(result)
Manager->>Sensors: attach_to_parent()
Manager-->>Caller: runtime ready
Reviews (3): Last reviewed commit: "wip" | Re-trigger Greptile
Too many files changed for review (110 files, 100 file limit). Bypass the limit by tagging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
xiemhDescription
This PR adapts EmbodiChain's Spawn integration to the updated DexSim public APIs on top of #516.
Dependencies: #516 and the matching DexSim Spawn implementation.
Refs #516
Type of change
Screenshots
Not applicable.
Validation
black --check --diff --coloron all 709 tracked Python files.open.tests/sim/test_differentiable_stepper.pyretains two Newton failures because draft: refactor spawn #516 removes the independently ownedNewtonManagerwhile the differentiable-stepper API still delegates to it; the native runtime can also segfault during teardown. DexSim does not yet expose an equivalent Spawn-owned public API, so this dependency gap is recorded rather than hidden with a speculative compatibility layer.Checklist
black .equivalent over all tracked Python files to format the code base.