chore: P7 KEEP leftover scan after upgrade→Core - #716
Merged
Conversation
Re-scan services barrel, src/self, production bridges, and upgrade wrappers after P6 (#711). No zero-ref or pure pass-through modules remain; lock the KEEP inventory in comments and ownership tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-P6 P7 leftover scan after upgrade→Core (#711) and OpenSpec archive (#712). Import-graph proof that no
src/services,src/self, compatibility, or upgrade wrapper became zero-reference or a pure pass-through when plan/check/apply orchestration moved tosrc/core/self-upgrade-executor.ts. Delete none. Keep every still-imported module and every bridge that still adds differential behavior (CLI context, port injection, domain planning/providers/binary/lock).Intake: mechanical leftover scan / no observable behavior — no new OpenSpec change.
DELETE vs KEEP
src/self/application.tssrc/core/self-upgrade-executor.ts. Ownership test asserts the path is gone.src/core/self-upgrade-production.tssrc/selfand fail the Core boundary. Ownership test asserts the path is gone.src/services/self-upgrade.tssrc/services/index.tsre-export ofself-upgrade-productionupgrade.tsimports production directly.src/services/self-upgrade-production.tssrc/selfplan/upgrade/lock/persistence binding into Core. Importer:src/commands/upgrade.ts.src/core/self-upgrade-executor.tsquantex-core. Must stay free ofsrc/self.src/commands/upgrade.tssrc/self/index.tsplanSelfUpgrade/upgradeSelfplus lock/planning/facts/release. Published v1 subset viasrc/compatibility/index.ts.src/self/planning.tssrc/self/index.ts.src/self/facts.tssrc/self/lock.tscreateSelfUpgradeLockPortinto Core ports.src/self/binary.tssrc/self/providers/binary.ts.src/self/providers/**bun/npm/binary/source).src/self/state-persistence.tssrc/self/{recovery,registry,release,types,update-metadata,update-notice}.tssrc/services/index.tsremaining agents + update re-exportssrc/compatibility/index.ts(published CLI surface).src/services/lifecycle-*-production.ts/doctor-diagnosis-production.tssrc/core/{installation,update}-compatibility.ts/*-production.ts/production-observation.tssrc/compatibility/{index,agent-inspection}.tssrc/lifecycle/**src/commands/unmanaged-install-compatibility.tsDELETE: none (0 zero-reference modules and 0 pure pass-through wrappers after #711).
Same-file helpers that look unused from outside stay: they are live internals, not leftover bridges. Unused named type re-exports on the lifecycle barrel are unchanged (not P6 leftovers; barrel itself is still imported).
Freeze confirmation
NETWORK_ERROR,MANUAL_ACTION_REQUIREDupgradeonly; binariesqtx/quantex--jsonenvelope and data fields unchanged--jsondoes not exposeengine/route--check,--channel, dry-run, exit codes, state v2 untouchedupgrade()methodrelease-core.yml/ protect-main untouchedrelease-one-line-delivery,release-pr-skip-human-heuristics,windows-ci-advisory-merge-gate)config/capabilities/commands/schemaLinked Artifacts
Validation
bun run memory:checkbun run lintbun run format:checkbun run typecheckbun run test— targeted 5 files / 44 passed; full suite 175 files / 2128 passed / 5 skippedbun run openspec:validateupgrade --json --check/--channel/ dry-run →MANUAL_ACTION_REQUIREDon source install,data.channelmatches, noengine/routerun_test_matrix=true/product-impactingRelease Intent
Release Summary
Docs Updated
Scope Check
Closure Check
Notes
src/modules after P6 deletedsrc/self/application.ts.src/keep classify on the full ubuntu/windows/macos test matrix (protect-main unchanged).