fix(upgrade): return NETWORK_ERROR when latest version cannot be resolved - #700
Merged
Merged
Conversation
This was referenced Sep 6, 2026
…lved Plain `quantex upgrade` crashed when planning could not resolve an installable latest version. Map that plan to structured NETWORK_ERROR and keep MANUAL_ACTION_REQUIRED under --check.
cursor
Bot
force-pushed
the
cursor/critical-quantex-cli-bugs-97f8
branch
from
September 6, 2026 11:36
5e03edc to
b85a77b
Compare
Contributor
Author
|
Rebase note (P3 delivery): Rebased Diff still scoped to upgrade New head: |
Drswith
marked this pull request as ready for review
September 6, 2026 11:40
13 tasks
cursor Bot
pushed a commit
that referenced
this pull request
Sep 6, 2026
Sync accepted self-upgrade NETWORK_ERROR / MANUAL_ACTION_REQUIRED deltas into openspec/specs/ after #700, and remove the completed change folder from the working tree.
Drswith
added a commit
that referenced
this pull request
Sep 6, 2026
* chore(openspec): archive fix-upgrade-unresolved-latest-crash Sync accepted self-upgrade NETWORK_ERROR / MANUAL_ACTION_REQUIRED deltas into openspec/specs/ after #700, and remove the completed change folder from the working tree. * chore(lifecycle): keep comment so archive PRs run macOS CI Touch a kept src/lifecycle file so classify sets run_test_matrix=true and protect-main's required test (macos-latest) actually runs. --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
30 tasks
cursor Bot
pushed a commit
that referenced
this pull request
Sep 6, 2026
Keep --channel on the frozen upgrade contract alongside --check, dry-run, JSON, aliases, exit codes, state v2, and #700 error codes. JSON still must not leak engine or route.
Drswith
added a commit
that referenced
this pull request
Sep 6, 2026
…711) * feat(upgrade): route plan/check/apply through in-repo Core (P6) Move CLI upgrade orchestration into an in-repo Core executor while keeping src/self domain modules and the CLI/self production bridge. Freeze JSON, --check, error codes, aliases, and the unpublished SDK surface. * chore(openspec): mark cli-core-upgrade-p6 validation tasks complete * chore(upgrade): lock --channel freeze and internal changelog framing Keep --channel on the frozen upgrade contract alongside --check, dry-run, JSON, aliases, exit codes, state v2, and #700 error codes. JSON still must not leak engine or route. * chore(openspec): mark cli-core-upgrade-p6 channel freeze validation complete --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quantex upgradecrashed with an unstructuredErrorwhen self-upgrade planning could not resolve an installable latest version.Impact: npm / bun / binary installs that run
quantex upgradeduring a registry or release-metadata failure lose the structuredNETWORK_ERRORcontract. Command runtime rethrows the error, so human and JSON modes both fail without a stable error code.Trigger: latest-version inspection returns no installable target (
check-unavailable). The application layer correctly returns a plan without mutating. The command layer only mapped that status under--check/ dry-run, then threwSelf-upgrade execution did not produce a result.Root cause: plan-status dispatch was incomplete.
--check/ dry-run also treated every non-update-availablestatus asNETWORK_ERROR, so a source / unknown install running--checkwas misclassified as a network failure.Fix: map
check-unavailableto structuredNETWORK_ERRORon everyupgradeentry, and mapmanual-requiredbefore the--check/ dry-run branch. The executed-result throw remains only as a fail-closed invariant.Linked Artifacts
fix-upgrade-unresolved-latest-crashValidation
bun run memory:checkbun run lintbun run format:checkbun run typecheckbun run test(if behavior changed) — 2113 passed, 5 skippedbun run openspec:validate— 26 passedRelease Intent
Release Summary
BEGIN_COMMIT_OVERRIDE
fix(upgrade): return NETWORK_ERROR when latest version cannot be resolved
qtx upgradenow reports a structured network error instead of crashingwhen the latest CLI version cannot be determined.
--checkon anon-auto-update install source keeps MANUAL_ACTION_REQUIRED.
END_COMMIT_OVERRIDE
Docs Updated
openspec/...Scope Check
Closure Check
Notes
fix-upgrade-unresolved-latest-crashafter this PR merges.#699(follow-up to#698), and the still-active umbrellarestore-managed-update-and-resume-releasesconfirmation tasks (1.11.x already published).