chore: L5 KEEP leftover scan after lifecycle barrel deletion - #729
Merged
Conversation
Import-graph proof that remaining services, compatibility, self, and idempotency layers are still referenced and still add differential behavior after L4 deleted src/lifecycle/. Delete none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-L4 L5 leftover scan after
src/lifecycle/barrel deletion (#727) and OpenSpec archive (#728). Import-graph proof that remainingsrc/services,src/compatibility,src/self, andsrc/idempotencybridges are still referenced and still add differential behavior (CLI context, port injection, v1 projection, domain planning/providers/binary/lock, idempotency replay). Delete none. Keep every still-imported module and every bridge that still adds differential behavior.Intake: mechanical leftover scan / no observable behavior — no new OpenSpec change. An actual fold of the published v1 facade or Core-internal engines would be an architecture-boundary change and would need OpenSpec; this PR documents that the fold is not safe.
DELETE vs KEEP
src/lifecycle/src/core/lifecycle/index.tssrc/core/lifecycle/{model,provider-binding,provider-evidence,agent-observation,update-planner,agent-execution,uninstall-postcondition}.tsproduct-impacting. Not leftover pass-throughs.src/self/application.tssrc/core/self-upgrade-production.tssrc/selfand fail the Core boundary.src/services/self-upgrade.tssrc/services/lifecycle-updates.ts/lifecycle-execution.tssrc/services/index.tssrc/compatibility/index.ts. P5 already pruned unused production re-exports.src/services/agents.tsresolveAgent/resolveAgentInspection/inspectRegisteredAgents. CLI routes no longer call the inspection helpers; the barrel still publishes them.src/services/update.tsplanAgentUpdatesgrouping. Importer: services barrel.src/services/self-upgrade-production.tssrc/selfplan/upgrade/lock/persistence binding into Core. Importer:src/commands/upgrade.ts.src/services/lifecycle-execution-production.ts--installvia installation-compatibility. Importer:src/commands/run.ts. L4 only retargetedLifecycleOutcomeontosrc/core/lifecycle/model.src/services/lifecycle-updates-production.tssrc/commands/update.ts,src/idempotency/lifecycle-policy.ts.src/services/doctor-diagnosis-production.tssrc/commands/doctor.ts.src/services/lifecycle-observations.tsobserveAgentLifecycle.src/services/core-read-observations.tsquantex-core/internalinspect/list.src/services/provider-observations.tssrc/services/command-capabilities.tssrc/compatibility/index.tssrc/index.tsre-exports it). Folding would change the published command/SDK boundary.src/compatibility/agent-inspection.tssrc/self/index.tsplanSelfUpgrade/upgradeSelfplus lock/planning/facts/release. Published v1 subset via compatibility.src/self/planning.tssrc/self/index.ts.src/self/{lock,facts,binary,recovery,registry,release,types,update-metadata,update-notice,state-persistence}.tssrc/self/providers/**bun/npm/binary/source).src/idempotency.tssrc/command-runtime.ts.src/idempotency/lifecycle-policy.tssrc/idempotency/{canonical,replay,schema}.tssrc/core/{installation,update}-compatibility.ts/*-production.ts/production-observation.ts/self-upgrade-executor.tssrc/commands/unmanaged-install-compatibility.tssrc/state.ts/src/planning/index.ts/src/inspection/index.ts/src/runtime/index.tspackages/core/src/{index,internal}.tsDELETE: none (0 zero-reference modules and 0 pure pass-through leftover wrappers after #727).
Same-file helpers that look unused from outside stay: they are live internals, not leftover bridges. Named re-exports on the published compatibility facade stay: they are the v1 root export surface locked by
test/compatibility/v1-baseline.test.ts.Freeze confirmation
--json/ aliases / exit codes / state v2 / receipt untouched--jsondoes not exposeengine/routecreateQuantexrelease-core.yml/ protect-main untouchedrelease-one-line-delivery,release-pr-skip-human-heuristics,windows-ci-advisory-merge-gate)restore-managed-update-and-resume-releasesuntouchedconfig/capabilities/commands/schemasrc/lifecycle/Linked Artifacts
docs/adr/0014-core-internal-lifecycle-barrel-deletion.md(L4 already deleted the barrel; this PR does not restore it)Validation
bun run memory:checkbun run lintbun run format:checkbun run typecheckbun run test— 176 files / 2152 passed / 5 skippedbun run openspec:validate— 25 passed / 0 failedinstall/ensure opencode --dry-run --json→ok=true,warnings[0].code=DRY_RUN,data.changed=false, exit0, noengine/route;upgrade --json --check→MANUAL_ACTION_REQUIREDon source install, noengine/route["createQuantex"]run_test_matrix=true/product-impactingd049304(classify + lint + governance + ubuntu/windows/macos + Agent Canaries); draft keptRelease Intent
Release Summary
Docs Updated
Scope Check
src/lifecycle/.Closure Check
Notes
src/services,src/compatibility,src/self, orsrc/idempotencymodules after L4 deletedsrc/lifecycle/.src/core/lifecycle/*paths so classify stays on the full ubuntu/windows/macos test matrix (protect-main unchanged).