chore: S1 KEEP leftover scan for thick-area zero-ref - #730
Merged
Conversation
Import-graph proof that src/agents, src/providers, src/package-manager, src/utils, src/agent-update, src/runtime, and related leftover barrels still have production importers and still add differential behavior. Delete none. Hang KEEP comments on existing product paths so classify stays on the macOS matrix. Do not restore src/lifecycle.
Keep repository-relative scan keys in POSIX form so the importer graph matches on windows-latest, where path.join uses backslashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-L5 S1 leftover scan of thick areas L5 did not cover:
src/agents,src/providers,src/package-manager,src/utils,src/agent-update,src/runtime, plus related leftover barrels (src/planning,src/inspection,src/state.ts,src/errors.ts,src/cli-context.ts,src/output). Import-graph proof that every scanned module still has a production importer and still adds differential behavior. Delete none. Keep every still-imported module and every bridge that still adds differential behavior.Intake: mechanical leftover scan / no observable behavior — no new OpenSpec change. Folding published v1 barrels,
config/capabilities/commands/schema, or restoringsrc/lifecycle/would be architecture-boundary work and would need OpenSpec; this PR documents that those folds are not safe.DELETE vs KEEP
src/lifecycle/src/core/lifecycle/index.tssrc/self/application.ts/src/services/self-upgrade.ts/src/services/lifecycle-updates.ts/src/services/lifecycle-execution.tssrc/agents/index.tsgetAllAgents/getAgentByLookupName).getAgentByNameOrAliasis the published v1 name. Generated catalog + withdrawn named exports stay on this barrel.src/agents/{types,catalog,schema,superseded}.tssrc/agents/generated/*src/agents/withdrawn/index.tsdeepcode/genie/jcode/vtcode). Not catalog members. Folding would change the published root surface.src/providers/index.tssrc/providers/{types,registry,first-party,invoke,internal-operation-context}.tssrc/providers/adapters/{brew,bun,cargo,deno,mise,npm,pip,uv,winget}.tsfirst-party.ts+installers.ts.src/providers/adapters/{registry-package,system-package,install-effect,pending-operation}.tssrc/package-manager/index.tssrc/package-manager/capabilities.tssrc/commands/capabilities.src/package-manager/managed-install-types.tssrc/statemust not depend on providers.src/package-manager/{installers,context-mutation,mutation-outcome,binary}.tssrc/package-manager/{brew,bun,cargo,deno,mise,npm,pip,uv,winget}.tsinstallers.ts, and Core installation-provider-registry.src/utils/install.tssrc/utils/exec.tsexecCommand. Thin CLI stdio wrapper, frozen root export.src/utils/{child-process,cli-child-process,detect,version,lock,color,registry,network,duration,compare-versions,executable-resolution,executable-search-paths,lifecycle-errors,user-output}.tssrc/agent-update/index.tssrc/agent-update/{providers,messages,self-update,types}.tssrc/runtime/index.tssrc/runtime/{ports,cli-operation-context,agent-process,child-process,fetch-network,invocation-context,version-cache}.tssrc/planning/index.ts/src/planning/updates.tssrc/inspection/index.ts/src/inspection/agents.tssrc/state.tssrc/state/index. Frozen state v2.src/errors.tssrc/cli-context.ts--json/ color / timeout).src/output/{index,types,human}.tsengine/route.src/commands/{capabilities,commands,schema}.ts/src/config/packages/core/src/{index,internal}.tsDELETE: none (0 zero-reference modules and 0 pure pass-through leftover wrappers after #729).
Same-file helpers that look unused from outside stay: they are live internals, not leftover bridges. Named re-exports on the published compatibility facade stay: they are the v1 root export surface locked by
test/compatibility/v1-baseline.test.ts. Convenience barrels with live importers (src/runtime,src/planning,src/inspection,src/state.ts) stay: inlining them would churn published and internal import paths without removing leftover behavior.Freeze confirmation
--json/ aliases / exit codes / state v2 / receipt untouched--jsondoes not exposeengine/routecreateQuantexrelease-core.yml/ protect-main untouchedrelease-one-line-delivery,release-pr-skip-human-heuristics,windows-ci-advisory-merge-gate)restore-managed-update-and-resume-releasesuntouchedconfig/capabilities/commands/schemasrc/lifecycle/Linked Artifacts
docs/adr/0014-core-internal-lifecycle-barrel-deletion.md(L4 already deleted the barrel; this PR does not restore it)Validation
bun run memory:checkbun run lintbun run format:checkbun run typecheckbun run test— 177 files / 2159 passed / 5 skippedbun run openspec:validate— 25 passed / 0 failedinstall/ensure opencode --dry-run --json→ok=true,warnings[0].code=DRY_RUN,data.changed=false, exit0, noengine/route;upgrade --json --check→MANUAL_ACTION_REQUIREDon source install, noengine/route["createQuantex"]run_test_matrix=true/product-impacting714c47d(classify + lint + governance + ubuntu/windows/macos + Agent Canaries); draft keptRelease Intent
Release Summary
Docs Updated
Scope Check
src/lifecycle/.Closure Check
Notes
src/agents,src/providers,src/package-manager,src/utils,src/agent-update,src/runtime,src/planning,src/inspection, andsrc/state.tspaths so classify stays on the full ubuntu/windows/macos test matrix (protect-main unchanged).