Resolving missing module - #167

Merged
gamesh411 merged 2 commits into
Ericsson:masterfrom
vodorok:new_java_patch
Sep 11, 2019
Merged

Resolving missing module#167
gamesh411 merged 2 commits into
Ericsson:masterfrom
vodorok:new_java_patch

Conversation

@vodorok

@vodorokvodorok commented Jul 2, 2019•
edited
Loading

Copy link
Copy Markdown
Collaborator

!!!
Bumped minimal required eclipse to 4.8 Photon
!!!

This from this eclipse version a newer java support is enabled.
See more at: https://projects.eclipse.org/projects/eclipse/releases/4.8.0

Bumped Tycho to 1.4.0.
Added Javax.annotation bundle to target platform.
Added vmargs to the integration test pom.xml.
Added profiles to jdk 8, 9, 10 & 11.

Fix for the missing dependency with java 11 in the integration test phase.
Referenced in:

Resolves#164
And depends on #166

@vodorok
vodorok requested a review from gyorbJuly 2, 2019 15:06
@vodorok
vodorokforce-pushed the new_java_patch branch 15 times, most recently from 0c3f7ca to 1bf4757CompareJuly 4, 2019 10:10
@vodorokvodorok mentioned this pull request Jul 4, 2019
Closed
@vodorok
vodorokforce-pushed the new_java_patch branch 5 times, most recently from 2de0845 to 23664a8CompareJuly 4, 2019 13:02
@gyorbgyorb mentioned this pull request Jul 5, 2019
Closed
gyorb
gyorb suggested changes Jul 5, 2019
View reviewed changes
Comment threadreadme.md
* Linux operating system
* Recent [CodeChecker](https://github.com/Ericsson/codechecker) (6.8.0 and up)
* Every eclipse version since [Oxygen 1](https://www.eclipse.org/downloads/packages/release/oxygen/1) (v4.7.0) is supported
* Every eclipse version since [Phtoton](https://www.eclipse.org/downloads/packages/release/photon/r) (v4.8.0) is supported

@gyorbgyorbJul 5, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split up the documentation to be more explicit what are the plugin build requirements and what is the runtime requirement for it.

This change mainly effects the build environment if I'm right.

@vodorokvodorokJul 24, 2019

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that!
But for the current setup of the compilation, we only test for one target platform, so until we create a deeper matrix with separate, older (newer) target platforms, we can't be sure the plugin works on older releases, even though we won't use newer features. I'll create an issue regarding this problem.
Until then, I can extend the readme with a note that it should work on Oxygen.

@gyorbgyorb mentioned this pull request Jul 5, 2019
Closed
@vodorokvodorok mentioned this pull request Jul 24, 2019
Open
vodorok
vodorok commented Jul 24, 2019
View reviewed changes
Comment threadtests/org.codechecker.eclipse.rcp.it.tests/pom.xml
</plugin>
</plugins>
</build>
<profiles>

@vodorokvodorokJul 24, 2019•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use different configurations depending on the jdk versions. Maven profiles can only alter build segments, that's why this segment got a little bit verbose.

@vodorok

vodorok commented Jul 24, 2019•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Resolves the first part of #132 (update the currently used Tycho version to a newer (latest?)) 1.4.0 is the latest right now.

@vodorokvodorok added seq 2 and removed seq 3 labels Aug 26, 2019
@vodorok
Test with multiple jdk verisons in travis
c030675
Need to symlink the system CA certificates if necessary.
on openjdk9+.
openjdk9 is allowed to fail because of its fragility.
See more: athttps://www.deps.co/guides/travis-ci-latest-java/
@vodorok
vodorokforce-pushed the new_java_patch branch 2 times, most recently from 43e3e89 to 9fc78fcCompareSeptember 4, 2019 11:11
@EricssonEricsson deleted a comment Sep 4, 2019
@EricssonEricsson deleted a comment Sep 4, 2019
@EricssonEricsson deleted a comment Sep 4, 2019
@EricssonEricsson deleted a comment Sep 4, 2019
@vodorok
Resolving missing module
f2a78bb
This from this eclipse version a newer java support is enabled.
See more at: https://projects.eclipse.org/projects/eclipse/releases/4.8.0
Bumped Tycho to 1.4.0.
Added Javax.annotation bundle to target platform.
Added vmargs to the integration test pom.xml.
Added profiles to jdk 8, 9, 10 & 11.
Fix for the missing dependency with java 11 in the integration test phase.
Referenced in:
* https://wiki.eclipse.org/Tycho/Release_Notes/1.4
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=541403
@EricssonEricsson deleted a comment Sep 4, 2019
@EricssonEricsson deleted a comment Sep 4, 2019
@gamesh411
gamesh411 merged commit 0b5646d into Ericsson:masterSep 11, 2019
This was referenced Jan 14, 2020
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@gyorbgyorbgyorb requested changes
@gamesh411gamesh411gamesh411 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfixenhancementseq 2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Installation fails

3 participants

@vodorok@gamesh411@gyorb
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Resolving missing module - #167
Merged
gamesh411 merged 2 commits into
Ericsson:masterfrom 
vodorok:new_java_patch
Sep 11, 2019
Merged
Resolving missing module#167
gamesh411 merged 2 commits into
Ericsson:masterfrom 
vodorok:new_java_patch
Conversation
@vodorok
@vodorokvodorok
commented
Jul 2, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
!!!

Bumped minimal required eclipse to 4.8 Photon

!!!
This from this eclipse version a newer java support is enabled.

See more at: https://projects.eclipse.org/projects/eclipse/releases/4.8.0
Bumped Tycho to 1.4.0.

Added Javax.annotation bundle to target platform.

Added vmargs to the integration test pom.xml.

Added profiles to jdk 8, 9, 10 & 11.
Fix for the missing dependency with java 11 in the integration test phase.

Referenced in:
Resolves#164

And depends on #166
@vodorok
vodorok
requested a review
from gyorbJuly 2, 2019 15:06
@vodorok
vodorokforce-pushed
the
new_java_patch
branch
15 times, most recently
from
0c3f7ca to
1bf4757CompareJuly 4, 2019 10:10
@vodorokvodorok
mentioned this pull request
Jul 4, 2019

Closed

@vodorok
vodorokforce-pushed
the
new_java_patch
branch
5 times, most recently
from
2de0845 to
23664a8CompareJuly 4, 2019 13:02
@gyorbgyorb
mentioned this pull request
Jul 5, 2019
 Closed

gyorb
gyorb
suggested changes
Jul 5, 2019
View reviewed changes
Comment threadreadme.md
* Linux operating system
* Recent [CodeChecker](https://github.com/Ericsson/codechecker) (6.8.0 and up)
* Every eclipse version since [Oxygen 1](https://www.eclipse.org/downloads/packages/release/oxygen/1) (v4.7.0) is supported
* Every eclipse version since [Phtoton](https://www.eclipse.org/downloads/packages/release/photon/r) (v4.8.0) is supported
@gyorbgyorbJul 5, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split up the documentation to be more explicit what are the plugin build requirements and what is the runtime requirement for it.
This change mainly effects the build environment if I'm right.
@vodorokvodorokJul 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that!

But for the current setup of the compilation, we only test for one target platform, so until we create a deeper matrix with separate, older (newer) target platforms, we can't be sure the plugin works on older releases, even though we won't use newer features. I'll create an issue regarding this problem.

Until then, I can extend the readme with a note that it should work on Oxygen.
@gyorbgyorb
mentioned this pull request
Jul 5, 2019
 Closed

@vodorokvodorok
mentioned this pull request
Jul 24, 2019
 Open

vodorok
vodorok
commented
Jul 24, 2019
View reviewed changes
Comment threadtests/org.codechecker.eclipse.rcp.it.tests/pom.xml
 </plugin>
 </plugins>
 </build>
 <profiles>
@vodorokvodorokJul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use different configurations depending on the jdk versions. Maven profiles can only alter build segments, that's why this segment got a little bit verbose.
@vodorok
vodorok
commented
Jul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Resolves the first part of #132 (update the currently used Tycho version to a newer (latest?)) 1.4.0 is the latest right now.
@vodorokvodorok
added

seq 2

and removed

seq 3

labels
Aug 26, 2019
@vodorok
Test with multiple jdk verisons in travis
c030675
Need to symlink the system CA certificates if necessary.
on openjdk9+.
openjdk9 is allowed to fail because of its fragility.
See more: athttps://www.deps.co/guides/travis-ci-latest-java/
@vodorok
vodorokforce-pushed
the
new_java_patch
branch
2 times, most recently
from
43e3e89 to
9fc78fcCompareSeptember 4, 2019 11:11
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@vodorok
Resolving missing module
f2a78bb
This from this eclipse version a newer java support is enabled.
See more at: https://projects.eclipse.org/projects/eclipse/releases/4.8.0
Bumped Tycho to 1.4.0.
Added Javax.annotation bundle to target platform.
Added vmargs to the integration test pom.xml.
Added profiles to jdk 8, 9, 10 & 11.
Fix for the missing dependency with java 11 in the integration test phase.
Referenced in:
* https://wiki.eclipse.org/Tycho/Release_Notes/1.4
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=541403
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@gamesh411
gamesh411
merged commit 0b5646d
into
Ericsson:masterSep 11, 2019

This was referenced Jan 14, 2020

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@gyorbgyorbgyorb requested changes
@gamesh411gamesh411gamesh411 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

bugfixenhancementseq 2

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Installation fails 

3 participants

@vodorok@gamesh411@gyorb

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Resolving missing module - #167
Merged
gamesh411 merged 2 commits into
Ericsson:masterfrom 
vodorok:new_java_patch
Sep 11, 2019
Merged
Resolving missing module#167
gamesh411 merged 2 commits into
Ericsson:masterfrom 
vodorok:new_java_patch
Conversation
@vodorok
@vodorokvodorok
commented
Jul 2, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
!!!

Bumped minimal required eclipse to 4.8 Photon

!!!
This from this eclipse version a newer java support is enabled.

See more at: https://projects.eclipse.org/projects/eclipse/releases/4.8.0
Bumped Tycho to 1.4.0.

Added Javax.annotation bundle to target platform.

Added vmargs to the integration test pom.xml.

Added profiles to jdk 8, 9, 10 & 11.
Fix for the missing dependency with java 11 in the integration test phase.

Referenced in:
Resolves#164

And depends on #166
@vodorok
vodorok
requested a review
from gyorbJuly 2, 2019 15:06
@vodorok
vodorokforce-pushed
the
new_java_patch
branch
15 times, most recently
from
0c3f7ca to
1bf4757CompareJuly 4, 2019 10:10
@vodorokvodorok
mentioned this pull request
Jul 4, 2019

Closed

@vodorok
vodorokforce-pushed
the
new_java_patch
branch
5 times, most recently
from
2de0845 to
23664a8CompareJuly 4, 2019 13:02
@gyorbgyorb
mentioned this pull request
Jul 5, 2019
 Closed

gyorb
gyorb
suggested changes
Jul 5, 2019
View reviewed changes
Comment threadreadme.md
* Linux operating system
* Recent [CodeChecker](https://github.com/Ericsson/codechecker) (6.8.0 and up)
* Every eclipse version since [Oxygen 1](https://www.eclipse.org/downloads/packages/release/oxygen/1) (v4.7.0) is supported
* Every eclipse version since [Phtoton](https://www.eclipse.org/downloads/packages/release/photon/r) (v4.8.0) is supported
@gyorbgyorbJul 5, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split up the documentation to be more explicit what are the plugin build requirements and what is the runtime requirement for it.
This change mainly effects the build environment if I'm right.
@vodorokvodorokJul 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that!

But for the current setup of the compilation, we only test for one target platform, so until we create a deeper matrix with separate, older (newer) target platforms, we can't be sure the plugin works on older releases, even though we won't use newer features. I'll create an issue regarding this problem.

Until then, I can extend the readme with a note that it should work on Oxygen.
@gyorbgyorb
mentioned this pull request
Jul 5, 2019
 Closed

@vodorokvodorok
mentioned this pull request
Jul 24, 2019
 Open

vodorok
vodorok
commented
Jul 24, 2019
View reviewed changes
Comment threadtests/org.codechecker.eclipse.rcp.it.tests/pom.xml
 </plugin>
 </plugins>
 </build>
 <profiles>
@vodorokvodorokJul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use different configurations depending on the jdk versions. Maven profiles can only alter build segments, that's why this segment got a little bit verbose.
@vodorok
vodorok
commented
Jul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Resolves the first part of #132 (update the currently used Tycho version to a newer (latest?)) 1.4.0 is the latest right now.
@vodorokvodorok
added

seq 2

and removed

seq 3

labels
Aug 26, 2019
@vodorok
Test with multiple jdk verisons in travis
c030675
Need to symlink the system CA certificates if necessary.
on openjdk9+.
openjdk9 is allowed to fail because of its fragility.
See more: athttps://www.deps.co/guides/travis-ci-latest-java/
@vodorok
vodorokforce-pushed
the
new_java_patch
branch
2 times, most recently
from
43e3e89 to
9fc78fcCompareSeptember 4, 2019 11:11
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@vodorok
Resolving missing module
f2a78bb
This from this eclipse version a newer java support is enabled.
See more at: https://projects.eclipse.org/projects/eclipse/releases/4.8.0
Bumped Tycho to 1.4.0.
Added Javax.annotation bundle to target platform.
Added vmargs to the integration test pom.xml.
Added profiles to jdk 8, 9, 10 & 11.
Fix for the missing dependency with java 11 in the integration test phase.
Referenced in:
* https://wiki.eclipse.org/Tycho/Release_Notes/1.4
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=541403
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@gamesh411
gamesh411
merged commit 0b5646d
into
Ericsson:masterSep 11, 2019

This was referenced Jan 14, 2020

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@gyorbgyorbgyorb requested changes
@gamesh411gamesh411gamesh411 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

bugfixenhancementseq 2

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Installation fails 

3 participants

@vodorok@gamesh411@gyorb

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Resolving missing module - #167
Merged
gamesh411 merged 2 commits into
Ericsson:masterfrom 
vodorok:new_java_patch
Sep 11, 2019
Merged
Resolving missing module#167
gamesh411 merged 2 commits into
Ericsson:masterfrom 
vodorok:new_java_patch
Conversation
@vodorok
@vodorokvodorok
commented
Jul 2, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
!!!

Bumped minimal required eclipse to 4.8 Photon

!!!
This from this eclipse version a newer java support is enabled.

See more at: https://projects.eclipse.org/projects/eclipse/releases/4.8.0
Bumped Tycho to 1.4.0.

Added Javax.annotation bundle to target platform.

Added vmargs to the integration test pom.xml.

Added profiles to jdk 8, 9, 10 & 11.
Fix for the missing dependency with java 11 in the integration test phase.

Referenced in:
Resolves#164

And depends on #166
@vodorok
vodorok
requested a review
from gyorbJuly 2, 2019 15:06
@vodorok
vodorokforce-pushed
the
new_java_patch
branch
15 times, most recently
from
0c3f7ca to
1bf4757CompareJuly 4, 2019 10:10
@vodorokvodorok
mentioned this pull request
Jul 4, 2019

Closed

@vodorok
vodorokforce-pushed
the
new_java_patch
branch
5 times, most recently
from
2de0845 to
23664a8CompareJuly 4, 2019 13:02
@gyorbgyorb
mentioned this pull request
Jul 5, 2019
 Closed

gyorb
gyorb
suggested changes
Jul 5, 2019
View reviewed changes
Comment threadreadme.md
* Linux operating system
* Recent [CodeChecker](https://github.com/Ericsson/codechecker) (6.8.0 and up)
* Every eclipse version since [Oxygen 1](https://www.eclipse.org/downloads/packages/release/oxygen/1) (v4.7.0) is supported
* Every eclipse version since [Phtoton](https://www.eclipse.org/downloads/packages/release/photon/r) (v4.8.0) is supported
@gyorbgyorbJul 5, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split up the documentation to be more explicit what are the plugin build requirements and what is the runtime requirement for it.
This change mainly effects the build environment if I'm right.
@vodorokvodorokJul 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that!

But for the current setup of the compilation, we only test for one target platform, so until we create a deeper matrix with separate, older (newer) target platforms, we can't be sure the plugin works on older releases, even though we won't use newer features. I'll create an issue regarding this problem.

Until then, I can extend the readme with a note that it should work on Oxygen.
@gyorbgyorb
mentioned this pull request
Jul 5, 2019
 Closed

@vodorokvodorok
mentioned this pull request
Jul 24, 2019
 Open

vodorok
vodorok
commented
Jul 24, 2019
View reviewed changes
Comment threadtests/org.codechecker.eclipse.rcp.it.tests/pom.xml
 </plugin>
 </plugins>
 </build>
 <profiles>
@vodorokvodorokJul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use different configurations depending on the jdk versions. Maven profiles can only alter build segments, that's why this segment got a little bit verbose.
@vodorok
vodorok
commented
Jul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Resolves the first part of #132 (update the currently used Tycho version to a newer (latest?)) 1.4.0 is the latest right now.
@vodorokvodorok
added

seq 2

and removed

seq 3

labels
Aug 26, 2019
@vodorok
Test with multiple jdk verisons in travis
c030675
Need to symlink the system CA certificates if necessary.
on openjdk9+.
openjdk9 is allowed to fail because of its fragility.
See more: athttps://www.deps.co/guides/travis-ci-latest-java/
@vodorok
vodorokforce-pushed
the
new_java_patch
branch
2 times, most recently
from
43e3e89 to
9fc78fcCompareSeptember 4, 2019 11:11
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@vodorok
Resolving missing module
f2a78bb
This from this eclipse version a newer java support is enabled.
See more at: https://projects.eclipse.org/projects/eclipse/releases/4.8.0
Bumped Tycho to 1.4.0.
Added Javax.annotation bundle to target platform.
Added vmargs to the integration test pom.xml.
Added profiles to jdk 8, 9, 10 & 11.
Fix for the missing dependency with java 11 in the integration test phase.
Referenced in:
* https://wiki.eclipse.org/Tycho/Release_Notes/1.4
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=541403
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@gamesh411
gamesh411
merged commit 0b5646d
into
Ericsson:masterSep 11, 2019

This was referenced Jan 14, 2020

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@gyorbgyorbgyorb requested changes
@gamesh411gamesh411gamesh411 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

bugfixenhancementseq 2

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Installation fails 

3 participants

@vodorok@gamesh411@gyorb

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Resolving missing module - #167
Merged
gamesh411 merged 2 commits into
Ericsson:masterfrom 
vodorok:new_java_patch
Sep 11, 2019
Merged
Resolving missing module#167
gamesh411 merged 2 commits into
Ericsson:masterfrom 
vodorok:new_java_patch
Conversation
@vodorok
@vodorokvodorok
commented
Jul 2, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
!!!

Bumped minimal required eclipse to 4.8 Photon

!!!
This from this eclipse version a newer java support is enabled.

See more at: https://projects.eclipse.org/projects/eclipse/releases/4.8.0
Bumped Tycho to 1.4.0.

Added Javax.annotation bundle to target platform.

Added vmargs to the integration test pom.xml.

Added profiles to jdk 8, 9, 10 & 11.
Fix for the missing dependency with java 11 in the integration test phase.

Referenced in:
Resolves#164

And depends on #166
@vodorok
vodorok
requested a review
from gyorbJuly 2, 2019 15:06
@vodorok
vodorokforce-pushed
the
new_java_patch
branch
15 times, most recently
from
0c3f7ca to
1bf4757CompareJuly 4, 2019 10:10
@vodorokvodorok
mentioned this pull request
Jul 4, 2019

Closed

@vodorok
vodorokforce-pushed
the
new_java_patch
branch
5 times, most recently
from
2de0845 to
23664a8CompareJuly 4, 2019 13:02
@gyorbgyorb
mentioned this pull request
Jul 5, 2019
 Closed

gyorb
gyorb
suggested changes
Jul 5, 2019
View reviewed changes
Comment threadreadme.md
* Linux operating system
* Recent [CodeChecker](https://github.com/Ericsson/codechecker) (6.8.0 and up)
* Every eclipse version since [Oxygen 1](https://www.eclipse.org/downloads/packages/release/oxygen/1) (v4.7.0) is supported
* Every eclipse version since [Phtoton](https://www.eclipse.org/downloads/packages/release/photon/r) (v4.8.0) is supported
@gyorbgyorbJul 5, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split up the documentation to be more explicit what are the plugin build requirements and what is the runtime requirement for it.
This change mainly effects the build environment if I'm right.
@vodorokvodorokJul 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that!

But for the current setup of the compilation, we only test for one target platform, so until we create a deeper matrix with separate, older (newer) target platforms, we can't be sure the plugin works on older releases, even though we won't use newer features. I'll create an issue regarding this problem.

Until then, I can extend the readme with a note that it should work on Oxygen.
@gyorbgyorb
mentioned this pull request
Jul 5, 2019
 Closed

@vodorokvodorok
mentioned this pull request
Jul 24, 2019
 Open

vodorok
vodorok
commented
Jul 24, 2019
View reviewed changes
Comment threadtests/org.codechecker.eclipse.rcp.it.tests/pom.xml
 </plugin>
 </plugins>
 </build>
 <profiles>
@vodorokvodorokJul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use different configurations depending on the jdk versions. Maven profiles can only alter build segments, that's why this segment got a little bit verbose.
@vodorok
vodorok
commented
Jul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Resolves the first part of #132 (update the currently used Tycho version to a newer (latest?)) 1.4.0 is the latest right now.
@vodorokvodorok
added

seq 2

and removed

seq 3

labels
Aug 26, 2019
@vodorok
Test with multiple jdk verisons in travis
c030675
Need to symlink the system CA certificates if necessary.
on openjdk9+.
openjdk9 is allowed to fail because of its fragility.
See more: athttps://www.deps.co/guides/travis-ci-latest-java/
@vodorok
vodorokforce-pushed
the
new_java_patch
branch
2 times, most recently
from
43e3e89 to
9fc78fcCompareSeptember 4, 2019 11:11
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@vodorok
Resolving missing module
f2a78bb
This from this eclipse version a newer java support is enabled.
See more at: https://projects.eclipse.org/projects/eclipse/releases/4.8.0
Bumped Tycho to 1.4.0.
Added Javax.annotation bundle to target platform.
Added vmargs to the integration test pom.xml.
Added profiles to jdk 8, 9, 10 & 11.
Fix for the missing dependency with java 11 in the integration test phase.
Referenced in:
* https://wiki.eclipse.org/Tycho/Release_Notes/1.4
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=541403
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@gamesh411
gamesh411
merged commit 0b5646d
into
Ericsson:masterSep 11, 2019

This was referenced Jan 14, 2020

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@gyorbgyorbgyorb requested changes
@gamesh411gamesh411gamesh411 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

bugfixenhancementseq 2

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Installation fails 

3 participants

@vodorok@gamesh411@gyorb

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Resolving missing module - #167
Merged
gamesh411 merged 2 commits into
Ericsson:masterfrom 
vodorok:new_java_patch
Sep 11, 2019
Merged
Resolving missing module#167
gamesh411 merged 2 commits into
Ericsson:masterfrom 
vodorok:new_java_patch
Conversation
@vodorok
@vodorokvodorok
commented
Jul 2, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
!!!

Bumped minimal required eclipse to 4.8 Photon

!!!
This from this eclipse version a newer java support is enabled.

See more at: https://projects.eclipse.org/projects/eclipse/releases/4.8.0
Bumped Tycho to 1.4.0.

Added Javax.annotation bundle to target platform.

Added vmargs to the integration test pom.xml.

Added profiles to jdk 8, 9, 10 & 11.
Fix for the missing dependency with java 11 in the integration test phase.

Referenced in:
Resolves#164

And depends on #166
@vodorok
vodorok
requested a review
from gyorbJuly 2, 2019 15:06
@vodorok
vodorokforce-pushed
the
new_java_patch
branch
15 times, most recently
from
0c3f7ca to
1bf4757CompareJuly 4, 2019 10:10
@vodorokvodorok
mentioned this pull request
Jul 4, 2019

Closed

@vodorok
vodorokforce-pushed
the
new_java_patch
branch
5 times, most recently
from
2de0845 to
23664a8CompareJuly 4, 2019 13:02
@gyorbgyorb
mentioned this pull request
Jul 5, 2019
 Closed

gyorb
gyorb
suggested changes
Jul 5, 2019
View reviewed changes
Comment threadreadme.md
* Linux operating system
* Recent [CodeChecker](https://github.com/Ericsson/codechecker) (6.8.0 and up)
* Every eclipse version since [Oxygen 1](https://www.eclipse.org/downloads/packages/release/oxygen/1) (v4.7.0) is supported
* Every eclipse version since [Phtoton](https://www.eclipse.org/downloads/packages/release/photon/r) (v4.8.0) is supported
@gyorbgyorbJul 5, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split up the documentation to be more explicit what are the plugin build requirements and what is the runtime requirement for it.
This change mainly effects the build environment if I'm right.
@vodorokvodorokJul 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that!

But for the current setup of the compilation, we only test for one target platform, so until we create a deeper matrix with separate, older (newer) target platforms, we can't be sure the plugin works on older releases, even though we won't use newer features. I'll create an issue regarding this problem.

Until then, I can extend the readme with a note that it should work on Oxygen.
@gyorbgyorb
mentioned this pull request
Jul 5, 2019
 Closed

@vodorokvodorok
mentioned this pull request
Jul 24, 2019
 Open

vodorok
vodorok
commented
Jul 24, 2019
View reviewed changes
Comment threadtests/org.codechecker.eclipse.rcp.it.tests/pom.xml
 </plugin>
 </plugins>
 </build>
 <profiles>
@vodorokvodorokJul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use different configurations depending on the jdk versions. Maven profiles can only alter build segments, that's why this segment got a little bit verbose.
@vodorok
vodorok
commented
Jul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Resolves the first part of #132 (update the currently used Tycho version to a newer (latest?)) 1.4.0 is the latest right now.
@vodorokvodorok
added

seq 2

and removed

seq 3

labels
Aug 26, 2019
@vodorok
Test with multiple jdk verisons in travis
c030675
Need to symlink the system CA certificates if necessary.
on openjdk9+.
openjdk9 is allowed to fail because of its fragility.
See more: athttps://www.deps.co/guides/travis-ci-latest-java/
@vodorok
vodorokforce-pushed
the
new_java_patch
branch
2 times, most recently
from
43e3e89 to
9fc78fcCompareSeptember 4, 2019 11:11
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@vodorok
Resolving missing module
f2a78bb
This from this eclipse version a newer java support is enabled.
See more at: https://projects.eclipse.org/projects/eclipse/releases/4.8.0
Bumped Tycho to 1.4.0.
Added Javax.annotation bundle to target platform.
Added vmargs to the integration test pom.xml.
Added profiles to jdk 8, 9, 10 & 11.
Fix for the missing dependency with java 11 in the integration test phase.
Referenced in:
* https://wiki.eclipse.org/Tycho/Release_Notes/1.4
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=541403
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@gamesh411
gamesh411
merged commit 0b5646d
into
Ericsson:masterSep 11, 2019

This was referenced Jan 14, 2020

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@gyorbgyorbgyorb requested changes
@gamesh411gamesh411gamesh411 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

bugfixenhancementseq 2

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Installation fails 

3 participants

@vodorok@gamesh411@gyorb

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Resolving missing module - #167
Merged
gamesh411 merged 2 commits into
Ericsson:masterfrom 
vodorok:new_java_patch
Sep 11, 2019
Merged
Resolving missing module#167
gamesh411 merged 2 commits into
Ericsson:masterfrom 
vodorok:new_java_patch
Conversation
@vodorok
@vodorokvodorok
commented
Jul 2, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
!!!

Bumped minimal required eclipse to 4.8 Photon

!!!
This from this eclipse version a newer java support is enabled.

See more at: https://projects.eclipse.org/projects/eclipse/releases/4.8.0
Bumped Tycho to 1.4.0.

Added Javax.annotation bundle to target platform.

Added vmargs to the integration test pom.xml.

Added profiles to jdk 8, 9, 10 & 11.
Fix for the missing dependency with java 11 in the integration test phase.

Referenced in:
Resolves#164

And depends on #166
@vodorok
vodorok
requested a review
from gyorbJuly 2, 2019 15:06
@vodorok
vodorokforce-pushed
the
new_java_patch
branch
15 times, most recently
from
0c3f7ca to
1bf4757CompareJuly 4, 2019 10:10
@vodorokvodorok
mentioned this pull request
Jul 4, 2019

Closed

@vodorok
vodorokforce-pushed
the
new_java_patch
branch
5 times, most recently
from
2de0845 to
23664a8CompareJuly 4, 2019 13:02
@gyorbgyorb
mentioned this pull request
Jul 5, 2019
 Closed

gyorb
gyorb
suggested changes
Jul 5, 2019
View reviewed changes
Comment threadreadme.md
* Linux operating system
* Recent [CodeChecker](https://github.com/Ericsson/codechecker) (6.8.0 and up)
* Every eclipse version since [Oxygen 1](https://www.eclipse.org/downloads/packages/release/oxygen/1) (v4.7.0) is supported
* Every eclipse version since [Phtoton](https://www.eclipse.org/downloads/packages/release/photon/r) (v4.8.0) is supported
@gyorbgyorbJul 5, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split up the documentation to be more explicit what are the plugin build requirements and what is the runtime requirement for it.
This change mainly effects the build environment if I'm right.
@vodorokvodorokJul 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that!

But for the current setup of the compilation, we only test for one target platform, so until we create a deeper matrix with separate, older (newer) target platforms, we can't be sure the plugin works on older releases, even though we won't use newer features. I'll create an issue regarding this problem.

Until then, I can extend the readme with a note that it should work on Oxygen.
@gyorbgyorb
mentioned this pull request
Jul 5, 2019
 Closed

@vodorokvodorok
mentioned this pull request
Jul 24, 2019
 Open

vodorok
vodorok
commented
Jul 24, 2019
View reviewed changes
Comment threadtests/org.codechecker.eclipse.rcp.it.tests/pom.xml
 </plugin>
 </plugins>
 </build>
 <profiles>
@vodorokvodorokJul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use different configurations depending on the jdk versions. Maven profiles can only alter build segments, that's why this segment got a little bit verbose.
@vodorok
vodorok
commented
Jul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Resolves the first part of #132 (update the currently used Tycho version to a newer (latest?)) 1.4.0 is the latest right now.
@vodorokvodorok
added

seq 2

and removed

seq 3

labels
Aug 26, 2019
@vodorok
Test with multiple jdk verisons in travis
c030675
Need to symlink the system CA certificates if necessary.
on openjdk9+.
openjdk9 is allowed to fail because of its fragility.
See more: athttps://www.deps.co/guides/travis-ci-latest-java/
@vodorok
vodorokforce-pushed
the
new_java_patch
branch
2 times, most recently
from
43e3e89 to
9fc78fcCompareSeptember 4, 2019 11:11
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@vodorok
Resolving missing module
f2a78bb
This from this eclipse version a newer java support is enabled.
See more at: https://projects.eclipse.org/projects/eclipse/releases/4.8.0
Bumped Tycho to 1.4.0.
Added Javax.annotation bundle to target platform.
Added vmargs to the integration test pom.xml.
Added profiles to jdk 8, 9, 10 & 11.
Fix for the missing dependency with java 11 in the integration test phase.
Referenced in:
* https://wiki.eclipse.org/Tycho/Release_Notes/1.4
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=541403
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@gamesh411
gamesh411
merged commit 0b5646d
into
Ericsson:masterSep 11, 2019

This was referenced Jan 14, 2020

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@gyorbgyorbgyorb requested changes
@gamesh411gamesh411gamesh411 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

bugfixenhancementseq 2

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Installation fails 

3 participants

@vodorok@gamesh411@gyorb

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Resolving missing module - #167
Merged
gamesh411 merged 2 commits into
Ericsson:masterfrom 
vodorok:new_java_patch
Sep 11, 2019
Merged
Resolving missing module#167
gamesh411 merged 2 commits into
Ericsson:masterfrom 
vodorok:new_java_patch
Conversation
@vodorok
@vodorokvodorok
commented
Jul 2, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
!!!

Bumped minimal required eclipse to 4.8 Photon

!!!
This from this eclipse version a newer java support is enabled.

See more at: https://projects.eclipse.org/projects/eclipse/releases/4.8.0
Bumped Tycho to 1.4.0.

Added Javax.annotation bundle to target platform.

Added vmargs to the integration test pom.xml.

Added profiles to jdk 8, 9, 10 & 11.
Fix for the missing dependency with java 11 in the integration test phase.

Referenced in:
Resolves#164

And depends on #166
@vodorok
vodorok
requested a review
from gyorbJuly 2, 2019 15:06
@vodorok
vodorokforce-pushed
the
new_java_patch
branch
15 times, most recently
from
0c3f7ca to
1bf4757CompareJuly 4, 2019 10:10
@vodorokvodorok
mentioned this pull request
Jul 4, 2019

Closed

@vodorok
vodorokforce-pushed
the
new_java_patch
branch
5 times, most recently
from
2de0845 to
23664a8CompareJuly 4, 2019 13:02
@gyorbgyorb
mentioned this pull request
Jul 5, 2019
 Closed

gyorb
gyorb
suggested changes
Jul 5, 2019
View reviewed changes
Comment threadreadme.md
* Linux operating system
* Recent [CodeChecker](https://github.com/Ericsson/codechecker) (6.8.0 and up)
* Every eclipse version since [Oxygen 1](https://www.eclipse.org/downloads/packages/release/oxygen/1) (v4.7.0) is supported
* Every eclipse version since [Phtoton](https://www.eclipse.org/downloads/packages/release/photon/r) (v4.8.0) is supported
@gyorbgyorbJul 5, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split up the documentation to be more explicit what are the plugin build requirements and what is the runtime requirement for it.
This change mainly effects the build environment if I'm right.
@vodorokvodorokJul 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that!

But for the current setup of the compilation, we only test for one target platform, so until we create a deeper matrix with separate, older (newer) target platforms, we can't be sure the plugin works on older releases, even though we won't use newer features. I'll create an issue regarding this problem.

Until then, I can extend the readme with a note that it should work on Oxygen.
@gyorbgyorb
mentioned this pull request
Jul 5, 2019
 Closed

@vodorokvodorok
mentioned this pull request
Jul 24, 2019
 Open

vodorok
vodorok
commented
Jul 24, 2019
View reviewed changes
Comment threadtests/org.codechecker.eclipse.rcp.it.tests/pom.xml
 </plugin>
 </plugins>
 </build>
 <profiles>
@vodorokvodorokJul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use different configurations depending on the jdk versions. Maven profiles can only alter build segments, that's why this segment got a little bit verbose.
@vodorok
vodorok
commented
Jul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Resolves the first part of #132 (update the currently used Tycho version to a newer (latest?)) 1.4.0 is the latest right now.
@vodorokvodorok
added

seq 2

and removed

seq 3

labels
Aug 26, 2019
@vodorok
Test with multiple jdk verisons in travis
c030675
Need to symlink the system CA certificates if necessary.
on openjdk9+.
openjdk9 is allowed to fail because of its fragility.
See more: athttps://www.deps.co/guides/travis-ci-latest-java/
@vodorok
vodorokforce-pushed
the
new_java_patch
branch
2 times, most recently
from
43e3e89 to
9fc78fcCompareSeptember 4, 2019 11:11
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@vodorok
Resolving missing module
f2a78bb
This from this eclipse version a newer java support is enabled.
See more at: https://projects.eclipse.org/projects/eclipse/releases/4.8.0
Bumped Tycho to 1.4.0.
Added Javax.annotation bundle to target platform.
Added vmargs to the integration test pom.xml.
Added profiles to jdk 8, 9, 10 & 11.
Fix for the missing dependency with java 11 in the integration test phase.
Referenced in:
* https://wiki.eclipse.org/Tycho/Release_Notes/1.4
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=541403
@EricssonEricsson
deleted a comment
Sep 4, 2019
@EricssonEricsson
deleted a comment
Sep 4, 2019
@gamesh411
gamesh411
merged commit 0b5646d
into
Ericsson:masterSep 11, 2019

This was referenced Jan 14, 2020

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@gyorbgyorbgyorb requested changes
@gamesh411gamesh411gamesh411 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

bugfixenhancementseq 2

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Installation fails 

3 participants

@vodorok@gamesh411@gyorb