Resolving missing module#167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gamesh411 merged 2 commits into from
Sep 11, 2019
Merged

Resolving missing module #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c030675
Test with multiple jdk verisons in travis
vodorok Jul 2, 2019
f2a78bb
Resolving missing module
vodorok Jul 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,9 +3,23 @@ install: true
language: java
jdk:
- oraclejdk8
- oraclejdk9
- oraclejdk11
- openjdk8

env: DISPLAY=:99.0

matrix:
include:
- jdk: openjdk10
before_install:
- rm "${JAVA_HOME}/lib/security/cacerts"
- ln -s /etc/ssl/certs/java/cacerts "${JAVA_HOME}/lib/security/cacerts"
- jdk: openjdk11
before_install:
- rm "${JAVA_HOME}/lib/security/cacerts"
- ln -s /etc/ssl/certs/java/cacerts "${JAVA_HOME}/lib/security/cacerts"

before_install:
- sudo apt-get install at-spi2-core

Expand All@@ -18,4 +32,4 @@ script: mvn -f mavendeps/pom.xml p2:site && mvn clean verify
after_failure:
- cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.it.tests/target/work/data/.metadata/.log
- cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.it.tests/target/surefire-reports/*

- cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.unit.tests/target/work/configuration/*.log
9 changes: 7 additions & 2 deletions readme.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,10 +7,15 @@ This is a C/C++ code analysis plugin for Eclipse that shows bugs detected by the
## Requirements

* Linux operating system

* Recent [CodeChecker](https://github.com/Ericsson/codechecker) (6.8.0 and up)
* Every eclipse version since [Oxygen 1](https://www.eclipse.org/downloads/packages/release/oxygen/1) (v4.7.0) is supported

* Every eclipse version since [Phtoton](https://www.eclipse.org/downloads/packages/release/photon/r) (v4.8.0) is supported

@gyorbgyorbJul 5, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split up the documentation to be more explicit what are the plugin build requirements and what is the runtime requirement for it.

This change mainly effects the build environment if I'm right.

@vodorokvodorokJul 24, 2019

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that!
But for the current setup of the compilation, we only test for one target platform, so until we create a deeper matrix with separate, older (newer) target platforms, we can't be sure the plugin works on older releases, even though we won't use newer features. I'll create an issue regarding this problem.
Until then, I can extend the readme with a note that it should work on Oxygen.

* Should work with v4.7.0 Oxygen, but this version is untested currently.

* Eclipse CDT
* Java SE 1.8

* Java SE 1.8 (for building, an equivalent jdk).

## Build and install CodeChecker Eclipse Plugin

Expand Down
2 changes: 1 addition & 1 deletion releng/org.codechecker.eclipse.configuration/pom.xml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
<packaging>pom</packaging>

<properties>
<tycho.version>1.3.0</tycho.version>
<tycho.version>1.4.0</tycho.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>

Expand Down
12 changes: 6 additions & 6 deletions releng/org.codechecker.eclipse.target/org.codechecker.eclipse.target.target
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<?pde version="3.8"?><target name="org.codechecker.eclipse.target" sequenceNumber="32">
<?pde version="3.8"?><target name="org.codechecker.eclipse.target" sequenceNumber="33">
<locations>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.swtbot.eclipse.feature.group" version="2.7.0.201806111355"/>
Expand All@@ -19,17 +19,17 @@
<repository location="http://download.eclipse.org/tools/cdt/releases/9.3"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.equinox.sdk.feature.group" version="3.13.0.v20170531-1133"/>
<unit id="org.eclipse.sdk.ide" version="4.7.0.I20170612-0950"/>
<unit id="org.eclipse.swt.tools.feature.feature.group" version="3.106.0.v20170503-0851"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.7/"/>
<unit id="org.eclipse.equinox.sdk.feature.group" version="3.14.0.v20180518-2029"/>
<unit id="org.eclipse.sdk.ide" version="4.8.0.I20180611-0500"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.8/"/>
</location>
<location path="${project_loc}/../../mavendeps/target/repository" type="Directory"/>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="javax.annotation" version="1.2.0.v201602091430"/>
<unit id="org.hamcrest" version="1.1.0.v20090501071000"/>
<unit id="org.junit" version="4.12.0.v201504281640"/>
<unit id="org.mockito" version="1.9.5.v201605172210"/>
<repository location="http://download.eclipse.org/tools/orbit/downloads/drops/R20170516192513/repository"/>
</location>
<location path="${project_loc}/../../mavendeps/target/repository" type="Directory"/>
</locations>
</target>
3 changes: 2 additions & 1 deletion tests/org.codechecker.eclipse.rcp.it.tests/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,4 +13,5 @@ Require-Bundle: org.junit;bundle-version="4.12.0",
org.eclipse.swtbot.swt.finder;bundle-version="2.7.0",
org.eclipse.swtbot.eclipse.finder;bundle-version="2.7.0",
org.codechecker.eclipse.rcp.shared;bundle-version="1.0.0",
com.github.stefanbirkner.system-rules;bundle-version="1.19.0"
com.github.stefanbirkner.system-rules;bundle-version="1.19.0",
javax.annotation;bundle-version="1.2.0"
204 changes: 172 additions & 32 deletions tests/org.codechecker.eclipse.rcp.it.tests/pom.xml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,37 +13,177 @@
<version>1.0.0-SNAPSHOT</version>
<packaging>eclipse-test-plugin</packaging>

<build>
<plugins>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>target-platform-configuration</artifactId>
<version>${tycho.version}</version>
<configuration>
<dependency-resolution>
<extraRequirements>
<requirement>
<type>eclipse-feature</type>
<id>org.eclipse.cdt</id>
<versionRange>0.0.0</versionRange>
</requirement>
</extraRequirements>
</dependency-resolution>
</configuration>
</plugin>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-surefire-plugin</artifactId>
<version>${tycho.version}</version>
<configuration>
<useUIHarness>true</useUIHarness>
<useUIThread>false</useUIThread>
<product>org.codechecker.eclipse.feature</product>
<application>org.eclipse.ui.ide.workbench</application>
<testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
</configuration>
</plugin>
</plugins>
</build>
<profiles>

@vodorokvodorokJul 24, 2019•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use different configurations depending on the jdk versions. Maven profiles can only alter build segments, that's why this segment got a little bit verbose.

<profile>
<id>active-on-jdk-8</id>
<activation>
<jdk>1.8</jdk>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>target-platform-configuration</artifactId>
<version>${tycho.version}</version>
<configuration>
<dependency-resolution>
<extraRequirements>
<requirement>
<type>eclipse-feature</type>
<id>org.eclipse.cdt</id>
<versionRange>0.0.0</versionRange>
</requirement>
</extraRequirements>
</dependency-resolution>
</configuration>
</plugin>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-surefire-plugin</artifactId>
<version>${tycho.version}</version>
<configuration>
<useUIHarness>true</useUIHarness>
<useUIThread>false</useUIThread>
<product>org.codechecker.eclipse.feature</product>
<application>org.eclipse.ui.ide.workbench</application>
<testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
</configuration>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>active-on-jdk-9</id>
<activation>
<jdk>9</jdk>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>target-platform-configuration</artifactId>
<version>${tycho.version}</version>
<configuration>
<dependency-resolution>
<extraRequirements>
<requirement>
<type>eclipse-feature</type>
<id>org.eclipse.cdt</id>
<versionRange>0.0.0</versionRange>
</requirement>
<!--requirement>
<type>eclipse-plugin</type>
<id>javax.annotation</id>
<versionRange>0.0.0</versionRange>
</requirement-->
</extraRequirements>
</dependency-resolution>
</configuration>
</plugin>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-surefire-plugin</artifactId>
<version>${tycho.version}</version>
<configuration>
<useUIHarness>true</useUIHarness>
<useUIThread>false</useUIThread>
<argLine>--add-modules=java.se.ee</argLine>
<product>org.codechecker.eclipse.feature</product>
<application>org.eclipse.ui.ide.workbench</application>
<testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
</configuration>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>active-on-jdk-10</id>
<activation>
<jdk>10</jdk>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>target-platform-configuration</artifactId>
<version>${tycho.version}</version>
<configuration>
<dependency-resolution>
<extraRequirements>
<requirement>
<type>eclipse-feature</type>
<id>org.eclipse.cdt</id>
<versionRange>0.0.0</versionRange>
</requirement>
<!--requirement>
<type>eclipse-plugin</type>
<id>javax.annotation</id>
<versionRange>1.2.0</versionRange>
</requirement-->
</extraRequirements>
</dependency-resolution>
</configuration>
</plugin>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-surefire-plugin</artifactId>
<version>${tycho.version}</version>
<configuration>
<useUIHarness>true</useUIHarness>
<useUIThread>false</useUIThread>
<argLine>--add-modules=ALL-SYSTEM</argLine>
<product>org.codechecker.eclipse.feature</product>
<application>org.eclipse.ui.ide.workbench</application>
<testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
</configuration>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>active-on-jdk-11</id>
<activation>
<jdk>11</jdk>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>target-platform-configuration</artifactId>
<version>${tycho.version}</version>
<configuration>
<dependency-resolution>
<extraRequirements>
<requirement>
<type>eclipse-feature</type>
<id>org.eclipse.cdt</id>
<versionRange>0.0.0</versionRange>
</requirement>
<requirement>
<type>eclipse-plugin</type>
<id>javax.annotation</id>
<versionRange>1.2.0</versionRange>
</requirement>
</extraRequirements>
</dependency-resolution>
</configuration>
</plugin>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-surefire-plugin</artifactId>
<version>${tycho.version}</version>
<configuration>
<useUIHarness>true</useUIHarness>
<useUIThread>false</useUIThread>
<argLine>--add-modules=ALL-SYSTEM</argLine>
<product>org.codechecker.eclipse.feature</product>
<application>org.eclipse.ui.ide.workbench</application>
<testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>

</project>
3 changes: 2 additions & 1 deletion tests/org.codechecker.eclipse.rcp.unit.tests/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,7 @@ Require-Bundle: org.junit,
org.objenesis;bundle-version="1.0.0",
org.codechecker.eclipse.rcp.shared;bundle-version="1.0.0",
com.google.guava,
com.github.stefanbirkner.system-rules;bundle-version="1.19.0"
com.github.stefanbirkner.system-rules;bundle-version="1.19.0",
javax.annotation;bundle-version="1.2.0"
Bundle-ClassPath: .,
resources/
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Resolving missing module#167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

gamesh411
merged 2 commits into

from

Sep 11, 2019
 Merged


Resolving missing module
#167
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
c030675

Test with multiple jdk verisons in travis


vodorok Jul 2, 2019
f2a78bb

Resolving missing module


vodorok Jul 2, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 15 additions & 1 deletion
.travis.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,9 +3,23 @@ install: true
language: java
jdk:
 - oraclejdk8
 - oraclejdk9
 - oraclejdk11
 - openjdk8

env: DISPLAY=:99.0

matrix:
 include:
 - jdk: openjdk10
 before_install:
 - rm "${JAVA_HOME}/lib/security/cacerts"
 - ln -s /etc/ssl/certs/java/cacerts "${JAVA_HOME}/lib/security/cacerts"
 - jdk: openjdk11
 before_install:
 - rm "${JAVA_HOME}/lib/security/cacerts"
 - ln -s /etc/ssl/certs/java/cacerts "${JAVA_HOME}/lib/security/cacerts"

before_install:
 - sudo apt-get install at-spi2-core

Expand All@@ -18,4 +32,4 @@ script: mvn -f mavendeps/pom.xml p2:site && mvn clean verify
after_failure:
 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.it.tests/target/work/data/.metadata/.log
 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.it.tests/target/surefire-reports/*

 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.unit.tests/target/work/configuration/*.log

9 changes: 7 additions & 2 deletions
readme.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,10 +7,15 @@ This is a C/C++ code analysis plugin for Eclipse that shows bugs detected by the
## Requirements

* Linux operating system

* Recent [CodeChecker](https://github.com/Ericsson/codechecker) (6.8.0 and up)
* Every eclipse version since [Oxygen 1](https://www.eclipse.org/downloads/packages/release/oxygen/1) (v4.7.0) is supported

* Every eclipse version since [Phtoton](https://www.eclipse.org/downloads/packages/release/photon/r) (v4.8.0) is supported
@gyorbgyorbJul 5, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split up the documentation to be more explicit what are the plugin build requirements and what is the runtime requirement for it.
This change mainly effects the build environment if I'm right.
@vodorokvodorokJul 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that!

But for the current setup of the compilation, we only test for one target platform, so until we create a deeper matrix with separate, older (newer) target platforms, we can't be sure the plugin works on older releases, even though we won't use newer features. I'll create an issue regarding this problem.

Until then, I can extend the readme with a note that it should work on Oxygen.
 * Should work with v4.7.0 Oxygen, but this version is untested currently.

* Eclipse CDT
* Java SE 1.8

* Java SE 1.8 (for building, an equivalent jdk).

## Build and install CodeChecker Eclipse Plugin

Expand Down

2 changes: 1 addition & 1 deletion
releng/org.codechecker.eclipse.configuration/pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
 <packaging>pom</packaging>

 <properties>
 <tycho.version>1.3.0</tycho.version>
 <tycho.version>1.4.0</tycho.version>
 <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 </properties>

Expand Down

12 changes: 6 additions & 6 deletions
releng/org.codechecker.eclipse.target/org.codechecker.eclipse.target.target

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<?pde version="3.8"?><target name="org.codechecker.eclipse.target" sequenceNumber="32">
<?pde version="3.8"?><target name="org.codechecker.eclipse.target" sequenceNumber="33">
<locations>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.swtbot.eclipse.feature.group" version="2.7.0.201806111355"/>
Expand All@@ -19,17 +19,17 @@
<repository location="http://download.eclipse.org/tools/cdt/releases/9.3"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.equinox.sdk.feature.group" version="3.13.0.v20170531-1133"/>
<unit id="org.eclipse.sdk.ide" version="4.7.0.I20170612-0950"/>
<unit id="org.eclipse.swt.tools.feature.feature.group" version="3.106.0.v20170503-0851"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.7/"/>
<unit id="org.eclipse.equinox.sdk.feature.group" version="3.14.0.v20180518-2029"/>
<unit id="org.eclipse.sdk.ide" version="4.8.0.I20180611-0500"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.8/"/>
</location>
<location path="${project_loc}/../../mavendeps/target/repository" type="Directory"/>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="javax.annotation" version="1.2.0.v201602091430"/>
<unit id="org.hamcrest" version="1.1.0.v20090501071000"/>
<unit id="org.junit" version="4.12.0.v201504281640"/>
<unit id="org.mockito" version="1.9.5.v201605172210"/>
<repository location="http://download.eclipse.org/tools/orbit/downloads/drops/R20170516192513/repository"/>
</location>
<location path="${project_loc}/../../mavendeps/target/repository" type="Directory"/>
</locations>
</target>

3 changes: 2 additions & 1 deletion
tests/org.codechecker.eclipse.rcp.it.tests/META-INF/MANIFEST.MF

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,4 +13,5 @@ Require-Bundle: org.junit;bundle-version="4.12.0",
 org.eclipse.swtbot.swt.finder;bundle-version="2.7.0",
 org.eclipse.swtbot.eclipse.finder;bundle-version="2.7.0",
 org.codechecker.eclipse.rcp.shared;bundle-version="1.0.0",
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0"
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0",
 javax.annotation;bundle-version="1.2.0"

204 changes: 172 additions & 32 deletions
tests/org.codechecker.eclipse.rcp.it.tests/pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,37 +13,177 @@
 <version>1.0.0-SNAPSHOT</version>
 <packaging>eclipse-test-plugin</packaging>

 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 <profiles>
@vodorokvodorokJul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use different configurations depending on the jdk versions. Maven profiles can only alter build segments, that's why this segment got a little bit verbose.
 <profile>
 <id>active-on-jdk-8</id>
 <activation>
 <jdk>1.8</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-9</id>
 <activation>
 <jdk>9</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <!--requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>0.0.0</versionRange>
 </requirement-->
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=java.se.ee</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-10</id>
 <activation>
 <jdk>10</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <!--requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>1.2.0</versionRange>
 </requirement-->
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=ALL-SYSTEM</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-11</id>
 <activation>
 <jdk>11</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>1.2.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=ALL-SYSTEM</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 </profiles>

</project>

3 changes: 2 additions & 1 deletion
tests/org.codechecker.eclipse.rcp.unit.tests/META-INF/MANIFEST.MF

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,7 @@ Require-Bundle: org.junit,
 org.objenesis;bundle-version="1.0.0",
 org.codechecker.eclipse.rcp.shared;bundle-version="1.0.0",
 com.google.guava,
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0"
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0",
 javax.annotation;bundle-version="1.2.0"
Bundle-ClassPath: .,
 resources/

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Resolving missing module#167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

gamesh411
merged 2 commits into

from

Sep 11, 2019
 Merged


Resolving missing module
#167
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
c030675

Test with multiple jdk verisons in travis


vodorok Jul 2, 2019
f2a78bb

Resolving missing module


vodorok Jul 2, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 15 additions & 1 deletion
.travis.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,9 +3,23 @@ install: true
language: java
jdk:
 - oraclejdk8
 - oraclejdk9
 - oraclejdk11
 - openjdk8

env: DISPLAY=:99.0

matrix:
 include:
 - jdk: openjdk10
 before_install:
 - rm "${JAVA_HOME}/lib/security/cacerts"
 - ln -s /etc/ssl/certs/java/cacerts "${JAVA_HOME}/lib/security/cacerts"
 - jdk: openjdk11
 before_install:
 - rm "${JAVA_HOME}/lib/security/cacerts"
 - ln -s /etc/ssl/certs/java/cacerts "${JAVA_HOME}/lib/security/cacerts"

before_install:
 - sudo apt-get install at-spi2-core

Expand All@@ -18,4 +32,4 @@ script: mvn -f mavendeps/pom.xml p2:site && mvn clean verify
after_failure:
 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.it.tests/target/work/data/.metadata/.log
 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.it.tests/target/surefire-reports/*

 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.unit.tests/target/work/configuration/*.log

9 changes: 7 additions & 2 deletions
readme.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,10 +7,15 @@ This is a C/C++ code analysis plugin for Eclipse that shows bugs detected by the
## Requirements

* Linux operating system

* Recent [CodeChecker](https://github.com/Ericsson/codechecker) (6.8.0 and up)
* Every eclipse version since [Oxygen 1](https://www.eclipse.org/downloads/packages/release/oxygen/1) (v4.7.0) is supported

* Every eclipse version since [Phtoton](https://www.eclipse.org/downloads/packages/release/photon/r) (v4.8.0) is supported
@gyorbgyorbJul 5, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split up the documentation to be more explicit what are the plugin build requirements and what is the runtime requirement for it.
This change mainly effects the build environment if I'm right.
@vodorokvodorokJul 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that!

But for the current setup of the compilation, we only test for one target platform, so until we create a deeper matrix with separate, older (newer) target platforms, we can't be sure the plugin works on older releases, even though we won't use newer features. I'll create an issue regarding this problem.

Until then, I can extend the readme with a note that it should work on Oxygen.
 * Should work with v4.7.0 Oxygen, but this version is untested currently.

* Eclipse CDT
* Java SE 1.8

* Java SE 1.8 (for building, an equivalent jdk).

## Build and install CodeChecker Eclipse Plugin

Expand Down

2 changes: 1 addition & 1 deletion
releng/org.codechecker.eclipse.configuration/pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
 <packaging>pom</packaging>

 <properties>
 <tycho.version>1.3.0</tycho.version>
 <tycho.version>1.4.0</tycho.version>
 <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 </properties>

Expand Down

12 changes: 6 additions & 6 deletions
releng/org.codechecker.eclipse.target/org.codechecker.eclipse.target.target

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<?pde version="3.8"?><target name="org.codechecker.eclipse.target" sequenceNumber="32">
<?pde version="3.8"?><target name="org.codechecker.eclipse.target" sequenceNumber="33">
<locations>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.swtbot.eclipse.feature.group" version="2.7.0.201806111355"/>
Expand All@@ -19,17 +19,17 @@
<repository location="http://download.eclipse.org/tools/cdt/releases/9.3"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.equinox.sdk.feature.group" version="3.13.0.v20170531-1133"/>
<unit id="org.eclipse.sdk.ide" version="4.7.0.I20170612-0950"/>
<unit id="org.eclipse.swt.tools.feature.feature.group" version="3.106.0.v20170503-0851"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.7/"/>
<unit id="org.eclipse.equinox.sdk.feature.group" version="3.14.0.v20180518-2029"/>
<unit id="org.eclipse.sdk.ide" version="4.8.0.I20180611-0500"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.8/"/>
</location>
<location path="${project_loc}/../../mavendeps/target/repository" type="Directory"/>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="javax.annotation" version="1.2.0.v201602091430"/>
<unit id="org.hamcrest" version="1.1.0.v20090501071000"/>
<unit id="org.junit" version="4.12.0.v201504281640"/>
<unit id="org.mockito" version="1.9.5.v201605172210"/>
<repository location="http://download.eclipse.org/tools/orbit/downloads/drops/R20170516192513/repository"/>
</location>
<location path="${project_loc}/../../mavendeps/target/repository" type="Directory"/>
</locations>
</target>

3 changes: 2 additions & 1 deletion
tests/org.codechecker.eclipse.rcp.it.tests/META-INF/MANIFEST.MF

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,4 +13,5 @@ Require-Bundle: org.junit;bundle-version="4.12.0",
 org.eclipse.swtbot.swt.finder;bundle-version="2.7.0",
 org.eclipse.swtbot.eclipse.finder;bundle-version="2.7.0",
 org.codechecker.eclipse.rcp.shared;bundle-version="1.0.0",
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0"
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0",
 javax.annotation;bundle-version="1.2.0"

204 changes: 172 additions & 32 deletions
tests/org.codechecker.eclipse.rcp.it.tests/pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,37 +13,177 @@
 <version>1.0.0-SNAPSHOT</version>
 <packaging>eclipse-test-plugin</packaging>

 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 <profiles>
@vodorokvodorokJul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use different configurations depending on the jdk versions. Maven profiles can only alter build segments, that's why this segment got a little bit verbose.
 <profile>
 <id>active-on-jdk-8</id>
 <activation>
 <jdk>1.8</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-9</id>
 <activation>
 <jdk>9</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <!--requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>0.0.0</versionRange>
 </requirement-->
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=java.se.ee</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-10</id>
 <activation>
 <jdk>10</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <!--requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>1.2.0</versionRange>
 </requirement-->
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=ALL-SYSTEM</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-11</id>
 <activation>
 <jdk>11</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>1.2.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=ALL-SYSTEM</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 </profiles>

</project>

3 changes: 2 additions & 1 deletion
tests/org.codechecker.eclipse.rcp.unit.tests/META-INF/MANIFEST.MF

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,7 @@ Require-Bundle: org.junit,
 org.objenesis;bundle-version="1.0.0",
 org.codechecker.eclipse.rcp.shared;bundle-version="1.0.0",
 com.google.guava,
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0"
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0",
 javax.annotation;bundle-version="1.2.0"
Bundle-ClassPath: .,
 resources/

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Resolving missing module#167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

gamesh411
merged 2 commits into

from

Sep 11, 2019
 Merged


Resolving missing module
#167
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
c030675

Test with multiple jdk verisons in travis


vodorok Jul 2, 2019
f2a78bb

Resolving missing module


vodorok Jul 2, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 15 additions & 1 deletion
.travis.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,9 +3,23 @@ install: true
language: java
jdk:
 - oraclejdk8
 - oraclejdk9
 - oraclejdk11
 - openjdk8

env: DISPLAY=:99.0

matrix:
 include:
 - jdk: openjdk10
 before_install:
 - rm "${JAVA_HOME}/lib/security/cacerts"
 - ln -s /etc/ssl/certs/java/cacerts "${JAVA_HOME}/lib/security/cacerts"
 - jdk: openjdk11
 before_install:
 - rm "${JAVA_HOME}/lib/security/cacerts"
 - ln -s /etc/ssl/certs/java/cacerts "${JAVA_HOME}/lib/security/cacerts"

before_install:
 - sudo apt-get install at-spi2-core

Expand All@@ -18,4 +32,4 @@ script: mvn -f mavendeps/pom.xml p2:site && mvn clean verify
after_failure:
 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.it.tests/target/work/data/.metadata/.log
 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.it.tests/target/surefire-reports/*

 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.unit.tests/target/work/configuration/*.log

9 changes: 7 additions & 2 deletions
readme.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,10 +7,15 @@ This is a C/C++ code analysis plugin for Eclipse that shows bugs detected by the
## Requirements

* Linux operating system

* Recent [CodeChecker](https://github.com/Ericsson/codechecker) (6.8.0 and up)
* Every eclipse version since [Oxygen 1](https://www.eclipse.org/downloads/packages/release/oxygen/1) (v4.7.0) is supported

* Every eclipse version since [Phtoton](https://www.eclipse.org/downloads/packages/release/photon/r) (v4.8.0) is supported
@gyorbgyorbJul 5, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split up the documentation to be more explicit what are the plugin build requirements and what is the runtime requirement for it.
This change mainly effects the build environment if I'm right.
@vodorokvodorokJul 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that!

But for the current setup of the compilation, we only test for one target platform, so until we create a deeper matrix with separate, older (newer) target platforms, we can't be sure the plugin works on older releases, even though we won't use newer features. I'll create an issue regarding this problem.

Until then, I can extend the readme with a note that it should work on Oxygen.
 * Should work with v4.7.0 Oxygen, but this version is untested currently.

* Eclipse CDT
* Java SE 1.8

* Java SE 1.8 (for building, an equivalent jdk).

## Build and install CodeChecker Eclipse Plugin

Expand Down

2 changes: 1 addition & 1 deletion
releng/org.codechecker.eclipse.configuration/pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
 <packaging>pom</packaging>

 <properties>
 <tycho.version>1.3.0</tycho.version>
 <tycho.version>1.4.0</tycho.version>
 <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 </properties>

Expand Down

12 changes: 6 additions & 6 deletions
releng/org.codechecker.eclipse.target/org.codechecker.eclipse.target.target

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<?pde version="3.8"?><target name="org.codechecker.eclipse.target" sequenceNumber="32">
<?pde version="3.8"?><target name="org.codechecker.eclipse.target" sequenceNumber="33">
<locations>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.swtbot.eclipse.feature.group" version="2.7.0.201806111355"/>
Expand All@@ -19,17 +19,17 @@
<repository location="http://download.eclipse.org/tools/cdt/releases/9.3"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.equinox.sdk.feature.group" version="3.13.0.v20170531-1133"/>
<unit id="org.eclipse.sdk.ide" version="4.7.0.I20170612-0950"/>
<unit id="org.eclipse.swt.tools.feature.feature.group" version="3.106.0.v20170503-0851"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.7/"/>
<unit id="org.eclipse.equinox.sdk.feature.group" version="3.14.0.v20180518-2029"/>
<unit id="org.eclipse.sdk.ide" version="4.8.0.I20180611-0500"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.8/"/>
</location>
<location path="${project_loc}/../../mavendeps/target/repository" type="Directory"/>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="javax.annotation" version="1.2.0.v201602091430"/>
<unit id="org.hamcrest" version="1.1.0.v20090501071000"/>
<unit id="org.junit" version="4.12.0.v201504281640"/>
<unit id="org.mockito" version="1.9.5.v201605172210"/>
<repository location="http://download.eclipse.org/tools/orbit/downloads/drops/R20170516192513/repository"/>
</location>
<location path="${project_loc}/../../mavendeps/target/repository" type="Directory"/>
</locations>
</target>

3 changes: 2 additions & 1 deletion
tests/org.codechecker.eclipse.rcp.it.tests/META-INF/MANIFEST.MF

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,4 +13,5 @@ Require-Bundle: org.junit;bundle-version="4.12.0",
 org.eclipse.swtbot.swt.finder;bundle-version="2.7.0",
 org.eclipse.swtbot.eclipse.finder;bundle-version="2.7.0",
 org.codechecker.eclipse.rcp.shared;bundle-version="1.0.0",
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0"
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0",
 javax.annotation;bundle-version="1.2.0"

204 changes: 172 additions & 32 deletions
tests/org.codechecker.eclipse.rcp.it.tests/pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,37 +13,177 @@
 <version>1.0.0-SNAPSHOT</version>
 <packaging>eclipse-test-plugin</packaging>

 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 <profiles>
@vodorokvodorokJul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use different configurations depending on the jdk versions. Maven profiles can only alter build segments, that's why this segment got a little bit verbose.
 <profile>
 <id>active-on-jdk-8</id>
 <activation>
 <jdk>1.8</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-9</id>
 <activation>
 <jdk>9</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <!--requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>0.0.0</versionRange>
 </requirement-->
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=java.se.ee</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-10</id>
 <activation>
 <jdk>10</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <!--requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>1.2.0</versionRange>
 </requirement-->
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=ALL-SYSTEM</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-11</id>
 <activation>
 <jdk>11</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>1.2.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=ALL-SYSTEM</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 </profiles>

</project>

3 changes: 2 additions & 1 deletion
tests/org.codechecker.eclipse.rcp.unit.tests/META-INF/MANIFEST.MF

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,7 @@ Require-Bundle: org.junit,
 org.objenesis;bundle-version="1.0.0",
 org.codechecker.eclipse.rcp.shared;bundle-version="1.0.0",
 com.google.guava,
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0"
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0",
 javax.annotation;bundle-version="1.2.0"
Bundle-ClassPath: .,
 resources/

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Resolving missing module#167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

gamesh411
merged 2 commits into

from

Sep 11, 2019
 Merged


Resolving missing module
#167
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
c030675

Test with multiple jdk verisons in travis


vodorok Jul 2, 2019
f2a78bb

Resolving missing module


vodorok Jul 2, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 15 additions & 1 deletion
.travis.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,9 +3,23 @@ install: true
language: java
jdk:
 - oraclejdk8
 - oraclejdk9
 - oraclejdk11
 - openjdk8

env: DISPLAY=:99.0

matrix:
 include:
 - jdk: openjdk10
 before_install:
 - rm "${JAVA_HOME}/lib/security/cacerts"
 - ln -s /etc/ssl/certs/java/cacerts "${JAVA_HOME}/lib/security/cacerts"
 - jdk: openjdk11
 before_install:
 - rm "${JAVA_HOME}/lib/security/cacerts"
 - ln -s /etc/ssl/certs/java/cacerts "${JAVA_HOME}/lib/security/cacerts"

before_install:
 - sudo apt-get install at-spi2-core

Expand All@@ -18,4 +32,4 @@ script: mvn -f mavendeps/pom.xml p2:site && mvn clean verify
after_failure:
 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.it.tests/target/work/data/.metadata/.log
 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.it.tests/target/surefire-reports/*

 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.unit.tests/target/work/configuration/*.log

9 changes: 7 additions & 2 deletions
readme.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,10 +7,15 @@ This is a C/C++ code analysis plugin for Eclipse that shows bugs detected by the
## Requirements

* Linux operating system

* Recent [CodeChecker](https://github.com/Ericsson/codechecker) (6.8.0 and up)
* Every eclipse version since [Oxygen 1](https://www.eclipse.org/downloads/packages/release/oxygen/1) (v4.7.0) is supported

* Every eclipse version since [Phtoton](https://www.eclipse.org/downloads/packages/release/photon/r) (v4.8.0) is supported
@gyorbgyorbJul 5, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split up the documentation to be more explicit what are the plugin build requirements and what is the runtime requirement for it.
This change mainly effects the build environment if I'm right.
@vodorokvodorokJul 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that!

But for the current setup of the compilation, we only test for one target platform, so until we create a deeper matrix with separate, older (newer) target platforms, we can't be sure the plugin works on older releases, even though we won't use newer features. I'll create an issue regarding this problem.

Until then, I can extend the readme with a note that it should work on Oxygen.
 * Should work with v4.7.0 Oxygen, but this version is untested currently.

* Eclipse CDT
* Java SE 1.8

* Java SE 1.8 (for building, an equivalent jdk).

## Build and install CodeChecker Eclipse Plugin

Expand Down

2 changes: 1 addition & 1 deletion
releng/org.codechecker.eclipse.configuration/pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
 <packaging>pom</packaging>

 <properties>
 <tycho.version>1.3.0</tycho.version>
 <tycho.version>1.4.0</tycho.version>
 <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 </properties>

Expand Down

12 changes: 6 additions & 6 deletions
releng/org.codechecker.eclipse.target/org.codechecker.eclipse.target.target

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<?pde version="3.8"?><target name="org.codechecker.eclipse.target" sequenceNumber="32">
<?pde version="3.8"?><target name="org.codechecker.eclipse.target" sequenceNumber="33">
<locations>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.swtbot.eclipse.feature.group" version="2.7.0.201806111355"/>
Expand All@@ -19,17 +19,17 @@
<repository location="http://download.eclipse.org/tools/cdt/releases/9.3"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.equinox.sdk.feature.group" version="3.13.0.v20170531-1133"/>
<unit id="org.eclipse.sdk.ide" version="4.7.0.I20170612-0950"/>
<unit id="org.eclipse.swt.tools.feature.feature.group" version="3.106.0.v20170503-0851"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.7/"/>
<unit id="org.eclipse.equinox.sdk.feature.group" version="3.14.0.v20180518-2029"/>
<unit id="org.eclipse.sdk.ide" version="4.8.0.I20180611-0500"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.8/"/>
</location>
<location path="${project_loc}/../../mavendeps/target/repository" type="Directory"/>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="javax.annotation" version="1.2.0.v201602091430"/>
<unit id="org.hamcrest" version="1.1.0.v20090501071000"/>
<unit id="org.junit" version="4.12.0.v201504281640"/>
<unit id="org.mockito" version="1.9.5.v201605172210"/>
<repository location="http://download.eclipse.org/tools/orbit/downloads/drops/R20170516192513/repository"/>
</location>
<location path="${project_loc}/../../mavendeps/target/repository" type="Directory"/>
</locations>
</target>

3 changes: 2 additions & 1 deletion
tests/org.codechecker.eclipse.rcp.it.tests/META-INF/MANIFEST.MF

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,4 +13,5 @@ Require-Bundle: org.junit;bundle-version="4.12.0",
 org.eclipse.swtbot.swt.finder;bundle-version="2.7.0",
 org.eclipse.swtbot.eclipse.finder;bundle-version="2.7.0",
 org.codechecker.eclipse.rcp.shared;bundle-version="1.0.0",
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0"
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0",
 javax.annotation;bundle-version="1.2.0"

204 changes: 172 additions & 32 deletions
tests/org.codechecker.eclipse.rcp.it.tests/pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,37 +13,177 @@
 <version>1.0.0-SNAPSHOT</version>
 <packaging>eclipse-test-plugin</packaging>

 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 <profiles>
@vodorokvodorokJul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use different configurations depending on the jdk versions. Maven profiles can only alter build segments, that's why this segment got a little bit verbose.
 <profile>
 <id>active-on-jdk-8</id>
 <activation>
 <jdk>1.8</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-9</id>
 <activation>
 <jdk>9</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <!--requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>0.0.0</versionRange>
 </requirement-->
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=java.se.ee</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-10</id>
 <activation>
 <jdk>10</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <!--requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>1.2.0</versionRange>
 </requirement-->
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=ALL-SYSTEM</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-11</id>
 <activation>
 <jdk>11</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>1.2.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=ALL-SYSTEM</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 </profiles>

</project>

3 changes: 2 additions & 1 deletion
tests/org.codechecker.eclipse.rcp.unit.tests/META-INF/MANIFEST.MF

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,7 @@ Require-Bundle: org.junit,
 org.objenesis;bundle-version="1.0.0",
 org.codechecker.eclipse.rcp.shared;bundle-version="1.0.0",
 com.google.guava,
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0"
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0",
 javax.annotation;bundle-version="1.2.0"
Bundle-ClassPath: .,
 resources/

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Resolving missing module#167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

gamesh411
merged 2 commits into

from

Sep 11, 2019
 Merged


Resolving missing module
#167
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
c030675

Test with multiple jdk verisons in travis


vodorok Jul 2, 2019
f2a78bb

Resolving missing module


vodorok Jul 2, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 15 additions & 1 deletion
.travis.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,9 +3,23 @@ install: true
language: java
jdk:
 - oraclejdk8
 - oraclejdk9
 - oraclejdk11
 - openjdk8

env: DISPLAY=:99.0

matrix:
 include:
 - jdk: openjdk10
 before_install:
 - rm "${JAVA_HOME}/lib/security/cacerts"
 - ln -s /etc/ssl/certs/java/cacerts "${JAVA_HOME}/lib/security/cacerts"
 - jdk: openjdk11
 before_install:
 - rm "${JAVA_HOME}/lib/security/cacerts"
 - ln -s /etc/ssl/certs/java/cacerts "${JAVA_HOME}/lib/security/cacerts"

before_install:
 - sudo apt-get install at-spi2-core

Expand All@@ -18,4 +32,4 @@ script: mvn -f mavendeps/pom.xml p2:site && mvn clean verify
after_failure:
 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.it.tests/target/work/data/.metadata/.log
 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.it.tests/target/surefire-reports/*

 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.unit.tests/target/work/configuration/*.log

9 changes: 7 additions & 2 deletions
readme.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,10 +7,15 @@ This is a C/C++ code analysis plugin for Eclipse that shows bugs detected by the
## Requirements

* Linux operating system

* Recent [CodeChecker](https://github.com/Ericsson/codechecker) (6.8.0 and up)
* Every eclipse version since [Oxygen 1](https://www.eclipse.org/downloads/packages/release/oxygen/1) (v4.7.0) is supported

* Every eclipse version since [Phtoton](https://www.eclipse.org/downloads/packages/release/photon/r) (v4.8.0) is supported
@gyorbgyorbJul 5, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split up the documentation to be more explicit what are the plugin build requirements and what is the runtime requirement for it.
This change mainly effects the build environment if I'm right.
@vodorokvodorokJul 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that!

But for the current setup of the compilation, we only test for one target platform, so until we create a deeper matrix with separate, older (newer) target platforms, we can't be sure the plugin works on older releases, even though we won't use newer features. I'll create an issue regarding this problem.

Until then, I can extend the readme with a note that it should work on Oxygen.
 * Should work with v4.7.0 Oxygen, but this version is untested currently.

* Eclipse CDT
* Java SE 1.8

* Java SE 1.8 (for building, an equivalent jdk).

## Build and install CodeChecker Eclipse Plugin

Expand Down

2 changes: 1 addition & 1 deletion
releng/org.codechecker.eclipse.configuration/pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
 <packaging>pom</packaging>

 <properties>
 <tycho.version>1.3.0</tycho.version>
 <tycho.version>1.4.0</tycho.version>
 <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 </properties>

Expand Down

12 changes: 6 additions & 6 deletions
releng/org.codechecker.eclipse.target/org.codechecker.eclipse.target.target

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<?pde version="3.8"?><target name="org.codechecker.eclipse.target" sequenceNumber="32">
<?pde version="3.8"?><target name="org.codechecker.eclipse.target" sequenceNumber="33">
<locations>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.swtbot.eclipse.feature.group" version="2.7.0.201806111355"/>
Expand All@@ -19,17 +19,17 @@
<repository location="http://download.eclipse.org/tools/cdt/releases/9.3"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.equinox.sdk.feature.group" version="3.13.0.v20170531-1133"/>
<unit id="org.eclipse.sdk.ide" version="4.7.0.I20170612-0950"/>
<unit id="org.eclipse.swt.tools.feature.feature.group" version="3.106.0.v20170503-0851"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.7/"/>
<unit id="org.eclipse.equinox.sdk.feature.group" version="3.14.0.v20180518-2029"/>
<unit id="org.eclipse.sdk.ide" version="4.8.0.I20180611-0500"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.8/"/>
</location>
<location path="${project_loc}/../../mavendeps/target/repository" type="Directory"/>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="javax.annotation" version="1.2.0.v201602091430"/>
<unit id="org.hamcrest" version="1.1.0.v20090501071000"/>
<unit id="org.junit" version="4.12.0.v201504281640"/>
<unit id="org.mockito" version="1.9.5.v201605172210"/>
<repository location="http://download.eclipse.org/tools/orbit/downloads/drops/R20170516192513/repository"/>
</location>
<location path="${project_loc}/../../mavendeps/target/repository" type="Directory"/>
</locations>
</target>

3 changes: 2 additions & 1 deletion
tests/org.codechecker.eclipse.rcp.it.tests/META-INF/MANIFEST.MF

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,4 +13,5 @@ Require-Bundle: org.junit;bundle-version="4.12.0",
 org.eclipse.swtbot.swt.finder;bundle-version="2.7.0",
 org.eclipse.swtbot.eclipse.finder;bundle-version="2.7.0",
 org.codechecker.eclipse.rcp.shared;bundle-version="1.0.0",
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0"
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0",
 javax.annotation;bundle-version="1.2.0"

204 changes: 172 additions & 32 deletions
tests/org.codechecker.eclipse.rcp.it.tests/pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,37 +13,177 @@
 <version>1.0.0-SNAPSHOT</version>
 <packaging>eclipse-test-plugin</packaging>

 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 <profiles>
@vodorokvodorokJul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use different configurations depending on the jdk versions. Maven profiles can only alter build segments, that's why this segment got a little bit verbose.
 <profile>
 <id>active-on-jdk-8</id>
 <activation>
 <jdk>1.8</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-9</id>
 <activation>
 <jdk>9</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <!--requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>0.0.0</versionRange>
 </requirement-->
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=java.se.ee</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-10</id>
 <activation>
 <jdk>10</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <!--requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>1.2.0</versionRange>
 </requirement-->
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=ALL-SYSTEM</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-11</id>
 <activation>
 <jdk>11</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>1.2.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=ALL-SYSTEM</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 </profiles>

</project>

3 changes: 2 additions & 1 deletion
tests/org.codechecker.eclipse.rcp.unit.tests/META-INF/MANIFEST.MF

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,7 @@ Require-Bundle: org.junit,
 org.objenesis;bundle-version="1.0.0",
 org.codechecker.eclipse.rcp.shared;bundle-version="1.0.0",
 com.google.guava,
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0"
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0",
 javax.annotation;bundle-version="1.2.0"
Bundle-ClassPath: .,
 resources/

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Resolving missing module#167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

gamesh411
merged 2 commits into

from

Sep 11, 2019
 Merged


Resolving missing module
#167
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
c030675

Test with multiple jdk verisons in travis


vodorok Jul 2, 2019
f2a78bb

Resolving missing module


vodorok Jul 2, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 15 additions & 1 deletion
.travis.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,9 +3,23 @@ install: true
language: java
jdk:
 - oraclejdk8
 - oraclejdk9
 - oraclejdk11
 - openjdk8

env: DISPLAY=:99.0

matrix:
 include:
 - jdk: openjdk10
 before_install:
 - rm "${JAVA_HOME}/lib/security/cacerts"
 - ln -s /etc/ssl/certs/java/cacerts "${JAVA_HOME}/lib/security/cacerts"
 - jdk: openjdk11
 before_install:
 - rm "${JAVA_HOME}/lib/security/cacerts"
 - ln -s /etc/ssl/certs/java/cacerts "${JAVA_HOME}/lib/security/cacerts"

before_install:
 - sudo apt-get install at-spi2-core

Expand All@@ -18,4 +32,4 @@ script: mvn -f mavendeps/pom.xml p2:site && mvn clean verify
after_failure:
 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.it.tests/target/work/data/.metadata/.log
 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.it.tests/target/surefire-reports/*

 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.unit.tests/target/work/configuration/*.log

9 changes: 7 additions & 2 deletions
readme.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,10 +7,15 @@ This is a C/C++ code analysis plugin for Eclipse that shows bugs detected by the
## Requirements

* Linux operating system

* Recent [CodeChecker](https://github.com/Ericsson/codechecker) (6.8.0 and up)
* Every eclipse version since [Oxygen 1](https://www.eclipse.org/downloads/packages/release/oxygen/1) (v4.7.0) is supported

* Every eclipse version since [Phtoton](https://www.eclipse.org/downloads/packages/release/photon/r) (v4.8.0) is supported
@gyorbgyorbJul 5, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split up the documentation to be more explicit what are the plugin build requirements and what is the runtime requirement for it.
This change mainly effects the build environment if I'm right.
@vodorokvodorokJul 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that!

But for the current setup of the compilation, we only test for one target platform, so until we create a deeper matrix with separate, older (newer) target platforms, we can't be sure the plugin works on older releases, even though we won't use newer features. I'll create an issue regarding this problem.

Until then, I can extend the readme with a note that it should work on Oxygen.
 * Should work with v4.7.0 Oxygen, but this version is untested currently.

* Eclipse CDT
* Java SE 1.8

* Java SE 1.8 (for building, an equivalent jdk).

## Build and install CodeChecker Eclipse Plugin

Expand Down

2 changes: 1 addition & 1 deletion
releng/org.codechecker.eclipse.configuration/pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
 <packaging>pom</packaging>

 <properties>
 <tycho.version>1.3.0</tycho.version>
 <tycho.version>1.4.0</tycho.version>
 <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 </properties>

Expand Down

12 changes: 6 additions & 6 deletions
releng/org.codechecker.eclipse.target/org.codechecker.eclipse.target.target

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<?pde version="3.8"?><target name="org.codechecker.eclipse.target" sequenceNumber="32">
<?pde version="3.8"?><target name="org.codechecker.eclipse.target" sequenceNumber="33">
<locations>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.swtbot.eclipse.feature.group" version="2.7.0.201806111355"/>
Expand All@@ -19,17 +19,17 @@
<repository location="http://download.eclipse.org/tools/cdt/releases/9.3"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.equinox.sdk.feature.group" version="3.13.0.v20170531-1133"/>
<unit id="org.eclipse.sdk.ide" version="4.7.0.I20170612-0950"/>
<unit id="org.eclipse.swt.tools.feature.feature.group" version="3.106.0.v20170503-0851"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.7/"/>
<unit id="org.eclipse.equinox.sdk.feature.group" version="3.14.0.v20180518-2029"/>
<unit id="org.eclipse.sdk.ide" version="4.8.0.I20180611-0500"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.8/"/>
</location>
<location path="${project_loc}/../../mavendeps/target/repository" type="Directory"/>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="javax.annotation" version="1.2.0.v201602091430"/>
<unit id="org.hamcrest" version="1.1.0.v20090501071000"/>
<unit id="org.junit" version="4.12.0.v201504281640"/>
<unit id="org.mockito" version="1.9.5.v201605172210"/>
<repository location="http://download.eclipse.org/tools/orbit/downloads/drops/R20170516192513/repository"/>
</location>
<location path="${project_loc}/../../mavendeps/target/repository" type="Directory"/>
</locations>
</target>

3 changes: 2 additions & 1 deletion
tests/org.codechecker.eclipse.rcp.it.tests/META-INF/MANIFEST.MF

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,4 +13,5 @@ Require-Bundle: org.junit;bundle-version="4.12.0",
 org.eclipse.swtbot.swt.finder;bundle-version="2.7.0",
 org.eclipse.swtbot.eclipse.finder;bundle-version="2.7.0",
 org.codechecker.eclipse.rcp.shared;bundle-version="1.0.0",
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0"
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0",
 javax.annotation;bundle-version="1.2.0"

204 changes: 172 additions & 32 deletions
tests/org.codechecker.eclipse.rcp.it.tests/pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,37 +13,177 @@
 <version>1.0.0-SNAPSHOT</version>
 <packaging>eclipse-test-plugin</packaging>

 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 <profiles>
@vodorokvodorokJul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use different configurations depending on the jdk versions. Maven profiles can only alter build segments, that's why this segment got a little bit verbose.
 <profile>
 <id>active-on-jdk-8</id>
 <activation>
 <jdk>1.8</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-9</id>
 <activation>
 <jdk>9</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <!--requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>0.0.0</versionRange>
 </requirement-->
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=java.se.ee</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-10</id>
 <activation>
 <jdk>10</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <!--requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>1.2.0</versionRange>
 </requirement-->
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=ALL-SYSTEM</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-11</id>
 <activation>
 <jdk>11</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>1.2.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=ALL-SYSTEM</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 </profiles>

</project>

3 changes: 2 additions & 1 deletion
tests/org.codechecker.eclipse.rcp.unit.tests/META-INF/MANIFEST.MF

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,7 @@ Require-Bundle: org.junit,
 org.objenesis;bundle-version="1.0.0",
 org.codechecker.eclipse.rcp.shared;bundle-version="1.0.0",
 com.google.guava,
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0"
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0",
 javax.annotation;bundle-version="1.2.0"
Bundle-ClassPath: .,
 resources/

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Resolving missing module#167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

gamesh411
merged 2 commits into

from

Sep 11, 2019
 Merged


Resolving missing module
#167
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
c030675

Test with multiple jdk verisons in travis


vodorok Jul 2, 2019
f2a78bb

Resolving missing module


vodorok Jul 2, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 15 additions & 1 deletion
.travis.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,9 +3,23 @@ install: true
language: java
jdk:
 - oraclejdk8
 - oraclejdk9
 - oraclejdk11
 - openjdk8

env: DISPLAY=:99.0

matrix:
 include:
 - jdk: openjdk10
 before_install:
 - rm "${JAVA_HOME}/lib/security/cacerts"
 - ln -s /etc/ssl/certs/java/cacerts "${JAVA_HOME}/lib/security/cacerts"
 - jdk: openjdk11
 before_install:
 - rm "${JAVA_HOME}/lib/security/cacerts"
 - ln -s /etc/ssl/certs/java/cacerts "${JAVA_HOME}/lib/security/cacerts"

before_install:
 - sudo apt-get install at-spi2-core

Expand All@@ -18,4 +32,4 @@ script: mvn -f mavendeps/pom.xml p2:site && mvn clean verify
after_failure:
 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.it.tests/target/work/data/.metadata/.log
 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.it.tests/target/surefire-reports/*

 - cat $TRAVIS_BUILD_DIR/tests/org.codechecker.eclipse.rcp.unit.tests/target/work/configuration/*.log

9 changes: 7 additions & 2 deletions
readme.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,10 +7,15 @@ This is a C/C++ code analysis plugin for Eclipse that shows bugs detected by the
## Requirements

* Linux operating system

* Recent [CodeChecker](https://github.com/Ericsson/codechecker) (6.8.0 and up)
* Every eclipse version since [Oxygen 1](https://www.eclipse.org/downloads/packages/release/oxygen/1) (v4.7.0) is supported

* Every eclipse version since [Phtoton](https://www.eclipse.org/downloads/packages/release/photon/r) (v4.8.0) is supported
@gyorbgyorbJul 5, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split up the documentation to be more explicit what are the plugin build requirements and what is the runtime requirement for it.
This change mainly effects the build environment if I'm right.
@vodorokvodorokJul 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that!

But for the current setup of the compilation, we only test for one target platform, so until we create a deeper matrix with separate, older (newer) target platforms, we can't be sure the plugin works on older releases, even though we won't use newer features. I'll create an issue regarding this problem.

Until then, I can extend the readme with a note that it should work on Oxygen.
 * Should work with v4.7.0 Oxygen, but this version is untested currently.

* Eclipse CDT
* Java SE 1.8

* Java SE 1.8 (for building, an equivalent jdk).

## Build and install CodeChecker Eclipse Plugin

Expand Down

2 changes: 1 addition & 1 deletion
releng/org.codechecker.eclipse.configuration/pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
 <packaging>pom</packaging>

 <properties>
 <tycho.version>1.3.0</tycho.version>
 <tycho.version>1.4.0</tycho.version>
 <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 </properties>

Expand Down

12 changes: 6 additions & 6 deletions
releng/org.codechecker.eclipse.target/org.codechecker.eclipse.target.target

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<?pde version="3.8"?><target name="org.codechecker.eclipse.target" sequenceNumber="32">
<?pde version="3.8"?><target name="org.codechecker.eclipse.target" sequenceNumber="33">
<locations>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.swtbot.eclipse.feature.group" version="2.7.0.201806111355"/>
Expand All@@ -19,17 +19,17 @@
<repository location="http://download.eclipse.org/tools/cdt/releases/9.3"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.equinox.sdk.feature.group" version="3.13.0.v20170531-1133"/>
<unit id="org.eclipse.sdk.ide" version="4.7.0.I20170612-0950"/>
<unit id="org.eclipse.swt.tools.feature.feature.group" version="3.106.0.v20170503-0851"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.7/"/>
<unit id="org.eclipse.equinox.sdk.feature.group" version="3.14.0.v20180518-2029"/>
<unit id="org.eclipse.sdk.ide" version="4.8.0.I20180611-0500"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.8/"/>
</location>
<location path="${project_loc}/../../mavendeps/target/repository" type="Directory"/>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="javax.annotation" version="1.2.0.v201602091430"/>
<unit id="org.hamcrest" version="1.1.0.v20090501071000"/>
<unit id="org.junit" version="4.12.0.v201504281640"/>
<unit id="org.mockito" version="1.9.5.v201605172210"/>
<repository location="http://download.eclipse.org/tools/orbit/downloads/drops/R20170516192513/repository"/>
</location>
<location path="${project_loc}/../../mavendeps/target/repository" type="Directory"/>
</locations>
</target>

3 changes: 2 additions & 1 deletion
tests/org.codechecker.eclipse.rcp.it.tests/META-INF/MANIFEST.MF

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,4 +13,5 @@ Require-Bundle: org.junit;bundle-version="4.12.0",
 org.eclipse.swtbot.swt.finder;bundle-version="2.7.0",
 org.eclipse.swtbot.eclipse.finder;bundle-version="2.7.0",
 org.codechecker.eclipse.rcp.shared;bundle-version="1.0.0",
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0"
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0",
 javax.annotation;bundle-version="1.2.0"

204 changes: 172 additions & 32 deletions
tests/org.codechecker.eclipse.rcp.it.tests/pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,37 +13,177 @@
 <version>1.0.0-SNAPSHOT</version>
 <packaging>eclipse-test-plugin</packaging>

 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 <profiles>
@vodorokvodorokJul 24, 2019•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use different configurations depending on the jdk versions. Maven profiles can only alter build segments, that's why this segment got a little bit verbose.
 <profile>
 <id>active-on-jdk-8</id>
 <activation>
 <jdk>1.8</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-9</id>
 <activation>
 <jdk>9</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <!--requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>0.0.0</versionRange>
 </requirement-->
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=java.se.ee</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-10</id>
 <activation>
 <jdk>10</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <!--requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>1.2.0</versionRange>
 </requirement-->
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=ALL-SYSTEM</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 <profile>
 <id>active-on-jdk-11</id>
 <activation>
 <jdk>11</jdk>
 </activation>
 <build>
 <plugins>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>target-platform-configuration</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <dependency-resolution>
 <extraRequirements>
 <requirement>
 <type>eclipse-feature</type>
 <id>org.eclipse.cdt</id>
 <versionRange>0.0.0</versionRange>
 </requirement>
 <requirement>
 <type>eclipse-plugin</type>
 <id>javax.annotation</id>
 <versionRange>1.2.0</versionRange>
 </requirement>
 </extraRequirements>
 </dependency-resolution>
 </configuration>
 </plugin>
 <plugin>
 <groupId>org.eclipse.tycho</groupId>
 <artifactId>tycho-surefire-plugin</artifactId>
 <version>${tycho.version}</version>
 <configuration>
 <useUIHarness>true</useUIHarness>
 <useUIThread>false</useUIThread>
 <argLine>--add-modules=ALL-SYSTEM</argLine>
 <product>org.codechecker.eclipse.feature</product>
 <application>org.eclipse.ui.ide.workbench</application>
 <testClass>org.codechecker.eclipse.plugin.AllTests</testClass>
 </configuration>
 </plugin>
 </plugins>
 </build>
 </profile>
 </profiles>

</project>

3 changes: 2 additions & 1 deletion
tests/org.codechecker.eclipse.rcp.unit.tests/META-INF/MANIFEST.MF

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,7 @@ Require-Bundle: org.junit,
 org.objenesis;bundle-version="1.0.0",
 org.codechecker.eclipse.rcp.shared;bundle-version="1.0.0",
 com.google.guava,
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0"
 com.github.stefanbirkner.system-rules;bundle-version="1.19.0",
 javax.annotation;bundle-version="1.2.0"
Bundle-ClassPath: .,
 resources/