Adding EssentialsWarpEvent by Banbeucmas · Pull Request #1921 · EssentialsX/Essentials

Banbeucmas · 2018-03-24T06:32:56Z

Tho you can still use PlayerTeleportEvent for this, I think it is better to have an event especially for EssentialsWarp for checking warps tho.
This should help a lot on dependency which are trying to hook into the plugin.

Update

Dolphin2Point1

Great! Some Plugins could really use this for an api!
Edit: I have compiled it for use. If you're too lazy, look here: https://github.com/loper12/BanbeucmasEssPatch

mdcfe

This mostly looks good, but I haven't been able to test it so I can't approve this yet.

mdcfe · 2018-03-24T14:37:10Z

 public void warp(IUser teleportee, String warp, Trade chargeFor, TeleportCause cause) throws Exception {
+ EssentialsWarpEvent event = new EssentialsWarpEvent(teleportee, warp);
+ Bukkit.getServer().getPluginManager().callEvent(event);
+ if(event.isCancelled()){


This should be spaced out.

Testing with Remote Debugging and also Checkpoints, the event was called. I haven't test the listeners tho

Banbeucmas · 2018-03-24T14:52:45Z

+ private IUser user;
+ private String warp;
+ private boolean cancelled = false;
+


Should I add Trade also?

Could do, I suppose.

Ok wait for me a moment

mdcfe · 2018-03-24T15:14:33Z

We could also add a method EssentialsWarpEvent#setWarp which changes the warp destination, then retrieve the warp destination from the event in Teleport#warp.

Also, prefixing the event with Essentials isn't consistent with other Essentials events - I'd suggest renaming it to UserWarpEvent, but open to any other suggestions.

Banbeucmas · 2018-03-24T17:05:27Z

We could also add a method EssentialsWarpEvent#setWarp which changes the warp destination, then retrieve the warp destination from the event in Teleport#warp.

Like that?
I tested and pretty sure it worked flawlessly without errors

mdcfe · 2018-03-25T20:24:05Z

+ return trade;
+ }
+
+ public void setWarp(String warp){


Spacing here too: public void setWarp(String warp) {

mdcfe · 2018-03-25T20:24:43Z

+ UserWarpEvent event = new UserWarpEvent(teleportee, warp, chargeFor);
+ Bukkit.getServer().getPluginManager().callEvent(event);
+
+ if(event.isCancelled()){


This should still be spaced out: if (event.isCancelled()) {

Ok I will do it tonight

drtshock · 2018-03-26T04:54:26Z

+ return warp;
+ }
+
+ public Trade getTrade() {


Perhaps some javadocs would help?

Should help. I am not that familiar with Javadocs tho

I don't know if I were to left documentation there, providing that all of other Events doesn't have any documentation except the heading of the class.

Banbeucmas · 2018-03-26T10:26:17Z

@md678685 @drtshock Done, can you guys check for what is left?
If it is ok then I think we can merge it by now.

mdcfe · 2018-10-28T18:53:56Z

This has been merged into the 1.13 branch and is now part of experimental builds.

Banbeucmas · 2018-10-29T03:32:48Z

Thanks for the merge.
Guess I will back to my work then.

* Adding EssentialsWarpEvent for checking if player is wrapping * Spacing * Adding Trade parameter * Refactoring * Adding #setWarp() to the Event * Spacing * Documenting the purpose of the Event * Javadoc?

Banbeucmas · 2018-03-24T06:32:56Z

Tho you can still use PlayerTeleportEvent for this, I think it is better to have an event especially for EssentialsWarp for checking warps tho.
This should help a lot on dependency which are trying to hook into the plugin.

Update

Dolphin2Point1

Great! Some Plugins could really use this for an api!
Edit: I have compiled it for use. If you're too lazy, look here: https://github.com/loper12/BanbeucmasEssPatch

mdcfe

This mostly looks good, but I haven't been able to test it so I can't approve this yet.

mdcfe · 2018-03-24T14:37:10Z

 public void warp(IUser teleportee, String warp, Trade chargeFor, TeleportCause cause) throws Exception {
+ EssentialsWarpEvent event = new EssentialsWarpEvent(teleportee, warp);
+ Bukkit.getServer().getPluginManager().callEvent(event);
+ if(event.isCancelled()){


This should be spaced out.

Testing with Remote Debugging and also Checkpoints, the event was called. I haven't test the listeners tho

Banbeucmas · 2018-03-24T14:52:45Z

+ private IUser user;
+ private String warp;
+ private boolean cancelled = false;
+


Should I add Trade also?

Could do, I suppose.

Ok wait for me a moment

mdcfe · 2018-03-24T15:14:33Z

We could also add a method EssentialsWarpEvent#setWarp which changes the warp destination, then retrieve the warp destination from the event in Teleport#warp.

Also, prefixing the event with Essentials isn't consistent with other Essentials events - I'd suggest renaming it to UserWarpEvent, but open to any other suggestions.

Banbeucmas · 2018-03-24T17:05:27Z

We could also add a method EssentialsWarpEvent#setWarp which changes the warp destination, then retrieve the warp destination from the event in Teleport#warp.

Like that?
I tested and pretty sure it worked flawlessly without errors

mdcfe · 2018-03-25T20:24:05Z

+ return trade;
+ }
+
+ public void setWarp(String warp){


Spacing here too: public void setWarp(String warp) {

mdcfe · 2018-03-25T20:24:43Z

+ UserWarpEvent event = new UserWarpEvent(teleportee, warp, chargeFor);
+ Bukkit.getServer().getPluginManager().callEvent(event);
+
+ if(event.isCancelled()){


This should still be spaced out: if (event.isCancelled()) {

Ok I will do it tonight

drtshock · 2018-03-26T04:54:26Z

+ return warp;
+ }
+
+ public Trade getTrade() {


Perhaps some javadocs would help?

Should help. I am not that familiar with Javadocs tho

I don't know if I were to left documentation there, providing that all of other Events doesn't have any documentation except the heading of the class.

Banbeucmas · 2018-03-26T10:26:17Z

@md678685 @drtshock Done, can you guys check for what is left?
If it is ok then I think we can merge it by now.

mdcfe · 2018-10-28T18:53:56Z

This has been merged into the 1.13 branch and is now part of experimental builds.

Banbeucmas · 2018-10-29T03:32:48Z

Thanks for the merge.
Guess I will back to my work then.

* Adding EssentialsWarpEvent for checking if player is wrapping * Spacing * Adding Trade parameter * Refactoring * Adding #setWarp() to the Event * Spacing * Documenting the purpose of the Event * Javadoc?

Banbeucmas · 2018-03-24T06:32:56Z

Tho you can still use PlayerTeleportEvent for this, I think it is better to have an event especially for EssentialsWarp for checking warps tho.
This should help a lot on dependency which are trying to hook into the plugin.

Update

Dolphin2Point1

Great! Some Plugins could really use this for an api!
Edit: I have compiled it for use. If you're too lazy, look here: https://github.com/loper12/BanbeucmasEssPatch

mdcfe

This mostly looks good, but I haven't been able to test it so I can't approve this yet.

mdcfe · 2018-03-24T14:37:10Z

 public void warp(IUser teleportee, String warp, Trade chargeFor, TeleportCause cause) throws Exception {
+ EssentialsWarpEvent event = new EssentialsWarpEvent(teleportee, warp);
+ Bukkit.getServer().getPluginManager().callEvent(event);
+ if(event.isCancelled()){


This should be spaced out.

Testing with Remote Debugging and also Checkpoints, the event was called. I haven't test the listeners tho

Banbeucmas · 2018-03-24T14:52:45Z

+ private IUser user;
+ private String warp;
+ private boolean cancelled = false;
+


Should I add Trade also?

Could do, I suppose.

Ok wait for me a moment

mdcfe · 2018-03-24T15:14:33Z

We could also add a method EssentialsWarpEvent#setWarp which changes the warp destination, then retrieve the warp destination from the event in Teleport#warp.

Also, prefixing the event with Essentials isn't consistent with other Essentials events - I'd suggest renaming it to UserWarpEvent, but open to any other suggestions.

Banbeucmas · 2018-03-24T17:05:27Z

We could also add a method EssentialsWarpEvent#setWarp which changes the warp destination, then retrieve the warp destination from the event in Teleport#warp.

Like that?
I tested and pretty sure it worked flawlessly without errors

mdcfe · 2018-03-25T20:24:05Z

+ return trade;
+ }
+
+ public void setWarp(String warp){


Spacing here too: public void setWarp(String warp) {

mdcfe · 2018-03-25T20:24:43Z

+ UserWarpEvent event = new UserWarpEvent(teleportee, warp, chargeFor);
+ Bukkit.getServer().getPluginManager().callEvent(event);
+
+ if(event.isCancelled()){


This should still be spaced out: if (event.isCancelled()) {

Ok I will do it tonight

drtshock · 2018-03-26T04:54:26Z

+ return warp;
+ }
+
+ public Trade getTrade() {


Perhaps some javadocs would help?

Should help. I am not that familiar with Javadocs tho

I don't know if I were to left documentation there, providing that all of other Events doesn't have any documentation except the heading of the class.

Banbeucmas · 2018-03-26T10:26:17Z

@md678685 @drtshock Done, can you guys check for what is left?
If it is ok then I think we can merge it by now.

mdcfe · 2018-10-28T18:53:56Z

This has been merged into the 1.13 branch and is now part of experimental builds.

Banbeucmas · 2018-10-29T03:32:48Z

Thanks for the merge.
Guess I will back to my work then.

* Adding EssentialsWarpEvent for checking if player is wrapping * Spacing * Adding Trade parameter * Refactoring * Adding #setWarp() to the Event * Spacing * Documenting the purpose of the Event * Javadoc?

Banbeucmas · 2018-03-24T06:32:56Z

Tho you can still use PlayerTeleportEvent for this, I think it is better to have an event especially for EssentialsWarp for checking warps tho.
This should help a lot on dependency which are trying to hook into the plugin.

Update

Dolphin2Point1

Great! Some Plugins could really use this for an api!
Edit: I have compiled it for use. If you're too lazy, look here: https://github.com/loper12/BanbeucmasEssPatch

mdcfe

This mostly looks good, but I haven't been able to test it so I can't approve this yet.

mdcfe · 2018-03-24T14:37:10Z

 public void warp(IUser teleportee, String warp, Trade chargeFor, TeleportCause cause) throws Exception {
+ EssentialsWarpEvent event = new EssentialsWarpEvent(teleportee, warp);
+ Bukkit.getServer().getPluginManager().callEvent(event);
+ if(event.isCancelled()){


This should be spaced out.

Testing with Remote Debugging and also Checkpoints, the event was called. I haven't test the listeners tho

Banbeucmas · 2018-03-24T14:52:45Z

+ private IUser user;
+ private String warp;
+ private boolean cancelled = false;
+


Should I add Trade also?

Could do, I suppose.

Ok wait for me a moment

mdcfe · 2018-03-24T15:14:33Z

We could also add a method EssentialsWarpEvent#setWarp which changes the warp destination, then retrieve the warp destination from the event in Teleport#warp.

Also, prefixing the event with Essentials isn't consistent with other Essentials events - I'd suggest renaming it to UserWarpEvent, but open to any other suggestions.

Banbeucmas · 2018-03-24T17:05:27Z

We could also add a method EssentialsWarpEvent#setWarp which changes the warp destination, then retrieve the warp destination from the event in Teleport#warp.

Like that?
I tested and pretty sure it worked flawlessly without errors

mdcfe · 2018-03-25T20:24:05Z

+ return trade;
+ }
+
+ public void setWarp(String warp){


Spacing here too: public void setWarp(String warp) {

mdcfe · 2018-03-25T20:24:43Z

+ UserWarpEvent event = new UserWarpEvent(teleportee, warp, chargeFor);
+ Bukkit.getServer().getPluginManager().callEvent(event);
+
+ if(event.isCancelled()){


This should still be spaced out: if (event.isCancelled()) {

Ok I will do it tonight

drtshock · 2018-03-26T04:54:26Z

+ return warp;
+ }
+
+ public Trade getTrade() {


Perhaps some javadocs would help?

Should help. I am not that familiar with Javadocs tho

I don't know if I were to left documentation there, providing that all of other Events doesn't have any documentation except the heading of the class.

Banbeucmas · 2018-03-26T10:26:17Z

@md678685 @drtshock Done, can you guys check for what is left?
If it is ok then I think we can merge it by now.

mdcfe · 2018-10-28T18:53:56Z

This has been merged into the 1.13 branch and is now part of experimental builds.

Banbeucmas · 2018-10-29T03:32:48Z

Thanks for the merge.
Guess I will back to my work then.

* Adding EssentialsWarpEvent for checking if player is wrapping * Spacing * Adding Trade parameter * Refactoring * Adding #setWarp() to the Event * Spacing * Documenting the purpose of the Event * Javadoc?

Banbeucmas · 2018-03-24T06:32:56Z

Tho you can still use PlayerTeleportEvent for this, I think it is better to have an event especially for EssentialsWarp for checking warps tho.
This should help a lot on dependency which are trying to hook into the plugin.

Update

Dolphin2Point1

Great! Some Plugins could really use this for an api!
Edit: I have compiled it for use. If you're too lazy, look here: https://github.com/loper12/BanbeucmasEssPatch

mdcfe

This mostly looks good, but I haven't been able to test it so I can't approve this yet.

mdcfe · 2018-03-24T14:37:10Z

 public void warp(IUser teleportee, String warp, Trade chargeFor, TeleportCause cause) throws Exception {
+ EssentialsWarpEvent event = new EssentialsWarpEvent(teleportee, warp);
+ Bukkit.getServer().getPluginManager().callEvent(event);
+ if(event.isCancelled()){


This should be spaced out.

Testing with Remote Debugging and also Checkpoints, the event was called. I haven't test the listeners tho

Banbeucmas · 2018-03-24T14:52:45Z

+ private IUser user;
+ private String warp;
+ private boolean cancelled = false;
+


Should I add Trade also?

Could do, I suppose.

Ok wait for me a moment

mdcfe · 2018-03-24T15:14:33Z

We could also add a method EssentialsWarpEvent#setWarp which changes the warp destination, then retrieve the warp destination from the event in Teleport#warp.

Also, prefixing the event with Essentials isn't consistent with other Essentials events - I'd suggest renaming it to UserWarpEvent, but open to any other suggestions.

Banbeucmas · 2018-03-24T17:05:27Z

We could also add a method EssentialsWarpEvent#setWarp which changes the warp destination, then retrieve the warp destination from the event in Teleport#warp.

Like that?
I tested and pretty sure it worked flawlessly without errors

mdcfe · 2018-03-25T20:24:05Z

+ return trade;
+ }
+
+ public void setWarp(String warp){


Spacing here too: public void setWarp(String warp) {

mdcfe · 2018-03-25T20:24:43Z

+ UserWarpEvent event = new UserWarpEvent(teleportee, warp, chargeFor);
+ Bukkit.getServer().getPluginManager().callEvent(event);
+
+ if(event.isCancelled()){


This should still be spaced out: if (event.isCancelled()) {

Ok I will do it tonight

drtshock · 2018-03-26T04:54:26Z

+ return warp;
+ }
+
+ public Trade getTrade() {


Perhaps some javadocs would help?

Should help. I am not that familiar with Javadocs tho

I don't know if I were to left documentation there, providing that all of other Events doesn't have any documentation except the heading of the class.

Banbeucmas · 2018-03-26T10:26:17Z

@md678685 @drtshock Done, can you guys check for what is left?
If it is ok then I think we can merge it by now.

mdcfe · 2018-10-28T18:53:56Z

This has been merged into the 1.13 branch and is now part of experimental builds.

Banbeucmas · 2018-10-29T03:32:48Z

Thanks for the merge.
Guess I will back to my work then.

* Adding EssentialsWarpEvent for checking if player is wrapping * Spacing * Adding Trade parameter * Refactoring * Adding #setWarp() to the Event * Spacing * Documenting the purpose of the Event * Javadoc?

Banbeucmas · 2018-03-24T06:32:56Z

Tho you can still use PlayerTeleportEvent for this, I think it is better to have an event especially for EssentialsWarp for checking warps tho.
This should help a lot on dependency which are trying to hook into the plugin.

Update

Dolphin2Point1

Great! Some Plugins could really use this for an api!
Edit: I have compiled it for use. If you're too lazy, look here: https://github.com/loper12/BanbeucmasEssPatch

mdcfe

This mostly looks good, but I haven't been able to test it so I can't approve this yet.

mdcfe · 2018-03-24T14:37:10Z

 public void warp(IUser teleportee, String warp, Trade chargeFor, TeleportCause cause) throws Exception {
+ EssentialsWarpEvent event = new EssentialsWarpEvent(teleportee, warp);
+ Bukkit.getServer().getPluginManager().callEvent(event);
+ if(event.isCancelled()){


This should be spaced out.

Testing with Remote Debugging and also Checkpoints, the event was called. I haven't test the listeners tho

Banbeucmas · 2018-03-24T14:52:45Z

+ private IUser user;
+ private String warp;
+ private boolean cancelled = false;
+


Should I add Trade also?

Could do, I suppose.

Ok wait for me a moment

mdcfe · 2018-03-24T15:14:33Z

We could also add a method EssentialsWarpEvent#setWarp which changes the warp destination, then retrieve the warp destination from the event in Teleport#warp.

Also, prefixing the event with Essentials isn't consistent with other Essentials events - I'd suggest renaming it to UserWarpEvent, but open to any other suggestions.

Banbeucmas · 2018-03-24T17:05:27Z

We could also add a method EssentialsWarpEvent#setWarp which changes the warp destination, then retrieve the warp destination from the event in Teleport#warp.

Like that?
I tested and pretty sure it worked flawlessly without errors

mdcfe · 2018-03-25T20:24:05Z

+ return trade;
+ }
+
+ public void setWarp(String warp){


Spacing here too: public void setWarp(String warp) {

mdcfe · 2018-03-25T20:24:43Z

+ UserWarpEvent event = new UserWarpEvent(teleportee, warp, chargeFor);
+ Bukkit.getServer().getPluginManager().callEvent(event);
+
+ if(event.isCancelled()){


This should still be spaced out: if (event.isCancelled()) {

Ok I will do it tonight

drtshock · 2018-03-26T04:54:26Z

+ return warp;
+ }
+
+ public Trade getTrade() {


Perhaps some javadocs would help?

Should help. I am not that familiar with Javadocs tho

I don't know if I were to left documentation there, providing that all of other Events doesn't have any documentation except the heading of the class.

Banbeucmas · 2018-03-26T10:26:17Z

@md678685 @drtshock Done, can you guys check for what is left?
If it is ok then I think we can merge it by now.

mdcfe · 2018-10-28T18:53:56Z

This has been merged into the 1.13 branch and is now part of experimental builds.

Banbeucmas · 2018-10-29T03:32:48Z

Thanks for the merge.
Guess I will back to my work then.

* Adding EssentialsWarpEvent for checking if player is wrapping * Spacing * Adding Trade parameter * Refactoring * Adding #setWarp() to the Event * Spacing * Documenting the purpose of the Event * Javadoc?

Banbeucmas · 2018-03-24T06:32:56Z

Tho you can still use PlayerTeleportEvent for this, I think it is better to have an event especially for EssentialsWarp for checking warps tho.
This should help a lot on dependency which are trying to hook into the plugin.

Update

Dolphin2Point1

Great! Some Plugins could really use this for an api!
Edit: I have compiled it for use. If you're too lazy, look here: https://github.com/loper12/BanbeucmasEssPatch

mdcfe

This mostly looks good, but I haven't been able to test it so I can't approve this yet.

mdcfe · 2018-03-24T14:37:10Z

 public void warp(IUser teleportee, String warp, Trade chargeFor, TeleportCause cause) throws Exception {
+ EssentialsWarpEvent event = new EssentialsWarpEvent(teleportee, warp);
+ Bukkit.getServer().getPluginManager().callEvent(event);
+ if(event.isCancelled()){


This should be spaced out.

Testing with Remote Debugging and also Checkpoints, the event was called. I haven't test the listeners tho

Banbeucmas · 2018-03-24T14:52:45Z

+ private IUser user;
+ private String warp;
+ private boolean cancelled = false;
+


Should I add Trade also?

Could do, I suppose.

Ok wait for me a moment

mdcfe · 2018-03-24T15:14:33Z

We could also add a method EssentialsWarpEvent#setWarp which changes the warp destination, then retrieve the warp destination from the event in Teleport#warp.

Also, prefixing the event with Essentials isn't consistent with other Essentials events - I'd suggest renaming it to UserWarpEvent, but open to any other suggestions.

Banbeucmas · 2018-03-24T17:05:27Z

We could also add a method EssentialsWarpEvent#setWarp which changes the warp destination, then retrieve the warp destination from the event in Teleport#warp.

Like that?
I tested and pretty sure it worked flawlessly without errors

mdcfe · 2018-03-25T20:24:05Z

+ return trade;
+ }
+
+ public void setWarp(String warp){


Spacing here too: public void setWarp(String warp) {

mdcfe · 2018-03-25T20:24:43Z

+ UserWarpEvent event = new UserWarpEvent(teleportee, warp, chargeFor);
+ Bukkit.getServer().getPluginManager().callEvent(event);
+
+ if(event.isCancelled()){


This should still be spaced out: if (event.isCancelled()) {

Ok I will do it tonight

drtshock · 2018-03-26T04:54:26Z

+ return warp;
+ }
+
+ public Trade getTrade() {


Perhaps some javadocs would help?

Should help. I am not that familiar with Javadocs tho

I don't know if I were to left documentation there, providing that all of other Events doesn't have any documentation except the heading of the class.

Banbeucmas · 2018-03-26T10:26:17Z

@md678685 @drtshock Done, can you guys check for what is left?
If it is ok then I think we can merge it by now.

mdcfe · 2018-10-28T18:53:56Z

This has been merged into the 1.13 branch and is now part of experimental builds.

Banbeucmas · 2018-10-29T03:32:48Z

Thanks for the merge.
Guess I will back to my work then.

* Adding EssentialsWarpEvent for checking if player is wrapping * Spacing * Adding Trade parameter * Refactoring * Adding #setWarp() to the Event * Spacing * Documenting the purpose of the Event * Javadoc?

Banbeucmas · 2018-03-24T06:32:56Z

Tho you can still use PlayerTeleportEvent for this, I think it is better to have an event especially for EssentialsWarp for checking warps tho.
This should help a lot on dependency which are trying to hook into the plugin.

Update

Dolphin2Point1

Great! Some Plugins could really use this for an api!
Edit: I have compiled it for use. If you're too lazy, look here: https://github.com/loper12/BanbeucmasEssPatch

mdcfe

This mostly looks good, but I haven't been able to test it so I can't approve this yet.

mdcfe · 2018-03-24T14:37:10Z

 public void warp(IUser teleportee, String warp, Trade chargeFor, TeleportCause cause) throws Exception {
+ EssentialsWarpEvent event = new EssentialsWarpEvent(teleportee, warp);
+ Bukkit.getServer().getPluginManager().callEvent(event);
+ if(event.isCancelled()){


This should be spaced out.

Testing with Remote Debugging and also Checkpoints, the event was called. I haven't test the listeners tho

Banbeucmas · 2018-03-24T14:52:45Z

+ private IUser user;
+ private String warp;
+ private boolean cancelled = false;
+


Should I add Trade also?

Could do, I suppose.

Ok wait for me a moment

mdcfe · 2018-03-24T15:14:33Z

We could also add a method EssentialsWarpEvent#setWarp which changes the warp destination, then retrieve the warp destination from the event in Teleport#warp.

Also, prefixing the event with Essentials isn't consistent with other Essentials events - I'd suggest renaming it to UserWarpEvent, but open to any other suggestions.

Banbeucmas · 2018-03-24T17:05:27Z

We could also add a method EssentialsWarpEvent#setWarp which changes the warp destination, then retrieve the warp destination from the event in Teleport#warp.

Like that?
I tested and pretty sure it worked flawlessly without errors

mdcfe · 2018-03-25T20:24:05Z

+ return trade;
+ }
+
+ public void setWarp(String warp){


Spacing here too: public void setWarp(String warp) {

mdcfe · 2018-03-25T20:24:43Z

+ UserWarpEvent event = new UserWarpEvent(teleportee, warp, chargeFor);
+ Bukkit.getServer().getPluginManager().callEvent(event);
+
+ if(event.isCancelled()){


This should still be spaced out: if (event.isCancelled()) {

Ok I will do it tonight

drtshock · 2018-03-26T04:54:26Z

+ return warp;
+ }
+
+ public Trade getTrade() {


Perhaps some javadocs would help?

Should help. I am not that familiar with Javadocs tho

I don't know if I were to left documentation there, providing that all of other Events doesn't have any documentation except the heading of the class.

Banbeucmas · 2018-03-26T10:26:17Z

@md678685 @drtshock Done, can you guys check for what is left?
If it is ok then I think we can merge it by now.

mdcfe · 2018-10-28T18:53:56Z

This has been merged into the 1.13 branch and is now part of experimental builds.

Banbeucmas · 2018-10-29T03:32:48Z

Thanks for the merge.
Guess I will back to my work then.

* Adding EssentialsWarpEvent for checking if player is wrapping * Spacing * Adding Trade parameter * Refactoring * Adding #setWarp() to the Event * Spacing * Documenting the purpose of the Event * Javadoc?

Banbeucmas added 2 commits March 23, 2018 11:47

Merge pull request#1from EssentialsX/2.x
b535198
Update

Adding EssentialsWarpEvent for checking if player is wrapping
0dda123

Dolphin2Point1 approved these changes Mar 24, 2018
View reviewed changes

mdcfe reviewed Mar 24, 2018
View reviewed changes

Spacing
d6af21c

Banbeucmas commented Mar 24, 2018
View reviewed changes

Adding Trade parameter
aadcd82

mdcfe added the type: enhancement Features and feature requests. label Mar 24, 2018

Banbeucmas added 2 commits March 25, 2018 00:20

Refactoring
5176f3c

Adding #setWarp() to the Event
5713538

mdcfe reviewed Mar 25, 2018
View reviewed changes

drtshock reviewed Mar 26, 2018
View reviewed changes

Banbeucmas added 2 commits March 26, 2018 19:19

Spacing
0714f53

Documenting the purpose of the Event
e66e636

mdcfe added this to the 2.16.0 milestone Mar 30, 2018

Banbeucmas added 2 commits April 1, 2018 15:54

Merge branch '2.x' ofhttps://github.com/EssentialsX/Essentialsinto 2.x
5105120

Javadoc?
6a24350

mdcfe mentioned this pull request May 20, 2018
Adding Placeholder API Compability internally [WIP] #1944
Closed

mdcfe mentioned this pull request Jun 14, 2018
Add PlaceholderAPI support #2041
Closed
6 tasks

mdcfe approved these changes Oct 28, 2018
View reviewed changes

mdcfe changed the base branch from 2.x to 1.13October 28, 2018 18:53

mdcfe merged commit 280d121 into EssentialsX:1.13Oct 28, 2018

mdcfe modified the milestones: 2.17.0 (future), 2.16.0 - The 1.13 Release Dec 24, 2018

Banbeucmas added 2 commits March 23, 2018 11:47

Merge pull request#1from EssentialsX/2.x
b535198
Update

Adding EssentialsWarpEvent for checking if player is wrapping
0dda123

Dolphin2Point1 approved these changes Mar 24, 2018
View reviewed changes

mdcfe reviewed Mar 24, 2018
View reviewed changes

Spacing
d6af21c

Banbeucmas commented Mar 24, 2018
View reviewed changes

Adding Trade parameter
aadcd82

mdcfe added the type: enhancement Features and feature requests. label Mar 24, 2018

Banbeucmas added 2 commits March 25, 2018 00:20

Refactoring
5176f3c

Adding #setWarp() to the Event
5713538

mdcfe reviewed Mar 25, 2018
View reviewed changes

drtshock reviewed Mar 26, 2018
View reviewed changes

Banbeucmas added 2 commits March 26, 2018 19:19

Spacing
0714f53

Documenting the purpose of the Event
e66e636

mdcfe added this to the 2.16.0 milestone Mar 30, 2018

Banbeucmas added 2 commits April 1, 2018 15:54

Merge branch '2.x' ofhttps://github.com/EssentialsX/Essentialsinto 2.x
5105120

Javadoc?
6a24350

mdcfe mentioned this pull request May 20, 2018
Adding Placeholder API Compability internally [WIP] #1944
Closed

mdcfe mentioned this pull request Jun 14, 2018
Add PlaceholderAPI support #2041
Closed
6 tasks

mdcfe approved these changes Oct 28, 2018
View reviewed changes

mdcfe changed the base branch from 2.x to 1.13October 28, 2018 18:53

mdcfe merged commit 280d121 into EssentialsX:1.13Oct 28, 2018

mdcfe modified the milestones: 2.17.0 (future), 2.16.0 - The 1.13 Release Dec 24, 2018

Banbeucmas added 2 commits March 23, 2018 11:47

Merge pull request#1from EssentialsX/2.x
b535198
Update

Adding EssentialsWarpEvent for checking if player is wrapping
0dda123

Dolphin2Point1 approved these changes Mar 24, 2018
View reviewed changes

mdcfe reviewed Mar 24, 2018
View reviewed changes

Spacing
d6af21c

Banbeucmas commented Mar 24, 2018
View reviewed changes

Adding Trade parameter
aadcd82

mdcfe added the type: enhancement Features and feature requests. label Mar 24, 2018

Banbeucmas added 2 commits March 25, 2018 00:20

Refactoring
5176f3c

Adding #setWarp() to the Event
5713538

mdcfe reviewed Mar 25, 2018
View reviewed changes

drtshock reviewed Mar 26, 2018
View reviewed changes

Banbeucmas added 2 commits March 26, 2018 19:19

Spacing
0714f53

Documenting the purpose of the Event
e66e636

mdcfe added this to the 2.16.0 milestone Mar 30, 2018

Banbeucmas added 2 commits April 1, 2018 15:54

Merge branch '2.x' ofhttps://github.com/EssentialsX/Essentialsinto 2.x
5105120

Javadoc?
6a24350

mdcfe mentioned this pull request May 20, 2018
Adding Placeholder API Compability internally [WIP] #1944
Closed

mdcfe mentioned this pull request Jun 14, 2018
Add PlaceholderAPI support #2041
Closed
6 tasks

mdcfe approved these changes Oct 28, 2018
View reviewed changes

mdcfe changed the base branch from 2.x to 1.13October 28, 2018 18:53

mdcfe merged commit 280d121 into EssentialsX:1.13Oct 28, 2018

mdcfe modified the milestones: 2.17.0 (future), 2.16.0 - The 1.13 Release Dec 24, 2018

Banbeucmas added 2 commits March 23, 2018 11:47

Merge pull request#1from EssentialsX/2.x
b535198
Update

Adding EssentialsWarpEvent for checking if player is wrapping
0dda123

Dolphin2Point1 approved these changes Mar 24, 2018
View reviewed changes

mdcfe reviewed Mar 24, 2018
View reviewed changes

Spacing
d6af21c

Banbeucmas commented Mar 24, 2018
View reviewed changes

Adding Trade parameter
aadcd82

mdcfe added the type: enhancement Features and feature requests. label Mar 24, 2018

Banbeucmas added 2 commits March 25, 2018 00:20

Refactoring
5176f3c

Adding #setWarp() to the Event
5713538

mdcfe reviewed Mar 25, 2018
View reviewed changes

drtshock reviewed Mar 26, 2018
View reviewed changes

Banbeucmas added 2 commits March 26, 2018 19:19

Spacing
0714f53

Documenting the purpose of the Event
e66e636

mdcfe added this to the 2.16.0 milestone Mar 30, 2018

Banbeucmas added 2 commits April 1, 2018 15:54

Merge branch '2.x' ofhttps://github.com/EssentialsX/Essentialsinto 2.x
5105120

Javadoc?
6a24350

mdcfe mentioned this pull request May 20, 2018
Adding Placeholder API Compability internally [WIP] #1944
Closed

mdcfe mentioned this pull request Jun 14, 2018
Add PlaceholderAPI support #2041
Closed
6 tasks

mdcfe approved these changes Oct 28, 2018
View reviewed changes

mdcfe changed the base branch from 2.x to 1.13October 28, 2018 18:53

mdcfe merged commit 280d121 into EssentialsX:1.13Oct 28, 2018

mdcfe modified the milestones: 2.17.0 (future), 2.16.0 - The 1.13 Release Dec 24, 2018

Banbeucmas added 2 commits March 23, 2018 11:47

Merge pull request#1from EssentialsX/2.x
b535198
Update

Adding EssentialsWarpEvent for checking if player is wrapping
0dda123

Dolphin2Point1 approved these changes Mar 24, 2018
View reviewed changes

mdcfe reviewed Mar 24, 2018
View reviewed changes

Spacing
d6af21c

Banbeucmas commented Mar 24, 2018
View reviewed changes

Adding Trade parameter
aadcd82

mdcfe added the type: enhancement Features and feature requests. label Mar 24, 2018

Banbeucmas added 2 commits March 25, 2018 00:20

Refactoring
5176f3c

Adding #setWarp() to the Event
5713538

mdcfe reviewed Mar 25, 2018
View reviewed changes

drtshock reviewed Mar 26, 2018
View reviewed changes

Banbeucmas added 2 commits March 26, 2018 19:19

Spacing
0714f53

Documenting the purpose of the Event
e66e636

mdcfe added this to the 2.16.0 milestone Mar 30, 2018

Banbeucmas added 2 commits April 1, 2018 15:54

Merge branch '2.x' ofhttps://github.com/EssentialsX/Essentialsinto 2.x
5105120

Javadoc?
6a24350

mdcfe mentioned this pull request May 20, 2018
Adding Placeholder API Compability internally [WIP] #1944
Closed

mdcfe mentioned this pull request Jun 14, 2018
Add PlaceholderAPI support #2041
Closed
6 tasks

mdcfe approved these changes Oct 28, 2018
View reviewed changes

mdcfe changed the base branch from 2.x to 1.13October 28, 2018 18:53

mdcfe merged commit 280d121 into EssentialsX:1.13Oct 28, 2018

mdcfe modified the milestones: 2.17.0 (future), 2.16.0 - The 1.13 Release Dec 24, 2018

Banbeucmas added 2 commits March 23, 2018 11:47

Merge pull request#1from EssentialsX/2.x
b535198
Update

Adding EssentialsWarpEvent for checking if player is wrapping
0dda123

Dolphin2Point1 approved these changes Mar 24, 2018
View reviewed changes

mdcfe reviewed Mar 24, 2018
View reviewed changes

Spacing
d6af21c

Banbeucmas commented Mar 24, 2018
View reviewed changes

Adding Trade parameter
aadcd82

mdcfe added the type: enhancement Features and feature requests. label Mar 24, 2018

Banbeucmas added 2 commits March 25, 2018 00:20

Refactoring
5176f3c

Adding #setWarp() to the Event
5713538

mdcfe reviewed Mar 25, 2018
View reviewed changes

drtshock reviewed Mar 26, 2018
View reviewed changes

Banbeucmas added 2 commits March 26, 2018 19:19

Spacing
0714f53

Documenting the purpose of the Event
e66e636

mdcfe added this to the 2.16.0 milestone Mar 30, 2018

Banbeucmas added 2 commits April 1, 2018 15:54

Merge branch '2.x' ofhttps://github.com/EssentialsX/Essentialsinto 2.x
5105120

Javadoc?
6a24350

mdcfe mentioned this pull request May 20, 2018
Adding Placeholder API Compability internally [WIP] #1944
Closed

mdcfe mentioned this pull request Jun 14, 2018
Add PlaceholderAPI support #2041
Closed
6 tasks

mdcfe approved these changes Oct 28, 2018
View reviewed changes

mdcfe changed the base branch from 2.x to 1.13October 28, 2018 18:53

mdcfe merged commit 280d121 into EssentialsX:1.13Oct 28, 2018

mdcfe modified the milestones: 2.17.0 (future), 2.16.0 - The 1.13 Release Dec 24, 2018

Banbeucmas added 2 commits March 23, 2018 11:47

Merge pull request#1from EssentialsX/2.x
b535198
Update

Adding EssentialsWarpEvent for checking if player is wrapping
0dda123

Dolphin2Point1 approved these changes Mar 24, 2018
View reviewed changes

mdcfe reviewed Mar 24, 2018
View reviewed changes

Spacing
d6af21c

Banbeucmas commented Mar 24, 2018
View reviewed changes

Adding Trade parameter
aadcd82

mdcfe added the type: enhancement Features and feature requests. label Mar 24, 2018

Banbeucmas added 2 commits March 25, 2018 00:20

Refactoring
5176f3c

Adding #setWarp() to the Event
5713538

mdcfe reviewed Mar 25, 2018
View reviewed changes

drtshock reviewed Mar 26, 2018
View reviewed changes

Banbeucmas added 2 commits March 26, 2018 19:19

Spacing
0714f53

Documenting the purpose of the Event
e66e636

mdcfe added this to the 2.16.0 milestone Mar 30, 2018

Banbeucmas added 2 commits April 1, 2018 15:54

Merge branch '2.x' ofhttps://github.com/EssentialsX/Essentialsinto 2.x
5105120

Javadoc?
6a24350

mdcfe mentioned this pull request May 20, 2018
Adding Placeholder API Compability internally [WIP] #1944
Closed

mdcfe mentioned this pull request Jun 14, 2018
Add PlaceholderAPI support #2041
Closed
6 tasks

mdcfe approved these changes Oct 28, 2018
View reviewed changes

mdcfe changed the base branch from 2.x to 1.13October 28, 2018 18:53

mdcfe merged commit 280d121 into EssentialsX:1.13Oct 28, 2018

mdcfe modified the milestones: 2.17.0 (future), 2.16.0 - The 1.13 Release Dec 24, 2018

Banbeucmas added 2 commits March 23, 2018 11:47

Merge pull request#1from EssentialsX/2.x
b535198
Update

Adding EssentialsWarpEvent for checking if player is wrapping
0dda123

Dolphin2Point1 approved these changes Mar 24, 2018
View reviewed changes

mdcfe reviewed Mar 24, 2018
View reviewed changes

Spacing
d6af21c

Banbeucmas commented Mar 24, 2018
View reviewed changes

Adding Trade parameter
aadcd82

mdcfe added the type: enhancement Features and feature requests. label Mar 24, 2018

Banbeucmas added 2 commits March 25, 2018 00:20

Refactoring
5176f3c

Adding #setWarp() to the Event
5713538

mdcfe reviewed Mar 25, 2018
View reviewed changes

drtshock reviewed Mar 26, 2018
View reviewed changes

Banbeucmas added 2 commits March 26, 2018 19:19

Spacing
0714f53

Documenting the purpose of the Event
e66e636

mdcfe added this to the 2.16.0 milestone Mar 30, 2018

Banbeucmas added 2 commits April 1, 2018 15:54

Merge branch '2.x' ofhttps://github.com/EssentialsX/Essentialsinto 2.x
5105120

Javadoc?
6a24350

mdcfe mentioned this pull request May 20, 2018
Adding Placeholder API Compability internally [WIP] #1944
Closed

mdcfe mentioned this pull request Jun 14, 2018
Add PlaceholderAPI support #2041
Closed
6 tasks

mdcfe approved these changes Oct 28, 2018
View reviewed changes

mdcfe changed the base branch from 2.x to 1.13October 28, 2018 18:53

mdcfe merged commit 280d121 into EssentialsX:1.13Oct 28, 2018

mdcfe modified the milestones: 2.17.0 (future), 2.16.0 - The 1.13 Release Dec 24, 2018

Uh oh!

Uh oh!

Conversation

Banbeucmas commented Mar 24, 2018

Uh oh!

Dolphin2Point1 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdcfe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdcfe commented Mar 24, 2018

Uh oh!

Banbeucmas commented Mar 24, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Banbeucmas commented Mar 26, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdcfe commented Oct 28, 2018

Uh oh!

Banbeucmas commented Oct 29, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

Banbeucmas commented Mar 24, 2018

Uh oh!

Dolphin2Point1 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdcfe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdcfe commented Mar 24, 2018

Uh oh!

Banbeucmas commented Mar 24, 2018

Uh oh!

Choose a reason for hiding this comment

Dolphin2Point1 left a comment •
edited
Loading

Banbeucmas commented Mar 26, 2018•
edited
Loading

Dolphin2Point1 left a comment •
edited
Loading

Banbeucmas commented Mar 26, 2018•
edited
Loading

Dolphin2Point1 left a comment •
edited
Loading