Uh oh!
There was an error while loading. Please reload this page.
Adding Placeholder API Compability internally [WIP] - #1944
Conversation
Banbeucmas
commented
Apr 1, 2018
Yep it fucked up |
Banbeucmas
commented
Apr 1, 2018
A little note: |
Banbeucmas
commented
Apr 1, 2018
As for registering our own placeholder, https://github.com/PlaceholderAPI/Essentials-Expansion is already here, I think it is better to just continue to contribute there rather than putting them internally onto Essentials |
Banbeucmas
commented
Apr 3, 2018
Not sure if this is necessary - thoughts?
This will need to be manually changed everywhere `tl` is used where placeholders may be expected.
Banbeucmas
commented
Apr 3, 2018
Nice one. |
Banbeucmas
left a comment
There was a problem hiding this comment.
plugin.yml might need some work
| website: http://tiny.cc/EssentialsCommands | ||
| description: Provides an essential, core set of commands for Bukkit. | ||
| softdepend: [Vault] | ||
| softdepend: [Vault, PlaceholderAPI] |
There was a problem hiding this comment.
#1945
You once said you don't want to add it as sofedepend.
Will we remove this?
There was a problem hiding this comment.
Oops, forgot about that. Still need to implement handling of PAPI loading after EssentialsX though before we do that.
There was a problem hiding this comment.
I will leave that part to you then :)
Banbeucmas
left a comment
There was a problem hiding this comment.
Was aware of this tho
| return null; | ||
| } | ||
| input = input.replaceAll("\\{|\\}", "%"); |
There was a problem hiding this comment.
There might be some problem that a single { standing alone will become % after that. I don't use regex for a long time. Should we do something about it.
There was a problem hiding this comment.
Still need to address this.
There was a problem hiding this comment.
I think the replacement with that regex would have been "%$1%", since the ()s in the regex capture the placeholder name (bobsplugin_hunger) and the $1 puts it back in the string once replaced.
There was a problem hiding this comment.
I love how the problem still excist tho. Idk why but seem like Java Regex behaves different than JS
| input = input.replaceAll("\\{|\\}", "%"); | ||
| if (papiEnabled == null) { |
There was a problem hiding this comment.
This still needs to be here, in case PAPI loads before EssentialsX - in that instance, Essentials won't receive PAPI's PluginEnableEvent.
There was a problem hiding this comment.
That is also the reason for the null - at the point that the class is loaded, we won't know whether PAPI is enabled, and it also might not be a safe time to check.
There was a problem hiding this comment.
Ah, that make sense. Let me change that
| //The warp function is a wrapper used to teleportPlayer a player to a /warp | ||
| @Override | ||
| public void warp(IUser teleportee, String warp, Trade chargeFor, TeleportCause cause) throws Exception { | ||
| UserWarpEvent event = new UserWarpEvent(teleportee, warp, chargeFor); |
There was a problem hiding this comment.
Not sure why this change is in this PR but the actual PR is here.
There was a problem hiding this comment.
Yeah, I accidentally create the Papi branch out of the original branch of my fork and PR before even realize it.
We will just solve both PR at the same time or if anyone have a better idea.
Banbeucmas
commented
Aug 12, 2018
Should we close this in favor of #2041? |
mdcfe
commented
Aug 19, 2018
@Banbeucmas Yes, closing this PR now. |
Pretty sure I want this to be an enhancement in 2.16.0
Still WIP tho.
Just that the placeholder seem to work flawlessly with PlaceholderAPI 2.8.5 tested
I hope my pr didn't fucked up lol. Haven't try to merge specific branch yet